Creation of components through MLContext, internalization, and renaming - #2510

Merged
artidoro merged 7 commits into
dotnet:masterfrom
artidoro:estimatortransformer
Feb 13, 2019
Merged

Creation of components through MLContext, internalization, and renaming#2510
artidoro merged 7 commits into
dotnet:masterfrom
artidoro:estimatortransformer

Conversation

@artidoro

@artidoroartidoro commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

Fixes#1798, #1758

  1. In this PR I internalize the constructors of DnnImageFeaturizerEstimator, PriorTrainer, and RandomTrainer. This required to add catalog extensions for these three trainers. Internalizing these constructor closes issue Creation of components through MLContext: advanced options and other feedback #1798.
  2. I also rename a few instances of Arguments to Options which closes issue Arguments class should be made internal when possible #1758.
  3. I internalized some fields across ITransformers and IEstimators.
  4. I also moved the Options class in TensorflowTransform to the estimator.

@artidoroartidoro self-assigned this Feb 12, 2019
@artidoroartidoro added the API Issues pertaining the friendly API label Feb 12, 2019
Ivanidzo4ka
Ivanidzo4ka reviewed Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.Transforms/CustomMappingTransformer.cs
/// <param name="inputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TSrc"/> and input data.</param>
/// <param name="outputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TDst"/> and output data.</param>
public CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
internal CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,

@Ivanidzo4kaIvanidzo4kaFeb 12, 2019•
edited by artidoro
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomMappingEstimator [](start = 17, length = 22)

We don't have any samples/ tests with it at all? #Resolved

@artidoroartidoroFeb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding a sample now.

In reply to: 255816087 [](ancestors = 255816087)

@Ivanidzo4ka

Ivanidzo4ka commented Feb 12, 2019•
edited by artidoro
Loading

Copy link
Copy Markdown
Contributor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

you used to add summary comments in previous PRs #Resolved

Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)

@Ivanidzo4ka

Ivanidzo4ka commented Feb 12, 2019•
edited by artidoro
Loading

Copy link
Copy Markdown
Contributor
 public RandomModelParameters(IHostEnvironment env, int seed)

I think we trying to close our current predictors till 1.0 #Resolved

Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)

@Ivanidzo4ka

Ivanidzo4ka commented Feb 12, 2019•
edited by artidoro
Loading

Copy link
Copy Markdown
Contributor
 public PriorModelParameters(IHostEnvironment env, float prob)

internal? #Resolved

Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)

Ivanidzo4ka
Ivanidzo4ka approved these changes Feb 12, 2019
View reviewed changes

@Ivanidzo4kaIvanidzo4ka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@abgoswam

abgoswam commented Feb 12, 2019

Copy link
Copy Markdown
Member

// Licensed to the .NET Foundation under one or more agreements.

no changes in this file.

Refers to: src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs:1 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = True)

abgoswam
abgoswam reviewed Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.OnnxTransform/OnnxCatalog.cs
abgoswam
abgoswam reviewed Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs Outdated
abgoswam
abgoswam reviewed Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
@artidoro

artidoro commented Feb 12, 2019

Copy link
Copy Markdown
ContributorAuthor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

Yes you are right let me do that.

In reply to: 462631911 [](ancestors = 462631911)

Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)

@artidoro

artidoro commented Feb 12, 2019

Copy link
Copy Markdown
ContributorAuthor
 public RandomModelParameters(IHostEnvironment env, int seed)

Ok will make this internal thank you!

In reply to: 462635433 [](ancestors = 462635433)

Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)

@artidoro

artidoro commented Feb 12, 2019

Copy link
Copy Markdown
ContributorAuthor
 public PriorModelParameters(IHostEnvironment env, float prob)

Thank you!

In reply to: 462635562 [](ancestors = 462635562)

Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)

@sfilipisfilipi mentioned this pull request Feb 13, 2019
Closed
@shmoradimsshmoradims mentioned this pull request Feb 13, 2019
Closed
abgoswam
abgoswam reviewed Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs
abgoswam
abgoswam reviewed Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/PriorTrainerSample.cs
abgoswam
abgoswam approved these changes Feb 13, 2019
View reviewed changes

@abgoswamabgoswam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@artidoro
artidoro merged commit f8e58dd into dotnet:masterFeb 13, 2019
@codecov

codecovBot commented Feb 13, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2510 into master will increase coverage by <.01%.
The diff coverage is 97.82%.

@@ Coverage Diff @@## master #2510 +/- ##
==========================================
+ Coverage 71.25% 71.25% +<.01% 
==========================================
Files 797 797 Lines 141271 141280 +9 Branches 16115 16115 ==========================================
+ Hits 100663 100671 +8 - Misses 36148 36149 +1 
Partials 4460 4460
FlagCoverage Δ
#Debug71.25% <97.82%> (ø)⬆️
#production67.58% <97.43%> (ø)⬆️
#test85.36% <100%> (ø)⬆️

Ivanidzo4ka
Ivanidzo4ka reviewed Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs

namespace Microsoft.ML.Samples.Dynamic
{
public class RandomTrainerSample

@Ivanidzo4kaIvanidzo4kaFeb 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RandomTrainerSample [](start = 17, length = 19)

Zeeshan A, Shahab and me have PRs where we create BinaryClassification folder.
Any chance you can move this two to that folder?

@ghostghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfilipisfilipiAwaiting requested review from sfilipi
@zeahmedzeahmedAwaiting requested review from zeahmed
@wschinwschinAwaiting requested review from wschin
2 more reviewers
@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@abgoswamabgoswamabgoswam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@artidoroartidoro

Labels

APIIssues pertaining the friendly API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creation of components through MLContext: advanced options and other feedback

3 participants

@artidoro@Ivanidzo4ka@abgoswam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Creation of components through MLContext, internalization, and renaming - #2510
Merged
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Feb 13, 2019
Merged
Creation of components through MLContext, internalization, and renaming#2510
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Conversation
@artidoro
@artidoroartidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

Contributor
Fixes#1798, #1758
  1. In this PR I internalize the constructors of DnnImageFeaturizerEstimator, PriorTrainer, and RandomTrainer. This required to add catalog extensions for these three trainers. Internalizing these constructor closes issue Creation of components through MLContext: advanced options and other feedback #1798.
  2. I also rename a few instances of Arguments to Options which closes issue Arguments class should be made internal when possible #1758.
  3. I internalized some fields across ITransformers and IEstimators.
  4. I also moved the Options class in TensorflowTransform to the estimator.
@artidoroartidoro
self-assigned this
Feb 12, 2019
@artidoroartidoro
added
the 
API
Issues pertaining the friendly API
label
Feb 12, 2019
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.Transforms/CustomMappingTransformer.cs
 /// <param name="inputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TSrc"/> and input data.</param>
 /// <param name="outputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TDst"/> and output data.</param>
public CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
internal CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
@Ivanidzo4kaIvanidzo4kaFeb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomMappingEstimator [](start = 17, length = 22)
We don't have any samples/ tests with it at all? #Resolved
@artidoroartidoroFeb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding a sample now.
In reply to: 255816087 [](ancestors = 255816087)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

you used to add summary comments in previous PRs #Resolved
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public RandomModelParameters(IHostEnvironment env, int seed)

I think we trying to close our current predictors till 1.0 #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public PriorModelParameters(IHostEnvironment env, float prob)

internal? #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Feb 12, 2019
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@abgoswam
abgoswam
commented
Feb 12, 2019

Copy link


Copy Markdown

Member
// Licensed to the .NET Foundation under one or more agreements.
no changes in this file.
Refers to: src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs:1 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = True)
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.OnnxTransform/OnnxCatalog.cs
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
Outdated

abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

Yes you are right let me do that.
In reply to: 462631911 [](ancestors = 462631911)
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public RandomModelParameters(IHostEnvironment env, int seed)

Ok will make this internal thank you!
In reply to: 462635433 [](ancestors = 462635433)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public PriorModelParameters(IHostEnvironment env, float prob)

Thank you!
In reply to: 462635562 [](ancestors = 462635562)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@sfilipisfilipi
mentioned this pull request
Feb 13, 2019

Closed

@shmoradimsshmoradims
mentioned this pull request
Feb 13, 2019

Closed

abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs
abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/PriorTrainerSample.cs
abgoswam
abgoswam
approved these changes
Feb 13, 2019
View reviewed changes
@abgoswamabgoswam
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@artidoro
artidoro
merged commit f8e58dd
into
dotnet:masterFeb 13, 2019
@codecov
codecovBot
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2510 into master will increase coverage by <.01%.

The diff coverage is 97.82%.
@@ Coverage Diff @@## master #2510 +/- ##
==========================================
+ Coverage 71.25% 71.25% +<.01% 
==========================================
Files 797 797 Lines 141271 141280 +9 Branches 16115 16115 ==========================================
+ Hits 100663 100671 +8 - Misses 36148 36149 +1 
Partials 4460 4460
FlagCoverage Δ
#Debug71.25% <97.82%> (ø)⬆️
#production67.58% <97.43%> (ø)⬆️
#test85.36% <100%> (ø)⬆️
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs

namespace Microsoft.ML.Samples.Dynamic
{
 public class RandomTrainerSample
@Ivanidzo4kaIvanidzo4kaFeb 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RandomTrainerSample [](start = 17, length = 19)
Zeeshan A, Shahab and me have PRs where we create BinaryClassification folder.

Any chance you can move this two to that folder?
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sfilipisfilipiAwaiting requested review from sfilipi
@zeahmedzeahmedAwaiting requested review from zeahmed
@wschinwschinAwaiting requested review from wschin

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@abgoswamabgoswamabgoswam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@artidoroartidoro

Labels

APIIssues pertaining the friendly API

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Creation of components through MLContext: advanced options and other feedback


3 participants

@artidoro@Ivanidzo4ka@abgoswam

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Creation of components through MLContext, internalization, and renaming - #2510
Merged
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Feb 13, 2019
Merged
Creation of components through MLContext, internalization, and renaming#2510
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Conversation
@artidoro
@artidoroartidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

Contributor
Fixes#1798, #1758
  1. In this PR I internalize the constructors of DnnImageFeaturizerEstimator, PriorTrainer, and RandomTrainer. This required to add catalog extensions for these three trainers. Internalizing these constructor closes issue Creation of components through MLContext: advanced options and other feedback #1798.
  2. I also rename a few instances of Arguments to Options which closes issue Arguments class should be made internal when possible #1758.
  3. I internalized some fields across ITransformers and IEstimators.
  4. I also moved the Options class in TensorflowTransform to the estimator.
@artidoroartidoro
self-assigned this
Feb 12, 2019
@artidoroartidoro
added
the 
API
Issues pertaining the friendly API
label
Feb 12, 2019
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.Transforms/CustomMappingTransformer.cs
 /// <param name="inputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TSrc"/> and input data.</param>
 /// <param name="outputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TDst"/> and output data.</param>
public CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
internal CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
@Ivanidzo4kaIvanidzo4kaFeb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomMappingEstimator [](start = 17, length = 22)
We don't have any samples/ tests with it at all? #Resolved
@artidoroartidoroFeb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding a sample now.
In reply to: 255816087 [](ancestors = 255816087)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

you used to add summary comments in previous PRs #Resolved
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public RandomModelParameters(IHostEnvironment env, int seed)

I think we trying to close our current predictors till 1.0 #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public PriorModelParameters(IHostEnvironment env, float prob)

internal? #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Feb 12, 2019
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@abgoswam
abgoswam
commented
Feb 12, 2019

Copy link


Copy Markdown

Member
// Licensed to the .NET Foundation under one or more agreements.
no changes in this file.
Refers to: src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs:1 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = True)
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.OnnxTransform/OnnxCatalog.cs
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
Outdated

abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

Yes you are right let me do that.
In reply to: 462631911 [](ancestors = 462631911)
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public RandomModelParameters(IHostEnvironment env, int seed)

Ok will make this internal thank you!
In reply to: 462635433 [](ancestors = 462635433)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public PriorModelParameters(IHostEnvironment env, float prob)

Thank you!
In reply to: 462635562 [](ancestors = 462635562)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@sfilipisfilipi
mentioned this pull request
Feb 13, 2019

Closed

@shmoradimsshmoradims
mentioned this pull request
Feb 13, 2019

Closed

abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs
abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/PriorTrainerSample.cs
abgoswam
abgoswam
approved these changes
Feb 13, 2019
View reviewed changes
@abgoswamabgoswam
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@artidoro
artidoro
merged commit f8e58dd
into
dotnet:masterFeb 13, 2019
@codecov
codecovBot
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2510 into master will increase coverage by <.01%.

The diff coverage is 97.82%.
@@ Coverage Diff @@## master #2510 +/- ##
==========================================
+ Coverage 71.25% 71.25% +<.01% 
==========================================
Files 797 797 Lines 141271 141280 +9 Branches 16115 16115 ==========================================
+ Hits 100663 100671 +8 - Misses 36148 36149 +1 
Partials 4460 4460
FlagCoverage Δ
#Debug71.25% <97.82%> (ø)⬆️
#production67.58% <97.43%> (ø)⬆️
#test85.36% <100%> (ø)⬆️
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs

namespace Microsoft.ML.Samples.Dynamic
{
 public class RandomTrainerSample
@Ivanidzo4kaIvanidzo4kaFeb 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RandomTrainerSample [](start = 17, length = 19)
Zeeshan A, Shahab and me have PRs where we create BinaryClassification folder.

Any chance you can move this two to that folder?
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sfilipisfilipiAwaiting requested review from sfilipi
@zeahmedzeahmedAwaiting requested review from zeahmed
@wschinwschinAwaiting requested review from wschin

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@abgoswamabgoswamabgoswam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@artidoroartidoro

Labels

APIIssues pertaining the friendly API

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Creation of components through MLContext: advanced options and other feedback


3 participants

@artidoro@Ivanidzo4ka@abgoswam

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Creation of components through MLContext, internalization, and renaming - #2510
Merged
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Feb 13, 2019
Merged
Creation of components through MLContext, internalization, and renaming#2510
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Conversation
@artidoro
@artidoroartidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

Contributor
Fixes#1798, #1758
  1. In this PR I internalize the constructors of DnnImageFeaturizerEstimator, PriorTrainer, and RandomTrainer. This required to add catalog extensions for these three trainers. Internalizing these constructor closes issue Creation of components through MLContext: advanced options and other feedback #1798.
  2. I also rename a few instances of Arguments to Options which closes issue Arguments class should be made internal when possible #1758.
  3. I internalized some fields across ITransformers and IEstimators.
  4. I also moved the Options class in TensorflowTransform to the estimator.
@artidoroartidoro
self-assigned this
Feb 12, 2019
@artidoroartidoro
added
the 
API
Issues pertaining the friendly API
label
Feb 12, 2019
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.Transforms/CustomMappingTransformer.cs
 /// <param name="inputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TSrc"/> and input data.</param>
 /// <param name="outputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TDst"/> and output data.</param>
public CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
internal CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
@Ivanidzo4kaIvanidzo4kaFeb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomMappingEstimator [](start = 17, length = 22)
We don't have any samples/ tests with it at all? #Resolved
@artidoroartidoroFeb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding a sample now.
In reply to: 255816087 [](ancestors = 255816087)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

you used to add summary comments in previous PRs #Resolved
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public RandomModelParameters(IHostEnvironment env, int seed)

I think we trying to close our current predictors till 1.0 #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public PriorModelParameters(IHostEnvironment env, float prob)

internal? #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Feb 12, 2019
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@abgoswam
abgoswam
commented
Feb 12, 2019

Copy link


Copy Markdown

Member
// Licensed to the .NET Foundation under one or more agreements.
no changes in this file.
Refers to: src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs:1 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = True)
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.OnnxTransform/OnnxCatalog.cs
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
Outdated

abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

Yes you are right let me do that.
In reply to: 462631911 [](ancestors = 462631911)
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public RandomModelParameters(IHostEnvironment env, int seed)

Ok will make this internal thank you!
In reply to: 462635433 [](ancestors = 462635433)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public PriorModelParameters(IHostEnvironment env, float prob)

Thank you!
In reply to: 462635562 [](ancestors = 462635562)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@sfilipisfilipi
mentioned this pull request
Feb 13, 2019

Closed

@shmoradimsshmoradims
mentioned this pull request
Feb 13, 2019

Closed

abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs
abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/PriorTrainerSample.cs
abgoswam
abgoswam
approved these changes
Feb 13, 2019
View reviewed changes
@abgoswamabgoswam
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@artidoro
artidoro
merged commit f8e58dd
into
dotnet:masterFeb 13, 2019
@codecov
codecovBot
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2510 into master will increase coverage by <.01%.

The diff coverage is 97.82%.
@@ Coverage Diff @@## master #2510 +/- ##
==========================================
+ Coverage 71.25% 71.25% +<.01% 
==========================================
Files 797 797 Lines 141271 141280 +9 Branches 16115 16115 ==========================================
+ Hits 100663 100671 +8 - Misses 36148 36149 +1 
Partials 4460 4460
FlagCoverage Δ
#Debug71.25% <97.82%> (ø)⬆️
#production67.58% <97.43%> (ø)⬆️
#test85.36% <100%> (ø)⬆️
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs

namespace Microsoft.ML.Samples.Dynamic
{
 public class RandomTrainerSample
@Ivanidzo4kaIvanidzo4kaFeb 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RandomTrainerSample [](start = 17, length = 19)
Zeeshan A, Shahab and me have PRs where we create BinaryClassification folder.

Any chance you can move this two to that folder?
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sfilipisfilipiAwaiting requested review from sfilipi
@zeahmedzeahmedAwaiting requested review from zeahmed
@wschinwschinAwaiting requested review from wschin

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@abgoswamabgoswamabgoswam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@artidoroartidoro

Labels

APIIssues pertaining the friendly API

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Creation of components through MLContext: advanced options and other feedback


3 participants

@artidoro@Ivanidzo4ka@abgoswam

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Creation of components through MLContext, internalization, and renaming - #2510
Merged
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Feb 13, 2019
Merged
Creation of components through MLContext, internalization, and renaming#2510
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Conversation
@artidoro
@artidoroartidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

Contributor
Fixes#1798, #1758
  1. In this PR I internalize the constructors of DnnImageFeaturizerEstimator, PriorTrainer, and RandomTrainer. This required to add catalog extensions for these three trainers. Internalizing these constructor closes issue Creation of components through MLContext: advanced options and other feedback #1798.
  2. I also rename a few instances of Arguments to Options which closes issue Arguments class should be made internal when possible #1758.
  3. I internalized some fields across ITransformers and IEstimators.
  4. I also moved the Options class in TensorflowTransform to the estimator.
@artidoroartidoro
self-assigned this
Feb 12, 2019
@artidoroartidoro
added
the 
API
Issues pertaining the friendly API
label
Feb 12, 2019
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.Transforms/CustomMappingTransformer.cs
 /// <param name="inputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TSrc"/> and input data.</param>
 /// <param name="outputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TDst"/> and output data.</param>
public CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
internal CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
@Ivanidzo4kaIvanidzo4kaFeb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomMappingEstimator [](start = 17, length = 22)
We don't have any samples/ tests with it at all? #Resolved
@artidoroartidoroFeb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding a sample now.
In reply to: 255816087 [](ancestors = 255816087)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

you used to add summary comments in previous PRs #Resolved
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public RandomModelParameters(IHostEnvironment env, int seed)

I think we trying to close our current predictors till 1.0 #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public PriorModelParameters(IHostEnvironment env, float prob)

internal? #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Feb 12, 2019
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@abgoswam
abgoswam
commented
Feb 12, 2019

Copy link


Copy Markdown

Member
// Licensed to the .NET Foundation under one or more agreements.
no changes in this file.
Refers to: src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs:1 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = True)
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.OnnxTransform/OnnxCatalog.cs
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
Outdated

abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

Yes you are right let me do that.
In reply to: 462631911 [](ancestors = 462631911)
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public RandomModelParameters(IHostEnvironment env, int seed)

Ok will make this internal thank you!
In reply to: 462635433 [](ancestors = 462635433)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public PriorModelParameters(IHostEnvironment env, float prob)

Thank you!
In reply to: 462635562 [](ancestors = 462635562)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@sfilipisfilipi
mentioned this pull request
Feb 13, 2019

Closed

@shmoradimsshmoradims
mentioned this pull request
Feb 13, 2019

Closed

abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs
abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/PriorTrainerSample.cs
abgoswam
abgoswam
approved these changes
Feb 13, 2019
View reviewed changes
@abgoswamabgoswam
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@artidoro
artidoro
merged commit f8e58dd
into
dotnet:masterFeb 13, 2019
@codecov
codecovBot
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2510 into master will increase coverage by <.01%.

The diff coverage is 97.82%.
@@ Coverage Diff @@## master #2510 +/- ##
==========================================
+ Coverage 71.25% 71.25% +<.01% 
==========================================
Files 797 797 Lines 141271 141280 +9 Branches 16115 16115 ==========================================
+ Hits 100663 100671 +8 - Misses 36148 36149 +1 
Partials 4460 4460
FlagCoverage Δ
#Debug71.25% <97.82%> (ø)⬆️
#production67.58% <97.43%> (ø)⬆️
#test85.36% <100%> (ø)⬆️
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs

namespace Microsoft.ML.Samples.Dynamic
{
 public class RandomTrainerSample
@Ivanidzo4kaIvanidzo4kaFeb 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RandomTrainerSample [](start = 17, length = 19)
Zeeshan A, Shahab and me have PRs where we create BinaryClassification folder.

Any chance you can move this two to that folder?
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sfilipisfilipiAwaiting requested review from sfilipi
@zeahmedzeahmedAwaiting requested review from zeahmed
@wschinwschinAwaiting requested review from wschin

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@abgoswamabgoswamabgoswam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@artidoroartidoro

Labels

APIIssues pertaining the friendly API

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Creation of components through MLContext: advanced options and other feedback


3 participants

@artidoro@Ivanidzo4ka@abgoswam

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Creation of components through MLContext, internalization, and renaming - #2510
Merged
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Feb 13, 2019
Merged
Creation of components through MLContext, internalization, and renaming#2510
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Conversation
@artidoro
@artidoroartidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

Contributor
Fixes#1798, #1758
  1. In this PR I internalize the constructors of DnnImageFeaturizerEstimator, PriorTrainer, and RandomTrainer. This required to add catalog extensions for these three trainers. Internalizing these constructor closes issue Creation of components through MLContext: advanced options and other feedback #1798.
  2. I also rename a few instances of Arguments to Options which closes issue Arguments class should be made internal when possible #1758.
  3. I internalized some fields across ITransformers and IEstimators.
  4. I also moved the Options class in TensorflowTransform to the estimator.
@artidoroartidoro
self-assigned this
Feb 12, 2019
@artidoroartidoro
added
the 
API
Issues pertaining the friendly API
label
Feb 12, 2019
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.Transforms/CustomMappingTransformer.cs
 /// <param name="inputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TSrc"/> and input data.</param>
 /// <param name="outputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TDst"/> and output data.</param>
public CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
internal CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
@Ivanidzo4kaIvanidzo4kaFeb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomMappingEstimator [](start = 17, length = 22)
We don't have any samples/ tests with it at all? #Resolved
@artidoroartidoroFeb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding a sample now.
In reply to: 255816087 [](ancestors = 255816087)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

you used to add summary comments in previous PRs #Resolved
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public RandomModelParameters(IHostEnvironment env, int seed)

I think we trying to close our current predictors till 1.0 #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public PriorModelParameters(IHostEnvironment env, float prob)

internal? #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Feb 12, 2019
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@abgoswam
abgoswam
commented
Feb 12, 2019

Copy link


Copy Markdown

Member
// Licensed to the .NET Foundation under one or more agreements.
no changes in this file.
Refers to: src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs:1 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = True)
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.OnnxTransform/OnnxCatalog.cs
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
Outdated

abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

Yes you are right let me do that.
In reply to: 462631911 [](ancestors = 462631911)
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public RandomModelParameters(IHostEnvironment env, int seed)

Ok will make this internal thank you!
In reply to: 462635433 [](ancestors = 462635433)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public PriorModelParameters(IHostEnvironment env, float prob)

Thank you!
In reply to: 462635562 [](ancestors = 462635562)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@sfilipisfilipi
mentioned this pull request
Feb 13, 2019

Closed

@shmoradimsshmoradims
mentioned this pull request
Feb 13, 2019

Closed

abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs
abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/PriorTrainerSample.cs
abgoswam
abgoswam
approved these changes
Feb 13, 2019
View reviewed changes
@abgoswamabgoswam
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@artidoro
artidoro
merged commit f8e58dd
into
dotnet:masterFeb 13, 2019
@codecov
codecovBot
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2510 into master will increase coverage by <.01%.

The diff coverage is 97.82%.
@@ Coverage Diff @@## master #2510 +/- ##
==========================================
+ Coverage 71.25% 71.25% +<.01% 
==========================================
Files 797 797 Lines 141271 141280 +9 Branches 16115 16115 ==========================================
+ Hits 100663 100671 +8 - Misses 36148 36149 +1 
Partials 4460 4460
FlagCoverage Δ
#Debug71.25% <97.82%> (ø)⬆️
#production67.58% <97.43%> (ø)⬆️
#test85.36% <100%> (ø)⬆️
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs

namespace Microsoft.ML.Samples.Dynamic
{
 public class RandomTrainerSample
@Ivanidzo4kaIvanidzo4kaFeb 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RandomTrainerSample [](start = 17, length = 19)
Zeeshan A, Shahab and me have PRs where we create BinaryClassification folder.

Any chance you can move this two to that folder?
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sfilipisfilipiAwaiting requested review from sfilipi
@zeahmedzeahmedAwaiting requested review from zeahmed
@wschinwschinAwaiting requested review from wschin

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@abgoswamabgoswamabgoswam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@artidoroartidoro

Labels

APIIssues pertaining the friendly API

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Creation of components through MLContext: advanced options and other feedback


3 participants

@artidoro@Ivanidzo4ka@abgoswam

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Creation of components through MLContext, internalization, and renaming - #2510
Merged
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Feb 13, 2019
Merged
Creation of components through MLContext, internalization, and renaming#2510
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Conversation
@artidoro
@artidoroartidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

Contributor
Fixes#1798, #1758
  1. In this PR I internalize the constructors of DnnImageFeaturizerEstimator, PriorTrainer, and RandomTrainer. This required to add catalog extensions for these three trainers. Internalizing these constructor closes issue Creation of components through MLContext: advanced options and other feedback #1798.
  2. I also rename a few instances of Arguments to Options which closes issue Arguments class should be made internal when possible #1758.
  3. I internalized some fields across ITransformers and IEstimators.
  4. I also moved the Options class in TensorflowTransform to the estimator.
@artidoroartidoro
self-assigned this
Feb 12, 2019
@artidoroartidoro
added
the 
API
Issues pertaining the friendly API
label
Feb 12, 2019
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.Transforms/CustomMappingTransformer.cs
 /// <param name="inputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TSrc"/> and input data.</param>
 /// <param name="outputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TDst"/> and output data.</param>
public CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
internal CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
@Ivanidzo4kaIvanidzo4kaFeb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomMappingEstimator [](start = 17, length = 22)
We don't have any samples/ tests with it at all? #Resolved
@artidoroartidoroFeb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding a sample now.
In reply to: 255816087 [](ancestors = 255816087)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

you used to add summary comments in previous PRs #Resolved
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public RandomModelParameters(IHostEnvironment env, int seed)

I think we trying to close our current predictors till 1.0 #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public PriorModelParameters(IHostEnvironment env, float prob)

internal? #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Feb 12, 2019
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@abgoswam
abgoswam
commented
Feb 12, 2019

Copy link


Copy Markdown

Member
// Licensed to the .NET Foundation under one or more agreements.
no changes in this file.
Refers to: src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs:1 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = True)
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.OnnxTransform/OnnxCatalog.cs
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
Outdated

abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

Yes you are right let me do that.
In reply to: 462631911 [](ancestors = 462631911)
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public RandomModelParameters(IHostEnvironment env, int seed)

Ok will make this internal thank you!
In reply to: 462635433 [](ancestors = 462635433)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public PriorModelParameters(IHostEnvironment env, float prob)

Thank you!
In reply to: 462635562 [](ancestors = 462635562)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@sfilipisfilipi
mentioned this pull request
Feb 13, 2019

Closed

@shmoradimsshmoradims
mentioned this pull request
Feb 13, 2019

Closed

abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs
abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/PriorTrainerSample.cs
abgoswam
abgoswam
approved these changes
Feb 13, 2019
View reviewed changes
@abgoswamabgoswam
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@artidoro
artidoro
merged commit f8e58dd
into
dotnet:masterFeb 13, 2019
@codecov
codecovBot
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2510 into master will increase coverage by <.01%.

The diff coverage is 97.82%.
@@ Coverage Diff @@## master #2510 +/- ##
==========================================
+ Coverage 71.25% 71.25% +<.01% 
==========================================
Files 797 797 Lines 141271 141280 +9 Branches 16115 16115 ==========================================
+ Hits 100663 100671 +8 - Misses 36148 36149 +1 
Partials 4460 4460
FlagCoverage Δ
#Debug71.25% <97.82%> (ø)⬆️
#production67.58% <97.43%> (ø)⬆️
#test85.36% <100%> (ø)⬆️
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs

namespace Microsoft.ML.Samples.Dynamic
{
 public class RandomTrainerSample
@Ivanidzo4kaIvanidzo4kaFeb 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RandomTrainerSample [](start = 17, length = 19)
Zeeshan A, Shahab and me have PRs where we create BinaryClassification folder.

Any chance you can move this two to that folder?
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sfilipisfilipiAwaiting requested review from sfilipi
@zeahmedzeahmedAwaiting requested review from zeahmed
@wschinwschinAwaiting requested review from wschin

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@abgoswamabgoswamabgoswam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@artidoroartidoro

Labels

APIIssues pertaining the friendly API

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Creation of components through MLContext: advanced options and other feedback


3 participants

@artidoro@Ivanidzo4ka@abgoswam

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Creation of components through MLContext, internalization, and renaming - #2510
Merged
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Feb 13, 2019
Merged
Creation of components through MLContext, internalization, and renaming#2510
artidoro merged 7 commits into
dotnet:masterfrom 
artidoro:estimatortransformer
Conversation
@artidoro
@artidoroartidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

Contributor
Fixes#1798, #1758
  1. In this PR I internalize the constructors of DnnImageFeaturizerEstimator, PriorTrainer, and RandomTrainer. This required to add catalog extensions for these three trainers. Internalizing these constructor closes issue Creation of components through MLContext: advanced options and other feedback #1798.
  2. I also rename a few instances of Arguments to Options which closes issue Arguments class should be made internal when possible #1758.
  3. I internalized some fields across ITransformers and IEstimators.
  4. I also moved the Options class in TensorflowTransform to the estimator.
@artidoroartidoro
self-assigned this
Feb 12, 2019
@artidoroartidoro
added
the 
API
Issues pertaining the friendly API
label
Feb 12, 2019
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.Transforms/CustomMappingTransformer.cs
 /// <param name="inputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TSrc"/> and input data.</param>
 /// <param name="outputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TDst"/> and output data.</param>
public CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
internal CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName,
@Ivanidzo4kaIvanidzo4kaFeb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomMappingEstimator [](start = 17, length = 22)
We don't have any samples/ tests with it at all? #Resolved
@artidoroartidoroFeb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding a sample now.
In reply to: 255816087 [](ancestors = 255816087)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

you used to add summary comments in previous PRs #Resolved
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public RandomModelParameters(IHostEnvironment env, int seed)

I think we trying to close our current predictors till 1.0 #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@Ivanidzo4ka
Ivanidzo4ka
commented
Feb 12, 2019•

edited by artidoro

Loading

Copy link


Copy Markdown

Contributor
 public PriorModelParameters(IHostEnvironment env, float prob)

internal? #Resolved
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
Ivanidzo4ka
Ivanidzo4ka
approved these changes
Feb 12, 2019
View reviewed changes
@Ivanidzo4kaIvanidzo4ka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@abgoswam
abgoswam
commented
Feb 12, 2019

Copy link


Copy Markdown

Member
// Licensed to the .NET Foundation under one or more agreements.
no changes in this file.
Refers to: src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs:1 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = True)
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.OnnxTransform/OnnxCatalog.cs
abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
Outdated

abgoswam
abgoswam
reviewed
Feb 12, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.StandardLearners/StandardLearnersCatalog.cs
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public override SchemaShape GetOutputSchema(SchemaShape inputSchema)

Yes you are right let me do that.
In reply to: 462631911 [](ancestors = 462631911)
Refers to: src/Microsoft.ML.Transforms/CustomMappingTransformer.cs:207 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public RandomModelParameters(IHostEnvironment env, int seed)

Ok will make this internal thank you!
In reply to: 462635433 [](ancestors = 462635433)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:142 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@artidoro
artidoro
commented
Feb 12, 2019

Copy link


Copy Markdown

ContributorAuthor
 public PriorModelParameters(IHostEnvironment env, float prob)

Thank you!
In reply to: 462635562 [](ancestors = 462635562)
Refers to: src/Microsoft.ML.StandardLearners/Standard/Simple/SimpleTrainers.cs:379 in 35e93ef. [](commit_id = 35e93ef, deletion_comment = False)
@sfilipisfilipi
mentioned this pull request
Feb 13, 2019

Closed

@shmoradimsshmoradims
mentioned this pull request
Feb 13, 2019

Closed

abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs
abgoswam
abgoswam
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/PriorTrainerSample.cs
abgoswam
abgoswam
approved these changes
Feb 13, 2019
View reviewed changes
@abgoswamabgoswam
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@artidoro
artidoro
merged commit f8e58dd
into
dotnet:masterFeb 13, 2019
@codecov
codecovBot
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2510 into master will increase coverage by <.01%.

The diff coverage is 97.82%.
@@ Coverage Diff @@## master #2510 +/- ##
==========================================
+ Coverage 71.25% 71.25% +<.01% 
==========================================
Files 797 797 Lines 141271 141280 +9 Branches 16115 16115 ==========================================
+ Hits 100663 100671 +8 - Misses 36148 36149 +1 
Partials 4460 4460
FlagCoverage Δ
#Debug71.25% <97.82%> (ø)⬆️
#production67.58% <97.43%> (ø)⬆️
#test85.36% <100%> (ø)⬆️
Ivanidzo4ka
Ivanidzo4ka
reviewed
Feb 13, 2019
View reviewed changes
Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs

namespace Microsoft.ML.Samples.Dynamic
{
 public class RandomTrainerSample
@Ivanidzo4kaIvanidzo4kaFeb 13, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RandomTrainerSample [](start = 17, length = 19)
Zeeshan A, Shahab and me have PRs where we create BinaryClassification folder.

Any chance you can move this two to that folder?
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 24, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sfilipisfilipiAwaiting requested review from sfilipi
@zeahmedzeahmedAwaiting requested review from zeahmed
@wschinwschinAwaiting requested review from wschin

2 more reviewers

@Ivanidzo4kaIvanidzo4kaIvanidzo4ka approved these changes
@abgoswamabgoswamabgoswam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@artidoroartidoro

Labels

APIIssues pertaining the friendly API

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Creation of components through MLContext: advanced options and other feedback


3 participants

@artidoro@Ivanidzo4ka@abgoswam