Update to coverlet 2.6.0 - #2843

Merged
codemzs merged 2 commits into
dotnet:masterfrom
sharwell:update-coverlet
Mar 12, 2019
Merged

Update to coverlet 2.6.0#2843
codemzs merged 2 commits into
dotnet:masterfrom
sharwell:update-coverlet

Conversation

@sharwell

@sharwellsharwell commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecovBot commented Mar 5, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2843 into master will increase coverage by 0.35%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2843 +/- ##
==========================================
+ Coverage 71.81% 72.17% +0.35% 
==========================================
Files 812 796 -16 Lines 142659 141949 -710 Branches 16090 16042 -48 ==========================================
Hits 102450 102450 + Misses 35826 35117 -709 + Partials 4383 4382 -1
FlagCoverage Δ
#Debug72.17% <ø> (+0.35%)⬆️
#production67.96% <ø> (ø)⬆️
#test88.32% <ø> (+2.08%)⬆️
Impacted FilesCoverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs84.7% <0%> (-0.21%)⬇️
test/Microsoft.ML.Benchmarks/Numeric/Ranking.cs
...st/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs
...t/Microsoft.ML.Benchmarks/PredictionEngineBench.cs
...s/StochasticDualCoordinateAscentClassifierBench.cs
...est/Microsoft.ML.Benchmarks/Helpers/EmptyWriter.cs
test/Microsoft.ML.Benchmarks/CacheDataViewBench.cs
test/Microsoft.ML.Benchmarks/Harness/Metrics.cs
test/Microsoft.ML.Benchmarks/Helpers/Errors.cs
test/Microsoft.ML.Benchmarks/RffTransform.cs
... and 8 more

@sharwell
sharwellforce-pushed the update-coverlet branch 2 times, most recently from e7a3e4b to 953ae39CompareMarch 5, 2019 13:57
@TomFinley
TomFinley requested a review from codemzsMarch 5, 2019 15:17
TomFinley
TomFinley reviewed Mar 5, 2019
View reviewed changes
Comment threadtest/Directory.Build.props
@TomFinley

TomFinley commented Mar 5, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

If I pick a code coverage run arbitrarily, I see #2808 finished in 38m 13s. Yours finished in 23m 36s. That's a very positive perf difference!

TomFinley
TomFinley approved these changes Mar 5, 2019
View reviewed changes

@TomFinleyTomFinley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sharwell, at least at first glance this seems quite positive!

@sharwell

sharwell commented Mar 5, 2019

Copy link
Copy Markdown
ContributorAuthor

@TomFinley it's a substantial improvement in time, but some of the data seems to be missing. I'm still investigating.

zsd4yr pushed a commit to dotnet/winforms that referenced this pull request Mar 8, 2019
Zachary Danz
mockdotnet/machinelearning#2843
562722b
@sharwell
sharwellforce-pushed the update-coverlet branch 2 times, most recently from c032056 to e9758e2CompareMarch 9, 2019 23:22
sharwell
sharwell commented Mar 10, 2019
View reviewed changes
Comment threadbuild/Codecoverage.proj Outdated
<Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
<Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
<Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
<Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />

@sharwellsharwellMar 10, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This is an attempt to address a change in the way numbers were appearing in the new reports. For some reason, the file submitted to codecov had two copies of each source file. The first copy referenced the file using the build machine path, and the second referenced the file using a Source Link path. Prior reports submitted to codecov appeared to only contain the latter, so I'm attempting to use a filter to address the problem.

<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="D:\a\1\s\src\Microsoft.ML.StaticPipe\LdaStaticExtensions.cs"line-rate="0"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="0"branch-rate="1">
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</lines>
</class>
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="https://raw.githubusercontent.com/dotnet/machinelearning/d495bb4c7a58c459e753b9de3d0895c188468b58/src/Microsoft.ML.StaticPipe/LdaStaticExtensions.cs"line-rate="1"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="1"branch-rate="1">
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</lines>
</class>

@sharwell

sharwell commented Mar 10, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This should be ready for review. The changes to coverage were primarily the following:

  1. Microsoft.ML.Benchmarks and Microsoft.ML.Benchmarks.Tests are no longer reported. These files had no coverage previously.
  2. Microsoft.ML.FSharp.Tests is no longer reported; the reportgenerator file filter might need to be updated to include it Should be fixed now

The other coverage changes appear to be normal non-determinism in the coverage runs.

@sharwell

sharwell commented Mar 10, 2019

Copy link
Copy Markdown
ContributorAuthor

For some reason the button to move this from a draft pull request to a normal pull request is missing here...

@TomFinley
TomFinley marked this pull request as ready for review March 10, 2019 23:56
@TomFinley

TomFinley commented Mar 10, 2019

Copy link
Copy Markdown
Contributor

For some reason the button to move this from a draft pull request to a normal pull request is missing here...

Interesting. Maybe it's one of those things that somehow needs write access? But that doesn't make sense. Anyway, I pushed the button...

@TomFinley
TomFinley requested a review from shauheenMarch 10, 2019 23:58
@sharwellsharwell mentioned this pull request Mar 11, 2019
Closed
sharwell
sharwell commented Mar 11, 2019
View reviewed changes
Comment threadbuild/ci/phase-template.yml Outdated
codemzs
codemzs approved these changes Mar 12, 2019
View reviewed changes

@codemzscodemzs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs

codemzs commented Mar 12, 2019

Copy link
Copy Markdown
Member

Thanks, @sharwell !

@codemzs
codemzs merged commit 6e1291a into dotnet:masterMar 12, 2019
@sharwell
sharwell deleted the update-coverlet branch March 12, 2019 22:49
zsd4yr added a commit to dotnet/winforms that referenced this pull request Mar 15, 2019
@zsd4yr
Establish Code Coverage for WinForms testing (#514)
1f0aead
* include coverlet.msbuild 2.5.1
* add targets and coverage group
* mock dotnet/machinelearning#2843
* Hook coverlet up to the 'RunTests' target
* Upload data to codecov.io
* Add code coverage badge to the README
* Add clarifying comments for code coverage configuration
* Move coverage upload after pick/sign/publish
@ghostghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@codemzscodemzscodemzs approved these changes
@shauheenshauheenAwaiting requested review from shauheen
+1 more reviewer
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharwell@TomFinley@codemzs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Update to coverlet 2.6.0 - #2843
Merged
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Mar 12, 2019
Merged
Update to coverlet 2.6.0#2843
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Conversation
@sharwell
@sharwellsharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@codecov
codecovBot
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2843 into master will increase coverage by 0.35%.

The diff coverage is n/a.
@@ Coverage Diff @@## master #2843 +/- ##
==========================================
+ Coverage 71.81% 72.17% +0.35% 
==========================================
Files 812 796 -16 Lines 142659 141949 -710 Branches 16090 16042 -48 ==========================================
Hits 102450 102450 + Misses 35826 35117 -709 + Partials 4383 4382 -1
FlagCoverage Δ
#Debug72.17% <ø> (+0.35%)⬆️
#production67.96% <ø> (ø)⬆️
#test88.32% <ø> (+2.08%)⬆️
Impacted FilesCoverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs84.7% <0%> (-0.21%)⬇️
test/Microsoft.ML.Benchmarks/Numeric/Ranking.cs
...st/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs
...t/Microsoft.ML.Benchmarks/PredictionEngineBench.cs
...s/StochasticDualCoordinateAscentClassifierBench.cs
...est/Microsoft.ML.Benchmarks/Helpers/EmptyWriter.cs
test/Microsoft.ML.Benchmarks/CacheDataViewBench.cs
test/Microsoft.ML.Benchmarks/Harness/Metrics.cs
test/Microsoft.ML.Benchmarks/Helpers/Errors.cs
test/Microsoft.ML.Benchmarks/RffTransform.cs
... and 8 more
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
e7a3e4b to
953ae39CompareMarch 5, 2019 13:57
@TomFinley
TomFinley
requested a review
from codemzsMarch 5, 2019 15:17
TomFinley
TomFinley
reviewed
Mar 5, 2019
View reviewed changes
Comment threadtest/Directory.Build.props
@TomFinley
TomFinley
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
If I pick a code coverage run arbitrarily, I see #2808 finished in 38m 13s. Yours finished in 23m 36s. That's a very positive perf difference!
TomFinley
TomFinley
approved these changes
Mar 5, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sharwell, at least at first glance this seems quite positive!
@sharwell
sharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

ContributorAuthor
@TomFinley it's a substantial improvement in time, but some of the data seems to be missing. I'm still investigating.
zsd4yr pushed a commit
to dotnet/winforms
that referenced
this pull request
Mar 8, 2019
Zachary Danz
mockdotnet/machinelearning#2843
562722b
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
c032056 to
e9758e2CompareMarch 9, 2019 23:22
sharwell
sharwell
commented
Mar 10, 2019
View reviewed changes
Comment threadbuild/Codecoverage.proj
Outdated

 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
@sharwellsharwellMar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This is an attempt to address a change in the way numbers were appearing in the new reports. For some reason, the file submitted to codecov had two copies of each source file. The first copy referenced the file using the build machine path, and the second referenced the file using a Source Link path. Prior reports submitted to codecov appeared to only contain the latter, so I'm attempting to use a filter to address the problem.
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="D:\a\1\s\src\Microsoft.ML.StaticPipe\LdaStaticExtensions.cs"line-rate="0"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="0"branch-rate="1">
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</lines>
</class>
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="https://raw.githubusercontent.com/dotnet/machinelearning/d495bb4c7a58c459e753b9de3d0895c188468b58/src/Microsoft.ML.StaticPipe/LdaStaticExtensions.cs"line-rate="1"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="1"branch-rate="1">
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</lines>
</class>
@sharwell
sharwell
commented
Mar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
This should be ready for review. The changes to coverage were primarily the following:
  1. Microsoft.ML.Benchmarks and Microsoft.ML.Benchmarks.Tests are no longer reported. These files had no coverage previously.
  2. Microsoft.ML.FSharp.Tests is no longer reported; the reportgenerator file filter might need to be updated to include it Should be fixed now
The other coverage changes appear to be normal non-determinism in the coverage runs.
@sharwell
sharwell
commented
Mar 10, 2019

Copy link


Copy Markdown

ContributorAuthor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
@TomFinley
TomFinley
marked this pull request as ready for review
March 10, 2019 23:56
@TomFinley
TomFinley
commented
Mar 10, 2019

Copy link


Copy Markdown

Contributor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
Interesting. Maybe it's one of those things that somehow needs write access? But that doesn't make sense. Anyway, I pushed the button...
@TomFinley
TomFinley
requested a review
from shauheenMarch 10, 2019 23:58
@sharwellsharwell
mentioned this pull request
Mar 11, 2019

Closed

sharwell
sharwell
commented
Mar 11, 2019
View reviewed changes
Comment threadbuild/ci/phase-template.yml
Outdated

codemzs
codemzs
approved these changes
Mar 12, 2019
View reviewed changes
@codemzscodemzs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@codemzs
codemzs
commented
Mar 12, 2019

Copy link


Copy Markdown

Member
Thanks, @sharwell !
@codemzs
codemzs
merged commit 6e1291a
into
dotnet:masterMar 12, 2019
@sharwell
sharwell
deleted the

update-coverlet

branch
March 12, 2019 22:49
zsd4yr added a commit
to dotnet/winforms
that referenced
this pull request
Mar 15, 2019
@zsd4yr
Establish Code Coverage for WinForms testing (#514)
1f0aead
* include coverlet.msbuild 2.5.1
* add targets and coverage group
* mock dotnet/machinelearning#2843
* Hook coverlet up to the 'RunTests' target
* Upload data to codecov.io
* Add code coverage badge to the README
* Add clarifying comments for code coverage configuration
* Move coverage upload after pick/sign/publish
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 23, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzscodemzs approved these changes
@shauheenshauheenAwaiting requested review from shauheen

+1 more reviewer

@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@sharwell@TomFinley@codemzs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update to coverlet 2.6.0 - #2843
Merged
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Mar 12, 2019
Merged
Update to coverlet 2.6.0#2843
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Conversation
@sharwell
@sharwellsharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@codecov
codecovBot
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2843 into master will increase coverage by 0.35%.

The diff coverage is n/a.
@@ Coverage Diff @@## master #2843 +/- ##
==========================================
+ Coverage 71.81% 72.17% +0.35% 
==========================================
Files 812 796 -16 Lines 142659 141949 -710 Branches 16090 16042 -48 ==========================================
Hits 102450 102450 + Misses 35826 35117 -709 + Partials 4383 4382 -1
FlagCoverage Δ
#Debug72.17% <ø> (+0.35%)⬆️
#production67.96% <ø> (ø)⬆️
#test88.32% <ø> (+2.08%)⬆️
Impacted FilesCoverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs84.7% <0%> (-0.21%)⬇️
test/Microsoft.ML.Benchmarks/Numeric/Ranking.cs
...st/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs
...t/Microsoft.ML.Benchmarks/PredictionEngineBench.cs
...s/StochasticDualCoordinateAscentClassifierBench.cs
...est/Microsoft.ML.Benchmarks/Helpers/EmptyWriter.cs
test/Microsoft.ML.Benchmarks/CacheDataViewBench.cs
test/Microsoft.ML.Benchmarks/Harness/Metrics.cs
test/Microsoft.ML.Benchmarks/Helpers/Errors.cs
test/Microsoft.ML.Benchmarks/RffTransform.cs
... and 8 more
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
e7a3e4b to
953ae39CompareMarch 5, 2019 13:57
@TomFinley
TomFinley
requested a review
from codemzsMarch 5, 2019 15:17
TomFinley
TomFinley
reviewed
Mar 5, 2019
View reviewed changes
Comment threadtest/Directory.Build.props
@TomFinley
TomFinley
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
If I pick a code coverage run arbitrarily, I see #2808 finished in 38m 13s. Yours finished in 23m 36s. That's a very positive perf difference!
TomFinley
TomFinley
approved these changes
Mar 5, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sharwell, at least at first glance this seems quite positive!
@sharwell
sharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

ContributorAuthor
@TomFinley it's a substantial improvement in time, but some of the data seems to be missing. I'm still investigating.
zsd4yr pushed a commit
to dotnet/winforms
that referenced
this pull request
Mar 8, 2019
Zachary Danz
mockdotnet/machinelearning#2843
562722b
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
c032056 to
e9758e2CompareMarch 9, 2019 23:22
sharwell
sharwell
commented
Mar 10, 2019
View reviewed changes
Comment threadbuild/Codecoverage.proj
Outdated

 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
@sharwellsharwellMar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This is an attempt to address a change in the way numbers were appearing in the new reports. For some reason, the file submitted to codecov had two copies of each source file. The first copy referenced the file using the build machine path, and the second referenced the file using a Source Link path. Prior reports submitted to codecov appeared to only contain the latter, so I'm attempting to use a filter to address the problem.
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="D:\a\1\s\src\Microsoft.ML.StaticPipe\LdaStaticExtensions.cs"line-rate="0"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="0"branch-rate="1">
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</lines>
</class>
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="https://raw.githubusercontent.com/dotnet/machinelearning/d495bb4c7a58c459e753b9de3d0895c188468b58/src/Microsoft.ML.StaticPipe/LdaStaticExtensions.cs"line-rate="1"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="1"branch-rate="1">
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</lines>
</class>
@sharwell
sharwell
commented
Mar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
This should be ready for review. The changes to coverage were primarily the following:
  1. Microsoft.ML.Benchmarks and Microsoft.ML.Benchmarks.Tests are no longer reported. These files had no coverage previously.
  2. Microsoft.ML.FSharp.Tests is no longer reported; the reportgenerator file filter might need to be updated to include it Should be fixed now
The other coverage changes appear to be normal non-determinism in the coverage runs.
@sharwell
sharwell
commented
Mar 10, 2019

Copy link


Copy Markdown

ContributorAuthor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
@TomFinley
TomFinley
marked this pull request as ready for review
March 10, 2019 23:56
@TomFinley
TomFinley
commented
Mar 10, 2019

Copy link


Copy Markdown

Contributor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
Interesting. Maybe it's one of those things that somehow needs write access? But that doesn't make sense. Anyway, I pushed the button...
@TomFinley
TomFinley
requested a review
from shauheenMarch 10, 2019 23:58
@sharwellsharwell
mentioned this pull request
Mar 11, 2019

Closed

sharwell
sharwell
commented
Mar 11, 2019
View reviewed changes
Comment threadbuild/ci/phase-template.yml
Outdated

codemzs
codemzs
approved these changes
Mar 12, 2019
View reviewed changes
@codemzscodemzs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@codemzs
codemzs
commented
Mar 12, 2019

Copy link


Copy Markdown

Member
Thanks, @sharwell !
@codemzs
codemzs
merged commit 6e1291a
into
dotnet:masterMar 12, 2019
@sharwell
sharwell
deleted the

update-coverlet

branch
March 12, 2019 22:49
zsd4yr added a commit
to dotnet/winforms
that referenced
this pull request
Mar 15, 2019
@zsd4yr
Establish Code Coverage for WinForms testing (#514)
1f0aead
* include coverlet.msbuild 2.5.1
* add targets and coverage group
* mock dotnet/machinelearning#2843
* Hook coverlet up to the 'RunTests' target
* Upload data to codecov.io
* Add code coverage badge to the README
* Add clarifying comments for code coverage configuration
* Move coverage upload after pick/sign/publish
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 23, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzscodemzs approved these changes
@shauheenshauheenAwaiting requested review from shauheen

+1 more reviewer

@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@sharwell@TomFinley@codemzs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update to coverlet 2.6.0 - #2843
Merged
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Mar 12, 2019
Merged
Update to coverlet 2.6.0#2843
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Conversation
@sharwell
@sharwellsharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@codecov
codecovBot
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2843 into master will increase coverage by 0.35%.

The diff coverage is n/a.
@@ Coverage Diff @@## master #2843 +/- ##
==========================================
+ Coverage 71.81% 72.17% +0.35% 
==========================================
Files 812 796 -16 Lines 142659 141949 -710 Branches 16090 16042 -48 ==========================================
Hits 102450 102450 + Misses 35826 35117 -709 + Partials 4383 4382 -1
FlagCoverage Δ
#Debug72.17% <ø> (+0.35%)⬆️
#production67.96% <ø> (ø)⬆️
#test88.32% <ø> (+2.08%)⬆️
Impacted FilesCoverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs84.7% <0%> (-0.21%)⬇️
test/Microsoft.ML.Benchmarks/Numeric/Ranking.cs
...st/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs
...t/Microsoft.ML.Benchmarks/PredictionEngineBench.cs
...s/StochasticDualCoordinateAscentClassifierBench.cs
...est/Microsoft.ML.Benchmarks/Helpers/EmptyWriter.cs
test/Microsoft.ML.Benchmarks/CacheDataViewBench.cs
test/Microsoft.ML.Benchmarks/Harness/Metrics.cs
test/Microsoft.ML.Benchmarks/Helpers/Errors.cs
test/Microsoft.ML.Benchmarks/RffTransform.cs
... and 8 more
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
e7a3e4b to
953ae39CompareMarch 5, 2019 13:57
@TomFinley
TomFinley
requested a review
from codemzsMarch 5, 2019 15:17
TomFinley
TomFinley
reviewed
Mar 5, 2019
View reviewed changes
Comment threadtest/Directory.Build.props
@TomFinley
TomFinley
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
If I pick a code coverage run arbitrarily, I see #2808 finished in 38m 13s. Yours finished in 23m 36s. That's a very positive perf difference!
TomFinley
TomFinley
approved these changes
Mar 5, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sharwell, at least at first glance this seems quite positive!
@sharwell
sharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

ContributorAuthor
@TomFinley it's a substantial improvement in time, but some of the data seems to be missing. I'm still investigating.
zsd4yr pushed a commit
to dotnet/winforms
that referenced
this pull request
Mar 8, 2019
Zachary Danz
mockdotnet/machinelearning#2843
562722b
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
c032056 to
e9758e2CompareMarch 9, 2019 23:22
sharwell
sharwell
commented
Mar 10, 2019
View reviewed changes
Comment threadbuild/Codecoverage.proj
Outdated

 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
@sharwellsharwellMar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This is an attempt to address a change in the way numbers were appearing in the new reports. For some reason, the file submitted to codecov had two copies of each source file. The first copy referenced the file using the build machine path, and the second referenced the file using a Source Link path. Prior reports submitted to codecov appeared to only contain the latter, so I'm attempting to use a filter to address the problem.
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="D:\a\1\s\src\Microsoft.ML.StaticPipe\LdaStaticExtensions.cs"line-rate="0"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="0"branch-rate="1">
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</lines>
</class>
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="https://raw.githubusercontent.com/dotnet/machinelearning/d495bb4c7a58c459e753b9de3d0895c188468b58/src/Microsoft.ML.StaticPipe/LdaStaticExtensions.cs"line-rate="1"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="1"branch-rate="1">
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</lines>
</class>
@sharwell
sharwell
commented
Mar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
This should be ready for review. The changes to coverage were primarily the following:
  1. Microsoft.ML.Benchmarks and Microsoft.ML.Benchmarks.Tests are no longer reported. These files had no coverage previously.
  2. Microsoft.ML.FSharp.Tests is no longer reported; the reportgenerator file filter might need to be updated to include it Should be fixed now
The other coverage changes appear to be normal non-determinism in the coverage runs.
@sharwell
sharwell
commented
Mar 10, 2019

Copy link


Copy Markdown

ContributorAuthor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
@TomFinley
TomFinley
marked this pull request as ready for review
March 10, 2019 23:56
@TomFinley
TomFinley
commented
Mar 10, 2019

Copy link


Copy Markdown

Contributor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
Interesting. Maybe it's one of those things that somehow needs write access? But that doesn't make sense. Anyway, I pushed the button...
@TomFinley
TomFinley
requested a review
from shauheenMarch 10, 2019 23:58
@sharwellsharwell
mentioned this pull request
Mar 11, 2019

Closed

sharwell
sharwell
commented
Mar 11, 2019
View reviewed changes
Comment threadbuild/ci/phase-template.yml
Outdated

codemzs
codemzs
approved these changes
Mar 12, 2019
View reviewed changes
@codemzscodemzs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@codemzs
codemzs
commented
Mar 12, 2019

Copy link


Copy Markdown

Member
Thanks, @sharwell !
@codemzs
codemzs
merged commit 6e1291a
into
dotnet:masterMar 12, 2019
@sharwell
sharwell
deleted the

update-coverlet

branch
March 12, 2019 22:49
zsd4yr added a commit
to dotnet/winforms
that referenced
this pull request
Mar 15, 2019
@zsd4yr
Establish Code Coverage for WinForms testing (#514)
1f0aead
* include coverlet.msbuild 2.5.1
* add targets and coverage group
* mock dotnet/machinelearning#2843
* Hook coverlet up to the 'RunTests' target
* Upload data to codecov.io
* Add code coverage badge to the README
* Add clarifying comments for code coverage configuration
* Move coverage upload after pick/sign/publish
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 23, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzscodemzs approved these changes
@shauheenshauheenAwaiting requested review from shauheen

+1 more reviewer

@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@sharwell@TomFinley@codemzs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Update to coverlet 2.6.0 - #2843
Merged
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Mar 12, 2019
Merged
Update to coverlet 2.6.0#2843
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Conversation
@sharwell
@sharwellsharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@codecov
codecovBot
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2843 into master will increase coverage by 0.35%.

The diff coverage is n/a.
@@ Coverage Diff @@## master #2843 +/- ##
==========================================
+ Coverage 71.81% 72.17% +0.35% 
==========================================
Files 812 796 -16 Lines 142659 141949 -710 Branches 16090 16042 -48 ==========================================
Hits 102450 102450 + Misses 35826 35117 -709 + Partials 4383 4382 -1
FlagCoverage Δ
#Debug72.17% <ø> (+0.35%)⬆️
#production67.96% <ø> (ø)⬆️
#test88.32% <ø> (+2.08%)⬆️
Impacted FilesCoverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs84.7% <0%> (-0.21%)⬇️
test/Microsoft.ML.Benchmarks/Numeric/Ranking.cs
...st/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs
...t/Microsoft.ML.Benchmarks/PredictionEngineBench.cs
...s/StochasticDualCoordinateAscentClassifierBench.cs
...est/Microsoft.ML.Benchmarks/Helpers/EmptyWriter.cs
test/Microsoft.ML.Benchmarks/CacheDataViewBench.cs
test/Microsoft.ML.Benchmarks/Harness/Metrics.cs
test/Microsoft.ML.Benchmarks/Helpers/Errors.cs
test/Microsoft.ML.Benchmarks/RffTransform.cs
... and 8 more
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
e7a3e4b to
953ae39CompareMarch 5, 2019 13:57
@TomFinley
TomFinley
requested a review
from codemzsMarch 5, 2019 15:17
TomFinley
TomFinley
reviewed
Mar 5, 2019
View reviewed changes
Comment threadtest/Directory.Build.props
@TomFinley
TomFinley
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
If I pick a code coverage run arbitrarily, I see #2808 finished in 38m 13s. Yours finished in 23m 36s. That's a very positive perf difference!
TomFinley
TomFinley
approved these changes
Mar 5, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sharwell, at least at first glance this seems quite positive!
@sharwell
sharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

ContributorAuthor
@TomFinley it's a substantial improvement in time, but some of the data seems to be missing. I'm still investigating.
zsd4yr pushed a commit
to dotnet/winforms
that referenced
this pull request
Mar 8, 2019
Zachary Danz
mockdotnet/machinelearning#2843
562722b
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
c032056 to
e9758e2CompareMarch 9, 2019 23:22
sharwell
sharwell
commented
Mar 10, 2019
View reviewed changes
Comment threadbuild/Codecoverage.proj
Outdated

 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
@sharwellsharwellMar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This is an attempt to address a change in the way numbers were appearing in the new reports. For some reason, the file submitted to codecov had two copies of each source file. The first copy referenced the file using the build machine path, and the second referenced the file using a Source Link path. Prior reports submitted to codecov appeared to only contain the latter, so I'm attempting to use a filter to address the problem.
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="D:\a\1\s\src\Microsoft.ML.StaticPipe\LdaStaticExtensions.cs"line-rate="0"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="0"branch-rate="1">
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</lines>
</class>
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="https://raw.githubusercontent.com/dotnet/machinelearning/d495bb4c7a58c459e753b9de3d0895c188468b58/src/Microsoft.ML.StaticPipe/LdaStaticExtensions.cs"line-rate="1"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="1"branch-rate="1">
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</lines>
</class>
@sharwell
sharwell
commented
Mar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
This should be ready for review. The changes to coverage were primarily the following:
  1. Microsoft.ML.Benchmarks and Microsoft.ML.Benchmarks.Tests are no longer reported. These files had no coverage previously.
  2. Microsoft.ML.FSharp.Tests is no longer reported; the reportgenerator file filter might need to be updated to include it Should be fixed now
The other coverage changes appear to be normal non-determinism in the coverage runs.
@sharwell
sharwell
commented
Mar 10, 2019

Copy link


Copy Markdown

ContributorAuthor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
@TomFinley
TomFinley
marked this pull request as ready for review
March 10, 2019 23:56
@TomFinley
TomFinley
commented
Mar 10, 2019

Copy link


Copy Markdown

Contributor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
Interesting. Maybe it's one of those things that somehow needs write access? But that doesn't make sense. Anyway, I pushed the button...
@TomFinley
TomFinley
requested a review
from shauheenMarch 10, 2019 23:58
@sharwellsharwell
mentioned this pull request
Mar 11, 2019

Closed

sharwell
sharwell
commented
Mar 11, 2019
View reviewed changes
Comment threadbuild/ci/phase-template.yml
Outdated

codemzs
codemzs
approved these changes
Mar 12, 2019
View reviewed changes
@codemzscodemzs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@codemzs
codemzs
commented
Mar 12, 2019

Copy link


Copy Markdown

Member
Thanks, @sharwell !
@codemzs
codemzs
merged commit 6e1291a
into
dotnet:masterMar 12, 2019
@sharwell
sharwell
deleted the

update-coverlet

branch
March 12, 2019 22:49
zsd4yr added a commit
to dotnet/winforms
that referenced
this pull request
Mar 15, 2019
@zsd4yr
Establish Code Coverage for WinForms testing (#514)
1f0aead
* include coverlet.msbuild 2.5.1
* add targets and coverage group
* mock dotnet/machinelearning#2843
* Hook coverlet up to the 'RunTests' target
* Upload data to codecov.io
* Add code coverage badge to the README
* Add clarifying comments for code coverage configuration
* Move coverage upload after pick/sign/publish
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 23, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzscodemzs approved these changes
@shauheenshauheenAwaiting requested review from shauheen

+1 more reviewer

@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@sharwell@TomFinley@codemzs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update to coverlet 2.6.0 - #2843
Merged
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Mar 12, 2019
Merged
Update to coverlet 2.6.0#2843
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Conversation
@sharwell
@sharwellsharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@codecov
codecovBot
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2843 into master will increase coverage by 0.35%.

The diff coverage is n/a.
@@ Coverage Diff @@## master #2843 +/- ##
==========================================
+ Coverage 71.81% 72.17% +0.35% 
==========================================
Files 812 796 -16 Lines 142659 141949 -710 Branches 16090 16042 -48 ==========================================
Hits 102450 102450 + Misses 35826 35117 -709 + Partials 4383 4382 -1
FlagCoverage Δ
#Debug72.17% <ø> (+0.35%)⬆️
#production67.96% <ø> (ø)⬆️
#test88.32% <ø> (+2.08%)⬆️
Impacted FilesCoverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs84.7% <0%> (-0.21%)⬇️
test/Microsoft.ML.Benchmarks/Numeric/Ranking.cs
...st/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs
...t/Microsoft.ML.Benchmarks/PredictionEngineBench.cs
...s/StochasticDualCoordinateAscentClassifierBench.cs
...est/Microsoft.ML.Benchmarks/Helpers/EmptyWriter.cs
test/Microsoft.ML.Benchmarks/CacheDataViewBench.cs
test/Microsoft.ML.Benchmarks/Harness/Metrics.cs
test/Microsoft.ML.Benchmarks/Helpers/Errors.cs
test/Microsoft.ML.Benchmarks/RffTransform.cs
... and 8 more
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
e7a3e4b to
953ae39CompareMarch 5, 2019 13:57
@TomFinley
TomFinley
requested a review
from codemzsMarch 5, 2019 15:17
TomFinley
TomFinley
reviewed
Mar 5, 2019
View reviewed changes
Comment threadtest/Directory.Build.props
@TomFinley
TomFinley
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
If I pick a code coverage run arbitrarily, I see #2808 finished in 38m 13s. Yours finished in 23m 36s. That's a very positive perf difference!
TomFinley
TomFinley
approved these changes
Mar 5, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sharwell, at least at first glance this seems quite positive!
@sharwell
sharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

ContributorAuthor
@TomFinley it's a substantial improvement in time, but some of the data seems to be missing. I'm still investigating.
zsd4yr pushed a commit
to dotnet/winforms
that referenced
this pull request
Mar 8, 2019
Zachary Danz
mockdotnet/machinelearning#2843
562722b
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
c032056 to
e9758e2CompareMarch 9, 2019 23:22
sharwell
sharwell
commented
Mar 10, 2019
View reviewed changes
Comment threadbuild/Codecoverage.proj
Outdated

 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
@sharwellsharwellMar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This is an attempt to address a change in the way numbers were appearing in the new reports. For some reason, the file submitted to codecov had two copies of each source file. The first copy referenced the file using the build machine path, and the second referenced the file using a Source Link path. Prior reports submitted to codecov appeared to only contain the latter, so I'm attempting to use a filter to address the problem.
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="D:\a\1\s\src\Microsoft.ML.StaticPipe\LdaStaticExtensions.cs"line-rate="0"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="0"branch-rate="1">
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</lines>
</class>
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="https://raw.githubusercontent.com/dotnet/machinelearning/d495bb4c7a58c459e753b9de3d0895c188468b58/src/Microsoft.ML.StaticPipe/LdaStaticExtensions.cs"line-rate="1"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="1"branch-rate="1">
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</lines>
</class>
@sharwell
sharwell
commented
Mar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
This should be ready for review. The changes to coverage were primarily the following:
  1. Microsoft.ML.Benchmarks and Microsoft.ML.Benchmarks.Tests are no longer reported. These files had no coverage previously.
  2. Microsoft.ML.FSharp.Tests is no longer reported; the reportgenerator file filter might need to be updated to include it Should be fixed now
The other coverage changes appear to be normal non-determinism in the coverage runs.
@sharwell
sharwell
commented
Mar 10, 2019

Copy link


Copy Markdown

ContributorAuthor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
@TomFinley
TomFinley
marked this pull request as ready for review
March 10, 2019 23:56
@TomFinley
TomFinley
commented
Mar 10, 2019

Copy link


Copy Markdown

Contributor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
Interesting. Maybe it's one of those things that somehow needs write access? But that doesn't make sense. Anyway, I pushed the button...
@TomFinley
TomFinley
requested a review
from shauheenMarch 10, 2019 23:58
@sharwellsharwell
mentioned this pull request
Mar 11, 2019

Closed

sharwell
sharwell
commented
Mar 11, 2019
View reviewed changes
Comment threadbuild/ci/phase-template.yml
Outdated

codemzs
codemzs
approved these changes
Mar 12, 2019
View reviewed changes
@codemzscodemzs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@codemzs
codemzs
commented
Mar 12, 2019

Copy link


Copy Markdown

Member
Thanks, @sharwell !
@codemzs
codemzs
merged commit 6e1291a
into
dotnet:masterMar 12, 2019
@sharwell
sharwell
deleted the

update-coverlet

branch
March 12, 2019 22:49
zsd4yr added a commit
to dotnet/winforms
that referenced
this pull request
Mar 15, 2019
@zsd4yr
Establish Code Coverage for WinForms testing (#514)
1f0aead
* include coverlet.msbuild 2.5.1
* add targets and coverage group
* mock dotnet/machinelearning#2843
* Hook coverlet up to the 'RunTests' target
* Upload data to codecov.io
* Add code coverage badge to the README
* Add clarifying comments for code coverage configuration
* Move coverage upload after pick/sign/publish
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 23, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzscodemzs approved these changes
@shauheenshauheenAwaiting requested review from shauheen

+1 more reviewer

@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@sharwell@TomFinley@codemzs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update to coverlet 2.6.0 - #2843
Merged
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Mar 12, 2019
Merged
Update to coverlet 2.6.0#2843
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Conversation
@sharwell
@sharwellsharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@codecov
codecovBot
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2843 into master will increase coverage by 0.35%.

The diff coverage is n/a.
@@ Coverage Diff @@## master #2843 +/- ##
==========================================
+ Coverage 71.81% 72.17% +0.35% 
==========================================
Files 812 796 -16 Lines 142659 141949 -710 Branches 16090 16042 -48 ==========================================
Hits 102450 102450 + Misses 35826 35117 -709 + Partials 4383 4382 -1
FlagCoverage Δ
#Debug72.17% <ø> (+0.35%)⬆️
#production67.96% <ø> (ø)⬆️
#test88.32% <ø> (+2.08%)⬆️
Impacted FilesCoverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs84.7% <0%> (-0.21%)⬇️
test/Microsoft.ML.Benchmarks/Numeric/Ranking.cs
...st/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs
...t/Microsoft.ML.Benchmarks/PredictionEngineBench.cs
...s/StochasticDualCoordinateAscentClassifierBench.cs
...est/Microsoft.ML.Benchmarks/Helpers/EmptyWriter.cs
test/Microsoft.ML.Benchmarks/CacheDataViewBench.cs
test/Microsoft.ML.Benchmarks/Harness/Metrics.cs
test/Microsoft.ML.Benchmarks/Helpers/Errors.cs
test/Microsoft.ML.Benchmarks/RffTransform.cs
... and 8 more
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
e7a3e4b to
953ae39CompareMarch 5, 2019 13:57
@TomFinley
TomFinley
requested a review
from codemzsMarch 5, 2019 15:17
TomFinley
TomFinley
reviewed
Mar 5, 2019
View reviewed changes
Comment threadtest/Directory.Build.props
@TomFinley
TomFinley
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
If I pick a code coverage run arbitrarily, I see #2808 finished in 38m 13s. Yours finished in 23m 36s. That's a very positive perf difference!
TomFinley
TomFinley
approved these changes
Mar 5, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sharwell, at least at first glance this seems quite positive!
@sharwell
sharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

ContributorAuthor
@TomFinley it's a substantial improvement in time, but some of the data seems to be missing. I'm still investigating.
zsd4yr pushed a commit
to dotnet/winforms
that referenced
this pull request
Mar 8, 2019
Zachary Danz
mockdotnet/machinelearning#2843
562722b
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
c032056 to
e9758e2CompareMarch 9, 2019 23:22
sharwell
sharwell
commented
Mar 10, 2019
View reviewed changes
Comment threadbuild/Codecoverage.proj
Outdated

 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
@sharwellsharwellMar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This is an attempt to address a change in the way numbers were appearing in the new reports. For some reason, the file submitted to codecov had two copies of each source file. The first copy referenced the file using the build machine path, and the second referenced the file using a Source Link path. Prior reports submitted to codecov appeared to only contain the latter, so I'm attempting to use a filter to address the problem.
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="D:\a\1\s\src\Microsoft.ML.StaticPipe\LdaStaticExtensions.cs"line-rate="0"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="0"branch-rate="1">
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</lines>
</class>
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="https://raw.githubusercontent.com/dotnet/machinelearning/d495bb4c7a58c459e753b9de3d0895c188468b58/src/Microsoft.ML.StaticPipe/LdaStaticExtensions.cs"line-rate="1"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="1"branch-rate="1">
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</lines>
</class>
@sharwell
sharwell
commented
Mar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
This should be ready for review. The changes to coverage were primarily the following:
  1. Microsoft.ML.Benchmarks and Microsoft.ML.Benchmarks.Tests are no longer reported. These files had no coverage previously.
  2. Microsoft.ML.FSharp.Tests is no longer reported; the reportgenerator file filter might need to be updated to include it Should be fixed now
The other coverage changes appear to be normal non-determinism in the coverage runs.
@sharwell
sharwell
commented
Mar 10, 2019

Copy link


Copy Markdown

ContributorAuthor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
@TomFinley
TomFinley
marked this pull request as ready for review
March 10, 2019 23:56
@TomFinley
TomFinley
commented
Mar 10, 2019

Copy link


Copy Markdown

Contributor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
Interesting. Maybe it's one of those things that somehow needs write access? But that doesn't make sense. Anyway, I pushed the button...
@TomFinley
TomFinley
requested a review
from shauheenMarch 10, 2019 23:58
@sharwellsharwell
mentioned this pull request
Mar 11, 2019

Closed

sharwell
sharwell
commented
Mar 11, 2019
View reviewed changes
Comment threadbuild/ci/phase-template.yml
Outdated

codemzs
codemzs
approved these changes
Mar 12, 2019
View reviewed changes
@codemzscodemzs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@codemzs
codemzs
commented
Mar 12, 2019

Copy link


Copy Markdown

Member
Thanks, @sharwell !
@codemzs
codemzs
merged commit 6e1291a
into
dotnet:masterMar 12, 2019
@sharwell
sharwell
deleted the

update-coverlet

branch
March 12, 2019 22:49
zsd4yr added a commit
to dotnet/winforms
that referenced
this pull request
Mar 15, 2019
@zsd4yr
Establish Code Coverage for WinForms testing (#514)
1f0aead
* include coverlet.msbuild 2.5.1
* add targets and coverage group
* mock dotnet/machinelearning#2843
* Hook coverlet up to the 'RunTests' target
* Upload data to codecov.io
* Add code coverage badge to the README
* Add clarifying comments for code coverage configuration
* Move coverage upload after pick/sign/publish
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 23, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzscodemzs approved these changes
@shauheenshauheenAwaiting requested review from shauheen

+1 more reviewer

@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@sharwell@TomFinley@codemzs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Update to coverlet 2.6.0 - #2843
Merged
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Mar 12, 2019
Merged
Update to coverlet 2.6.0#2843
codemzs merged 2 commits into
dotnet:masterfrom 
sharwell:update-coverlet
Conversation
@sharwell
@sharwellsharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

Contributor
 No description provided. 
@codecov
codecovBot
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2843 into master will increase coverage by 0.35%.

The diff coverage is n/a.
@@ Coverage Diff @@## master #2843 +/- ##
==========================================
+ Coverage 71.81% 72.17% +0.35% 
==========================================
Files 812 796 -16 Lines 142659 141949 -710 Branches 16090 16042 -48 ==========================================
Hits 102450 102450 + Misses 35826 35117 -709 + Partials 4383 4382 -1
FlagCoverage Δ
#Debug72.17% <ø> (+0.35%)⬆️
#production67.96% <ø> (ø)⬆️
#test88.32% <ø> (+2.08%)⬆️
Impacted FilesCoverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs84.7% <0%> (-0.21%)⬇️
test/Microsoft.ML.Benchmarks/Numeric/Ranking.cs
...st/Microsoft.ML.Benchmarks.Tests/BenchmarksTest.cs
...t/Microsoft.ML.Benchmarks/PredictionEngineBench.cs
...s/StochasticDualCoordinateAscentClassifierBench.cs
...est/Microsoft.ML.Benchmarks/Helpers/EmptyWriter.cs
test/Microsoft.ML.Benchmarks/CacheDataViewBench.cs
test/Microsoft.ML.Benchmarks/Harness/Metrics.cs
test/Microsoft.ML.Benchmarks/Helpers/Errors.cs
test/Microsoft.ML.Benchmarks/RffTransform.cs
... and 8 more
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
e7a3e4b to
953ae39CompareMarch 5, 2019 13:57
@TomFinley
TomFinley
requested a review
from codemzsMarch 5, 2019 15:17
TomFinley
TomFinley
reviewed
Mar 5, 2019
View reviewed changes
Comment threadtest/Directory.Build.props
@TomFinley
TomFinley
commented
Mar 5, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
If I pick a code coverage run arbitrarily, I see #2808 finished in 38m 13s. Yours finished in 23m 36s. That's a very positive perf difference!
TomFinley
TomFinley
approved these changes
Mar 5, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sharwell, at least at first glance this seems quite positive!
@sharwell
sharwell
commented
Mar 5, 2019

Copy link


Copy Markdown

ContributorAuthor
@TomFinley it's a substantial improvement in time, but some of the data seems to be missing. I'm still investigating.
zsd4yr pushed a commit
to dotnet/winforms
that referenced
this pull request
Mar 8, 2019
Zachary Danz
mockdotnet/machinelearning#2843
562722b
@sharwell
sharwellforce-pushed
the
update-coverlet
branch
2 times, most recently
from
c032056 to
e9758e2CompareMarch 9, 2019 23:22
sharwell
sharwell
commented
Mar 10, 2019
View reviewed changes
Comment threadbuild/Codecoverage.proj
Outdated

 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -reporttypes:Cobertura" />
 <Message Importance="high" Text="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
 <Exec Command="&quot;$(_ReportGeneratorPath)&quot; -reports:$(BaseOutputPath)$(PlatformConfig)\coverage\*.coverage -targetdir:$(BaseOutputPath)$(PlatformConfig)\coverage -filefilters:+https* -reporttypes:Cobertura" />
@sharwellsharwellMar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This is an attempt to address a change in the way numbers were appearing in the new reports. For some reason, the file submitted to codecov had two copies of each source file. The first copy referenced the file using the build machine path, and the second referenced the file using a Source Link path. Prior reports submitted to codecov appeared to only contain the latter, so I'm attempting to use a filter to address the problem.
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="D:\a\1\s\src\Microsoft.ML.StaticPipe\LdaStaticExtensions.cs"line-rate="0"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="0"branch-rate="1">
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="0"branch="false" />
<linenumber="25"hits="0"branch="false" />
<linenumber="26"hits="0"branch="false" />
<linenumber="27"hits="0"branch="false" />
</lines>
</class>
<classname="Microsoft.ML.StaticPipe.LdaFitResult"filename="https://raw.githubusercontent.com/dotnet/machinelearning/d495bb4c7a58c459e753b9de3d0895c188468b58/src/Microsoft.ML.StaticPipe/LdaStaticExtensions.cs"line-rate="1"branch-rate="1"complexity="NaN">
<methods>
<methodname=".ctor"signature="(Microsoft.ML.Transforms.Text.LatentDirichletAllocationTransformer/LdaSummary)"line-rate="1"branch-rate="1">
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</method>
</methods>
<lines>
<linenumber="24"hits="1"branch="false" />
<linenumber="25"hits="1"branch="false" />
<linenumber="26"hits="1"branch="false" />
<linenumber="27"hits="1"branch="false" />
</lines>
</class>
@sharwell
sharwell
commented
Mar 10, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
This should be ready for review. The changes to coverage were primarily the following:
  1. Microsoft.ML.Benchmarks and Microsoft.ML.Benchmarks.Tests are no longer reported. These files had no coverage previously.
  2. Microsoft.ML.FSharp.Tests is no longer reported; the reportgenerator file filter might need to be updated to include it Should be fixed now
The other coverage changes appear to be normal non-determinism in the coverage runs.
@sharwell
sharwell
commented
Mar 10, 2019

Copy link


Copy Markdown

ContributorAuthor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
@TomFinley
TomFinley
marked this pull request as ready for review
March 10, 2019 23:56
@TomFinley
TomFinley
commented
Mar 10, 2019

Copy link


Copy Markdown

Contributor
For some reason the button to move this from a draft pull request to a normal pull request is missing here...
Interesting. Maybe it's one of those things that somehow needs write access? But that doesn't make sense. Anyway, I pushed the button...
@TomFinley
TomFinley
requested a review
from shauheenMarch 10, 2019 23:58
@sharwellsharwell
mentioned this pull request
Mar 11, 2019

Closed

sharwell
sharwell
commented
Mar 11, 2019
View reviewed changes
Comment threadbuild/ci/phase-template.yml
Outdated

codemzs
codemzs
approved these changes
Mar 12, 2019
View reviewed changes
@codemzscodemzs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@codemzs
codemzs
commented
Mar 12, 2019

Copy link


Copy Markdown

Member
Thanks, @sharwell !
@codemzs
codemzs
merged commit 6e1291a
into
dotnet:masterMar 12, 2019
@sharwell
sharwell
deleted the

update-coverlet

branch
March 12, 2019 22:49
zsd4yr added a commit
to dotnet/winforms
that referenced
this pull request
Mar 15, 2019
@zsd4yr
Establish Code Coverage for WinForms testing (#514)
1f0aead
* include coverlet.msbuild 2.5.1
* add targets and coverage group
* mock dotnet/machinelearning#2843
* Hook coverlet up to the 'RunTests' target
* Upload data to codecov.io
* Add code coverage badge to the README
* Add clarifying comments for code coverage configuration
* Move coverage upload after pick/sign/publish
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 23, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@codemzscodemzscodemzs approved these changes
@shauheenshauheenAwaiting requested review from shauheen

+1 more reviewer

@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@sharwell@TomFinley@codemzs