Uh oh!
There was an error while loading. Please reload this page.
Samples and unit test for image-related transform estimators - #3165
Conversation
| // ImagePath : tomato.bmp | ||
| // Name : tomato | ||
| // ImageObject : System.Drawing.Bitmap | ||
| // Grayscale : System.Drawing.Bitmap |
There was a problem hiding this comment.
maybe transpose, to give the column/row idea more accurately. #Resolved
There was a problem hiding this comment.
| // Preview 1 row of the transformedData. | ||
| var transformedDataPreview = transformedData.Preview(1); | ||
| foreach (var kvPair in transformedDataPreview.RowView[0].Values) | ||
| { |
There was a problem hiding this comment.
{ [](start = 12, length = 1)
omit :) #Resolved
| { | ||
| public static class ConvertToImage | ||
| { | ||
| private const int inputSize = 3 * 224 * 224; |
There was a problem hiding this comment.
- 224 * 224; [](start = 39, length = 13)
might want to add a comment about what does each number represent #Resolved
| Features = Enumerable.Repeat(0, inputSize).Select(x => random.NextDouble() * 100).ToArray() | ||
| }; | ||
| } | ||
| } |
There was a problem hiding this comment.
i'd move this below the example. If the users want to scroll to it they can. #Resolved
There was a problem hiding this comment.
| // Preview 1 row of the transformedData. | ||
| var transformedDataPreview = transformedData.Preview(1); | ||
| foreach (var kvPair in transformedDataPreview.RowView[0].Values) | ||
| { |
There was a problem hiding this comment.
{ [](start = 11, length = 2)
omit #Resolved
| // The transformedData IDataView contains the loaded and resized raw values | ||
| // Preview 1 row of the transformedData. |
There was a problem hiding this comment.
no need for space in between. #Resolved
| // Pixels : Dense vector of size 30000 | ||
| Console.WriteLine("--------------------------------------------------"); | ||
There was a problem hiding this comment.
no need for it. Users can add it #Resolved
| Console.WriteLine("--------------------------------------------------"); | ||
| // Using schema comprehension to display raw pixels for each row. | ||
| // Display extracted pixels in column 'Pixels'. |
There was a problem hiding this comment.
might be easier to understand if put as:
Convert the transformedData into an IEnumerable #Resolved
There was a problem hiding this comment.
| // Preview of the content of the images.tsv file | ||
| // | ||
| // ImagePath Name ImageObject "Pixels" |
There was a problem hiding this comment.
// ImagePath Name ImageObject [](start = 11, length = 41)
maybe keep the headers/column names, even if they don't print out. Or print them separately. #Resolved
There was a problem hiding this comment.
| var pipeline = mlContext.Transforms.LoadImages("ImageObject", imagesFolder, "ImagePath"); | ||
| var transformedData = pipeline.Fit(data).Transform(data); | ||
| // The transformedData IDataView contains the loaded images now |
There was a problem hiding this comment.
now [](start = 72, length = 3)
dot in the end of sentence :) #Resolved
| .Append(mlContext.Transforms.ResizeImages("ImageObjectResized", inputColumnName: "ImageObject", imageWidth: 100, imageHeight: 100)); | ||
| var transformedData = pipeline.Fit(data).Transform(data); | ||
| // The transformedData IDataView contains the resized images now |
There was a problem hiding this comment.
dot here is well #Resolved
Codecov Report
@@ Coverage Diff @@## master #3165 +/- ##
==========================================
+ Coverage 72.53% 72.55% +0.01%
==========================================
Files 808 807 -1 Lines 144775 144793 +18 Branches 16209 16211 +2 ==========================================
+ Hits 105012 105054 +42 + Misses 35348 35323 -25 - Partials 4415 4416 +1
|
Codecov Report
@@ Coverage Diff @@## master #3165 +/- ##
==========================================
+ Coverage 72.53% 72.55% +0.01%
==========================================
Files 808 807 -1 Lines 144775 144793 +18 Branches 16209 16211 +2 ==========================================
+ Hits 105012 105054 +42 + Misses 35348 35322 -26 - Partials 4415 4417 +2
|
| foreach (var row in data.RowView) | ||
| { | ||
| foreach (var kvPair in row.Values) | ||
| { |
There was a problem hiding this comment.
{ [](start = 16, length = 1)
for 1-liner blocks, let's not use {} to keep the samples short. similar to foreach loop on line 58 #Resolved
There was a problem hiding this comment.
actually these are 2-liners. may use Linq to shorten it.
In reply to: 271452481 [](ancestors = 271452481)
There was a problem hiding this comment.
| private static void PrintPreview(DataDebuggerPreview data) | ||
| { | ||
| foreach (var colInfo in data.ColumnView) | ||
| Console.Write("{0, -25}", colInfo.Column.Name); |
There was a problem hiding this comment.
"{0, -25}" [](start = 30, length = 10)
let's just define this as:
var format = "{0,-25}" (they usually don't use space after comma)
and use 'format' in the rest of the code
There was a problem hiding this comment.
not getting you .. whats meant by using 'format' ? is the suggestion to use string.Format somehow ..
In reply to: 271455734 [](ancestors = 271455734)
There was a problem hiding this comment.
used control+k+d to fix format (if thats what u meant)
In reply to: 271462084 [](ancestors = 271462084,271455734)
There was a problem hiding this comment.
Ivan meant to define the "{0,-25}" as a variable, rather than repeating it, and reuse the variable below.
In reply to: 271465497 [](ancestors = 271465497,271462084,271455734)
| var random = new Random(seed); | ||
| for (int i = 0; i < count; i++) | ||
| { |
There was a problem hiding this comment.
{ [](start = 12, length = 1)
omit #Resolved
| private class DataPoint | ||
| { | ||
| [VectorType(inputSize)] |
There was a problem hiding this comment.
[VectorType(inputSize)] [](start = 11, length = 24)
is this annotation needed? #Resolved
There was a problem hiding this comment.
yeah, this is indeed needed.
when fitting a model, we do some checks e.g. schema validation / size checks / whether the estimator works with fixed size or variable size etc
the VectorToImageConvertingEstimator works on fixed-size vector . without the annotation, the assumtion is that its a variable size vector , and the following check fails :
Unhandled Exception: System.ArgumentOutOfRangeException: Schema mismatch for input column 'Features': expected known-size vector of type Single, Double or Byte, got VarVector
In reply to: 271595813 [](ancestors = 271595813)
…3165) * updating image samples * fix review comments (print preview) * fix comments (minor nits) * fix review comments (whitespaces)
Towards #1209
The PR makes the following changes
Adds unit test and sample for the
ConvertToImagetransform estimator.Fixes the info presented to the user for the 4 existing image samples {ConvertToGrayscale, LoadImages, ExtractPixels, ResizeImages}