Uh oh!
There was an error while loading. Please reload this page.
Conversion catalog samples - #3167
Conversation
Codecov Report
@@ Coverage Diff @@## master #3167 +/- ##
==========================================
- Coverage 72.54% 72.53% -0.01%
==========================================
Files 807 807 Lines 144774 144774 Branches 16208 16208 ==========================================
- Hits 105022 105011 -11 - Misses 35338 35348 +10 - Partials 4414 4415 +1
|
| public uint Label { get; set; } | ||
| } | ||
| public static class ConvertTypeMultiColumn | ||
| { | ||
| // The initial data type | ||
| private class InputData |
There was a problem hiding this comment.
Other places we have C# structures defined after the actual example function. #Resolved
There was a problem hiding this comment.
| { | ||
| public float Converted1 { get; set; } | ||
| public float Converted2 { get; set; } | ||
There was a problem hiding this comment.
Do we want to remove this empty line? #Resolved
| new InputOutputColumnPair("Converted3", "Feature3"), | ||
| new InputOutputColumnPair("Converted4", "Feature4"), | ||
| }, DataKind.Single); |
There was a problem hiding this comment.
{ is not aligned with }. #Resolved
| new InputOutputColumnPair("Converted2", "Feature2"), | ||
| new InputOutputColumnPair("Converted3", "Feature3"), | ||
| new InputOutputColumnPair("Converted4", "Feature4"), | ||
There was a problem hiding this comment.
Please remove this empty line. #Resolved
| }, DataKind.Single); | ||
| // Let's train our pipeline, and then apply it to the same data. |
There was a problem hiding this comment.
Please add more detailed description about what this pipeline is doing. For example, input column A will be converted to output column B. #Pending
There was a problem hiding this comment.
I am not adding too many details, because it is hard to maintain as stale names in the comments don't get flagged by anything.
In reply to: 271402918 [](ancestors = 271402918)
| { | ||
| public static class MapValue | ||
| { | ||
| class DataPoint |
There was a problem hiding this comment.
| class DataPoint | |
| privateclass DataPoint | |
| ``` #Resolved |
| public int Score { get; set; } | ||
| } | ||
| class TransformedData : DataPoint |
There was a problem hiding this comment.
| classTransformedData:DataPoint | |
| privateclassTransformedDataPoint:DataPoint | |
| ``` #Resolved |
| /// This example demonstrates the use of the ValueMappingEstimator by mapping strings to other string values, or floats to strings. | ||
| /// This is useful to map types to a grouping. |
There was a problem hiding this comment.
What does This is useful to map types to a grouping. mean? #Resolved
| new DataPoint() { Timeframe = "12-25yrs" , Score = 3 }, | ||
| new DataPoint() { Timeframe = "0-5yrs" , Score = 4 }, | ||
| new DataPoint() { Timeframe = "12-25yrs" , Score = 5 }, | ||
| new DataPoint() { Timeframe = "25+yrs" , Score = 5 }, |
There was a problem hiding this comment.
| newDataPoint(){Timeframe="25+yrs",Score=5}, | |
| newDataPoint(){Timeframe="25+yrs",Score=5}, | |
| ``` #Resolved |
| /// This example demonstrates the use of the ValueMappingEstimator by mapping strings to other string values, or floats to strings. | ||
| /// This is useful to map types to a grouping. | ||
| /// It is possible to have multiple values map to the same category. |
There was a problem hiding this comment.
This sentence is not very clear to me. #Resolved
| namespace Microsoft.ML.Samples.Dynamic | ||
| { | ||
| // This example illustrates how to convert multiple columns of different types to one type, in this case System.Single. | ||
| // This is often a useful data transformation before concatenting the features together and passing them to a particular estimator. |
There was a problem hiding this comment.
concatenting [](start = 57, length = 12)
typo. #Closed
| public static void Example() | ||
| { | ||
| var mlContext = new MLContext(seed: 1); |
There was a problem hiding this comment.
var mlContext = new MLContext(seed: 1); [](start = 12, length = 39)
I see missing comments overall in this sample which we usually have in other samples e.g. comments above the MLContext etc. #Closed
| // TransformedData obtained post-transformation. | ||
| // | ||
| // Timeframe TimeframeCategory Label Score ScoreCategory | ||
| // 0 - 4yrs Short 1 1 Low |
There was a problem hiding this comment.
0 - 4 [](start = 15, length = 5)
There should not be spaces between hyphen here. #Closed
| // Create the lookup map data IEnumerable. | ||
| var lookupData = new[] { | ||
| new LookupMap { Value = 3.14f, Category = "Low" }, |
There was a problem hiding this comment.
Value = 3.14f, Category = "Low" [](start = 32, length = 31)
is it intentional that order of Value and Category differ from the rest? #Closed
| // Convert to IDataView | ||
| var lookupIdvMap = mlContext.Data.LoadFromEnumerable(lookupData); | ||
| // Constructs the ValueMappingEstimator making the ML.net pipeline |
There was a problem hiding this comment.
ML.net [](start = 63, length = 6)
I think we advertise it as ML.NET not ML.net, right? #Closed
| foreach (var featureRow in features) | ||
| Console.WriteLine($"{featureRow.Price}\t\t{featureRow.PriceCategory}"); | ||
| // TransformedData obtained post-transformation. |
There was a problem hiding this comment.
// TransformedData obtained post-transformation. [](start = 12, length = 48)
Everywhere else this is "// Expected output:" #Closed
There was a problem hiding this comment.
I think this is fine too, it matches the name of the type.
In reply to: 271420199 [](ancestors = 271420199)
There was a problem hiding this comment.
| } | ||
| // Timeframe Feature | ||
| // 0 - 4yrs 0, 5, 300 |
There was a problem hiding this comment.
0 - 4yrs [](start = 15, length = 8)
No spaces between hyphen here. #Closed
| class TransformedData : DataPoint | ||
| { | ||
| public int[] Feature { get; set; } |
There was a problem hiding this comment.
Feature [](start = 25, length = 7)
Should be 'Features" as you mentioned this as Features Column in the comments below, right? #Closed
| /// <format type="text/markdown"> | ||
| /// <] | ||
| /// [!code-csharp[KeyToValueMappingEstimator](~/../docs/samples/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/Conversion/ValueMappingStringToKeyType.cs)] |
There was a problem hiding this comment.
KeyToValueMappingEstimator [](start = 27, length = 26)
It should be the name of the extension method e.g. MapKeyToValue. Can you please also check this inconsistency in the rest of the file? #Closed
| } | ||
| // The resulting data type after the transformation | ||
| private sealed class TransformedData : InputData |
There was a problem hiding this comment.
sealed [](start = 16, length = 6)
we don't need to worry about sealed. it might give the wrong impression that the data classes should be sealed.
I added this note to the checklist #Resolved
| public string Feature2; | ||
| public DateTime Feature3; | ||
| public double Feature4; | ||
| } |
There was a problem hiding this comment.
please move the data classes below example as discussed in the group (i also added this note to the checklist) #Resolved
| new DataPoint() { Price = 1.19f }, | ||
| new DataPoint() { Price = 2.17f }, | ||
| new DataPoint() { Price = 33.784f }, | ||
| public string Category { get; set; } | ||
| } | ||
| namespace Microsoft.ML.Samples.Dynamic | ||
| { | ||
| public static class MapValueIdvLookup |
There was a problem hiding this comment.
MapValueIdvLookup [](start = 24, length = 17)
Let's change the filename to say Idv instead of IDV #Resolved
| // 0 23 6.368921E+17 0.1206 | ||
| // 1 8904 6.368924E+17 8.09 | ||
| } |
There was a problem hiding this comment.
i see a lot of extra empty lines. please have a second pass and remove them. #Resolved
| // A: False Aconv:0 | ||
| // A: False Aconv:0 | ||
| } | ||
| private class InputData |
There was a problem hiding this comment.
pr [](start = 7, length = 3)
need extra line here
| { | ||
| public bool Survived; | ||
| } | ||
| private sealed class TransformedData : InputData |
* adding a sample for convert MultiColumns. Moving files around. * Adjust the samples about ValueMapping * Addressing PR comments
Towards #1209
Adding and adjusting samples for the Conversions catalog.