Fix matrix factorization trainer's doc based on user feedback by wschin · Pull Request #3170 · dotnet/machinelearning

wschin · 2019-04-02T16:25:55Z

This PR fixes#3169 by

updating key-typed variable's description in matrix factorization trainer's doc, and
adding one more reference for alg used.

codecov · 2019-04-02T22:40:11Z

Codecov Report

❗ No coverage uploaded for pull request base (master@fde1ab7). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3170 +/- ##
=========================================
Coverage ? 72.53% =========================================
Files ? 807 Lines ? 144774 Branches ? 16208 =========================================
Hits ? 105016 Misses ? 35344 Partials ? 4414

Flag	Coverage Δ
#Debug	`72.53% <ø> (?)`
#production	`68.12% <ø> (?)`
#test	`88.82% <ø> (?)`

Impacted Files	Coverage Δ
...osoft.ML.Recommender/MatrixFactorizationTrainer.cs	`70.39% <ø> (ø)`

artidoro

artidoro · 2019-04-04T07:23:18Z

/// }

To avoid this kind of issues in the future, it might be good to include the code sample that you are giving here in the referenced sample file instead of the trainer's doc.
For maintainability purposes if we check that the samples compile it would be better.

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:21:02Z

/// }

+1. Yo ucan reference specific lines from a .cs file.

In reply to: 479781691 [](ancestors = 479781691)

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:22:11Z

- /// // Matrix row index starts from firstRowIndex and is at most firstRowIndex+m-1.
- /// // Contieuous=true means that all values from firstRowIndex to firstRowIndex+m-1 are allowed keys.
- /// [KeyType(Contiguous = true, Count = m, Min = firstRowIndex)]
+ /// // Matrix column index starts from 0 and is at most n-1.


// Matrix column index starts from 0 and is at most n-1. [](start = 12, length = 56)
tangential, what do you think about #3072

sfilipi · 2019-04-05T15:23:05Z

 /// <a href='https://www.csie.ntu.edu.tw/~cjlin/papers/libmf/mf_adaptive_pakdd.pdf'>a stochastic gradient method</a> for finding <i>P</i>
 /// and <i>Q</i> via minimizing the distance between<i> R</i> and the product of <i>P</i>'s transpose and Q.</para>.
- /// <para>For users interested in the mathematical details, please see the references below.</para>
+ /// <para>The underlying library used in ML.NET matrix factorization can be found on <a href='https://github.com/cjlin1/libmf'>a Github repository</a>. For users interested in the mathematical details, please see the references below.</para>


on a Github repository [](start = 86, length = 68)
on the libmf Github repository

sfilipi

shauheen

…3170)

wschin · 2019-04-02T16:25:55Z

This PR fixes#3169 by

updating key-typed variable's description in matrix factorization trainer's doc, and
adding one more reference for alg used.

codecov · 2019-04-02T22:40:11Z

Codecov Report

❗ No coverage uploaded for pull request base (master@fde1ab7). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3170 +/- ##
=========================================
Coverage ? 72.53% =========================================
Files ? 807 Lines ? 144774 Branches ? 16208 =========================================
Hits ? 105016 Misses ? 35344 Partials ? 4414

Flag	Coverage Δ
#Debug	`72.53% <ø> (?)`
#production	`68.12% <ø> (?)`
#test	`88.82% <ø> (?)`

Impacted Files	Coverage Δ
...osoft.ML.Recommender/MatrixFactorizationTrainer.cs	`70.39% <ø> (ø)`

artidoro

artidoro · 2019-04-04T07:23:18Z

/// }

To avoid this kind of issues in the future, it might be good to include the code sample that you are giving here in the referenced sample file instead of the trainer's doc.
For maintainability purposes if we check that the samples compile it would be better.

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:21:02Z

/// }

+1. Yo ucan reference specific lines from a .cs file.

In reply to: 479781691 [](ancestors = 479781691)

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:22:11Z

- /// // Matrix row index starts from firstRowIndex and is at most firstRowIndex+m-1.
- /// // Contieuous=true means that all values from firstRowIndex to firstRowIndex+m-1 are allowed keys.
- /// [KeyType(Contiguous = true, Count = m, Min = firstRowIndex)]
+ /// // Matrix column index starts from 0 and is at most n-1.


// Matrix column index starts from 0 and is at most n-1. [](start = 12, length = 56)
tangential, what do you think about #3072

sfilipi · 2019-04-05T15:23:05Z

 /// <a href='https://www.csie.ntu.edu.tw/~cjlin/papers/libmf/mf_adaptive_pakdd.pdf'>a stochastic gradient method</a> for finding <i>P</i>
 /// and <i>Q</i> via minimizing the distance between<i> R</i> and the product of <i>P</i>'s transpose and Q.</para>.
- /// <para>For users interested in the mathematical details, please see the references below.</para>
+ /// <para>The underlying library used in ML.NET matrix factorization can be found on <a href='https://github.com/cjlin1/libmf'>a Github repository</a>. For users interested in the mathematical details, please see the references below.</para>


on a Github repository [](start = 86, length = 68)
on the libmf Github repository

sfilipi

shauheen

…3170)

wschin · 2019-04-02T16:25:55Z

This PR fixes#3169 by

updating key-typed variable's description in matrix factorization trainer's doc, and
adding one more reference for alg used.

codecov · 2019-04-02T22:40:11Z

Codecov Report

❗ No coverage uploaded for pull request base (master@fde1ab7). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3170 +/- ##
=========================================
Coverage ? 72.53% =========================================
Files ? 807 Lines ? 144774 Branches ? 16208 =========================================
Hits ? 105016 Misses ? 35344 Partials ? 4414

Flag	Coverage Δ
#Debug	`72.53% <ø> (?)`
#production	`68.12% <ø> (?)`
#test	`88.82% <ø> (?)`

Impacted Files	Coverage Δ
...osoft.ML.Recommender/MatrixFactorizationTrainer.cs	`70.39% <ø> (ø)`

artidoro

artidoro · 2019-04-04T07:23:18Z

/// }

To avoid this kind of issues in the future, it might be good to include the code sample that you are giving here in the referenced sample file instead of the trainer's doc.
For maintainability purposes if we check that the samples compile it would be better.

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:21:02Z

/// }

+1. Yo ucan reference specific lines from a .cs file.

In reply to: 479781691 [](ancestors = 479781691)

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:22:11Z

- /// // Matrix row index starts from firstRowIndex and is at most firstRowIndex+m-1.
- /// // Contieuous=true means that all values from firstRowIndex to firstRowIndex+m-1 are allowed keys.
- /// [KeyType(Contiguous = true, Count = m, Min = firstRowIndex)]
+ /// // Matrix column index starts from 0 and is at most n-1.


// Matrix column index starts from 0 and is at most n-1. [](start = 12, length = 56)
tangential, what do you think about #3072

sfilipi · 2019-04-05T15:23:05Z

 /// <a href='https://www.csie.ntu.edu.tw/~cjlin/papers/libmf/mf_adaptive_pakdd.pdf'>a stochastic gradient method</a> for finding <i>P</i>
 /// and <i>Q</i> via minimizing the distance between<i> R</i> and the product of <i>P</i>'s transpose and Q.</para>.
- /// <para>For users interested in the mathematical details, please see the references below.</para>
+ /// <para>The underlying library used in ML.NET matrix factorization can be found on <a href='https://github.com/cjlin1/libmf'>a Github repository</a>. For users interested in the mathematical details, please see the references below.</para>


on a Github repository [](start = 86, length = 68)
on the libmf Github repository

sfilipi

shauheen

…3170)

wschin · 2019-04-02T16:25:55Z

This PR fixes#3169 by

updating key-typed variable's description in matrix factorization trainer's doc, and
adding one more reference for alg used.

codecov · 2019-04-02T22:40:11Z

Codecov Report

❗ No coverage uploaded for pull request base (master@fde1ab7). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3170 +/- ##
=========================================
Coverage ? 72.53% =========================================
Files ? 807 Lines ? 144774 Branches ? 16208 =========================================
Hits ? 105016 Misses ? 35344 Partials ? 4414

Flag	Coverage Δ
#Debug	`72.53% <ø> (?)`
#production	`68.12% <ø> (?)`
#test	`88.82% <ø> (?)`

Impacted Files	Coverage Δ
...osoft.ML.Recommender/MatrixFactorizationTrainer.cs	`70.39% <ø> (ø)`

artidoro

artidoro · 2019-04-04T07:23:18Z

/// }

To avoid this kind of issues in the future, it might be good to include the code sample that you are giving here in the referenced sample file instead of the trainer's doc.
For maintainability purposes if we check that the samples compile it would be better.

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:21:02Z

/// }

+1. Yo ucan reference specific lines from a .cs file.

In reply to: 479781691 [](ancestors = 479781691)

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:22:11Z

- /// // Matrix row index starts from firstRowIndex and is at most firstRowIndex+m-1.
- /// // Contieuous=true means that all values from firstRowIndex to firstRowIndex+m-1 are allowed keys.
- /// [KeyType(Contiguous = true, Count = m, Min = firstRowIndex)]
+ /// // Matrix column index starts from 0 and is at most n-1.


// Matrix column index starts from 0 and is at most n-1. [](start = 12, length = 56)
tangential, what do you think about #3072

sfilipi · 2019-04-05T15:23:05Z

 /// <a href='https://www.csie.ntu.edu.tw/~cjlin/papers/libmf/mf_adaptive_pakdd.pdf'>a stochastic gradient method</a> for finding <i>P</i>
 /// and <i>Q</i> via minimizing the distance between<i> R</i> and the product of <i>P</i>'s transpose and Q.</para>.
- /// <para>For users interested in the mathematical details, please see the references below.</para>
+ /// <para>The underlying library used in ML.NET matrix factorization can be found on <a href='https://github.com/cjlin1/libmf'>a Github repository</a>. For users interested in the mathematical details, please see the references below.</para>


on a Github repository [](start = 86, length = 68)
on the libmf Github repository

sfilipi

shauheen

…3170)

wschin · 2019-04-02T16:25:55Z

This PR fixes#3169 by

updating key-typed variable's description in matrix factorization trainer's doc, and
adding one more reference for alg used.

codecov · 2019-04-02T22:40:11Z

Codecov Report

❗ No coverage uploaded for pull request base (master@fde1ab7). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3170 +/- ##
=========================================
Coverage ? 72.53% =========================================
Files ? 807 Lines ? 144774 Branches ? 16208 =========================================
Hits ? 105016 Misses ? 35344 Partials ? 4414

Flag	Coverage Δ
#Debug	`72.53% <ø> (?)`
#production	`68.12% <ø> (?)`
#test	`88.82% <ø> (?)`

Impacted Files	Coverage Δ
...osoft.ML.Recommender/MatrixFactorizationTrainer.cs	`70.39% <ø> (ø)`

artidoro

artidoro · 2019-04-04T07:23:18Z

/// }

To avoid this kind of issues in the future, it might be good to include the code sample that you are giving here in the referenced sample file instead of the trainer's doc.
For maintainability purposes if we check that the samples compile it would be better.

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:21:02Z

/// }

+1. Yo ucan reference specific lines from a .cs file.

In reply to: 479781691 [](ancestors = 479781691)

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:22:11Z

- /// // Matrix row index starts from firstRowIndex and is at most firstRowIndex+m-1.
- /// // Contieuous=true means that all values from firstRowIndex to firstRowIndex+m-1 are allowed keys.
- /// [KeyType(Contiguous = true, Count = m, Min = firstRowIndex)]
+ /// // Matrix column index starts from 0 and is at most n-1.


// Matrix column index starts from 0 and is at most n-1. [](start = 12, length = 56)
tangential, what do you think about #3072

sfilipi · 2019-04-05T15:23:05Z

 /// <a href='https://www.csie.ntu.edu.tw/~cjlin/papers/libmf/mf_adaptive_pakdd.pdf'>a stochastic gradient method</a> for finding <i>P</i>
 /// and <i>Q</i> via minimizing the distance between<i> R</i> and the product of <i>P</i>'s transpose and Q.</para>.
- /// <para>For users interested in the mathematical details, please see the references below.</para>
+ /// <para>The underlying library used in ML.NET matrix factorization can be found on <a href='https://github.com/cjlin1/libmf'>a Github repository</a>. For users interested in the mathematical details, please see the references below.</para>


on a Github repository [](start = 86, length = 68)
on the libmf Github repository

sfilipi

shauheen

…3170)

wschin · 2019-04-02T16:25:55Z

This PR fixes#3169 by

updating key-typed variable's description in matrix factorization trainer's doc, and
adding one more reference for alg used.

codecov · 2019-04-02T22:40:11Z

Codecov Report

❗ No coverage uploaded for pull request base (master@fde1ab7). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3170 +/- ##
=========================================
Coverage ? 72.53% =========================================
Files ? 807 Lines ? 144774 Branches ? 16208 =========================================
Hits ? 105016 Misses ? 35344 Partials ? 4414

Flag	Coverage Δ
#Debug	`72.53% <ø> (?)`
#production	`68.12% <ø> (?)`
#test	`88.82% <ø> (?)`

Impacted Files	Coverage Δ
...osoft.ML.Recommender/MatrixFactorizationTrainer.cs	`70.39% <ø> (ø)`

artidoro

artidoro · 2019-04-04T07:23:18Z

/// }

To avoid this kind of issues in the future, it might be good to include the code sample that you are giving here in the referenced sample file instead of the trainer's doc.
For maintainability purposes if we check that the samples compile it would be better.

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:21:02Z

/// }

+1. Yo ucan reference specific lines from a .cs file.

In reply to: 479781691 [](ancestors = 479781691)

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:22:11Z

- /// // Matrix row index starts from firstRowIndex and is at most firstRowIndex+m-1.
- /// // Contieuous=true means that all values from firstRowIndex to firstRowIndex+m-1 are allowed keys.
- /// [KeyType(Contiguous = true, Count = m, Min = firstRowIndex)]
+ /// // Matrix column index starts from 0 and is at most n-1.


// Matrix column index starts from 0 and is at most n-1. [](start = 12, length = 56)
tangential, what do you think about #3072

sfilipi · 2019-04-05T15:23:05Z

 /// <a href='https://www.csie.ntu.edu.tw/~cjlin/papers/libmf/mf_adaptive_pakdd.pdf'>a stochastic gradient method</a> for finding <i>P</i>
 /// and <i>Q</i> via minimizing the distance between<i> R</i> and the product of <i>P</i>'s transpose and Q.</para>.
- /// <para>For users interested in the mathematical details, please see the references below.</para>
+ /// <para>The underlying library used in ML.NET matrix factorization can be found on <a href='https://github.com/cjlin1/libmf'>a Github repository</a>. For users interested in the mathematical details, please see the references below.</para>


on a Github repository [](start = 86, length = 68)
on the libmf Github repository

sfilipi

shauheen

…3170)

wschin · 2019-04-02T16:25:55Z

This PR fixes#3169 by

updating key-typed variable's description in matrix factorization trainer's doc, and
adding one more reference for alg used.

codecov · 2019-04-02T22:40:11Z

Codecov Report

❗ No coverage uploaded for pull request base (master@fde1ab7). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3170 +/- ##
=========================================
Coverage ? 72.53% =========================================
Files ? 807 Lines ? 144774 Branches ? 16208 =========================================
Hits ? 105016 Misses ? 35344 Partials ? 4414

Flag	Coverage Δ
#Debug	`72.53% <ø> (?)`
#production	`68.12% <ø> (?)`
#test	`88.82% <ø> (?)`

Impacted Files	Coverage Δ
...osoft.ML.Recommender/MatrixFactorizationTrainer.cs	`70.39% <ø> (ø)`

artidoro

artidoro · 2019-04-04T07:23:18Z

/// }

To avoid this kind of issues in the future, it might be good to include the code sample that you are giving here in the referenced sample file instead of the trainer's doc.
For maintainability purposes if we check that the samples compile it would be better.

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:21:02Z

/// }

+1. Yo ucan reference specific lines from a .cs file.

In reply to: 479781691 [](ancestors = 479781691)

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:22:11Z

- /// // Matrix row index starts from firstRowIndex and is at most firstRowIndex+m-1.
- /// // Contieuous=true means that all values from firstRowIndex to firstRowIndex+m-1 are allowed keys.
- /// [KeyType(Contiguous = true, Count = m, Min = firstRowIndex)]
+ /// // Matrix column index starts from 0 and is at most n-1.


// Matrix column index starts from 0 and is at most n-1. [](start = 12, length = 56)
tangential, what do you think about #3072

sfilipi · 2019-04-05T15:23:05Z

 /// <a href='https://www.csie.ntu.edu.tw/~cjlin/papers/libmf/mf_adaptive_pakdd.pdf'>a stochastic gradient method</a> for finding <i>P</i>
 /// and <i>Q</i> via minimizing the distance between<i> R</i> and the product of <i>P</i>'s transpose and Q.</para>.
- /// <para>For users interested in the mathematical details, please see the references below.</para>
+ /// <para>The underlying library used in ML.NET matrix factorization can be found on <a href='https://github.com/cjlin1/libmf'>a Github repository</a>. For users interested in the mathematical details, please see the references below.</para>


on a Github repository [](start = 86, length = 68)
on the libmf Github repository

sfilipi

shauheen

…3170)

wschin · 2019-04-02T16:25:55Z

This PR fixes#3169 by

updating key-typed variable's description in matrix factorization trainer's doc, and
adding one more reference for alg used.

codecov · 2019-04-02T22:40:11Z

Codecov Report

❗ No coverage uploaded for pull request base (master@fde1ab7). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3170 +/- ##
=========================================
Coverage ? 72.53% =========================================
Files ? 807 Lines ? 144774 Branches ? 16208 =========================================
Hits ? 105016 Misses ? 35344 Partials ? 4414

Flag	Coverage Δ
#Debug	`72.53% <ø> (?)`
#production	`68.12% <ø> (?)`
#test	`88.82% <ø> (?)`

Impacted Files	Coverage Δ
...osoft.ML.Recommender/MatrixFactorizationTrainer.cs	`70.39% <ø> (ø)`

artidoro

artidoro · 2019-04-04T07:23:18Z

/// }

To avoid this kind of issues in the future, it might be good to include the code sample that you are giving here in the referenced sample file instead of the trainer's doc.
For maintainability purposes if we check that the samples compile it would be better.

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:21:02Z

/// }

+1. Yo ucan reference specific lines from a .cs file.

In reply to: 479781691 [](ancestors = 479781691)

Refers to: src/Microsoft.ML.Recommender/MatrixFactorizationTrainer.cs:50 in 95f09fd. [](commit_id = 95f09fd, deletion_comment = False)

sfilipi · 2019-04-05T15:22:11Z

- /// // Matrix row index starts from firstRowIndex and is at most firstRowIndex+m-1.
- /// // Contieuous=true means that all values from firstRowIndex to firstRowIndex+m-1 are allowed keys.
- /// [KeyType(Contiguous = true, Count = m, Min = firstRowIndex)]
+ /// // Matrix column index starts from 0 and is at most n-1.


// Matrix column index starts from 0 and is at most n-1. [](start = 12, length = 56)
tangential, what do you think about #3072

sfilipi · 2019-04-05T15:23:05Z

 /// <a href='https://www.csie.ntu.edu.tw/~cjlin/papers/libmf/mf_adaptive_pakdd.pdf'>a stochastic gradient method</a> for finding <i>P</i>
 /// and <i>Q</i> via minimizing the distance between<i> R</i> and the product of <i>P</i>'s transpose and Q.</para>.
- /// <para>For users interested in the mathematical details, please see the references below.</para>
+ /// <para>The underlying library used in ML.NET matrix factorization can be found on <a href='https://github.com/cjlin1/libmf'>a Github repository</a>. For users interested in the mathematical details, please see the references below.</para>


on a Github repository [](start = 86, length = 68)
on the libmf Github repository

sfilipi

shauheen

…3170)

wschin self-assigned this Apr 2, 2019

wschin requested review from artidoro and sfilipi April 2, 2019 16:25

Update description about key type and add one more reference
95f09fd

wschin force-pushed the fix-mf-doc branch from d113d5b to 95f09fdCompare April 2, 2019 16:29

artidoro approved these changes Apr 4, 2019
View reviewed changes

sfilipi reviewed Apr 5, 2019
View reviewed changes

sfilipi approved these changes Apr 5, 2019
View reviewed changes

shauheen approved these changes Apr 5, 2019
View reviewed changes

wschin merged commit 68640bb into dotnet:masterApr 5, 2019

wschin deleted the fix-mf-doc branch April 5, 2019 18:15

wschin added a commit to wschin/machinelearning that referenced this pull request Apr 11, 2019
Update description about key type and add one more reference (dotnet#…
3668b3e
…3170)

wschin mentioned this pull request Apr 11, 2019
Add MF fixes to release branch #3292
Closed

ghost locked as resolved and limited conversation to collaborators Mar 23, 2022

wschin self-assigned this Apr 2, 2019

wschin requested review from artidoro and sfilipi April 2, 2019 16:25

Update description about key type and add one more reference
95f09fd

wschin force-pushed the fix-mf-doc branch from d113d5b to 95f09fdCompare April 2, 2019 16:29

artidoro approved these changes Apr 4, 2019
View reviewed changes

sfilipi reviewed Apr 5, 2019
View reviewed changes

sfilipi approved these changes Apr 5, 2019
View reviewed changes

shauheen approved these changes Apr 5, 2019
View reviewed changes

wschin merged commit 68640bb into dotnet:masterApr 5, 2019

wschin deleted the fix-mf-doc branch April 5, 2019 18:15

wschin added a commit to wschin/machinelearning that referenced this pull request Apr 11, 2019
Update description about key type and add one more reference (dotnet#…
3668b3e
…3170)

wschin mentioned this pull request Apr 11, 2019
Add MF fixes to release branch #3292
Closed

ghost locked as resolved and limited conversation to collaborators Mar 23, 2022

wschin self-assigned this Apr 2, 2019

wschin requested review from artidoro and sfilipi April 2, 2019 16:25

Update description about key type and add one more reference
95f09fd

wschin force-pushed the fix-mf-doc branch from d113d5b to 95f09fdCompare April 2, 2019 16:29

artidoro approved these changes Apr 4, 2019
View reviewed changes

sfilipi reviewed Apr 5, 2019
View reviewed changes

sfilipi approved these changes Apr 5, 2019
View reviewed changes

shauheen approved these changes Apr 5, 2019
View reviewed changes

wschin merged commit 68640bb into dotnet:masterApr 5, 2019

wschin deleted the fix-mf-doc branch April 5, 2019 18:15

wschin added a commit to wschin/machinelearning that referenced this pull request Apr 11, 2019
Update description about key type and add one more reference (dotnet#…
3668b3e
…3170)

wschin mentioned this pull request Apr 11, 2019
Add MF fixes to release branch #3292
Closed

ghost locked as resolved and limited conversation to collaborators Mar 23, 2022

wschin self-assigned this Apr 2, 2019

wschin requested review from artidoro and sfilipi April 2, 2019 16:25

Update description about key type and add one more reference
95f09fd

wschin force-pushed the fix-mf-doc branch from d113d5b to 95f09fdCompare April 2, 2019 16:29

artidoro approved these changes Apr 4, 2019
View reviewed changes

sfilipi reviewed Apr 5, 2019
View reviewed changes

sfilipi approved these changes Apr 5, 2019
View reviewed changes

shauheen approved these changes Apr 5, 2019
View reviewed changes

wschin merged commit 68640bb into dotnet:masterApr 5, 2019

wschin deleted the fix-mf-doc branch April 5, 2019 18:15

wschin added a commit to wschin/machinelearning that referenced this pull request Apr 11, 2019
Update description about key type and add one more reference (dotnet#…
3668b3e
…3170)

wschin mentioned this pull request Apr 11, 2019
Add MF fixes to release branch #3292
Closed

ghost locked as resolved and limited conversation to collaborators Mar 23, 2022

wschin self-assigned this Apr 2, 2019

wschin requested review from artidoro and sfilipi April 2, 2019 16:25

Update description about key type and add one more reference
95f09fd

wschin force-pushed the fix-mf-doc branch from d113d5b to 95f09fdCompare April 2, 2019 16:29

artidoro approved these changes Apr 4, 2019
View reviewed changes

sfilipi reviewed Apr 5, 2019
View reviewed changes

sfilipi approved these changes Apr 5, 2019
View reviewed changes

shauheen approved these changes Apr 5, 2019
View reviewed changes

wschin merged commit 68640bb into dotnet:masterApr 5, 2019

wschin deleted the fix-mf-doc branch April 5, 2019 18:15

wschin added a commit to wschin/machinelearning that referenced this pull request Apr 11, 2019
Update description about key type and add one more reference (dotnet#…
3668b3e
…3170)

wschin mentioned this pull request Apr 11, 2019
Add MF fixes to release branch #3292
Closed

ghost locked as resolved and limited conversation to collaborators Mar 23, 2022

wschin self-assigned this Apr 2, 2019

wschin requested review from artidoro and sfilipi April 2, 2019 16:25

Update description about key type and add one more reference
95f09fd

wschin force-pushed the fix-mf-doc branch from d113d5b to 95f09fdCompare April 2, 2019 16:29

artidoro approved these changes Apr 4, 2019
View reviewed changes

sfilipi reviewed Apr 5, 2019
View reviewed changes

sfilipi approved these changes Apr 5, 2019
View reviewed changes

shauheen approved these changes Apr 5, 2019
View reviewed changes

wschin merged commit 68640bb into dotnet:masterApr 5, 2019

wschin deleted the fix-mf-doc branch April 5, 2019 18:15

wschin added a commit to wschin/machinelearning that referenced this pull request Apr 11, 2019
Update description about key type and add one more reference (dotnet#…
3668b3e
…3170)

wschin mentioned this pull request Apr 11, 2019
Add MF fixes to release branch #3292
Closed

ghost locked as resolved and limited conversation to collaborators Mar 23, 2022

wschin self-assigned this Apr 2, 2019

wschin requested review from artidoro and sfilipi April 2, 2019 16:25

Update description about key type and add one more reference
95f09fd

wschin force-pushed the fix-mf-doc branch from d113d5b to 95f09fdCompare April 2, 2019 16:29

artidoro approved these changes Apr 4, 2019
View reviewed changes

sfilipi reviewed Apr 5, 2019
View reviewed changes

sfilipi approved these changes Apr 5, 2019
View reviewed changes

shauheen approved these changes Apr 5, 2019
View reviewed changes

wschin merged commit 68640bb into dotnet:masterApr 5, 2019

wschin deleted the fix-mf-doc branch April 5, 2019 18:15

wschin added a commit to wschin/machinelearning that referenced this pull request Apr 11, 2019
Update description about key type and add one more reference (dotnet#…
3668b3e
…3170)

wschin mentioned this pull request Apr 11, 2019
Add MF fixes to release branch #3292
Closed

ghost locked as resolved and limited conversation to collaborators Mar 23, 2022

wschin self-assigned this Apr 2, 2019

wschin requested review from artidoro and sfilipi April 2, 2019 16:25

Update description about key type and add one more reference
95f09fd

wschin force-pushed the fix-mf-doc branch from d113d5b to 95f09fdCompare April 2, 2019 16:29

artidoro approved these changes Apr 4, 2019
View reviewed changes

sfilipi reviewed Apr 5, 2019
View reviewed changes

sfilipi approved these changes Apr 5, 2019
View reviewed changes

shauheen approved these changes Apr 5, 2019
View reviewed changes

wschin merged commit 68640bb into dotnet:masterApr 5, 2019

wschin deleted the fix-mf-doc branch April 5, 2019 18:15

wschin added a commit to wschin/machinelearning that referenced this pull request Apr 11, 2019
Update description about key type and add one more reference (dotnet#…
3668b3e
…3170)

wschin mentioned this pull request Apr 11, 2019
Add MF fixes to release branch #3292
Closed

ghost locked as resolved and limited conversation to collaborators Mar 23, 2022

Uh oh!

Conversation

wschin commented Apr 2, 2019

Uh oh!

codecovBot commented Apr 2, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

artidoro left a comment

Choose a reason for hiding this comment

Uh oh!

artidoro commented Apr 4, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sfilipi commented Apr 5, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sfilipi left a comment

Choose a reason for hiding this comment

Uh oh!

shauheen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

wschin commented Apr 2, 2019

Uh oh!

codecovBot commented Apr 2, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

artidoro left a comment

Choose a reason for hiding this comment

Uh oh!

artidoro commented Apr 4, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sfilipi commented Apr 5, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sfilipi left a comment

Choose a reason for hiding this comment

Uh oh!

shauheen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

wschin commented Apr 2, 2019

Uh oh!

codecovBot commented Apr 2, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

artidoro left a comment

Choose a reason for hiding this comment

codecovBot commented Apr 2, 2019•
edited
Loading

artidoro commented Apr 4, 2019•
edited
Loading

sfilipi commented Apr 5, 2019•
edited
Loading

codecovBot commented Apr 2, 2019•
edited
Loading

artidoro commented Apr 4, 2019•
edited
Loading

sfilipi commented Apr 5, 2019•
edited
Loading

codecovBot commented Apr 2, 2019•
edited
Loading

artidoro commented Apr 4, 2019•
edited
Loading

sfilipi commented Apr 5, 2019•
edited
Loading

codecovBot commented Apr 2, 2019•
edited
Loading

artidoro commented Apr 4, 2019•
edited
Loading

sfilipi commented Apr 5, 2019•
edited
Loading