Skip to content

Update IDataView principles, type system documentation. - #3288

Merged
TomFinley merged 4 commits into
dotnet:masterfrom
TomFinley:DocDataView
Apr 11, 2019
Merged

Update IDataView principles, type system documentation.#3288
TomFinley merged 4 commits into
dotnet:masterfrom
TomFinley:DocDataView

Conversation

@TomFinley

@TomFinleyTomFinley commented Apr 11, 2019

Copy link
Copy Markdown
Contributor

Towards #3095.

eerhardt
eerhardt reviewed Apr 11, 2019
View reviewed changes
Comment threadtest/Microsoft.ML.Tests/Transformers/KeyToBinaryVectorEstimatorTest.cs Outdated
eerhardt
eerhardt reviewed Apr 11, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.DataView/VectorType.cs Outdated
eerhardt
eerhardt reviewed Apr 11, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.DataView/VectorType.cs
eerhardt
eerhardt reviewed Apr 11, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.DataView/DataViewType.cs Outdated
eerhardt
eerhardt reviewed Apr 11, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.DataView/DataViewType.cs Outdated
eerhardt
eerhardt reviewed Apr 11, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.DataView/DataViewType.cs Outdated
eerhardt
eerhardt reviewed Apr 11, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.DataView/DataViewType.cs
eerhardt
eerhardt approved these changes Apr 11, 2019
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this doc work @TomFinley. It will definitely reap many rewards in the future.

Comment threaddocs/code/IDataViewDesignPrinciples.md Outdated
Comment threaddocs/code/IDataViewDesignPrinciples.md Outdated
Comment threaddocs/code/IDataViewDesignPrinciples.md Outdated
Comment threaddocs/code/IDataViewDesignPrinciples.md Outdated
Comment threaddocs/code/IDataViewDesignPrinciples.md Outdated
Comment threaddocs/code/IDataViewTypeSystem.md Outdated
Comment threaddocs/code/IDataViewTypeSystem.md Outdated
Comment threaddocs/code/IDataViewTypeSystem.md Outdated
Comment threaddocs/code/IDataViewTypeSystem.md Outdated
Comment threaddocs/code/IDataViewTypeSystem.md
shauheen
shauheen reviewed Apr 11, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.DataView/VectorType.cs
shauheen
shauheen reviewed Apr 11, 2019
View reviewed changes
Comment threadsrc/Microsoft.ML.DataView/VectorType.cs
shauheen
shauheen approved these changes Apr 11, 2019
View reviewed changes

@shauheenshauheen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov

codecovBot commented Apr 11, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3288 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3288 +/- ##
==========================================
+ Coverage 72.63% 72.65% +0.01% 
==========================================
Files 807 807 Lines 145129 145129 Branches 16220 16220 ==========================================
+ Hits 105417 105437 +20 + Misses 35295 35272 -23 - Partials 4417 4420 +3
FlagCoverage Δ
#Debug72.65% <ø> (+0.01%)⬆️
#production68.19% <ø> (+0.01%)⬆️
#test88.94% <ø> (ø)⬆️
Impacted FilesCoverage Δ
src/Microsoft.ML.Core/Data/IEstimator.cs84.53% <ø> (ø)⬆️
src/Microsoft.ML.DataView/VectorType.cs89.41% <ø> (ø)⬆️
src/Microsoft.ML.DataView/DataViewType.cs86.82% <ø> (ø)⬆️
...StandardTrainers/Standard/LinearModelParameters.cs60.31% <0%> (+0.26%)⬆️
src/Microsoft.ML.Core/Data/ProgressReporter.cs77.94% <0%> (+6.98%)⬆️

@TomFinley
TomFinley merged commit 9c03a1c into dotnet:masterApr 11, 2019
@TomFinley
TomFinley deleted the DocDataView branch April 11, 2019 17:53
@TomFinleyTomFinley mentioned this pull request Apr 11, 2019
Merged
TomFinley added a commit to TomFinley/machinelearning that referenced this pull request Apr 12, 2019
@TomFinley
Update IDataView principles, type system documentation. (dotnet#3288)
2429aaf
* Update IDataView principles, type system documentation.
@ghostghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Ivanidzo4kaIvanidzo4kaAwaiting requested review from Ivanidzo4ka
@sfilipisfilipiAwaiting requested review from sfilipi
2 more reviewers
@shauheenshauheenshauheen approved these changes
@eerhardteerhardteerhardt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomFinley@shauheen@eerhardt