Uh oh!
There was an error while loading. Please reload this page.
Update error messages to point to GitHub issues instead of support group - #359
Conversation
danmoseley
commented
Jun 15, 2018
Hi @jwood803, you should be able to eliminate the extra changes by either rebasing your branch onto master, or merging master into your branch. If you do the former (what I typically do) you will have to You're probably right that on merging, the changes should vanish, but if they do not entirely vanish, they are then committed to master, so it is best to have the PR look how you want it. |
jwood803
commented
Jun 15, 2018
Thanks, @danmosemsft! I'll make sure to remember that for next time. 😄 Hopefully, the PR is as it should be. |
danmoseley
commented
Jun 15, 2018
@jwood803 assuming you only wanted to make the comment changes, this didn't work, as they still show up: https://github.com/dotnet/machinelearning/pull/359/files My instructions were mistaken, then. I think what is easiest is you just do |
jwood803
commented
Jun 16, 2018
@danmosemsft Thanks a ton! I had to reset to upstream master, but I think I now got this correct! 😄 Thanks again for the help! |
shauheen
commented
Jun 26, 2018
Thanks @jwood803 for this PR. |
Ivanidzo4ka
left a comment
There was a problem hiding this comment.
Thank you for your PR @jwood803
*Update error messages to point to GitHub issues instead of support group
*Update error messages to point to GitHub issues instead of support group
Fix for issue #258 by replacing
tlcsuppwith a link to https://aka.ms/MLNetIssue.Due to my lacking git skills, some commits from #358 got in, but I believe that can get cleaned up if/when it gets merged.