Reformatting TensorFlow and AnomalyDetection samples to width 85 by sayanshaw24 · Pull Request #3922 · dotnet/machinelearning

sayanshaw24 · 2019-06-27T16:35:02Z

Guidelines followed:

85 characters per line
Use 4 spaces for indentation
Dot, open parentheses, and function/variable name on same line
Math operations on same line
Don't indent comments
Don't break links
Don't break a comment if it represents a print output
Add an extra line after a break if it does not already exist
Break before "$"

Fix for Issue #3478

dnfclas · 2019-06-27T16:35:14Z

All CLA requirements met.

wschin

Just left some minor comments. Overall LGTM.

…to samples

natke

A couple of suggestions

natke · 2019-06-28T17:38:42Z

+ // ML.NET Pipeline 

- Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i, j) =>
+ Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i,


This would be clearer if the (i, j) was on the same line

natke · 2019-06-28T17:47:27Z

- .Append(mlContext.Transforms.CopyColumns("Prediction", "Prediction/Softmax"))
- .Fit(dataView);
- var engine = mlContext.Model.CreatePredictionEngine<IMDBSentiment, OutputScores>(model);
+ var model = mlContext.Transforms.Text.TokenizeIntoWords(


It would be better to try and align the Append methods, as well as keep the transform strings together. Something like:
var model = mlContext.Transforms.Text.TokenizeIntoWords( "TokenizedWords", "Sentiment_Text") .Append(mlContext.Transforms.Conversion.MapValue( "VariableLengthFeatures", lookupMap, lookupMap.Schema["Words"], lookupMap.Schema["Ids"], "TokenizedWords")) .Append(mlContext.Transforms.CustomMapping( ResizeFeaturesAction, "Resize")) .Append(tensorFlowModel.ScoreTensorFlowModel( "Prediction/Softmax", "Features")) .Append(mlContext.Transforms.CopyColumns( "Prediction", "Prediction/Softmax")) .Fit(dataView);

natke

A couple of suggestions

codemzs · 2019-06-28T20:12:49Z

+ var image1 = Enumerable.Range(0, inputSize).Select(
+ x => (float)x / inputSize).ToArray();
+ var image2 = Enumerable.Range(0, inputSize).Select(
+ x => (float)(x + 10000) / inputSize).ToArray();


As discussed new line between any two lines that were broken into multiple lines.

…net#3922) * Testing * Reformatted TensorFlow samples to width 85 * Reformatted AnomalyDetection samples to width 85 * Fixed formatting errors * Made a few edits to TensorFlow samples format * Fixed syntax errors * Spacing changes

sayanshaw24 · 2019-06-27T16:35:02Z

Guidelines followed:

85 characters per line
Use 4 spaces for indentation
Dot, open parentheses, and function/variable name on same line
Math operations on same line
Don't indent comments
Don't break links
Don't break a comment if it represents a print output
Add an extra line after a break if it does not already exist
Break before "$"

Fix for Issue #3478

dnfclas · 2019-06-27T16:35:14Z

All CLA requirements met.

wschin

Just left some minor comments. Overall LGTM.

…to samples

natke

A couple of suggestions

natke · 2019-06-28T17:38:42Z

+ // ML.NET Pipeline 

- Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i, j) =>
+ Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i,


This would be clearer if the (i, j) was on the same line

natke · 2019-06-28T17:47:27Z

- .Append(mlContext.Transforms.CopyColumns("Prediction", "Prediction/Softmax"))
- .Fit(dataView);
- var engine = mlContext.Model.CreatePredictionEngine<IMDBSentiment, OutputScores>(model);
+ var model = mlContext.Transforms.Text.TokenizeIntoWords(


It would be better to try and align the Append methods, as well as keep the transform strings together. Something like:
var model = mlContext.Transforms.Text.TokenizeIntoWords( "TokenizedWords", "Sentiment_Text") .Append(mlContext.Transforms.Conversion.MapValue( "VariableLengthFeatures", lookupMap, lookupMap.Schema["Words"], lookupMap.Schema["Ids"], "TokenizedWords")) .Append(mlContext.Transforms.CustomMapping( ResizeFeaturesAction, "Resize")) .Append(tensorFlowModel.ScoreTensorFlowModel( "Prediction/Softmax", "Features")) .Append(mlContext.Transforms.CopyColumns( "Prediction", "Prediction/Softmax")) .Fit(dataView);

natke

A couple of suggestions

codemzs · 2019-06-28T20:12:49Z

+ var image1 = Enumerable.Range(0, inputSize).Select(
+ x => (float)x / inputSize).ToArray();
+ var image2 = Enumerable.Range(0, inputSize).Select(
+ x => (float)(x + 10000) / inputSize).ToArray();


As discussed new line between any two lines that were broken into multiple lines.

…net#3922) * Testing * Reformatted TensorFlow samples to width 85 * Reformatted AnomalyDetection samples to width 85 * Fixed formatting errors * Made a few edits to TensorFlow samples format * Fixed syntax errors * Spacing changes

sayanshaw24 · 2019-06-27T16:35:02Z

Guidelines followed:

85 characters per line
Use 4 spaces for indentation
Dot, open parentheses, and function/variable name on same line
Math operations on same line
Don't indent comments
Don't break links
Don't break a comment if it represents a print output
Add an extra line after a break if it does not already exist
Break before "$"

Fix for Issue #3478

dnfclas · 2019-06-27T16:35:14Z

All CLA requirements met.

wschin

Just left some minor comments. Overall LGTM.

…to samples

natke

A couple of suggestions

natke · 2019-06-28T17:38:42Z

+ // ML.NET Pipeline 

- Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i, j) =>
+ Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i,


This would be clearer if the (i, j) was on the same line

natke · 2019-06-28T17:47:27Z

- .Append(mlContext.Transforms.CopyColumns("Prediction", "Prediction/Softmax"))
- .Fit(dataView);
- var engine = mlContext.Model.CreatePredictionEngine<IMDBSentiment, OutputScores>(model);
+ var model = mlContext.Transforms.Text.TokenizeIntoWords(


It would be better to try and align the Append methods, as well as keep the transform strings together. Something like:
var model = mlContext.Transforms.Text.TokenizeIntoWords( "TokenizedWords", "Sentiment_Text") .Append(mlContext.Transforms.Conversion.MapValue( "VariableLengthFeatures", lookupMap, lookupMap.Schema["Words"], lookupMap.Schema["Ids"], "TokenizedWords")) .Append(mlContext.Transforms.CustomMapping( ResizeFeaturesAction, "Resize")) .Append(tensorFlowModel.ScoreTensorFlowModel( "Prediction/Softmax", "Features")) .Append(mlContext.Transforms.CopyColumns( "Prediction", "Prediction/Softmax")) .Fit(dataView);

natke

A couple of suggestions

codemzs · 2019-06-28T20:12:49Z

+ var image1 = Enumerable.Range(0, inputSize).Select(
+ x => (float)x / inputSize).ToArray();
+ var image2 = Enumerable.Range(0, inputSize).Select(
+ x => (float)(x + 10000) / inputSize).ToArray();


As discussed new line between any two lines that were broken into multiple lines.

…net#3922) * Testing * Reformatted TensorFlow samples to width 85 * Reformatted AnomalyDetection samples to width 85 * Fixed formatting errors * Made a few edits to TensorFlow samples format * Fixed syntax errors * Spacing changes

sayanshaw24 · 2019-06-27T16:35:02Z

Guidelines followed:

85 characters per line
Use 4 spaces for indentation
Dot, open parentheses, and function/variable name on same line
Math operations on same line
Don't indent comments
Don't break links
Don't break a comment if it represents a print output
Add an extra line after a break if it does not already exist
Break before "$"

Fix for Issue #3478

dnfclas · 2019-06-27T16:35:14Z

All CLA requirements met.

wschin

Just left some minor comments. Overall LGTM.

…to samples

natke

A couple of suggestions

natke · 2019-06-28T17:38:42Z

+ // ML.NET Pipeline 

- Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i, j) =>
+ Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i,


This would be clearer if the (i, j) was on the same line

natke · 2019-06-28T17:47:27Z

- .Append(mlContext.Transforms.CopyColumns("Prediction", "Prediction/Softmax"))
- .Fit(dataView);
- var engine = mlContext.Model.CreatePredictionEngine<IMDBSentiment, OutputScores>(model);
+ var model = mlContext.Transforms.Text.TokenizeIntoWords(


It would be better to try and align the Append methods, as well as keep the transform strings together. Something like:
var model = mlContext.Transforms.Text.TokenizeIntoWords( "TokenizedWords", "Sentiment_Text") .Append(mlContext.Transforms.Conversion.MapValue( "VariableLengthFeatures", lookupMap, lookupMap.Schema["Words"], lookupMap.Schema["Ids"], "TokenizedWords")) .Append(mlContext.Transforms.CustomMapping( ResizeFeaturesAction, "Resize")) .Append(tensorFlowModel.ScoreTensorFlowModel( "Prediction/Softmax", "Features")) .Append(mlContext.Transforms.CopyColumns( "Prediction", "Prediction/Softmax")) .Fit(dataView);

natke

A couple of suggestions

codemzs · 2019-06-28T20:12:49Z

+ var image1 = Enumerable.Range(0, inputSize).Select(
+ x => (float)x / inputSize).ToArray();
+ var image2 = Enumerable.Range(0, inputSize).Select(
+ x => (float)(x + 10000) / inputSize).ToArray();


As discussed new line between any two lines that were broken into multiple lines.

…net#3922) * Testing * Reformatted TensorFlow samples to width 85 * Reformatted AnomalyDetection samples to width 85 * Fixed formatting errors * Made a few edits to TensorFlow samples format * Fixed syntax errors * Spacing changes

sayanshaw24 · 2019-06-27T16:35:02Z

Guidelines followed:

85 characters per line
Use 4 spaces for indentation
Dot, open parentheses, and function/variable name on same line
Math operations on same line
Don't indent comments
Don't break links
Don't break a comment if it represents a print output
Add an extra line after a break if it does not already exist
Break before "$"

Fix for Issue #3478

dnfclas · 2019-06-27T16:35:14Z

All CLA requirements met.

wschin

Just left some minor comments. Overall LGTM.

…to samples

natke

A couple of suggestions

natke · 2019-06-28T17:38:42Z

+ // ML.NET Pipeline 

- Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i, j) =>
+ Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i,


This would be clearer if the (i, j) was on the same line

natke · 2019-06-28T17:47:27Z

- .Append(mlContext.Transforms.CopyColumns("Prediction", "Prediction/Softmax"))
- .Fit(dataView);
- var engine = mlContext.Model.CreatePredictionEngine<IMDBSentiment, OutputScores>(model);
+ var model = mlContext.Transforms.Text.TokenizeIntoWords(


It would be better to try and align the Append methods, as well as keep the transform strings together. Something like:
var model = mlContext.Transforms.Text.TokenizeIntoWords( "TokenizedWords", "Sentiment_Text") .Append(mlContext.Transforms.Conversion.MapValue( "VariableLengthFeatures", lookupMap, lookupMap.Schema["Words"], lookupMap.Schema["Ids"], "TokenizedWords")) .Append(mlContext.Transforms.CustomMapping( ResizeFeaturesAction, "Resize")) .Append(tensorFlowModel.ScoreTensorFlowModel( "Prediction/Softmax", "Features")) .Append(mlContext.Transforms.CopyColumns( "Prediction", "Prediction/Softmax")) .Fit(dataView);

natke

A couple of suggestions

codemzs · 2019-06-28T20:12:49Z

+ var image1 = Enumerable.Range(0, inputSize).Select(
+ x => (float)x / inputSize).ToArray();
+ var image2 = Enumerable.Range(0, inputSize).Select(
+ x => (float)(x + 10000) / inputSize).ToArray();


As discussed new line between any two lines that were broken into multiple lines.

…net#3922) * Testing * Reformatted TensorFlow samples to width 85 * Reformatted AnomalyDetection samples to width 85 * Fixed formatting errors * Made a few edits to TensorFlow samples format * Fixed syntax errors * Spacing changes

sayanshaw24 · 2019-06-27T16:35:02Z

Guidelines followed:

85 characters per line
Use 4 spaces for indentation
Dot, open parentheses, and function/variable name on same line
Math operations on same line
Don't indent comments
Don't break links
Don't break a comment if it represents a print output
Add an extra line after a break if it does not already exist
Break before "$"

Fix for Issue #3478

dnfclas · 2019-06-27T16:35:14Z

All CLA requirements met.

wschin

Just left some minor comments. Overall LGTM.

…to samples

natke

A couple of suggestions

natke · 2019-06-28T17:38:42Z

+ // ML.NET Pipeline 

- Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i, j) =>
+ Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i,


This would be clearer if the (i, j) was on the same line

natke · 2019-06-28T17:47:27Z

- .Append(mlContext.Transforms.CopyColumns("Prediction", "Prediction/Softmax"))
- .Fit(dataView);
- var engine = mlContext.Model.CreatePredictionEngine<IMDBSentiment, OutputScores>(model);
+ var model = mlContext.Transforms.Text.TokenizeIntoWords(


It would be better to try and align the Append methods, as well as keep the transform strings together. Something like:
var model = mlContext.Transforms.Text.TokenizeIntoWords( "TokenizedWords", "Sentiment_Text") .Append(mlContext.Transforms.Conversion.MapValue( "VariableLengthFeatures", lookupMap, lookupMap.Schema["Words"], lookupMap.Schema["Ids"], "TokenizedWords")) .Append(mlContext.Transforms.CustomMapping( ResizeFeaturesAction, "Resize")) .Append(tensorFlowModel.ScoreTensorFlowModel( "Prediction/Softmax", "Features")) .Append(mlContext.Transforms.CopyColumns( "Prediction", "Prediction/Softmax")) .Fit(dataView);

natke

A couple of suggestions

codemzs · 2019-06-28T20:12:49Z

+ var image1 = Enumerable.Range(0, inputSize).Select(
+ x => (float)x / inputSize).ToArray();
+ var image2 = Enumerable.Range(0, inputSize).Select(
+ x => (float)(x + 10000) / inputSize).ToArray();


As discussed new line between any two lines that were broken into multiple lines.

…net#3922) * Testing * Reformatted TensorFlow samples to width 85 * Reformatted AnomalyDetection samples to width 85 * Fixed formatting errors * Made a few edits to TensorFlow samples format * Fixed syntax errors * Spacing changes

sayanshaw24 · 2019-06-27T16:35:02Z

Guidelines followed:

85 characters per line
Use 4 spaces for indentation
Dot, open parentheses, and function/variable name on same line
Math operations on same line
Don't indent comments
Don't break links
Don't break a comment if it represents a print output
Add an extra line after a break if it does not already exist
Break before "$"

Fix for Issue #3478

dnfclas · 2019-06-27T16:35:14Z

All CLA requirements met.

wschin

Just left some minor comments. Overall LGTM.

…to samples

natke

A couple of suggestions

natke · 2019-06-28T17:38:42Z

+ // ML.NET Pipeline 

- Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i, j) =>
+ Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i,


This would be clearer if the (i, j) was on the same line

natke · 2019-06-28T17:47:27Z

- .Append(mlContext.Transforms.CopyColumns("Prediction", "Prediction/Softmax"))
- .Fit(dataView);
- var engine = mlContext.Model.CreatePredictionEngine<IMDBSentiment, OutputScores>(model);
+ var model = mlContext.Transforms.Text.TokenizeIntoWords(


It would be better to try and align the Append methods, as well as keep the transform strings together. Something like:
var model = mlContext.Transforms.Text.TokenizeIntoWords( "TokenizedWords", "Sentiment_Text") .Append(mlContext.Transforms.Conversion.MapValue( "VariableLengthFeatures", lookupMap, lookupMap.Schema["Words"], lookupMap.Schema["Ids"], "TokenizedWords")) .Append(mlContext.Transforms.CustomMapping( ResizeFeaturesAction, "Resize")) .Append(tensorFlowModel.ScoreTensorFlowModel( "Prediction/Softmax", "Features")) .Append(mlContext.Transforms.CopyColumns( "Prediction", "Prediction/Softmax")) .Fit(dataView);

natke

A couple of suggestions

codemzs · 2019-06-28T20:12:49Z

+ var image1 = Enumerable.Range(0, inputSize).Select(
+ x => (float)x / inputSize).ToArray();
+ var image2 = Enumerable.Range(0, inputSize).Select(
+ x => (float)(x + 10000) / inputSize).ToArray();


As discussed new line between any two lines that were broken into multiple lines.

…net#3922) * Testing * Reformatted TensorFlow samples to width 85 * Reformatted AnomalyDetection samples to width 85 * Fixed formatting errors * Made a few edits to TensorFlow samples format * Fixed syntax errors * Spacing changes

sayanshaw24 · 2019-06-27T16:35:02Z

Guidelines followed:

85 characters per line
Use 4 spaces for indentation
Dot, open parentheses, and function/variable name on same line
Math operations on same line
Don't indent comments
Don't break links
Don't break a comment if it represents a print output
Add an extra line after a break if it does not already exist
Break before "$"

Fix for Issue #3478

dnfclas · 2019-06-27T16:35:14Z

All CLA requirements met.

wschin

Just left some minor comments. Overall LGTM.

…to samples

natke

A couple of suggestions

natke · 2019-06-28T17:38:42Z

+ // ML.NET Pipeline 

- Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i, j) =>
+ Action<IMDBSentiment, IntermediateFeatures> ResizeFeaturesAction = (i,


This would be clearer if the (i, j) was on the same line

natke · 2019-06-28T17:47:27Z

- .Append(mlContext.Transforms.CopyColumns("Prediction", "Prediction/Softmax"))
- .Fit(dataView);
- var engine = mlContext.Model.CreatePredictionEngine<IMDBSentiment, OutputScores>(model);
+ var model = mlContext.Transforms.Text.TokenizeIntoWords(


It would be better to try and align the Append methods, as well as keep the transform strings together. Something like:
var model = mlContext.Transforms.Text.TokenizeIntoWords( "TokenizedWords", "Sentiment_Text") .Append(mlContext.Transforms.Conversion.MapValue( "VariableLengthFeatures", lookupMap, lookupMap.Schema["Words"], lookupMap.Schema["Ids"], "TokenizedWords")) .Append(mlContext.Transforms.CustomMapping( ResizeFeaturesAction, "Resize")) .Append(tensorFlowModel.ScoreTensorFlowModel( "Prediction/Softmax", "Features")) .Append(mlContext.Transforms.CopyColumns( "Prediction", "Prediction/Softmax")) .Fit(dataView);

natke

A couple of suggestions

codemzs · 2019-06-28T20:12:49Z

+ var image1 = Enumerable.Range(0, inputSize).Select(
+ x => (float)x / inputSize).ToArray();
+ var image2 = Enumerable.Range(0, inputSize).Select(
+ x => (float)(x + 10000) / inputSize).ToArray();


As discussed new line between any two lines that were broken into multiple lines.

…net#3922) * Testing * Reformatted TensorFlow samples to width 85 * Reformatted AnomalyDetection samples to width 85 * Fixed formatting errors * Made a few edits to TensorFlow samples format * Fixed syntax errors * Spacing changes

sayanshaw24 added 3 commits June 25, 2019 20:09

Just trying stuff out!
94553e9

Testing
f24dd62

Reformatted TensorFlow samples to width 85
a0bc22b

sayanshaw24 requested review from artidoro, codemzs and wschin June 27, 2019 16:35

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

sayanshaw24 requested a review from natke June 27, 2019 17:28

Reformatted AnomalyDetection samples to width 85
cb39e85

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment thread...les/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSampleWithOptions.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSample.cs

wschin approved these changes Jun 27, 2019
View reviewed changes

sayanshaw24 changed the title ~~Reformatting TensorFlow samples to width 85~~Reformatting TensorFlow and AnomalyDetection samples to width 85Jun 27, 2019

sayanshaw24 added 2 commits June 27, 2019 13:57

Fixed formatting errors
8b218f0

Merge branch 'master' ofhttps://github.com/dotnet/machinelearningin…
6364b31
…to samples

natke reviewed Jun 28, 2019
View reviewed changes

Made a few edits to TensorFlow samples format
d91086e

natke approved these changes Jun 28, 2019
View reviewed changes

codemzs reviewed Jun 28, 2019
View reviewed changes

sayanshaw24 added 2 commits June 28, 2019 15:39

Fixed syntax errors
65355fc

Spacing changes
0fcebec

sayanshaw24 merged commit e0c4caa into dotnet:masterJun 29, 2019

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

sayanshaw24 added 3 commits June 25, 2019 20:09

Just trying stuff out!
94553e9

Testing
f24dd62

Reformatted TensorFlow samples to width 85
a0bc22b

sayanshaw24 requested review from artidoro, codemzs and wschin June 27, 2019 16:35

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

sayanshaw24 requested a review from natke June 27, 2019 17:28

Reformatted AnomalyDetection samples to width 85
cb39e85

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment thread...les/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSampleWithOptions.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSample.cs

wschin approved these changes Jun 27, 2019
View reviewed changes

sayanshaw24 changed the title ~~Reformatting TensorFlow samples to width 85~~Reformatting TensorFlow and AnomalyDetection samples to width 85Jun 27, 2019

sayanshaw24 added 2 commits June 27, 2019 13:57

Fixed formatting errors
8b218f0

Merge branch 'master' ofhttps://github.com/dotnet/machinelearningin…
6364b31
…to samples

natke reviewed Jun 28, 2019
View reviewed changes

Made a few edits to TensorFlow samples format
d91086e

natke approved these changes Jun 28, 2019
View reviewed changes

codemzs reviewed Jun 28, 2019
View reviewed changes

sayanshaw24 added 2 commits June 28, 2019 15:39

Fixed syntax errors
65355fc

Spacing changes
0fcebec

sayanshaw24 merged commit e0c4caa into dotnet:masterJun 29, 2019

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

sayanshaw24 added 3 commits June 25, 2019 20:09

Just trying stuff out!
94553e9

Testing
f24dd62

Reformatted TensorFlow samples to width 85
a0bc22b

sayanshaw24 requested review from artidoro, codemzs and wschin June 27, 2019 16:35

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

sayanshaw24 requested a review from natke June 27, 2019 17:28

Reformatted AnomalyDetection samples to width 85
cb39e85

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment thread...les/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSampleWithOptions.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSample.cs

wschin approved these changes Jun 27, 2019
View reviewed changes

sayanshaw24 changed the title ~~Reformatting TensorFlow samples to width 85~~Reformatting TensorFlow and AnomalyDetection samples to width 85Jun 27, 2019

sayanshaw24 added 2 commits June 27, 2019 13:57

Fixed formatting errors
8b218f0

Merge branch 'master' ofhttps://github.com/dotnet/machinelearningin…
6364b31
…to samples

natke reviewed Jun 28, 2019
View reviewed changes

Made a few edits to TensorFlow samples format
d91086e

natke approved these changes Jun 28, 2019
View reviewed changes

codemzs reviewed Jun 28, 2019
View reviewed changes

sayanshaw24 added 2 commits June 28, 2019 15:39

Fixed syntax errors
65355fc

Spacing changes
0fcebec

sayanshaw24 merged commit e0c4caa into dotnet:masterJun 29, 2019

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

sayanshaw24 added 3 commits June 25, 2019 20:09

Just trying stuff out!
94553e9

Testing
f24dd62

Reformatted TensorFlow samples to width 85
a0bc22b

sayanshaw24 requested review from artidoro, codemzs and wschin June 27, 2019 16:35

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

sayanshaw24 requested a review from natke June 27, 2019 17:28

Reformatted AnomalyDetection samples to width 85
cb39e85

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment thread...les/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSampleWithOptions.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSample.cs

wschin approved these changes Jun 27, 2019
View reviewed changes

sayanshaw24 changed the title ~~Reformatting TensorFlow samples to width 85~~Reformatting TensorFlow and AnomalyDetection samples to width 85Jun 27, 2019

sayanshaw24 added 2 commits June 27, 2019 13:57

Fixed formatting errors
8b218f0

Merge branch 'master' ofhttps://github.com/dotnet/machinelearningin…
6364b31
…to samples

natke reviewed Jun 28, 2019
View reviewed changes

Made a few edits to TensorFlow samples format
d91086e

natke approved these changes Jun 28, 2019
View reviewed changes

codemzs reviewed Jun 28, 2019
View reviewed changes

sayanshaw24 added 2 commits June 28, 2019 15:39

Fixed syntax errors
65355fc

Spacing changes
0fcebec

sayanshaw24 merged commit e0c4caa into dotnet:masterJun 29, 2019

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

sayanshaw24 added 3 commits June 25, 2019 20:09

Just trying stuff out!
94553e9

Testing
f24dd62

Reformatted TensorFlow samples to width 85
a0bc22b

sayanshaw24 requested review from artidoro, codemzs and wschin June 27, 2019 16:35

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

sayanshaw24 requested a review from natke June 27, 2019 17:28

Reformatted AnomalyDetection samples to width 85
cb39e85

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment thread...les/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSampleWithOptions.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSample.cs

wschin approved these changes Jun 27, 2019
View reviewed changes

sayanshaw24 changed the title ~~Reformatting TensorFlow samples to width 85~~Reformatting TensorFlow and AnomalyDetection samples to width 85Jun 27, 2019

sayanshaw24 added 2 commits June 27, 2019 13:57

Fixed formatting errors
8b218f0

Merge branch 'master' ofhttps://github.com/dotnet/machinelearningin…
6364b31
…to samples

natke reviewed Jun 28, 2019
View reviewed changes

Made a few edits to TensorFlow samples format
d91086e

natke approved these changes Jun 28, 2019
View reviewed changes

codemzs reviewed Jun 28, 2019
View reviewed changes

sayanshaw24 added 2 commits June 28, 2019 15:39

Fixed syntax errors
65355fc

Spacing changes
0fcebec

sayanshaw24 merged commit e0c4caa into dotnet:masterJun 29, 2019

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

sayanshaw24 added 3 commits June 25, 2019 20:09

Just trying stuff out!
94553e9

Testing
f24dd62

Reformatted TensorFlow samples to width 85
a0bc22b

sayanshaw24 requested review from artidoro, codemzs and wschin June 27, 2019 16:35

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

sayanshaw24 requested a review from natke June 27, 2019 17:28

Reformatted AnomalyDetection samples to width 85
cb39e85

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment thread...les/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSampleWithOptions.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSample.cs

wschin approved these changes Jun 27, 2019
View reviewed changes

sayanshaw24 changed the title ~~Reformatting TensorFlow samples to width 85~~Reformatting TensorFlow and AnomalyDetection samples to width 85Jun 27, 2019

sayanshaw24 added 2 commits June 27, 2019 13:57

Fixed formatting errors
8b218f0

Merge branch 'master' ofhttps://github.com/dotnet/machinelearningin…
6364b31
…to samples

natke reviewed Jun 28, 2019
View reviewed changes

Made a few edits to TensorFlow samples format
d91086e

natke approved these changes Jun 28, 2019
View reviewed changes

codemzs reviewed Jun 28, 2019
View reviewed changes

sayanshaw24 added 2 commits June 28, 2019 15:39

Fixed syntax errors
65355fc

Spacing changes
0fcebec

sayanshaw24 merged commit e0c4caa into dotnet:masterJun 29, 2019

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

sayanshaw24 added 3 commits June 25, 2019 20:09

Just trying stuff out!
94553e9

Testing
f24dd62

Reformatted TensorFlow samples to width 85
a0bc22b

sayanshaw24 requested review from artidoro, codemzs and wschin June 27, 2019 16:35

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

sayanshaw24 requested a review from natke June 27, 2019 17:28

Reformatted AnomalyDetection samples to width 85
cb39e85

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment thread...les/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSampleWithOptions.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSample.cs

wschin approved these changes Jun 27, 2019
View reviewed changes

sayanshaw24 changed the title ~~Reformatting TensorFlow samples to width 85~~Reformatting TensorFlow and AnomalyDetection samples to width 85Jun 27, 2019

sayanshaw24 added 2 commits June 27, 2019 13:57

Fixed formatting errors
8b218f0

Merge branch 'master' ofhttps://github.com/dotnet/machinelearningin…
6364b31
…to samples

natke reviewed Jun 28, 2019
View reviewed changes

Made a few edits to TensorFlow samples format
d91086e

natke approved these changes Jun 28, 2019
View reviewed changes

codemzs reviewed Jun 28, 2019
View reviewed changes

sayanshaw24 added 2 commits June 28, 2019 15:39

Fixed syntax errors
65355fc

Spacing changes
0fcebec

sayanshaw24 merged commit e0c4caa into dotnet:masterJun 29, 2019

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

sayanshaw24 added 3 commits June 25, 2019 20:09

Just trying stuff out!
94553e9

Testing
f24dd62

Reformatted TensorFlow samples to width 85
a0bc22b

sayanshaw24 requested review from artidoro, codemzs and wschin June 27, 2019 16:35

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

sayanshaw24 requested a review from natke June 27, 2019 17:28

Reformatted AnomalyDetection samples to width 85
cb39e85

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment thread...les/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSampleWithOptions.cs Outdated

wschin reviewed Jun 27, 2019
View reviewed changes

Comment threaddocs/samples/Microsoft.ML.Samples/Dynamic/Trainers/AnomalyDetection/RandomizedPcaSample.cs

wschin approved these changes Jun 27, 2019
View reviewed changes

sayanshaw24 changed the title ~~Reformatting TensorFlow samples to width 85~~Reformatting TensorFlow and AnomalyDetection samples to width 85Jun 27, 2019

sayanshaw24 added 2 commits June 27, 2019 13:57

Fixed formatting errors
8b218f0

Merge branch 'master' ofhttps://github.com/dotnet/machinelearningin…
6364b31
…to samples

natke reviewed Jun 28, 2019
View reviewed changes

Made a few edits to TensorFlow samples format
d91086e

natke approved these changes Jun 28, 2019
View reviewed changes

codemzs reviewed Jun 28, 2019
View reviewed changes

sayanshaw24 added 2 commits June 28, 2019 15:39

Fixed syntax errors
65355fc

Spacing changes
0fcebec

sayanshaw24 merged commit e0c4caa into dotnet:masterJun 29, 2019

ghost locked as resolved and limited conversation to collaborators Mar 21, 2022

Uh oh!

Conversation

sayanshaw24 commented Jun 27, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnfclas commented Jun 27, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wschin left a comment

Choose a reason for hiding this comment

Uh oh!

natke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

natke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

sayanshaw24 commented Jun 27, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnfclas commented Jun 27, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wschin left a comment

Choose a reason for hiding this comment

Uh oh!

natke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

natke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

sayanshaw24 commented Jun 27, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnfclas commented Jun 27, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

sayanshaw24 commented Jun 27, 2019•
edited
Loading

dnfclas commented Jun 27, 2019•
edited
Loading

sayanshaw24 commented Jun 27, 2019•
edited
Loading

dnfclas commented Jun 27, 2019•
edited
Loading

sayanshaw24 commented Jun 27, 2019•
edited
Loading

dnfclas commented Jun 27, 2019•
edited
Loading

sayanshaw24 commented Jun 27, 2019•
edited
Loading

dnfclas commented Jun 27, 2019•
edited
Loading