Fix iris.txt dataset and modify Iris Classification tests accordingly by bojanmisic · Pull Request #428 · dotnet/machinelearning

bojanmisic · 2018-06-27T09:42:41Z

Related to issue #400.

Reordered column values in iris.txt (headers stay the same), so the previously Petal width values are actually Sepal length values; other columns shifted to the right.
Tests TrainAndPredictIrisModelTest and TrainAndPredictIrisModelWithStringLabelTest are modified accordingly so that the values that test the prediction are also reordered to be more realistic (same way the dataset is modified).
Model class IrisDataWithStringLabel fields reordered to match iris.data dataset.

The fix for the samples repo that uses the same dataset will follow.

dnfclas · 2018-06-27T09:42:52Z

All CLA requirements met.

bojanmisic · 2018-06-27T10:05:19Z

Ok, just realized some additional tests need to be covered. #Resolved

sfilipi · 2018-06-27T15:30:49Z

Thanks for taking care of this, Bojan.

Take a look at the results of the tests as well, they might need update since the dataset is changing quite a bit.

In reply to: 400616611 [](ancestors = 400616611)

sfilipi · 2018-06-27T15:31:38Z

 Assert.Equal(49, matrix["2", "2"]);

see if anything here need be updated.

It might be the case for other tests using this dataset. #Resolved

Refers to: test/Microsoft.ML.Tests/Scenarios/IrisPlantClassificationTests.cs:113 in 57b9fc3. [](commit_id = 57b9fc3, deletion_comment = False)

…taset and LightGBM

bojanmisic · 2018-06-28T07:54:23Z

Thanks Senja!

Removing WIP and adding new change:

Tests MultiClassifierLightGMBKeyLabelTest and MultiClassifierLightGBMKeyLabelU404Test were failing since used Iris dataset was changed significantly, so baseline test files needed to be updated (latest commit). Pinging @codemzs since he was the author.

Ivanidzo4ka

sfilipi

…dotnet#428) * Fix iris.txt dataset and modify Iris Classification tests accordingly * Modify baseline test files for multiclass classification with Iris dataset and LightGBM

bojanmisic · 2018-06-27T09:42:41Z

Related to issue #400.

Reordered column values in iris.txt (headers stay the same), so the previously Petal width values are actually Sepal length values; other columns shifted to the right.
Tests TrainAndPredictIrisModelTest and TrainAndPredictIrisModelWithStringLabelTest are modified accordingly so that the values that test the prediction are also reordered to be more realistic (same way the dataset is modified).
Model class IrisDataWithStringLabel fields reordered to match iris.data dataset.

The fix for the samples repo that uses the same dataset will follow.

dnfclas · 2018-06-27T09:42:52Z

All CLA requirements met.

bojanmisic · 2018-06-27T10:05:19Z

Ok, just realized some additional tests need to be covered. #Resolved

sfilipi · 2018-06-27T15:30:49Z

Thanks for taking care of this, Bojan.

Take a look at the results of the tests as well, they might need update since the dataset is changing quite a bit.

In reply to: 400616611 [](ancestors = 400616611)

sfilipi · 2018-06-27T15:31:38Z

 Assert.Equal(49, matrix["2", "2"]);

see if anything here need be updated.

It might be the case for other tests using this dataset. #Resolved

Refers to: test/Microsoft.ML.Tests/Scenarios/IrisPlantClassificationTests.cs:113 in 57b9fc3. [](commit_id = 57b9fc3, deletion_comment = False)

…taset and LightGBM

bojanmisic · 2018-06-28T07:54:23Z

Thanks Senja!

Removing WIP and adding new change:

Tests MultiClassifierLightGMBKeyLabelTest and MultiClassifierLightGBMKeyLabelU404Test were failing since used Iris dataset was changed significantly, so baseline test files needed to be updated (latest commit). Pinging @codemzs since he was the author.

Ivanidzo4ka

sfilipi

…dotnet#428) * Fix iris.txt dataset and modify Iris Classification tests accordingly * Modify baseline test files for multiclass classification with Iris dataset and LightGBM

bojanmisic · 2018-06-27T09:42:41Z

Related to issue #400.

Reordered column values in iris.txt (headers stay the same), so the previously Petal width values are actually Sepal length values; other columns shifted to the right.
Tests TrainAndPredictIrisModelTest and TrainAndPredictIrisModelWithStringLabelTest are modified accordingly so that the values that test the prediction are also reordered to be more realistic (same way the dataset is modified).
Model class IrisDataWithStringLabel fields reordered to match iris.data dataset.

The fix for the samples repo that uses the same dataset will follow.

dnfclas · 2018-06-27T09:42:52Z

All CLA requirements met.

bojanmisic · 2018-06-27T10:05:19Z

Ok, just realized some additional tests need to be covered. #Resolved

sfilipi · 2018-06-27T15:30:49Z

Thanks for taking care of this, Bojan.

Take a look at the results of the tests as well, they might need update since the dataset is changing quite a bit.

In reply to: 400616611 [](ancestors = 400616611)

sfilipi · 2018-06-27T15:31:38Z

 Assert.Equal(49, matrix["2", "2"]);

see if anything here need be updated.

It might be the case for other tests using this dataset. #Resolved

Refers to: test/Microsoft.ML.Tests/Scenarios/IrisPlantClassificationTests.cs:113 in 57b9fc3. [](commit_id = 57b9fc3, deletion_comment = False)

…taset and LightGBM

bojanmisic · 2018-06-28T07:54:23Z

Thanks Senja!

Removing WIP and adding new change:

Tests MultiClassifierLightGMBKeyLabelTest and MultiClassifierLightGBMKeyLabelU404Test were failing since used Iris dataset was changed significantly, so baseline test files needed to be updated (latest commit). Pinging @codemzs since he was the author.

Ivanidzo4ka

sfilipi

…dotnet#428) * Fix iris.txt dataset and modify Iris Classification tests accordingly * Modify baseline test files for multiclass classification with Iris dataset and LightGBM

bojanmisic · 2018-06-27T09:42:41Z

Related to issue #400.

Reordered column values in iris.txt (headers stay the same), so the previously Petal width values are actually Sepal length values; other columns shifted to the right.
Tests TrainAndPredictIrisModelTest and TrainAndPredictIrisModelWithStringLabelTest are modified accordingly so that the values that test the prediction are also reordered to be more realistic (same way the dataset is modified).
Model class IrisDataWithStringLabel fields reordered to match iris.data dataset.

The fix for the samples repo that uses the same dataset will follow.

dnfclas · 2018-06-27T09:42:52Z

All CLA requirements met.

bojanmisic · 2018-06-27T10:05:19Z

Ok, just realized some additional tests need to be covered. #Resolved

sfilipi · 2018-06-27T15:30:49Z

Thanks for taking care of this, Bojan.

Take a look at the results of the tests as well, they might need update since the dataset is changing quite a bit.

In reply to: 400616611 [](ancestors = 400616611)

sfilipi · 2018-06-27T15:31:38Z

 Assert.Equal(49, matrix["2", "2"]);

see if anything here need be updated.

It might be the case for other tests using this dataset. #Resolved

Refers to: test/Microsoft.ML.Tests/Scenarios/IrisPlantClassificationTests.cs:113 in 57b9fc3. [](commit_id = 57b9fc3, deletion_comment = False)

…taset and LightGBM

bojanmisic · 2018-06-28T07:54:23Z

Thanks Senja!

Removing WIP and adding new change:

Tests MultiClassifierLightGMBKeyLabelTest and MultiClassifierLightGBMKeyLabelU404Test were failing since used Iris dataset was changed significantly, so baseline test files needed to be updated (latest commit). Pinging @codemzs since he was the author.

Ivanidzo4ka

sfilipi

…dotnet#428) * Fix iris.txt dataset and modify Iris Classification tests accordingly * Modify baseline test files for multiclass classification with Iris dataset and LightGBM

bojanmisic · 2018-06-27T09:42:41Z

Related to issue #400.

Reordered column values in iris.txt (headers stay the same), so the previously Petal width values are actually Sepal length values; other columns shifted to the right.
Tests TrainAndPredictIrisModelTest and TrainAndPredictIrisModelWithStringLabelTest are modified accordingly so that the values that test the prediction are also reordered to be more realistic (same way the dataset is modified).
Model class IrisDataWithStringLabel fields reordered to match iris.data dataset.

The fix for the samples repo that uses the same dataset will follow.

dnfclas · 2018-06-27T09:42:52Z

All CLA requirements met.

bojanmisic · 2018-06-27T10:05:19Z

Ok, just realized some additional tests need to be covered. #Resolved

sfilipi · 2018-06-27T15:30:49Z

Thanks for taking care of this, Bojan.

Take a look at the results of the tests as well, they might need update since the dataset is changing quite a bit.

In reply to: 400616611 [](ancestors = 400616611)

sfilipi · 2018-06-27T15:31:38Z

 Assert.Equal(49, matrix["2", "2"]);

see if anything here need be updated.

It might be the case for other tests using this dataset. #Resolved

Refers to: test/Microsoft.ML.Tests/Scenarios/IrisPlantClassificationTests.cs:113 in 57b9fc3. [](commit_id = 57b9fc3, deletion_comment = False)

…taset and LightGBM

bojanmisic · 2018-06-28T07:54:23Z

Thanks Senja!

Removing WIP and adding new change:

Tests MultiClassifierLightGMBKeyLabelTest and MultiClassifierLightGBMKeyLabelU404Test were failing since used Iris dataset was changed significantly, so baseline test files needed to be updated (latest commit). Pinging @codemzs since he was the author.

Ivanidzo4ka

sfilipi

…dotnet#428) * Fix iris.txt dataset and modify Iris Classification tests accordingly * Modify baseline test files for multiclass classification with Iris dataset and LightGBM

bojanmisic · 2018-06-27T09:42:41Z

Related to issue #400.

Reordered column values in iris.txt (headers stay the same), so the previously Petal width values are actually Sepal length values; other columns shifted to the right.
Tests TrainAndPredictIrisModelTest and TrainAndPredictIrisModelWithStringLabelTest are modified accordingly so that the values that test the prediction are also reordered to be more realistic (same way the dataset is modified).
Model class IrisDataWithStringLabel fields reordered to match iris.data dataset.

The fix for the samples repo that uses the same dataset will follow.

dnfclas · 2018-06-27T09:42:52Z

All CLA requirements met.

bojanmisic · 2018-06-27T10:05:19Z

Ok, just realized some additional tests need to be covered. #Resolved

sfilipi · 2018-06-27T15:30:49Z

Thanks for taking care of this, Bojan.

Take a look at the results of the tests as well, they might need update since the dataset is changing quite a bit.

In reply to: 400616611 [](ancestors = 400616611)

sfilipi · 2018-06-27T15:31:38Z

 Assert.Equal(49, matrix["2", "2"]);

see if anything here need be updated.

It might be the case for other tests using this dataset. #Resolved

Refers to: test/Microsoft.ML.Tests/Scenarios/IrisPlantClassificationTests.cs:113 in 57b9fc3. [](commit_id = 57b9fc3, deletion_comment = False)

…taset and LightGBM

bojanmisic · 2018-06-28T07:54:23Z

Thanks Senja!

Removing WIP and adding new change:

Tests MultiClassifierLightGMBKeyLabelTest and MultiClassifierLightGBMKeyLabelU404Test were failing since used Iris dataset was changed significantly, so baseline test files needed to be updated (latest commit). Pinging @codemzs since he was the author.

Ivanidzo4ka

sfilipi

…dotnet#428) * Fix iris.txt dataset and modify Iris Classification tests accordingly * Modify baseline test files for multiclass classification with Iris dataset and LightGBM

bojanmisic · 2018-06-27T09:42:41Z

Related to issue #400.

Reordered column values in iris.txt (headers stay the same), so the previously Petal width values are actually Sepal length values; other columns shifted to the right.
Tests TrainAndPredictIrisModelTest and TrainAndPredictIrisModelWithStringLabelTest are modified accordingly so that the values that test the prediction are also reordered to be more realistic (same way the dataset is modified).
Model class IrisDataWithStringLabel fields reordered to match iris.data dataset.

The fix for the samples repo that uses the same dataset will follow.

dnfclas · 2018-06-27T09:42:52Z

All CLA requirements met.

bojanmisic · 2018-06-27T10:05:19Z

Ok, just realized some additional tests need to be covered. #Resolved

sfilipi · 2018-06-27T15:30:49Z

Thanks for taking care of this, Bojan.

Take a look at the results of the tests as well, they might need update since the dataset is changing quite a bit.

In reply to: 400616611 [](ancestors = 400616611)

sfilipi · 2018-06-27T15:31:38Z

 Assert.Equal(49, matrix["2", "2"]);

see if anything here need be updated.

It might be the case for other tests using this dataset. #Resolved

Refers to: test/Microsoft.ML.Tests/Scenarios/IrisPlantClassificationTests.cs:113 in 57b9fc3. [](commit_id = 57b9fc3, deletion_comment = False)

…taset and LightGBM

bojanmisic · 2018-06-28T07:54:23Z

Thanks Senja!

Removing WIP and adding new change:

Tests MultiClassifierLightGMBKeyLabelTest and MultiClassifierLightGBMKeyLabelU404Test were failing since used Iris dataset was changed significantly, so baseline test files needed to be updated (latest commit). Pinging @codemzs since he was the author.

Ivanidzo4ka

sfilipi

…dotnet#428) * Fix iris.txt dataset and modify Iris Classification tests accordingly * Modify baseline test files for multiclass classification with Iris dataset and LightGBM

bojanmisic · 2018-06-27T09:42:41Z

Related to issue #400.

Reordered column values in iris.txt (headers stay the same), so the previously Petal width values are actually Sepal length values; other columns shifted to the right.
Tests TrainAndPredictIrisModelTest and TrainAndPredictIrisModelWithStringLabelTest are modified accordingly so that the values that test the prediction are also reordered to be more realistic (same way the dataset is modified).
Model class IrisDataWithStringLabel fields reordered to match iris.data dataset.

The fix for the samples repo that uses the same dataset will follow.

dnfclas · 2018-06-27T09:42:52Z

All CLA requirements met.

bojanmisic · 2018-06-27T10:05:19Z

Ok, just realized some additional tests need to be covered. #Resolved

sfilipi · 2018-06-27T15:30:49Z

Thanks for taking care of this, Bojan.

Take a look at the results of the tests as well, they might need update since the dataset is changing quite a bit.

In reply to: 400616611 [](ancestors = 400616611)

sfilipi · 2018-06-27T15:31:38Z

 Assert.Equal(49, matrix["2", "2"]);

see if anything here need be updated.

It might be the case for other tests using this dataset. #Resolved

Refers to: test/Microsoft.ML.Tests/Scenarios/IrisPlantClassificationTests.cs:113 in 57b9fc3. [](commit_id = 57b9fc3, deletion_comment = False)

…taset and LightGBM

bojanmisic · 2018-06-28T07:54:23Z

Thanks Senja!

Removing WIP and adding new change:

Tests MultiClassifierLightGMBKeyLabelTest and MultiClassifierLightGBMKeyLabelU404Test were failing since used Iris dataset was changed significantly, so baseline test files needed to be updated (latest commit). Pinging @codemzs since he was the author.

Ivanidzo4ka

sfilipi

…dotnet#428) * Fix iris.txt dataset and modify Iris Classification tests accordingly * Modify baseline test files for multiclass classification with Iris dataset and LightGBM

bojanmisic mentioned this pull request Jun 27, 2018
WIP: Fixed column name\order in iris dataset #408
Closed

bojanmisic changed the title ~~Fix iris.txt dataset and modify Iris Classification tests accordingly~~WIP: Fix iris.txt dataset and modify Iris Classification tests accordinglyJun 27, 2018

OliaG self-requested a review June 27, 2018 13:58

bojanmisic force-pushed the issue400 branch from ceca0ec to 57b9fc3Compare June 27, 2018 15:49

Bojan Misic added 2 commits June 28, 2018 09:13

Fix iris.txt dataset and modify Iris Classification tests accordingly
43c28a3

Modify baseline test files for multiclass classification with Iris da…
f9bfe8d
…taset and LightGBM

bojanmisic force-pushed the issue400 branch from 57b9fc3 to f9bfe8dCompare June 28, 2018 07:25

bojanmisic changed the title ~~WIP: Fix iris.txt dataset and modify Iris Classification tests accordingly~~Fix iris.txt dataset and modify Iris Classification tests accordinglyJun 28, 2018

Ivanidzo4ka approved these changes Jun 28, 2018
View reviewed changes

sfilipi approved these changes Jul 10, 2018
View reviewed changes

Ivanidzo4ka merged commit 54596ac into dotnet:masterJul 12, 2018

TomFinley mentioned this pull request Jul 13, 2018
Fix TrainAndPredictIrisModelUsingDirectInstantiationTest test from commit #428 #526
Closed

artidoro mentioned this pull request Aug 30, 2018
Iris data set (iris.txt) is not correct #400
Closed

ghost locked as resolved and limited conversation to collaborators Mar 30, 2022