Uh oh!
There was an error while loading. Please reload this page.
Fix NullReferenceException when it comes to Recommendation in AutoML and CodeGenerator - #4774
Merged
LittleLittleCloud merged 1 commit intoFeb 4, 2020
Conversation
LittleLittleCloud
commented
Feb 3, 2020
MemberAuthor
JakeRadMSFT
approved these changes
Feb 4, 2020
| {nameof(MatrixFactorizationTrainer.Options.Lambda), 0.01f }, | ||
| {nameof(MatrixFactorizationTrainer.Options.LossFunction), MatrixFactorizationTrainer.LossFunctionType.SquareLossRegression }, | ||
| {nameof(MatrixFactorizationTrainer.Options.Alpha), 1f }, | ||
| {nameof(MatrixFactorizationTrainer.Options.C), 0.00001f }, |
Contributor
There was a problem hiding this comment.
Thanks for adding the MF options to a test.
| ITrainerGenerator generator = TrainerGeneratorFactory.GetInstance(node); | ||
| var trainerString = generator.GenerateTrainer(); | ||
| var trainerUsings = generator.GenerateUsings(); | ||
| return (trainerString, trainerUsings); |
Contributor
There was a problem hiding this comment.
I'm not sure why the try/catch was needed. If no one else knows, we may want drill down in the code, or run a variety of datasets thru the CLI to show that nothing is expected to throw.
The old catch seem to eat the error without a hint of what went wrong.
MemberAuthor
There was a problem hiding this comment.
Yeah, that's why I removed that part of code
justinormont
approved these changes
Feb 4, 2020
justinormont
left a comment
Contributor
There was a problem hiding this comment.
LGTM. May want to check on why we had a try/catch before, seemed oddly written previously. Thanks for expanding the unit test to cover MF's options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add code for handle enum case in CodeGen