Uh oh!
There was an error while loading. Please reload this page.
Move Windows and Linux CI to VSTS#566
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| resources: | ||
| containers: | ||
| - container: centos7 | ||
| image: microsoft/dotnet-buildtools-prereqs:centos-7-b46d863-20180719033416 | ||
Contributor There was a problem hiding this comment.
does this docker image contains libgdiplus? MemberAuthor There was a problem hiding this comment. Contributor There was a problem hiding this comment. https://ci2.dot.net/job/Private/job/dotnet_machinelearning/job/master/job/linux_release_prtest/1240/testReport/junit/(root)/(empty)/Microsoft_ML_Tests_ImageTests_TestBackAndForthConversion/ In reply to: 204483166 [](ancestors = 204483166) MemberAuthor There was a problem hiding this comment. I’m trying to build and run the tests locally in my computer with the same container. I’ll update you. Using your branch of course MemberAuthor There was a problem hiding this comment. The tests that you added passed in my machine when using that docker image. I just need to dig why they are failing in VSTS, maybe not picking the right docker image. I'll update you. | ||
| phases: | ||
| - template: /build/ci/phase-template.yml | ||
| parameters: | ||
| name: Linux | ||
| buildScript: ./build.sh | ||
| queue: | ||
| container: centos7 | ||
| - template: /build/ci/phase-template.yml | ||
| parameters: | ||
| name: Windows_NT | ||
Contributor There was a problem hiding this comment.
I obviously don't have knowleage regarding build system, but from what I see we have 4 nodes in VSTS where Windows_NT is not running, and also Windows builds on jenkins. MemberAuthor There was a problem hiding this comment. So the jenkins Windows builds will stop showing up after I merge this PR. They keep showing because it takes the checked-in netci.groovy file instead of taking the one in this PR. About the VSTS nodes, you can see here: https://dotnet.visualstudio.com/public/_build/results?buildId=7047&view=logs that the new Build Def, will run Linux and Windows in both Release and Debug mode simultaneously. Contributor There was a problem hiding this comment. Got it, thank you for clarification. | ||
| buildScript: build.cmd | ||
| queue: | ||
| name: Hosted VS2017 | ||
| demands: | ||
| - agent.os -equals Windows_NT | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| parameters: | ||
| name: '' | ||
| buildScript: '' | ||
| queue: {} | ||
| phases: | ||
| - phase: ${{ parameters.name }} | ||
| variables: | ||
| _buildScript: ${{ parameters.buildScript }} | ||
| _phaseName: ${{ parameters.name }} | ||
| queue: | ||
| parallel: 2 | ||
| matrix: | ||
| Build_Debug: | ||
| _configuration: Debug | ||
| Build_Release: | ||
| _configuration: Release | ||
| ${{ insert }}: ${{ parameters.queue }} | ||
| steps: | ||
| - script: $(_buildScript) -$(_configuration) -runtests | ||
| displayName: Build and Test | ||
| - task: PublishTestResults@2 | ||
| displayName: Publish Test Results | ||
| condition: succeededOrFailed() | ||
| inputs: | ||
| testRunner: 'vSTest' | ||
Contributor There was a problem hiding this comment.
don't we use xUnit tests, or they interchangeable? MemberAuthor There was a problem hiding this comment. We use xunit as a framework, but we use VSTest as our test runner: | ||
| searchFolder: '$(System.DefaultWorkingDirectory)/bin' | ||
| testResultsFiles: '**/*.trx' | ||
| testRunTitle: Machinelearning_Tests_$(_phaseName)_$(_configuration)_$(Build.BuildNumber) | ||
| configuration: $(_configuration) | ||
| mergeTestResults: true | ||
| - script: $(_buildScript) -buildPackages | ||
| displayName: Build Packages | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this file from the root of the repo and instead put it in the
buildfolder?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it in the root because if it is in the root we get Resource Authorization automatically:
https://github.com/Microsoft/vsts-agent/blob/master/docs/preview/yamlgettingstarted-authz.md
They do have plans on supporting directory structure for this though:
microsoft/azure-pipelines-agent#1430
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is unfortunate.