Add needed param to warning for L2 in SDCA by justinormont · Pull Request #597 · dotnet/machinelearning

justinormont · 2018-07-29T09:33:32Z

Closes#596

Pull from upstream

Update to origin

TomFinley · 2018-07-29T21:12:06Z

 ch.Warning("The specified l2Const = {0} is too small. SDCA optimizes the dual objective function. " +
 "The dual formulation is only valid with a positive L2 regularization. Also, an l2Const less than {1} " +
- "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const);
+ "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const, L2LowerBound);


l2Const [](start = 83, length = 7)
Hi @justinormont thanks for looking at this. Another problem with this message, replace these with nameof(L2Const), here, and everywhere in this message that it is used, in the format args. It might go easier if you used the $ string interpolation. #resolved

justinormont · 2018-07-30T07:52:19Z

@dotnet-bot test OSX10.13 Debug

justinormont · 2018-07-30T09:07:51Z

@TomFinley : Perhaps there's a StyleCop (ref: #553) rule we can enable, which can catch future issues like this mismatched (param count) vs. (count of items in the String.Format-style).

TomFinley · 2018-07-30T18:10:21Z

Such a code analysis rule would have to be aware of ch.Warning, ch.Except, and all such other places -- certainly StyleCop is unaware of this. One possible remediation would be to drop all usage of such things, and insist that if people want formatted args, we simply do $ style string interpolation, which just simply works.

In reply to: 408797756 [](ancestors = 408797756)

TomFinley · 2018-07-30T18:12:37Z

 env.CheckUserArg(L2Const == null || L2Const >= 0, nameof(L2Const), "L2 constant must be non-negative.");

If you wanted to improve these messages while you're at it so they don't contain this redundant information that would be nice. E.g., "``L2 constant must be non-negative"should just be "Must be non-negative."`, similar for other messages here that needlessly re-identify what paramater they're talking about, despite the fact that the name of the parameter is already part of the error message.

Refers to: src/Microsoft.ML.StandardLearners/Standard/LinearClassificationTrainer.cs:201 in dc42fee. [](commit_id = dc42fee, deletion_comment = False)

TomFinley

Thanks @justinormont . If you wanted to improve those other badly structured messages preceding your changes that would also help improve our overall quality.

abgoswam

justinormont · 2018-07-30T19:37:53Z

@TomFinley : I did a pass of word-smithing.

The warning now reads as:
Warning: The L2 regularization constant must be at least 1E-09. In SDCA, the dual formulation is only valid with a positive constant, and values below 1E-09 cause very slow convergence. The original L2Const = 0, was replaced with L2Const = 1E-09.

* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

justinormont · 2018-07-29T09:33:32Z

Closes#596

Pull from upstream

Update to origin

TomFinley · 2018-07-29T21:12:06Z

 ch.Warning("The specified l2Const = {0} is too small. SDCA optimizes the dual objective function. " +
 "The dual formulation is only valid with a positive L2 regularization. Also, an l2Const less than {1} " +
- "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const);
+ "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const, L2LowerBound);


l2Const [](start = 83, length = 7)
Hi @justinormont thanks for looking at this. Another problem with this message, replace these with nameof(L2Const), here, and everywhere in this message that it is used, in the format args. It might go easier if you used the $ string interpolation. #resolved

justinormont · 2018-07-30T07:52:19Z

@dotnet-bot test OSX10.13 Debug

justinormont · 2018-07-30T09:07:51Z

@TomFinley : Perhaps there's a StyleCop (ref: #553) rule we can enable, which can catch future issues like this mismatched (param count) vs. (count of items in the String.Format-style).

TomFinley · 2018-07-30T18:10:21Z

Such a code analysis rule would have to be aware of ch.Warning, ch.Except, and all such other places -- certainly StyleCop is unaware of this. One possible remediation would be to drop all usage of such things, and insist that if people want formatted args, we simply do $ style string interpolation, which just simply works.

In reply to: 408797756 [](ancestors = 408797756)

TomFinley · 2018-07-30T18:12:37Z

 env.CheckUserArg(L2Const == null || L2Const >= 0, nameof(L2Const), "L2 constant must be non-negative.");

If you wanted to improve these messages while you're at it so they don't contain this redundant information that would be nice. E.g., "``L2 constant must be non-negative"should just be "Must be non-negative."`, similar for other messages here that needlessly re-identify what paramater they're talking about, despite the fact that the name of the parameter is already part of the error message.

Refers to: src/Microsoft.ML.StandardLearners/Standard/LinearClassificationTrainer.cs:201 in dc42fee. [](commit_id = dc42fee, deletion_comment = False)

TomFinley

Thanks @justinormont . If you wanted to improve those other badly structured messages preceding your changes that would also help improve our overall quality.

abgoswam

justinormont · 2018-07-30T19:37:53Z

@TomFinley : I did a pass of word-smithing.

The warning now reads as:
Warning: The L2 regularization constant must be at least 1E-09. In SDCA, the dual formulation is only valid with a positive constant, and values below 1E-09 cause very slow convergence. The original L2Const = 0, was replaced with L2Const = 1E-09.

* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

justinormont · 2018-07-29T09:33:32Z

Closes#596

Pull from upstream

Update to origin

TomFinley · 2018-07-29T21:12:06Z

 ch.Warning("The specified l2Const = {0} is too small. SDCA optimizes the dual objective function. " +
 "The dual formulation is only valid with a positive L2 regularization. Also, an l2Const less than {1} " +
- "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const);
+ "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const, L2LowerBound);


l2Const [](start = 83, length = 7)
Hi @justinormont thanks for looking at this. Another problem with this message, replace these with nameof(L2Const), here, and everywhere in this message that it is used, in the format args. It might go easier if you used the $ string interpolation. #resolved

justinormont · 2018-07-30T07:52:19Z

@dotnet-bot test OSX10.13 Debug

justinormont · 2018-07-30T09:07:51Z

@TomFinley : Perhaps there's a StyleCop (ref: #553) rule we can enable, which can catch future issues like this mismatched (param count) vs. (count of items in the String.Format-style).

TomFinley · 2018-07-30T18:10:21Z

Such a code analysis rule would have to be aware of ch.Warning, ch.Except, and all such other places -- certainly StyleCop is unaware of this. One possible remediation would be to drop all usage of such things, and insist that if people want formatted args, we simply do $ style string interpolation, which just simply works.

In reply to: 408797756 [](ancestors = 408797756)

TomFinley · 2018-07-30T18:12:37Z

 env.CheckUserArg(L2Const == null || L2Const >= 0, nameof(L2Const), "L2 constant must be non-negative.");

If you wanted to improve these messages while you're at it so they don't contain this redundant information that would be nice. E.g., "``L2 constant must be non-negative"should just be "Must be non-negative."`, similar for other messages here that needlessly re-identify what paramater they're talking about, despite the fact that the name of the parameter is already part of the error message.

Refers to: src/Microsoft.ML.StandardLearners/Standard/LinearClassificationTrainer.cs:201 in dc42fee. [](commit_id = dc42fee, deletion_comment = False)

TomFinley

Thanks @justinormont . If you wanted to improve those other badly structured messages preceding your changes that would also help improve our overall quality.

abgoswam

justinormont · 2018-07-30T19:37:53Z

@TomFinley : I did a pass of word-smithing.

The warning now reads as:
Warning: The L2 regularization constant must be at least 1E-09. In SDCA, the dual formulation is only valid with a positive constant, and values below 1E-09 cause very slow convergence. The original L2Const = 0, was replaced with L2Const = 1E-09.

* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

justinormont · 2018-07-29T09:33:32Z

Closes#596

Pull from upstream

Update to origin

TomFinley · 2018-07-29T21:12:06Z

 ch.Warning("The specified l2Const = {0} is too small. SDCA optimizes the dual objective function. " +
 "The dual formulation is only valid with a positive L2 regularization. Also, an l2Const less than {1} " +
- "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const);
+ "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const, L2LowerBound);


l2Const [](start = 83, length = 7)
Hi @justinormont thanks for looking at this. Another problem with this message, replace these with nameof(L2Const), here, and everywhere in this message that it is used, in the format args. It might go easier if you used the $ string interpolation. #resolved

justinormont · 2018-07-30T07:52:19Z

@dotnet-bot test OSX10.13 Debug

justinormont · 2018-07-30T09:07:51Z

@TomFinley : Perhaps there's a StyleCop (ref: #553) rule we can enable, which can catch future issues like this mismatched (param count) vs. (count of items in the String.Format-style).

TomFinley · 2018-07-30T18:10:21Z

Such a code analysis rule would have to be aware of ch.Warning, ch.Except, and all such other places -- certainly StyleCop is unaware of this. One possible remediation would be to drop all usage of such things, and insist that if people want formatted args, we simply do $ style string interpolation, which just simply works.

In reply to: 408797756 [](ancestors = 408797756)

TomFinley · 2018-07-30T18:12:37Z

 env.CheckUserArg(L2Const == null || L2Const >= 0, nameof(L2Const), "L2 constant must be non-negative.");

If you wanted to improve these messages while you're at it so they don't contain this redundant information that would be nice. E.g., "``L2 constant must be non-negative"should just be "Must be non-negative."`, similar for other messages here that needlessly re-identify what paramater they're talking about, despite the fact that the name of the parameter is already part of the error message.

Refers to: src/Microsoft.ML.StandardLearners/Standard/LinearClassificationTrainer.cs:201 in dc42fee. [](commit_id = dc42fee, deletion_comment = False)

TomFinley

Thanks @justinormont . If you wanted to improve those other badly structured messages preceding your changes that would also help improve our overall quality.

abgoswam

justinormont · 2018-07-30T19:37:53Z

@TomFinley : I did a pass of word-smithing.

The warning now reads as:
Warning: The L2 regularization constant must be at least 1E-09. In SDCA, the dual formulation is only valid with a positive constant, and values below 1E-09 cause very slow convergence. The original L2Const = 0, was replaced with L2Const = 1E-09.

* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

justinormont · 2018-07-29T09:33:32Z

Closes#596

Pull from upstream

Update to origin

TomFinley · 2018-07-29T21:12:06Z

 ch.Warning("The specified l2Const = {0} is too small. SDCA optimizes the dual objective function. " +
 "The dual formulation is only valid with a positive L2 regularization. Also, an l2Const less than {1} " +
- "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const);
+ "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const, L2LowerBound);


l2Const [](start = 83, length = 7)
Hi @justinormont thanks for looking at this. Another problem with this message, replace these with nameof(L2Const), here, and everywhere in this message that it is used, in the format args. It might go easier if you used the $ string interpolation. #resolved

justinormont · 2018-07-30T07:52:19Z

@dotnet-bot test OSX10.13 Debug

justinormont · 2018-07-30T09:07:51Z

@TomFinley : Perhaps there's a StyleCop (ref: #553) rule we can enable, which can catch future issues like this mismatched (param count) vs. (count of items in the String.Format-style).

TomFinley · 2018-07-30T18:10:21Z

Such a code analysis rule would have to be aware of ch.Warning, ch.Except, and all such other places -- certainly StyleCop is unaware of this. One possible remediation would be to drop all usage of such things, and insist that if people want formatted args, we simply do $ style string interpolation, which just simply works.

In reply to: 408797756 [](ancestors = 408797756)

TomFinley · 2018-07-30T18:12:37Z

 env.CheckUserArg(L2Const == null || L2Const >= 0, nameof(L2Const), "L2 constant must be non-negative.");

If you wanted to improve these messages while you're at it so they don't contain this redundant information that would be nice. E.g., "``L2 constant must be non-negative"should just be "Must be non-negative."`, similar for other messages here that needlessly re-identify what paramater they're talking about, despite the fact that the name of the parameter is already part of the error message.

Refers to: src/Microsoft.ML.StandardLearners/Standard/LinearClassificationTrainer.cs:201 in dc42fee. [](commit_id = dc42fee, deletion_comment = False)

TomFinley

Thanks @justinormont . If you wanted to improve those other badly structured messages preceding your changes that would also help improve our overall quality.

abgoswam

justinormont · 2018-07-30T19:37:53Z

@TomFinley : I did a pass of word-smithing.

The warning now reads as:
Warning: The L2 regularization constant must be at least 1E-09. In SDCA, the dual formulation is only valid with a positive constant, and values below 1E-09 cause very slow convergence. The original L2Const = 0, was replaced with L2Const = 1E-09.

* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

justinormont · 2018-07-29T09:33:32Z

Closes#596

Pull from upstream

Update to origin

TomFinley · 2018-07-29T21:12:06Z

 ch.Warning("The specified l2Const = {0} is too small. SDCA optimizes the dual objective function. " +
 "The dual formulation is only valid with a positive L2 regularization. Also, an l2Const less than {1} " +
- "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const);
+ "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const, L2LowerBound);


l2Const [](start = 83, length = 7)
Hi @justinormont thanks for looking at this. Another problem with this message, replace these with nameof(L2Const), here, and everywhere in this message that it is used, in the format args. It might go easier if you used the $ string interpolation. #resolved

justinormont · 2018-07-30T07:52:19Z

@dotnet-bot test OSX10.13 Debug

justinormont · 2018-07-30T09:07:51Z

@TomFinley : Perhaps there's a StyleCop (ref: #553) rule we can enable, which can catch future issues like this mismatched (param count) vs. (count of items in the String.Format-style).

TomFinley · 2018-07-30T18:10:21Z

Such a code analysis rule would have to be aware of ch.Warning, ch.Except, and all such other places -- certainly StyleCop is unaware of this. One possible remediation would be to drop all usage of such things, and insist that if people want formatted args, we simply do $ style string interpolation, which just simply works.

In reply to: 408797756 [](ancestors = 408797756)

TomFinley · 2018-07-30T18:12:37Z

 env.CheckUserArg(L2Const == null || L2Const >= 0, nameof(L2Const), "L2 constant must be non-negative.");

If you wanted to improve these messages while you're at it so they don't contain this redundant information that would be nice. E.g., "``L2 constant must be non-negative"should just be "Must be non-negative."`, similar for other messages here that needlessly re-identify what paramater they're talking about, despite the fact that the name of the parameter is already part of the error message.

Refers to: src/Microsoft.ML.StandardLearners/Standard/LinearClassificationTrainer.cs:201 in dc42fee. [](commit_id = dc42fee, deletion_comment = False)

TomFinley

Thanks @justinormont . If you wanted to improve those other badly structured messages preceding your changes that would also help improve our overall quality.

abgoswam

justinormont · 2018-07-30T19:37:53Z

@TomFinley : I did a pass of word-smithing.

The warning now reads as:
Warning: The L2 regularization constant must be at least 1E-09. In SDCA, the dual formulation is only valid with a positive constant, and values below 1E-09 cause very slow convergence. The original L2Const = 0, was replaced with L2Const = 1E-09.

* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

justinormont · 2018-07-29T09:33:32Z

Closes#596

Pull from upstream

Update to origin

TomFinley · 2018-07-29T21:12:06Z

 ch.Warning("The specified l2Const = {0} is too small. SDCA optimizes the dual objective function. " +
 "The dual formulation is only valid with a positive L2 regularization. Also, an l2Const less than {1} " +
- "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const);
+ "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const, L2LowerBound);


l2Const [](start = 83, length = 7)
Hi @justinormont thanks for looking at this. Another problem with this message, replace these with nameof(L2Const), here, and everywhere in this message that it is used, in the format args. It might go easier if you used the $ string interpolation. #resolved

justinormont · 2018-07-30T07:52:19Z

@dotnet-bot test OSX10.13 Debug

justinormont · 2018-07-30T09:07:51Z

@TomFinley : Perhaps there's a StyleCop (ref: #553) rule we can enable, which can catch future issues like this mismatched (param count) vs. (count of items in the String.Format-style).

TomFinley · 2018-07-30T18:10:21Z

Such a code analysis rule would have to be aware of ch.Warning, ch.Except, and all such other places -- certainly StyleCop is unaware of this. One possible remediation would be to drop all usage of such things, and insist that if people want formatted args, we simply do $ style string interpolation, which just simply works.

In reply to: 408797756 [](ancestors = 408797756)

TomFinley · 2018-07-30T18:12:37Z

 env.CheckUserArg(L2Const == null || L2Const >= 0, nameof(L2Const), "L2 constant must be non-negative.");

If you wanted to improve these messages while you're at it so they don't contain this redundant information that would be nice. E.g., "``L2 constant must be non-negative"should just be "Must be non-negative."`, similar for other messages here that needlessly re-identify what paramater they're talking about, despite the fact that the name of the parameter is already part of the error message.

Refers to: src/Microsoft.ML.StandardLearners/Standard/LinearClassificationTrainer.cs:201 in dc42fee. [](commit_id = dc42fee, deletion_comment = False)

TomFinley

Thanks @justinormont . If you wanted to improve those other badly structured messages preceding your changes that would also help improve our overall quality.

abgoswam

justinormont · 2018-07-30T19:37:53Z

@TomFinley : I did a pass of word-smithing.

The warning now reads as:
Warning: The L2 regularization constant must be at least 1E-09. In SDCA, the dual formulation is only valid with a positive constant, and values below 1E-09 cause very slow convergence. The original L2Const = 0, was replaced with L2Const = 1E-09.

* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

justinormont · 2018-07-29T09:33:32Z

Closes#596

Pull from upstream

Update to origin

TomFinley · 2018-07-29T21:12:06Z

 ch.Warning("The specified l2Const = {0} is too small. SDCA optimizes the dual objective function. " +
 "The dual formulation is only valid with a positive L2 regularization. Also, an l2Const less than {1} " +
- "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const);
+ "could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const, L2LowerBound);


l2Const [](start = 83, length = 7)
Hi @justinormont thanks for looking at this. Another problem with this message, replace these with nameof(L2Const), here, and everywhere in this message that it is used, in the format args. It might go easier if you used the $ string interpolation. #resolved

justinormont · 2018-07-30T07:52:19Z

@dotnet-bot test OSX10.13 Debug

justinormont · 2018-07-30T09:07:51Z

@TomFinley : Perhaps there's a StyleCop (ref: #553) rule we can enable, which can catch future issues like this mismatched (param count) vs. (count of items in the String.Format-style).

TomFinley · 2018-07-30T18:10:21Z

Such a code analysis rule would have to be aware of ch.Warning, ch.Except, and all such other places -- certainly StyleCop is unaware of this. One possible remediation would be to drop all usage of such things, and insist that if people want formatted args, we simply do $ style string interpolation, which just simply works.

In reply to: 408797756 [](ancestors = 408797756)

TomFinley · 2018-07-30T18:12:37Z

 env.CheckUserArg(L2Const == null || L2Const >= 0, nameof(L2Const), "L2 constant must be non-negative.");

If you wanted to improve these messages while you're at it so they don't contain this redundant information that would be nice. E.g., "``L2 constant must be non-negative"should just be "Must be non-negative."`, similar for other messages here that needlessly re-identify what paramater they're talking about, despite the fact that the name of the parameter is already part of the error message.

Refers to: src/Microsoft.ML.StandardLearners/Standard/LinearClassificationTrainer.cs:201 in dc42fee. [](commit_id = dc42fee, deletion_comment = False)

TomFinley

Thanks @justinormont . If you wanted to improve those other badly structured messages preceding your changes that would also help improve our overall quality.

abgoswam

justinormont · 2018-07-30T19:37:53Z

@TomFinley : I did a pass of word-smithing.

The warning now reads as:
Warning: The L2 regularization constant must be at least 1E-09. In SDCA, the dual formulation is only valid with a positive constant, and values below 1E-09 cause very slow convergence. The original L2Const = 0, was replaced with L2Const = 1E-09.

* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

justinormont added 4 commits June 4, 2018 13:18

Merge pull request#1from dotnet/master
f03189d
Pull from upstream

Merge pull request#2from dotnet/master
1421743
Update to origin

Merge pull request#3from dotnet/master
24d939a
Update to origin

Fix warning for L2 in SDCA
3258e37

TomFinley reviewed Jul 29, 2018
View reviewed changes

String interpolation
dc42fee

justinormont requested a review from abgoswam July 30, 2018 18:08

TomFinley approved these changes Jul 30, 2018
View reviewed changes

abgoswam approved these changes Jul 30, 2018
View reviewed changes

Word-smithing the warning message
4da3c50

justinormont merged commit 98318b6 into dotnet:masterJul 30, 2018

justinormont deleted the sdca-l2-fix branch July 31, 2018 17:11

codemzs pushed a commit to codemzs/machinelearning that referenced this pull request Aug 1, 2018
Add needed param to warning for L2 in SDCA (dotnet#597)
966b0f3
* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

justinormont added 4 commits June 4, 2018 13:18

Merge pull request#1from dotnet/master
f03189d
Pull from upstream

Merge pull request#2from dotnet/master
1421743
Update to origin

Merge pull request#3from dotnet/master
24d939a
Update to origin

Fix warning for L2 in SDCA
3258e37

TomFinley reviewed Jul 29, 2018
View reviewed changes

String interpolation
dc42fee

justinormont requested a review from abgoswam July 30, 2018 18:08

TomFinley approved these changes Jul 30, 2018
View reviewed changes

abgoswam approved these changes Jul 30, 2018
View reviewed changes

Word-smithing the warning message
4da3c50

justinormont merged commit 98318b6 into dotnet:masterJul 30, 2018

justinormont deleted the sdca-l2-fix branch July 31, 2018 17:11

codemzs pushed a commit to codemzs/machinelearning that referenced this pull request Aug 1, 2018
Add needed param to warning for L2 in SDCA (dotnet#597)
966b0f3
* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

justinormont added 4 commits June 4, 2018 13:18

Merge pull request#1from dotnet/master
f03189d
Pull from upstream

Merge pull request#2from dotnet/master
1421743
Update to origin

Merge pull request#3from dotnet/master
24d939a
Update to origin

Fix warning for L2 in SDCA
3258e37

TomFinley reviewed Jul 29, 2018
View reviewed changes

String interpolation
dc42fee

justinormont requested a review from abgoswam July 30, 2018 18:08

TomFinley approved these changes Jul 30, 2018
View reviewed changes

abgoswam approved these changes Jul 30, 2018
View reviewed changes

Word-smithing the warning message
4da3c50

justinormont merged commit 98318b6 into dotnet:masterJul 30, 2018

justinormont deleted the sdca-l2-fix branch July 31, 2018 17:11

codemzs pushed a commit to codemzs/machinelearning that referenced this pull request Aug 1, 2018
Add needed param to warning for L2 in SDCA (dotnet#597)
966b0f3
* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

justinormont added 4 commits June 4, 2018 13:18

Merge pull request#1from dotnet/master
f03189d
Pull from upstream

Merge pull request#2from dotnet/master
1421743
Update to origin

Merge pull request#3from dotnet/master
24d939a
Update to origin

Fix warning for L2 in SDCA
3258e37

TomFinley reviewed Jul 29, 2018
View reviewed changes

String interpolation
dc42fee

justinormont requested a review from abgoswam July 30, 2018 18:08

TomFinley approved these changes Jul 30, 2018
View reviewed changes

abgoswam approved these changes Jul 30, 2018
View reviewed changes

Word-smithing the warning message
4da3c50

justinormont merged commit 98318b6 into dotnet:masterJul 30, 2018

justinormont deleted the sdca-l2-fix branch July 31, 2018 17:11

codemzs pushed a commit to codemzs/machinelearning that referenced this pull request Aug 1, 2018
Add needed param to warning for L2 in SDCA (dotnet#597)
966b0f3
* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

justinormont added 4 commits June 4, 2018 13:18

Merge pull request#1from dotnet/master
f03189d
Pull from upstream

Merge pull request#2from dotnet/master
1421743
Update to origin

Merge pull request#3from dotnet/master
24d939a
Update to origin

Fix warning for L2 in SDCA
3258e37

TomFinley reviewed Jul 29, 2018
View reviewed changes

String interpolation
dc42fee

justinormont requested a review from abgoswam July 30, 2018 18:08

TomFinley approved these changes Jul 30, 2018
View reviewed changes

abgoswam approved these changes Jul 30, 2018
View reviewed changes

Word-smithing the warning message
4da3c50

justinormont merged commit 98318b6 into dotnet:masterJul 30, 2018

justinormont deleted the sdca-l2-fix branch July 31, 2018 17:11

codemzs pushed a commit to codemzs/machinelearning that referenced this pull request Aug 1, 2018
Add needed param to warning for L2 in SDCA (dotnet#597)
966b0f3
* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

justinormont added 4 commits June 4, 2018 13:18

Merge pull request#1from dotnet/master
f03189d
Pull from upstream

Merge pull request#2from dotnet/master
1421743
Update to origin

Merge pull request#3from dotnet/master
24d939a
Update to origin

Fix warning for L2 in SDCA
3258e37

TomFinley reviewed Jul 29, 2018
View reviewed changes

String interpolation
dc42fee

justinormont requested a review from abgoswam July 30, 2018 18:08

TomFinley approved these changes Jul 30, 2018
View reviewed changes

abgoswam approved these changes Jul 30, 2018
View reviewed changes

Word-smithing the warning message
4da3c50

justinormont merged commit 98318b6 into dotnet:masterJul 30, 2018

justinormont deleted the sdca-l2-fix branch July 31, 2018 17:11

codemzs pushed a commit to codemzs/machinelearning that referenced this pull request Aug 1, 2018
Add needed param to warning for L2 in SDCA (dotnet#597)
966b0f3
* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

justinormont added 4 commits June 4, 2018 13:18

Merge pull request#1from dotnet/master
f03189d
Pull from upstream

Merge pull request#2from dotnet/master
1421743
Update to origin

Merge pull request#3from dotnet/master
24d939a
Update to origin

Fix warning for L2 in SDCA
3258e37

TomFinley reviewed Jul 29, 2018
View reviewed changes

String interpolation
dc42fee

justinormont requested a review from abgoswam July 30, 2018 18:08

TomFinley approved these changes Jul 30, 2018
View reviewed changes

abgoswam approved these changes Jul 30, 2018
View reviewed changes

Word-smithing the warning message
4da3c50

justinormont merged commit 98318b6 into dotnet:masterJul 30, 2018

justinormont deleted the sdca-l2-fix branch July 31, 2018 17:11

codemzs pushed a commit to codemzs/machinelearning that referenced this pull request Aug 1, 2018
Add needed param to warning for L2 in SDCA (dotnet#597)
966b0f3
* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

justinormont added 4 commits June 4, 2018 13:18

Merge pull request#1from dotnet/master
f03189d
Pull from upstream

Merge pull request#2from dotnet/master
1421743
Update to origin

Merge pull request#3from dotnet/master
24d939a
Update to origin

Fix warning for L2 in SDCA
3258e37

TomFinley reviewed Jul 29, 2018
View reviewed changes

String interpolation
dc42fee

justinormont requested a review from abgoswam July 30, 2018 18:08

TomFinley approved these changes Jul 30, 2018
View reviewed changes

abgoswam approved these changes Jul 30, 2018
View reviewed changes

Word-smithing the warning message
4da3c50

justinormont merged commit 98318b6 into dotnet:masterJul 30, 2018

justinormont deleted the sdca-l2-fix branch July 31, 2018 17:11

codemzs pushed a commit to codemzs/machinelearning that referenced this pull request Aug 1, 2018
Add needed param to warning for L2 in SDCA (dotnet#597)
966b0f3
* Fix warning for L2 in SDCA * String interpolation * Word-smithing the warning message

ghost locked as resolved and limited conversation to collaborators Mar 29, 2022

Uh oh!

Conversation

justinormont commented Jul 29, 2018

Uh oh!

TomFinleyJul 29, 2018• edited by justinormont Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinormont commented Jul 30, 2018

Uh oh!

justinormont commented Jul 30, 2018

Uh oh!

TomFinley commented Jul 30, 2018

Uh oh!

TomFinley commented Jul 30, 2018

Uh oh!

TomFinley left a comment

Choose a reason for hiding this comment

Uh oh!

abgoswam left a comment

Choose a reason for hiding this comment

Uh oh!

justinormont commented Jul 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

justinormont commented Jul 29, 2018

Uh oh!

TomFinleyJul 29, 2018• edited by justinormont Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinormont commented Jul 30, 2018

Uh oh!

justinormont commented Jul 30, 2018

Uh oh!

TomFinley commented Jul 30, 2018

Uh oh!

TomFinley commented Jul 30, 2018

Uh oh!

TomFinley left a comment

Choose a reason for hiding this comment

Uh oh!

abgoswam left a comment

Choose a reason for hiding this comment

Uh oh!

justinormont commented Jul 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

justinormont commented Jul 29, 2018

Uh oh!

TomFinleyJul 29, 2018• edited by justinormont Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinormont commented Jul 30, 2018

Uh oh!

justinormont commented Jul 30, 2018

Uh oh!

TomFinley commented Jul 30, 2018

Uh oh!

TomFinley commented Jul 30, 2018

Uh oh!

TomFinleyJul 29, 2018•
edited by justinormont
Loading

TomFinleyJul 29, 2018•
edited by justinormont
Loading

TomFinleyJul 29, 2018•
edited by justinormont
Loading

TomFinleyJul 29, 2018•
edited by justinormont
Loading