Uh oh!
There was an error while loading. Please reload this page.
implement auto featurizer - #6205
Merged
michaelgsharp merged 7 commits intoJun 17, 2022
Merged
Conversation
28 tasks
Codecov Report
@@ Coverage Diff @@## main #6205 +/- ##
==========================================
+ Coverage 68.32% 68.43% +0.11%
==========================================
Files 1101 1141 +40 Lines 242236 244678 +2442 Branches 25172 25396 +224 ==========================================
+ Hits 165505 167451 +1946 - Misses 70163 70589 +426 - Partials 6568 6638 +70
Flags with carried forward coverage won't be shown. Click here to find out more.
|
LittleLittleCloud
commented
Jun 9, 2022
MemberAuthor
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
8 tasks
| internal SweepableEstimator[] NumericFeaturizer(string[] outputColumnNames, string[] inputColumnNames) | ||
| { | ||
| throw new NotImplementedException(); | ||
| Contracts.Check(outputColumnNames.Count() == inputColumnNames.Count() && outputColumnNames.Count() > 0, "outputColumnNames and inputColumnNames must have the same length and greater than 0"); |
Contributor
There was a problem hiding this comment.
I think this will blow up if either of those inputs are null. Make sure they aren't null first.
| if (overallColumns != null) | ||
| { | ||
| Contracts.Assert(overallColumns.Count() == overallColumns.Distinct().Count(), "detect overlapping among catalogColumns, numericColumns, textColumns and excludedColumns"); |
Contributor
There was a problem hiding this comment.
Nit: changed detect overlapping to detected overlapping.
I'm also personally a fan of the oxford comma.
| } | ||
| return pipeline; | ||
Contributor
There was a problem hiding this comment.
Nit: remove extra blank line.
| /// <param name="columnInformation">column information.</param> | ||
| /// <param name="outputColumnName">output feature column.</param> | ||
| /// <param name="excludeColumns">columns that won't be included when featurizing, like label</param> | ||
| /// <returns></returns> |
Contributor
There was a problem hiding this comment.
Can you add a comment for what it returns.
michaelgsharp
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnnin your description to cause GitHub to automatically close the issue(s) when your PR is merged.