Uh oh!
There was an error while loading. Please reload this page.
Improve RegressionExpeirment using AutoMLExperiment - #6338
Merged
LittleLittleCloud merged 4 commits intoSep 29, 2022
Conversation
28 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #6338 +/- ##
==========================================
+ Coverage 68.56% 68.64% +0.08%
==========================================
Files 1171 1171 Lines 247736 247964 +228 Branches 25733 25738 +5 ==========================================
+ Hits 169858 170214 +356 + Misses 71115 71008 -107 + Partials 6763 6742 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| [InlineData("en-US")] | ||
| [InlineData("ar-SA")] | ||
| [InlineData("pl-PL")] | ||
| public void AutoFitRegressionTest(string culture) |
MemberAuthor
There was a problem hiding this comment.
We no longer using SMac Sweeper in regression, so we can just remove this test.
tarekgh
reviewed
Sep 29, 2022
| if (rowCount < crossValRowCountThreshold) | ||
| { | ||
| const int numCrossValFolds = 10; | ||
| int numCrossValFolds = 10; |
MemberAuthor
There was a problem hiding this comment.
There's no specific reason of doing that. I just feel like there's no need to mark this numCrossValFolds as const.
Member
There was a problem hiding this comment.
why you have a variable in the first place then? I mean why you don't just call the method and passing 10?
MemberAuthor
There was a problem hiding this comment.
I didn't notice that,, fixed and Resolved
tarekgh
reviewed
Sep 29, 2022
| // Else, run experiment using train-validate split. | ||
| const int crossValRowCountThreshold = 15000; | ||
| var rowCount = DatasetDimensionsUtil.CountRows(trainData, crossValRowCountThreshold); | ||
| // TODO |
Member
tarekgh
approved these changes
Sep 29, 2022
tarekgh
left a comment
Member
There was a problem hiding this comment.
module my minor questions, LGTM.
tarekgh
reviewed
Sep 29, 2022
| { | ||
| const int numCrossValFolds = 10; | ||
| _experiment.SetDataset(trainData, numCrossValFolds); | ||
| _experiment.SetDataset(trainData, 10); |
Member
There was a problem hiding this comment.
nit: you may add the parameter name before 10 for code readability :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are excited to review your PR.
So we can do the best job, please check:
There's a descriptive title that will make sense to other developers some time from now.
There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format
Fixes #nnnnin your description to cause GitHub to automatically close the issue(s) when your PR is merged.Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
You have included any necessary tests in the same PR.
AutoML.Net improvements tracking down list #6145
Update or deprecate AutoML 1.x APIs #6532