Refactor official build to use arcade templates - #6412

Merged
michaelgsharp merged 25 commits into
dotnet:mainfrom
ericstj:enablePost-Build
Oct 27, 2022
Merged

Refactor official build to use arcade templates#6412
michaelgsharp merged 25 commits into
dotnet:mainfrom
ericstj:enablePost-Build

Conversation

@ericstj

@ericstjericstj commented Oct 27, 2022

Copy link
Copy Markdown
Member

This refactors the official build to use the arcade templates which automate a lot of validation tasks. It also removes some redundant signing we were doing before, opting for a single signing phase after all packages have been built.

Here's a successful build from this change https://dev.azure.com/dnceng/internal/_build/results?buildId=2030382&view=results

@ericstj
Call arcade post-build template
d08e394
@ericstj
Fix post-build template location
3f03889
@ericstj
Add "Build" stage to pipeline
8e65846
@ericstj
Decrease indent of post-build import
0731af0
@ericstj
Is this yml better?
467fbeb
@ericstj
Use Arcade for publishing and signing
c458dd5
@ericstj
Add explicit publish step
dc4cd33
@ericstj
Fix publish-build-assets template import
4a29b4e
@ericstj
Remove a bunch of unnecessary build steps
20513b2
@ericstj
Rename intermediate build artifact PackageAssets to pkgassets
d0dba0c
This lets us remove an unnecessary copy step
@ericstj
Use job.yml template for Package job
0bedc65
@ericstj
Attempt to fix yml error by reformatting variables
d86931b
@ericstj
Make Native.proj download MlNetMklDeps package
31b7eb8
@ericstj
Fix publish build assets to depend on Package
ee9708d
@ericstj
Enable publish during Package job
eb18c8b
@ericstj
Set the pool for publish job
6fc1325
@ericstj
Enable PostBuildSign
18825e9
@ericstj
Fix author of Microsoft.ML.Mkl.Redist
66cb2ec
@ericstj
Make signing happen during Package job
e092c8c
@ericstj
Set SDK variable group
ae05a62
@ericstj
Publish logs and artifacts from Package job
09837e7
@ericstj
Enable more job template options
396ebb6
@ericstj
Attempt to fix import of SDL_Settings group
a45a09d
@ericstj
Attempt to fix syntax for variable group usage
83c42ab
@ericstj
Move pipeline variables into template
ec1f420
We need to include top-level variable groups but can only do so if we
use -name/value syntax. Hide this in a template so that it's less ugly.
@ghostghost assigned ericstjOct 27, 2022
tarekgh
tarekgh reviewed Oct 27, 2022
View reviewed changes
Comment threadsrc/Microsoft.ML.Mkl.Redist/Microsoft.ML.Mkl.Redist.csproj
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="$(RepoRoot)eng/pkg/Pack.props" />
<PropertyGroup>
<Authors>Intel</Authors>

@tarekghtarekghOct 27, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel

I assume this is ok and no concern removing it.

@ericstjericstjOct 27, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrong for us to claim Intel is the Author of the package. The gallery doesn't even present it to our users.
https://www.nuget.org/packages/Microsoft.ML.Mkl.Redist/2.0.0-preview.22313.1
image
We are the ones who build this package and binary, it's a custom linked copy of MKL. The package itself has the Intel license.

tarekgh
tarekgh reviewed Oct 27, 2022
View reviewed changes
Comment threadsrc/Native/Native.proj
<Target Name="Test" />

<ItemGroup>
<PackageDownload Include="MlNetMklDeps" Version="[$(MlNetMklDepsVersion)]" />

@tarekghtarekghOct 27, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[

interesting, does the version included inside brackets?

@ericstjericstjOct 27, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, PackageDownload requires explicit version references. https://learn.microsoft.com/en-us/nuget/consume-packages/packagedownload-functionality

@tarekgh

tarekgh commented Oct 27, 2022

Copy link
Copy Markdown
Member

@LittleLittleCloud Any idea about this failure?

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-6412-merge-b739effdcc32498c89/Microsoft.ML.AutoML.Tests/1/console.8ab99b89.log?helixlogtype=result

 ---> System.ObjectDisposedException: The CancellationTokenSource has been disposed.
at System.Threading.CancellationTokenSource.Cancel()
at Microsoft.ML.AutoML.AutoMLExperiment.<>c__DisplayClass26_1.<RunAsync>g__handler|4(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/AutoMLExperiment.cs:line 270
at Microsoft.ML.AutoML.AggregateTrainingStopManager.<.ctor>b__4_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 129
at Microsoft.ML.AutoML.TimeoutTrainingStopManager.<.ctor>b__5_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 72
at Microsoft.ML.AutoML.CancellationTokenStopTrainingManager.<.ctor>b__5_0() in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 38
at System.Threading.CancellationToken.<>c.<Register>b__12_0(Object obj)
at System.Threading.CancellationTokenSource.CallbackNode.<>c.<ExecuteCallback>b__9_0(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

tarekgh
tarekgh approved these changes Oct 27, 2022
View reviewed changes

@tarekghtarekgh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my best knowledge, LGTM.

@codecov

codecovBot commented Oct 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #6412 (ec1f420) into main (c69acbe) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@ Coverage Diff @@## main #6412 +/- ##
==========================================
- Coverage 68.54% 68.52% -0.02% 
==========================================
Files 1169 1170 +1 Lines 246867 246960 +93 Branches 25788 25790 +2 ==========================================
+ Hits 169206 169222 +16 - Misses 70938 71022 +84 + Partials 6723 6716 -7
FlagCoverage Δ
Debug68.52% <ø> (-0.02%)⬇️
production62.91% <ø> (-0.04%)⬇️
test88.96% <ø> (+0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
src/Microsoft.ML.FastTree/Dataset/DenseIntArray.cs26.73% <0.00%> (-17.67%)⬇️
src/Microsoft.ML.FastTree/Dataset/IntArray.cs12.10% <0.00%> (-0.90%)⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs86.38% <0.00%> (-0.15%)⬇️
...rosoft.ML.AutoML.Tests/StopTrainingManagerTests.cs100.00% <0.00%> (ø)
...Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs96.52% <0.00%> (+0.29%)⬆️

michaelgsharp
michaelgsharp approved these changes Oct 27, 2022
View reviewed changes

@michaelgsharpmichaelgsharp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelgsharp
michaelgsharp merged commit de79b8a into dotnet:mainOct 27, 2022
@ericstjericstj mentioned this pull request Oct 28, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekghtarekghtarekgh approved these changes
@mmitchemmitcheAwaiting requested review from mmitche
+1 more reviewer
@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ericstjericstj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@tarekgh@michaelgsharp
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Refactor official build to use arcade templates - #6412
Merged
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Oct 27, 2022
Merged
Refactor official build to use arcade templates#6412
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Conversation
@ericstj
@ericstjericstj
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
This refactors the official build to use the arcade templates which automate a lot of validation tasks. It also removes some redundant signing we were doing before, opting for a single signing phase after all packages have been built.
Here's a successful build from this change https://dev.azure.com/dnceng/internal/_build/results?buildId=2030382&view=results
@ericstj
Call arcade post-build template
d08e394
@ericstj
Fix post-build template location
3f03889
@ericstj
Add "Build" stage to pipeline
8e65846
@ericstj
Decrease indent of post-build import
0731af0
@ericstj
Is this yml better?
467fbeb
@ericstj
Use Arcade for publishing and signing
c458dd5
@ericstj
Add explicit publish step
dc4cd33
@ericstj
Fix publish-build-assets template import
4a29b4e
@ericstj
Remove a bunch of unnecessary build steps
20513b2
@ericstj
Rename intermediate build artifact PackageAssets to pkgassets
d0dba0c
This lets us remove an unnecessary copy step
@ericstj
Use job.yml template for Package job
0bedc65
@ericstj
Attempt to fix yml error by reformatting variables
d86931b
@ericstj
Make Native.proj download MlNetMklDeps package
31b7eb8
@ericstj
Fix publish build assets to depend on Package
ee9708d
@ericstj
Enable publish during Package job
eb18c8b
@ericstj
Set the pool for publish job
6fc1325
@ericstj
Enable PostBuildSign
18825e9
@ericstj
Fix author of Microsoft.ML.Mkl.Redist
66cb2ec
@ericstj
Make signing happen during Package job
e092c8c
@ericstj
Set SDK variable group
ae05a62
@ericstj
Publish logs and artifacts from Package job
09837e7
@ericstj
Enable more job template options
396ebb6
@ericstj
Attempt to fix import of SDL_Settings group
a45a09d
@ericstj
Attempt to fix syntax for variable group usage
83c42ab
@ericstj
Move pipeline variables into template
ec1f420
We need to include top-level variable groups but can only do so if we
use -name/value syntax. Hide this in a template so that it's less ugly.
@ghostghost
assigned ericstjOct 27, 2022
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Microsoft.ML.Mkl.Redist/Microsoft.ML.Mkl.Redist.csproj
<Project Sdk="Microsoft.NET.Sdk">
 <Import Project="$(RepoRoot)eng/pkg/Pack.props" />
 <PropertyGroup>
 <Authors>Intel</Authors>
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel 
I assume this is ok and no concern removing it.
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrong for us to claim Intel is the Author of the package. The gallery doesn't even present it to our users.
https://www.nuget.org/packages/Microsoft.ML.Mkl.Redist/2.0.0-preview.22313.1
image

We are the ones who build this package and binary, it's a custom linked copy of MKL. The package itself has the Intel license.
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Native/Native.proj
 <Target Name="Test" />

 <ItemGroup>
 <PackageDownload Include="MlNetMklDeps" Version="[$(MlNetMklDepsVersion)]" />
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ 
interesting, does the version included inside brackets?
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, PackageDownload requires explicit version references. https://learn.microsoft.com/en-us/nuget/consume-packages/packagedownload-functionality
@tarekgh
tarekgh
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
@LittleLittleCloud Any idea about this failure?
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-6412-merge-b739effdcc32498c89/Microsoft.ML.AutoML.Tests/1/console.8ab99b89.log?helixlogtype=result
 ---> System.ObjectDisposedException: The CancellationTokenSource has been disposed.
at System.Threading.CancellationTokenSource.Cancel()
at Microsoft.ML.AutoML.AutoMLExperiment.<>c__DisplayClass26_1.<RunAsync>g__handler|4(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/AutoMLExperiment.cs:line 270
at Microsoft.ML.AutoML.AggregateTrainingStopManager.<.ctor>b__4_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 129
at Microsoft.ML.AutoML.TimeoutTrainingStopManager.<.ctor>b__5_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 72
at Microsoft.ML.AutoML.CancellationTokenStopTrainingManager.<.ctor>b__5_0() in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 38
at System.Threading.CancellationToken.<>c.<Register>b__12_0(Object obj)
at System.Threading.CancellationTokenSource.CallbackNode.<>c.<ExecuteCallback>b__9_0(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

tarekgh
tarekgh
approved these changes
Oct 27, 2022
View reviewed changes
@tarekghtarekgh
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my best knowledge, LGTM.
@codecov
codecovBot
commented
Oct 27, 2022

Copy link


Copy Markdown

Codecov Report
Merging #6412 (ec1f420) into main (c69acbe) will decrease coverage by 0.01%.

The diff coverage is n/a.
Additional details and impacted files
@@ Coverage Diff @@## main #6412 +/- ##
==========================================
- Coverage 68.54% 68.52% -0.02% 
==========================================
Files 1169 1170 +1 Lines 246867 246960 +93 Branches 25788 25790 +2 ==========================================
+ Hits 169206 169222 +16 - Misses 70938 71022 +84 + Partials 6723 6716 -7 
FlagCoverage Δ
Debug68.52% <ø> (-0.02%)⬇️
production62.91% <ø> (-0.04%)⬇️
test88.96% <ø> (+0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
src/Microsoft.ML.FastTree/Dataset/DenseIntArray.cs26.73% <0.00%> (-17.67%)⬇️
src/Microsoft.ML.FastTree/Dataset/IntArray.cs12.10% <0.00%> (-0.90%)⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs86.38% <0.00%> (-0.15%)⬇️
...rosoft.ML.AutoML.Tests/StopTrainingManagerTests.cs100.00% <0.00%> (ø)
...Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs96.52% <0.00%> (+0.29%)⬆️
michaelgsharp
michaelgsharp
approved these changes
Oct 27, 2022
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@michaelgsharp
michaelgsharp
merged commit de79b8a
into
dotnet:mainOct 27, 2022
@ericstjericstj
mentioned this pull request
Oct 28, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 27, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh approved these changes
@mmitchemmitcheAwaiting requested review from mmitche

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ericstjericstj

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Refactor official build to use arcade templates - #6412
Merged
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Oct 27, 2022
Merged
Refactor official build to use arcade templates#6412
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Conversation
@ericstj
@ericstjericstj
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
This refactors the official build to use the arcade templates which automate a lot of validation tasks. It also removes some redundant signing we were doing before, opting for a single signing phase after all packages have been built.
Here's a successful build from this change https://dev.azure.com/dnceng/internal/_build/results?buildId=2030382&view=results
@ericstj
Call arcade post-build template
d08e394
@ericstj
Fix post-build template location
3f03889
@ericstj
Add "Build" stage to pipeline
8e65846
@ericstj
Decrease indent of post-build import
0731af0
@ericstj
Is this yml better?
467fbeb
@ericstj
Use Arcade for publishing and signing
c458dd5
@ericstj
Add explicit publish step
dc4cd33
@ericstj
Fix publish-build-assets template import
4a29b4e
@ericstj
Remove a bunch of unnecessary build steps
20513b2
@ericstj
Rename intermediate build artifact PackageAssets to pkgassets
d0dba0c
This lets us remove an unnecessary copy step
@ericstj
Use job.yml template for Package job
0bedc65
@ericstj
Attempt to fix yml error by reformatting variables
d86931b
@ericstj
Make Native.proj download MlNetMklDeps package
31b7eb8
@ericstj
Fix publish build assets to depend on Package
ee9708d
@ericstj
Enable publish during Package job
eb18c8b
@ericstj
Set the pool for publish job
6fc1325
@ericstj
Enable PostBuildSign
18825e9
@ericstj
Fix author of Microsoft.ML.Mkl.Redist
66cb2ec
@ericstj
Make signing happen during Package job
e092c8c
@ericstj
Set SDK variable group
ae05a62
@ericstj
Publish logs and artifacts from Package job
09837e7
@ericstj
Enable more job template options
396ebb6
@ericstj
Attempt to fix import of SDL_Settings group
a45a09d
@ericstj
Attempt to fix syntax for variable group usage
83c42ab
@ericstj
Move pipeline variables into template
ec1f420
We need to include top-level variable groups but can only do so if we
use -name/value syntax. Hide this in a template so that it's less ugly.
@ghostghost
assigned ericstjOct 27, 2022
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Microsoft.ML.Mkl.Redist/Microsoft.ML.Mkl.Redist.csproj
<Project Sdk="Microsoft.NET.Sdk">
 <Import Project="$(RepoRoot)eng/pkg/Pack.props" />
 <PropertyGroup>
 <Authors>Intel</Authors>
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel 
I assume this is ok and no concern removing it.
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrong for us to claim Intel is the Author of the package. The gallery doesn't even present it to our users.
https://www.nuget.org/packages/Microsoft.ML.Mkl.Redist/2.0.0-preview.22313.1
image

We are the ones who build this package and binary, it's a custom linked copy of MKL. The package itself has the Intel license.
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Native/Native.proj
 <Target Name="Test" />

 <ItemGroup>
 <PackageDownload Include="MlNetMklDeps" Version="[$(MlNetMklDepsVersion)]" />
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ 
interesting, does the version included inside brackets?
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, PackageDownload requires explicit version references. https://learn.microsoft.com/en-us/nuget/consume-packages/packagedownload-functionality
@tarekgh
tarekgh
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
@LittleLittleCloud Any idea about this failure?
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-6412-merge-b739effdcc32498c89/Microsoft.ML.AutoML.Tests/1/console.8ab99b89.log?helixlogtype=result
 ---> System.ObjectDisposedException: The CancellationTokenSource has been disposed.
at System.Threading.CancellationTokenSource.Cancel()
at Microsoft.ML.AutoML.AutoMLExperiment.<>c__DisplayClass26_1.<RunAsync>g__handler|4(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/AutoMLExperiment.cs:line 270
at Microsoft.ML.AutoML.AggregateTrainingStopManager.<.ctor>b__4_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 129
at Microsoft.ML.AutoML.TimeoutTrainingStopManager.<.ctor>b__5_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 72
at Microsoft.ML.AutoML.CancellationTokenStopTrainingManager.<.ctor>b__5_0() in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 38
at System.Threading.CancellationToken.<>c.<Register>b__12_0(Object obj)
at System.Threading.CancellationTokenSource.CallbackNode.<>c.<ExecuteCallback>b__9_0(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

tarekgh
tarekgh
approved these changes
Oct 27, 2022
View reviewed changes
@tarekghtarekgh
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my best knowledge, LGTM.
@codecov
codecovBot
commented
Oct 27, 2022

Copy link


Copy Markdown

Codecov Report
Merging #6412 (ec1f420) into main (c69acbe) will decrease coverage by 0.01%.

The diff coverage is n/a.
Additional details and impacted files
@@ Coverage Diff @@## main #6412 +/- ##
==========================================
- Coverage 68.54% 68.52% -0.02% 
==========================================
Files 1169 1170 +1 Lines 246867 246960 +93 Branches 25788 25790 +2 ==========================================
+ Hits 169206 169222 +16 - Misses 70938 71022 +84 + Partials 6723 6716 -7 
FlagCoverage Δ
Debug68.52% <ø> (-0.02%)⬇️
production62.91% <ø> (-0.04%)⬇️
test88.96% <ø> (+0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
src/Microsoft.ML.FastTree/Dataset/DenseIntArray.cs26.73% <0.00%> (-17.67%)⬇️
src/Microsoft.ML.FastTree/Dataset/IntArray.cs12.10% <0.00%> (-0.90%)⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs86.38% <0.00%> (-0.15%)⬇️
...rosoft.ML.AutoML.Tests/StopTrainingManagerTests.cs100.00% <0.00%> (ø)
...Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs96.52% <0.00%> (+0.29%)⬆️
michaelgsharp
michaelgsharp
approved these changes
Oct 27, 2022
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@michaelgsharp
michaelgsharp
merged commit de79b8a
into
dotnet:mainOct 27, 2022
@ericstjericstj
mentioned this pull request
Oct 28, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 27, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh approved these changes
@mmitchemmitcheAwaiting requested review from mmitche

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ericstjericstj

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Refactor official build to use arcade templates - #6412
Merged
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Oct 27, 2022
Merged
Refactor official build to use arcade templates#6412
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Conversation
@ericstj
@ericstjericstj
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
This refactors the official build to use the arcade templates which automate a lot of validation tasks. It also removes some redundant signing we were doing before, opting for a single signing phase after all packages have been built.
Here's a successful build from this change https://dev.azure.com/dnceng/internal/_build/results?buildId=2030382&view=results
@ericstj
Call arcade post-build template
d08e394
@ericstj
Fix post-build template location
3f03889
@ericstj
Add "Build" stage to pipeline
8e65846
@ericstj
Decrease indent of post-build import
0731af0
@ericstj
Is this yml better?
467fbeb
@ericstj
Use Arcade for publishing and signing
c458dd5
@ericstj
Add explicit publish step
dc4cd33
@ericstj
Fix publish-build-assets template import
4a29b4e
@ericstj
Remove a bunch of unnecessary build steps
20513b2
@ericstj
Rename intermediate build artifact PackageAssets to pkgassets
d0dba0c
This lets us remove an unnecessary copy step
@ericstj
Use job.yml template for Package job
0bedc65
@ericstj
Attempt to fix yml error by reformatting variables
d86931b
@ericstj
Make Native.proj download MlNetMklDeps package
31b7eb8
@ericstj
Fix publish build assets to depend on Package
ee9708d
@ericstj
Enable publish during Package job
eb18c8b
@ericstj
Set the pool for publish job
6fc1325
@ericstj
Enable PostBuildSign
18825e9
@ericstj
Fix author of Microsoft.ML.Mkl.Redist
66cb2ec
@ericstj
Make signing happen during Package job
e092c8c
@ericstj
Set SDK variable group
ae05a62
@ericstj
Publish logs and artifacts from Package job
09837e7
@ericstj
Enable more job template options
396ebb6
@ericstj
Attempt to fix import of SDL_Settings group
a45a09d
@ericstj
Attempt to fix syntax for variable group usage
83c42ab
@ericstj
Move pipeline variables into template
ec1f420
We need to include top-level variable groups but can only do so if we
use -name/value syntax. Hide this in a template so that it's less ugly.
@ghostghost
assigned ericstjOct 27, 2022
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Microsoft.ML.Mkl.Redist/Microsoft.ML.Mkl.Redist.csproj
<Project Sdk="Microsoft.NET.Sdk">
 <Import Project="$(RepoRoot)eng/pkg/Pack.props" />
 <PropertyGroup>
 <Authors>Intel</Authors>
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel 
I assume this is ok and no concern removing it.
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrong for us to claim Intel is the Author of the package. The gallery doesn't even present it to our users.
https://www.nuget.org/packages/Microsoft.ML.Mkl.Redist/2.0.0-preview.22313.1
image

We are the ones who build this package and binary, it's a custom linked copy of MKL. The package itself has the Intel license.
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Native/Native.proj
 <Target Name="Test" />

 <ItemGroup>
 <PackageDownload Include="MlNetMklDeps" Version="[$(MlNetMklDepsVersion)]" />
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ 
interesting, does the version included inside brackets?
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, PackageDownload requires explicit version references. https://learn.microsoft.com/en-us/nuget/consume-packages/packagedownload-functionality
@tarekgh
tarekgh
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
@LittleLittleCloud Any idea about this failure?
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-6412-merge-b739effdcc32498c89/Microsoft.ML.AutoML.Tests/1/console.8ab99b89.log?helixlogtype=result
 ---> System.ObjectDisposedException: The CancellationTokenSource has been disposed.
at System.Threading.CancellationTokenSource.Cancel()
at Microsoft.ML.AutoML.AutoMLExperiment.<>c__DisplayClass26_1.<RunAsync>g__handler|4(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/AutoMLExperiment.cs:line 270
at Microsoft.ML.AutoML.AggregateTrainingStopManager.<.ctor>b__4_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 129
at Microsoft.ML.AutoML.TimeoutTrainingStopManager.<.ctor>b__5_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 72
at Microsoft.ML.AutoML.CancellationTokenStopTrainingManager.<.ctor>b__5_0() in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 38
at System.Threading.CancellationToken.<>c.<Register>b__12_0(Object obj)
at System.Threading.CancellationTokenSource.CallbackNode.<>c.<ExecuteCallback>b__9_0(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

tarekgh
tarekgh
approved these changes
Oct 27, 2022
View reviewed changes
@tarekghtarekgh
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my best knowledge, LGTM.
@codecov
codecovBot
commented
Oct 27, 2022

Copy link


Copy Markdown

Codecov Report
Merging #6412 (ec1f420) into main (c69acbe) will decrease coverage by 0.01%.

The diff coverage is n/a.
Additional details and impacted files
@@ Coverage Diff @@## main #6412 +/- ##
==========================================
- Coverage 68.54% 68.52% -0.02% 
==========================================
Files 1169 1170 +1 Lines 246867 246960 +93 Branches 25788 25790 +2 ==========================================
+ Hits 169206 169222 +16 - Misses 70938 71022 +84 + Partials 6723 6716 -7 
FlagCoverage Δ
Debug68.52% <ø> (-0.02%)⬇️
production62.91% <ø> (-0.04%)⬇️
test88.96% <ø> (+0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
src/Microsoft.ML.FastTree/Dataset/DenseIntArray.cs26.73% <0.00%> (-17.67%)⬇️
src/Microsoft.ML.FastTree/Dataset/IntArray.cs12.10% <0.00%> (-0.90%)⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs86.38% <0.00%> (-0.15%)⬇️
...rosoft.ML.AutoML.Tests/StopTrainingManagerTests.cs100.00% <0.00%> (ø)
...Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs96.52% <0.00%> (+0.29%)⬆️
michaelgsharp
michaelgsharp
approved these changes
Oct 27, 2022
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@michaelgsharp
michaelgsharp
merged commit de79b8a
into
dotnet:mainOct 27, 2022
@ericstjericstj
mentioned this pull request
Oct 28, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 27, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh approved these changes
@mmitchemmitcheAwaiting requested review from mmitche

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ericstjericstj

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Refactor official build to use arcade templates - #6412
Merged
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Oct 27, 2022
Merged
Refactor official build to use arcade templates#6412
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Conversation
@ericstj
@ericstjericstj
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
This refactors the official build to use the arcade templates which automate a lot of validation tasks. It also removes some redundant signing we were doing before, opting for a single signing phase after all packages have been built.
Here's a successful build from this change https://dev.azure.com/dnceng/internal/_build/results?buildId=2030382&view=results
@ericstj
Call arcade post-build template
d08e394
@ericstj
Fix post-build template location
3f03889
@ericstj
Add "Build" stage to pipeline
8e65846
@ericstj
Decrease indent of post-build import
0731af0
@ericstj
Is this yml better?
467fbeb
@ericstj
Use Arcade for publishing and signing
c458dd5
@ericstj
Add explicit publish step
dc4cd33
@ericstj
Fix publish-build-assets template import
4a29b4e
@ericstj
Remove a bunch of unnecessary build steps
20513b2
@ericstj
Rename intermediate build artifact PackageAssets to pkgassets
d0dba0c
This lets us remove an unnecessary copy step
@ericstj
Use job.yml template for Package job
0bedc65
@ericstj
Attempt to fix yml error by reformatting variables
d86931b
@ericstj
Make Native.proj download MlNetMklDeps package
31b7eb8
@ericstj
Fix publish build assets to depend on Package
ee9708d
@ericstj
Enable publish during Package job
eb18c8b
@ericstj
Set the pool for publish job
6fc1325
@ericstj
Enable PostBuildSign
18825e9
@ericstj
Fix author of Microsoft.ML.Mkl.Redist
66cb2ec
@ericstj
Make signing happen during Package job
e092c8c
@ericstj
Set SDK variable group
ae05a62
@ericstj
Publish logs and artifacts from Package job
09837e7
@ericstj
Enable more job template options
396ebb6
@ericstj
Attempt to fix import of SDL_Settings group
a45a09d
@ericstj
Attempt to fix syntax for variable group usage
83c42ab
@ericstj
Move pipeline variables into template
ec1f420
We need to include top-level variable groups but can only do so if we
use -name/value syntax. Hide this in a template so that it's less ugly.
@ghostghost
assigned ericstjOct 27, 2022
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Microsoft.ML.Mkl.Redist/Microsoft.ML.Mkl.Redist.csproj
<Project Sdk="Microsoft.NET.Sdk">
 <Import Project="$(RepoRoot)eng/pkg/Pack.props" />
 <PropertyGroup>
 <Authors>Intel</Authors>
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel 
I assume this is ok and no concern removing it.
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrong for us to claim Intel is the Author of the package. The gallery doesn't even present it to our users.
https://www.nuget.org/packages/Microsoft.ML.Mkl.Redist/2.0.0-preview.22313.1
image

We are the ones who build this package and binary, it's a custom linked copy of MKL. The package itself has the Intel license.
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Native/Native.proj
 <Target Name="Test" />

 <ItemGroup>
 <PackageDownload Include="MlNetMklDeps" Version="[$(MlNetMklDepsVersion)]" />
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ 
interesting, does the version included inside brackets?
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, PackageDownload requires explicit version references. https://learn.microsoft.com/en-us/nuget/consume-packages/packagedownload-functionality
@tarekgh
tarekgh
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
@LittleLittleCloud Any idea about this failure?
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-6412-merge-b739effdcc32498c89/Microsoft.ML.AutoML.Tests/1/console.8ab99b89.log?helixlogtype=result
 ---> System.ObjectDisposedException: The CancellationTokenSource has been disposed.
at System.Threading.CancellationTokenSource.Cancel()
at Microsoft.ML.AutoML.AutoMLExperiment.<>c__DisplayClass26_1.<RunAsync>g__handler|4(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/AutoMLExperiment.cs:line 270
at Microsoft.ML.AutoML.AggregateTrainingStopManager.<.ctor>b__4_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 129
at Microsoft.ML.AutoML.TimeoutTrainingStopManager.<.ctor>b__5_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 72
at Microsoft.ML.AutoML.CancellationTokenStopTrainingManager.<.ctor>b__5_0() in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 38
at System.Threading.CancellationToken.<>c.<Register>b__12_0(Object obj)
at System.Threading.CancellationTokenSource.CallbackNode.<>c.<ExecuteCallback>b__9_0(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

tarekgh
tarekgh
approved these changes
Oct 27, 2022
View reviewed changes
@tarekghtarekgh
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my best knowledge, LGTM.
@codecov
codecovBot
commented
Oct 27, 2022

Copy link


Copy Markdown

Codecov Report
Merging #6412 (ec1f420) into main (c69acbe) will decrease coverage by 0.01%.

The diff coverage is n/a.
Additional details and impacted files
@@ Coverage Diff @@## main #6412 +/- ##
==========================================
- Coverage 68.54% 68.52% -0.02% 
==========================================
Files 1169 1170 +1 Lines 246867 246960 +93 Branches 25788 25790 +2 ==========================================
+ Hits 169206 169222 +16 - Misses 70938 71022 +84 + Partials 6723 6716 -7 
FlagCoverage Δ
Debug68.52% <ø> (-0.02%)⬇️
production62.91% <ø> (-0.04%)⬇️
test88.96% <ø> (+0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
src/Microsoft.ML.FastTree/Dataset/DenseIntArray.cs26.73% <0.00%> (-17.67%)⬇️
src/Microsoft.ML.FastTree/Dataset/IntArray.cs12.10% <0.00%> (-0.90%)⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs86.38% <0.00%> (-0.15%)⬇️
...rosoft.ML.AutoML.Tests/StopTrainingManagerTests.cs100.00% <0.00%> (ø)
...Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs96.52% <0.00%> (+0.29%)⬆️
michaelgsharp
michaelgsharp
approved these changes
Oct 27, 2022
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@michaelgsharp
michaelgsharp
merged commit de79b8a
into
dotnet:mainOct 27, 2022
@ericstjericstj
mentioned this pull request
Oct 28, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 27, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh approved these changes
@mmitchemmitcheAwaiting requested review from mmitche

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ericstjericstj

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Refactor official build to use arcade templates - #6412
Merged
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Oct 27, 2022
Merged
Refactor official build to use arcade templates#6412
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Conversation
@ericstj
@ericstjericstj
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
This refactors the official build to use the arcade templates which automate a lot of validation tasks. It also removes some redundant signing we were doing before, opting for a single signing phase after all packages have been built.
Here's a successful build from this change https://dev.azure.com/dnceng/internal/_build/results?buildId=2030382&view=results
@ericstj
Call arcade post-build template
d08e394
@ericstj
Fix post-build template location
3f03889
@ericstj
Add "Build" stage to pipeline
8e65846
@ericstj
Decrease indent of post-build import
0731af0
@ericstj
Is this yml better?
467fbeb
@ericstj
Use Arcade for publishing and signing
c458dd5
@ericstj
Add explicit publish step
dc4cd33
@ericstj
Fix publish-build-assets template import
4a29b4e
@ericstj
Remove a bunch of unnecessary build steps
20513b2
@ericstj
Rename intermediate build artifact PackageAssets to pkgassets
d0dba0c
This lets us remove an unnecessary copy step
@ericstj
Use job.yml template for Package job
0bedc65
@ericstj
Attempt to fix yml error by reformatting variables
d86931b
@ericstj
Make Native.proj download MlNetMklDeps package
31b7eb8
@ericstj
Fix publish build assets to depend on Package
ee9708d
@ericstj
Enable publish during Package job
eb18c8b
@ericstj
Set the pool for publish job
6fc1325
@ericstj
Enable PostBuildSign
18825e9
@ericstj
Fix author of Microsoft.ML.Mkl.Redist
66cb2ec
@ericstj
Make signing happen during Package job
e092c8c
@ericstj
Set SDK variable group
ae05a62
@ericstj
Publish logs and artifacts from Package job
09837e7
@ericstj
Enable more job template options
396ebb6
@ericstj
Attempt to fix import of SDL_Settings group
a45a09d
@ericstj
Attempt to fix syntax for variable group usage
83c42ab
@ericstj
Move pipeline variables into template
ec1f420
We need to include top-level variable groups but can only do so if we
use -name/value syntax. Hide this in a template so that it's less ugly.
@ghostghost
assigned ericstjOct 27, 2022
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Microsoft.ML.Mkl.Redist/Microsoft.ML.Mkl.Redist.csproj
<Project Sdk="Microsoft.NET.Sdk">
 <Import Project="$(RepoRoot)eng/pkg/Pack.props" />
 <PropertyGroup>
 <Authors>Intel</Authors>
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel 
I assume this is ok and no concern removing it.
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrong for us to claim Intel is the Author of the package. The gallery doesn't even present it to our users.
https://www.nuget.org/packages/Microsoft.ML.Mkl.Redist/2.0.0-preview.22313.1
image

We are the ones who build this package and binary, it's a custom linked copy of MKL. The package itself has the Intel license.
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Native/Native.proj
 <Target Name="Test" />

 <ItemGroup>
 <PackageDownload Include="MlNetMklDeps" Version="[$(MlNetMklDepsVersion)]" />
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ 
interesting, does the version included inside brackets?
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, PackageDownload requires explicit version references. https://learn.microsoft.com/en-us/nuget/consume-packages/packagedownload-functionality
@tarekgh
tarekgh
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
@LittleLittleCloud Any idea about this failure?
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-6412-merge-b739effdcc32498c89/Microsoft.ML.AutoML.Tests/1/console.8ab99b89.log?helixlogtype=result
 ---> System.ObjectDisposedException: The CancellationTokenSource has been disposed.
at System.Threading.CancellationTokenSource.Cancel()
at Microsoft.ML.AutoML.AutoMLExperiment.<>c__DisplayClass26_1.<RunAsync>g__handler|4(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/AutoMLExperiment.cs:line 270
at Microsoft.ML.AutoML.AggregateTrainingStopManager.<.ctor>b__4_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 129
at Microsoft.ML.AutoML.TimeoutTrainingStopManager.<.ctor>b__5_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 72
at Microsoft.ML.AutoML.CancellationTokenStopTrainingManager.<.ctor>b__5_0() in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 38
at System.Threading.CancellationToken.<>c.<Register>b__12_0(Object obj)
at System.Threading.CancellationTokenSource.CallbackNode.<>c.<ExecuteCallback>b__9_0(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

tarekgh
tarekgh
approved these changes
Oct 27, 2022
View reviewed changes
@tarekghtarekgh
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my best knowledge, LGTM.
@codecov
codecovBot
commented
Oct 27, 2022

Copy link


Copy Markdown

Codecov Report
Merging #6412 (ec1f420) into main (c69acbe) will decrease coverage by 0.01%.

The diff coverage is n/a.
Additional details and impacted files
@@ Coverage Diff @@## main #6412 +/- ##
==========================================
- Coverage 68.54% 68.52% -0.02% 
==========================================
Files 1169 1170 +1 Lines 246867 246960 +93 Branches 25788 25790 +2 ==========================================
+ Hits 169206 169222 +16 - Misses 70938 71022 +84 + Partials 6723 6716 -7 
FlagCoverage Δ
Debug68.52% <ø> (-0.02%)⬇️
production62.91% <ø> (-0.04%)⬇️
test88.96% <ø> (+0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
src/Microsoft.ML.FastTree/Dataset/DenseIntArray.cs26.73% <0.00%> (-17.67%)⬇️
src/Microsoft.ML.FastTree/Dataset/IntArray.cs12.10% <0.00%> (-0.90%)⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs86.38% <0.00%> (-0.15%)⬇️
...rosoft.ML.AutoML.Tests/StopTrainingManagerTests.cs100.00% <0.00%> (ø)
...Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs96.52% <0.00%> (+0.29%)⬆️
michaelgsharp
michaelgsharp
approved these changes
Oct 27, 2022
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@michaelgsharp
michaelgsharp
merged commit de79b8a
into
dotnet:mainOct 27, 2022
@ericstjericstj
mentioned this pull request
Oct 28, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 27, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh approved these changes
@mmitchemmitcheAwaiting requested review from mmitche

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ericstjericstj

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Refactor official build to use arcade templates - #6412
Merged
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Oct 27, 2022
Merged
Refactor official build to use arcade templates#6412
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Conversation
@ericstj
@ericstjericstj
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
This refactors the official build to use the arcade templates which automate a lot of validation tasks. It also removes some redundant signing we were doing before, opting for a single signing phase after all packages have been built.
Here's a successful build from this change https://dev.azure.com/dnceng/internal/_build/results?buildId=2030382&view=results
@ericstj
Call arcade post-build template
d08e394
@ericstj
Fix post-build template location
3f03889
@ericstj
Add "Build" stage to pipeline
8e65846
@ericstj
Decrease indent of post-build import
0731af0
@ericstj
Is this yml better?
467fbeb
@ericstj
Use Arcade for publishing and signing
c458dd5
@ericstj
Add explicit publish step
dc4cd33
@ericstj
Fix publish-build-assets template import
4a29b4e
@ericstj
Remove a bunch of unnecessary build steps
20513b2
@ericstj
Rename intermediate build artifact PackageAssets to pkgassets
d0dba0c
This lets us remove an unnecessary copy step
@ericstj
Use job.yml template for Package job
0bedc65
@ericstj
Attempt to fix yml error by reformatting variables
d86931b
@ericstj
Make Native.proj download MlNetMklDeps package
31b7eb8
@ericstj
Fix publish build assets to depend on Package
ee9708d
@ericstj
Enable publish during Package job
eb18c8b
@ericstj
Set the pool for publish job
6fc1325
@ericstj
Enable PostBuildSign
18825e9
@ericstj
Fix author of Microsoft.ML.Mkl.Redist
66cb2ec
@ericstj
Make signing happen during Package job
e092c8c
@ericstj
Set SDK variable group
ae05a62
@ericstj
Publish logs and artifacts from Package job
09837e7
@ericstj
Enable more job template options
396ebb6
@ericstj
Attempt to fix import of SDL_Settings group
a45a09d
@ericstj
Attempt to fix syntax for variable group usage
83c42ab
@ericstj
Move pipeline variables into template
ec1f420
We need to include top-level variable groups but can only do so if we
use -name/value syntax. Hide this in a template so that it's less ugly.
@ghostghost
assigned ericstjOct 27, 2022
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Microsoft.ML.Mkl.Redist/Microsoft.ML.Mkl.Redist.csproj
<Project Sdk="Microsoft.NET.Sdk">
 <Import Project="$(RepoRoot)eng/pkg/Pack.props" />
 <PropertyGroup>
 <Authors>Intel</Authors>
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel 
I assume this is ok and no concern removing it.
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrong for us to claim Intel is the Author of the package. The gallery doesn't even present it to our users.
https://www.nuget.org/packages/Microsoft.ML.Mkl.Redist/2.0.0-preview.22313.1
image

We are the ones who build this package and binary, it's a custom linked copy of MKL. The package itself has the Intel license.
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Native/Native.proj
 <Target Name="Test" />

 <ItemGroup>
 <PackageDownload Include="MlNetMklDeps" Version="[$(MlNetMklDepsVersion)]" />
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ 
interesting, does the version included inside brackets?
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, PackageDownload requires explicit version references. https://learn.microsoft.com/en-us/nuget/consume-packages/packagedownload-functionality
@tarekgh
tarekgh
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
@LittleLittleCloud Any idea about this failure?
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-6412-merge-b739effdcc32498c89/Microsoft.ML.AutoML.Tests/1/console.8ab99b89.log?helixlogtype=result
 ---> System.ObjectDisposedException: The CancellationTokenSource has been disposed.
at System.Threading.CancellationTokenSource.Cancel()
at Microsoft.ML.AutoML.AutoMLExperiment.<>c__DisplayClass26_1.<RunAsync>g__handler|4(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/AutoMLExperiment.cs:line 270
at Microsoft.ML.AutoML.AggregateTrainingStopManager.<.ctor>b__4_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 129
at Microsoft.ML.AutoML.TimeoutTrainingStopManager.<.ctor>b__5_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 72
at Microsoft.ML.AutoML.CancellationTokenStopTrainingManager.<.ctor>b__5_0() in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 38
at System.Threading.CancellationToken.<>c.<Register>b__12_0(Object obj)
at System.Threading.CancellationTokenSource.CallbackNode.<>c.<ExecuteCallback>b__9_0(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

tarekgh
tarekgh
approved these changes
Oct 27, 2022
View reviewed changes
@tarekghtarekgh
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my best knowledge, LGTM.
@codecov
codecovBot
commented
Oct 27, 2022

Copy link


Copy Markdown

Codecov Report
Merging #6412 (ec1f420) into main (c69acbe) will decrease coverage by 0.01%.

The diff coverage is n/a.
Additional details and impacted files
@@ Coverage Diff @@## main #6412 +/- ##
==========================================
- Coverage 68.54% 68.52% -0.02% 
==========================================
Files 1169 1170 +1 Lines 246867 246960 +93 Branches 25788 25790 +2 ==========================================
+ Hits 169206 169222 +16 - Misses 70938 71022 +84 + Partials 6723 6716 -7 
FlagCoverage Δ
Debug68.52% <ø> (-0.02%)⬇️
production62.91% <ø> (-0.04%)⬇️
test88.96% <ø> (+0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
src/Microsoft.ML.FastTree/Dataset/DenseIntArray.cs26.73% <0.00%> (-17.67%)⬇️
src/Microsoft.ML.FastTree/Dataset/IntArray.cs12.10% <0.00%> (-0.90%)⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs86.38% <0.00%> (-0.15%)⬇️
...rosoft.ML.AutoML.Tests/StopTrainingManagerTests.cs100.00% <0.00%> (ø)
...Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs96.52% <0.00%> (+0.29%)⬆️
michaelgsharp
michaelgsharp
approved these changes
Oct 27, 2022
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@michaelgsharp
michaelgsharp
merged commit de79b8a
into
dotnet:mainOct 27, 2022
@ericstjericstj
mentioned this pull request
Oct 28, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 27, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh approved these changes
@mmitchemmitcheAwaiting requested review from mmitche

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ericstjericstj

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Refactor official build to use arcade templates - #6412
Merged
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Oct 27, 2022
Merged
Refactor official build to use arcade templates#6412
michaelgsharp merged 25 commits into
dotnet:mainfrom 
ericstj:enablePost-Build
Conversation
@ericstj
@ericstjericstj
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
This refactors the official build to use the arcade templates which automate a lot of validation tasks. It also removes some redundant signing we were doing before, opting for a single signing phase after all packages have been built.
Here's a successful build from this change https://dev.azure.com/dnceng/internal/_build/results?buildId=2030382&view=results
@ericstj
Call arcade post-build template
d08e394
@ericstj
Fix post-build template location
3f03889
@ericstj
Add "Build" stage to pipeline
8e65846
@ericstj
Decrease indent of post-build import
0731af0
@ericstj
Is this yml better?
467fbeb
@ericstj
Use Arcade for publishing and signing
c458dd5
@ericstj
Add explicit publish step
dc4cd33
@ericstj
Fix publish-build-assets template import
4a29b4e
@ericstj
Remove a bunch of unnecessary build steps
20513b2
@ericstj
Rename intermediate build artifact PackageAssets to pkgassets
d0dba0c
This lets us remove an unnecessary copy step
@ericstj
Use job.yml template for Package job
0bedc65
@ericstj
Attempt to fix yml error by reformatting variables
d86931b
@ericstj
Make Native.proj download MlNetMklDeps package
31b7eb8
@ericstj
Fix publish build assets to depend on Package
ee9708d
@ericstj
Enable publish during Package job
eb18c8b
@ericstj
Set the pool for publish job
6fc1325
@ericstj
Enable PostBuildSign
18825e9
@ericstj
Fix author of Microsoft.ML.Mkl.Redist
66cb2ec
@ericstj
Make signing happen during Package job
e092c8c
@ericstj
Set SDK variable group
ae05a62
@ericstj
Publish logs and artifacts from Package job
09837e7
@ericstj
Enable more job template options
396ebb6
@ericstj
Attempt to fix import of SDL_Settings group
a45a09d
@ericstj
Attempt to fix syntax for variable group usage
83c42ab
@ericstj
Move pipeline variables into template
ec1f420
We need to include top-level variable groups but can only do so if we
use -name/value syntax. Hide this in a template so that it's less ugly.
@ghostghost
assigned ericstjOct 27, 2022
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Microsoft.ML.Mkl.Redist/Microsoft.ML.Mkl.Redist.csproj
<Project Sdk="Microsoft.NET.Sdk">
 <Import Project="$(RepoRoot)eng/pkg/Pack.props" />
 <PropertyGroup>
 <Authors>Intel</Authors>
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel 
I assume this is ok and no concern removing it.
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrong for us to claim Intel is the Author of the package. The gallery doesn't even present it to our users.
https://www.nuget.org/packages/Microsoft.ML.Mkl.Redist/2.0.0-preview.22313.1
image

We are the ones who build this package and binary, it's a custom linked copy of MKL. The package itself has the Intel license.
tarekgh
tarekgh
reviewed
Oct 27, 2022
View reviewed changes
Comment threadsrc/Native/Native.proj
 <Target Name="Test" />

 <ItemGroup>
 <PackageDownload Include="MlNetMklDeps" Version="[$(MlNetMklDepsVersion)]" />
@tarekghtarekghOct 27, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ 
interesting, does the version included inside brackets?
@ericstjericstjOct 27, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, PackageDownload requires explicit version references. https://learn.microsoft.com/en-us/nuget/consume-packages/packagedownload-functionality
@tarekgh
tarekgh
commented
Oct 27, 2022

Copy link


Copy Markdown

Member
@LittleLittleCloud Any idea about this failure?
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-6412-merge-b739effdcc32498c89/Microsoft.ML.AutoML.Tests/1/console.8ab99b89.log?helixlogtype=result
 ---> System.ObjectDisposedException: The CancellationTokenSource has been disposed.
at System.Threading.CancellationTokenSource.Cancel()
at Microsoft.ML.AutoML.AutoMLExperiment.<>c__DisplayClass26_1.<RunAsync>g__handler|4(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/AutoMLExperiment.cs:line 270
at Microsoft.ML.AutoML.AggregateTrainingStopManager.<.ctor>b__4_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 129
at Microsoft.ML.AutoML.TimeoutTrainingStopManager.<.ctor>b__5_0(Object o, EventArgs e) in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 72
at Microsoft.ML.AutoML.CancellationTokenStopTrainingManager.<.ctor>b__5_0() in /__w/1/s/src/Microsoft.ML.AutoML/AutoMLExperiment/IStopTrainingManager.cs:line 38
at System.Threading.CancellationToken.<>c.<Register>b__12_0(Object obj)
at System.Threading.CancellationTokenSource.CallbackNode.<>c.<ExecuteCallback>b__9_0(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

tarekgh
tarekgh
approved these changes
Oct 27, 2022
View reviewed changes
@tarekghtarekgh
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my best knowledge, LGTM.
@codecov
codecovBot
commented
Oct 27, 2022

Copy link


Copy Markdown

Codecov Report
Merging #6412 (ec1f420) into main (c69acbe) will decrease coverage by 0.01%.

The diff coverage is n/a.
Additional details and impacted files
@@ Coverage Diff @@## main #6412 +/- ##
==========================================
- Coverage 68.54% 68.52% -0.02% 
==========================================
Files 1169 1170 +1 Lines 246867 246960 +93 Branches 25788 25790 +2 ==========================================
+ Hits 169206 169222 +16 - Misses 70938 71022 +84 + Partials 6723 6716 -7 
FlagCoverage Δ
Debug68.52% <ø> (-0.02%)⬇️
production62.91% <ø> (-0.04%)⬇️
test88.96% <ø> (+0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
src/Microsoft.ML.FastTree/Dataset/DenseIntArray.cs26.73% <0.00%> (-17.67%)⬇️
src/Microsoft.ML.FastTree/Dataset/IntArray.cs12.10% <0.00%> (-0.90%)⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs86.38% <0.00%> (-0.15%)⬇️
...rosoft.ML.AutoML.Tests/StopTrainingManagerTests.cs100.00% <0.00%> (ø)
...Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs96.52% <0.00%> (+0.29%)⬆️
michaelgsharp
michaelgsharp
approved these changes
Oct 27, 2022
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@michaelgsharp
michaelgsharp
merged commit de79b8a
into
dotnet:mainOct 27, 2022
@ericstjericstj
mentioned this pull request
Oct 28, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 27, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh approved these changes
@mmitchemmitcheAwaiting requested review from mmitche

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ericstjericstj

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@tarekgh@michaelgsharp