Clean up PrimitiveColumnContainer by JakeRadMSFT · Pull Request #6656 · dotnet/machinelearning

JakeRadMSFT · 2023-05-05T10:37:39Z

I was inspired by a community members PR (#6642) to try and clean up PrimitiveColumnContainer.

I'd say this is Part 1 of a few part series for improving DataFrame.

Updates the code to be more consistent with the Buffer and nullBufferBitMap usage
Updated all the PrimitiveColumn related things that used to be T : struct and move to T : unmanaged.
Hopefully improved readability

Not Fixed:

It's still not thread safe

Try to clean up PrimitiveColumnContainer

agocke · 2023-05-05T16:38:16Z

 }
 }

 public void ApplyElementwise(Func<T?, long, T?> func)


Out of curiosity, what is the contract for this method? It's going to swap out the buffer in the array with a new one -- what if someone's holding on to the old one? How do you handle reference invalidation?

I just inherited this but my understanding is the following:
This method is going to apply func for each element and update the value in buffer
It will make the buffer mutable if it needs to
It will update the nullBitMapBuffer
If something is holding on to the old buffer - it shouldn't be/it's outdated.

Fix helper

Remove duplicate

More clean up

Fix slice

Update name to GetOrCreateMutable

Use null instead of default for nullable values.

Clean up Apply methods.

…cleanup' into u/jakerad/column-container-cleanup

codecov · 2023-05-06T06:24:39Z

Codecov Report

Merging #6656 (e33608d) into main (3986fcf) will decrease coverage by 0.01%.
The diff coverage is 90.74%.

Additional details and impacted files

@@ Coverage Diff @@## main #6656 +/- ##
==========================================
- Coverage 68.59% 68.59% -0.01% 
==========================================
Files 1200 1201 +1 Lines 250326 250296 -30 Branches 26096 26094 -2 ==========================================
- Hits 171701 171679 -22 + Misses 71809 71803 -6 + Partials 6816 6814 -2

Flag	Coverage Δ
Debug	`68.59% <90.74%> (-0.01%)`	⬇️
production	`63.07% <90.74%> (-0.01%)`	⬇️
test	`88.84% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Microsoft.Data.Analysis/DataFrameBuffer.cs	`82.60% <ø> (ø)`
...lysis/PrimitiveColumnContainer.BinaryOperations.cs	`84.21% <ø> (ø)`
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs	`48.98% <ø> (ø)`
...a.Analysis/PrimitiveDataFrameColumnComputations.cs	`45.66% <ø> (ø)`
...Microsoft.Data.Analysis/ReadOnlyDataFrameBuffer.cs	`47.36% <ø> (ø)`
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs	`83.04% <88.63%> (+0.03%)`	⬆️
...t.Data.Analysis/PrimitiveColumnContainerHelpers.cs	`100.00% <100.00%> (ø)`

... and 6 files with indirect coverage changes

JakeRadMSFT · 2023-05-05T10:37:39Z

I was inspired by a community members PR (#6642) to try and clean up PrimitiveColumnContainer.

I'd say this is Part 1 of a few part series for improving DataFrame.

Updates the code to be more consistent with the Buffer and nullBufferBitMap usage
Updated all the PrimitiveColumn related things that used to be T : struct and move to T : unmanaged.
Hopefully improved readability

Not Fixed:

It's still not thread safe

Try to clean up PrimitiveColumnContainer

agocke · 2023-05-05T16:38:16Z

 }
 }

 public void ApplyElementwise(Func<T?, long, T?> func)


Out of curiosity, what is the contract for this method? It's going to swap out the buffer in the array with a new one -- what if someone's holding on to the old one? How do you handle reference invalidation?

I just inherited this but my understanding is the following:
This method is going to apply func for each element and update the value in buffer
It will make the buffer mutable if it needs to
It will update the nullBitMapBuffer
If something is holding on to the old buffer - it shouldn't be/it's outdated.

Fix helper

Remove duplicate

More clean up

Fix slice

Update name to GetOrCreateMutable

Use null instead of default for nullable values.

Clean up Apply methods.

…cleanup' into u/jakerad/column-container-cleanup

codecov · 2023-05-06T06:24:39Z

Codecov Report

Merging #6656 (e33608d) into main (3986fcf) will decrease coverage by 0.01%.
The diff coverage is 90.74%.

Additional details and impacted files

@@ Coverage Diff @@## main #6656 +/- ##
==========================================
- Coverage 68.59% 68.59% -0.01% 
==========================================
Files 1200 1201 +1 Lines 250326 250296 -30 Branches 26096 26094 -2 ==========================================
- Hits 171701 171679 -22 + Misses 71809 71803 -6 + Partials 6816 6814 -2

Flag	Coverage Δ
Debug	`68.59% <90.74%> (-0.01%)`	⬇️
production	`63.07% <90.74%> (-0.01%)`	⬇️
test	`88.84% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Microsoft.Data.Analysis/DataFrameBuffer.cs	`82.60% <ø> (ø)`
...lysis/PrimitiveColumnContainer.BinaryOperations.cs	`84.21% <ø> (ø)`
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs	`48.98% <ø> (ø)`
...a.Analysis/PrimitiveDataFrameColumnComputations.cs	`45.66% <ø> (ø)`
...Microsoft.Data.Analysis/ReadOnlyDataFrameBuffer.cs	`47.36% <ø> (ø)`
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs	`83.04% <88.63%> (+0.03%)`	⬆️
...t.Data.Analysis/PrimitiveColumnContainerHelpers.cs	`100.00% <100.00%> (ø)`

... and 6 files with indirect coverage changes

JakeRadMSFT · 2023-05-05T10:37:39Z

I was inspired by a community members PR (#6642) to try and clean up PrimitiveColumnContainer.

I'd say this is Part 1 of a few part series for improving DataFrame.

Updates the code to be more consistent with the Buffer and nullBufferBitMap usage
Updated all the PrimitiveColumn related things that used to be T : struct and move to T : unmanaged.
Hopefully improved readability

Not Fixed:

It's still not thread safe

Try to clean up PrimitiveColumnContainer

agocke · 2023-05-05T16:38:16Z

 }
 }

 public void ApplyElementwise(Func<T?, long, T?> func)


Out of curiosity, what is the contract for this method? It's going to swap out the buffer in the array with a new one -- what if someone's holding on to the old one? How do you handle reference invalidation?

I just inherited this but my understanding is the following:
This method is going to apply func for each element and update the value in buffer
It will make the buffer mutable if it needs to
It will update the nullBitMapBuffer
If something is holding on to the old buffer - it shouldn't be/it's outdated.

Fix helper

Remove duplicate

More clean up

Fix slice

Update name to GetOrCreateMutable

Use null instead of default for nullable values.

Clean up Apply methods.

…cleanup' into u/jakerad/column-container-cleanup

codecov · 2023-05-06T06:24:39Z

Codecov Report

Merging #6656 (e33608d) into main (3986fcf) will decrease coverage by 0.01%.
The diff coverage is 90.74%.

Additional details and impacted files

@@ Coverage Diff @@## main #6656 +/- ##
==========================================
- Coverage 68.59% 68.59% -0.01% 
==========================================
Files 1200 1201 +1 Lines 250326 250296 -30 Branches 26096 26094 -2 ==========================================
- Hits 171701 171679 -22 + Misses 71809 71803 -6 + Partials 6816 6814 -2

Flag	Coverage Δ
Debug	`68.59% <90.74%> (-0.01%)`	⬇️
production	`63.07% <90.74%> (-0.01%)`	⬇️
test	`88.84% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Microsoft.Data.Analysis/DataFrameBuffer.cs	`82.60% <ø> (ø)`
...lysis/PrimitiveColumnContainer.BinaryOperations.cs	`84.21% <ø> (ø)`
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs	`48.98% <ø> (ø)`
...a.Analysis/PrimitiveDataFrameColumnComputations.cs	`45.66% <ø> (ø)`
...Microsoft.Data.Analysis/ReadOnlyDataFrameBuffer.cs	`47.36% <ø> (ø)`
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs	`83.04% <88.63%> (+0.03%)`	⬆️
...t.Data.Analysis/PrimitiveColumnContainerHelpers.cs	`100.00% <100.00%> (ø)`

... and 6 files with indirect coverage changes

JakeRadMSFT · 2023-05-05T10:37:39Z

I was inspired by a community members PR (#6642) to try and clean up PrimitiveColumnContainer.

I'd say this is Part 1 of a few part series for improving DataFrame.

Updates the code to be more consistent with the Buffer and nullBufferBitMap usage
Updated all the PrimitiveColumn related things that used to be T : struct and move to T : unmanaged.
Hopefully improved readability

Not Fixed:

It's still not thread safe

Try to clean up PrimitiveColumnContainer

agocke · 2023-05-05T16:38:16Z

 }
 }

 public void ApplyElementwise(Func<T?, long, T?> func)


Out of curiosity, what is the contract for this method? It's going to swap out the buffer in the array with a new one -- what if someone's holding on to the old one? How do you handle reference invalidation?

I just inherited this but my understanding is the following:
This method is going to apply func for each element and update the value in buffer
It will make the buffer mutable if it needs to
It will update the nullBitMapBuffer
If something is holding on to the old buffer - it shouldn't be/it's outdated.

Fix helper

Remove duplicate

More clean up

Fix slice

Update name to GetOrCreateMutable

Use null instead of default for nullable values.

Clean up Apply methods.

…cleanup' into u/jakerad/column-container-cleanup

codecov · 2023-05-06T06:24:39Z

Codecov Report

Merging #6656 (e33608d) into main (3986fcf) will decrease coverage by 0.01%.
The diff coverage is 90.74%.

Additional details and impacted files

@@ Coverage Diff @@## main #6656 +/- ##
==========================================
- Coverage 68.59% 68.59% -0.01% 
==========================================
Files 1200 1201 +1 Lines 250326 250296 -30 Branches 26096 26094 -2 ==========================================
- Hits 171701 171679 -22 + Misses 71809 71803 -6 + Partials 6816 6814 -2

Flag	Coverage Δ
Debug	`68.59% <90.74%> (-0.01%)`	⬇️
production	`63.07% <90.74%> (-0.01%)`	⬇️
test	`88.84% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Microsoft.Data.Analysis/DataFrameBuffer.cs	`82.60% <ø> (ø)`
...lysis/PrimitiveColumnContainer.BinaryOperations.cs	`84.21% <ø> (ø)`
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs	`48.98% <ø> (ø)`
...a.Analysis/PrimitiveDataFrameColumnComputations.cs	`45.66% <ø> (ø)`
...Microsoft.Data.Analysis/ReadOnlyDataFrameBuffer.cs	`47.36% <ø> (ø)`
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs	`83.04% <88.63%> (+0.03%)`	⬆️
...t.Data.Analysis/PrimitiveColumnContainerHelpers.cs	`100.00% <100.00%> (ø)`

... and 6 files with indirect coverage changes

JakeRadMSFT · 2023-05-05T10:37:39Z

I was inspired by a community members PR (#6642) to try and clean up PrimitiveColumnContainer.

I'd say this is Part 1 of a few part series for improving DataFrame.

Updates the code to be more consistent with the Buffer and nullBufferBitMap usage
Updated all the PrimitiveColumn related things that used to be T : struct and move to T : unmanaged.
Hopefully improved readability

Not Fixed:

It's still not thread safe

Try to clean up PrimitiveColumnContainer

agocke · 2023-05-05T16:38:16Z

 }
 }

 public void ApplyElementwise(Func<T?, long, T?> func)


Out of curiosity, what is the contract for this method? It's going to swap out the buffer in the array with a new one -- what if someone's holding on to the old one? How do you handle reference invalidation?

I just inherited this but my understanding is the following:
This method is going to apply func for each element and update the value in buffer
It will make the buffer mutable if it needs to
It will update the nullBitMapBuffer
If something is holding on to the old buffer - it shouldn't be/it's outdated.

Fix helper

Remove duplicate

More clean up

Fix slice

Update name to GetOrCreateMutable

Use null instead of default for nullable values.

Clean up Apply methods.

…cleanup' into u/jakerad/column-container-cleanup

codecov · 2023-05-06T06:24:39Z

Codecov Report

Merging #6656 (e33608d) into main (3986fcf) will decrease coverage by 0.01%.
The diff coverage is 90.74%.

Additional details and impacted files

@@ Coverage Diff @@## main #6656 +/- ##
==========================================
- Coverage 68.59% 68.59% -0.01% 
==========================================
Files 1200 1201 +1 Lines 250326 250296 -30 Branches 26096 26094 -2 ==========================================
- Hits 171701 171679 -22 + Misses 71809 71803 -6 + Partials 6816 6814 -2

Flag	Coverage Δ
Debug	`68.59% <90.74%> (-0.01%)`	⬇️
production	`63.07% <90.74%> (-0.01%)`	⬇️
test	`88.84% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Microsoft.Data.Analysis/DataFrameBuffer.cs	`82.60% <ø> (ø)`
...lysis/PrimitiveColumnContainer.BinaryOperations.cs	`84.21% <ø> (ø)`
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs	`48.98% <ø> (ø)`
...a.Analysis/PrimitiveDataFrameColumnComputations.cs	`45.66% <ø> (ø)`
...Microsoft.Data.Analysis/ReadOnlyDataFrameBuffer.cs	`47.36% <ø> (ø)`
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs	`83.04% <88.63%> (+0.03%)`	⬆️
...t.Data.Analysis/PrimitiveColumnContainerHelpers.cs	`100.00% <100.00%> (ø)`

... and 6 files with indirect coverage changes

JakeRadMSFT · 2023-05-05T10:37:39Z

I was inspired by a community members PR (#6642) to try and clean up PrimitiveColumnContainer.

I'd say this is Part 1 of a few part series for improving DataFrame.

Updates the code to be more consistent with the Buffer and nullBufferBitMap usage
Updated all the PrimitiveColumn related things that used to be T : struct and move to T : unmanaged.
Hopefully improved readability

Not Fixed:

It's still not thread safe

Try to clean up PrimitiveColumnContainer

agocke · 2023-05-05T16:38:16Z

 }
 }

 public void ApplyElementwise(Func<T?, long, T?> func)


Out of curiosity, what is the contract for this method? It's going to swap out the buffer in the array with a new one -- what if someone's holding on to the old one? How do you handle reference invalidation?

I just inherited this but my understanding is the following:
This method is going to apply func for each element and update the value in buffer
It will make the buffer mutable if it needs to
It will update the nullBitMapBuffer
If something is holding on to the old buffer - it shouldn't be/it's outdated.

Fix helper

Remove duplicate

More clean up

Fix slice

Update name to GetOrCreateMutable

Use null instead of default for nullable values.

Clean up Apply methods.

…cleanup' into u/jakerad/column-container-cleanup

codecov · 2023-05-06T06:24:39Z

Codecov Report

Merging #6656 (e33608d) into main (3986fcf) will decrease coverage by 0.01%.
The diff coverage is 90.74%.

Additional details and impacted files

@@ Coverage Diff @@## main #6656 +/- ##
==========================================
- Coverage 68.59% 68.59% -0.01% 
==========================================
Files 1200 1201 +1 Lines 250326 250296 -30 Branches 26096 26094 -2 ==========================================
- Hits 171701 171679 -22 + Misses 71809 71803 -6 + Partials 6816 6814 -2

Flag	Coverage Δ
Debug	`68.59% <90.74%> (-0.01%)`	⬇️
production	`63.07% <90.74%> (-0.01%)`	⬇️
test	`88.84% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Microsoft.Data.Analysis/DataFrameBuffer.cs	`82.60% <ø> (ø)`
...lysis/PrimitiveColumnContainer.BinaryOperations.cs	`84.21% <ø> (ø)`
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs	`48.98% <ø> (ø)`
...a.Analysis/PrimitiveDataFrameColumnComputations.cs	`45.66% <ø> (ø)`
...Microsoft.Data.Analysis/ReadOnlyDataFrameBuffer.cs	`47.36% <ø> (ø)`
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs	`83.04% <88.63%> (+0.03%)`	⬆️
...t.Data.Analysis/PrimitiveColumnContainerHelpers.cs	`100.00% <100.00%> (ø)`

... and 6 files with indirect coverage changes

JakeRadMSFT · 2023-05-05T10:37:39Z

I was inspired by a community members PR (#6642) to try and clean up PrimitiveColumnContainer.

I'd say this is Part 1 of a few part series for improving DataFrame.

Updates the code to be more consistent with the Buffer and nullBufferBitMap usage
Updated all the PrimitiveColumn related things that used to be T : struct and move to T : unmanaged.
Hopefully improved readability

Not Fixed:

It's still not thread safe

Try to clean up PrimitiveColumnContainer

agocke · 2023-05-05T16:38:16Z

 }
 }

 public void ApplyElementwise(Func<T?, long, T?> func)


Out of curiosity, what is the contract for this method? It's going to swap out the buffer in the array with a new one -- what if someone's holding on to the old one? How do you handle reference invalidation?

I just inherited this but my understanding is the following:
This method is going to apply func for each element and update the value in buffer
It will make the buffer mutable if it needs to
It will update the nullBitMapBuffer
If something is holding on to the old buffer - it shouldn't be/it's outdated.

Fix helper

Remove duplicate

More clean up

Fix slice

Update name to GetOrCreateMutable

Use null instead of default for nullable values.

Clean up Apply methods.

…cleanup' into u/jakerad/column-container-cleanup

codecov · 2023-05-06T06:24:39Z

Codecov Report

Merging #6656 (e33608d) into main (3986fcf) will decrease coverage by 0.01%.
The diff coverage is 90.74%.

Additional details and impacted files

@@ Coverage Diff @@## main #6656 +/- ##
==========================================
- Coverage 68.59% 68.59% -0.01% 
==========================================
Files 1200 1201 +1 Lines 250326 250296 -30 Branches 26096 26094 -2 ==========================================
- Hits 171701 171679 -22 + Misses 71809 71803 -6 + Partials 6816 6814 -2

Flag	Coverage Δ
Debug	`68.59% <90.74%> (-0.01%)`	⬇️
production	`63.07% <90.74%> (-0.01%)`	⬇️
test	`88.84% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Microsoft.Data.Analysis/DataFrameBuffer.cs	`82.60% <ø> (ø)`
...lysis/PrimitiveColumnContainer.BinaryOperations.cs	`84.21% <ø> (ø)`
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs	`48.98% <ø> (ø)`
...a.Analysis/PrimitiveDataFrameColumnComputations.cs	`45.66% <ø> (ø)`
...Microsoft.Data.Analysis/ReadOnlyDataFrameBuffer.cs	`47.36% <ø> (ø)`
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs	`83.04% <88.63%> (+0.03%)`	⬆️
...t.Data.Analysis/PrimitiveColumnContainerHelpers.cs	`100.00% <100.00%> (ø)`

... and 6 files with indirect coverage changes

JakeRadMSFT · 2023-05-05T10:37:39Z

I was inspired by a community members PR (#6642) to try and clean up PrimitiveColumnContainer.

I'd say this is Part 1 of a few part series for improving DataFrame.

Updates the code to be more consistent with the Buffer and nullBufferBitMap usage
Updated all the PrimitiveColumn related things that used to be T : struct and move to T : unmanaged.
Hopefully improved readability

Not Fixed:

It's still not thread safe

Try to clean up PrimitiveColumnContainer

agocke · 2023-05-05T16:38:16Z

 }
 }

 public void ApplyElementwise(Func<T?, long, T?> func)


Out of curiosity, what is the contract for this method? It's going to swap out the buffer in the array with a new one -- what if someone's holding on to the old one? How do you handle reference invalidation?

I just inherited this but my understanding is the following:
This method is going to apply func for each element and update the value in buffer
It will make the buffer mutable if it needs to
It will update the nullBitMapBuffer
If something is holding on to the old buffer - it shouldn't be/it's outdated.

Fix helper

Remove duplicate

More clean up

Fix slice

Update name to GetOrCreateMutable

Use null instead of default for nullable values.

Clean up Apply methods.

…cleanup' into u/jakerad/column-container-cleanup

codecov · 2023-05-06T06:24:39Z

Codecov Report

Merging #6656 (e33608d) into main (3986fcf) will decrease coverage by 0.01%.
The diff coverage is 90.74%.

Additional details and impacted files

@@ Coverage Diff @@## main #6656 +/- ##
==========================================
- Coverage 68.59% 68.59% -0.01% 
==========================================
Files 1200 1201 +1 Lines 250326 250296 -30 Branches 26096 26094 -2 ==========================================
- Hits 171701 171679 -22 + Misses 71809 71803 -6 + Partials 6816 6814 -2

Flag	Coverage Δ
Debug	`68.59% <90.74%> (-0.01%)`	⬇️
production	`63.07% <90.74%> (-0.01%)`	⬇️
test	`88.84% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Microsoft.Data.Analysis/DataFrameBuffer.cs	`82.60% <ø> (ø)`
...lysis/PrimitiveColumnContainer.BinaryOperations.cs	`84.21% <ø> (ø)`
...ata.Analysis/PrimitiveDataFrameColumnArithmetic.cs	`48.98% <ø> (ø)`
...a.Analysis/PrimitiveDataFrameColumnComputations.cs	`45.66% <ø> (ø)`
...Microsoft.Data.Analysis/ReadOnlyDataFrameBuffer.cs	`47.36% <ø> (ø)`
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs	`83.04% <88.63%> (+0.03%)`	⬆️
...t.Data.Analysis/PrimitiveColumnContainerHelpers.cs	`100.00% <100.00%> (ø)`

... and 6 files with indirect coverage changes

871bed6
Try to clean up PrimitiveColumnContainer

ghost assigned JakeRadMSFT May 5, 2023

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs Outdated

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs

agocke reviewed May 5, 2023
View reviewed changes

jaredpar reviewed May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated

JakeRadMSFTand others added 9 commits May 5, 2023 19:59

ec3fb29
Fix helper

1d7a2b3
Remove duplicate

1fac8ab
More clean up

1c91301
Fix slice

7a6d911
Update name to GetOrCreateMutable

0b8575d
Use null instead of default for nullable values.

Merge branch 'main' into u/jakerad/column-container-cleanup
5614df6

54bba84
Clean up Apply methods.

Merge remote-tracking branch 'JakeRadMSFT/u/jakerad/column-container-…
e33608d
…cleanup' into u/jakerad/column-container-cleanup

JakeRadMSFT changed the title ~~(WIP) Try to clean up PrimitiveColumnContainer~~Clean up PrimitiveColumnContainerMay 6, 2023

michaelgsharp approved these changes May 8, 2023
View reviewed changes

michaelgsharp merged commit 247f3a0 into dotnet:mainMay 8, 2023

ghost locked as resolved and limited conversation to collaborators Jun 8, 2023

871bed6
Try to clean up PrimitiveColumnContainer

ghost assigned JakeRadMSFT May 5, 2023

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs Outdated

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs

agocke reviewed May 5, 2023
View reviewed changes

jaredpar reviewed May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated

JakeRadMSFTand others added 9 commits May 5, 2023 19:59

ec3fb29
Fix helper

1d7a2b3
Remove duplicate

1fac8ab
More clean up

1c91301
Fix slice

7a6d911
Update name to GetOrCreateMutable

0b8575d
Use null instead of default for nullable values.

Merge branch 'main' into u/jakerad/column-container-cleanup
5614df6

54bba84
Clean up Apply methods.

Merge remote-tracking branch 'JakeRadMSFT/u/jakerad/column-container-…
e33608d
…cleanup' into u/jakerad/column-container-cleanup

JakeRadMSFT changed the title ~~(WIP) Try to clean up PrimitiveColumnContainer~~Clean up PrimitiveColumnContainerMay 6, 2023

michaelgsharp approved these changes May 8, 2023
View reviewed changes

michaelgsharp merged commit 247f3a0 into dotnet:mainMay 8, 2023

ghost locked as resolved and limited conversation to collaborators Jun 8, 2023

871bed6
Try to clean up PrimitiveColumnContainer

ghost assigned JakeRadMSFT May 5, 2023

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs Outdated

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs

agocke reviewed May 5, 2023
View reviewed changes

jaredpar reviewed May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated

JakeRadMSFTand others added 9 commits May 5, 2023 19:59

ec3fb29
Fix helper

1d7a2b3
Remove duplicate

1fac8ab
More clean up

1c91301
Fix slice

7a6d911
Update name to GetOrCreateMutable

0b8575d
Use null instead of default for nullable values.

Merge branch 'main' into u/jakerad/column-container-cleanup
5614df6

54bba84
Clean up Apply methods.

Merge remote-tracking branch 'JakeRadMSFT/u/jakerad/column-container-…
e33608d
…cleanup' into u/jakerad/column-container-cleanup

JakeRadMSFT changed the title ~~(WIP) Try to clean up PrimitiveColumnContainer~~Clean up PrimitiveColumnContainerMay 6, 2023

michaelgsharp approved these changes May 8, 2023
View reviewed changes

michaelgsharp merged commit 247f3a0 into dotnet:mainMay 8, 2023

ghost locked as resolved and limited conversation to collaborators Jun 8, 2023

871bed6
Try to clean up PrimitiveColumnContainer

ghost assigned JakeRadMSFT May 5, 2023

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs Outdated

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs

agocke reviewed May 5, 2023
View reviewed changes

jaredpar reviewed May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated

JakeRadMSFTand others added 9 commits May 5, 2023 19:59

ec3fb29
Fix helper

1d7a2b3
Remove duplicate

1fac8ab
More clean up

1c91301
Fix slice

7a6d911
Update name to GetOrCreateMutable

0b8575d
Use null instead of default for nullable values.

Merge branch 'main' into u/jakerad/column-container-cleanup
5614df6

54bba84
Clean up Apply methods.

Merge remote-tracking branch 'JakeRadMSFT/u/jakerad/column-container-…
e33608d
…cleanup' into u/jakerad/column-container-cleanup

JakeRadMSFT changed the title ~~(WIP) Try to clean up PrimitiveColumnContainer~~Clean up PrimitiveColumnContainerMay 6, 2023

michaelgsharp approved these changes May 8, 2023
View reviewed changes

michaelgsharp merged commit 247f3a0 into dotnet:mainMay 8, 2023

ghost locked as resolved and limited conversation to collaborators Jun 8, 2023

871bed6
Try to clean up PrimitiveColumnContainer

ghost assigned JakeRadMSFT May 5, 2023

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs Outdated

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs

agocke reviewed May 5, 2023
View reviewed changes

jaredpar reviewed May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated

JakeRadMSFTand others added 9 commits May 5, 2023 19:59

ec3fb29
Fix helper

1d7a2b3
Remove duplicate

1fac8ab
More clean up

1c91301
Fix slice

7a6d911
Update name to GetOrCreateMutable

0b8575d
Use null instead of default for nullable values.

Merge branch 'main' into u/jakerad/column-container-cleanup
5614df6

54bba84
Clean up Apply methods.

Merge remote-tracking branch 'JakeRadMSFT/u/jakerad/column-container-…
e33608d
…cleanup' into u/jakerad/column-container-cleanup

JakeRadMSFT changed the title ~~(WIP) Try to clean up PrimitiveColumnContainer~~Clean up PrimitiveColumnContainerMay 6, 2023

michaelgsharp approved these changes May 8, 2023
View reviewed changes

michaelgsharp merged commit 247f3a0 into dotnet:mainMay 8, 2023

ghost locked as resolved and limited conversation to collaborators Jun 8, 2023

871bed6
Try to clean up PrimitiveColumnContainer

ghost assigned JakeRadMSFT May 5, 2023

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs Outdated

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs

agocke reviewed May 5, 2023
View reviewed changes

jaredpar reviewed May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated

JakeRadMSFTand others added 9 commits May 5, 2023 19:59

ec3fb29
Fix helper

1d7a2b3
Remove duplicate

1fac8ab
More clean up

1c91301
Fix slice

7a6d911
Update name to GetOrCreateMutable

0b8575d
Use null instead of default for nullable values.

Merge branch 'main' into u/jakerad/column-container-cleanup
5614df6

54bba84
Clean up Apply methods.

Merge remote-tracking branch 'JakeRadMSFT/u/jakerad/column-container-…
e33608d
…cleanup' into u/jakerad/column-container-cleanup

JakeRadMSFT changed the title ~~(WIP) Try to clean up PrimitiveColumnContainer~~Clean up PrimitiveColumnContainerMay 6, 2023

michaelgsharp approved these changes May 8, 2023
View reviewed changes

michaelgsharp merged commit 247f3a0 into dotnet:mainMay 8, 2023

ghost locked as resolved and limited conversation to collaborators Jun 8, 2023

871bed6
Try to clean up PrimitiveColumnContainer

ghost assigned JakeRadMSFT May 5, 2023

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs Outdated

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs

agocke reviewed May 5, 2023
View reviewed changes

jaredpar reviewed May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated

JakeRadMSFTand others added 9 commits May 5, 2023 19:59

ec3fb29
Fix helper

1d7a2b3
Remove duplicate

1fac8ab
More clean up

1c91301
Fix slice

7a6d911
Update name to GetOrCreateMutable

0b8575d
Use null instead of default for nullable values.

Merge branch 'main' into u/jakerad/column-container-cleanup
5614df6

54bba84
Clean up Apply methods.

Merge remote-tracking branch 'JakeRadMSFT/u/jakerad/column-container-…
e33608d
…cleanup' into u/jakerad/column-container-cleanup

JakeRadMSFT changed the title ~~(WIP) Try to clean up PrimitiveColumnContainer~~Clean up PrimitiveColumnContainerMay 6, 2023

michaelgsharp approved these changes May 8, 2023
View reviewed changes

michaelgsharp merged commit 247f3a0 into dotnet:mainMay 8, 2023

ghost locked as resolved and limited conversation to collaborators Jun 8, 2023

871bed6
Try to clean up PrimitiveColumnContainer

ghost assigned JakeRadMSFT May 5, 2023

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs Outdated

JakeRadMSFT commented May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs

agocke reviewed May 5, 2023
View reviewed changes

jaredpar reviewed May 5, 2023
View reviewed changes

Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated
Comment threadsrc/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs Outdated

JakeRadMSFTand others added 9 commits May 5, 2023 19:59

ec3fb29
Fix helper

1d7a2b3
Remove duplicate

1fac8ab
More clean up

1c91301
Fix slice

7a6d911
Update name to GetOrCreateMutable

0b8575d
Use null instead of default for nullable values.

Merge branch 'main' into u/jakerad/column-container-cleanup
5614df6

54bba84
Clean up Apply methods.

Merge remote-tracking branch 'JakeRadMSFT/u/jakerad/column-container-…
e33608d
…cleanup' into u/jakerad/column-container-cleanup

JakeRadMSFT changed the title ~~(WIP) Try to clean up PrimitiveColumnContainer~~Clean up PrimitiveColumnContainerMay 6, 2023

michaelgsharp approved these changes May 8, 2023
View reviewed changes

michaelgsharp merged commit 247f3a0 into dotnet:mainMay 8, 2023

ghost locked as resolved and limited conversation to collaborators Jun 8, 2023

Uh oh!

Conversation

JakeRadMSFT commented May 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented May 6, 2023

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

JakeRadMSFT commented May 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented May 6, 2023

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

JakeRadMSFT commented May 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented May 6, 2023

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

JakeRadMSFT commented May 5, 2023•
edited
Loading

JakeRadMSFT commented May 5, 2023•
edited
Loading

JakeRadMSFT commented May 5, 2023•
edited
Loading

JakeRadMSFT commented May 5, 2023•
edited
Loading

JakeRadMSFT commented May 5, 2023•
edited
Loading