[main] Update dependencies from dotnet/arcade - #6703

Merged
ericstj merged 52 commits into
mainfrom
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Jan 2, 2024
Merged

[main] Update dependencies from dotnet/arcade#6703
ericstj merged 52 commits into
mainfrom
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented May 22, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 97926d79-6b8b-4d32-c8db-08d9d479971c
  • Build: 20231228.1
  • Date Produced: December 28, 2023 10:38:38 AM UTC
  • Commit: 9e5fd26c0d1a187dfa08242d83e341634d4b1b07
  • Branch: refs/heads/main

dotnet-maestroBotand others added 2 commits May 22, 2023 12:36
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
63bfbea
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23269.2
@ericstj
Add dotnet8 nuget feed
f2e4581
@codecov

codecovBot commented May 25, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (d3c3127) 68.80% compared to head (501826e) 68.80%.

Additional details and impacted files
@@ Coverage Diff @@## main #6703 +/- ##
=======================================
Coverage 68.80% 68.80% =======================================
Files 1249 1249 Lines 249433 249436 +3 Branches 25509 25468 -41 =======================================
+ Hits 171615 171633 +18 - Misses 71209 71212 +3 + Partials 6609 6591 -18
FlagCoverage Δ
Debug68.80% <47.82%> (+<0.01%)⬆️
production63.26% <ø> (+<0.01%)⬆️
test88.49% <47.82%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

FilesCoverage Δ
...osoft.Data.Analysis.Tests/ArrowIntegrationTests.cs100.00% <100.00%> (ø)
...ata.Analysis.Tests/DataFrameJoinExtensionsTests.cs100.00% <100.00%> (ø)
.../Microsoft.ML.AutoML.Tests/ColumnInferenceTests.cs96.29% <100.00%> (ø)
...t.ML.AutoML.Tests/SuggestedPipelineBuilderTests.cs100.00% <100.00%> (ø)
test/Microsoft.ML.FSharp.Tests/SmokeTests.fs87.23% <ø> (ø)
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs0.00% <ø> (ø)
...stFramework/Attributes/BenchmarkTheoryAttribute.cs100.00% <ø> (ø)
test/Microsoft.ML.TestFramework/GlobalBase.cs33.33% <100.00%> (ø)
test/Microsoft.ML.TestFramework/TestCommandBase.cs39.45% <100.00%> (+0.04%)⬆️
...icrosoft.ML.TestFramework/DataPipe/TestDataPipe.cs91.06% <0.00%> (ø)
... and 5 more

... and 15 files with indirect coverage changes

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
04d8d36
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23279.1
@michaelgsharp

michaelgsharp commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jun 1, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80b44d6
…602.3
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23302.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7d571b5
…609.8
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23309.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
a6d9897
…616.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23316.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
827bea1
…622.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23322.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7f9de8a
…630.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23330.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
47cd477
…710.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23360.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7099384
…714.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23364.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
e51c1ba
…721.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23371.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
5449f24
…728.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23378.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
905fad9
…804.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23404.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7379ca5
…811.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23411.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
9c9fa1f
…819.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23419.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b83340a
…825.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23425.2
@michaelgsharp

michaelgsharp commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Sep 1, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8443dd7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b9cc1d7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
6b79938
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80a9a3a
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
eaa7961
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
a60ce8b
…008.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23508.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
6e6e344
…010.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23510.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
3430802
…018.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23518.2
ericstj
ericstj reviewed Dec 19, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml Outdated
@build-analysisbuild-analysisBot mentioned this pull request Dec 21, 2023
Closed
@ericstj

ericstj commented Dec 21, 2023

Copy link
Copy Markdown
Member

Getting close! The ARM64 failures are both #6921.

@michaelgsharp - looks like the OSX failure in TestSaveAndLoadDoubleTreeFeaturizer is different

Assert.Equal() Failure: Values are not within 5 decimal places
Expected: 0.19011 (rounded from 0.1901149994134903)
Actual: 0.19012000000000001 (rounded from 0.19011500015854835)

It's funny, the actual difference between these two numbers is 0.00000000074505805, or 7.45 x 10^-10, but that's enough to make it round differently at 5 decimal places 😆 I wonder if we should use a different assert?

@ericstj

ericstj commented Dec 21, 2023

Copy link
Copy Markdown
Member

Turns out there's actually an assert that does that; https://github.com/xunit/assert.xunit/blob/6d9024665f1b67714311b38b72054fbad9d9972c/EqualityAsserts.cs#L342

Might be good to adopt this in our double comparisons since it would be less sensitive to differences when expected value is close to a rounding threshold.

@ericstjericstj mentioned this pull request Dec 21, 2023
Merged
@ericstj

ericstj commented Dec 22, 2023

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelinesBot commented Dec 22, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

ericstj
ericstj reviewed Dec 22, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
ericstj
ericstj reviewed Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.Tests/Data/github-issues-train.tsv
ericstj
ericstj reviewed Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.TestFramework/Attributes/BenchmarkTheoryAttribute.cs Outdated
ericstjand others added 7 commits December 22, 2023 14:18
@ericstj
Undo changes to test data
4a404f3
@ericstj
Make NETFRAMEWORK ifdef versionless
75b3706
@ericstj
Merge remote-tracking branch 'upstream/main' into darc-main-4fc19a23-…
c47e345
…a34d-4ff1-bd23-11be82f3618c
@ericstj
Switch back to centos7 for testing
ab0d41e
@ericstj
Revert "Switch back to centos7 for testing"
56511ac
This reverts commit ab0d41e.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
27b544f
…221.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23621.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
501826e
…228.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23628.1
@ericstj

ericstj commented Jan 2, 2024

Copy link
Copy Markdown
Member

Wow, green build. Should we merge it @michaelgsharp?

michaelgsharp
michaelgsharp approved these changes Jan 2, 2024
View reviewed changes

@michaelgsharpmichaelgsharp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericstj
ericstj merged commit f625080 into mainJan 2, 2024
@dotnet-maestro
dotnet-maestroBot deleted the darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c branch January 2, 2024 23:50
@ericstj

ericstj commented Jan 3, 2024

Copy link
Copy Markdown
Member

So this introduced a build break where the NoWarn for NETSDK1206 doesn't always apply. #6935 is fixing that.

@ericstjericstj mentioned this pull request Jan 4, 2024
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstjericstjericstj left review comments
+1 more reviewer
@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelgsharp@ericstj
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #6703
Merged
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Jan 2, 2024
Merged
[main] Update dependencies from dotnet/arcade#6703
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 22, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: 97926d79-6b8b-4d32-c8db-08d9d479971c
  • Build: 20231228.1
  • Date Produced: December 28, 2023 10:38:38 AM UTC
  • Commit: 9e5fd26c0d1a187dfa08242d83e341634d4b1b07
  • Branch: refs/heads/main
dotnet-maestroBotand others
added 2 commits
May 22, 2023 12:36
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
63bfbea
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23269.2
@ericstj
Add dotnet8 nuget feed
f2e4581
@codecov
codecovBot
commented
May 25, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: 24 lines in your changes are missing coverage. Please review.
Comparison is base (d3c3127) 68.80% compared to head (501826e) 68.80%.
Additional details and impacted files
@@ Coverage Diff @@## main #6703 +/- ##
=======================================
Coverage 68.80% 68.80% =======================================
Files 1249 1249 Lines 249433 249436 +3 Branches 25509 25468 -41 =======================================
+ Hits 171615 171633 +18 - Misses 71209 71212 +3 + Partials 6609 6591 -18 
FlagCoverage Δ
Debug68.80% <47.82%> (+<0.01%)⬆️
production63.26% <ø> (+<0.01%)⬆️
test88.49% <47.82%> (+<0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...osoft.Data.Analysis.Tests/ArrowIntegrationTests.cs100.00% <100.00%> (ø)
...ata.Analysis.Tests/DataFrameJoinExtensionsTests.cs100.00% <100.00%> (ø)
.../Microsoft.ML.AutoML.Tests/ColumnInferenceTests.cs96.29% <100.00%> (ø)
...t.ML.AutoML.Tests/SuggestedPipelineBuilderTests.cs100.00% <100.00%> (ø)
test/Microsoft.ML.FSharp.Tests/SmokeTests.fs87.23% <ø> (ø)
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs0.00% <ø> (ø)
...stFramework/Attributes/BenchmarkTheoryAttribute.cs100.00% <ø> (ø)
test/Microsoft.ML.TestFramework/GlobalBase.cs33.33% <100.00%> (ø)
test/Microsoft.ML.TestFramework/TestCommandBase.cs39.45% <100.00%> (+0.04%)⬆️
...icrosoft.ML.TestFramework/DataPipe/TestDataPipe.cs91.06% <0.00%> (ø)
... and 5 more
... and 15 files with indirect coverage changes
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
04d8d36
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23279.1
@michaelgsharp
michaelgsharp
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jun 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80b44d6
…602.3
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23302.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7d571b5
…609.8
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23309.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
a6d9897
…616.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23316.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
827bea1
…622.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23322.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7f9de8a
…630.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23330.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
47cd477
…710.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23360.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7099384
…714.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23364.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
e51c1ba
…721.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23371.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
5449f24
…728.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23378.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
905fad9
…804.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23404.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7379ca5
…811.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23411.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
9c9fa1f
…819.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23419.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b83340a
…825.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23425.2
@michaelgsharp
michaelgsharp
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Sep 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8443dd7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b9cc1d7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
6b79938
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80a9a3a
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
eaa7961
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
a60ce8b
…008.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23508.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
6e6e344
…010.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23510.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
3430802
…018.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23518.2
ericstj
ericstj
reviewed
Dec 19, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Dec 21, 2023

Closed

@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Getting close! The ARM64 failures are both #6921.
@michaelgsharp - looks like the OSX failure in TestSaveAndLoadDoubleTreeFeaturizer is different
Assert.Equal() Failure: Values are not within 5 decimal places
Expected: 0.19011 (rounded from 0.1901149994134903)
Actual: 0.19012000000000001 (rounded from 0.19011500015854835)

It's funny, the actual difference between these two numbers is 0.00000000074505805, or 7.45 x 10^-10, but that's enough to make it round differently at 5 decimal places 😆 I wonder if we should use a different assert?
@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Turns out there's actually an assert that does that; https://github.com/xunit/assert.xunit/blob/6d9024665f1b67714311b38b72054fbad9d9972c/EqualityAsserts.cs#L342
Might be good to adopt this in our double comparisons since it would be less sensitive to differences when expected value is close to a rounding threshold.
@ericstjericstj
mentioned this pull request
Dec 21, 2023
 Merged

@ericstj
ericstj
commented
Dec 22, 2023

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Dec 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.Tests/Data/github-issues-train.tsv
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.TestFramework/Attributes/BenchmarkTheoryAttribute.cs
Outdated

ericstjand others
added 7 commits
December 22, 2023 14:18
@ericstj
Undo changes to test data
4a404f3
@ericstj
Make NETFRAMEWORK ifdef versionless
75b3706
@ericstj
Merge remote-tracking branch 'upstream/main' into darc-main-4fc19a23-…
c47e345
…a34d-4ff1-bd23-11be82f3618c
@ericstj
Switch back to centos7 for testing
ab0d41e
@ericstj
Revert "Switch back to centos7 for testing"
56511ac
This reverts commit ab0d41e.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
27b544f
…221.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23621.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
501826e
…228.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23628.1
@ericstj
ericstj
commented
Jan 2, 2024

Copy link


Copy Markdown

Member
Wow, green build. Should we merge it @michaelgsharp?
michaelgsharp
michaelgsharp
approved these changes
Jan 2, 2024
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ericstj
ericstj
merged commit f625080
into
mainJan 2, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c

branch
January 2, 2024 23:50
@ericstj
ericstj
commented
Jan 3, 2024

Copy link


Copy Markdown

Member
So this introduced a build break where the NoWarn for NETSDK1206 doesn't always apply. #6935 is fixing that.
@ericstjericstj
mentioned this pull request
Jan 4, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelgsharp@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #6703
Merged
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Jan 2, 2024
Merged
[main] Update dependencies from dotnet/arcade#6703
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 22, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: 97926d79-6b8b-4d32-c8db-08d9d479971c
  • Build: 20231228.1
  • Date Produced: December 28, 2023 10:38:38 AM UTC
  • Commit: 9e5fd26c0d1a187dfa08242d83e341634d4b1b07
  • Branch: refs/heads/main
dotnet-maestroBotand others
added 2 commits
May 22, 2023 12:36
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
63bfbea
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23269.2
@ericstj
Add dotnet8 nuget feed
f2e4581
@codecov
codecovBot
commented
May 25, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: 24 lines in your changes are missing coverage. Please review.
Comparison is base (d3c3127) 68.80% compared to head (501826e) 68.80%.
Additional details and impacted files
@@ Coverage Diff @@## main #6703 +/- ##
=======================================
Coverage 68.80% 68.80% =======================================
Files 1249 1249 Lines 249433 249436 +3 Branches 25509 25468 -41 =======================================
+ Hits 171615 171633 +18 - Misses 71209 71212 +3 + Partials 6609 6591 -18 
FlagCoverage Δ
Debug68.80% <47.82%> (+<0.01%)⬆️
production63.26% <ø> (+<0.01%)⬆️
test88.49% <47.82%> (+<0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...osoft.Data.Analysis.Tests/ArrowIntegrationTests.cs100.00% <100.00%> (ø)
...ata.Analysis.Tests/DataFrameJoinExtensionsTests.cs100.00% <100.00%> (ø)
.../Microsoft.ML.AutoML.Tests/ColumnInferenceTests.cs96.29% <100.00%> (ø)
...t.ML.AutoML.Tests/SuggestedPipelineBuilderTests.cs100.00% <100.00%> (ø)
test/Microsoft.ML.FSharp.Tests/SmokeTests.fs87.23% <ø> (ø)
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs0.00% <ø> (ø)
...stFramework/Attributes/BenchmarkTheoryAttribute.cs100.00% <ø> (ø)
test/Microsoft.ML.TestFramework/GlobalBase.cs33.33% <100.00%> (ø)
test/Microsoft.ML.TestFramework/TestCommandBase.cs39.45% <100.00%> (+0.04%)⬆️
...icrosoft.ML.TestFramework/DataPipe/TestDataPipe.cs91.06% <0.00%> (ø)
... and 5 more
... and 15 files with indirect coverage changes
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
04d8d36
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23279.1
@michaelgsharp
michaelgsharp
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jun 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80b44d6
…602.3
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23302.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7d571b5
…609.8
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23309.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
a6d9897
…616.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23316.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
827bea1
…622.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23322.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7f9de8a
…630.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23330.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
47cd477
…710.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23360.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7099384
…714.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23364.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
e51c1ba
…721.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23371.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
5449f24
…728.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23378.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
905fad9
…804.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23404.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7379ca5
…811.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23411.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
9c9fa1f
…819.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23419.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b83340a
…825.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23425.2
@michaelgsharp
michaelgsharp
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Sep 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8443dd7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b9cc1d7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
6b79938
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80a9a3a
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
eaa7961
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
a60ce8b
…008.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23508.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
6e6e344
…010.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23510.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
3430802
…018.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23518.2
ericstj
ericstj
reviewed
Dec 19, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Dec 21, 2023

Closed

@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Getting close! The ARM64 failures are both #6921.
@michaelgsharp - looks like the OSX failure in TestSaveAndLoadDoubleTreeFeaturizer is different
Assert.Equal() Failure: Values are not within 5 decimal places
Expected: 0.19011 (rounded from 0.1901149994134903)
Actual: 0.19012000000000001 (rounded from 0.19011500015854835)

It's funny, the actual difference between these two numbers is 0.00000000074505805, or 7.45 x 10^-10, but that's enough to make it round differently at 5 decimal places 😆 I wonder if we should use a different assert?
@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Turns out there's actually an assert that does that; https://github.com/xunit/assert.xunit/blob/6d9024665f1b67714311b38b72054fbad9d9972c/EqualityAsserts.cs#L342
Might be good to adopt this in our double comparisons since it would be less sensitive to differences when expected value is close to a rounding threshold.
@ericstjericstj
mentioned this pull request
Dec 21, 2023
 Merged

@ericstj
ericstj
commented
Dec 22, 2023

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Dec 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.Tests/Data/github-issues-train.tsv
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.TestFramework/Attributes/BenchmarkTheoryAttribute.cs
Outdated

ericstjand others
added 7 commits
December 22, 2023 14:18
@ericstj
Undo changes to test data
4a404f3
@ericstj
Make NETFRAMEWORK ifdef versionless
75b3706
@ericstj
Merge remote-tracking branch 'upstream/main' into darc-main-4fc19a23-…
c47e345
…a34d-4ff1-bd23-11be82f3618c
@ericstj
Switch back to centos7 for testing
ab0d41e
@ericstj
Revert "Switch back to centos7 for testing"
56511ac
This reverts commit ab0d41e.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
27b544f
…221.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23621.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
501826e
…228.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23628.1
@ericstj
ericstj
commented
Jan 2, 2024

Copy link


Copy Markdown

Member
Wow, green build. Should we merge it @michaelgsharp?
michaelgsharp
michaelgsharp
approved these changes
Jan 2, 2024
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ericstj
ericstj
merged commit f625080
into
mainJan 2, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c

branch
January 2, 2024 23:50
@ericstj
ericstj
commented
Jan 3, 2024

Copy link


Copy Markdown

Member
So this introduced a build break where the NoWarn for NETSDK1206 doesn't always apply. #6935 is fixing that.
@ericstjericstj
mentioned this pull request
Jan 4, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelgsharp@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #6703
Merged
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Jan 2, 2024
Merged
[main] Update dependencies from dotnet/arcade#6703
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 22, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: 97926d79-6b8b-4d32-c8db-08d9d479971c
  • Build: 20231228.1
  • Date Produced: December 28, 2023 10:38:38 AM UTC
  • Commit: 9e5fd26c0d1a187dfa08242d83e341634d4b1b07
  • Branch: refs/heads/main
dotnet-maestroBotand others
added 2 commits
May 22, 2023 12:36
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
63bfbea
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23269.2
@ericstj
Add dotnet8 nuget feed
f2e4581
@codecov
codecovBot
commented
May 25, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: 24 lines in your changes are missing coverage. Please review.
Comparison is base (d3c3127) 68.80% compared to head (501826e) 68.80%.
Additional details and impacted files
@@ Coverage Diff @@## main #6703 +/- ##
=======================================
Coverage 68.80% 68.80% =======================================
Files 1249 1249 Lines 249433 249436 +3 Branches 25509 25468 -41 =======================================
+ Hits 171615 171633 +18 - Misses 71209 71212 +3 + Partials 6609 6591 -18 
FlagCoverage Δ
Debug68.80% <47.82%> (+<0.01%)⬆️
production63.26% <ø> (+<0.01%)⬆️
test88.49% <47.82%> (+<0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...osoft.Data.Analysis.Tests/ArrowIntegrationTests.cs100.00% <100.00%> (ø)
...ata.Analysis.Tests/DataFrameJoinExtensionsTests.cs100.00% <100.00%> (ø)
.../Microsoft.ML.AutoML.Tests/ColumnInferenceTests.cs96.29% <100.00%> (ø)
...t.ML.AutoML.Tests/SuggestedPipelineBuilderTests.cs100.00% <100.00%> (ø)
test/Microsoft.ML.FSharp.Tests/SmokeTests.fs87.23% <ø> (ø)
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs0.00% <ø> (ø)
...stFramework/Attributes/BenchmarkTheoryAttribute.cs100.00% <ø> (ø)
test/Microsoft.ML.TestFramework/GlobalBase.cs33.33% <100.00%> (ø)
test/Microsoft.ML.TestFramework/TestCommandBase.cs39.45% <100.00%> (+0.04%)⬆️
...icrosoft.ML.TestFramework/DataPipe/TestDataPipe.cs91.06% <0.00%> (ø)
... and 5 more
... and 15 files with indirect coverage changes
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
04d8d36
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23279.1
@michaelgsharp
michaelgsharp
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jun 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80b44d6
…602.3
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23302.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7d571b5
…609.8
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23309.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
a6d9897
…616.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23316.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
827bea1
…622.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23322.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7f9de8a
…630.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23330.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
47cd477
…710.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23360.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7099384
…714.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23364.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
e51c1ba
…721.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23371.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
5449f24
…728.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23378.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
905fad9
…804.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23404.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7379ca5
…811.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23411.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
9c9fa1f
…819.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23419.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b83340a
…825.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23425.2
@michaelgsharp
michaelgsharp
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Sep 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8443dd7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b9cc1d7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
6b79938
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80a9a3a
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
eaa7961
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
a60ce8b
…008.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23508.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
6e6e344
…010.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23510.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
3430802
…018.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23518.2
ericstj
ericstj
reviewed
Dec 19, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Dec 21, 2023

Closed

@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Getting close! The ARM64 failures are both #6921.
@michaelgsharp - looks like the OSX failure in TestSaveAndLoadDoubleTreeFeaturizer is different
Assert.Equal() Failure: Values are not within 5 decimal places
Expected: 0.19011 (rounded from 0.1901149994134903)
Actual: 0.19012000000000001 (rounded from 0.19011500015854835)

It's funny, the actual difference between these two numbers is 0.00000000074505805, or 7.45 x 10^-10, but that's enough to make it round differently at 5 decimal places 😆 I wonder if we should use a different assert?
@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Turns out there's actually an assert that does that; https://github.com/xunit/assert.xunit/blob/6d9024665f1b67714311b38b72054fbad9d9972c/EqualityAsserts.cs#L342
Might be good to adopt this in our double comparisons since it would be less sensitive to differences when expected value is close to a rounding threshold.
@ericstjericstj
mentioned this pull request
Dec 21, 2023
 Merged

@ericstj
ericstj
commented
Dec 22, 2023

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Dec 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.Tests/Data/github-issues-train.tsv
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.TestFramework/Attributes/BenchmarkTheoryAttribute.cs
Outdated

ericstjand others
added 7 commits
December 22, 2023 14:18
@ericstj
Undo changes to test data
4a404f3
@ericstj
Make NETFRAMEWORK ifdef versionless
75b3706
@ericstj
Merge remote-tracking branch 'upstream/main' into darc-main-4fc19a23-…
c47e345
…a34d-4ff1-bd23-11be82f3618c
@ericstj
Switch back to centos7 for testing
ab0d41e
@ericstj
Revert "Switch back to centos7 for testing"
56511ac
This reverts commit ab0d41e.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
27b544f
…221.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23621.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
501826e
…228.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23628.1
@ericstj
ericstj
commented
Jan 2, 2024

Copy link


Copy Markdown

Member
Wow, green build. Should we merge it @michaelgsharp?
michaelgsharp
michaelgsharp
approved these changes
Jan 2, 2024
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ericstj
ericstj
merged commit f625080
into
mainJan 2, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c

branch
January 2, 2024 23:50
@ericstj
ericstj
commented
Jan 3, 2024

Copy link


Copy Markdown

Member
So this introduced a build break where the NoWarn for NETSDK1206 doesn't always apply. #6935 is fixing that.
@ericstjericstj
mentioned this pull request
Jan 4, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelgsharp@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #6703
Merged
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Jan 2, 2024
Merged
[main] Update dependencies from dotnet/arcade#6703
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 22, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: 97926d79-6b8b-4d32-c8db-08d9d479971c
  • Build: 20231228.1
  • Date Produced: December 28, 2023 10:38:38 AM UTC
  • Commit: 9e5fd26c0d1a187dfa08242d83e341634d4b1b07
  • Branch: refs/heads/main
dotnet-maestroBotand others
added 2 commits
May 22, 2023 12:36
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
63bfbea
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23269.2
@ericstj
Add dotnet8 nuget feed
f2e4581
@codecov
codecovBot
commented
May 25, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: 24 lines in your changes are missing coverage. Please review.
Comparison is base (d3c3127) 68.80% compared to head (501826e) 68.80%.
Additional details and impacted files
@@ Coverage Diff @@## main #6703 +/- ##
=======================================
Coverage 68.80% 68.80% =======================================
Files 1249 1249 Lines 249433 249436 +3 Branches 25509 25468 -41 =======================================
+ Hits 171615 171633 +18 - Misses 71209 71212 +3 + Partials 6609 6591 -18 
FlagCoverage Δ
Debug68.80% <47.82%> (+<0.01%)⬆️
production63.26% <ø> (+<0.01%)⬆️
test88.49% <47.82%> (+<0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...osoft.Data.Analysis.Tests/ArrowIntegrationTests.cs100.00% <100.00%> (ø)
...ata.Analysis.Tests/DataFrameJoinExtensionsTests.cs100.00% <100.00%> (ø)
.../Microsoft.ML.AutoML.Tests/ColumnInferenceTests.cs96.29% <100.00%> (ø)
...t.ML.AutoML.Tests/SuggestedPipelineBuilderTests.cs100.00% <100.00%> (ø)
test/Microsoft.ML.FSharp.Tests/SmokeTests.fs87.23% <ø> (ø)
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs0.00% <ø> (ø)
...stFramework/Attributes/BenchmarkTheoryAttribute.cs100.00% <ø> (ø)
test/Microsoft.ML.TestFramework/GlobalBase.cs33.33% <100.00%> (ø)
test/Microsoft.ML.TestFramework/TestCommandBase.cs39.45% <100.00%> (+0.04%)⬆️
...icrosoft.ML.TestFramework/DataPipe/TestDataPipe.cs91.06% <0.00%> (ø)
... and 5 more
... and 15 files with indirect coverage changes
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
04d8d36
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23279.1
@michaelgsharp
michaelgsharp
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jun 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80b44d6
…602.3
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23302.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7d571b5
…609.8
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23309.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
a6d9897
…616.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23316.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
827bea1
…622.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23322.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7f9de8a
…630.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23330.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
47cd477
…710.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23360.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7099384
…714.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23364.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
e51c1ba
…721.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23371.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
5449f24
…728.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23378.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
905fad9
…804.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23404.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7379ca5
…811.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23411.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
9c9fa1f
…819.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23419.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b83340a
…825.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23425.2
@michaelgsharp
michaelgsharp
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Sep 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8443dd7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b9cc1d7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
6b79938
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80a9a3a
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
eaa7961
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
a60ce8b
…008.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23508.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
6e6e344
…010.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23510.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
3430802
…018.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23518.2
ericstj
ericstj
reviewed
Dec 19, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Dec 21, 2023

Closed

@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Getting close! The ARM64 failures are both #6921.
@michaelgsharp - looks like the OSX failure in TestSaveAndLoadDoubleTreeFeaturizer is different
Assert.Equal() Failure: Values are not within 5 decimal places
Expected: 0.19011 (rounded from 0.1901149994134903)
Actual: 0.19012000000000001 (rounded from 0.19011500015854835)

It's funny, the actual difference between these two numbers is 0.00000000074505805, or 7.45 x 10^-10, but that's enough to make it round differently at 5 decimal places 😆 I wonder if we should use a different assert?
@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Turns out there's actually an assert that does that; https://github.com/xunit/assert.xunit/blob/6d9024665f1b67714311b38b72054fbad9d9972c/EqualityAsserts.cs#L342
Might be good to adopt this in our double comparisons since it would be less sensitive to differences when expected value is close to a rounding threshold.
@ericstjericstj
mentioned this pull request
Dec 21, 2023
 Merged

@ericstj
ericstj
commented
Dec 22, 2023

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Dec 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.Tests/Data/github-issues-train.tsv
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.TestFramework/Attributes/BenchmarkTheoryAttribute.cs
Outdated

ericstjand others
added 7 commits
December 22, 2023 14:18
@ericstj
Undo changes to test data
4a404f3
@ericstj
Make NETFRAMEWORK ifdef versionless
75b3706
@ericstj
Merge remote-tracking branch 'upstream/main' into darc-main-4fc19a23-…
c47e345
…a34d-4ff1-bd23-11be82f3618c
@ericstj
Switch back to centos7 for testing
ab0d41e
@ericstj
Revert "Switch back to centos7 for testing"
56511ac
This reverts commit ab0d41e.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
27b544f
…221.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23621.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
501826e
…228.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23628.1
@ericstj
ericstj
commented
Jan 2, 2024

Copy link


Copy Markdown

Member
Wow, green build. Should we merge it @michaelgsharp?
michaelgsharp
michaelgsharp
approved these changes
Jan 2, 2024
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ericstj
ericstj
merged commit f625080
into
mainJan 2, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c

branch
January 2, 2024 23:50
@ericstj
ericstj
commented
Jan 3, 2024

Copy link


Copy Markdown

Member
So this introduced a build break where the NoWarn for NETSDK1206 doesn't always apply. #6935 is fixing that.
@ericstjericstj
mentioned this pull request
Jan 4, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelgsharp@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #6703
Merged
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Jan 2, 2024
Merged
[main] Update dependencies from dotnet/arcade#6703
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 22, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: 97926d79-6b8b-4d32-c8db-08d9d479971c
  • Build: 20231228.1
  • Date Produced: December 28, 2023 10:38:38 AM UTC
  • Commit: 9e5fd26c0d1a187dfa08242d83e341634d4b1b07
  • Branch: refs/heads/main
dotnet-maestroBotand others
added 2 commits
May 22, 2023 12:36
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
63bfbea
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23269.2
@ericstj
Add dotnet8 nuget feed
f2e4581
@codecov
codecovBot
commented
May 25, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: 24 lines in your changes are missing coverage. Please review.
Comparison is base (d3c3127) 68.80% compared to head (501826e) 68.80%.
Additional details and impacted files
@@ Coverage Diff @@## main #6703 +/- ##
=======================================
Coverage 68.80% 68.80% =======================================
Files 1249 1249 Lines 249433 249436 +3 Branches 25509 25468 -41 =======================================
+ Hits 171615 171633 +18 - Misses 71209 71212 +3 + Partials 6609 6591 -18 
FlagCoverage Δ
Debug68.80% <47.82%> (+<0.01%)⬆️
production63.26% <ø> (+<0.01%)⬆️
test88.49% <47.82%> (+<0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...osoft.Data.Analysis.Tests/ArrowIntegrationTests.cs100.00% <100.00%> (ø)
...ata.Analysis.Tests/DataFrameJoinExtensionsTests.cs100.00% <100.00%> (ø)
.../Microsoft.ML.AutoML.Tests/ColumnInferenceTests.cs96.29% <100.00%> (ø)
...t.ML.AutoML.Tests/SuggestedPipelineBuilderTests.cs100.00% <100.00%> (ø)
test/Microsoft.ML.FSharp.Tests/SmokeTests.fs87.23% <ø> (ø)
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs0.00% <ø> (ø)
...stFramework/Attributes/BenchmarkTheoryAttribute.cs100.00% <ø> (ø)
test/Microsoft.ML.TestFramework/GlobalBase.cs33.33% <100.00%> (ø)
test/Microsoft.ML.TestFramework/TestCommandBase.cs39.45% <100.00%> (+0.04%)⬆️
...icrosoft.ML.TestFramework/DataPipe/TestDataPipe.cs91.06% <0.00%> (ø)
... and 5 more
... and 15 files with indirect coverage changes
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
04d8d36
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23279.1
@michaelgsharp
michaelgsharp
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jun 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80b44d6
…602.3
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23302.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7d571b5
…609.8
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23309.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
a6d9897
…616.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23316.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
827bea1
…622.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23322.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7f9de8a
…630.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23330.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
47cd477
…710.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23360.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7099384
…714.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23364.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
e51c1ba
…721.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23371.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
5449f24
…728.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23378.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
905fad9
…804.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23404.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7379ca5
…811.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23411.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
9c9fa1f
…819.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23419.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b83340a
…825.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23425.2
@michaelgsharp
michaelgsharp
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Sep 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8443dd7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b9cc1d7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
6b79938
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80a9a3a
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
eaa7961
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
a60ce8b
…008.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23508.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
6e6e344
…010.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23510.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
3430802
…018.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23518.2
ericstj
ericstj
reviewed
Dec 19, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Dec 21, 2023

Closed

@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Getting close! The ARM64 failures are both #6921.
@michaelgsharp - looks like the OSX failure in TestSaveAndLoadDoubleTreeFeaturizer is different
Assert.Equal() Failure: Values are not within 5 decimal places
Expected: 0.19011 (rounded from 0.1901149994134903)
Actual: 0.19012000000000001 (rounded from 0.19011500015854835)

It's funny, the actual difference between these two numbers is 0.00000000074505805, or 7.45 x 10^-10, but that's enough to make it round differently at 5 decimal places 😆 I wonder if we should use a different assert?
@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Turns out there's actually an assert that does that; https://github.com/xunit/assert.xunit/blob/6d9024665f1b67714311b38b72054fbad9d9972c/EqualityAsserts.cs#L342
Might be good to adopt this in our double comparisons since it would be less sensitive to differences when expected value is close to a rounding threshold.
@ericstjericstj
mentioned this pull request
Dec 21, 2023
 Merged

@ericstj
ericstj
commented
Dec 22, 2023

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Dec 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.Tests/Data/github-issues-train.tsv
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.TestFramework/Attributes/BenchmarkTheoryAttribute.cs
Outdated

ericstjand others
added 7 commits
December 22, 2023 14:18
@ericstj
Undo changes to test data
4a404f3
@ericstj
Make NETFRAMEWORK ifdef versionless
75b3706
@ericstj
Merge remote-tracking branch 'upstream/main' into darc-main-4fc19a23-…
c47e345
…a34d-4ff1-bd23-11be82f3618c
@ericstj
Switch back to centos7 for testing
ab0d41e
@ericstj
Revert "Switch back to centos7 for testing"
56511ac
This reverts commit ab0d41e.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
27b544f
…221.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23621.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
501826e
…228.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23628.1
@ericstj
ericstj
commented
Jan 2, 2024

Copy link


Copy Markdown

Member
Wow, green build. Should we merge it @michaelgsharp?
michaelgsharp
michaelgsharp
approved these changes
Jan 2, 2024
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ericstj
ericstj
merged commit f625080
into
mainJan 2, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c

branch
January 2, 2024 23:50
@ericstj
ericstj
commented
Jan 3, 2024

Copy link


Copy Markdown

Member
So this introduced a build break where the NoWarn for NETSDK1206 doesn't always apply. #6935 is fixing that.
@ericstjericstj
mentioned this pull request
Jan 4, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelgsharp@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #6703
Merged
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Jan 2, 2024
Merged
[main] Update dependencies from dotnet/arcade#6703
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 22, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: 97926d79-6b8b-4d32-c8db-08d9d479971c
  • Build: 20231228.1
  • Date Produced: December 28, 2023 10:38:38 AM UTC
  • Commit: 9e5fd26c0d1a187dfa08242d83e341634d4b1b07
  • Branch: refs/heads/main
dotnet-maestroBotand others
added 2 commits
May 22, 2023 12:36
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
63bfbea
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23269.2
@ericstj
Add dotnet8 nuget feed
f2e4581
@codecov
codecovBot
commented
May 25, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: 24 lines in your changes are missing coverage. Please review.
Comparison is base (d3c3127) 68.80% compared to head (501826e) 68.80%.
Additional details and impacted files
@@ Coverage Diff @@## main #6703 +/- ##
=======================================
Coverage 68.80% 68.80% =======================================
Files 1249 1249 Lines 249433 249436 +3 Branches 25509 25468 -41 =======================================
+ Hits 171615 171633 +18 - Misses 71209 71212 +3 + Partials 6609 6591 -18 
FlagCoverage Δ
Debug68.80% <47.82%> (+<0.01%)⬆️
production63.26% <ø> (+<0.01%)⬆️
test88.49% <47.82%> (+<0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...osoft.Data.Analysis.Tests/ArrowIntegrationTests.cs100.00% <100.00%> (ø)
...ata.Analysis.Tests/DataFrameJoinExtensionsTests.cs100.00% <100.00%> (ø)
.../Microsoft.ML.AutoML.Tests/ColumnInferenceTests.cs96.29% <100.00%> (ø)
...t.ML.AutoML.Tests/SuggestedPipelineBuilderTests.cs100.00% <100.00%> (ø)
test/Microsoft.ML.FSharp.Tests/SmokeTests.fs87.23% <ø> (ø)
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs0.00% <ø> (ø)
...stFramework/Attributes/BenchmarkTheoryAttribute.cs100.00% <ø> (ø)
test/Microsoft.ML.TestFramework/GlobalBase.cs33.33% <100.00%> (ø)
test/Microsoft.ML.TestFramework/TestCommandBase.cs39.45% <100.00%> (+0.04%)⬆️
...icrosoft.ML.TestFramework/DataPipe/TestDataPipe.cs91.06% <0.00%> (ø)
... and 5 more
... and 15 files with indirect coverage changes
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
04d8d36
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23279.1
@michaelgsharp
michaelgsharp
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jun 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80b44d6
…602.3
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23302.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7d571b5
…609.8
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23309.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
a6d9897
…616.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23316.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
827bea1
…622.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23322.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7f9de8a
…630.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23330.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
47cd477
…710.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23360.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7099384
…714.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23364.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
e51c1ba
…721.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23371.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
5449f24
…728.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23378.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
905fad9
…804.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23404.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7379ca5
…811.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23411.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
9c9fa1f
…819.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23419.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b83340a
…825.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23425.2
@michaelgsharp
michaelgsharp
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Sep 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8443dd7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b9cc1d7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
6b79938
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80a9a3a
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
eaa7961
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
a60ce8b
…008.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23508.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
6e6e344
…010.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23510.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
3430802
…018.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23518.2
ericstj
ericstj
reviewed
Dec 19, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Dec 21, 2023

Closed

@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Getting close! The ARM64 failures are both #6921.
@michaelgsharp - looks like the OSX failure in TestSaveAndLoadDoubleTreeFeaturizer is different
Assert.Equal() Failure: Values are not within 5 decimal places
Expected: 0.19011 (rounded from 0.1901149994134903)
Actual: 0.19012000000000001 (rounded from 0.19011500015854835)

It's funny, the actual difference between these two numbers is 0.00000000074505805, or 7.45 x 10^-10, but that's enough to make it round differently at 5 decimal places 😆 I wonder if we should use a different assert?
@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Turns out there's actually an assert that does that; https://github.com/xunit/assert.xunit/blob/6d9024665f1b67714311b38b72054fbad9d9972c/EqualityAsserts.cs#L342
Might be good to adopt this in our double comparisons since it would be less sensitive to differences when expected value is close to a rounding threshold.
@ericstjericstj
mentioned this pull request
Dec 21, 2023
 Merged

@ericstj
ericstj
commented
Dec 22, 2023

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Dec 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.Tests/Data/github-issues-train.tsv
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.TestFramework/Attributes/BenchmarkTheoryAttribute.cs
Outdated

ericstjand others
added 7 commits
December 22, 2023 14:18
@ericstj
Undo changes to test data
4a404f3
@ericstj
Make NETFRAMEWORK ifdef versionless
75b3706
@ericstj
Merge remote-tracking branch 'upstream/main' into darc-main-4fc19a23-…
c47e345
…a34d-4ff1-bd23-11be82f3618c
@ericstj
Switch back to centos7 for testing
ab0d41e
@ericstj
Revert "Switch back to centos7 for testing"
56511ac
This reverts commit ab0d41e.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
27b544f
…221.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23621.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
501826e
…228.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23628.1
@ericstj
ericstj
commented
Jan 2, 2024

Copy link


Copy Markdown

Member
Wow, green build. Should we merge it @michaelgsharp?
michaelgsharp
michaelgsharp
approved these changes
Jan 2, 2024
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ericstj
ericstj
merged commit f625080
into
mainJan 2, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c

branch
January 2, 2024 23:50
@ericstj
ericstj
commented
Jan 3, 2024

Copy link


Copy Markdown

Member
So this introduced a build break where the NoWarn for NETSDK1206 doesn't always apply. #6935 is fixing that.
@ericstjericstj
mentioned this pull request
Jan 4, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelgsharp@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[main] Update dependencies from dotnet/arcade - #6703
Merged
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Jan 2, 2024
Merged
[main] Update dependencies from dotnet/arcade#6703
ericstj merged 52 commits into
mainfrom 
darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 22, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: 97926d79-6b8b-4d32-c8db-08d9d479971c
  • Build: 20231228.1
  • Date Produced: December 28, 2023 10:38:38 AM UTC
  • Commit: 9e5fd26c0d1a187dfa08242d83e341634d4b1b07
  • Branch: refs/heads/main
dotnet-maestroBotand others
added 2 commits
May 22, 2023 12:36
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
63bfbea
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23269.2
@ericstj
Add dotnet8 nuget feed
f2e4581
@codecov
codecovBot
commented
May 25, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: 24 lines in your changes are missing coverage. Please review.
Comparison is base (d3c3127) 68.80% compared to head (501826e) 68.80%.
Additional details and impacted files
@@ Coverage Diff @@## main #6703 +/- ##
=======================================
Coverage 68.80% 68.80% =======================================
Files 1249 1249 Lines 249433 249436 +3 Branches 25509 25468 -41 =======================================
+ Hits 171615 171633 +18 - Misses 71209 71212 +3 + Partials 6609 6591 -18 
FlagCoverage Δ
Debug68.80% <47.82%> (+<0.01%)⬆️
production63.26% <ø> (+<0.01%)⬆️
test88.49% <47.82%> (+<0.01%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...osoft.Data.Analysis.Tests/ArrowIntegrationTests.cs100.00% <100.00%> (ø)
...ata.Analysis.Tests/DataFrameJoinExtensionsTests.cs100.00% <100.00%> (ø)
.../Microsoft.ML.AutoML.Tests/ColumnInferenceTests.cs96.29% <100.00%> (ø)
...t.ML.AutoML.Tests/SuggestedPipelineBuilderTests.cs100.00% <100.00%> (ø)
test/Microsoft.ML.FSharp.Tests/SmokeTests.fs87.23% <ø> (ø)
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs0.00% <ø> (ø)
...stFramework/Attributes/BenchmarkTheoryAttribute.cs100.00% <ø> (ø)
test/Microsoft.ML.TestFramework/GlobalBase.cs33.33% <100.00%> (ø)
test/Microsoft.ML.TestFramework/TestCommandBase.cs39.45% <100.00%> (+0.04%)⬆️
...icrosoft.ML.TestFramework/DataPipe/TestDataPipe.cs91.06% <0.00%> (ø)
... and 5 more
... and 15 files with indirect coverage changes
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
04d8d36
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23279.1
@michaelgsharp
michaelgsharp
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jun 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80b44d6
…602.3
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23302.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7d571b5
…609.8
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23309.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
a6d9897
…616.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23316.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
827bea1
…622.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23322.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7f9de8a
…630.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23330.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
47cd477
…710.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23360.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7099384
…714.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23364.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
e51c1ba
…721.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23371.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
5449f24
…728.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23378.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
905fad9
…804.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23404.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7379ca5
…811.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23411.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
9c9fa1f
…819.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23419.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b83340a
…825.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23425.2
@michaelgsharp
michaelgsharp
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Sep 1, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8443dd7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
b9cc1d7
…901.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
6b79938
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
80a9a3a
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
eaa7961
…913.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
a60ce8b
…008.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23508.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
6e6e344
…010.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23510.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
3430802
…018.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23518.2
ericstj
ericstj
reviewed
Dec 19, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Dec 21, 2023

Closed

@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Getting close! The ARM64 failures are both #6921.
@michaelgsharp - looks like the OSX failure in TestSaveAndLoadDoubleTreeFeaturizer is different
Assert.Equal() Failure: Values are not within 5 decimal places
Expected: 0.19011 (rounded from 0.1901149994134903)
Actual: 0.19012000000000001 (rounded from 0.19011500015854835)

It's funny, the actual difference between these two numbers is 0.00000000074505805, or 7.45 x 10^-10, but that's enough to make it round differently at 5 decimal places 😆 I wonder if we should use a different assert?
@ericstj
ericstj
commented
Dec 21, 2023

Copy link


Copy Markdown

Member
Turns out there's actually an assert that does that; https://github.com/xunit/assert.xunit/blob/6d9024665f1b67714311b38b72054fbad9d9972c/EqualityAsserts.cs#L342
Might be good to adopt this in our double comparisons since it would be less sensitive to differences when expected value is close to a rounding threshold.
@ericstjericstj
mentioned this pull request
Dec 21, 2023
 Merged

@ericstj
ericstj
commented
Dec 22, 2023

Copy link


Copy Markdown

Member
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Dec 22, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment thread.vsts-dotnet-ci.yml
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.Tests/Data/github-issues-train.tsv
ericstj
ericstj
reviewed
Dec 22, 2023
View reviewed changes
Comment threadtest/Microsoft.ML.TestFramework/Attributes/BenchmarkTheoryAttribute.cs
Outdated

ericstjand others
added 7 commits
December 22, 2023 14:18
@ericstj
Undo changes to test data
4a404f3
@ericstj
Make NETFRAMEWORK ifdef versionless
75b3706
@ericstj
Merge remote-tracking branch 'upstream/main' into darc-main-4fc19a23-…
c47e345
…a34d-4ff1-bd23-11be82f3618c
@ericstj
Switch back to centos7 for testing
ab0d41e
@ericstj
Revert "Switch back to centos7 for testing"
56511ac
This reverts commit ab0d41e.
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
27b544f
…221.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23621.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20231…
501826e
…228.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23628.1
@ericstj
ericstj
commented
Jan 2, 2024

Copy link


Copy Markdown

Member
Wow, green build. Should we merge it @michaelgsharp?
michaelgsharp
michaelgsharp
approved these changes
Jan 2, 2024
View reviewed changes
@michaelgsharpmichaelgsharp
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ericstj
ericstj
merged commit f625080
into
mainJan 2, 2024
@dotnet-maestro
dotnet-maestroBot
deleted the

darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c

branch
January 2, 2024 23:50
@ericstj
ericstj
commented
Jan 3, 2024

Copy link


Copy Markdown

Member
So this introduced a build break where the NoWarn for NETSDK1206 doesn't always apply. #6935 is fixing that.
@ericstjericstj
mentioned this pull request
Jan 4, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Feb 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelgsharp@ericstj