Clean DataFrame meaningless code

[asmirnov82]

Fixes#6754

1. PrimitiveColumnContainer is internal class, PrimitiveColumnContainer(T[] values) is not used anywhere inside DataFrameProject and there is another constructor that can be used for the same purpose PrimitiveColumnContainer(IEnumerable values). so this unused contructor can be easily removed (taking into account, that it contains errors - seems due to copy-past of code from the append method)

2. Line
   items[c] = items[c];
   is redundant, seems to appear after copy pasting from:

public static async Task<DataFrame> LoadFrom(DbDataReader reader)
...
for (var c = 0; c < columnsCount; c++)
{
items[c] = reader.IsDBNull(c) ? null : reader[c];
}

Method has unit tests. Changes don't affect method behaviour

[JakeRadMSFT]

I guess we can always bring it back if we need it?

Thanks for finding and cleaning up :)

[asmirnov82]

Sure, it can be returned back anytime we want.
And actually these 2 issues were found by @nodakai, not by me :)

[asmirnov82]

Fixes#6754

1. PrimitiveColumnContainer is internal class, PrimitiveColumnContainer(T[] values) is not used anywhere inside DataFrameProject and there is another constructor that can be used for the same purpose PrimitiveColumnContainer(IEnumerable values). so this unused contructor can be easily removed (taking into account, that it contains errors - seems due to copy-past of code from the append method)

2. Line
   items[c] = items[c];
   is redundant, seems to appear after copy pasting from:

public static async Task<DataFrame> LoadFrom(DbDataReader reader)
...
for (var c = 0; c < columnsCount; c++)
{
items[c] = reader.IsDBNull(c) ? null : reader[c];
}

Method has unit tests. Changes don't affect method behaviour

[JakeRadMSFT]

I guess we can always bring it back if we need it?

Thanks for finding and cleaning up :)

[asmirnov82]

Sure, it can be returned back anytime we want.
And actually these 2 issues were found by @nodakai, not by me :)

[asmirnov82]

Fixes#6754

1. PrimitiveColumnContainer is internal class, PrimitiveColumnContainer(T[] values) is not used anywhere inside DataFrameProject and there is another constructor that can be used for the same purpose PrimitiveColumnContainer(IEnumerable values). so this unused contructor can be easily removed (taking into account, that it contains errors - seems due to copy-past of code from the append method)

2. Line
   items[c] = items[c];
   is redundant, seems to appear after copy pasting from:

public static async Task<DataFrame> LoadFrom(DbDataReader reader)
...
for (var c = 0; c < columnsCount; c++)
{
items[c] = reader.IsDBNull(c) ? null : reader[c];
}

Method has unit tests. Changes don't affect method behaviour

[JakeRadMSFT]

I guess we can always bring it back if we need it?

Thanks for finding and cleaning up :)

[asmirnov82]

Sure, it can be returned back anytime we want.
And actually these 2 issues were found by @nodakai, not by me :)

[asmirnov82]

Fixes#6754

1. PrimitiveColumnContainer is internal class, PrimitiveColumnContainer(T[] values) is not used anywhere inside DataFrameProject and there is another constructor that can be used for the same purpose PrimitiveColumnContainer(IEnumerable values). so this unused contructor can be easily removed (taking into account, that it contains errors - seems due to copy-past of code from the append method)

2. Line
   items[c] = items[c];
   is redundant, seems to appear after copy pasting from:

public static async Task<DataFrame> LoadFrom(DbDataReader reader)
...
for (var c = 0; c < columnsCount; c++)
{
items[c] = reader.IsDBNull(c) ? null : reader[c];
}

Method has unit tests. Changes don't affect method behaviour

[JakeRadMSFT]

I guess we can always bring it back if we need it?

Thanks for finding and cleaning up :)

[asmirnov82]

Sure, it can be returned back anytime we want.
And actually these 2 issues were found by @nodakai, not by me :)

[asmirnov82]

Fixes#6754

1. PrimitiveColumnContainer is internal class, PrimitiveColumnContainer(T[] values) is not used anywhere inside DataFrameProject and there is another constructor that can be used for the same purpose PrimitiveColumnContainer(IEnumerable values). so this unused contructor can be easily removed (taking into account, that it contains errors - seems due to copy-past of code from the append method)

2. Line
   items[c] = items[c];
   is redundant, seems to appear after copy pasting from:

public static async Task<DataFrame> LoadFrom(DbDataReader reader)
...
for (var c = 0; c < columnsCount; c++)
{
items[c] = reader.IsDBNull(c) ? null : reader[c];
}

Method has unit tests. Changes don't affect method behaviour

[JakeRadMSFT]

I guess we can always bring it back if we need it?

Thanks for finding and cleaning up :)

[asmirnov82]

Sure, it can be returned back anytime we want.
And actually these 2 issues were found by @nodakai, not by me :)

[asmirnov82]

Fixes#6754

1. PrimitiveColumnContainer is internal class, PrimitiveColumnContainer(T[] values) is not used anywhere inside DataFrameProject and there is another constructor that can be used for the same purpose PrimitiveColumnContainer(IEnumerable values). so this unused contructor can be easily removed (taking into account, that it contains errors - seems due to copy-past of code from the append method)

2. Line
   items[c] = items[c];
   is redundant, seems to appear after copy pasting from:

public static async Task<DataFrame> LoadFrom(DbDataReader reader)
...
for (var c = 0; c < columnsCount; c++)
{
items[c] = reader.IsDBNull(c) ? null : reader[c];
}

Method has unit tests. Changes don't affect method behaviour

[JakeRadMSFT]

I guess we can always bring it back if we need it?

Thanks for finding and cleaning up :)

[asmirnov82]

Sure, it can be returned back anytime we want.
And actually these 2 issues were found by @nodakai, not by me :)

[asmirnov82]

Fixes#6754

1. PrimitiveColumnContainer is internal class, PrimitiveColumnContainer(T[] values) is not used anywhere inside DataFrameProject and there is another constructor that can be used for the same purpose PrimitiveColumnContainer(IEnumerable values). so this unused contructor can be easily removed (taking into account, that it contains errors - seems due to copy-past of code from the append method)

2. Line
   items[c] = items[c];
   is redundant, seems to appear after copy pasting from:

public static async Task<DataFrame> LoadFrom(DbDataReader reader)
...
for (var c = 0; c < columnsCount; c++)
{
items[c] = reader.IsDBNull(c) ? null : reader[c];
}

Method has unit tests. Changes don't affect method behaviour

[JakeRadMSFT]

I guess we can always bring it back if we need it?

Thanks for finding and cleaning up :)

[asmirnov82]

Sure, it can be returned back anytime we want.
And actually these 2 issues were found by @nodakai, not by me :)

[asmirnov82]

Fixes#6754

1. PrimitiveColumnContainer is internal class, PrimitiveColumnContainer(T[] values) is not used anywhere inside DataFrameProject and there is another constructor that can be used for the same purpose PrimitiveColumnContainer(IEnumerable values). so this unused contructor can be easily removed (taking into account, that it contains errors - seems due to copy-past of code from the append method)

2. Line
   items[c] = items[c];
   is redundant, seems to appear after copy pasting from:

public static async Task<DataFrame> LoadFrom(DbDataReader reader)
...
for (var c = 0; c < columnsCount; c++)
{
items[c] = reader.IsDBNull(c) ? null : reader[c];
}

Method has unit tests. Changes don't affect method behaviour

[JakeRadMSFT]

I guess we can always bring it back if we need it?

Thanks for finding and cleaning up :)

[asmirnov82]

Sure, it can be returned back anytime we want.
And actually these 2 issues were found by @nodakai, not by me :)