Add Microsoft.ML.GenAI.Phi, test package and sample project. - #7184

Merged
LittleLittleCloud merged 43 commits into
dotnet:mainfrom
LittleLittleCloud:u/xiaoyun/phi
Jul 30, 2024
Merged

Add Microsoft.ML.GenAI.Phi, test package and sample project.#7184
LittleLittleCloud merged 43 commits into
dotnet:mainfrom
LittleLittleCloud:u/xiaoyun/phi

Conversation

@LittleLittleCloud

@LittleLittleCloudLittleLittleCloud commented Jun 28, 2024•
edited
Loading

Copy link
Copy Markdown
Member

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

#7169

@LittleLittleCloudLittleLittleCloud mentioned this pull request Jun 28, 2024
Open
13 tasks
LittleLittleCloud
LittleLittleCloud commented Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs Outdated
LittleLittleCloud
LittleLittleCloud commented Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs Outdated
tarekgh
tarekgh reviewed Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs Outdated
@build-analysisbuild-analysisBot mentioned this pull request Jul 1, 2024
Open
3 tasks
@azure-pipelines

azure-pipelinesBot commented Jul 19, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

tarekgh
tarekgh reviewed Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs Outdated
tarekgh
tarekgh reviewed Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
@luisquintanilla

luisquintanilla commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

@LittleLittleCloud samples look good.

Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.

Similar to:

https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26

tarekgh
tarekgh reviewed Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs

return tokens
.Where(t => t.Offset != (0, 0))
.Select(t => t.Id)

@tarekghtarekghJul 22, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this for?

@LittleLittleCloudLittleLittleCloudJul 22, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To detect the _ token automatically added by tokenzier

@tarekghtarekghJul 22, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks. it is worth a comment.

Also, EncodeToToken is very expensive comparing to EncodeToIds. If you are interested to optimize I can suggest some code to check for _ token.

@LittleLittleCloudLittleLittleCloudJul 23, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be very helpful

@LittleLittleCloud

LittleLittleCloud commented Jul 23, 2024

Copy link
Copy Markdown
MemberAuthor

@LittleLittleCloud samples look good.

Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.

Similar to:

https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26

Rename to AddGenAIChatCompletion and AddGenAITextCompletion

@build-analysisbuild-analysisBot mentioned this pull request Jul 23, 2024
Open
@build-analysisbuild-analysisBot mentioned this pull request Jul 29, 2024
Open
@LittleLittleCloud

LittleLittleCloud commented Jul 30, 2024

Copy link
Copy Markdown
MemberAuthor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jul 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@codecov

codecovBot commented Jul 30, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.28902% with 774 lines in your changes missing coverage. Please review.

Project coverage is 68.90%. Comparing base (579fe03) to head (a97afdf).
Report is 10 commits behind head on main.

FilesPatch %Lines
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs0.00%98 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Attention.cs25.00%86 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Utils.cs12.94%72 Missing and 2 partials ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Model.cs19.04%68 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Model.cs12.16%65 Missing ⚠️
.../Microsoft.ML.GenAI.Phi/Module/Phi3DecoderLayer.cs16.66%59 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Attention.cs32.09%53 Missing and 2 partials ⚠️
...crosoft.ML.GenAI.Phi/Module/Phi3RotaryEmbedding.cs20.00%32 Missing ⚠️
...ML.GenAI.Phi/Module/Phi3SuScaledRotaryEmbedding.cs24.39%31 Missing ⚠️
...c/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMAgent.cs56.71%21 Missing and 8 partials ⚠️
... and 18 more
Additional details and impacted files
@@ Coverage Diff @@## main #7184 +/- ##
==========================================
- Coverage 69.06% 68.90% -0.16% 
==========================================
Files 1401 1441 +40 Lines 268516 270828 +2312 Branches 27812 28019 +207 ==========================================
+ Hits 185451 186619 +1168 - Misses 75902 77004 +1102 - Partials 7163 7205 +42
FlagCoverage Δ
Debug68.90% <50.28%> (-0.16%)⬇️
production63.43% <41.62%> (-0.22%)⬇️
test89.02% <95.60%> (+0.06%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

FilesCoverage Δ
...crosoft.ML.GenAI.Core/Extension/ModuleExtension.cs54.22% <100.00%> (ø)
src/Microsoft.ML.GenAI.Core/Module/GenAILinear.cs100.00% <100.00%> (ø)
....ML.GenAI.Phi/Extension/SemanticKernelExtension.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi2/Phi2TokenizerHelper.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi3/Phi3TokenizerHelper.cs100.00% <100.00%> (ø)
test/Microsoft.ML.GenAI.Phi.Tests/AutoGenTests.cs100.00% <100.00%> (ø)
...icrosoft.ML.GenAI.Phi.Tests/SemanticKernelTests.cs100.00% <100.00%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi2/Config.cs98.00% <98.00%> (ø)
...rosoft.ML.GenAI.Core.Tests/QuantizedLinearTests.cs95.52% <95.52%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi3/Config.cs93.84% <93.84%> (ø)
... and 25 more

... and 38 files with indirect coverage changes

@LittleLittleCloud
LittleLittleCloud merged commit 6d1f7e2 into dotnet:mainJul 30, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 30, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekghtarekghtarekgh left review comments
@ericstjericstjAwaiting requested review from ericstj
+1 more reviewer
@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LittleLittleCloudLittleLittleCloud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LittleLittleCloud@luisquintanilla@tarekgh@michaelgsharp
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add Microsoft.ML.GenAI.Phi, test package and sample project. - #7184
Merged
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Jul 30, 2024
Merged
Add Microsoft.ML.GenAI.Phi, test package and sample project.#7184
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Conversation
@LittleLittleCloud
@LittleLittleCloudLittleLittleCloud
commented
Jun 28, 2024•

edited

Loading

Copy link


Copy Markdown

Member
We are excited to review your PR.
So we can do the best job, please check:
  •  There's a descriptive title that will make sense to other developers some time from now.
  •  There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  •  Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  •  You have included any necessary tests in the same PR.
#7169
@LittleLittleCloudLittleLittleCloud
mentioned this pull request
Jun 28, 2024

Open

13 tasks
LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

tarekgh
tarekgh
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Open

3 tasks
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
@luisquintanilla
luisquintanilla
commented
Jul 22, 2024

Copy link


Copy Markdown

Contributor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs

 return tokens
 .Where(t => t.Offset != (0, 0))
 .Select(t => t.Id)
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this for?
@LittleLittleCloudLittleLittleCloudJul 22, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To detect the _ token automatically added by tokenzier
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks. it is worth a comment.
Also, EncodeToToken is very expensive comparing to EncodeToIds. If you are interested to optimize I can suggest some code to check for _  token.
@LittleLittleCloudLittleLittleCloudJul 23, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be very helpful
@LittleLittleCloud
LittleLittleCloud
commented
Jul 23, 2024

Copy link


Copy Markdown

MemberAuthor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
Rename to AddGenAIChatCompletion and AddGenAITextCompletion
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 23, 2024

Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2024

Open

@LittleLittleCloud
LittleLittleCloud
commented
Jul 30, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 30, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@codecov
codecovBot
commented
Jul 30, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.28902% with 774 lines in your changes missing coverage. Please review.
Project coverage is 68.90%. Comparing base (579fe03) to head (a97afdf).

Report is 10 commits behind head on main.
FilesPatch %Lines
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs0.00%98 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Attention.cs25.00%86 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Utils.cs12.94%72 Missing and 2 partials ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Model.cs19.04%68 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Model.cs12.16%65 Missing ⚠️
.../Microsoft.ML.GenAI.Phi/Module/Phi3DecoderLayer.cs16.66%59 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Attention.cs32.09%53 Missing and 2 partials ⚠️
...crosoft.ML.GenAI.Phi/Module/Phi3RotaryEmbedding.cs20.00%32 Missing ⚠️
...ML.GenAI.Phi/Module/Phi3SuScaledRotaryEmbedding.cs24.39%31 Missing ⚠️
...c/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMAgent.cs56.71%21 Missing and 8 partials ⚠️
... and 18 more
Additional details and impacted files
@@ Coverage Diff @@## main #7184 +/- ##
==========================================
- Coverage 69.06% 68.90% -0.16% 
==========================================
Files 1401 1441 +40 Lines 268516 270828 +2312 Branches 27812 28019 +207 ==========================================
+ Hits 185451 186619 +1168 - Misses 75902 77004 +1102 - Partials 7163 7205 +42 
FlagCoverage Δ
Debug68.90% <50.28%> (-0.16%)⬇️
production63.43% <41.62%> (-0.22%)⬇️
test89.02% <95.60%> (+0.06%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...crosoft.ML.GenAI.Core/Extension/ModuleExtension.cs54.22% <100.00%> (ø)
src/Microsoft.ML.GenAI.Core/Module/GenAILinear.cs100.00% <100.00%> (ø)
....ML.GenAI.Phi/Extension/SemanticKernelExtension.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi2/Phi2TokenizerHelper.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi3/Phi3TokenizerHelper.cs100.00% <100.00%> (ø)
test/Microsoft.ML.GenAI.Phi.Tests/AutoGenTests.cs100.00% <100.00%> (ø)
...icrosoft.ML.GenAI.Phi.Tests/SemanticKernelTests.cs100.00% <100.00%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi2/Config.cs98.00% <98.00%> (ø)
...rosoft.ML.GenAI.Core.Tests/QuantizedLinearTests.cs95.52% <95.52%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi3/Config.cs93.84% <93.84%> (ø)
... and 25 more
... and 38 files with indirect coverage changes
@LittleLittleCloud
LittleLittleCloud
merged commit 6d1f7e2
into
dotnet:mainJul 30, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 30, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh left review comments
@ericstjericstjAwaiting requested review from ericstj

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LittleLittleCloudLittleLittleCloud

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@LittleLittleCloud@luisquintanilla@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Microsoft.ML.GenAI.Phi, test package and sample project. - #7184
Merged
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Jul 30, 2024
Merged
Add Microsoft.ML.GenAI.Phi, test package and sample project.#7184
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Conversation
@LittleLittleCloud
@LittleLittleCloudLittleLittleCloud
commented
Jun 28, 2024•

edited

Loading

Copy link


Copy Markdown

Member
We are excited to review your PR.
So we can do the best job, please check:
  •  There's a descriptive title that will make sense to other developers some time from now.
  •  There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  •  Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  •  You have included any necessary tests in the same PR.
#7169
@LittleLittleCloudLittleLittleCloud
mentioned this pull request
Jun 28, 2024

Open

13 tasks
LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

tarekgh
tarekgh
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Open

3 tasks
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
@luisquintanilla
luisquintanilla
commented
Jul 22, 2024

Copy link


Copy Markdown

Contributor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs

 return tokens
 .Where(t => t.Offset != (0, 0))
 .Select(t => t.Id)
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this for?
@LittleLittleCloudLittleLittleCloudJul 22, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To detect the _ token automatically added by tokenzier
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks. it is worth a comment.
Also, EncodeToToken is very expensive comparing to EncodeToIds. If you are interested to optimize I can suggest some code to check for _  token.
@LittleLittleCloudLittleLittleCloudJul 23, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be very helpful
@LittleLittleCloud
LittleLittleCloud
commented
Jul 23, 2024

Copy link


Copy Markdown

MemberAuthor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
Rename to AddGenAIChatCompletion and AddGenAITextCompletion
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 23, 2024

Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2024

Open

@LittleLittleCloud
LittleLittleCloud
commented
Jul 30, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 30, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@codecov
codecovBot
commented
Jul 30, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.28902% with 774 lines in your changes missing coverage. Please review.
Project coverage is 68.90%. Comparing base (579fe03) to head (a97afdf).

Report is 10 commits behind head on main.
FilesPatch %Lines
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs0.00%98 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Attention.cs25.00%86 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Utils.cs12.94%72 Missing and 2 partials ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Model.cs19.04%68 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Model.cs12.16%65 Missing ⚠️
.../Microsoft.ML.GenAI.Phi/Module/Phi3DecoderLayer.cs16.66%59 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Attention.cs32.09%53 Missing and 2 partials ⚠️
...crosoft.ML.GenAI.Phi/Module/Phi3RotaryEmbedding.cs20.00%32 Missing ⚠️
...ML.GenAI.Phi/Module/Phi3SuScaledRotaryEmbedding.cs24.39%31 Missing ⚠️
...c/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMAgent.cs56.71%21 Missing and 8 partials ⚠️
... and 18 more
Additional details and impacted files
@@ Coverage Diff @@## main #7184 +/- ##
==========================================
- Coverage 69.06% 68.90% -0.16% 
==========================================
Files 1401 1441 +40 Lines 268516 270828 +2312 Branches 27812 28019 +207 ==========================================
+ Hits 185451 186619 +1168 - Misses 75902 77004 +1102 - Partials 7163 7205 +42 
FlagCoverage Δ
Debug68.90% <50.28%> (-0.16%)⬇️
production63.43% <41.62%> (-0.22%)⬇️
test89.02% <95.60%> (+0.06%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...crosoft.ML.GenAI.Core/Extension/ModuleExtension.cs54.22% <100.00%> (ø)
src/Microsoft.ML.GenAI.Core/Module/GenAILinear.cs100.00% <100.00%> (ø)
....ML.GenAI.Phi/Extension/SemanticKernelExtension.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi2/Phi2TokenizerHelper.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi3/Phi3TokenizerHelper.cs100.00% <100.00%> (ø)
test/Microsoft.ML.GenAI.Phi.Tests/AutoGenTests.cs100.00% <100.00%> (ø)
...icrosoft.ML.GenAI.Phi.Tests/SemanticKernelTests.cs100.00% <100.00%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi2/Config.cs98.00% <98.00%> (ø)
...rosoft.ML.GenAI.Core.Tests/QuantizedLinearTests.cs95.52% <95.52%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi3/Config.cs93.84% <93.84%> (ø)
... and 25 more
... and 38 files with indirect coverage changes
@LittleLittleCloud
LittleLittleCloud
merged commit 6d1f7e2
into
dotnet:mainJul 30, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 30, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh left review comments
@ericstjericstjAwaiting requested review from ericstj

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LittleLittleCloudLittleLittleCloud

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@LittleLittleCloud@luisquintanilla@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Microsoft.ML.GenAI.Phi, test package and sample project. - #7184
Merged
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Jul 30, 2024
Merged
Add Microsoft.ML.GenAI.Phi, test package and sample project.#7184
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Conversation
@LittleLittleCloud
@LittleLittleCloudLittleLittleCloud
commented
Jun 28, 2024•

edited

Loading

Copy link


Copy Markdown

Member
We are excited to review your PR.
So we can do the best job, please check:
  •  There's a descriptive title that will make sense to other developers some time from now.
  •  There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  •  Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  •  You have included any necessary tests in the same PR.
#7169
@LittleLittleCloudLittleLittleCloud
mentioned this pull request
Jun 28, 2024

Open

13 tasks
LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

tarekgh
tarekgh
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Open

3 tasks
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
@luisquintanilla
luisquintanilla
commented
Jul 22, 2024

Copy link


Copy Markdown

Contributor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs

 return tokens
 .Where(t => t.Offset != (0, 0))
 .Select(t => t.Id)
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this for?
@LittleLittleCloudLittleLittleCloudJul 22, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To detect the _ token automatically added by tokenzier
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks. it is worth a comment.
Also, EncodeToToken is very expensive comparing to EncodeToIds. If you are interested to optimize I can suggest some code to check for _  token.
@LittleLittleCloudLittleLittleCloudJul 23, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be very helpful
@LittleLittleCloud
LittleLittleCloud
commented
Jul 23, 2024

Copy link


Copy Markdown

MemberAuthor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
Rename to AddGenAIChatCompletion and AddGenAITextCompletion
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 23, 2024

Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2024

Open

@LittleLittleCloud
LittleLittleCloud
commented
Jul 30, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 30, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@codecov
codecovBot
commented
Jul 30, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.28902% with 774 lines in your changes missing coverage. Please review.
Project coverage is 68.90%. Comparing base (579fe03) to head (a97afdf).

Report is 10 commits behind head on main.
FilesPatch %Lines
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs0.00%98 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Attention.cs25.00%86 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Utils.cs12.94%72 Missing and 2 partials ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Model.cs19.04%68 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Model.cs12.16%65 Missing ⚠️
.../Microsoft.ML.GenAI.Phi/Module/Phi3DecoderLayer.cs16.66%59 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Attention.cs32.09%53 Missing and 2 partials ⚠️
...crosoft.ML.GenAI.Phi/Module/Phi3RotaryEmbedding.cs20.00%32 Missing ⚠️
...ML.GenAI.Phi/Module/Phi3SuScaledRotaryEmbedding.cs24.39%31 Missing ⚠️
...c/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMAgent.cs56.71%21 Missing and 8 partials ⚠️
... and 18 more
Additional details and impacted files
@@ Coverage Diff @@## main #7184 +/- ##
==========================================
- Coverage 69.06% 68.90% -0.16% 
==========================================
Files 1401 1441 +40 Lines 268516 270828 +2312 Branches 27812 28019 +207 ==========================================
+ Hits 185451 186619 +1168 - Misses 75902 77004 +1102 - Partials 7163 7205 +42 
FlagCoverage Δ
Debug68.90% <50.28%> (-0.16%)⬇️
production63.43% <41.62%> (-0.22%)⬇️
test89.02% <95.60%> (+0.06%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...crosoft.ML.GenAI.Core/Extension/ModuleExtension.cs54.22% <100.00%> (ø)
src/Microsoft.ML.GenAI.Core/Module/GenAILinear.cs100.00% <100.00%> (ø)
....ML.GenAI.Phi/Extension/SemanticKernelExtension.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi2/Phi2TokenizerHelper.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi3/Phi3TokenizerHelper.cs100.00% <100.00%> (ø)
test/Microsoft.ML.GenAI.Phi.Tests/AutoGenTests.cs100.00% <100.00%> (ø)
...icrosoft.ML.GenAI.Phi.Tests/SemanticKernelTests.cs100.00% <100.00%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi2/Config.cs98.00% <98.00%> (ø)
...rosoft.ML.GenAI.Core.Tests/QuantizedLinearTests.cs95.52% <95.52%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi3/Config.cs93.84% <93.84%> (ø)
... and 25 more
... and 38 files with indirect coverage changes
@LittleLittleCloud
LittleLittleCloud
merged commit 6d1f7e2
into
dotnet:mainJul 30, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 30, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh left review comments
@ericstjericstjAwaiting requested review from ericstj

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LittleLittleCloudLittleLittleCloud

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@LittleLittleCloud@luisquintanilla@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add Microsoft.ML.GenAI.Phi, test package and sample project. - #7184
Merged
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Jul 30, 2024
Merged
Add Microsoft.ML.GenAI.Phi, test package and sample project.#7184
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Conversation
@LittleLittleCloud
@LittleLittleCloudLittleLittleCloud
commented
Jun 28, 2024•

edited

Loading

Copy link


Copy Markdown

Member
We are excited to review your PR.
So we can do the best job, please check:
  •  There's a descriptive title that will make sense to other developers some time from now.
  •  There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  •  Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  •  You have included any necessary tests in the same PR.
#7169
@LittleLittleCloudLittleLittleCloud
mentioned this pull request
Jun 28, 2024

Open

13 tasks
LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

tarekgh
tarekgh
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Open

3 tasks
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
@luisquintanilla
luisquintanilla
commented
Jul 22, 2024

Copy link


Copy Markdown

Contributor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs

 return tokens
 .Where(t => t.Offset != (0, 0))
 .Select(t => t.Id)
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this for?
@LittleLittleCloudLittleLittleCloudJul 22, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To detect the _ token automatically added by tokenzier
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks. it is worth a comment.
Also, EncodeToToken is very expensive comparing to EncodeToIds. If you are interested to optimize I can suggest some code to check for _  token.
@LittleLittleCloudLittleLittleCloudJul 23, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be very helpful
@LittleLittleCloud
LittleLittleCloud
commented
Jul 23, 2024

Copy link


Copy Markdown

MemberAuthor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
Rename to AddGenAIChatCompletion and AddGenAITextCompletion
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 23, 2024

Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2024

Open

@LittleLittleCloud
LittleLittleCloud
commented
Jul 30, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 30, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@codecov
codecovBot
commented
Jul 30, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.28902% with 774 lines in your changes missing coverage. Please review.
Project coverage is 68.90%. Comparing base (579fe03) to head (a97afdf).

Report is 10 commits behind head on main.
FilesPatch %Lines
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs0.00%98 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Attention.cs25.00%86 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Utils.cs12.94%72 Missing and 2 partials ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Model.cs19.04%68 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Model.cs12.16%65 Missing ⚠️
.../Microsoft.ML.GenAI.Phi/Module/Phi3DecoderLayer.cs16.66%59 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Attention.cs32.09%53 Missing and 2 partials ⚠️
...crosoft.ML.GenAI.Phi/Module/Phi3RotaryEmbedding.cs20.00%32 Missing ⚠️
...ML.GenAI.Phi/Module/Phi3SuScaledRotaryEmbedding.cs24.39%31 Missing ⚠️
...c/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMAgent.cs56.71%21 Missing and 8 partials ⚠️
... and 18 more
Additional details and impacted files
@@ Coverage Diff @@## main #7184 +/- ##
==========================================
- Coverage 69.06% 68.90% -0.16% 
==========================================
Files 1401 1441 +40 Lines 268516 270828 +2312 Branches 27812 28019 +207 ==========================================
+ Hits 185451 186619 +1168 - Misses 75902 77004 +1102 - Partials 7163 7205 +42 
FlagCoverage Δ
Debug68.90% <50.28%> (-0.16%)⬇️
production63.43% <41.62%> (-0.22%)⬇️
test89.02% <95.60%> (+0.06%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...crosoft.ML.GenAI.Core/Extension/ModuleExtension.cs54.22% <100.00%> (ø)
src/Microsoft.ML.GenAI.Core/Module/GenAILinear.cs100.00% <100.00%> (ø)
....ML.GenAI.Phi/Extension/SemanticKernelExtension.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi2/Phi2TokenizerHelper.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi3/Phi3TokenizerHelper.cs100.00% <100.00%> (ø)
test/Microsoft.ML.GenAI.Phi.Tests/AutoGenTests.cs100.00% <100.00%> (ø)
...icrosoft.ML.GenAI.Phi.Tests/SemanticKernelTests.cs100.00% <100.00%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi2/Config.cs98.00% <98.00%> (ø)
...rosoft.ML.GenAI.Core.Tests/QuantizedLinearTests.cs95.52% <95.52%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi3/Config.cs93.84% <93.84%> (ø)
... and 25 more
... and 38 files with indirect coverage changes
@LittleLittleCloud
LittleLittleCloud
merged commit 6d1f7e2
into
dotnet:mainJul 30, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 30, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh left review comments
@ericstjericstjAwaiting requested review from ericstj

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LittleLittleCloudLittleLittleCloud

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@LittleLittleCloud@luisquintanilla@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Microsoft.ML.GenAI.Phi, test package and sample project. - #7184
Merged
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Jul 30, 2024
Merged
Add Microsoft.ML.GenAI.Phi, test package and sample project.#7184
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Conversation
@LittleLittleCloud
@LittleLittleCloudLittleLittleCloud
commented
Jun 28, 2024•

edited

Loading

Copy link


Copy Markdown

Member
We are excited to review your PR.
So we can do the best job, please check:
  •  There's a descriptive title that will make sense to other developers some time from now.
  •  There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  •  Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  •  You have included any necessary tests in the same PR.
#7169
@LittleLittleCloudLittleLittleCloud
mentioned this pull request
Jun 28, 2024

Open

13 tasks
LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

tarekgh
tarekgh
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Open

3 tasks
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
@luisquintanilla
luisquintanilla
commented
Jul 22, 2024

Copy link


Copy Markdown

Contributor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs

 return tokens
 .Where(t => t.Offset != (0, 0))
 .Select(t => t.Id)
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this for?
@LittleLittleCloudLittleLittleCloudJul 22, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To detect the _ token automatically added by tokenzier
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks. it is worth a comment.
Also, EncodeToToken is very expensive comparing to EncodeToIds. If you are interested to optimize I can suggest some code to check for _  token.
@LittleLittleCloudLittleLittleCloudJul 23, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be very helpful
@LittleLittleCloud
LittleLittleCloud
commented
Jul 23, 2024

Copy link


Copy Markdown

MemberAuthor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
Rename to AddGenAIChatCompletion and AddGenAITextCompletion
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 23, 2024

Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2024

Open

@LittleLittleCloud
LittleLittleCloud
commented
Jul 30, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 30, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@codecov
codecovBot
commented
Jul 30, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.28902% with 774 lines in your changes missing coverage. Please review.
Project coverage is 68.90%. Comparing base (579fe03) to head (a97afdf).

Report is 10 commits behind head on main.
FilesPatch %Lines
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs0.00%98 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Attention.cs25.00%86 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Utils.cs12.94%72 Missing and 2 partials ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Model.cs19.04%68 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Model.cs12.16%65 Missing ⚠️
.../Microsoft.ML.GenAI.Phi/Module/Phi3DecoderLayer.cs16.66%59 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Attention.cs32.09%53 Missing and 2 partials ⚠️
...crosoft.ML.GenAI.Phi/Module/Phi3RotaryEmbedding.cs20.00%32 Missing ⚠️
...ML.GenAI.Phi/Module/Phi3SuScaledRotaryEmbedding.cs24.39%31 Missing ⚠️
...c/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMAgent.cs56.71%21 Missing and 8 partials ⚠️
... and 18 more
Additional details and impacted files
@@ Coverage Diff @@## main #7184 +/- ##
==========================================
- Coverage 69.06% 68.90% -0.16% 
==========================================
Files 1401 1441 +40 Lines 268516 270828 +2312 Branches 27812 28019 +207 ==========================================
+ Hits 185451 186619 +1168 - Misses 75902 77004 +1102 - Partials 7163 7205 +42 
FlagCoverage Δ
Debug68.90% <50.28%> (-0.16%)⬇️
production63.43% <41.62%> (-0.22%)⬇️
test89.02% <95.60%> (+0.06%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...crosoft.ML.GenAI.Core/Extension/ModuleExtension.cs54.22% <100.00%> (ø)
src/Microsoft.ML.GenAI.Core/Module/GenAILinear.cs100.00% <100.00%> (ø)
....ML.GenAI.Phi/Extension/SemanticKernelExtension.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi2/Phi2TokenizerHelper.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi3/Phi3TokenizerHelper.cs100.00% <100.00%> (ø)
test/Microsoft.ML.GenAI.Phi.Tests/AutoGenTests.cs100.00% <100.00%> (ø)
...icrosoft.ML.GenAI.Phi.Tests/SemanticKernelTests.cs100.00% <100.00%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi2/Config.cs98.00% <98.00%> (ø)
...rosoft.ML.GenAI.Core.Tests/QuantizedLinearTests.cs95.52% <95.52%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi3/Config.cs93.84% <93.84%> (ø)
... and 25 more
... and 38 files with indirect coverage changes
@LittleLittleCloud
LittleLittleCloud
merged commit 6d1f7e2
into
dotnet:mainJul 30, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 30, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh left review comments
@ericstjericstjAwaiting requested review from ericstj

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LittleLittleCloudLittleLittleCloud

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@LittleLittleCloud@luisquintanilla@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add Microsoft.ML.GenAI.Phi, test package and sample project. - #7184
Merged
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Jul 30, 2024
Merged
Add Microsoft.ML.GenAI.Phi, test package and sample project.#7184
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Conversation
@LittleLittleCloud
@LittleLittleCloudLittleLittleCloud
commented
Jun 28, 2024•

edited

Loading

Copy link


Copy Markdown

Member
We are excited to review your PR.
So we can do the best job, please check:
  •  There's a descriptive title that will make sense to other developers some time from now.
  •  There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  •  Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  •  You have included any necessary tests in the same PR.
#7169
@LittleLittleCloudLittleLittleCloud
mentioned this pull request
Jun 28, 2024

Open

13 tasks
LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

tarekgh
tarekgh
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Open

3 tasks
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
@luisquintanilla
luisquintanilla
commented
Jul 22, 2024

Copy link


Copy Markdown

Contributor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs

 return tokens
 .Where(t => t.Offset != (0, 0))
 .Select(t => t.Id)
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this for?
@LittleLittleCloudLittleLittleCloudJul 22, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To detect the _ token automatically added by tokenzier
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks. it is worth a comment.
Also, EncodeToToken is very expensive comparing to EncodeToIds. If you are interested to optimize I can suggest some code to check for _  token.
@LittleLittleCloudLittleLittleCloudJul 23, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be very helpful
@LittleLittleCloud
LittleLittleCloud
commented
Jul 23, 2024

Copy link


Copy Markdown

MemberAuthor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
Rename to AddGenAIChatCompletion and AddGenAITextCompletion
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 23, 2024

Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2024

Open

@LittleLittleCloud
LittleLittleCloud
commented
Jul 30, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 30, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@codecov
codecovBot
commented
Jul 30, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.28902% with 774 lines in your changes missing coverage. Please review.
Project coverage is 68.90%. Comparing base (579fe03) to head (a97afdf).

Report is 10 commits behind head on main.
FilesPatch %Lines
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs0.00%98 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Attention.cs25.00%86 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Utils.cs12.94%72 Missing and 2 partials ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Model.cs19.04%68 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Model.cs12.16%65 Missing ⚠️
.../Microsoft.ML.GenAI.Phi/Module/Phi3DecoderLayer.cs16.66%59 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Attention.cs32.09%53 Missing and 2 partials ⚠️
...crosoft.ML.GenAI.Phi/Module/Phi3RotaryEmbedding.cs20.00%32 Missing ⚠️
...ML.GenAI.Phi/Module/Phi3SuScaledRotaryEmbedding.cs24.39%31 Missing ⚠️
...c/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMAgent.cs56.71%21 Missing and 8 partials ⚠️
... and 18 more
Additional details and impacted files
@@ Coverage Diff @@## main #7184 +/- ##
==========================================
- Coverage 69.06% 68.90% -0.16% 
==========================================
Files 1401 1441 +40 Lines 268516 270828 +2312 Branches 27812 28019 +207 ==========================================
+ Hits 185451 186619 +1168 - Misses 75902 77004 +1102 - Partials 7163 7205 +42 
FlagCoverage Δ
Debug68.90% <50.28%> (-0.16%)⬇️
production63.43% <41.62%> (-0.22%)⬇️
test89.02% <95.60%> (+0.06%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...crosoft.ML.GenAI.Core/Extension/ModuleExtension.cs54.22% <100.00%> (ø)
src/Microsoft.ML.GenAI.Core/Module/GenAILinear.cs100.00% <100.00%> (ø)
....ML.GenAI.Phi/Extension/SemanticKernelExtension.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi2/Phi2TokenizerHelper.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi3/Phi3TokenizerHelper.cs100.00% <100.00%> (ø)
test/Microsoft.ML.GenAI.Phi.Tests/AutoGenTests.cs100.00% <100.00%> (ø)
...icrosoft.ML.GenAI.Phi.Tests/SemanticKernelTests.cs100.00% <100.00%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi2/Config.cs98.00% <98.00%> (ø)
...rosoft.ML.GenAI.Core.Tests/QuantizedLinearTests.cs95.52% <95.52%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi3/Config.cs93.84% <93.84%> (ø)
... and 25 more
... and 38 files with indirect coverage changes
@LittleLittleCloud
LittleLittleCloud
merged commit 6d1f7e2
into
dotnet:mainJul 30, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 30, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh left review comments
@ericstjericstjAwaiting requested review from ericstj

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LittleLittleCloudLittleLittleCloud

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@LittleLittleCloud@luisquintanilla@tarekgh@michaelgsharp

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add Microsoft.ML.GenAI.Phi, test package and sample project. - #7184
Merged
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Jul 30, 2024
Merged
Add Microsoft.ML.GenAI.Phi, test package and sample project.#7184
LittleLittleCloud merged 43 commits into
dotnet:mainfrom 
LittleLittleCloud:u/xiaoyun/phi
Conversation
@LittleLittleCloud
@LittleLittleCloudLittleLittleCloud
commented
Jun 28, 2024•

edited

Loading

Copy link


Copy Markdown

Member
We are excited to review your PR.
So we can do the best job, please check:
  •  There's a descriptive title that will make sense to other developers some time from now.
  •  There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  •  Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  •  You have included any necessary tests in the same PR.
#7169
@LittleLittleCloudLittleLittleCloud
mentioned this pull request
Jun 28, 2024

Open

13 tasks
LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

LittleLittleCloud
LittleLittleCloud
commented
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

tarekgh
tarekgh
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.Tokenizers/Tokenizer.cs
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Open

3 tasks
@azure-pipelines
azure-pipelinesBot
commented
Jul 19, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
Outdated

tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Phi/Phi3/Phi3Tokenzier.cs
@luisquintanilla
luisquintanilla
commented
Jul 22, 2024

Copy link


Copy Markdown

Contributor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
tarekgh
tarekgh
reviewed
Jul 22, 2024
View reviewed changes
Comment threadsrc/Microsoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs

 return tokens
 .Where(t => t.Offset != (0, 0))
 .Select(t => t.Id)
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this for?
@LittleLittleCloudLittleLittleCloudJul 22, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To detect the _ token automatically added by tokenzier
@tarekghtarekghJul 22, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks. it is worth a comment.
Also, EncodeToToken is very expensive comparing to EncodeToIds. If you are interested to optimize I can suggest some code to check for _  token.
@LittleLittleCloudLittleLittleCloudJul 23, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be very helpful
@LittleLittleCloud
LittleLittleCloud
commented
Jul 23, 2024

Copy link


Copy Markdown

MemberAuthor
@LittleLittleCloud samples look good.
Something we might want to think about is the naming of the SK naming conventions for adding a model to make it more generic.
Similar to:
https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI/blob/6efcbcfbb84c5ecdb5cc31215903b6df13f3f841/OnnxRuntimeGenAIServiceCollectionExtensions.cs#L26
Rename to AddGenAIChatCompletion and AddGenAITextCompletion
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 23, 2024

Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 29, 2024

Open

@LittleLittleCloud
LittleLittleCloud
commented
Jul 30, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 30, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 2 pipeline(s).
@codecov
codecovBot
commented
Jul 30, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.28902% with 774 lines in your changes missing coverage. Please review.
Project coverage is 68.90%. Comparing base (579fe03) to head (a97afdf).

Report is 10 commits behind head on main.
FilesPatch %Lines
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs0.00%98 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Attention.cs25.00%86 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Utils.cs12.94%72 Missing and 2 partials ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi3Model.cs19.04%68 Missing ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Model.cs12.16%65 Missing ⚠️
.../Microsoft.ML.GenAI.Phi/Module/Phi3DecoderLayer.cs16.66%59 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Phi/Module/Phi2Attention.cs32.09%53 Missing and 2 partials ⚠️
...crosoft.ML.GenAI.Phi/Module/Phi3RotaryEmbedding.cs20.00%32 Missing ⚠️
...ML.GenAI.Phi/Module/Phi3SuScaledRotaryEmbedding.cs24.39%31 Missing ⚠️
...c/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMAgent.cs56.71%21 Missing and 8 partials ⚠️
... and 18 more
Additional details and impacted files
@@ Coverage Diff @@## main #7184 +/- ##
==========================================
- Coverage 69.06% 68.90% -0.16% 
==========================================
Files 1401 1441 +40 Lines 268516 270828 +2312 Branches 27812 28019 +207 ==========================================
+ Hits 185451 186619 +1168 - Misses 75902 77004 +1102 - Partials 7163 7205 +42 
FlagCoverage Δ
Debug68.90% <50.28%> (-0.16%)⬇️
production63.43% <41.62%> (-0.22%)⬇️
test89.02% <95.60%> (+0.06%)⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.
FilesCoverage Δ
...crosoft.ML.GenAI.Core/Extension/ModuleExtension.cs54.22% <100.00%> (ø)
src/Microsoft.ML.GenAI.Core/Module/GenAILinear.cs100.00% <100.00%> (ø)
....ML.GenAI.Phi/Extension/SemanticKernelExtension.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi2/Phi2TokenizerHelper.cs100.00% <100.00%> (ø)
...Microsoft.ML.GenAI.Phi/Phi3/Phi3TokenizerHelper.cs100.00% <100.00%> (ø)
test/Microsoft.ML.GenAI.Phi.Tests/AutoGenTests.cs100.00% <100.00%> (ø)
...icrosoft.ML.GenAI.Phi.Tests/SemanticKernelTests.cs100.00% <100.00%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi2/Config.cs98.00% <98.00%> (ø)
...rosoft.ML.GenAI.Core.Tests/QuantizedLinearTests.cs95.52% <95.52%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi3/Config.cs93.84% <93.84%> (ø)
... and 25 more
... and 38 files with indirect coverage changes
@LittleLittleCloud
LittleLittleCloud
merged commit 6d1f7e2
into
dotnet:mainJul 30, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 30, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tarekghtarekghtarekgh left review comments
@ericstjericstjAwaiting requested review from ericstj

+1 more reviewer

@michaelgsharpmichaelgsharpmichaelgsharp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LittleLittleCloudLittleLittleCloud

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@LittleLittleCloud@luisquintanilla@tarekgh@michaelgsharp