[GenAI] Add readme to Microsoft.ML.GenAI.Phi by LittleLittleCloud · Pull Request #7206 · dotnet/machinelearning

LittleLittleCloud · 2024-07-31T19:32:26Z

We are excited to review your PR.

So we can do the best job, please check:

There's a descriptive title that will make sense to other developers some time from now.
There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
You have included any necessary tests in the same PR.

luisquintanilla

Looks great @LittleLittleCloud. Added a few suggestions.

luisquintanilla · 2024-08-05T20:26:14Z

+# Microsoft.ML.GenAI.Phi
+Torchsharp implementation of Microsoft phi-series models for GenAI
+
+## Supported list


For the ones that aren't checked, do we have a path to support them? If not, maybe remove them

Yes, I am working on implementing those models

Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

LittleLittleCloud · 2024-07-31T19:32:26Z

We are excited to review your PR.

So we can do the best job, please check:

There's a descriptive title that will make sense to other developers some time from now.
There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
You have included any necessary tests in the same PR.

luisquintanilla

Looks great @LittleLittleCloud. Added a few suggestions.

luisquintanilla · 2024-08-05T20:26:14Z

+# Microsoft.ML.GenAI.Phi
+Torchsharp implementation of Microsoft phi-series models for GenAI
+
+## Supported list


For the ones that aren't checked, do we have a path to support them? If not, maybe remove them

Yes, I am working on implementing those models

Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

LittleLittleCloud · 2024-07-31T19:32:26Z

We are excited to review your PR.

So we can do the best job, please check:

There's a descriptive title that will make sense to other developers some time from now.
There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
You have included any necessary tests in the same PR.

luisquintanilla

Looks great @LittleLittleCloud. Added a few suggestions.

luisquintanilla · 2024-08-05T20:26:14Z

+# Microsoft.ML.GenAI.Phi
+Torchsharp implementation of Microsoft phi-series models for GenAI
+
+## Supported list


For the ones that aren't checked, do we have a path to support them? If not, maybe remove them

Yes, I am working on implementing those models

Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

LittleLittleCloud · 2024-07-31T19:32:26Z

We are excited to review your PR.

So we can do the best job, please check:

There's a descriptive title that will make sense to other developers some time from now.
There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
You have included any necessary tests in the same PR.

luisquintanilla

Looks great @LittleLittleCloud. Added a few suggestions.

luisquintanilla · 2024-08-05T20:26:14Z

+# Microsoft.ML.GenAI.Phi
+Torchsharp implementation of Microsoft phi-series models for GenAI
+
+## Supported list


For the ones that aren't checked, do we have a path to support them? If not, maybe remove them

Yes, I am working on implementing those models

Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

LittleLittleCloud · 2024-07-31T19:32:26Z

We are excited to review your PR.

So we can do the best job, please check:

There's a descriptive title that will make sense to other developers some time from now.
There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
You have included any necessary tests in the same PR.

luisquintanilla

Looks great @LittleLittleCloud. Added a few suggestions.

luisquintanilla · 2024-08-05T20:26:14Z

+# Microsoft.ML.GenAI.Phi
+Torchsharp implementation of Microsoft phi-series models for GenAI
+
+## Supported list


For the ones that aren't checked, do we have a path to support them? If not, maybe remove them

Yes, I am working on implementing those models

Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

LittleLittleCloud · 2024-07-31T19:32:26Z

We are excited to review your PR.

So we can do the best job, please check:

There's a descriptive title that will make sense to other developers some time from now.
There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
You have included any necessary tests in the same PR.

luisquintanilla

Looks great @LittleLittleCloud. Added a few suggestions.

luisquintanilla · 2024-08-05T20:26:14Z

+# Microsoft.ML.GenAI.Phi
+Torchsharp implementation of Microsoft phi-series models for GenAI
+
+## Supported list


For the ones that aren't checked, do we have a path to support them? If not, maybe remove them

Yes, I am working on implementing those models

Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

LittleLittleCloud · 2024-07-31T19:32:26Z

We are excited to review your PR.

So we can do the best job, please check:

There's a descriptive title that will make sense to other developers some time from now.
There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
You have included any necessary tests in the same PR.

luisquintanilla

Looks great @LittleLittleCloud. Added a few suggestions.

luisquintanilla · 2024-08-05T20:26:14Z

+# Microsoft.ML.GenAI.Phi
+Torchsharp implementation of Microsoft phi-series models for GenAI
+
+## Supported list


For the ones that aren't checked, do we have a path to support them? If not, maybe remove them

Yes, I am working on implementing those models

Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

LittleLittleCloud · 2024-07-31T19:32:26Z

We are excited to review your PR.

So we can do the best job, please check:

There's a descriptive title that will make sense to other developers some time from now.
There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
You have included any necessary tests in the same PR.

luisquintanilla

Looks great @LittleLittleCloud. Added a few suggestions.

luisquintanilla · 2024-08-05T20:26:14Z

+# Microsoft.ML.GenAI.Phi
+Torchsharp implementation of Microsoft phi-series models for GenAI
+
+## Supported list


For the ones that aren't checked, do we have a path to support them? If not, maybe remove them

Yes, I am working on implementing those models

Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

add readme
126d80c

dotnet-policy-serviceBot assigned LittleLittleCloud Jul 31, 2024

LittleLittleCloud mentioned this pull request Jul 31, 2024
Add GenAI packages #7169
Open
13 tasks

luisquintanilla approved these changes Aug 5, 2024
View reviewed changes

LittleLittleCloudand others added 6 commits August 5, 2024 13:33

Update src/Microsoft.ML.GenAI.Phi/README.md
b45eb89
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

Update src/Microsoft.ML.GenAI.Phi/README.md
d1019b8
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

Update src/Microsoft.ML.GenAI.Phi/README.md
3800b14
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

Update src/Microsoft.ML.GenAI.Phi/README.md
e7a51c6
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

Update src/Microsoft.ML.GenAI.Phi/README.md
e2083aa
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

Update src/Microsoft.ML.GenAI.Phi/README.md
cc55546
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>

LittleLittleCloud merged commit 5f5a199 into dotnet:mainAug 5, 2024

github-actionsBot locked and limited conversation to collaborators Sep 6, 2024