Uh oh!
There was an error while loading. Please reload this page.
Update dependencies from maintenance-packages to latest versions - #7301
Merged
Conversation
michaelgsharp
approved these changes
Nov 12, 2024
ContributorAuthor
I am seeing a new failure and it is coming from System.Data.SqlClient (sni.dll not found): |
| private DatabaseSource GetIrisDatabaseSource(string command, int commandTimeoutInSeconds = 30) | ||
| { | ||
| if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) | ||
| #pragma warning disable CS0618 // 'SqlClientFactory' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.' |
ContributorAuthor
There was a problem hiding this comment.
I didn't see this build failure in the previous CI run, but I did hit it in my local machine. If you prefer that I remove these pragmas, let me know, @michaelgsharp .
| <MlNetMklDepsVersion>0.0.0.12</MlNetMklDepsVersion> | ||
| <MicrosoftExtensionsAIVersion>9.0.0-preview.9.24507.7</MicrosoftExtensionsAIVersion> | ||
| <!-- runtime.native.System.Data.SqlClient.sni is not updated by dependency flow as it is not produced live anymore. --> | ||
| <RuntimeNativeSystemDataSqlClientSniVersion>4.4.0</RuntimeNativeSystemDataSqlClientSniVersion> |
ContributorAuthor
There was a problem hiding this comment.
This is what we did in maintenance-packages to fix the same error in the System.Data.SqlClient unit tests.
| <MicrosoftMLOnnxRuntimeVersion>1.18.1</MicrosoftMLOnnxRuntimeVersion> | ||
| <MlNetMklDepsVersion>0.0.0.12</MlNetMklDepsVersion> | ||
| <MicrosoftExtensionsAIVersion>9.0.0-preview.9.24507.7</MicrosoftExtensionsAIVersion> | ||
| <!-- runtime.native.System.Data.SqlClient.sni is not updated by dependency flow as it is not produced live anymore. --> |
ContributorAuthor
There was a problem hiding this comment.
We have a similar comment in maintenance-packages, but we actually indicate this package's version in Directory.Packages.props (we don't have that here). So I thought it could be useful to have the same comment here, as a reminder that this version won't automatically change.
This was referenced Nov 12, 2024
Open
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #7301 +/- ##
==========================================
+ Coverage 68.87% 68.88% +0.01%
==========================================
Files 1470 1470 Lines 274005 274005 Branches 28403 28403 ==========================================
+ Hits 188725 188756 +31 + Misses 77962 77932 -30 + Partials 7318 7317 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michaelgsharp
commented
Nov 12, 2024
Contributor
Merging on red since the only test failures are known test failures and we don't have the repo set up correctly for Build Analysis to be able to bypass it. |
ericstj
commented
Nov 12, 2024
Member
We should remove that reference to SNI. Right fix is here: dotnet/maintenance-packages#169 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest prerelease versions can be found here: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries
Tomorrow we can update to the stable versions after they get published to nuget.