Uh oh!
There was an error while loading. Please reload this page.
Fix local build on linux that was omiting arch argument - #7549
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR sets a default architecture for the native build script, addressing an issue where the build architecture variable was previously uninitialized.
- Sets
__build_archdefault tox64instead of leaving it empty
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ericstj
commented
Nov 10, 2025
The script you are modifying is the native build script, it's always run by specifying architecture when called by msbuild -- https://github.com/dotnet/machinelearning/blob/0a7a0291fc04e4356dab25c614c43fad524b8e9f/src/Native/Native.proj#L101C60-L101C78 Were you making this change to improve the experience when a user directly tries to build just the native portion? I'm double-checking that you weren't trying to fix the top-level build script. That one is here -- https://github.com/dotnet/machinelearning/blob/main/build.sh |
ericstj
left a comment
There was a problem hiding this comment.
This is fine to improve the experience around directly building native portion. LMK if you were having an issue with root-build, in which case we might need to see what's going on there.
The root build will need to know the architecture, so that it can consume the native outputs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #7549 +/- ##
=======================================
Coverage 69.01% 69.02% =======================================
Files 1482 1482 Lines 274093 274093 Branches 28266 28266 =======================================
+ Hits 189176 189199 +23 + Misses 77531 77513 -18 + Partials 7386 7381 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ManickaP
commented
Nov 10, 2025
I see. But still, this makes it on-par with Windows, so let's keep it. |
ManickaP
commented
Nov 10, 2025
The errors are: dotnet/dnceng#5015 |
For comparison see Windows build defaults:
machinelearning/src/Native/build.cmd
Line 17 in 0a7a029