Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.9k
Tree estimators#855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Tree estimators #855
Changes from all commits
cbd84ab0f68992c76285c13a187e8e76ef1e5f8925f2410a6574b9d24b3da6663e63d50cccda55073a90edc39d566eaf762d8b525df5449ae770ddce8fb0487ce1bd3File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -57,7 +57,7 @@ public Arguments() | ||
| env => new Ova(env, new Ova.Arguments() | ||
| { | ||
| PredictorType = ComponentFactoryUtils.CreateFromFunction( | ||
| e => new AveragedPerceptronTrainer(e, new AveragedPerceptronTrainer.Arguments())) | ||
| e => new FastTreeBinaryClassificationTrainer(e, DefaultColumnNames.Label, DefaultColumnNames.Features)) | ||
| ||
| })); | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the reason why we have two types that are identical in practically everything but name, so we can identify ranking estimators vs. regression estimators in a statically typed way?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this transformer should also expose the group ID column name, at least that would be my belief
In reply to: 218214277 [](ancestors = 218214277)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually thought about this, like labels group ids are only needed for training, right? So for prediction I don't think they should be.
In reply to: 218216192 [](ancestors = 218216192,218214277)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So keep it, or make the Regression one Generic and use it for both?
In reply to: 218216839 [](ancestors = 218216839,218216192,218214277)