Wasm/WASI tasks spec by JanProvaznik · Pull Request #10259 · dotnet/msbuild

JanProvaznik · 2024-06-18T14:43:23Z

This is a PR for the proposed WASI-Build feature spec, only documentation

WIP implementation: https://github.com/JanProvaznik/MSBuildWasm

rainersigwald

Hey, I've got LOTS of comments here but this is great progress and I'm getting even more excited about the project. Feel free to reach out to discuss anything.

clarify spec, update with info about communication between host and tasks

attempted implementation

YuliiaKovalova

Looks good to me, some small comments to consider

rainersigwald

Loving it!

rainersigwald · 2024-07-25T22:28:05Z

@lambdageek @lewing y'all might be interested in this project.

formatting

format and fix WIT so it can generate bindings

initial spec background and context
c1a00ca

JanProvaznik added Area: Tasks Issues impacting the tasks shipped in Microsoft.Build.Tasks.Core.dll. WIP labels Jun 18, 2024

JanProvaznik self-assigned this Jun 18, 2024

JanProvaznik added the Disabled-Tests label Jun 18, 2024

update spec with findings, interpretations, questions
104218b

rainersigwald reviewed Jun 20, 2024
View reviewed changes

JanProvaznik changed the base branch from main to feature/wasi-tasksJune 20, 2024 14:49

JanProvaznikand others added 2 commits June 20, 2024 18:19

ascertain goals, address feedback
8685c1f

Update spec with details after experiments in the ecosystem
e951885

YuliiaKovalova reviewed Jun 27, 2024
View reviewed changes

Comment threaddocumentation/specs/proposed/WASI-tasks.md Outdated
Comment threaddocumentation/specs/proposed/WASI-tasks.md Outdated
Comment threaddocumentation/specs/proposed/WASI-tasks.md Outdated

JanProvaznik added 2 commits July 1, 2024 18:32

add API specification in WIT
4e4aeff
clarify spec, update with info about communication between host and tasks

rename to Wasm-tasks
42d1f06

JanProvaznik changed the title ~~WASI-Build spec~~Wasm-Build specJul 1, 2024

JanProvaznik mentioned this pull request Jul 2, 2024
Implement WasmTask via TaskFactory JanProvaznik/MSBuildWasm#5
Closed

update spec with better understanding of Wasm, and lessons from
f8541c3
attempted implementation

JanProvaznik changed the title ~~Wasm-Build spec~~Wasm/WASI tasks specJul 12, 2024

JanProvaznik requested review from baronfel and rainersigwald July 12, 2024 16:06

JanProvaznik removed the WIP label Jul 15, 2024

JanProvaznik marked this pull request as ready for review July 15, 2024 13:00

JanProvaznik changed the base branch from feature/wasi-tasks to mainJuly 15, 2024 13:00

YuliiaKovalova approved these changes Jul 15, 2024
View reviewed changes

address comments
89fe997

JanProvaznik force-pushed the dev/janpro/wasi-tasks-spec branch from a19d9b5 to 89fe997Compare July 17, 2024 11:23

JanProvaznik added 2 commits July 17, 2024 13:24

fix details about logging
fbf0267

update with communication details, WASIp1/p2 diff
7aba7ab

rainersigwald approved these changes Jul 25, 2024
View reviewed changes

Comment threaddocumentation/specs/proposed/Wasm-tasks.md Outdated
Comment threaddocumentation/specs/proposed/Wasm-tasks.md Outdated
Comment threaddocumentation/specs/proposed/Wasm-tasks.md Outdated
Comment threaddocumentation/specs/proposed/wasmtask.wit Outdated

update proposed WIT
8575218
formatting

clarify diagram
40fc346

rainersigwald reviewed Jul 26, 2024
View reviewed changes

Comment threaddocumentation/specs/proposed/wasmtask.wit Outdated

cataggar reviewed Jul 28, 2024
View reviewed changes