Uh oh!
There was an error while loading. Please reload this page.
Add performance test for XmlSerializationWriter.WriteTypedPrimitive - #2623
Add performance test for XmlSerializationWriter.WriteTypedPrimitive#2623TrayanZapryanov wants to merge 5 commits into
Conversation
TrayanZapryanov
commented
Sep 30, 2022
Hmmm, strange exception. [2022/09/30 11:29:37][INFO] // BeforeActualRun |
| private readonly MyXmlSerializationWriter _writer = new MyXmlSerializationWriter(); | ||
| private static readonly DateTime Now = new DateTime(2022, 9, 30, 9, 4, 15, DateTimeKind.Utc); |
There was a problem hiding this comment.
I think these shouldn't be static readonly in order to prevent some JIT optimization that otherwise may occur, and to have the benchmarks more realistic (i.e. non constant inputs).
Uh oh!
There was an error while loading. Please reload this page.
TrayanZapryanov
commented
Oct 2, 2022
I receive some warning at the end : // * Warnings * What should I change to solve it ? |
Benchmark used in dotnet/runtime#76436
Maybe merge can wait until owners agree that it is good optimization and deserves benchmark.