Uh oh!
There was an error while loading. Please reload this page.
Add Maui Mobile Testing to the perf repo (port from release/7.0 Test) - #2813
Merged
Conversation
LoopedBard3force-pushed
the
AddMauiMobileTestingMain
branch
28 times, most recently
from
January 5, 2023 23:26
21a8c58 to
7b55f8fCompareLoopedBard3force-pushed
the
AddMauiMobileTestingMain
branch
4 times, most recently
from
January 9, 2023 18:28
cdbe01f to
7c90323CompareLoopedBard3
commented
Jan 9, 2023
MemberAuthor
Test run with the Maui run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2083511&view=results |
LoopedBard3force-pushed
the
AddMauiMobileTestingMain
branch
from
January 9, 2023 23:37
5f8024f to
f398728CompareLoopedBard3
marked this pull request as ready for review
January 10, 2023 21:38
…ng). Move maui android scenario yml template to the correct place. (Private runs) specify that it is the dotnet packs we are removing from the correlation staging Testing the passing of links for the dotnet version. Add rollback file for installing the maui workload on .Net versions 8 and up, and update output dir functionality to work when it is not included.
LoopedBard3force-pushed
the
AddMauiMobileTestingMain
branch
from
January 17, 2023 19:17
0915880 to
0ef1134CompareUh oh!
There was an error while loading. Please reload this page.
…and, and strip the getActivity output to fix error with the activity name.
LoopedBard3
commented
Jan 18, 2023
MemberAuthor
cincuranet
approved these changes
Jan 18, 2023
cincuranet
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Only minor observations, I'll leave that to your discretion.
| setup_loggers(True) | ||
| precommands = PreCommands() | ||
| target_framework_wo_platform = precommands.framework.split('-')[0] |
Contributor
There was a problem hiding this comment.
Could this be, maybe, extracted and reused? Just in case we ever need to change the logic.
| workload_install_args += ['--from-rollback-file', f'https://aka.ms/dotnet/maui/{target_framework_wo_platform}.json'] | ||
| precommands.install_workload('maui', workload_install_args) | ||
| precommands.existing(projectdir='./dotnet-podcasts',projectfile='./src/Mobile/Microsoft.NetConf2021.Maui.csproj') |
Contributor
There was a problem hiding this comment.
nit: Missing space before projectfile.
| # Download what we need | ||
| with open ("MauiNuGet.config", "wb") as f: | ||
| f.write(requests.get(f'https://raw.githubusercontent.com/dotnet/maui/{target_framework_wo_platform}/NuGet.config', allow_redirects=True).content) |
Contributor
There was a problem hiding this comment.
Maybe this could be "maui" helper as well...
MemberAuthor
There was a problem hiding this comment.
Combined this with the target_framework_wo_platform line making a single install_versioned_maui method.
| if __name__ == "__main__": | ||
| if __name__ == "__main__": | ||
| versionsreadjsonfilesaveenv(rf".\{PUBDIR}\versions.json") |
Contributor
There was a problem hiding this comment.
Probably better to follow "standard" naming conventions and use _ in the method name.
| if "PERFLAB_INLAB" in os.environ and os.environ["PERFLAB_INLAB"] == "1": | ||
| os.remove(inputfile) | ||
| def GetVersionFromDllPowershell(dll_path: str): |
Contributor
There was a problem hiding this comment.
Name should be Python-like. You probably had brain in PS mode. :)
| { | ||
| build.AdditionalData["mauiVersion"] = environment.GetEnvironmentVariable("MAUI_VERSION"); | ||
| } | ||
| foreach (DictionaryEntry entry in environment.GetEnvironmentVariables()){ |
…sc spacing, and consolidating reused maui methods into mauisharedpython. Also moved mauisharedpython from its own folder to the general shared folder since it was the only file in the maui specific shared folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables android mobile testing for Maui in the performance pipeline. This includes adding the scenarios for the Maui runs, adding some version passing capabilities, and a working queue for the runs. The first version of this is #2789, with some main branch specific changes made.
This also includes the updates made to dotnet.py to make getting the commit datetime more resilient, and changes to how _Version environment variables are saved such that they are added dynamically.