Uh oh!
There was an error while loading. Please reload this page.
Removed failing System.Drawing tests from net8.0+ runs. - #2936
Merged
LoopedBard3 merged 3 commits intoMar 21, 2023
Merged
Conversation
LoopedBard3
requested review from
adamsitnik, caaavik-msft, cincuranet and sblomMarch 21, 2023 17:47
cincuranet
approved these changes
Mar 21, 2023
LoopedBard3
enabled auto-merge (squash)
March 21, 2023 19:16
5 tasks
LoopedBard3
disabled auto-merge
March 21, 2023 20:28
LoopedBard3
commented
Mar 21, 2023
MemberAuthor
Failing run is failing on main and due to unrelated changes, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2931.
System.Drawing tests recently started failing because the runtime library code was moved out of the runtime: dotnet/runtime#83356. This PR removes the tests that broke from this change from net8.0+ runs.
Here is a net8.0 test run showing it fixed the windows runs: https://dev.azure.com/dnceng/internal/_build/results?buildId=2139959&view=results