add TryGetValue_False_FrozenDictionary benchmark - #3432

Merged
cincuranet merged 1 commit into
dotnet:mainfrom
adamsitnik:keyNotFound
Nov 29, 2023
Merged

add TryGetValue_False_FrozenDictionary benchmark#3432
cincuranet merged 1 commit into
dotnet:mainfrom
adamsitnik:keyNotFound

Conversation

@adamsitnik

@adamsitnikadamsitnik commented Oct 20, 2023

Copy link
Copy Markdown
Member

No description provided.

@adamsitnikadamsitnik mentioned this pull request Oct 20, 2023
Merged
andrewjsaid
andrewjsaid reviewed Oct 21, 2023
View reviewed changes
Comment threadsrc/benchmarks/micro/libraries/System.Collections/Frozen/Perf_FrozenDictionary_String.cs
? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 25, maxLength: 25)
: ValuesGenerator.ArrayOfUniqueValues<string>(Count);

? ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 25, maxLength: 25)

@andrewjsaidandrewjsaidOct 21, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding a new case for 20 items designed to benchmark the length optimizations.

 // bimodal distribution of lengths with some search strings outside bounds of the keys
: Count == 20 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 10, maxLength: 12)
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 18, maxLength: 20))
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 5, maxLength: 25)).ToArray()

I ran the benchmarks against 3 versions of .NET runtime.
main - main branch as of yesterday
nolength - I removed the existing if ((uint)(key.Length - _minimumLength) <= (uint)_maximumLengthDiff) check for comparison's sake
pr92546 - dotnet/runtime#92546 which adds a new length filter

Here are the results:

// * Summary *
BenchmarkDotNet v0.13.7-nightly.20230717.35, Windows 11 (10.0.22621.2428/22H2/2022Update/SunValley2)
AMD Ryzen 9 5950X, 1 CPU, 32 logical and 16 physical cores
.NET SDK 8.0.100-rc.1.23463.5
[Host] : .NET 8.0.0 (8.0.23.41904), X64 RyuJIT AVX2
Job-DLBUBA : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-LYUJAP : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-EJCRGQ : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
PowerPlanMode=00000000-0000-0000-0000-000000000000 Arguments=/p:EnableUnsafeBinaryFormatterSerialization=true IterationTime=250.0000 ms MaxIterationCount=20 MinIterationCount=15 WarmupCount=1 | Method | Job | ... Toolchain | Count | Mean | Error | StdDev | Median | Min | Max | Ratio | RatioSD | Allocated | Alloc Ratio |
|----------------------------------- |----------- |-------------------------...------------ |------ |--------------:|-------------:|-------------:|--------------:|--------------:|--------------:|------:|--------:|----------:|------------:|
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10 | 22.72 ns | 0.177 ns | 0.165 ns | 22.78 ns | 22.31 ns | 22.89 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10 | 22.04 ns | 0.746 ns | 0.829 ns | 21.67 ns | 21.03 ns | 23.72 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10 | 24.14 ns | 0.305 ns | 0.285 ns | 24.19 ns | 23.61 ns | 24.53 ns | 1.06 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 20 | 37.76 ns | 0.761 ns | 0.747 ns | 37.59 ns | 36.78 ns | 39.03 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 20 | 79.91 ns | 1.291 ns | 1.207 ns | 79.65 ns | 78.42 ns | 82.54 ns | 2.12 | 0.06 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 20 | 21.93 ns | 0.449 ns | 0.441 ns | 21.80 ns | 21.51 ns | 23.26 ns | 0.58 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 100 | 716.16 ns | 5.014 ns | 4.187 ns | 716.11 ns | 710.24 ns | 725.50 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 100 | 686.85 ns | 4.755 ns | 4.448 ns | 686.33 ns | 678.03 ns | 694.17 ns | 0.96 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 100 | 561.36 ns | 3.986 ns | 3.728 ns | 562.77 ns | 555.22 ns | 567.82 ns | 0.78 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 1000 | 7,837.84 ns | 49.749 ns | 46.535 ns | 7,815.30 ns | 7,781.38 ns | 7,899.49 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 1000 | 7,701.66 ns | 7.215 ns | 6.749 ns | 7,700.41 ns | 7,692.06 ns | 7,714.71 ns | 0.98 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 1000 | 7,936.08 ns | 49.304 ns | 46.119 ns | 7,957.89 ns | 7,838.63 ns | 7,987.06 ns | 1.01 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10000 | 140,558.00 ns | 4,053.557 ns | 4,668.082 ns | 138,462.17 ns | 135,838.37 ns | 148,890.43 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10000 | 136,547.30 ns | 1,650.734 ns | 1,544.097 ns | 136,678.12 ns | 134,415.09 ns | 139,203.45 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10000 | 139,220.39 ns | 850.721 ns | 795.765 ns | 139,317.75 ns | 137,574.00 ns | 140,382.59 ns | 0.99 | 0.04 | - | NA |

I believe the new Count = 20 scenario case showcases both the existing optimization (without PR92546), with the ratio going from 2.12 (optimization removed) -> 1 (main), as well as the proposed optimization in PR92546 with the ratio improving from 1 to 0.58.

Although the effects of PR92546 are also visible in the Count=100 scenario, I would argue that testing strings with lengths outside the bounds of the key strings is an important benchmark to keep.

@andrewjsaidandrewjsaid mentioned this pull request Oct 26, 2023
Closed
@cincuranet

cincuranet commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

Merging this as is. I see dotnet/runtime#92546 still open. @andrewjsaid if/when it's merged, feel free to update the benchmarks.

@cincuranet
cincuranet merged commit 21bc5c2 into dotnet:mainNov 29, 2023
@cincuranetcincuranet self-assigned this Nov 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentoubstephentoubAwaiting requested review from stephentoub
@cincuranetcincuranetAwaiting requested review from cincuranet
1 more reviewer
@andrewjsaidandrewjsaidandrewjsaid left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@cincuranetcincuranet

Labels

adds new benchmarks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamsitnik@cincuranet@andrewjsaid
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
add TryGetValue_False_FrozenDictionary benchmark - #3432
Merged
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Nov 29, 2023
Merged
add TryGetValue_False_FrozenDictionary benchmark#3432
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Conversation
@adamsitnik
@adamsitnikadamsitnik
commented
Oct 20, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@adamsitnikadamsitnik
mentioned this pull request
Oct 20, 2023
 Merged

andrewjsaid
andrewjsaid
reviewed
Oct 21, 2023
View reviewed changes
Comment threadsrc/benchmarks/micro/libraries/System.Collections/Frozen/Perf_FrozenDictionary_String.cs
 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 25, maxLength: 25)
 : ValuesGenerator.ArrayOfUniqueValues<string>(Count);

 ? ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 25, maxLength: 25)
@andrewjsaidandrewjsaidOct 21, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding a new case for 20 items designed to benchmark the length optimizations.
 // bimodal distribution of lengths with some search strings outside bounds of the keys
: Count == 20 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 10, maxLength: 12)
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 18, maxLength: 20))
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 5, maxLength: 25)).ToArray()

I ran the benchmarks against 3 versions of .NET runtime.
main - main branch as of yesterday
nolength - I removed the existing if ((uint)(key.Length - _minimumLength) <= (uint)_maximumLengthDiff) check for comparison's sake
pr92546 - dotnet/runtime#92546 which adds a new length filter
Here are the results:
// * Summary *
BenchmarkDotNet v0.13.7-nightly.20230717.35, Windows 11 (10.0.22621.2428/22H2/2022Update/SunValley2)
AMD Ryzen 9 5950X, 1 CPU, 32 logical and 16 physical cores
.NET SDK 8.0.100-rc.1.23463.5
[Host] : .NET 8.0.0 (8.0.23.41904), X64 RyuJIT AVX2
Job-DLBUBA : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-LYUJAP : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-EJCRGQ : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
PowerPlanMode=00000000-0000-0000-0000-000000000000 Arguments=/p:EnableUnsafeBinaryFormatterSerialization=true IterationTime=250.0000 ms MaxIterationCount=20 MinIterationCount=15 WarmupCount=1 | Method | Job | ... Toolchain | Count | Mean | Error | StdDev | Median | Min | Max | Ratio | RatioSD | Allocated | Alloc Ratio |
|----------------------------------- |----------- |-------------------------...------------ |------ |--------------:|-------------:|-------------:|--------------:|--------------:|--------------:|------:|--------:|----------:|------------:|
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10 | 22.72 ns | 0.177 ns | 0.165 ns | 22.78 ns | 22.31 ns | 22.89 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10 | 22.04 ns | 0.746 ns | 0.829 ns | 21.67 ns | 21.03 ns | 23.72 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10 | 24.14 ns | 0.305 ns | 0.285 ns | 24.19 ns | 23.61 ns | 24.53 ns | 1.06 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 20 | 37.76 ns | 0.761 ns | 0.747 ns | 37.59 ns | 36.78 ns | 39.03 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 20 | 79.91 ns | 1.291 ns | 1.207 ns | 79.65 ns | 78.42 ns | 82.54 ns | 2.12 | 0.06 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 20 | 21.93 ns | 0.449 ns | 0.441 ns | 21.80 ns | 21.51 ns | 23.26 ns | 0.58 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 100 | 716.16 ns | 5.014 ns | 4.187 ns | 716.11 ns | 710.24 ns | 725.50 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 100 | 686.85 ns | 4.755 ns | 4.448 ns | 686.33 ns | 678.03 ns | 694.17 ns | 0.96 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 100 | 561.36 ns | 3.986 ns | 3.728 ns | 562.77 ns | 555.22 ns | 567.82 ns | 0.78 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 1000 | 7,837.84 ns | 49.749 ns | 46.535 ns | 7,815.30 ns | 7,781.38 ns | 7,899.49 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 1000 | 7,701.66 ns | 7.215 ns | 6.749 ns | 7,700.41 ns | 7,692.06 ns | 7,714.71 ns | 0.98 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 1000 | 7,936.08 ns | 49.304 ns | 46.119 ns | 7,957.89 ns | 7,838.63 ns | 7,987.06 ns | 1.01 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10000 | 140,558.00 ns | 4,053.557 ns | 4,668.082 ns | 138,462.17 ns | 135,838.37 ns | 148,890.43 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10000 | 136,547.30 ns | 1,650.734 ns | 1,544.097 ns | 136,678.12 ns | 134,415.09 ns | 139,203.45 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10000 | 139,220.39 ns | 850.721 ns | 795.765 ns | 139,317.75 ns | 137,574.00 ns | 140,382.59 ns | 0.99 | 0.04 | - | NA |

I believe the new Count = 20 scenario case showcases both the existing optimization (without PR92546), with the ratio going from 2.12 (optimization removed) -> 1 (main), as well as the proposed optimization in PR92546 with the ratio improving from 1 to 0.58.
Although the effects of PR92546 are also visible in the Count=100 scenario, I would argue that testing strings with lengths outside the bounds of the key strings is an important benchmark to keep.
@andrewjsaidandrewjsaid
mentioned this pull request
Oct 26, 2023
 Closed

@cincuranet
cincuranet
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
Merging this as is. I see dotnet/runtime#92546 still open. @andrewjsaid if/when it's merged, feel free to update the benchmarks.
@cincuranet
cincuranet
merged commit 21bc5c2
into
dotnet:mainNov 29, 2023
@cincuranetcincuranet
self-assigned this
Nov 29, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@stephentoubstephentoubAwaiting requested review from stephentoub
@cincuranetcincuranetAwaiting requested review from cincuranet

1 more reviewer

@andrewjsaidandrewjsaidandrewjsaid left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@cincuranetcincuranet

Labels

adds new benchmarks

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@adamsitnik@cincuranet@andrewjsaid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
add TryGetValue_False_FrozenDictionary benchmark - #3432
Merged
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Nov 29, 2023
Merged
add TryGetValue_False_FrozenDictionary benchmark#3432
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Conversation
@adamsitnik
@adamsitnikadamsitnik
commented
Oct 20, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@adamsitnikadamsitnik
mentioned this pull request
Oct 20, 2023
 Merged

andrewjsaid
andrewjsaid
reviewed
Oct 21, 2023
View reviewed changes
Comment threadsrc/benchmarks/micro/libraries/System.Collections/Frozen/Perf_FrozenDictionary_String.cs
 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 25, maxLength: 25)
 : ValuesGenerator.ArrayOfUniqueValues<string>(Count);

 ? ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 25, maxLength: 25)
@andrewjsaidandrewjsaidOct 21, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding a new case for 20 items designed to benchmark the length optimizations.
 // bimodal distribution of lengths with some search strings outside bounds of the keys
: Count == 20 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 10, maxLength: 12)
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 18, maxLength: 20))
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 5, maxLength: 25)).ToArray()

I ran the benchmarks against 3 versions of .NET runtime.
main - main branch as of yesterday
nolength - I removed the existing if ((uint)(key.Length - _minimumLength) <= (uint)_maximumLengthDiff) check for comparison's sake
pr92546 - dotnet/runtime#92546 which adds a new length filter
Here are the results:
// * Summary *
BenchmarkDotNet v0.13.7-nightly.20230717.35, Windows 11 (10.0.22621.2428/22H2/2022Update/SunValley2)
AMD Ryzen 9 5950X, 1 CPU, 32 logical and 16 physical cores
.NET SDK 8.0.100-rc.1.23463.5
[Host] : .NET 8.0.0 (8.0.23.41904), X64 RyuJIT AVX2
Job-DLBUBA : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-LYUJAP : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-EJCRGQ : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
PowerPlanMode=00000000-0000-0000-0000-000000000000 Arguments=/p:EnableUnsafeBinaryFormatterSerialization=true IterationTime=250.0000 ms MaxIterationCount=20 MinIterationCount=15 WarmupCount=1 | Method | Job | ... Toolchain | Count | Mean | Error | StdDev | Median | Min | Max | Ratio | RatioSD | Allocated | Alloc Ratio |
|----------------------------------- |----------- |-------------------------...------------ |------ |--------------:|-------------:|-------------:|--------------:|--------------:|--------------:|------:|--------:|----------:|------------:|
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10 | 22.72 ns | 0.177 ns | 0.165 ns | 22.78 ns | 22.31 ns | 22.89 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10 | 22.04 ns | 0.746 ns | 0.829 ns | 21.67 ns | 21.03 ns | 23.72 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10 | 24.14 ns | 0.305 ns | 0.285 ns | 24.19 ns | 23.61 ns | 24.53 ns | 1.06 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 20 | 37.76 ns | 0.761 ns | 0.747 ns | 37.59 ns | 36.78 ns | 39.03 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 20 | 79.91 ns | 1.291 ns | 1.207 ns | 79.65 ns | 78.42 ns | 82.54 ns | 2.12 | 0.06 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 20 | 21.93 ns | 0.449 ns | 0.441 ns | 21.80 ns | 21.51 ns | 23.26 ns | 0.58 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 100 | 716.16 ns | 5.014 ns | 4.187 ns | 716.11 ns | 710.24 ns | 725.50 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 100 | 686.85 ns | 4.755 ns | 4.448 ns | 686.33 ns | 678.03 ns | 694.17 ns | 0.96 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 100 | 561.36 ns | 3.986 ns | 3.728 ns | 562.77 ns | 555.22 ns | 567.82 ns | 0.78 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 1000 | 7,837.84 ns | 49.749 ns | 46.535 ns | 7,815.30 ns | 7,781.38 ns | 7,899.49 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 1000 | 7,701.66 ns | 7.215 ns | 6.749 ns | 7,700.41 ns | 7,692.06 ns | 7,714.71 ns | 0.98 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 1000 | 7,936.08 ns | 49.304 ns | 46.119 ns | 7,957.89 ns | 7,838.63 ns | 7,987.06 ns | 1.01 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10000 | 140,558.00 ns | 4,053.557 ns | 4,668.082 ns | 138,462.17 ns | 135,838.37 ns | 148,890.43 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10000 | 136,547.30 ns | 1,650.734 ns | 1,544.097 ns | 136,678.12 ns | 134,415.09 ns | 139,203.45 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10000 | 139,220.39 ns | 850.721 ns | 795.765 ns | 139,317.75 ns | 137,574.00 ns | 140,382.59 ns | 0.99 | 0.04 | - | NA |

I believe the new Count = 20 scenario case showcases both the existing optimization (without PR92546), with the ratio going from 2.12 (optimization removed) -> 1 (main), as well as the proposed optimization in PR92546 with the ratio improving from 1 to 0.58.
Although the effects of PR92546 are also visible in the Count=100 scenario, I would argue that testing strings with lengths outside the bounds of the key strings is an important benchmark to keep.
@andrewjsaidandrewjsaid
mentioned this pull request
Oct 26, 2023
 Closed

@cincuranet
cincuranet
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
Merging this as is. I see dotnet/runtime#92546 still open. @andrewjsaid if/when it's merged, feel free to update the benchmarks.
@cincuranet
cincuranet
merged commit 21bc5c2
into
dotnet:mainNov 29, 2023
@cincuranetcincuranet
self-assigned this
Nov 29, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@stephentoubstephentoubAwaiting requested review from stephentoub
@cincuranetcincuranetAwaiting requested review from cincuranet

1 more reviewer

@andrewjsaidandrewjsaidandrewjsaid left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@cincuranetcincuranet

Labels

adds new benchmarks

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@adamsitnik@cincuranet@andrewjsaid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
add TryGetValue_False_FrozenDictionary benchmark - #3432
Merged
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Nov 29, 2023
Merged
add TryGetValue_False_FrozenDictionary benchmark#3432
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Conversation
@adamsitnik
@adamsitnikadamsitnik
commented
Oct 20, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@adamsitnikadamsitnik
mentioned this pull request
Oct 20, 2023
 Merged

andrewjsaid
andrewjsaid
reviewed
Oct 21, 2023
View reviewed changes
Comment threadsrc/benchmarks/micro/libraries/System.Collections/Frozen/Perf_FrozenDictionary_String.cs
 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 25, maxLength: 25)
 : ValuesGenerator.ArrayOfUniqueValues<string>(Count);

 ? ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 25, maxLength: 25)
@andrewjsaidandrewjsaidOct 21, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding a new case for 20 items designed to benchmark the length optimizations.
 // bimodal distribution of lengths with some search strings outside bounds of the keys
: Count == 20 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 10, maxLength: 12)
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 18, maxLength: 20))
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 5, maxLength: 25)).ToArray()

I ran the benchmarks against 3 versions of .NET runtime.
main - main branch as of yesterday
nolength - I removed the existing if ((uint)(key.Length - _minimumLength) <= (uint)_maximumLengthDiff) check for comparison's sake
pr92546 - dotnet/runtime#92546 which adds a new length filter
Here are the results:
// * Summary *
BenchmarkDotNet v0.13.7-nightly.20230717.35, Windows 11 (10.0.22621.2428/22H2/2022Update/SunValley2)
AMD Ryzen 9 5950X, 1 CPU, 32 logical and 16 physical cores
.NET SDK 8.0.100-rc.1.23463.5
[Host] : .NET 8.0.0 (8.0.23.41904), X64 RyuJIT AVX2
Job-DLBUBA : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-LYUJAP : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-EJCRGQ : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
PowerPlanMode=00000000-0000-0000-0000-000000000000 Arguments=/p:EnableUnsafeBinaryFormatterSerialization=true IterationTime=250.0000 ms MaxIterationCount=20 MinIterationCount=15 WarmupCount=1 | Method | Job | ... Toolchain | Count | Mean | Error | StdDev | Median | Min | Max | Ratio | RatioSD | Allocated | Alloc Ratio |
|----------------------------------- |----------- |-------------------------...------------ |------ |--------------:|-------------:|-------------:|--------------:|--------------:|--------------:|------:|--------:|----------:|------------:|
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10 | 22.72 ns | 0.177 ns | 0.165 ns | 22.78 ns | 22.31 ns | 22.89 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10 | 22.04 ns | 0.746 ns | 0.829 ns | 21.67 ns | 21.03 ns | 23.72 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10 | 24.14 ns | 0.305 ns | 0.285 ns | 24.19 ns | 23.61 ns | 24.53 ns | 1.06 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 20 | 37.76 ns | 0.761 ns | 0.747 ns | 37.59 ns | 36.78 ns | 39.03 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 20 | 79.91 ns | 1.291 ns | 1.207 ns | 79.65 ns | 78.42 ns | 82.54 ns | 2.12 | 0.06 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 20 | 21.93 ns | 0.449 ns | 0.441 ns | 21.80 ns | 21.51 ns | 23.26 ns | 0.58 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 100 | 716.16 ns | 5.014 ns | 4.187 ns | 716.11 ns | 710.24 ns | 725.50 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 100 | 686.85 ns | 4.755 ns | 4.448 ns | 686.33 ns | 678.03 ns | 694.17 ns | 0.96 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 100 | 561.36 ns | 3.986 ns | 3.728 ns | 562.77 ns | 555.22 ns | 567.82 ns | 0.78 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 1000 | 7,837.84 ns | 49.749 ns | 46.535 ns | 7,815.30 ns | 7,781.38 ns | 7,899.49 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 1000 | 7,701.66 ns | 7.215 ns | 6.749 ns | 7,700.41 ns | 7,692.06 ns | 7,714.71 ns | 0.98 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 1000 | 7,936.08 ns | 49.304 ns | 46.119 ns | 7,957.89 ns | 7,838.63 ns | 7,987.06 ns | 1.01 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10000 | 140,558.00 ns | 4,053.557 ns | 4,668.082 ns | 138,462.17 ns | 135,838.37 ns | 148,890.43 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10000 | 136,547.30 ns | 1,650.734 ns | 1,544.097 ns | 136,678.12 ns | 134,415.09 ns | 139,203.45 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10000 | 139,220.39 ns | 850.721 ns | 795.765 ns | 139,317.75 ns | 137,574.00 ns | 140,382.59 ns | 0.99 | 0.04 | - | NA |

I believe the new Count = 20 scenario case showcases both the existing optimization (without PR92546), with the ratio going from 2.12 (optimization removed) -> 1 (main), as well as the proposed optimization in PR92546 with the ratio improving from 1 to 0.58.
Although the effects of PR92546 are also visible in the Count=100 scenario, I would argue that testing strings with lengths outside the bounds of the key strings is an important benchmark to keep.
@andrewjsaidandrewjsaid
mentioned this pull request
Oct 26, 2023
 Closed

@cincuranet
cincuranet
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
Merging this as is. I see dotnet/runtime#92546 still open. @andrewjsaid if/when it's merged, feel free to update the benchmarks.
@cincuranet
cincuranet
merged commit 21bc5c2
into
dotnet:mainNov 29, 2023
@cincuranetcincuranet
self-assigned this
Nov 29, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@stephentoubstephentoubAwaiting requested review from stephentoub
@cincuranetcincuranetAwaiting requested review from cincuranet

1 more reviewer

@andrewjsaidandrewjsaidandrewjsaid left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@cincuranetcincuranet

Labels

adds new benchmarks

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@adamsitnik@cincuranet@andrewjsaid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
add TryGetValue_False_FrozenDictionary benchmark - #3432
Merged
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Nov 29, 2023
Merged
add TryGetValue_False_FrozenDictionary benchmark#3432
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Conversation
@adamsitnik
@adamsitnikadamsitnik
commented
Oct 20, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@adamsitnikadamsitnik
mentioned this pull request
Oct 20, 2023
 Merged

andrewjsaid
andrewjsaid
reviewed
Oct 21, 2023
View reviewed changes
Comment threadsrc/benchmarks/micro/libraries/System.Collections/Frozen/Perf_FrozenDictionary_String.cs
 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 25, maxLength: 25)
 : ValuesGenerator.ArrayOfUniqueValues<string>(Count);

 ? ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 25, maxLength: 25)
@andrewjsaidandrewjsaidOct 21, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding a new case for 20 items designed to benchmark the length optimizations.
 // bimodal distribution of lengths with some search strings outside bounds of the keys
: Count == 20 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 10, maxLength: 12)
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 18, maxLength: 20))
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 5, maxLength: 25)).ToArray()

I ran the benchmarks against 3 versions of .NET runtime.
main - main branch as of yesterday
nolength - I removed the existing if ((uint)(key.Length - _minimumLength) <= (uint)_maximumLengthDiff) check for comparison's sake
pr92546 - dotnet/runtime#92546 which adds a new length filter
Here are the results:
// * Summary *
BenchmarkDotNet v0.13.7-nightly.20230717.35, Windows 11 (10.0.22621.2428/22H2/2022Update/SunValley2)
AMD Ryzen 9 5950X, 1 CPU, 32 logical and 16 physical cores
.NET SDK 8.0.100-rc.1.23463.5
[Host] : .NET 8.0.0 (8.0.23.41904), X64 RyuJIT AVX2
Job-DLBUBA : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-LYUJAP : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-EJCRGQ : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
PowerPlanMode=00000000-0000-0000-0000-000000000000 Arguments=/p:EnableUnsafeBinaryFormatterSerialization=true IterationTime=250.0000 ms MaxIterationCount=20 MinIterationCount=15 WarmupCount=1 | Method | Job | ... Toolchain | Count | Mean | Error | StdDev | Median | Min | Max | Ratio | RatioSD | Allocated | Alloc Ratio |
|----------------------------------- |----------- |-------------------------...------------ |------ |--------------:|-------------:|-------------:|--------------:|--------------:|--------------:|------:|--------:|----------:|------------:|
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10 | 22.72 ns | 0.177 ns | 0.165 ns | 22.78 ns | 22.31 ns | 22.89 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10 | 22.04 ns | 0.746 ns | 0.829 ns | 21.67 ns | 21.03 ns | 23.72 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10 | 24.14 ns | 0.305 ns | 0.285 ns | 24.19 ns | 23.61 ns | 24.53 ns | 1.06 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 20 | 37.76 ns | 0.761 ns | 0.747 ns | 37.59 ns | 36.78 ns | 39.03 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 20 | 79.91 ns | 1.291 ns | 1.207 ns | 79.65 ns | 78.42 ns | 82.54 ns | 2.12 | 0.06 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 20 | 21.93 ns | 0.449 ns | 0.441 ns | 21.80 ns | 21.51 ns | 23.26 ns | 0.58 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 100 | 716.16 ns | 5.014 ns | 4.187 ns | 716.11 ns | 710.24 ns | 725.50 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 100 | 686.85 ns | 4.755 ns | 4.448 ns | 686.33 ns | 678.03 ns | 694.17 ns | 0.96 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 100 | 561.36 ns | 3.986 ns | 3.728 ns | 562.77 ns | 555.22 ns | 567.82 ns | 0.78 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 1000 | 7,837.84 ns | 49.749 ns | 46.535 ns | 7,815.30 ns | 7,781.38 ns | 7,899.49 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 1000 | 7,701.66 ns | 7.215 ns | 6.749 ns | 7,700.41 ns | 7,692.06 ns | 7,714.71 ns | 0.98 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 1000 | 7,936.08 ns | 49.304 ns | 46.119 ns | 7,957.89 ns | 7,838.63 ns | 7,987.06 ns | 1.01 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10000 | 140,558.00 ns | 4,053.557 ns | 4,668.082 ns | 138,462.17 ns | 135,838.37 ns | 148,890.43 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10000 | 136,547.30 ns | 1,650.734 ns | 1,544.097 ns | 136,678.12 ns | 134,415.09 ns | 139,203.45 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10000 | 139,220.39 ns | 850.721 ns | 795.765 ns | 139,317.75 ns | 137,574.00 ns | 140,382.59 ns | 0.99 | 0.04 | - | NA |

I believe the new Count = 20 scenario case showcases both the existing optimization (without PR92546), with the ratio going from 2.12 (optimization removed) -> 1 (main), as well as the proposed optimization in PR92546 with the ratio improving from 1 to 0.58.
Although the effects of PR92546 are also visible in the Count=100 scenario, I would argue that testing strings with lengths outside the bounds of the key strings is an important benchmark to keep.
@andrewjsaidandrewjsaid
mentioned this pull request
Oct 26, 2023
 Closed

@cincuranet
cincuranet
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
Merging this as is. I see dotnet/runtime#92546 still open. @andrewjsaid if/when it's merged, feel free to update the benchmarks.
@cincuranet
cincuranet
merged commit 21bc5c2
into
dotnet:mainNov 29, 2023
@cincuranetcincuranet
self-assigned this
Nov 29, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@stephentoubstephentoubAwaiting requested review from stephentoub
@cincuranetcincuranetAwaiting requested review from cincuranet

1 more reviewer

@andrewjsaidandrewjsaidandrewjsaid left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@cincuranetcincuranet

Labels

adds new benchmarks

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@adamsitnik@cincuranet@andrewjsaid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
add TryGetValue_False_FrozenDictionary benchmark - #3432
Merged
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Nov 29, 2023
Merged
add TryGetValue_False_FrozenDictionary benchmark#3432
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Conversation
@adamsitnik
@adamsitnikadamsitnik
commented
Oct 20, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@adamsitnikadamsitnik
mentioned this pull request
Oct 20, 2023
 Merged

andrewjsaid
andrewjsaid
reviewed
Oct 21, 2023
View reviewed changes
Comment threadsrc/benchmarks/micro/libraries/System.Collections/Frozen/Perf_FrozenDictionary_String.cs
 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 25, maxLength: 25)
 : ValuesGenerator.ArrayOfUniqueValues<string>(Count);

 ? ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 25, maxLength: 25)
@andrewjsaidandrewjsaidOct 21, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding a new case for 20 items designed to benchmark the length optimizations.
 // bimodal distribution of lengths with some search strings outside bounds of the keys
: Count == 20 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 10, maxLength: 12)
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 18, maxLength: 20))
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 5, maxLength: 25)).ToArray()

I ran the benchmarks against 3 versions of .NET runtime.
main - main branch as of yesterday
nolength - I removed the existing if ((uint)(key.Length - _minimumLength) <= (uint)_maximumLengthDiff) check for comparison's sake
pr92546 - dotnet/runtime#92546 which adds a new length filter
Here are the results:
// * Summary *
BenchmarkDotNet v0.13.7-nightly.20230717.35, Windows 11 (10.0.22621.2428/22H2/2022Update/SunValley2)
AMD Ryzen 9 5950X, 1 CPU, 32 logical and 16 physical cores
.NET SDK 8.0.100-rc.1.23463.5
[Host] : .NET 8.0.0 (8.0.23.41904), X64 RyuJIT AVX2
Job-DLBUBA : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-LYUJAP : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-EJCRGQ : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
PowerPlanMode=00000000-0000-0000-0000-000000000000 Arguments=/p:EnableUnsafeBinaryFormatterSerialization=true IterationTime=250.0000 ms MaxIterationCount=20 MinIterationCount=15 WarmupCount=1 | Method | Job | ... Toolchain | Count | Mean | Error | StdDev | Median | Min | Max | Ratio | RatioSD | Allocated | Alloc Ratio |
|----------------------------------- |----------- |-------------------------...------------ |------ |--------------:|-------------:|-------------:|--------------:|--------------:|--------------:|------:|--------:|----------:|------------:|
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10 | 22.72 ns | 0.177 ns | 0.165 ns | 22.78 ns | 22.31 ns | 22.89 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10 | 22.04 ns | 0.746 ns | 0.829 ns | 21.67 ns | 21.03 ns | 23.72 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10 | 24.14 ns | 0.305 ns | 0.285 ns | 24.19 ns | 23.61 ns | 24.53 ns | 1.06 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 20 | 37.76 ns | 0.761 ns | 0.747 ns | 37.59 ns | 36.78 ns | 39.03 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 20 | 79.91 ns | 1.291 ns | 1.207 ns | 79.65 ns | 78.42 ns | 82.54 ns | 2.12 | 0.06 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 20 | 21.93 ns | 0.449 ns | 0.441 ns | 21.80 ns | 21.51 ns | 23.26 ns | 0.58 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 100 | 716.16 ns | 5.014 ns | 4.187 ns | 716.11 ns | 710.24 ns | 725.50 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 100 | 686.85 ns | 4.755 ns | 4.448 ns | 686.33 ns | 678.03 ns | 694.17 ns | 0.96 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 100 | 561.36 ns | 3.986 ns | 3.728 ns | 562.77 ns | 555.22 ns | 567.82 ns | 0.78 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 1000 | 7,837.84 ns | 49.749 ns | 46.535 ns | 7,815.30 ns | 7,781.38 ns | 7,899.49 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 1000 | 7,701.66 ns | 7.215 ns | 6.749 ns | 7,700.41 ns | 7,692.06 ns | 7,714.71 ns | 0.98 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 1000 | 7,936.08 ns | 49.304 ns | 46.119 ns | 7,957.89 ns | 7,838.63 ns | 7,987.06 ns | 1.01 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10000 | 140,558.00 ns | 4,053.557 ns | 4,668.082 ns | 138,462.17 ns | 135,838.37 ns | 148,890.43 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10000 | 136,547.30 ns | 1,650.734 ns | 1,544.097 ns | 136,678.12 ns | 134,415.09 ns | 139,203.45 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10000 | 139,220.39 ns | 850.721 ns | 795.765 ns | 139,317.75 ns | 137,574.00 ns | 140,382.59 ns | 0.99 | 0.04 | - | NA |

I believe the new Count = 20 scenario case showcases both the existing optimization (without PR92546), with the ratio going from 2.12 (optimization removed) -> 1 (main), as well as the proposed optimization in PR92546 with the ratio improving from 1 to 0.58.
Although the effects of PR92546 are also visible in the Count=100 scenario, I would argue that testing strings with lengths outside the bounds of the key strings is an important benchmark to keep.
@andrewjsaidandrewjsaid
mentioned this pull request
Oct 26, 2023
 Closed

@cincuranet
cincuranet
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
Merging this as is. I see dotnet/runtime#92546 still open. @andrewjsaid if/when it's merged, feel free to update the benchmarks.
@cincuranet
cincuranet
merged commit 21bc5c2
into
dotnet:mainNov 29, 2023
@cincuranetcincuranet
self-assigned this
Nov 29, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@stephentoubstephentoubAwaiting requested review from stephentoub
@cincuranetcincuranetAwaiting requested review from cincuranet

1 more reviewer

@andrewjsaidandrewjsaidandrewjsaid left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@cincuranetcincuranet

Labels

adds new benchmarks

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@adamsitnik@cincuranet@andrewjsaid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
add TryGetValue_False_FrozenDictionary benchmark - #3432
Merged
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Nov 29, 2023
Merged
add TryGetValue_False_FrozenDictionary benchmark#3432
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Conversation
@adamsitnik
@adamsitnikadamsitnik
commented
Oct 20, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@adamsitnikadamsitnik
mentioned this pull request
Oct 20, 2023
 Merged

andrewjsaid
andrewjsaid
reviewed
Oct 21, 2023
View reviewed changes
Comment threadsrc/benchmarks/micro/libraries/System.Collections/Frozen/Perf_FrozenDictionary_String.cs
 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 25, maxLength: 25)
 : ValuesGenerator.ArrayOfUniqueValues<string>(Count);

 ? ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 25, maxLength: 25)
@andrewjsaidandrewjsaidOct 21, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding a new case for 20 items designed to benchmark the length optimizations.
 // bimodal distribution of lengths with some search strings outside bounds of the keys
: Count == 20 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 10, maxLength: 12)
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 18, maxLength: 20))
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 5, maxLength: 25)).ToArray()

I ran the benchmarks against 3 versions of .NET runtime.
main - main branch as of yesterday
nolength - I removed the existing if ((uint)(key.Length - _minimumLength) <= (uint)_maximumLengthDiff) check for comparison's sake
pr92546 - dotnet/runtime#92546 which adds a new length filter
Here are the results:
// * Summary *
BenchmarkDotNet v0.13.7-nightly.20230717.35, Windows 11 (10.0.22621.2428/22H2/2022Update/SunValley2)
AMD Ryzen 9 5950X, 1 CPU, 32 logical and 16 physical cores
.NET SDK 8.0.100-rc.1.23463.5
[Host] : .NET 8.0.0 (8.0.23.41904), X64 RyuJIT AVX2
Job-DLBUBA : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-LYUJAP : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-EJCRGQ : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
PowerPlanMode=00000000-0000-0000-0000-000000000000 Arguments=/p:EnableUnsafeBinaryFormatterSerialization=true IterationTime=250.0000 ms MaxIterationCount=20 MinIterationCount=15 WarmupCount=1 | Method | Job | ... Toolchain | Count | Mean | Error | StdDev | Median | Min | Max | Ratio | RatioSD | Allocated | Alloc Ratio |
|----------------------------------- |----------- |-------------------------...------------ |------ |--------------:|-------------:|-------------:|--------------:|--------------:|--------------:|------:|--------:|----------:|------------:|
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10 | 22.72 ns | 0.177 ns | 0.165 ns | 22.78 ns | 22.31 ns | 22.89 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10 | 22.04 ns | 0.746 ns | 0.829 ns | 21.67 ns | 21.03 ns | 23.72 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10 | 24.14 ns | 0.305 ns | 0.285 ns | 24.19 ns | 23.61 ns | 24.53 ns | 1.06 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 20 | 37.76 ns | 0.761 ns | 0.747 ns | 37.59 ns | 36.78 ns | 39.03 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 20 | 79.91 ns | 1.291 ns | 1.207 ns | 79.65 ns | 78.42 ns | 82.54 ns | 2.12 | 0.06 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 20 | 21.93 ns | 0.449 ns | 0.441 ns | 21.80 ns | 21.51 ns | 23.26 ns | 0.58 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 100 | 716.16 ns | 5.014 ns | 4.187 ns | 716.11 ns | 710.24 ns | 725.50 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 100 | 686.85 ns | 4.755 ns | 4.448 ns | 686.33 ns | 678.03 ns | 694.17 ns | 0.96 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 100 | 561.36 ns | 3.986 ns | 3.728 ns | 562.77 ns | 555.22 ns | 567.82 ns | 0.78 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 1000 | 7,837.84 ns | 49.749 ns | 46.535 ns | 7,815.30 ns | 7,781.38 ns | 7,899.49 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 1000 | 7,701.66 ns | 7.215 ns | 6.749 ns | 7,700.41 ns | 7,692.06 ns | 7,714.71 ns | 0.98 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 1000 | 7,936.08 ns | 49.304 ns | 46.119 ns | 7,957.89 ns | 7,838.63 ns | 7,987.06 ns | 1.01 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10000 | 140,558.00 ns | 4,053.557 ns | 4,668.082 ns | 138,462.17 ns | 135,838.37 ns | 148,890.43 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10000 | 136,547.30 ns | 1,650.734 ns | 1,544.097 ns | 136,678.12 ns | 134,415.09 ns | 139,203.45 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10000 | 139,220.39 ns | 850.721 ns | 795.765 ns | 139,317.75 ns | 137,574.00 ns | 140,382.59 ns | 0.99 | 0.04 | - | NA |

I believe the new Count = 20 scenario case showcases both the existing optimization (without PR92546), with the ratio going from 2.12 (optimization removed) -> 1 (main), as well as the proposed optimization in PR92546 with the ratio improving from 1 to 0.58.
Although the effects of PR92546 are also visible in the Count=100 scenario, I would argue that testing strings with lengths outside the bounds of the key strings is an important benchmark to keep.
@andrewjsaidandrewjsaid
mentioned this pull request
Oct 26, 2023
 Closed

@cincuranet
cincuranet
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
Merging this as is. I see dotnet/runtime#92546 still open. @andrewjsaid if/when it's merged, feel free to update the benchmarks.
@cincuranet
cincuranet
merged commit 21bc5c2
into
dotnet:mainNov 29, 2023
@cincuranetcincuranet
self-assigned this
Nov 29, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@stephentoubstephentoubAwaiting requested review from stephentoub
@cincuranetcincuranetAwaiting requested review from cincuranet

1 more reviewer

@andrewjsaidandrewjsaidandrewjsaid left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@cincuranetcincuranet

Labels

adds new benchmarks

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@adamsitnik@cincuranet@andrewjsaid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
add TryGetValue_False_FrozenDictionary benchmark - #3432
Merged
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Nov 29, 2023
Merged
add TryGetValue_False_FrozenDictionary benchmark#3432
cincuranet merged 1 commit into
dotnet:mainfrom 
adamsitnik:keyNotFound
Conversation
@adamsitnik
@adamsitnikadamsitnik
commented
Oct 20, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@adamsitnikadamsitnik
mentioned this pull request
Oct 20, 2023
 Merged

andrewjsaid
andrewjsaid
reviewed
Oct 21, 2023
View reviewed changes
Comment threadsrc/benchmarks/micro/libraries/System.Collections/Frozen/Perf_FrozenDictionary_String.cs
 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 25, maxLength: 25)
 : ValuesGenerator.ArrayOfUniqueValues<string>(Count);

 ? ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 25, maxLength: 25)
@andrewjsaidandrewjsaidOct 21, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding a new case for 20 items designed to benchmark the length optimizations.
 // bimodal distribution of lengths with some search strings outside bounds of the keys
: Count == 20 ? ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 10, maxLength: 12)
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10, minLength: 18, maxLength: 20))
.Concat(ValuesGenerator.ArrayOfUniqueStrings(10 * 2, minLength: 5, maxLength: 25)).ToArray()

I ran the benchmarks against 3 versions of .NET runtime.
main - main branch as of yesterday
nolength - I removed the existing if ((uint)(key.Length - _minimumLength) <= (uint)_maximumLengthDiff) check for comparison's sake
pr92546 - dotnet/runtime#92546 which adds a new length filter
Here are the results:
// * Summary *
BenchmarkDotNet v0.13.7-nightly.20230717.35, Windows 11 (10.0.22621.2428/22H2/2022Update/SunValley2)
AMD Ryzen 9 5950X, 1 CPU, 32 logical and 16 physical cores
.NET SDK 8.0.100-rc.1.23463.5
[Host] : .NET 8.0.0 (8.0.23.41904), X64 RyuJIT AVX2
Job-DLBUBA : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-LYUJAP : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
Job-EJCRGQ : .NET 9.0.0 (42.42.42.42424), X64 RyuJIT AVX2
PowerPlanMode=00000000-0000-0000-0000-000000000000 Arguments=/p:EnableUnsafeBinaryFormatterSerialization=true IterationTime=250.0000 ms MaxIterationCount=20 MinIterationCount=15 WarmupCount=1 | Method | Job | ... Toolchain | Count | Mean | Error | StdDev | Median | Min | Max | Ratio | RatioSD | Allocated | Alloc Ratio |
|----------------------------------- |----------- |-------------------------...------------ |------ |--------------:|-------------:|-------------:|--------------:|--------------:|--------------:|------:|--------:|----------:|------------:|
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10 | 22.72 ns | 0.177 ns | 0.165 ns | 22.78 ns | 22.31 ns | 22.89 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10 | 22.04 ns | 0.746 ns | 0.829 ns | 21.67 ns | 21.03 ns | 23.72 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10 | 24.14 ns | 0.305 ns | 0.285 ns | 24.19 ns | 23.61 ns | 24.53 ns | 1.06 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 20 | 37.76 ns | 0.761 ns | 0.747 ns | 37.59 ns | 36.78 ns | 39.03 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 20 | 79.91 ns | 1.291 ns | 1.207 ns | 79.65 ns | 78.42 ns | 82.54 ns | 2.12 | 0.06 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 20 | 21.93 ns | 0.449 ns | 0.441 ns | 21.80 ns | 21.51 ns | 23.26 ns | 0.58 | 0.02 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 100 | 716.16 ns | 5.014 ns | 4.187 ns | 716.11 ns | 710.24 ns | 725.50 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 100 | 686.85 ns | 4.755 ns | 4.448 ns | 686.33 ns | 678.03 ns | 694.17 ns | 0.96 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 100 | 561.36 ns | 3.986 ns | 3.728 ns | 562.77 ns | 555.22 ns | 567.82 ns | 0.78 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 1000 | 7,837.84 ns | 49.749 ns | 46.535 ns | 7,815.30 ns | 7,781.38 ns | 7,899.49 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 1000 | 7,701.66 ns | 7.215 ns | 6.749 ns | 7,700.41 ns | 7,692.06 ns | 7,714.71 ns | 0.98 | 0.01 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 1000 | 7,936.08 ns | 49.304 ns | 46.119 ns | 7,957.89 ns | 7,838.63 ns | 7,987.06 ns | 1.01 | 0.01 | - | NA |
| | | ... | | | | | | | | | | | |
| TryGetValue_False_FrozenDictionary | Job-DLBUBA | \dotnet-runtime-main...\corerun.exe | 10000 | 140,558.00 ns | 4,053.557 ns | 4,668.082 ns | 138,462.17 ns | 135,838.37 ns | 148,890.43 ns | 1.00 | 0.00 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-LYUJAP | \dotnet-runtime-nolength...\corerun.exe | 10000 | 136,547.30 ns | 1,650.734 ns | 1,544.097 ns | 136,678.12 ns | 134,415.09 ns | 139,203.45 ns | 0.97 | 0.04 | - | NA |
| TryGetValue_False_FrozenDictionary | Job-EJCRGQ | \dotnet-runtime-pr92546...\corerun.exe | 10000 | 139,220.39 ns | 850.721 ns | 795.765 ns | 139,317.75 ns | 137,574.00 ns | 140,382.59 ns | 0.99 | 0.04 | - | NA |

I believe the new Count = 20 scenario case showcases both the existing optimization (without PR92546), with the ratio going from 2.12 (optimization removed) -> 1 (main), as well as the proposed optimization in PR92546 with the ratio improving from 1 to 0.58.
Although the effects of PR92546 are also visible in the Count=100 scenario, I would argue that testing strings with lengths outside the bounds of the key strings is an important benchmark to keep.
@andrewjsaidandrewjsaid
mentioned this pull request
Oct 26, 2023
 Closed

@cincuranet
cincuranet
commented
Nov 29, 2023

Copy link


Copy Markdown

Contributor
Merging this as is. I see dotnet/runtime#92546 still open. @andrewjsaid if/when it's merged, feel free to update the benchmarks.
@cincuranet
cincuranet
merged commit 21bc5c2
into
dotnet:mainNov 29, 2023
@cincuranetcincuranet
self-assigned this
Nov 29, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@stephentoubstephentoubAwaiting requested review from stephentoub
@cincuranetcincuranetAwaiting requested review from cincuranet

1 more reviewer

@andrewjsaidandrewjsaidandrewjsaid left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@cincuranetcincuranet

Labels

adds new benchmarks

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@adamsitnik@cincuranet@andrewjsaid