Merge AsyncRx.NET assemblies - #1896
Merged
Merged
Conversation
System.Reactive.Async.Concurrency, System.Reactive.Async.Core, System.Reactive.Async.Disposables, System.Reactive.Async.Linq and System.Reactive.Async.Bcl all merged into System.Reactive.Async TBD: not sure what to do with System.Reactive.Async.Interfaces and System.Reactive.Shared yet
All the types in that library are also defined in System.Reactive. This meant we needed to change the name of our AsyncLock because System.Reactive also defines a type with that name, but it works differently. (Also fixed erroneous paths for all the .tt files)
Replace System.Reactive.Shared with a reference to the System.Reactive NuGet package, and an extension method to supply the one extra feature AsyncRx.NET requires of Notification<T>.
idg10
marked this pull request as ready for review
March 16, 2023 10:57
HowardvanRooijen
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1891
System.Reactive.Async.Concurrency, System.Reactive.Async.Core, System.Reactive.Async.Disposables, System.Reactive.Async.Interfaces, System.Reactive.Async.Linq and System.Reactive.Async.Bcl all merged into System.Reactive.Async
System.Reactive.Shared has been removed because almost everything it did was already in System.Reactive. So we now take a dependency on System.Reactive, and one extension method puts back the one thing that was missing.