Expand UI framework readmes; update release notes - #2328
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the NuGet package ReadMe content for Rx 7’s UI-framework-specific packages (WPF, Windows Forms, UWP) and updates the Rx 7 release notes to mention the OfType nullability behavior change.
Changes:
- Add “Getting started” sections with minimal sample code to
System.Reactive.Wpf,System.Reactive.Windows.Forms, andSystem.Reactive.UwpNuGet ReadMes. - Update Rx 7.0 release notes to call out the
OfTypenullability/breaking-change behavior adjustment.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Rx.NET/Source/src/System.Reactive.Wpf/build/NuGet.Readme.md | Adds a WPF “Getting started” section demonstrating ObserveOn(this.Dispatcher) usage. |
| Rx.NET/Source/src/System.Reactive.Windows.Forms/build/NuGet.Readme.md | Adds a Windows Forms “Getting started” section demonstrating ObserveOn(this) usage (contains a WPF copy/paste error to fix). |
| Rx.NET/Source/src/System.Reactive.Uwp/build/NuGet.Readme.md | Adds a UWP “Getting started” section demonstrating ObserveOn(this) on a DependencyObject. |
| Rx.NET/Documentation/ReleaseHistory/Rx.v7.md | Adds a breaking-change bullet about OfType nullability (wording should be made more explicit). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mwadams
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2269
Resolves #2261