Add timezone data to System.Runtime

[tqiu8]

Add downloaded timezone data from iana.org

[safern]

Should we instead download it as part of the build of the package?

[tqiu8]

@safern How can I do that?

[safern]

Hmm good question. We would probably need a build script or an MSBuild task to do that. I guess it is fine as is at the moment, and we can open an issue as a follow up?

cc: @ViktorHofer

[ViktorHofer]

Please avoid build scripts if possible and use msbuild instead. You should be able to add a target to the test data project file which then downloads and uncompresses the files.

[safern]

You should be able to add a target to the test data project file which then downloads and uncompresses the files.

Yeah I also prefer MSBuild targets.

[akoeplinger]

@ViktorHofer@safern I'm wondering whether this is the right repo for this data. Do we expect to branch runtime-assets into release/5.0? right now the master branch pushes to .NET 6 feeds already and we'll need this data in .NET 5.

[akoeplinger]

I discussed with @mmitche offline and his recommendation was to branch runtime-assets for release/5.0.

[ViktorHofer]

Do we actually want to check these external assets into the repository? If yes, are we allowed to do so? cc @jkotas

[akoeplinger]

Do we actually want to check these external assets into the repository?

That's what we do for the Unicode files as well to avoid relying on a third party website during the build: https://github.com/dotnet/runtime-assets/tree/master/src/System.Private.Runtime.UnicodeData/13.0.0/ucd

If yes, are we allowed to do so?

The files are licensed under the public domain: https://data.iana.org/time-zones/tzdb/LICENSE

We'll need to update https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT with that text.

[jkotas]

What is the license for these files?

This should have an entry in https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT

[tqiu8]

@ViktorHofer@akoeplinger Should I keep the timezone data in src/System.Runtime.TimeZoneData/zoneinfo then? Currently it's being saved to IntermediateOutputPath

[akoeplinger]

@tqiu8 after thinking about it a bit my preference is to only download and package the zoneinfo input files here in runtime-assets and do the zic compilation to binary as part of the dotnet/runtime WASM build. That avoids the issue of the build not working on Windows.

So basically download the area files + zone1970.tab into src/System.Runtime.TimeZoneData/data.

[ViktorHofer]

I would prefer not to check these input files into the repo but download them into the intermediate path. Having thousands of these checked in isn't ideal.

[akoeplinger]

I do think we should check in the input files that we download from iana.org, it'd be a problem for sourcebuild otherwise.
This is also what we do for the Unicode files: #66

[tqiu8]

Ok, so just to clarify. Source files from iana go to src/System.Runtime.TimeZoneData and zic compilation happens later in the runtime build.

[akoeplinger]

Yes this looks fine to me. I'll discuss with Viktor about any concerns he has.

discussed with Viktor offline

[akoeplinger]

Discussed with Viktor on Teams, he understands the approach now and is fine with it.

[tqiu8]

Add downloaded timezone data from iana.org

[safern]

Should we instead download it as part of the build of the package?

[tqiu8]

@safern How can I do that?

[safern]

Hmm good question. We would probably need a build script or an MSBuild task to do that. I guess it is fine as is at the moment, and we can open an issue as a follow up?

cc: @ViktorHofer

[ViktorHofer]

Please avoid build scripts if possible and use msbuild instead. You should be able to add a target to the test data project file which then downloads and uncompresses the files.

[safern]

You should be able to add a target to the test data project file which then downloads and uncompresses the files.

Yeah I also prefer MSBuild targets.

[akoeplinger]

@ViktorHofer@safern I'm wondering whether this is the right repo for this data. Do we expect to branch runtime-assets into release/5.0? right now the master branch pushes to .NET 6 feeds already and we'll need this data in .NET 5.

[akoeplinger]

I discussed with @mmitche offline and his recommendation was to branch runtime-assets for release/5.0.

[ViktorHofer]

Do we actually want to check these external assets into the repository? If yes, are we allowed to do so? cc @jkotas

[akoeplinger]

Do we actually want to check these external assets into the repository?

That's what we do for the Unicode files as well to avoid relying on a third party website during the build: https://github.com/dotnet/runtime-assets/tree/master/src/System.Private.Runtime.UnicodeData/13.0.0/ucd

If yes, are we allowed to do so?

The files are licensed under the public domain: https://data.iana.org/time-zones/tzdb/LICENSE

We'll need to update https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT with that text.

[jkotas]

What is the license for these files?

This should have an entry in https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT

[tqiu8]

@ViktorHofer@akoeplinger Should I keep the timezone data in src/System.Runtime.TimeZoneData/zoneinfo then? Currently it's being saved to IntermediateOutputPath

[akoeplinger]

@tqiu8 after thinking about it a bit my preference is to only download and package the zoneinfo input files here in runtime-assets and do the zic compilation to binary as part of the dotnet/runtime WASM build. That avoids the issue of the build not working on Windows.

So basically download the area files + zone1970.tab into src/System.Runtime.TimeZoneData/data.

[ViktorHofer]

I would prefer not to check these input files into the repo but download them into the intermediate path. Having thousands of these checked in isn't ideal.

[akoeplinger]

I do think we should check in the input files that we download from iana.org, it'd be a problem for sourcebuild otherwise.
This is also what we do for the Unicode files: #66

[tqiu8]

Ok, so just to clarify. Source files from iana go to src/System.Runtime.TimeZoneData and zic compilation happens later in the runtime build.

[akoeplinger]

Yes this looks fine to me. I'll discuss with Viktor about any concerns he has.

discussed with Viktor offline

[akoeplinger]

Discussed with Viktor on Teams, he understands the approach now and is fine with it.

[tqiu8]

Add downloaded timezone data from iana.org

[safern]

Should we instead download it as part of the build of the package?

[tqiu8]

@safern How can I do that?

[safern]

Hmm good question. We would probably need a build script or an MSBuild task to do that. I guess it is fine as is at the moment, and we can open an issue as a follow up?

cc: @ViktorHofer

[ViktorHofer]

Please avoid build scripts if possible and use msbuild instead. You should be able to add a target to the test data project file which then downloads and uncompresses the files.

[safern]

You should be able to add a target to the test data project file which then downloads and uncompresses the files.

Yeah I also prefer MSBuild targets.

[akoeplinger]

@ViktorHofer@safern I'm wondering whether this is the right repo for this data. Do we expect to branch runtime-assets into release/5.0? right now the master branch pushes to .NET 6 feeds already and we'll need this data in .NET 5.

[akoeplinger]

I discussed with @mmitche offline and his recommendation was to branch runtime-assets for release/5.0.

[ViktorHofer]

Do we actually want to check these external assets into the repository? If yes, are we allowed to do so? cc @jkotas

[akoeplinger]

Do we actually want to check these external assets into the repository?

That's what we do for the Unicode files as well to avoid relying on a third party website during the build: https://github.com/dotnet/runtime-assets/tree/master/src/System.Private.Runtime.UnicodeData/13.0.0/ucd

If yes, are we allowed to do so?

The files are licensed under the public domain: https://data.iana.org/time-zones/tzdb/LICENSE

We'll need to update https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT with that text.

[jkotas]

What is the license for these files?

This should have an entry in https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT

[tqiu8]

@ViktorHofer@akoeplinger Should I keep the timezone data in src/System.Runtime.TimeZoneData/zoneinfo then? Currently it's being saved to IntermediateOutputPath

[akoeplinger]

@tqiu8 after thinking about it a bit my preference is to only download and package the zoneinfo input files here in runtime-assets and do the zic compilation to binary as part of the dotnet/runtime WASM build. That avoids the issue of the build not working on Windows.

So basically download the area files + zone1970.tab into src/System.Runtime.TimeZoneData/data.

[ViktorHofer]

I would prefer not to check these input files into the repo but download them into the intermediate path. Having thousands of these checked in isn't ideal.

[akoeplinger]

I do think we should check in the input files that we download from iana.org, it'd be a problem for sourcebuild otherwise.
This is also what we do for the Unicode files: #66

[tqiu8]

Ok, so just to clarify. Source files from iana go to src/System.Runtime.TimeZoneData and zic compilation happens later in the runtime build.

[akoeplinger]

Yes this looks fine to me. I'll discuss with Viktor about any concerns he has.

discussed with Viktor offline

[akoeplinger]

Discussed with Viktor on Teams, he understands the approach now and is fine with it.

[tqiu8]

Add downloaded timezone data from iana.org

[safern]

Should we instead download it as part of the build of the package?

[tqiu8]

@safern How can I do that?

[safern]

Hmm good question. We would probably need a build script or an MSBuild task to do that. I guess it is fine as is at the moment, and we can open an issue as a follow up?

cc: @ViktorHofer

[ViktorHofer]

Please avoid build scripts if possible and use msbuild instead. You should be able to add a target to the test data project file which then downloads and uncompresses the files.

[safern]

You should be able to add a target to the test data project file which then downloads and uncompresses the files.

Yeah I also prefer MSBuild targets.

[akoeplinger]

@ViktorHofer@safern I'm wondering whether this is the right repo for this data. Do we expect to branch runtime-assets into release/5.0? right now the master branch pushes to .NET 6 feeds already and we'll need this data in .NET 5.

[akoeplinger]

I discussed with @mmitche offline and his recommendation was to branch runtime-assets for release/5.0.

[ViktorHofer]

Do we actually want to check these external assets into the repository? If yes, are we allowed to do so? cc @jkotas

[akoeplinger]

Do we actually want to check these external assets into the repository?

That's what we do for the Unicode files as well to avoid relying on a third party website during the build: https://github.com/dotnet/runtime-assets/tree/master/src/System.Private.Runtime.UnicodeData/13.0.0/ucd

If yes, are we allowed to do so?

The files are licensed under the public domain: https://data.iana.org/time-zones/tzdb/LICENSE

We'll need to update https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT with that text.

[jkotas]

What is the license for these files?

This should have an entry in https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT

[tqiu8]

@ViktorHofer@akoeplinger Should I keep the timezone data in src/System.Runtime.TimeZoneData/zoneinfo then? Currently it's being saved to IntermediateOutputPath

[akoeplinger]

@tqiu8 after thinking about it a bit my preference is to only download and package the zoneinfo input files here in runtime-assets and do the zic compilation to binary as part of the dotnet/runtime WASM build. That avoids the issue of the build not working on Windows.

So basically download the area files + zone1970.tab into src/System.Runtime.TimeZoneData/data.

[ViktorHofer]

I would prefer not to check these input files into the repo but download them into the intermediate path. Having thousands of these checked in isn't ideal.

[akoeplinger]

I do think we should check in the input files that we download from iana.org, it'd be a problem for sourcebuild otherwise.
This is also what we do for the Unicode files: #66

[tqiu8]

Ok, so just to clarify. Source files from iana go to src/System.Runtime.TimeZoneData and zic compilation happens later in the runtime build.

[akoeplinger]

Yes this looks fine to me. I'll discuss with Viktor about any concerns he has.

discussed with Viktor offline

[akoeplinger]

Discussed with Viktor on Teams, he understands the approach now and is fine with it.

[tqiu8]

Add downloaded timezone data from iana.org

[safern]

Should we instead download it as part of the build of the package?

[tqiu8]

@safern How can I do that?

[safern]

Hmm good question. We would probably need a build script or an MSBuild task to do that. I guess it is fine as is at the moment, and we can open an issue as a follow up?

cc: @ViktorHofer

[ViktorHofer]

Please avoid build scripts if possible and use msbuild instead. You should be able to add a target to the test data project file which then downloads and uncompresses the files.

[safern]

You should be able to add a target to the test data project file which then downloads and uncompresses the files.

Yeah I also prefer MSBuild targets.

[akoeplinger]

@ViktorHofer@safern I'm wondering whether this is the right repo for this data. Do we expect to branch runtime-assets into release/5.0? right now the master branch pushes to .NET 6 feeds already and we'll need this data in .NET 5.

[akoeplinger]

I discussed with @mmitche offline and his recommendation was to branch runtime-assets for release/5.0.

[ViktorHofer]

Do we actually want to check these external assets into the repository? If yes, are we allowed to do so? cc @jkotas

[akoeplinger]

Do we actually want to check these external assets into the repository?

That's what we do for the Unicode files as well to avoid relying on a third party website during the build: https://github.com/dotnet/runtime-assets/tree/master/src/System.Private.Runtime.UnicodeData/13.0.0/ucd

If yes, are we allowed to do so?

The files are licensed under the public domain: https://data.iana.org/time-zones/tzdb/LICENSE

We'll need to update https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT with that text.

[jkotas]

What is the license for these files?

This should have an entry in https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT

[tqiu8]

@ViktorHofer@akoeplinger Should I keep the timezone data in src/System.Runtime.TimeZoneData/zoneinfo then? Currently it's being saved to IntermediateOutputPath

[akoeplinger]

@tqiu8 after thinking about it a bit my preference is to only download and package the zoneinfo input files here in runtime-assets and do the zic compilation to binary as part of the dotnet/runtime WASM build. That avoids the issue of the build not working on Windows.

So basically download the area files + zone1970.tab into src/System.Runtime.TimeZoneData/data.

[ViktorHofer]

I would prefer not to check these input files into the repo but download them into the intermediate path. Having thousands of these checked in isn't ideal.

[akoeplinger]

I do think we should check in the input files that we download from iana.org, it'd be a problem for sourcebuild otherwise.
This is also what we do for the Unicode files: #66

[tqiu8]

Ok, so just to clarify. Source files from iana go to src/System.Runtime.TimeZoneData and zic compilation happens later in the runtime build.

[akoeplinger]

Yes this looks fine to me. I'll discuss with Viktor about any concerns he has.

discussed with Viktor offline

[akoeplinger]

Discussed with Viktor on Teams, he understands the approach now and is fine with it.

[tqiu8]

Add downloaded timezone data from iana.org

[safern]

Should we instead download it as part of the build of the package?

[tqiu8]

@safern How can I do that?

[safern]

Hmm good question. We would probably need a build script or an MSBuild task to do that. I guess it is fine as is at the moment, and we can open an issue as a follow up?

cc: @ViktorHofer

[ViktorHofer]

Please avoid build scripts if possible and use msbuild instead. You should be able to add a target to the test data project file which then downloads and uncompresses the files.

[safern]

You should be able to add a target to the test data project file which then downloads and uncompresses the files.

Yeah I also prefer MSBuild targets.

[akoeplinger]

@ViktorHofer@safern I'm wondering whether this is the right repo for this data. Do we expect to branch runtime-assets into release/5.0? right now the master branch pushes to .NET 6 feeds already and we'll need this data in .NET 5.

[akoeplinger]

I discussed with @mmitche offline and his recommendation was to branch runtime-assets for release/5.0.

[ViktorHofer]

Do we actually want to check these external assets into the repository? If yes, are we allowed to do so? cc @jkotas

[akoeplinger]

Do we actually want to check these external assets into the repository?

That's what we do for the Unicode files as well to avoid relying on a third party website during the build: https://github.com/dotnet/runtime-assets/tree/master/src/System.Private.Runtime.UnicodeData/13.0.0/ucd

If yes, are we allowed to do so?

The files are licensed under the public domain: https://data.iana.org/time-zones/tzdb/LICENSE

We'll need to update https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT with that text.

[jkotas]

What is the license for these files?

This should have an entry in https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT

[tqiu8]

@ViktorHofer@akoeplinger Should I keep the timezone data in src/System.Runtime.TimeZoneData/zoneinfo then? Currently it's being saved to IntermediateOutputPath

[akoeplinger]

@tqiu8 after thinking about it a bit my preference is to only download and package the zoneinfo input files here in runtime-assets and do the zic compilation to binary as part of the dotnet/runtime WASM build. That avoids the issue of the build not working on Windows.

So basically download the area files + zone1970.tab into src/System.Runtime.TimeZoneData/data.

[ViktorHofer]

I would prefer not to check these input files into the repo but download them into the intermediate path. Having thousands of these checked in isn't ideal.

[akoeplinger]

I do think we should check in the input files that we download from iana.org, it'd be a problem for sourcebuild otherwise.
This is also what we do for the Unicode files: #66

[tqiu8]

Ok, so just to clarify. Source files from iana go to src/System.Runtime.TimeZoneData and zic compilation happens later in the runtime build.

[akoeplinger]

Yes this looks fine to me. I'll discuss with Viktor about any concerns he has.

discussed with Viktor offline

[akoeplinger]

Discussed with Viktor on Teams, he understands the approach now and is fine with it.

[tqiu8]

Add downloaded timezone data from iana.org

[safern]

Should we instead download it as part of the build of the package?

[tqiu8]

@safern How can I do that?

[safern]

Hmm good question. We would probably need a build script or an MSBuild task to do that. I guess it is fine as is at the moment, and we can open an issue as a follow up?

cc: @ViktorHofer

[ViktorHofer]

Please avoid build scripts if possible and use msbuild instead. You should be able to add a target to the test data project file which then downloads and uncompresses the files.

[safern]

You should be able to add a target to the test data project file which then downloads and uncompresses the files.

Yeah I also prefer MSBuild targets.

[akoeplinger]

@ViktorHofer@safern I'm wondering whether this is the right repo for this data. Do we expect to branch runtime-assets into release/5.0? right now the master branch pushes to .NET 6 feeds already and we'll need this data in .NET 5.

[akoeplinger]

I discussed with @mmitche offline and his recommendation was to branch runtime-assets for release/5.0.

[ViktorHofer]

Do we actually want to check these external assets into the repository? If yes, are we allowed to do so? cc @jkotas

[akoeplinger]

Do we actually want to check these external assets into the repository?

That's what we do for the Unicode files as well to avoid relying on a third party website during the build: https://github.com/dotnet/runtime-assets/tree/master/src/System.Private.Runtime.UnicodeData/13.0.0/ucd

If yes, are we allowed to do so?

The files are licensed under the public domain: https://data.iana.org/time-zones/tzdb/LICENSE

We'll need to update https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT with that text.

[jkotas]

What is the license for these files?

This should have an entry in https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT

[tqiu8]

@ViktorHofer@akoeplinger Should I keep the timezone data in src/System.Runtime.TimeZoneData/zoneinfo then? Currently it's being saved to IntermediateOutputPath

[akoeplinger]

@tqiu8 after thinking about it a bit my preference is to only download and package the zoneinfo input files here in runtime-assets and do the zic compilation to binary as part of the dotnet/runtime WASM build. That avoids the issue of the build not working on Windows.

So basically download the area files + zone1970.tab into src/System.Runtime.TimeZoneData/data.

[ViktorHofer]

I would prefer not to check these input files into the repo but download them into the intermediate path. Having thousands of these checked in isn't ideal.

[akoeplinger]

I do think we should check in the input files that we download from iana.org, it'd be a problem for sourcebuild otherwise.
This is also what we do for the Unicode files: #66

[tqiu8]

Ok, so just to clarify. Source files from iana go to src/System.Runtime.TimeZoneData and zic compilation happens later in the runtime build.

[akoeplinger]

Yes this looks fine to me. I'll discuss with Viktor about any concerns he has.

discussed with Viktor offline

[akoeplinger]

Discussed with Viktor on Teams, he understands the approach now and is fine with it.

[tqiu8]

Add downloaded timezone data from iana.org

[safern]

Should we instead download it as part of the build of the package?

[tqiu8]

@safern How can I do that?

[safern]

Hmm good question. We would probably need a build script or an MSBuild task to do that. I guess it is fine as is at the moment, and we can open an issue as a follow up?

cc: @ViktorHofer

[ViktorHofer]

Please avoid build scripts if possible and use msbuild instead. You should be able to add a target to the test data project file which then downloads and uncompresses the files.

[safern]

You should be able to add a target to the test data project file which then downloads and uncompresses the files.

Yeah I also prefer MSBuild targets.

[akoeplinger]

@ViktorHofer@safern I'm wondering whether this is the right repo for this data. Do we expect to branch runtime-assets into release/5.0? right now the master branch pushes to .NET 6 feeds already and we'll need this data in .NET 5.

[akoeplinger]

I discussed with @mmitche offline and his recommendation was to branch runtime-assets for release/5.0.

[ViktorHofer]

Do we actually want to check these external assets into the repository? If yes, are we allowed to do so? cc @jkotas

[akoeplinger]

Do we actually want to check these external assets into the repository?

That's what we do for the Unicode files as well to avoid relying on a third party website during the build: https://github.com/dotnet/runtime-assets/tree/master/src/System.Private.Runtime.UnicodeData/13.0.0/ucd

If yes, are we allowed to do so?

The files are licensed under the public domain: https://data.iana.org/time-zones/tzdb/LICENSE

We'll need to update https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT with that text.

[jkotas]

What is the license for these files?

This should have an entry in https://github.com/dotnet/runtime-assets/blob/master/THIRD-PARTY-NOTICES.TXT

[tqiu8]

@ViktorHofer@akoeplinger Should I keep the timezone data in src/System.Runtime.TimeZoneData/zoneinfo then? Currently it's being saved to IntermediateOutputPath

[akoeplinger]

@tqiu8 after thinking about it a bit my preference is to only download and package the zoneinfo input files here in runtime-assets and do the zic compilation to binary as part of the dotnet/runtime WASM build. That avoids the issue of the build not working on Windows.

So basically download the area files + zone1970.tab into src/System.Runtime.TimeZoneData/data.

[ViktorHofer]

I would prefer not to check these input files into the repo but download them into the intermediate path. Having thousands of these checked in isn't ideal.

[akoeplinger]

I do think we should check in the input files that we download from iana.org, it'd be a problem for sourcebuild otherwise.
This is also what we do for the Unicode files: #66

[tqiu8]

Ok, so just to clarify. Source files from iana go to src/System.Runtime.TimeZoneData and zic compilation happens later in the runtime build.

[akoeplinger]

Yes this looks fine to me. I'll discuss with Viktor about any concerns he has.

discussed with Viktor offline

[akoeplinger]

Discussed with Viktor on Teams, he understands the approach now and is fine with it.