Various BenchmarksGame tests failing due to inability to resolve a manifest resource stream

[tannergooding]

Various tests under JIT/Performance/CodeQuality/BenchmarksGame including k-nucleotide-9, k-nucleotide-1, reverse-complement-1, regex-reduce-1, and regex-redux-5 are failing as the manifest resource stream is returning null.

For example, regex-reduce-5 uses the following and the result of GetInputStream is null:

class TestHarnessHelpers
{
 public readonly int ExpectedLength;
 private readonly string resourceName;

 public TestHarnessHelpers(bool bigInput, [System.Runtime.CompilerServices.CallerFilePath] string csFileName = "")
 {
 if (bigInput)
 {
 ExpectedLength = 136381;
 resourceName = $"{Path.GetFileNameWithoutExtension(csFileName)}.regexdna-input25000.txt";
 }
 else
 {
 ExpectedLength = 152;
 resourceName = $"{Path.GetFileNameWithoutExtension(csFileName)}.regexdna-input25.txt";
 }
 }

 public Stream GetInputStream()
 {
 var assembly = typeof(TestHarnessHelpers).GetTypeInfo().Assembly;
 return assembly.GetManifestResourceStream(resourceName);
 }
}

[tannergooding]

This was found in #117845

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

[jkotas]

This is regression introduced by dotnet/sdk#49328 that changed the default value of RootNamespace property for projects that contain - and other special characters in the names.

The RootNamespace property is used to compute the resource names. The resource name that these tests expect is k-nucleotide-9.knucleotide-input.txt, but the actual name produced by .NET SDK after the above change is k_nucleotide_9.knucleotide-input.txt. Notice - vs. _ in the name.

@baronfel @marcpopMSFT Is this an expected .NET SDK breaking change?