System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm #48522

Closed
#48710
Closed
System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm#48522
#48710
Labels
arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
Milestone
6.0.0

Description

@joperezr
joperezr
opened on Feb 19, 2021

When trying to enable the linker Trimming Tests to run on browser-wasm, we found that some tests would fail due to the fact that System.Runtime.InteropServices.Javascript.dll is not getting preserved correctly when the app is built, causing runtime crashes when the test needs to marshal some types. One example of a test case that fails is GenericArraySortHelperTest which passes just fine if we manually root the IS.Javascript.dll, but if we remove that workaround the test fails with:

root@168370dbdf5c:/home/joperezr/share/runtime/artifacts/bin/trimmingTests/projects/System.Runtime.TrimmingTests/GenericArraySortHelperTest/browser-wasm/bin/Release/net6.0/browser-wasm/AppBundle# ./run-v8.sh
Arguments: --run,project.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
WASM-ERR: [ERROR] FATAL UNHANDLED EXCEPTION: Nested exception detected.
WASM-ERR: Original Exception: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int,System.Collections.Generic.IEqualityComparer`1<string>) <0x00060>
WASM-ERR: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int) <0x00014>
WASM-ERR: at System.AppContext.Setup (char**,char**,int) <0x00016>
WASM-ERR:
WASM-ERR: Nested exception:at System.RuntimeType.get_BaseType () <0x00056>
WASM-ERR: at System.Type.IsSubclassOf (System.Type) <0x00044>
WASM-ERR: at System.Reflection.CustomAttribute.IsDefined (System.Reflection.ICustomAttributeProvider,System.Type,bool) <0x00040>
WASM-ERR: at System.Reflection.RuntimeMethodInfo.IsDefined (System.Type,bool) <0x00016>
WASM-ERR: at System.Diagnostics.StackTrace.ShowInStackTrace (System.Reflection.MethodBase) <0x00048>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat,System.Text.StringBuilder) <0x000c8>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat) <0x00036>
WASM-ERR: at System.Exception.GetStackTrace (bool) <0x0006a>
WASM-ERR: at System.Exception.get_StackTrace () <0x0000e>
WASM-ERR: at System.Exception.ToString () <0x000ae>
WASM-ERR: at System.Exception.ToString () <0x00054>
WASM-ERR:
WASM-ERR:

PR #48429 is adding a workaround for now which is rooting System.Runtime.InteropServices.Javascript.dll for the browser-wasm trimming tests so that we can have all tests running and passing, but this workaround should be removed once the underlying problem is fixed.

cc: @marek-safar@eerhardt@lewing

Metadata

Metadata

Assignees

No one assigned

    Labels

    arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
       blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

      Skip to content
      System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm #48522
      Closed
      #48710
      Closed
      System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm#48522
      #48710
      Labels
      arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
      Milestone
      6.0.0
      Description
      @joperezr
      joperezr
      opened on Feb 19, 2021
      When trying to enable the linker Trimming Tests to run on browser-wasm, we found that some tests would fail due to the fact that System.Runtime.InteropServices.Javascript.dll is not getting preserved correctly when the app is built, causing runtime crashes when the test needs to marshal some types. One example of a test case that fails is GenericArraySortHelperTest which passes just fine if we manually root the IS.Javascript.dll, but if we remove that workaround the test fails with:
      root@168370dbdf5c:/home/joperezr/share/runtime/artifacts/bin/trimmingTests/projects/System.Runtime.TrimmingTests/GenericArraySortHelperTest/browser-wasm/bin/Release/net6.0/browser-wasm/AppBundle# ./run-v8.sh
Arguments: --run,project.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
WASM-ERR: [ERROR] FATAL UNHANDLED EXCEPTION: Nested exception detected.
WASM-ERR: Original Exception: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int,System.Collections.Generic.IEqualityComparer`1<string>) <0x00060>
WASM-ERR: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int) <0x00014>
WASM-ERR: at System.AppContext.Setup (char**,char**,int) <0x00016>
WASM-ERR:
WASM-ERR: Nested exception:at System.RuntimeType.get_BaseType () <0x00056>
WASM-ERR: at System.Type.IsSubclassOf (System.Type) <0x00044>
WASM-ERR: at System.Reflection.CustomAttribute.IsDefined (System.Reflection.ICustomAttributeProvider,System.Type,bool) <0x00040>
WASM-ERR: at System.Reflection.RuntimeMethodInfo.IsDefined (System.Type,bool) <0x00016>
WASM-ERR: at System.Diagnostics.StackTrace.ShowInStackTrace (System.Reflection.MethodBase) <0x00048>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat,System.Text.StringBuilder) <0x000c8>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat) <0x00036>
WASM-ERR: at System.Exception.GetStackTrace (bool) <0x0006a>
WASM-ERR: at System.Exception.get_StackTrace () <0x0000e>
WASM-ERR: at System.Exception.ToString () <0x000ae>
WASM-ERR: at System.Exception.ToString () <0x00054>
WASM-ERR:
WASM-ERR:

      PR #48429 is adding a workaround for now which is rooting System.Runtime.InteropServices.Javascript.dll for the browser-wasm trimming tests so that we can have all tests running and passing, but this workaround should be removed once the underlying problem is fixed.
      cc: @marek-safar@eerhardt@lewing
      Metadata
      Metadata
      Assignees
      No one assigned
        Labels
        arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
        Type
        No type
        Projects
        No projects
          Milestone
          Relationships
          None yet
          Development
          No branches or pull requests
          Issue actions
          
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

          Skip to content
          System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm #48522
          Closed
          #48710
          Closed
          System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm#48522
          #48710
          Labels
          arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
          Milestone
          6.0.0
          Description
          @joperezr
          joperezr
          opened on Feb 19, 2021
          When trying to enable the linker Trimming Tests to run on browser-wasm, we found that some tests would fail due to the fact that System.Runtime.InteropServices.Javascript.dll is not getting preserved correctly when the app is built, causing runtime crashes when the test needs to marshal some types. One example of a test case that fails is GenericArraySortHelperTest which passes just fine if we manually root the IS.Javascript.dll, but if we remove that workaround the test fails with:
          root@168370dbdf5c:/home/joperezr/share/runtime/artifacts/bin/trimmingTests/projects/System.Runtime.TrimmingTests/GenericArraySortHelperTest/browser-wasm/bin/Release/net6.0/browser-wasm/AppBundle# ./run-v8.sh
Arguments: --run,project.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
WASM-ERR: [ERROR] FATAL UNHANDLED EXCEPTION: Nested exception detected.
WASM-ERR: Original Exception: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int,System.Collections.Generic.IEqualityComparer`1<string>) <0x00060>
WASM-ERR: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int) <0x00014>
WASM-ERR: at System.AppContext.Setup (char**,char**,int) <0x00016>
WASM-ERR:
WASM-ERR: Nested exception:at System.RuntimeType.get_BaseType () <0x00056>
WASM-ERR: at System.Type.IsSubclassOf (System.Type) <0x00044>
WASM-ERR: at System.Reflection.CustomAttribute.IsDefined (System.Reflection.ICustomAttributeProvider,System.Type,bool) <0x00040>
WASM-ERR: at System.Reflection.RuntimeMethodInfo.IsDefined (System.Type,bool) <0x00016>
WASM-ERR: at System.Diagnostics.StackTrace.ShowInStackTrace (System.Reflection.MethodBase) <0x00048>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat,System.Text.StringBuilder) <0x000c8>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat) <0x00036>
WASM-ERR: at System.Exception.GetStackTrace (bool) <0x0006a>
WASM-ERR: at System.Exception.get_StackTrace () <0x0000e>
WASM-ERR: at System.Exception.ToString () <0x000ae>
WASM-ERR: at System.Exception.ToString () <0x00054>
WASM-ERR:
WASM-ERR:

          PR #48429 is adding a workaround for now which is rooting System.Runtime.InteropServices.Javascript.dll for the browser-wasm trimming tests so that we can have all tests running and passing, but this workaround should be removed once the underlying problem is fixed.
          cc: @marek-safar@eerhardt@lewing
          Metadata
          Metadata
          Assignees
          No one assigned
            Labels
            arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
            Type
            No type
            Projects
            No projects
              Milestone
              Relationships
              None yet
              Development
              No branches or pull requests
              Issue actions
              
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

              Skip to content
              System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm #48522
              Closed
              #48710
              Closed
              System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm#48522
              #48710
              Labels
              arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
              Milestone
              6.0.0
              Description
              @joperezr
              joperezr
              opened on Feb 19, 2021
              When trying to enable the linker Trimming Tests to run on browser-wasm, we found that some tests would fail due to the fact that System.Runtime.InteropServices.Javascript.dll is not getting preserved correctly when the app is built, causing runtime crashes when the test needs to marshal some types. One example of a test case that fails is GenericArraySortHelperTest which passes just fine if we manually root the IS.Javascript.dll, but if we remove that workaround the test fails with:
              root@168370dbdf5c:/home/joperezr/share/runtime/artifacts/bin/trimmingTests/projects/System.Runtime.TrimmingTests/GenericArraySortHelperTest/browser-wasm/bin/Release/net6.0/browser-wasm/AppBundle# ./run-v8.sh
Arguments: --run,project.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
WASM-ERR: [ERROR] FATAL UNHANDLED EXCEPTION: Nested exception detected.
WASM-ERR: Original Exception: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int,System.Collections.Generic.IEqualityComparer`1<string>) <0x00060>
WASM-ERR: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int) <0x00014>
WASM-ERR: at System.AppContext.Setup (char**,char**,int) <0x00016>
WASM-ERR:
WASM-ERR: Nested exception:at System.RuntimeType.get_BaseType () <0x00056>
WASM-ERR: at System.Type.IsSubclassOf (System.Type) <0x00044>
WASM-ERR: at System.Reflection.CustomAttribute.IsDefined (System.Reflection.ICustomAttributeProvider,System.Type,bool) <0x00040>
WASM-ERR: at System.Reflection.RuntimeMethodInfo.IsDefined (System.Type,bool) <0x00016>
WASM-ERR: at System.Diagnostics.StackTrace.ShowInStackTrace (System.Reflection.MethodBase) <0x00048>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat,System.Text.StringBuilder) <0x000c8>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat) <0x00036>
WASM-ERR: at System.Exception.GetStackTrace (bool) <0x0006a>
WASM-ERR: at System.Exception.get_StackTrace () <0x0000e>
WASM-ERR: at System.Exception.ToString () <0x000ae>
WASM-ERR: at System.Exception.ToString () <0x00054>
WASM-ERR:
WASM-ERR:

              PR #48429 is adding a workaround for now which is rooting System.Runtime.InteropServices.Javascript.dll for the browser-wasm trimming tests so that we can have all tests running and passing, but this workaround should be removed once the underlying problem is fixed.
              cc: @marek-safar@eerhardt@lewing
              Metadata
              Metadata
              Assignees
              No one assigned
                Labels
                arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
                Type
                No type
                Projects
                No projects
                  Milestone
                  Relationships
                  None yet
                  Development
                  No branches or pull requests
                  Issue actions
                  
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

                  Skip to content
                  System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm #48522
                  Closed
                  #48710
                  Closed
                  System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm#48522
                  #48710
                  Labels
                  arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
                  Milestone
                  6.0.0
                  Description
                  @joperezr
                  joperezr
                  opened on Feb 19, 2021
                  When trying to enable the linker Trimming Tests to run on browser-wasm, we found that some tests would fail due to the fact that System.Runtime.InteropServices.Javascript.dll is not getting preserved correctly when the app is built, causing runtime crashes when the test needs to marshal some types. One example of a test case that fails is GenericArraySortHelperTest which passes just fine if we manually root the IS.Javascript.dll, but if we remove that workaround the test fails with:
                  root@168370dbdf5c:/home/joperezr/share/runtime/artifacts/bin/trimmingTests/projects/System.Runtime.TrimmingTests/GenericArraySortHelperTest/browser-wasm/bin/Release/net6.0/browser-wasm/AppBundle# ./run-v8.sh
Arguments: --run,project.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
WASM-ERR: [ERROR] FATAL UNHANDLED EXCEPTION: Nested exception detected.
WASM-ERR: Original Exception: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int,System.Collections.Generic.IEqualityComparer`1<string>) <0x00060>
WASM-ERR: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int) <0x00014>
WASM-ERR: at System.AppContext.Setup (char**,char**,int) <0x00016>
WASM-ERR:
WASM-ERR: Nested exception:at System.RuntimeType.get_BaseType () <0x00056>
WASM-ERR: at System.Type.IsSubclassOf (System.Type) <0x00044>
WASM-ERR: at System.Reflection.CustomAttribute.IsDefined (System.Reflection.ICustomAttributeProvider,System.Type,bool) <0x00040>
WASM-ERR: at System.Reflection.RuntimeMethodInfo.IsDefined (System.Type,bool) <0x00016>
WASM-ERR: at System.Diagnostics.StackTrace.ShowInStackTrace (System.Reflection.MethodBase) <0x00048>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat,System.Text.StringBuilder) <0x000c8>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat) <0x00036>
WASM-ERR: at System.Exception.GetStackTrace (bool) <0x0006a>
WASM-ERR: at System.Exception.get_StackTrace () <0x0000e>
WASM-ERR: at System.Exception.ToString () <0x000ae>
WASM-ERR: at System.Exception.ToString () <0x00054>
WASM-ERR:
WASM-ERR:

                  PR #48429 is adding a workaround for now which is rooting System.Runtime.InteropServices.Javascript.dll for the browser-wasm trimming tests so that we can have all tests running and passing, but this workaround should be removed once the underlying problem is fixed.
                  cc: @marek-safar@eerhardt@lewing
                  Metadata
                  Metadata
                  Assignees
                  No one assigned
                    Labels
                    arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
                    Type
                    No type
                    Projects
                    No projects
                      Milestone
                      Relationships
                      None yet
                      Development
                      No branches or pull requests
                      Issue actions
                      
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

                      Skip to content
                      System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm #48522
                      Closed
                      #48710
                      Closed
                      System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm#48522
                      #48710
                      Labels
                      arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
                      Milestone
                      6.0.0
                      Description
                      @joperezr
                      joperezr
                      opened on Feb 19, 2021
                      When trying to enable the linker Trimming Tests to run on browser-wasm, we found that some tests would fail due to the fact that System.Runtime.InteropServices.Javascript.dll is not getting preserved correctly when the app is built, causing runtime crashes when the test needs to marshal some types. One example of a test case that fails is GenericArraySortHelperTest which passes just fine if we manually root the IS.Javascript.dll, but if we remove that workaround the test fails with:
                      root@168370dbdf5c:/home/joperezr/share/runtime/artifacts/bin/trimmingTests/projects/System.Runtime.TrimmingTests/GenericArraySortHelperTest/browser-wasm/bin/Release/net6.0/browser-wasm/AppBundle# ./run-v8.sh
Arguments: --run,project.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
WASM-ERR: [ERROR] FATAL UNHANDLED EXCEPTION: Nested exception detected.
WASM-ERR: Original Exception: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int,System.Collections.Generic.IEqualityComparer`1<string>) <0x00060>
WASM-ERR: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int) <0x00014>
WASM-ERR: at System.AppContext.Setup (char**,char**,int) <0x00016>
WASM-ERR:
WASM-ERR: Nested exception:at System.RuntimeType.get_BaseType () <0x00056>
WASM-ERR: at System.Type.IsSubclassOf (System.Type) <0x00044>
WASM-ERR: at System.Reflection.CustomAttribute.IsDefined (System.Reflection.ICustomAttributeProvider,System.Type,bool) <0x00040>
WASM-ERR: at System.Reflection.RuntimeMethodInfo.IsDefined (System.Type,bool) <0x00016>
WASM-ERR: at System.Diagnostics.StackTrace.ShowInStackTrace (System.Reflection.MethodBase) <0x00048>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat,System.Text.StringBuilder) <0x000c8>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat) <0x00036>
WASM-ERR: at System.Exception.GetStackTrace (bool) <0x0006a>
WASM-ERR: at System.Exception.get_StackTrace () <0x0000e>
WASM-ERR: at System.Exception.ToString () <0x000ae>
WASM-ERR: at System.Exception.ToString () <0x00054>
WASM-ERR:
WASM-ERR:

                      PR #48429 is adding a workaround for now which is rooting System.Runtime.InteropServices.Javascript.dll for the browser-wasm trimming tests so that we can have all tests running and passing, but this workaround should be removed once the underlying problem is fixed.
                      cc: @marek-safar@eerhardt@lewing
                      Metadata
                      Metadata
                      Assignees
                      No one assigned
                        Labels
                        arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
                        Type
                        No type
                        Projects
                        No projects
                          Milestone
                          Relationships
                          None yet
                          Development
                          No branches or pull requests
                          Issue actions
                          
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

                          Skip to content
                          System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm #48522
                          Closed
                          #48710
                          Closed
                          System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm#48522
                          #48710
                          Labels
                          arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
                          Milestone
                          6.0.0
                          Description
                          @joperezr
                          joperezr
                          opened on Feb 19, 2021
                          When trying to enable the linker Trimming Tests to run on browser-wasm, we found that some tests would fail due to the fact that System.Runtime.InteropServices.Javascript.dll is not getting preserved correctly when the app is built, causing runtime crashes when the test needs to marshal some types. One example of a test case that fails is GenericArraySortHelperTest which passes just fine if we manually root the IS.Javascript.dll, but if we remove that workaround the test fails with:
                          root@168370dbdf5c:/home/joperezr/share/runtime/artifacts/bin/trimmingTests/projects/System.Runtime.TrimmingTests/GenericArraySortHelperTest/browser-wasm/bin/Release/net6.0/browser-wasm/AppBundle# ./run-v8.sh
Arguments: --run,project.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
WASM-ERR: [ERROR] FATAL UNHANDLED EXCEPTION: Nested exception detected.
WASM-ERR: Original Exception: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int,System.Collections.Generic.IEqualityComparer`1<string>) <0x00060>
WASM-ERR: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int) <0x00014>
WASM-ERR: at System.AppContext.Setup (char**,char**,int) <0x00016>
WASM-ERR:
WASM-ERR: Nested exception:at System.RuntimeType.get_BaseType () <0x00056>
WASM-ERR: at System.Type.IsSubclassOf (System.Type) <0x00044>
WASM-ERR: at System.Reflection.CustomAttribute.IsDefined (System.Reflection.ICustomAttributeProvider,System.Type,bool) <0x00040>
WASM-ERR: at System.Reflection.RuntimeMethodInfo.IsDefined (System.Type,bool) <0x00016>
WASM-ERR: at System.Diagnostics.StackTrace.ShowInStackTrace (System.Reflection.MethodBase) <0x00048>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat,System.Text.StringBuilder) <0x000c8>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat) <0x00036>
WASM-ERR: at System.Exception.GetStackTrace (bool) <0x0006a>
WASM-ERR: at System.Exception.get_StackTrace () <0x0000e>
WASM-ERR: at System.Exception.ToString () <0x000ae>
WASM-ERR: at System.Exception.ToString () <0x00054>
WASM-ERR:
WASM-ERR:

                          PR #48429 is adding a workaround for now which is rooting System.Runtime.InteropServices.Javascript.dll for the browser-wasm trimming tests so that we can have all tests running and passing, but this workaround should be removed once the underlying problem is fixed.
                          cc: @marek-safar@eerhardt@lewing
                          Metadata
                          Metadata
                          Assignees
                          No one assigned
                            Labels
                            arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
                            Type
                            No type
                            Projects
                            No projects
                              Milestone
                              Relationships
                              None yet
                              Development
                              No branches or pull requests
                              Issue actions
                              
, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

                              Skip to content
                              System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm #48522
                              Closed
                              #48710
                              Closed
                              System.Runtime.InteropServices.Javascript is getting trimmed out in some cases for browser-wasm#48522
                              #48710
                              Labels
                              arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
                              Milestone
                              6.0.0
                              Description
                              @joperezr
                              joperezr
                              opened on Feb 19, 2021
                              When trying to enable the linker Trimming Tests to run on browser-wasm, we found that some tests would fail due to the fact that System.Runtime.InteropServices.Javascript.dll is not getting preserved correctly when the app is built, causing runtime crashes when the test needs to marshal some types. One example of a test case that fails is GenericArraySortHelperTest which passes just fine if we manually root the IS.Javascript.dll, but if we remove that workaround the test fails with:
                              root@168370dbdf5c:/home/joperezr/share/runtime/artifacts/bin/trimmingTests/projects/System.Runtime.TrimmingTests/GenericArraySortHelperTest/browser-wasm/bin/Release/net6.0/browser-wasm/AppBundle# ./run-v8.sh
Arguments: --run,project.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
WASM-ERR: [ERROR] FATAL UNHANDLED EXCEPTION: Nested exception detected.
WASM-ERR: Original Exception: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int,System.Collections.Generic.IEqualityComparer`1<string>) <0x00060>
WASM-ERR: at System.Collections.Generic.Dictionary`2<string, object>..ctor (int) <0x00014>
WASM-ERR: at System.AppContext.Setup (char**,char**,int) <0x00016>
WASM-ERR:
WASM-ERR: Nested exception:at System.RuntimeType.get_BaseType () <0x00056>
WASM-ERR: at System.Type.IsSubclassOf (System.Type) <0x00044>
WASM-ERR: at System.Reflection.CustomAttribute.IsDefined (System.Reflection.ICustomAttributeProvider,System.Type,bool) <0x00040>
WASM-ERR: at System.Reflection.RuntimeMethodInfo.IsDefined (System.Type,bool) <0x00016>
WASM-ERR: at System.Diagnostics.StackTrace.ShowInStackTrace (System.Reflection.MethodBase) <0x00048>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat,System.Text.StringBuilder) <0x000c8>
WASM-ERR: at System.Diagnostics.StackTrace.ToString (System.Diagnostics.StackTrace/TraceFormat) <0x00036>
WASM-ERR: at System.Exception.GetStackTrace (bool) <0x0006a>
WASM-ERR: at System.Exception.get_StackTrace () <0x0000e>
WASM-ERR: at System.Exception.ToString () <0x000ae>
WASM-ERR: at System.Exception.ToString () <0x00054>
WASM-ERR:
WASM-ERR:

                              PR #48429 is adding a workaround for now which is rooting System.Runtime.InteropServices.Javascript.dll for the browser-wasm trimming tests so that we can have all tests running and passing, but this workaround should be removed once the underlying problem is fixed.
                              cc: @marek-safar@eerhardt@lewing
                              Metadata
                              Metadata
                              Assignees
                              No one assigned
                                Labels
                                arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptbuglinkable-frameworkIssues associated with delivering a linker friendly framework
                                Type
                                No type
                                Projects
                                No projects
                                  Milestone
                                  Relationships
                                  None yet
                                  Development
                                  No branches or pull requests
                                  Issue actions