Skip to content

Build break of calling convention __cdecl since appending of 'Interop' test folder #5318

Description

@leemgs

Even though __cdecl is accepted but typically ignored on ARM and x64 processors by the compiler, the cross build for Linux/ARM is broken (while doing the build time) by the [-Werror,-Wignored-attributes] policy of the compiler. This issue was suddenly generated since appending of 'Interop' test folder. Mr. @tijoytom, Could you explain us why we have to keep the __cdecl calling convention?.

/cc @jkotas , @benpye , @tijoytom

Build environment:

  • Build PC: Intel i5 CPU (quad core) , MEM 8GiB
  • Build OS: Ubuntu 14.04 X86 64bit
  • Memory: DDR3 8GiB
  • Commit number: 586ce53 (Fri Mar 11 18:57:50 2016)
  • Build command:
    u14.04$> cd ./coreclr
    u14.04$> time ROOTFS_DIR=/work/dotnet/rootfs-coreclr/arm ./build.sh arm debug verbose cross

Build Break:

 . . . . UPPER OMISSIOn . . . . . /usr/bin/clang++-3.5 -fPIC -Wall -Wno-null-conversion -std=c++11 -g -O0 -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -shared -Wl,-soname,libRefCharArrayNative.so -o libRefCharArrayNative.so CMakeFiles/RefCharArrayNative.dir/RefCharArrayNative.cpp.o /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:111:27: error: calling convention '__cdecl' ignored for this target
[-Werror,-Wignored-attributes]
extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char ...
^
/work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:127:28: error: calling convention '__cdecl' ignored for this target
[-Werror,-Wignored-attributes]
extern "C" DLL_EXPORT BOOL __cdecl RPinvoke_DelMarshal_InOut(Test_DelMar...
^
/work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:146:17: error: calling convention '__cdecl' ignored for this target
[-Werror,-Wignored-attributes]
typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
^
3 errors generated.
make[2]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/LPSTRTestNative.cpp.o] 오류 1
make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
make[1]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/all] 오류 2
make[1]: /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles *** 끝나지 않은 작업을 기다리고 있습니다....
/work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPTSTR/LPTSTRTestNative.cpp:129:17: error: calling convention '__cdecl' ignored for this target
[-Werror,-Wignored-attributes]
typedef LPTSTR (__cdecl * Test_Del_MarshalStrB_Out)(/*[out]*/ LPTSTR * s);
^
1 error generated.
/work/dotnet/arm32/coreclr/src/pal/tests/palsuite/exception_handling/pal_sxs/test1/exceptionsxs.cpp:74:5: error: calling convention '__cdecl' ignored for this target [-Werror,-Wignored-attributes]
int __cdecl main(int argc, char *argv[])
^
1 error generated.
[ 89%] make[2]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/exceptionsxs.cpp.o] 오류 1
make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
make[1]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/all] 오류 2
make[1]: *** 끝나지 않은 작업을 기다리고 있습니다....
Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/DependInfo.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
Scanning dependencies of target ilasm
make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
make -f src/jit/dll/CMakeFiles/ClrJit.dir/build.make src/jit/dll/CMakeFiles/ClrJit.dir/build
make -f src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build.make src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build
make[2]: Entering directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
/usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles

git blame:

invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 110,113 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
282b9fce (tijoytom 2016-03-03 21:14:14 +0000 110) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 111) extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char c, double d, short s, unsigned u)
282b9fce (tijoytom 2016-03-03 21:14:14 +0000 112) {
282b9fce (tijoytom 2016-03-03 21:14:14 +0000 113) int sum = i;
invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 121,126 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
282b9fce (tijoytom 2016-03-03 21:14:14 +0000 121) sum += (int)u;
282b9fce (tijoytom 2016-03-03 21:14:14 +0000 122) return sum;
282b9fce (tijoytom 2016-03-03 21:14:14 +0000 123) }
282b9fce (tijoytom 2016-03-03 21:14:14 +0000 124) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 125) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 126) typedef LPCTSTR (__stdcall * Test_DelMarshal_InOut)(/*[in]*/ LPCSTR s);
invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 142,147 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
282b9fce (tijoytom 2016-03-03 21:14:14 +0000 142) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 143) return TRUE;
282b9fce (tijoytom 2016-03-03 21:14:14 +0000 144) }
282b9fce (tijoytom 2016-03-03 21:14:14 +0000 145) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 146) typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
282b9fce (tijoytom 2016-03-03 21:14:14 +0000 147) extern "C" DLL_EXPORT BOOL WINAPI RPinvoke_DelMarshalPointer_Out(Test_DelMarshalPointer_Out d)
invain@DB400:/work/dotnet/arm32/coreclr$ 

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
       blocks
      (function() {
      function addCopyButtons() {
      document.querySelectorAll('pre code').forEach(function(codeBlock) {
      if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
      codeBlock.parentElement.setAttribute('data-copy-added', 'true');
      var btn = document.createElement('button');
      btn.textContent = 'Copy';
      btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
      btn.onmouseover = function() { this.style.opacity = '1'; };
      btn.onmouseout = function() { this.style.opacity = '0.7'; };
      btn.onclick = function() {
      navigator.clipboard.writeText(codeBlock.textContent).then(function() {
      btn.textContent = 'Copied!';
      setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
      });
      };
      codeBlock.parentElement.style.position = 'relative';
      codeBlock.parentElement.appendChild(btn);
      });
      }
      addCopyButtons();
      // Re-run on dynamic content
      var observer = new MutationObserver(addCopyButtons);
      observer.observe(document.body, { childList: true, subtree: true });
      })();
      }
      } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
      })();
      (function(){
      try {
      var __m = "github.com";
      var __re = new RegExp('^' + "github\\.com" + '
      Build break of calling convention __cdecl since appending of 'Interop' test folder · Issue #5318 · dotnet/runtime · GitHub
      Skip to content

      Build break of calling convention __cdecl since appending of 'Interop' test folder #5318

      Description

      @leemgs

      Even though __cdecl is accepted but typically ignored on ARM and x64 processors by the compiler, the cross build for Linux/ARM is broken (while doing the build time) by the [-Werror,-Wignored-attributes] policy of the compiler. This issue was suddenly generated since appending of 'Interop' test folder. Mr. @tijoytom, Could you explain us why we have to keep the __cdecl calling convention?.

      /cc @jkotas , @benpye , @tijoytom

      Build environment:

      • Build PC: Intel i5 CPU (quad core) , MEM 8GiB
      • Build OS: Ubuntu 14.04 X86 64bit
      • Memory: DDR3 8GiB
      • Commit number: 586ce53 (Fri Mar 11 18:57:50 2016)
      • Build command:
        u14.04$> cd ./coreclr
        u14.04$> time ROOTFS_DIR=/work/dotnet/rootfs-coreclr/arm ./build.sh arm debug verbose cross

      Build Break:

       . . . . UPPER OMISSIOn . . . . . /usr/bin/clang++-3.5 -fPIC -Wall -Wno-null-conversion -std=c++11 -g -O0 -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -shared -Wl,-soname,libRefCharArrayNative.so -o libRefCharArrayNative.so CMakeFiles/RefCharArrayNative.dir/RefCharArrayNative.cpp.o /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:111:27: error: calling convention '__cdecl' ignored for this target
      [-Werror,-Wignored-attributes]
      extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char ...
      ^
      /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:127:28: error: calling convention '__cdecl' ignored for this target
      [-Werror,-Wignored-attributes]
      extern "C" DLL_EXPORT BOOL __cdecl RPinvoke_DelMarshal_InOut(Test_DelMar...
      ^
      /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:146:17: error: calling convention '__cdecl' ignored for this target
      [-Werror,-Wignored-attributes]
      typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
      ^
      3 errors generated.
      make[2]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/LPSTRTestNative.cpp.o] 오류 1
      make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
      make[1]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/all] 오류 2
      make[1]: /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles *** 끝나지 않은 작업을 기다리고 있습니다....
      /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPTSTR/LPTSTRTestNative.cpp:129:17: error: calling convention '__cdecl' ignored for this target
      [-Werror,-Wignored-attributes]
      typedef LPTSTR (__cdecl * Test_Del_MarshalStrB_Out)(/*[out]*/ LPTSTR * s);
      ^
      1 error generated.
      /work/dotnet/arm32/coreclr/src/pal/tests/palsuite/exception_handling/pal_sxs/test1/exceptionsxs.cpp:74:5: error: calling convention '__cdecl' ignored for this target [-Werror,-Wignored-attributes]
      int __cdecl main(int argc, char *argv[])
      ^
      1 error generated.
      [ 89%] make[2]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/exceptionsxs.cpp.o] 오류 1
      make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
      make[1]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/all] 오류 2
      make[1]: *** 끝나지 않은 작업을 기다리고 있습니다....
      Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/DependInfo.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
      Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
      Scanning dependencies of target ilasm
      make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
      make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
      make -f src/jit/dll/CMakeFiles/ClrJit.dir/build.make src/jit/dll/CMakeFiles/ClrJit.dir/build
      make -f src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build.make src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build
      make[2]: Entering directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
      /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles
      

      git blame:

      invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 110,113 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 110) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 111) extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char c, double d, short s, unsigned u)
      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 112) {
      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 113) int sum = i;
      invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 121,126 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 121) sum += (int)u;
      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 122) return sum;
      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 123) }
      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 124) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 125) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 126) typedef LPCTSTR (__stdcall * Test_DelMarshal_InOut)(/*[in]*/ LPCSTR s);
      invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 142,147 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 142) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 143) return TRUE;
      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 144) }
      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 145) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 146) typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 147) extern "C" DLL_EXPORT BOOL WINAPI RPinvoke_DelMarshalPointer_Out(Test_DelMarshalPointer_Out d)
      invain@DB400:/work/dotnet/arm32/coreclr$ 

      Metadata

      Metadata

      Assignees

      No one assigned

        Type

        No type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Build break of calling convention __cdecl since appending of 'Interop' test folder · Issue #5318 · dotnet/runtime · GitHub
          Skip to content

          Build break of calling convention __cdecl since appending of 'Interop' test folder #5318

          Description

          @leemgs

          Even though __cdecl is accepted but typically ignored on ARM and x64 processors by the compiler, the cross build for Linux/ARM is broken (while doing the build time) by the [-Werror,-Wignored-attributes] policy of the compiler. This issue was suddenly generated since appending of 'Interop' test folder. Mr. @tijoytom, Could you explain us why we have to keep the __cdecl calling convention?.

          /cc @jkotas , @benpye , @tijoytom

          Build environment:

          • Build PC: Intel i5 CPU (quad core) , MEM 8GiB
          • Build OS: Ubuntu 14.04 X86 64bit
          • Memory: DDR3 8GiB
          • Commit number: 586ce53 (Fri Mar 11 18:57:50 2016)
          • Build command:
            u14.04$> cd ./coreclr
            u14.04$> time ROOTFS_DIR=/work/dotnet/rootfs-coreclr/arm ./build.sh arm debug verbose cross

          Build Break:

           . . . . UPPER OMISSIOn . . . . . /usr/bin/clang++-3.5 -fPIC -Wall -Wno-null-conversion -std=c++11 -g -O0 -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -shared -Wl,-soname,libRefCharArrayNative.so -o libRefCharArrayNative.so CMakeFiles/RefCharArrayNative.dir/RefCharArrayNative.cpp.o /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:111:27: error: calling convention '__cdecl' ignored for this target
          [-Werror,-Wignored-attributes]
          extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char ...
          ^
          /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:127:28: error: calling convention '__cdecl' ignored for this target
          [-Werror,-Wignored-attributes]
          extern "C" DLL_EXPORT BOOL __cdecl RPinvoke_DelMarshal_InOut(Test_DelMar...
          ^
          /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:146:17: error: calling convention '__cdecl' ignored for this target
          [-Werror,-Wignored-attributes]
          typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
          ^
          3 errors generated.
          make[2]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/LPSTRTestNative.cpp.o] 오류 1
          make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
          make[1]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/all] 오류 2
          make[1]: /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles *** 끝나지 않은 작업을 기다리고 있습니다....
          /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPTSTR/LPTSTRTestNative.cpp:129:17: error: calling convention '__cdecl' ignored for this target
          [-Werror,-Wignored-attributes]
          typedef LPTSTR (__cdecl * Test_Del_MarshalStrB_Out)(/*[out]*/ LPTSTR * s);
          ^
          1 error generated.
          /work/dotnet/arm32/coreclr/src/pal/tests/palsuite/exception_handling/pal_sxs/test1/exceptionsxs.cpp:74:5: error: calling convention '__cdecl' ignored for this target [-Werror,-Wignored-attributes]
          int __cdecl main(int argc, char *argv[])
          ^
          1 error generated.
          [ 89%] make[2]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/exceptionsxs.cpp.o] 오류 1
          make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
          make[1]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/all] 오류 2
          make[1]: *** 끝나지 않은 작업을 기다리고 있습니다....
          Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/DependInfo.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
          Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
          Scanning dependencies of target ilasm
          make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
          make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
          make -f src/jit/dll/CMakeFiles/ClrJit.dir/build.make src/jit/dll/CMakeFiles/ClrJit.dir/build
          make -f src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build.make src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build
          make[2]: Entering directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
          /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles
          

          git blame:

          invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 110,113 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 110) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 111) extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char c, double d, short s, unsigned u)
          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 112) {
          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 113) int sum = i;
          invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 121,126 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 121) sum += (int)u;
          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 122) return sum;
          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 123) }
          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 124) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 125) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 126) typedef LPCTSTR (__stdcall * Test_DelMarshal_InOut)(/*[in]*/ LPCSTR s);
          invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 142,147 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 142) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 143) return TRUE;
          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 144) }
          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 145) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 146) typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 147) extern "C" DLL_EXPORT BOOL WINAPI RPinvoke_DelMarshalPointer_Out(Test_DelMarshalPointer_Out d)
          invain@DB400:/work/dotnet/arm32/coreclr$ 

          Metadata

          Metadata

          Assignees

          No one assigned

            Type

            No type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Build break of calling convention __cdecl since appending of 'Interop' test folder · Issue #5318 · dotnet/runtime · GitHub
              Skip to content

              Build break of calling convention __cdecl since appending of 'Interop' test folder #5318

              Description

              @leemgs

              Even though __cdecl is accepted but typically ignored on ARM and x64 processors by the compiler, the cross build for Linux/ARM is broken (while doing the build time) by the [-Werror,-Wignored-attributes] policy of the compiler. This issue was suddenly generated since appending of 'Interop' test folder. Mr. @tijoytom, Could you explain us why we have to keep the __cdecl calling convention?.

              /cc @jkotas , @benpye , @tijoytom

              Build environment:

              • Build PC: Intel i5 CPU (quad core) , MEM 8GiB
              • Build OS: Ubuntu 14.04 X86 64bit
              • Memory: DDR3 8GiB
              • Commit number: 586ce53 (Fri Mar 11 18:57:50 2016)
              • Build command:
                u14.04$> cd ./coreclr
                u14.04$> time ROOTFS_DIR=/work/dotnet/rootfs-coreclr/arm ./build.sh arm debug verbose cross

              Build Break:

               . . . . UPPER OMISSIOn . . . . . /usr/bin/clang++-3.5 -fPIC -Wall -Wno-null-conversion -std=c++11 -g -O0 -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -shared -Wl,-soname,libRefCharArrayNative.so -o libRefCharArrayNative.so CMakeFiles/RefCharArrayNative.dir/RefCharArrayNative.cpp.o /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:111:27: error: calling convention '__cdecl' ignored for this target
              [-Werror,-Wignored-attributes]
              extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char ...
              ^
              /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:127:28: error: calling convention '__cdecl' ignored for this target
              [-Werror,-Wignored-attributes]
              extern "C" DLL_EXPORT BOOL __cdecl RPinvoke_DelMarshal_InOut(Test_DelMar...
              ^
              /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:146:17: error: calling convention '__cdecl' ignored for this target
              [-Werror,-Wignored-attributes]
              typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
              ^
              3 errors generated.
              make[2]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/LPSTRTestNative.cpp.o] 오류 1
              make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
              make[1]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/all] 오류 2
              make[1]: /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles *** 끝나지 않은 작업을 기다리고 있습니다....
              /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPTSTR/LPTSTRTestNative.cpp:129:17: error: calling convention '__cdecl' ignored for this target
              [-Werror,-Wignored-attributes]
              typedef LPTSTR (__cdecl * Test_Del_MarshalStrB_Out)(/*[out]*/ LPTSTR * s);
              ^
              1 error generated.
              /work/dotnet/arm32/coreclr/src/pal/tests/palsuite/exception_handling/pal_sxs/test1/exceptionsxs.cpp:74:5: error: calling convention '__cdecl' ignored for this target [-Werror,-Wignored-attributes]
              int __cdecl main(int argc, char *argv[])
              ^
              1 error generated.
              [ 89%] make[2]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/exceptionsxs.cpp.o] 오류 1
              make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
              make[1]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/all] 오류 2
              make[1]: *** 끝나지 않은 작업을 기다리고 있습니다....
              Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/DependInfo.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
              Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
              Scanning dependencies of target ilasm
              make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
              make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
              make -f src/jit/dll/CMakeFiles/ClrJit.dir/build.make src/jit/dll/CMakeFiles/ClrJit.dir/build
              make -f src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build.make src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build
              make[2]: Entering directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
              /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles
              

              git blame:

              invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 110,113 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 110) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 111) extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char c, double d, short s, unsigned u)
              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 112) {
              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 113) int sum = i;
              invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 121,126 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 121) sum += (int)u;
              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 122) return sum;
              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 123) }
              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 124) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 125) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 126) typedef LPCTSTR (__stdcall * Test_DelMarshal_InOut)(/*[in]*/ LPCSTR s);
              invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 142,147 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 142) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 143) return TRUE;
              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 144) }
              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 145) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 146) typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 147) extern "C" DLL_EXPORT BOOL WINAPI RPinvoke_DelMarshalPointer_Out(Test_DelMarshalPointer_Out d)
              invain@DB400:/work/dotnet/arm32/coreclr$ 

              Metadata

              Metadata

              Assignees

              No one assigned

                Type

                No type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Build break of calling convention __cdecl since appending of 'Interop' test folder · Issue #5318 · dotnet/runtime · GitHub
                  Skip to content

                  Build break of calling convention __cdecl since appending of 'Interop' test folder #5318

                  Description

                  @leemgs

                  Even though __cdecl is accepted but typically ignored on ARM and x64 processors by the compiler, the cross build for Linux/ARM is broken (while doing the build time) by the [-Werror,-Wignored-attributes] policy of the compiler. This issue was suddenly generated since appending of 'Interop' test folder. Mr. @tijoytom, Could you explain us why we have to keep the __cdecl calling convention?.

                  /cc @jkotas , @benpye , @tijoytom

                  Build environment:

                  • Build PC: Intel i5 CPU (quad core) , MEM 8GiB
                  • Build OS: Ubuntu 14.04 X86 64bit
                  • Memory: DDR3 8GiB
                  • Commit number: 586ce53 (Fri Mar 11 18:57:50 2016)
                  • Build command:
                    u14.04$> cd ./coreclr
                    u14.04$> time ROOTFS_DIR=/work/dotnet/rootfs-coreclr/arm ./build.sh arm debug verbose cross

                  Build Break:

                   . . . . UPPER OMISSIOn . . . . . /usr/bin/clang++-3.5 -fPIC -Wall -Wno-null-conversion -std=c++11 -g -O0 -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -shared -Wl,-soname,libRefCharArrayNative.so -o libRefCharArrayNative.so CMakeFiles/RefCharArrayNative.dir/RefCharArrayNative.cpp.o /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:111:27: error: calling convention '__cdecl' ignored for this target
                  [-Werror,-Wignored-attributes]
                  extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char ...
                  ^
                  /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:127:28: error: calling convention '__cdecl' ignored for this target
                  [-Werror,-Wignored-attributes]
                  extern "C" DLL_EXPORT BOOL __cdecl RPinvoke_DelMarshal_InOut(Test_DelMar...
                  ^
                  /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:146:17: error: calling convention '__cdecl' ignored for this target
                  [-Werror,-Wignored-attributes]
                  typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
                  ^
                  3 errors generated.
                  make[2]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/LPSTRTestNative.cpp.o] 오류 1
                  make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                  make[1]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/all] 오류 2
                  make[1]: /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles *** 끝나지 않은 작업을 기다리고 있습니다....
                  /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPTSTR/LPTSTRTestNative.cpp:129:17: error: calling convention '__cdecl' ignored for this target
                  [-Werror,-Wignored-attributes]
                  typedef LPTSTR (__cdecl * Test_Del_MarshalStrB_Out)(/*[out]*/ LPTSTR * s);
                  ^
                  1 error generated.
                  /work/dotnet/arm32/coreclr/src/pal/tests/palsuite/exception_handling/pal_sxs/test1/exceptionsxs.cpp:74:5: error: calling convention '__cdecl' ignored for this target [-Werror,-Wignored-attributes]
                  int __cdecl main(int argc, char *argv[])
                  ^
                  1 error generated.
                  [ 89%] make[2]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/exceptionsxs.cpp.o] 오류 1
                  make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                  make[1]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/all] 오류 2
                  make[1]: *** 끝나지 않은 작업을 기다리고 있습니다....
                  Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/DependInfo.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
                  Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
                  Scanning dependencies of target ilasm
                  make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                  make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                  make -f src/jit/dll/CMakeFiles/ClrJit.dir/build.make src/jit/dll/CMakeFiles/ClrJit.dir/build
                  make -f src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build.make src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build
                  make[2]: Entering directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                  /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles
                  

                  git blame:

                  invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 110,113 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                  282b9fce (tijoytom 2016-03-03 21:14:14 +0000 110) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 111) extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char c, double d, short s, unsigned u)
                  282b9fce (tijoytom 2016-03-03 21:14:14 +0000 112) {
                  282b9fce (tijoytom 2016-03-03 21:14:14 +0000 113) int sum = i;
                  invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 121,126 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                  282b9fce (tijoytom 2016-03-03 21:14:14 +0000 121) sum += (int)u;
                  282b9fce (tijoytom 2016-03-03 21:14:14 +0000 122) return sum;
                  282b9fce (tijoytom 2016-03-03 21:14:14 +0000 123) }
                  282b9fce (tijoytom 2016-03-03 21:14:14 +0000 124) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 125) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 126) typedef LPCTSTR (__stdcall * Test_DelMarshal_InOut)(/*[in]*/ LPCSTR s);
                  invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 142,147 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                  282b9fce (tijoytom 2016-03-03 21:14:14 +0000 142) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 143) return TRUE;
                  282b9fce (tijoytom 2016-03-03 21:14:14 +0000 144) }
                  282b9fce (tijoytom 2016-03-03 21:14:14 +0000 145) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 146) typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
                  282b9fce (tijoytom 2016-03-03 21:14:14 +0000 147) extern "C" DLL_EXPORT BOOL WINAPI RPinvoke_DelMarshalPointer_Out(Test_DelMarshalPointer_Out d)
                  invain@DB400:/work/dotnet/arm32/coreclr$ 

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Type

                    No type

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Build break of calling convention __cdecl since appending of 'Interop' test folder · Issue #5318 · dotnet/runtime · GitHub
                      Skip to content

                      Build break of calling convention __cdecl since appending of 'Interop' test folder #5318

                      Description

                      @leemgs

                      Even though __cdecl is accepted but typically ignored on ARM and x64 processors by the compiler, the cross build for Linux/ARM is broken (while doing the build time) by the [-Werror,-Wignored-attributes] policy of the compiler. This issue was suddenly generated since appending of 'Interop' test folder. Mr. @tijoytom, Could you explain us why we have to keep the __cdecl calling convention?.

                      /cc @jkotas , @benpye , @tijoytom

                      Build environment:

                      • Build PC: Intel i5 CPU (quad core) , MEM 8GiB
                      • Build OS: Ubuntu 14.04 X86 64bit
                      • Memory: DDR3 8GiB
                      • Commit number: 586ce53 (Fri Mar 11 18:57:50 2016)
                      • Build command:
                        u14.04$> cd ./coreclr
                        u14.04$> time ROOTFS_DIR=/work/dotnet/rootfs-coreclr/arm ./build.sh arm debug verbose cross

                      Build Break:

                       . . . . UPPER OMISSIOn . . . . . /usr/bin/clang++-3.5 -fPIC -Wall -Wno-null-conversion -std=c++11 -g -O0 -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -shared -Wl,-soname,libRefCharArrayNative.so -o libRefCharArrayNative.so CMakeFiles/RefCharArrayNative.dir/RefCharArrayNative.cpp.o /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:111:27: error: calling convention '__cdecl' ignored for this target
                      [-Werror,-Wignored-attributes]
                      extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char ...
                      ^
                      /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:127:28: error: calling convention '__cdecl' ignored for this target
                      [-Werror,-Wignored-attributes]
                      extern "C" DLL_EXPORT BOOL __cdecl RPinvoke_DelMarshal_InOut(Test_DelMar...
                      ^
                      /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:146:17: error: calling convention '__cdecl' ignored for this target
                      [-Werror,-Wignored-attributes]
                      typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
                      ^
                      3 errors generated.
                      make[2]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/LPSTRTestNative.cpp.o] 오류 1
                      make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                      make[1]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/all] 오류 2
                      make[1]: /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles *** 끝나지 않은 작업을 기다리고 있습니다....
                      /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPTSTR/LPTSTRTestNative.cpp:129:17: error: calling convention '__cdecl' ignored for this target
                      [-Werror,-Wignored-attributes]
                      typedef LPTSTR (__cdecl * Test_Del_MarshalStrB_Out)(/*[out]*/ LPTSTR * s);
                      ^
                      1 error generated.
                      /work/dotnet/arm32/coreclr/src/pal/tests/palsuite/exception_handling/pal_sxs/test1/exceptionsxs.cpp:74:5: error: calling convention '__cdecl' ignored for this target [-Werror,-Wignored-attributes]
                      int __cdecl main(int argc, char *argv[])
                      ^
                      1 error generated.
                      [ 89%] make[2]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/exceptionsxs.cpp.o] 오류 1
                      make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                      make[1]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/all] 오류 2
                      make[1]: *** 끝나지 않은 작업을 기다리고 있습니다....
                      Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/DependInfo.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
                      Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
                      Scanning dependencies of target ilasm
                      make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                      make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                      make -f src/jit/dll/CMakeFiles/ClrJit.dir/build.make src/jit/dll/CMakeFiles/ClrJit.dir/build
                      make -f src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build.make src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build
                      make[2]: Entering directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                      /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles
                      

                      git blame:

                      invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 110,113 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 110) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 111) extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char c, double d, short s, unsigned u)
                      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 112) {
                      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 113) int sum = i;
                      invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 121,126 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 121) sum += (int)u;
                      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 122) return sum;
                      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 123) }
                      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 124) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 125) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 126) typedef LPCTSTR (__stdcall * Test_DelMarshal_InOut)(/*[in]*/ LPCSTR s);
                      invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 142,147 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 142) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 143) return TRUE;
                      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 144) }
                      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 145) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 146) typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
                      282b9fce (tijoytom 2016-03-03 21:14:14 +0000 147) extern "C" DLL_EXPORT BOOL WINAPI RPinvoke_DelMarshalPointer_Out(Test_DelMarshalPointer_Out d)
                      invain@DB400:/work/dotnet/arm32/coreclr$ 

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Type

                        No type

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Build break of calling convention __cdecl since appending of 'Interop' test folder · Issue #5318 · dotnet/runtime · GitHub
                          Skip to content

                          Build break of calling convention __cdecl since appending of 'Interop' test folder #5318

                          Description

                          @leemgs

                          Even though __cdecl is accepted but typically ignored on ARM and x64 processors by the compiler, the cross build for Linux/ARM is broken (while doing the build time) by the [-Werror,-Wignored-attributes] policy of the compiler. This issue was suddenly generated since appending of 'Interop' test folder. Mr. @tijoytom, Could you explain us why we have to keep the __cdecl calling convention?.

                          /cc @jkotas , @benpye , @tijoytom

                          Build environment:

                          • Build PC: Intel i5 CPU (quad core) , MEM 8GiB
                          • Build OS: Ubuntu 14.04 X86 64bit
                          • Memory: DDR3 8GiB
                          • Commit number: 586ce53 (Fri Mar 11 18:57:50 2016)
                          • Build command:
                            u14.04$> cd ./coreclr
                            u14.04$> time ROOTFS_DIR=/work/dotnet/rootfs-coreclr/arm ./build.sh arm debug verbose cross

                          Build Break:

                           . . . . UPPER OMISSIOn . . . . . /usr/bin/clang++-3.5 -fPIC -Wall -Wno-null-conversion -std=c++11 -g -O0 -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -shared -Wl,-soname,libRefCharArrayNative.so -o libRefCharArrayNative.so CMakeFiles/RefCharArrayNative.dir/RefCharArrayNative.cpp.o /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:111:27: error: calling convention '__cdecl' ignored for this target
                          [-Werror,-Wignored-attributes]
                          extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char ...
                          ^
                          /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:127:28: error: calling convention '__cdecl' ignored for this target
                          [-Werror,-Wignored-attributes]
                          extern "C" DLL_EXPORT BOOL __cdecl RPinvoke_DelMarshal_InOut(Test_DelMar...
                          ^
                          /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:146:17: error: calling convention '__cdecl' ignored for this target
                          [-Werror,-Wignored-attributes]
                          typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
                          ^
                          3 errors generated.
                          make[2]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/LPSTRTestNative.cpp.o] 오류 1
                          make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                          make[1]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/all] 오류 2
                          make[1]: /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles *** 끝나지 않은 작업을 기다리고 있습니다....
                          /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPTSTR/LPTSTRTestNative.cpp:129:17: error: calling convention '__cdecl' ignored for this target
                          [-Werror,-Wignored-attributes]
                          typedef LPTSTR (__cdecl * Test_Del_MarshalStrB_Out)(/*[out]*/ LPTSTR * s);
                          ^
                          1 error generated.
                          /work/dotnet/arm32/coreclr/src/pal/tests/palsuite/exception_handling/pal_sxs/test1/exceptionsxs.cpp:74:5: error: calling convention '__cdecl' ignored for this target [-Werror,-Wignored-attributes]
                          int __cdecl main(int argc, char *argv[])
                          ^
                          1 error generated.
                          [ 89%] make[2]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/exceptionsxs.cpp.o] 오류 1
                          make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                          make[1]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/all] 오류 2
                          make[1]: *** 끝나지 않은 작업을 기다리고 있습니다....
                          Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/DependInfo.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
                          Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
                          Scanning dependencies of target ilasm
                          make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                          make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                          make -f src/jit/dll/CMakeFiles/ClrJit.dir/build.make src/jit/dll/CMakeFiles/ClrJit.dir/build
                          make -f src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build.make src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build
                          make[2]: Entering directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                          /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles
                          

                          git blame:

                          invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 110,113 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 110) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 111) extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char c, double d, short s, unsigned u)
                          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 112) {
                          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 113) int sum = i;
                          invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 121,126 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 121) sum += (int)u;
                          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 122) return sum;
                          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 123) }
                          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 124) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 125) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 126) typedef LPCTSTR (__stdcall * Test_DelMarshal_InOut)(/*[in]*/ LPCSTR s);
                          invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 142,147 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 142) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 143) return TRUE;
                          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 144) }
                          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 145) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 146) typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
                          282b9fce (tijoytom 2016-03-03 21:14:14 +0000 147) extern "C" DLL_EXPORT BOOL WINAPI RPinvoke_DelMarshalPointer_Out(Test_DelMarshalPointer_Out d)
                          invain@DB400:/work/dotnet/arm32/coreclr$ 

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Type

                            No type

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Build break of calling convention __cdecl since appending of 'Interop' test folder · Issue #5318 · dotnet/runtime · GitHub
                              Skip to content

                              Build break of calling convention __cdecl since appending of 'Interop' test folder #5318

                              Description

                              @leemgs

                              Even though __cdecl is accepted but typically ignored on ARM and x64 processors by the compiler, the cross build for Linux/ARM is broken (while doing the build time) by the [-Werror,-Wignored-attributes] policy of the compiler. This issue was suddenly generated since appending of 'Interop' test folder. Mr. @tijoytom, Could you explain us why we have to keep the __cdecl calling convention?.

                              /cc @jkotas , @benpye , @tijoytom

                              Build environment:

                              • Build PC: Intel i5 CPU (quad core) , MEM 8GiB
                              • Build OS: Ubuntu 14.04 X86 64bit
                              • Memory: DDR3 8GiB
                              • Commit number: 586ce53 (Fri Mar 11 18:57:50 2016)
                              • Build command:
                                u14.04$> cd ./coreclr
                                u14.04$> time ROOTFS_DIR=/work/dotnet/rootfs-coreclr/arm ./build.sh arm debug verbose cross

                              Build Break:

                               . . . . UPPER OMISSIOn . . . . . /usr/bin/clang++-3.5 -fPIC -Wall -Wno-null-conversion -std=c++11 -g -O0 -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -target arm-linux-gnueabihf -B /work/dotnet/rootfs-coreclr/arm/usr/lib/gcc/arm-linux-gnueabihf -L/work/dotnet/rootfs-coreclr/arm/lib/arm-linux-gnueabihf --sysroot=/work/dotnet/rootfs-coreclr/arm -shared -Wl,-soname,libRefCharArrayNative.so -o libRefCharArrayNative.so CMakeFiles/RefCharArrayNative.dir/RefCharArrayNative.cpp.o /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:111:27: error: calling convention '__cdecl' ignored for this target
                              [-Werror,-Wignored-attributes]
                              extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char ...
                              ^
                              /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:127:28: error: calling convention '__cdecl' ignored for this target
                              [-Werror,-Wignored-attributes]
                              extern "C" DLL_EXPORT BOOL __cdecl RPinvoke_DelMarshal_InOut(Test_DelMar...
                              ^
                              /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp:146:17: error: calling convention '__cdecl' ignored for this target
                              [-Werror,-Wignored-attributes]
                              typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
                              ^
                              3 errors generated.
                              make[2]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/LPSTRTestNative.cpp.o] 오류 1
                              make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                              make[1]: *** [tests/src/Interop/StringMarshalling/LPSTR/CMakeFiles/LPSTRTestNative.dir/all] 오류 2
                              make[1]: /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles *** 끝나지 않은 작업을 기다리고 있습니다....
                              /work/dotnet/arm32/coreclr/tests/src/Interop/StringMarshalling/LPTSTR/LPTSTRTestNative.cpp:129:17: error: calling convention '__cdecl' ignored for this target
                              [-Werror,-Wignored-attributes]
                              typedef LPTSTR (__cdecl * Test_Del_MarshalStrB_Out)(/*[out]*/ LPTSTR * s);
                              ^
                              1 error generated.
                              /work/dotnet/arm32/coreclr/src/pal/tests/palsuite/exception_handling/pal_sxs/test1/exceptionsxs.cpp:74:5: error: calling convention '__cdecl' ignored for this target [-Werror,-Wignored-attributes]
                              int __cdecl main(int argc, char *argv[])
                              ^
                              1 error generated.
                              [ 89%] make[2]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/exceptionsxs.cpp.o] 오류 1
                              make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                              make[1]: *** [src/pal/tests/palsuite/exception_handling/pal_sxs/test1/CMakeFiles/paltest_pal_sxs_test1.dir/all] 오류 2
                              make[1]: *** 끝나지 않은 작업을 기다리고 있습니다....
                              Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/DependInfo.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
                              Dependee "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/src/ilasm/CMakeFiles/ilasm.dir/depend.internal".
                              Scanning dependencies of target ilasm
                              make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                              make[2]: Leaving directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                              make -f src/jit/dll/CMakeFiles/ClrJit.dir/build.make src/jit/dll/CMakeFiles/ClrJit.dir/build
                              make -f src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build.make src/dlls/dbgshim/CMakeFiles/dbgshim.dir/build
                              make[2]: Entering directory `/work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug'
                              /usr/bin/cmake -E cmake_progress_report /work/dotnet/arm32/coreclr/bin/obj/Linux.arm.Debug/CMakeFiles
                              

                              git blame:

                              invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 110,113 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 110) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 111) extern "C" DLL_EXPORT int __cdecl Writeline(char * pFormat, int i, char c, double d, short s, unsigned u)
                              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 112) {
                              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 113) int sum = i;
                              invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 121,126 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 121) sum += (int)u;
                              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 122) return sum;
                              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 123) }
                              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 124) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 125) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 126) typedef LPCTSTR (__stdcall * Test_DelMarshal_InOut)(/*[in]*/ LPCSTR s);
                              invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ invain@DB400:/work/dotnet/arm32/coreclr$ git blame -L 142,147 tests/src/Interop/StringMarshalling/LPSTR/LPSTRTestNative.cpp
                              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 142) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 143) return TRUE;
                              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 144) }
                              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 145) 282b9fce (tijoytom 2016-03-03 21:14:14 +0000 146) typedef LPCSTR (__cdecl * Test_DelMarshalPointer_Out)(/*[out]*/ LPSTR * s);
                              282b9fce (tijoytom 2016-03-03 21:14:14 +0000 147) extern "C" DLL_EXPORT BOOL WINAPI RPinvoke_DelMarshalPointer_Out(Test_DelMarshalPointer_Out d)
                              invain@DB400:/work/dotnet/arm32/coreclr$ 

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Type

                                No type

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions