For exact reasons unknown, we're seeing failures in certain StringTests tests when using hu-HU and tr-TR cultures. We should see if the tests can be tweaked for Android or if they should be skipped outright. I suspect it's platform specific.
1.) System.Tests.StringTests.Contains_StringComparison_TurkishI
| Assert.True(Source.Contains("\u0069\u0069",StringComparison.CurrentCultureIgnoreCase)); |
| Assert.True(Source.AsSpan().Contains("\u0069\u0069",StringComparison.CurrentCultureIgnoreCase)); |
Exception messages: Assert.True() Failure
Expected: True
2.) System.Tests.StringTests.IndexOf_HungarianDoubleCompression_HungarianCulture
| Assert.Equal(PlatformDetection.IsNlsGlobalization?0:-1,source.IndexOf(target)); |
| Assert.Equal(PlatformDetection.IsNlsGlobalization?0:-1,source.IndexOf(target,StringComparison.CurrentCulture)); |
| |
| Assert.Equal(0,source.IndexOf(target,StringComparison.CurrentCultureIgnoreCase)); |
| Assert.Equal(-1,source.IndexOf(target,StringComparison.Ordinal)); |
| Assert.Equal(-1,source.IndexOf(target,StringComparison.OrdinalIgnoreCase)); |
| |
| ReadOnlySpan<char>span=source.AsSpan(); |
| |
| Assert.Equal(PlatformDetection.IsNlsGlobalization?0:-1,span.IndexOf(target.AsSpan(),StringComparison.CurrentCulture)); |
| |
| Assert.Equal(0,span.IndexOf(target.AsSpan(),StringComparison.CurrentCultureIgnoreCase)); |
| Assert.Equal(-1,span.IndexOf(target.AsSpan(),StringComparison.Ordinal)); |
| Assert.Equal(-1,span.IndexOf(target.AsSpan(),StringComparison.OrdinalIgnoreCase)); |
Exception messages: Assert.Equal() Failure
Expected: 0
Actual: -1
3.) System.Tests.StringTests.ToUpper_TurkishI_TurkishCulture
| Assert.True(s.ToUpper().Equals(expected,StringComparison.Ordinal),"Actual: "+s.ToUpper()); |
Exception messages: Actual: I
Expected: True
Actual: False
4.) System.Tests.StringTests.Replace_StringComparison_TurkishI
| Assert.True("\u0069".Equals("\u0130",StringComparison.CurrentCultureIgnoreCase)); |
Exception messages: Assert.True() Failure
Expected: True
Actual: False
5.) System.Tests.StringTests.IndexOf_TurkishI_TurkishCulture
| Assert.Equal(4,s.IndexOf(value,StringComparison.CurrentCultureIgnoreCase)); |
Assert.Equal() Failure
Expected: 4
Actual: 19
For exact reasons unknown, we're seeing failures in certain StringTests tests when using hu-HU and tr-TR cultures. We should see if the tests can be tweaked for Android or if they should be skipped outright. I suspect it's platform specific.
1.) System.Tests.StringTests.Contains_StringComparison_TurkishI
runtime/src/libraries/System.Runtime/tests/System/StringTests.cs
Lines 324 to 325 in dfd618d
2.) System.Tests.StringTests.IndexOf_HungarianDoubleCompression_HungarianCulture
runtime/src/libraries/Common/tests/Tests/System/StringTests.cs
Lines 3018 to 3031 in 293c7f6
3.) System.Tests.StringTests.ToUpper_TurkishI_TurkishCulture
runtime/src/libraries/Common/tests/Tests/System/StringTests.cs
Line 5690 in 293c7f6
4.) System.Tests.StringTests.Replace_StringComparison_TurkishI
runtime/src/libraries/System.Runtime/tests/System/StringTests.cs
Line 791 in dfd618d
5.) System.Tests.StringTests.IndexOf_TurkishI_TurkishCulture
runtime/src/libraries/System.Runtime/tests/System/StringTests.cs
Line 1115 in dfd618d