') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); FEATURE_GDBJIT fails to compile due to missing member of Module type · Issue #76291 · dotnet/runtime · GitHub
Skip to content

FEATURE_GDBJIT fails to compile due to missing member of Module type #76291

Closed
#76293
Closed
FEATURE_GDBJIT fails to compile due to missing member of Module type#76291
#76293
Labels
area-VM-coreclr

Description

@tonybaloney
tonybaloney
opened on Sep 28, 2022

Description

I'm trying to compile .NET 7 RC1 with the GDB JIT debug emitter by using:

$ ./build.sh clr.runtime -c debug --cmakeargs -DFEATURE_GDBJIT=ON

The FEATURE_GDBJIT when combined with the COMPlus_GDBJitDump environment variable should emit JIT dumps for GDB (which is what I'm trying to do).

I get an error at compile time for this line: https://github.com/dotnet/runtime/blob/v7.0.0-rc.1.22426.10/src/coreclr/vm/gdbjit.cpp#L511

Building CXX object vm/wks/CMakeFiles/cee_wks_core.dir/__/interoplibinterface_comwrappers.cpp.o
/home/anthonyshaw/Pyjion/CoreCLR/src/coreclr/vm/gdbjit.cpp:511:28: error: no member named 'GetFile' in 'Module'
SString modName = mod->GetFile()->GetPath();
~~~ ^
/home/anthonyshaw/Pyjion/CoreCLR/src/coreclr/vm/gdbjit.cpp:2536:28: error: no member named 'GetFile' in 'Module'
SString modName = mod->GetFile()->GetPath();
~~~ ^

the Module type no longer has a member named GetFile, it was removed since .NET 6, but the gdbjit.cpp file has not been updated with whatever the new API should be, so the file cannot be compiled.

The .NET 6 interface with this method is here:
https://github.com/dotnet/runtime/blob/v6.0.9/src/coreclr/vm/ceeload.h#L1695-L1697

Reproduction Steps

$ ./build.sh clr.runtime -c debug --cmakeargs -DFEATURE_GDBJIT=ON

Expected behavior

Successful compilation (as with .net 6)

Actual behavior

compilation error

Regression?

Yes.

The code was removed here:
7088332d#diff-85a6545c44de808889ff13d59b23a669174330d44a5d0b3248ef2373696fa0ec

Known Workarounds

No response

Configuration

No response

Other information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-VM-coreclr

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions