Skip to content

[mono][wasm] Force interpreter to initialize the pointers - #100288

Merged
mkhamoyan merged 13 commits into
dotnet:mainfrom
mkhamoyan:95087_interpreter_support
Mar 28, 2024
Merged

[mono][wasm] Force interpreter to initialize the pointers#100288
mkhamoyan merged 13 commits into
dotnet:mainfrom
mkhamoyan:95087_interpreter_support

Conversation

@mkhamoyan

@mkhamoyanmkhamoyan commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

Fixes#95087

@mkhamoyanmkhamoyan added the arch-wasm WebAssembly architecture label Mar 26, 2024
@mkhamoyanmkhamoyan self-assigned this Mar 26, 2024
@ghostghost added the area-VM-meta-mono label Mar 26, 2024
pavelsavara
pavelsavara reviewed Mar 26, 2024
View reviewed changes
Comment threadsrc/mono/browser/runtime/runtime.c Outdated
pavelsavara
pavelsavara reviewed Mar 26, 2024
View reviewed changes
Comment threadsrc/mono/browser/runtime/runtime.c Outdated
lewing

This comment was marked as resolved.

Sign in to view

lewing
lewing reviewed Mar 26, 2024
View reviewed changes
Comment threadsrc/tasks/WasmAppBuilder/PInvokeTableGenerator.cs Outdated
This was referenced Mar 26, 2024
Closed
Closed
lewing
lewing reviewed Mar 26, 2024
View reviewed changes
Comment threadsrc/tasks/WasmAppBuilder/PInvokeTableGenerator.cs Outdated
@lewing

lewing commented Mar 26, 2024

Copy link
Copy Markdown
Member

This passes locally so let's get it asap once we have a test.

This was referenced Mar 27, 2024
Closed
Open
Closed
mkhamoyan
mkhamoyan commented Mar 27, 2024
View reviewed changes
Comment threadsrc/mono/wasi/Wasi.Build.Tests/PInvokeTableGeneratorTests.cs Outdated
@build-analysisbuild-analysisBot mentioned this pull request Mar 28, 2024
Closed
@mkhamoyan
mkhamoyan marked this pull request as ready for review March 28, 2024 11:59
maraf
maraf approved these changes Mar 28, 2024
View reviewed changes

@marafmaraf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mkhamoyan

mkhamoyan commented Mar 28, 2024

Copy link
Copy Markdown
ContributorAuthor

/ba-g failures are not related.

@mkhamoyan
mkhamoyan merged commit 1f00cda into dotnet:mainMar 28, 2024
@mkhamoyan
mkhamoyan deleted the 95087_interpreter_support branch March 28, 2024 17:49
@sbomersbomer mentioned this pull request Mar 28, 2024
Open
@mkhamoyanmkhamoyan mentioned this pull request Apr 23, 2024
Open
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 28, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavarapavelsavarapavelsavara left review comments
@lewinglewinglewing approved these changes
@marafmarafmaraf approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner

Assignees

@mkhamoyanmkhamoyan

Labels

arch-wasmWebAssembly architecturearea-VM-meta-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[mono][wasm] Add interpreter support for calls to UnmanagedCallersOnly EntryPoint without managed delegate reference

4 participants

@mkhamoyan@lewing@pavelsavara@maraf