[wasm] emscripten bump 3.1.56 by radekdoulik · Pull Request #100334 · dotnet/runtime

radekdoulik · 2024-03-27T10:46:15Z

Remaining issues:

WBT linux

~~dotnet.native.wasm missing 2x - this is missing native lib in SkiaSharp - we need to disable it temporarily~~
~~wrong exit code value 3x~~
~~timeouts 4x~~
~~SkiaSharp problem 1x - that is expected as it is built against older emscripten, disable it until newer version is available~~

WBT windows

~~66 failures~~

Library tests

timeout in WasmTestOnFirefox-ST-System.Private.Xml.Tests - known issue
timeout in System.Memory.Tests - known issue

Release LibraryTests_Smoke_AOT

~~build fails during AOT compilation - OOM? unable to reproduce locally~~

LibraryTests_Threading

5 failures - known issues - build analysis is green

assert in mono-threads
timeout 4x

more failures in runtime-wasm pipeline

TODO

update aspnetcore for .mjs mimetype
create new issue for MT - already covered by build analysis [Ilona]
try to increase MT tests timeout lengths
another round of build dance to get binaryen fix all the way down to the runtime
disable WBT tests using skiasharp

Fixes#103977.

Module.asm was removed, use wasmExports instead. Context: emscripten-core/emscripten#19816

Context: emscripten-core/emscripten#21041

pavelsavara

the .mjs extension will likely miss MIME type in the Blazor server

The current names 3.1.34 are new enough

radekdoulik · 2024-06-03T21:42:59Z

the errors are related to wrong binaryen version

 emcc: error: unexpected binaryen version: 112 (expected 117) [-Wversion-check] [-Werror]
make[1]: *** [cmTC_fe167.js] Error 1
make: *** [cmTC_fe167/fast] Error 2

dotnet/binaryen#101 for the rescue

pavelsavara · 2024-07-08T10:00:33Z

There is interesting ST fail V8 Log Chrome Log

[09:04:21] info: [FAIL] System.Text.Json.Serialization.Tests.RequiredKeywordTests_Pipe.RequiredKeywordAndJsonRequiredCustomAttributeWorkCorrectlyTogether
[09:04:21] info: System.Threading.SynchronizationLockException : Object synchronization method was called from an unsynchronized block of code.
[09:04:21] info: at System.IO.Pipelines.Pipe.AllocateWriteHeadSynchronized(Int32 )
[09:04:21] info: at System.Text.Json.Serialization.JsonConverter`1[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].WriteCore(Utf8JsonWriter , ClassWithRequiredKeywordAndJsonRequiredCustomAttribute& , JsonSerializerOptions , WriteStack& )
[09:04:21] info: at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.<SerializeAsync>d__12[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].MoveNext()
[09:04:21] info: at System.IO.Pipelines.Pipe.AllocateWriteHeadSynchronized(Int32 )
[09:04:21] info: at System.Text.Json.Serialization.JsonConverter`1[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].WriteCore(Utf8JsonWriter , ClassWithRequiredKeywordAndJsonRequiredCustomAttribute& , JsonSerializerOptions , WriteStack& )
[09:04:21] info: at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.<SerializeAsync>d__12[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].MoveNext()
[09:04:21] info: at System.IO.Pipelines.Pipe.AllocateWriteHeadSynchronized(Int32 )
[09:04:21] info: at System.Text.Json.Serialization.JsonConverter`1[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].WriteCore(Utf8JsonWriter , ClassWithRequiredKeywordAndJsonRequiredCustomAttribute& , JsonSerializerOptions , WriteStack& )
[09:04:21] info: at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.<SerializeAsync>d__12[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].MoveNext()
[09:04:21] info: at System.IO.Pipelines.Pipe.AllocateWriteHeadSynchronized(Int32 )
[09:04:21] info: at System.Text.Json.Serialization.JsonConverter`1[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].WriteCore(Utf8JsonWriter , ClassWithRequiredKeywordAndJsonRequiredCustomAttribute& , JsonSerializerOptions , WriteStack& )
[09:04:21] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncPipelinesSerializerWrapper.<SerializeWrapper>d__10`1[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].MoveNext()
[09:04:21] info: at System.IO.Pipelines.Pipe.AllocateWriteHeadSynchronized(Int32 )
[09:04:21] info: at System.Text.Json.Serialization.JsonConverter`1[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].WriteCore(Utf8JsonWriter , ClassWithRequiredKeywordAndJsonRequiredCustomAttribute& , JsonSerializerOptions , WriteStack& )
[09:04:21] info: at System.Text.Json.Serialization.Tests.RequiredKeywordTests.RequiredKeywordAndJsonRequiredCustomAttributeWorkCorrectlyTogether()
[09:04:21] info: at System.IO.Pipelines.Pipe.AllocateWriteHeadSynchronized(Int32 )
[09:04:21] info: at System.Text.Json.Serialization.JsonConverter`1[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].WriteCore(Utf8JsonWriter , ClassWithRequiredKeywordAndJsonRequiredCustomAttribute& , JsonSerializerOptions , WriteStack& )
[09:04:21] info: --- End of stack trace from previous location ---
[09:04:21] info: at System.IO.Pipelines.Pipe.AllocateWriteHeadSynchronized(Int32 )
[09:04:21] info: at System.Text.Json.Serialization.JsonConverter`1[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].WriteCore(Utf8JsonWriter , ClassWithRequiredKeywordAndJsonRequiredCustomAttribute& , JsonSerializerOptions , WriteStack& )
[09:04:21] info: at System.IO.Pipelines.Pipe.AllocateWriteHeadSynchronized(Int32 )
[09:04:21] info: at System.Text.Json.Serialization.JsonConverter`1[[System.Text.Json.Serialization.Tests.RequiredKeywordTests.ClassWithRequiredKeywordAndJsonRequiredCustomAttribute, System.Text.Json.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].WriteCore(Utf8JsonWriter , ClassWithRequiredKeywordAndJsonRequiredCustomAttribute& , JsonSerializerOptions , WriteStack& )

pavelsavara · 2024-07-08T10:12:17Z

In the 27134031523 MT run deadlocks are

[STRT] TaskCoverage.Coverage.TaskAwaiter
[STRT] System.Threading.Tasks.Tests.AsyncEnumerableToBlockingEnumerableTests.AsyncEnumerableWithException
something after [PASS] System.Runtime.InteropServices.JavaScript.Tests.WebWorkerTest.WaitAssertsOnSyncJSExport
something after [PASS] System.Threading.Tests.SemaphoreSlimTests.RunSemaphoreSlimTest0_Ctor_Negative
something after [PASS] System.Threading.Tests.SemaphoreSlimTests.RunSemaphoreSlimTest2_Release

maraf · 2024-07-08T11:16:38Z

 <add key="dotnet-libraries-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries-transport/nuget/v3/index.json" />
 <add key="dotnet9" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" />
 <add key="dotnet9-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9-transport/nuget/v3/index.json" />
+ <add key="general-testing" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/general-testing/nuget/v3/index.json" />


Do we want to keep this change?

this will be removed once the dependencies are in the flow

pavelsavara · 2024-07-09T13:01:07Z

/azp run runtime-wasm

azure-pipelines · 2024-07-09T13:01:28Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2024-07-09T14:48:05Z

OOM in System.Buffers.ArrayPool.Tests.CollectionTests.ThreadLocalIsCollectedUnderHighPressure
I don't know if this is related to the emscripten bump or not

Details in #102195 (comment)

pavelsavara · 2024-07-09T14:54:05Z

AOT

System.Collections.Tests - null function or function signature mismatchLog
System.Collections.Immutable.Tests - null function or function signature mismatchLog
System.ComponentModel.TypeConverter.Tests - null function or function signature mismatchLog

Common.Tests - Assertion: should not be reached at D:/a/_work/1/s/src/mono/mono/metadata/class-accessors.c:92Log

pavelsavara · 2024-07-09T14:57:07Z

AOT
ST-System.Text.Json.Tests - MONO_WASM: memory access out of boundsLog

Assert at interp.c:2663 Log

Assertion at D:/a/_work/1/s/src/mono/mono/mini/interp/interp.c:2663, condition `is_ok (error)' not met, function:init_jit_call_info, Attempting to JIT compile method '(wrapper other) void object:gsharedvt_out_sig (intptr,System.Text.RegularExpressions.Symbolic.SymbolicRegexBuilder`1/NodeCacheKey<object>&,intptr)' while running in aot-only mode.

pavelsavara · 2024-07-10T13:30:48Z

 {
 string resourceExtension = Path.GetExtension(resourceName);
- if (resourceName.StartsWith("dotnet.native.worker", StringComparison.OrdinalIgnoreCase) && string.Equals(resourceExtension, ".js", StringComparison.OrdinalIgnoreCase))
+ if (resourceName.StartsWith("dotnet.native.worker", StringComparison.OrdinalIgnoreCase) && string.Equals(resourceExtension, ".mjs", StringComparison.OrdinalIgnoreCase))


if this is code that impacts Net8, it still needs to consider .js, I think

radekdoulik · 2024-07-10T16:08:13Z

AOT ST-System.Text.Json.Tests - MONO_WASM: memory access out of boundsLog

Assert at interp.c:2663 Log

Assertion at D:/a/_work/1/s/src/mono/mono/mini/interp/interp.c:2663, condition `is_ok (error)' not met, function:init_jit_call_info, Attempting to JIT compile method '(wrapper other) void object:gsharedvt_out_sig (intptr,System.Text.RegularExpressions.Symbolic.SymbolicRegexBuilder`1/NodeCacheKey<object>&,intptr)' while running in aot-only mode.

this is happening on main too, I tried to run runtime-wasm pipeline few days ago in #104356 to compare it

pavelsavara · 2024-07-10T16:14:44Z

AOT ST-System.Text.Json.Tests - MONO_WASM: memory access out of boundsLog
this is happening on main too, I tried to run runtime-wasm pipeline few days ago in #104356 to compare it

note this is single-threaded, could you please point me to the specific log on main ?

radekdoulik · 2024-07-15T20:22:19Z

AOT ST-System.Text.Json.Tests - MONO_WASM: memory access out of boundsLog
this is happening on main too, I tried to run runtime-wasm pipeline few days ago in #104356 to compare it
note this is single-threaded, could you please point me to the specific log on main ?

the build is gone, the log is still alive. it is ST as well

Console log: 'WasmTestOnV8-ST-System.Text.RegularExpressions.Tests' from job 3bd75066-e30b-4b0b-9738-2a055329014c (ubuntu.2204.amd64.open.rt) using docker image mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-helix-webassembly on a00FUH7
...
[12:07:59] info: [MONO] * Assertion at /__w/1/s/src/mono/mono/mini/interp/interp.c:2663, condition `is_ok (error)' not met, function:init_jit_call_info, Attempting to JIT compile method '(wrapper other) void object:gsharedvt_out_sig (intptr,System.Text.RegularExpressions.Symbolic.SymbolicRegexBuilder`1/NodeCacheKey<object>&,intptr)' while running in aot-only mode. See https://learn.microsoft.com/xamarin/ios/internals/limitations for more information.
[12:07:59] info: assembly:<unknown assembly> type:<unknown type> member:(null)

radekdoulik added 2 commits March 26, 2024 15:40

[wasm] Bump emscripten to 3.1.56
e52f7df

Replace Module.asm with Module.wasmExports
a91ec44
Module.asm was removed, use wasmExports instead. Context: emscripten-core/emscripten#19816

ghost added the area-Build-mono label Mar 27, 2024

dotnet-policy-serviceBot assigned radekdoulik Mar 27, 2024

radekdoulik added 2 commits April 5, 2024 13:18

Updates for .native.worker.js -> mjs rename
d23f6fa
Context: emscripten-core/emscripten#21041

Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
9848b92

pavelsavara reviewed Apr 5, 2024
View reviewed changes

Comment threadsrc/mono/wasm/build/WasmApp.Common.targets

pavelsavara reviewed Apr 5, 2024
View reviewed changes

This was referenced Apr 5, 2024
[wasm] Playwright failing #94240
Closed
[browser][MT] Unhandled JS error #97546
Closed

radekdoulik added 6 commits May 30, 2024 17:30

Update deps
50dfb72

Add general testing feed
aca6c58

Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
f229a30

Update mode deps
f917ea6

Update path
a7c4e55

Use current python packages for now, we don't have newer ones
0b030c1
The current names 3.1.34 are new enough

This was referenced May 30, 2024
GC\Regressions\v2.0-beta2\452950\452950\452950.cmd failing on Mono minijit Windows x64 #99729
Closed
at GC_Regressions._v2_0_beta2_452950_452950_452950_._v2_0_beta2_452950_452950_452950_cmd() #100174
Closed

radekdoulik added 3 commits June 3, 2024 10:54

Keep using llvm 16 for runtime and aot compiler
6a0057f

Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
6cde92a

Add -Wno-pre-c11-compat only for browser
1721779

Temporarily disable version checks to get further
fe1e5c6

build-analysisBot mentioned this pull request Jun 4, 2024
NativeAOT legs timing out in CI #102239
Closed

radekdoulik added 3 commits June 4, 2024 09:27

Temporarily disable version checks to get further#2
3f8834f

Disable -Wunused-command-line-argument
123767a

Update emsdk deps
e3b1316

build-analysisBot mentioned this pull request Jun 4, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

Update icu dependency
7d6edc3

build-analysisBot mentioned this pull request Jun 4, 2024
Wasm test failure: Unable to evaluate script: target frame detached #102957
Closed

maraf reviewed Jul 8, 2024
View reviewed changes

pavelsavara added 2 commits July 9, 2024 13:08

Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
061f2b5

use active issues for MT
8ed7bf9

build-analysisBot mentioned this pull request Jul 9, 2024
[browser][MT] System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests.RentAndReturnManyOfTheSameSize_NoneAreSame #103943
Closed

Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
d665bfa

pavelsavara reviewed Jul 10, 2024
View reviewed changes

radekdoulik added 3 commits July 13, 2024 14:13

Remove testing channel from nuget config, update deps
fdbb1f2

Update emsdk and icu dependencies
ddc4698

Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
e6426d2

radekdoulik merged commit ad542b2 into dotnet:mainJul 15, 2024

This was referenced Jul 24, 2024
[Perf] Linux/x64: 298 Regressions on 7/15/2024 10:11:33 PM dotnet/perf-autofiling-issues#38866
Open
[Perf] Linux/x64: 28 Regressions on 7/16/2024 4:20:22 AM dotnet/perf-autofiling-issues#38867
Open

github-actionsBot locked and limited conversation to collaborators Aug 15, 2024

Uh oh!

Conversation

radekdoulik commented Mar 27, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pavelsavara left a comment

Choose a reason for hiding this comment

Uh oh!

radekdoulik commented Jun 3, 2024

Uh oh!

pavelsavara commented Jul 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pavelsavara commented Jul 8, 2024

Uh oh!

marafJul 8, 2024

Choose a reason for hiding this comment

Uh oh!

radekdoulikJul 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pavelsavara commented Jul 9, 2024

Uh oh!

azure-pipelinesBot commented Jul 9, 2024

Uh oh!

pavelsavara commented Jul 9, 2024

Uh oh!

pavelsavara commented Jul 9, 2024

Uh oh!

pavelsavara commented Jul 9, 2024

Uh oh!

pavelsavaraJul 10, 2024

Choose a reason for hiding this comment

Uh oh!

radekdoulik commented Jul 10, 2024

Uh oh!

pavelsavara commented Jul 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

radekdoulik commented Jul 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

radekdoulik commented Mar 27, 2024•
edited
Loading

pavelsavara commented Jul 8, 2024•
edited
Loading

pavelsavara commented Jul 10, 2024•
edited
Loading