JIT: Add support for frozen structs in Swift reverse pinvokes by jakobbotsch · Pull Request #100344 · dotnet/runtime

jakobbotsch · 2024-03-27T15:01:38Z

This adds the final support for frozen structs in UCO methods.

This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests.

Frozen struct parameters are handled via the new ABI representation added in #100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen.

One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB.

Since Swift structs can be passed by reference in certain cases this PR also enables FEATURE_IMPLICIT_BYREFS for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

TODO:

Fix lvRefCnt() == 0 case

For HVAs the element size can be > 8, but should at most be 8-byte aligned.

jakobbotsch · 2024-04-03T20:09:19Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs

azure-pipelines · 2024-04-03T20:09:40Z

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch · 2024-04-04T09:00:59Z

The testing passed, the failure is #99810. Need to fix the formatting failures though.

…invokes-structs

jakobbotsch · 2024-04-04T19:02:14Z

cc @dotnet/jit-contrib PTAL @amanasifkhalid

I think this will need a few fixups after #100429 is merged.

Diffs. Enabling implicit byrefs on SysV x64 results in some large TP regressions with an MSVC compiled cross compiler, but the clang compiled one doesn't look bad. Also some TP improvements on other platforms from some of the optimization work I did around the implicit byrefs as a result.

…invokes-structs

amanasifkhalid

LGTM assuming runtime/stress pipelines pass. Thanks!

amanasifkhalid · 2024-04-04T20:05:51Z

+ case 1:
+ return TYP_UBYTE;
+ case 2:
+ return TYP_USHORT;


Why do we use unsigned types for these ones?

We generally normalize up to at least 4 bytes on all loads, and zero extensions sometimes have smaller encodings than sign extensions on xarch (similar change was made in #86631).

jakobbotsch · 2024-04-04T21:12:52Z

I'll kick off the stress pipelines again just to be safe after the merge of #100429.

jakobbotsch · 2024-04-04T21:13:20Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr jitstress2-jitstressregs

azure-pipelines · 2024-04-04T21:13:38Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2024-04-04T21:16:46Z

Also cc @jkoritzinsky, @jkurdek, @matouskozak, @kotlarmilos. With this PR I think we'll be feature complete on the Swift support in RyuJIT (until #100543 makes it through review, although I expect it will be straightforward to add support for those).

jakobbotsch · 2024-04-05T08:03:25Z

Failures are #100476 and #99810

…#100344) This adds the final support for frozen structs in UCO methods. This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests. Frozen struct parameters are handled via the new ABI representation added in dotnet#100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen. One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB. Since Swift structs can be passed by reference in certain cases this PR also enables `FEATURE_IMPLICIT_BYREFS` for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

jakobbotsch · 2024-03-27T15:01:38Z

This adds the final support for frozen structs in UCO methods.

This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests.

Frozen struct parameters are handled via the new ABI representation added in #100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen.

One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB.

Since Swift structs can be passed by reference in certain cases this PR also enables FEATURE_IMPLICIT_BYREFS for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

TODO:

Fix lvRefCnt() == 0 case

For HVAs the element size can be > 8, but should at most be 8-byte aligned.

jakobbotsch · 2024-04-03T20:09:19Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs

azure-pipelines · 2024-04-03T20:09:40Z

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch · 2024-04-04T09:00:59Z

The testing passed, the failure is #99810. Need to fix the formatting failures though.

…invokes-structs

jakobbotsch · 2024-04-04T19:02:14Z

cc @dotnet/jit-contrib PTAL @amanasifkhalid

I think this will need a few fixups after #100429 is merged.

Diffs. Enabling implicit byrefs on SysV x64 results in some large TP regressions with an MSVC compiled cross compiler, but the clang compiled one doesn't look bad. Also some TP improvements on other platforms from some of the optimization work I did around the implicit byrefs as a result.

…invokes-structs

amanasifkhalid

LGTM assuming runtime/stress pipelines pass. Thanks!

amanasifkhalid · 2024-04-04T20:05:51Z

+ case 1:
+ return TYP_UBYTE;
+ case 2:
+ return TYP_USHORT;


Why do we use unsigned types for these ones?

We generally normalize up to at least 4 bytes on all loads, and zero extensions sometimes have smaller encodings than sign extensions on xarch (similar change was made in #86631).

jakobbotsch · 2024-04-04T21:12:52Z

I'll kick off the stress pipelines again just to be safe after the merge of #100429.

jakobbotsch · 2024-04-04T21:13:20Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr jitstress2-jitstressregs

azure-pipelines · 2024-04-04T21:13:38Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2024-04-04T21:16:46Z

Also cc @jkoritzinsky, @jkurdek, @matouskozak, @kotlarmilos. With this PR I think we'll be feature complete on the Swift support in RyuJIT (until #100543 makes it through review, although I expect it will be straightforward to add support for those).

jakobbotsch · 2024-04-05T08:03:25Z

Failures are #100476 and #99810

…#100344) This adds the final support for frozen structs in UCO methods. This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests. Frozen struct parameters are handled via the new ABI representation added in dotnet#100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen. One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB. Since Swift structs can be passed by reference in certain cases this PR also enables `FEATURE_IMPLICIT_BYREFS` for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

jakobbotsch · 2024-03-27T15:01:38Z

This adds the final support for frozen structs in UCO methods.

This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests.

Frozen struct parameters are handled via the new ABI representation added in #100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen.

One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB.

Since Swift structs can be passed by reference in certain cases this PR also enables FEATURE_IMPLICIT_BYREFS for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

TODO:

Fix lvRefCnt() == 0 case

For HVAs the element size can be > 8, but should at most be 8-byte aligned.

jakobbotsch · 2024-04-03T20:09:19Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs

azure-pipelines · 2024-04-03T20:09:40Z

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch · 2024-04-04T09:00:59Z

The testing passed, the failure is #99810. Need to fix the formatting failures though.

…invokes-structs

jakobbotsch · 2024-04-04T19:02:14Z

cc @dotnet/jit-contrib PTAL @amanasifkhalid

I think this will need a few fixups after #100429 is merged.

Diffs. Enabling implicit byrefs on SysV x64 results in some large TP regressions with an MSVC compiled cross compiler, but the clang compiled one doesn't look bad. Also some TP improvements on other platforms from some of the optimization work I did around the implicit byrefs as a result.

…invokes-structs

amanasifkhalid

LGTM assuming runtime/stress pipelines pass. Thanks!

amanasifkhalid · 2024-04-04T20:05:51Z

+ case 1:
+ return TYP_UBYTE;
+ case 2:
+ return TYP_USHORT;


Why do we use unsigned types for these ones?

We generally normalize up to at least 4 bytes on all loads, and zero extensions sometimes have smaller encodings than sign extensions on xarch (similar change was made in #86631).

jakobbotsch · 2024-04-04T21:12:52Z

I'll kick off the stress pipelines again just to be safe after the merge of #100429.

jakobbotsch · 2024-04-04T21:13:20Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr jitstress2-jitstressregs

azure-pipelines · 2024-04-04T21:13:38Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2024-04-04T21:16:46Z

Also cc @jkoritzinsky, @jkurdek, @matouskozak, @kotlarmilos. With this PR I think we'll be feature complete on the Swift support in RyuJIT (until #100543 makes it through review, although I expect it will be straightforward to add support for those).

jakobbotsch · 2024-04-05T08:03:25Z

Failures are #100476 and #99810

…#100344) This adds the final support for frozen structs in UCO methods. This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests. Frozen struct parameters are handled via the new ABI representation added in dotnet#100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen. One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB. Since Swift structs can be passed by reference in certain cases this PR also enables `FEATURE_IMPLICIT_BYREFS` for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

jakobbotsch · 2024-03-27T15:01:38Z

This adds the final support for frozen structs in UCO methods.

This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests.

Frozen struct parameters are handled via the new ABI representation added in #100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen.

One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB.

Since Swift structs can be passed by reference in certain cases this PR also enables FEATURE_IMPLICIT_BYREFS for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

TODO:

Fix lvRefCnt() == 0 case

For HVAs the element size can be > 8, but should at most be 8-byte aligned.

jakobbotsch · 2024-04-03T20:09:19Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs

azure-pipelines · 2024-04-03T20:09:40Z

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch · 2024-04-04T09:00:59Z

The testing passed, the failure is #99810. Need to fix the formatting failures though.

…invokes-structs

jakobbotsch · 2024-04-04T19:02:14Z

cc @dotnet/jit-contrib PTAL @amanasifkhalid

I think this will need a few fixups after #100429 is merged.

Diffs. Enabling implicit byrefs on SysV x64 results in some large TP regressions with an MSVC compiled cross compiler, but the clang compiled one doesn't look bad. Also some TP improvements on other platforms from some of the optimization work I did around the implicit byrefs as a result.

…invokes-structs

amanasifkhalid

LGTM assuming runtime/stress pipelines pass. Thanks!

amanasifkhalid · 2024-04-04T20:05:51Z

+ case 1:
+ return TYP_UBYTE;
+ case 2:
+ return TYP_USHORT;


Why do we use unsigned types for these ones?

We generally normalize up to at least 4 bytes on all loads, and zero extensions sometimes have smaller encodings than sign extensions on xarch (similar change was made in #86631).

jakobbotsch · 2024-04-04T21:12:52Z

I'll kick off the stress pipelines again just to be safe after the merge of #100429.

jakobbotsch · 2024-04-04T21:13:20Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr jitstress2-jitstressregs

azure-pipelines · 2024-04-04T21:13:38Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2024-04-04T21:16:46Z

Also cc @jkoritzinsky, @jkurdek, @matouskozak, @kotlarmilos. With this PR I think we'll be feature complete on the Swift support in RyuJIT (until #100543 makes it through review, although I expect it will be straightforward to add support for those).

jakobbotsch · 2024-04-05T08:03:25Z

Failures are #100476 and #99810

…#100344) This adds the final support for frozen structs in UCO methods. This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests. Frozen struct parameters are handled via the new ABI representation added in dotnet#100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen. One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB. Since Swift structs can be passed by reference in certain cases this PR also enables `FEATURE_IMPLICIT_BYREFS` for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

jakobbotsch · 2024-03-27T15:01:38Z

This adds the final support for frozen structs in UCO methods.

This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests.

Frozen struct parameters are handled via the new ABI representation added in #100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen.

One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB.

Since Swift structs can be passed by reference in certain cases this PR also enables FEATURE_IMPLICIT_BYREFS for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

TODO:

Fix lvRefCnt() == 0 case

For HVAs the element size can be > 8, but should at most be 8-byte aligned.

jakobbotsch · 2024-04-03T20:09:19Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs

azure-pipelines · 2024-04-03T20:09:40Z

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch · 2024-04-04T09:00:59Z

The testing passed, the failure is #99810. Need to fix the formatting failures though.

…invokes-structs

jakobbotsch · 2024-04-04T19:02:14Z

cc @dotnet/jit-contrib PTAL @amanasifkhalid

I think this will need a few fixups after #100429 is merged.

Diffs. Enabling implicit byrefs on SysV x64 results in some large TP regressions with an MSVC compiled cross compiler, but the clang compiled one doesn't look bad. Also some TP improvements on other platforms from some of the optimization work I did around the implicit byrefs as a result.

…invokes-structs

amanasifkhalid

LGTM assuming runtime/stress pipelines pass. Thanks!

amanasifkhalid · 2024-04-04T20:05:51Z

+ case 1:
+ return TYP_UBYTE;
+ case 2:
+ return TYP_USHORT;


Why do we use unsigned types for these ones?

We generally normalize up to at least 4 bytes on all loads, and zero extensions sometimes have smaller encodings than sign extensions on xarch (similar change was made in #86631).

jakobbotsch · 2024-04-04T21:12:52Z

I'll kick off the stress pipelines again just to be safe after the merge of #100429.

jakobbotsch · 2024-04-04T21:13:20Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr jitstress2-jitstressregs

azure-pipelines · 2024-04-04T21:13:38Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2024-04-04T21:16:46Z

Also cc @jkoritzinsky, @jkurdek, @matouskozak, @kotlarmilos. With this PR I think we'll be feature complete on the Swift support in RyuJIT (until #100543 makes it through review, although I expect it will be straightforward to add support for those).

jakobbotsch · 2024-04-05T08:03:25Z

Failures are #100476 and #99810

…#100344) This adds the final support for frozen structs in UCO methods. This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests. Frozen struct parameters are handled via the new ABI representation added in dotnet#100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen. One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB. Since Swift structs can be passed by reference in certain cases this PR also enables `FEATURE_IMPLICIT_BYREFS` for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

jakobbotsch · 2024-03-27T15:01:38Z

This adds the final support for frozen structs in UCO methods.

This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests.

Frozen struct parameters are handled via the new ABI representation added in #100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen.

One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB.

Since Swift structs can be passed by reference in certain cases this PR also enables FEATURE_IMPLICIT_BYREFS for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

TODO:

Fix lvRefCnt() == 0 case

For HVAs the element size can be > 8, but should at most be 8-byte aligned.

jakobbotsch · 2024-04-03T20:09:19Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs

azure-pipelines · 2024-04-03T20:09:40Z

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch · 2024-04-04T09:00:59Z

The testing passed, the failure is #99810. Need to fix the formatting failures though.

…invokes-structs

jakobbotsch · 2024-04-04T19:02:14Z

cc @dotnet/jit-contrib PTAL @amanasifkhalid

I think this will need a few fixups after #100429 is merged.

Diffs. Enabling implicit byrefs on SysV x64 results in some large TP regressions with an MSVC compiled cross compiler, but the clang compiled one doesn't look bad. Also some TP improvements on other platforms from some of the optimization work I did around the implicit byrefs as a result.

…invokes-structs

amanasifkhalid

LGTM assuming runtime/stress pipelines pass. Thanks!

amanasifkhalid · 2024-04-04T20:05:51Z

+ case 1:
+ return TYP_UBYTE;
+ case 2:
+ return TYP_USHORT;


Why do we use unsigned types for these ones?

We generally normalize up to at least 4 bytes on all loads, and zero extensions sometimes have smaller encodings than sign extensions on xarch (similar change was made in #86631).

jakobbotsch · 2024-04-04T21:12:52Z

I'll kick off the stress pipelines again just to be safe after the merge of #100429.

jakobbotsch · 2024-04-04T21:13:20Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr jitstress2-jitstressregs

azure-pipelines · 2024-04-04T21:13:38Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2024-04-04T21:16:46Z

Also cc @jkoritzinsky, @jkurdek, @matouskozak, @kotlarmilos. With this PR I think we'll be feature complete on the Swift support in RyuJIT (until #100543 makes it through review, although I expect it will be straightforward to add support for those).

jakobbotsch · 2024-04-05T08:03:25Z

Failures are #100476 and #99810

…#100344) This adds the final support for frozen structs in UCO methods. This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests. Frozen struct parameters are handled via the new ABI representation added in dotnet#100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen. One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB. Since Swift structs can be passed by reference in certain cases this PR also enables `FEATURE_IMPLICIT_BYREFS` for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

jakobbotsch · 2024-03-27T15:01:38Z

This adds the final support for frozen structs in UCO methods.

This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests.

Frozen struct parameters are handled via the new ABI representation added in #100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen.

One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB.

Since Swift structs can be passed by reference in certain cases this PR also enables FEATURE_IMPLICIT_BYREFS for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

TODO:

Fix lvRefCnt() == 0 case

For HVAs the element size can be > 8, but should at most be 8-byte aligned.

jakobbotsch · 2024-04-03T20:09:19Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs

azure-pipelines · 2024-04-03T20:09:40Z

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch · 2024-04-04T09:00:59Z

The testing passed, the failure is #99810. Need to fix the formatting failures though.

…invokes-structs

jakobbotsch · 2024-04-04T19:02:14Z

cc @dotnet/jit-contrib PTAL @amanasifkhalid

I think this will need a few fixups after #100429 is merged.

Diffs. Enabling implicit byrefs on SysV x64 results in some large TP regressions with an MSVC compiled cross compiler, but the clang compiled one doesn't look bad. Also some TP improvements on other platforms from some of the optimization work I did around the implicit byrefs as a result.

…invokes-structs

amanasifkhalid

LGTM assuming runtime/stress pipelines pass. Thanks!

amanasifkhalid · 2024-04-04T20:05:51Z

+ case 1:
+ return TYP_UBYTE;
+ case 2:
+ return TYP_USHORT;


Why do we use unsigned types for these ones?

We generally normalize up to at least 4 bytes on all loads, and zero extensions sometimes have smaller encodings than sign extensions on xarch (similar change was made in #86631).

jakobbotsch · 2024-04-04T21:12:52Z

I'll kick off the stress pipelines again just to be safe after the merge of #100429.

jakobbotsch · 2024-04-04T21:13:20Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr jitstress2-jitstressregs

azure-pipelines · 2024-04-04T21:13:38Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2024-04-04T21:16:46Z

Also cc @jkoritzinsky, @jkurdek, @matouskozak, @kotlarmilos. With this PR I think we'll be feature complete on the Swift support in RyuJIT (until #100543 makes it through review, although I expect it will be straightforward to add support for those).

jakobbotsch · 2024-04-05T08:03:25Z

Failures are #100476 and #99810

…#100344) This adds the final support for frozen structs in UCO methods. This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests. Frozen struct parameters are handled via the new ABI representation added in dotnet#100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen. One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB. Since Swift structs can be passed by reference in certain cases this PR also enables `FEATURE_IMPLICIT_BYREFS` for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

jakobbotsch · 2024-03-27T15:01:38Z

This adds the final support for frozen structs in UCO methods.

This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests.

Frozen struct parameters are handled via the new ABI representation added in #100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen.

One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB.

Since Swift structs can be passed by reference in certain cases this PR also enables FEATURE_IMPLICIT_BYREFS for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

TODO:

Fix lvRefCnt() == 0 case

For HVAs the element size can be > 8, but should at most be 8-byte aligned.

jakobbotsch · 2024-04-03T20:09:19Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs

azure-pipelines · 2024-04-03T20:09:40Z

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch · 2024-04-04T09:00:59Z

The testing passed, the failure is #99810. Need to fix the formatting failures though.

…invokes-structs

jakobbotsch · 2024-04-04T19:02:14Z

cc @dotnet/jit-contrib PTAL @amanasifkhalid

I think this will need a few fixups after #100429 is merged.

Diffs. Enabling implicit byrefs on SysV x64 results in some large TP regressions with an MSVC compiled cross compiler, but the clang compiled one doesn't look bad. Also some TP improvements on other platforms from some of the optimization work I did around the implicit byrefs as a result.

…invokes-structs

amanasifkhalid

LGTM assuming runtime/stress pipelines pass. Thanks!

amanasifkhalid · 2024-04-04T20:05:51Z

+ case 1:
+ return TYP_UBYTE;
+ case 2:
+ return TYP_USHORT;


Why do we use unsigned types for these ones?

We generally normalize up to at least 4 bytes on all loads, and zero extensions sometimes have smaller encodings than sign extensions on xarch (similar change was made in #86631).

jakobbotsch · 2024-04-04T21:12:52Z

I'll kick off the stress pipelines again just to be safe after the merge of #100429.

jakobbotsch · 2024-04-04T21:13:20Z

/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr jitstress2-jitstressregs

azure-pipelines · 2024-04-04T21:13:38Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2024-04-04T21:16:46Z

Also cc @jkoritzinsky, @jkurdek, @matouskozak, @kotlarmilos. With this PR I think we'll be feature complete on the Swift support in RyuJIT (until #100543 makes it through review, although I expect it will be straightforward to add support for those).

jakobbotsch · 2024-04-05T08:03:25Z

Failures are #100476 and #99810

…#100344) This adds the final support for frozen structs in UCO methods. This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests. Frozen struct parameters are handled via the new ABI representation added in dotnet#100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen. One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB. Since Swift structs can be passed by reference in certain cases this PR also enables `FEATURE_IMPLICIT_BYREFS` for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.

jakobbotsch added 30 commits March 25, 2024 20:05

JIT: Split ABI classification by ABI
fea5284

Refactor, fix arm64
150cb28

Run jit-format
af2fc72

Comments
1d09c9f

Fix varargs retbuf case
dcccedd

Fix SysV
7fe878b

Add function headers
9297865

Nit
25e2c49

Fix macOS arm64 ABI bug
9954062

Preemptively fix build
5fab654

More build fixes
3f1c738

Further fix build
b8d9334

Move classifiers into target specific files
f12a9d7

Fix x86
70a0aff

Fix Apple ARM64 ABI for HVAs
0e82029
For HVAs the element size can be > 8, but should at most be 8-byte aligned.

Initial work
8cf09c7

Fix build
10bbcce

More fixes
6d2a284

Check for swift call conv
90bab28

More
b5586da

More fixing
a17cdeb

Fix further
6214044

Fixes
60eecf1

More fixing
10d1f3b

Fix
8db32af

Fix
1eab0d9

Handle stack and registers separately
be0137e

More
3faedce

Enable implicit byrefs on SysV x64
5b72edd

Fix SysV x64 arg asserts
27cb1b1

jakobbotsch added 6 commits April 3, 2024 15:35

Maybe that does it
5929425

Run jit-format
0bf62c0

Clean up
955e5bf

Fix an x64 assert
efc5637

Clean up
c4874e0

Straggler
ee436f6

jakobbotsch added 2 commits April 4, 2024 11:01

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
700864a
…invokes-structs

Run jit-format
ef478a0

build-analysisBot mentioned this pull request Apr 4, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

EgorBo mentioned this pull request Apr 4, 2024
Force 2 iterations of OptRepeat #100473
Closed

jakobbotsch marked this pull request as ready for review April 4, 2024 18:59

jakobbotsch requested a review from amanasifkhalid April 4, 2024 19:02

amanasifkhalid mentioned this pull request Apr 4, 2024
JIT: Support Swift error handling for reverse P/Invokes #100429
Merged

jakobbotsch added 2 commits April 4, 2024 21:08

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
fa1860c
…invokes-structs

Fix bad merge
010552a

amanasifkhalid approved these changes Apr 4, 2024
View reviewed changes

Address feedback
4f272f7

jakobbotsch merged commit a971763 into dotnet:mainApr 5, 2024

jakobbotsch deleted the swift-reverse-pinvokes-structs branch April 5, 2024 08:04

github-actionsBot locked and limited conversation to collaborators May 5, 2024

jakobbotsch added 30 commits March 25, 2024 20:05

JIT: Split ABI classification by ABI
fea5284

Refactor, fix arm64
150cb28

Run jit-format
af2fc72

Comments
1d09c9f

Fix varargs retbuf case
dcccedd

Fix SysV
7fe878b

Add function headers
9297865

Nit
25e2c49

Fix macOS arm64 ABI bug
9954062

Preemptively fix build
5fab654

More build fixes
3f1c738

Further fix build
b8d9334

Move classifiers into target specific files
f12a9d7

Fix x86
70a0aff

Fix Apple ARM64 ABI for HVAs
0e82029
For HVAs the element size can be > 8, but should at most be 8-byte aligned.

Initial work
8cf09c7

Fix build
10bbcce

More fixes
6d2a284

Check for swift call conv
90bab28

More
b5586da

More fixing
a17cdeb

Fix further
6214044

Fixes
60eecf1

More fixing
10d1f3b

Fix
8db32af

Fix
1eab0d9

Handle stack and registers separately
be0137e

More
3faedce

Enable implicit byrefs on SysV x64
5b72edd

Fix SysV x64 arg asserts
27cb1b1

jakobbotsch added 6 commits April 3, 2024 15:35

Maybe that does it
5929425

Run jit-format
0bf62c0

Clean up
955e5bf

Fix an x64 assert
efc5637

Clean up
c4874e0

Straggler
ee436f6

jakobbotsch added 2 commits April 4, 2024 11:01

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
700864a
…invokes-structs

Run jit-format
ef478a0

build-analysisBot mentioned this pull request Apr 4, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

EgorBo mentioned this pull request Apr 4, 2024
Force 2 iterations of OptRepeat #100473
Closed

jakobbotsch marked this pull request as ready for review April 4, 2024 18:59

jakobbotsch requested a review from amanasifkhalid April 4, 2024 19:02

amanasifkhalid mentioned this pull request Apr 4, 2024
JIT: Support Swift error handling for reverse P/Invokes #100429
Merged

jakobbotsch added 2 commits April 4, 2024 21:08

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
fa1860c
…invokes-structs

Fix bad merge
010552a

amanasifkhalid approved these changes Apr 4, 2024
View reviewed changes

Address feedback
4f272f7

jakobbotsch merged commit a971763 into dotnet:mainApr 5, 2024

jakobbotsch deleted the swift-reverse-pinvokes-structs branch April 5, 2024 08:04

github-actionsBot locked and limited conversation to collaborators May 5, 2024

jakobbotsch added 30 commits March 25, 2024 20:05

JIT: Split ABI classification by ABI
fea5284

Refactor, fix arm64
150cb28

Run jit-format
af2fc72

Comments
1d09c9f

Fix varargs retbuf case
dcccedd

Fix SysV
7fe878b

Add function headers
9297865

Nit
25e2c49

Fix macOS arm64 ABI bug
9954062

Preemptively fix build
5fab654

More build fixes
3f1c738

Further fix build
b8d9334

Move classifiers into target specific files
f12a9d7

Fix x86
70a0aff

Fix Apple ARM64 ABI for HVAs
0e82029
For HVAs the element size can be > 8, but should at most be 8-byte aligned.

Initial work
8cf09c7

Fix build
10bbcce

More fixes
6d2a284

Check for swift call conv
90bab28

More
b5586da

More fixing
a17cdeb

Fix further
6214044

Fixes
60eecf1

More fixing
10d1f3b

Fix
8db32af

Fix
1eab0d9

Handle stack and registers separately
be0137e

More
3faedce

Enable implicit byrefs on SysV x64
5b72edd

Fix SysV x64 arg asserts
27cb1b1

jakobbotsch added 6 commits April 3, 2024 15:35

Maybe that does it
5929425

Run jit-format
0bf62c0

Clean up
955e5bf

Fix an x64 assert
efc5637

Clean up
c4874e0

Straggler
ee436f6

jakobbotsch added 2 commits April 4, 2024 11:01

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
700864a
…invokes-structs

Run jit-format
ef478a0

build-analysisBot mentioned this pull request Apr 4, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

EgorBo mentioned this pull request Apr 4, 2024
Force 2 iterations of OptRepeat #100473
Closed

jakobbotsch marked this pull request as ready for review April 4, 2024 18:59

jakobbotsch requested a review from amanasifkhalid April 4, 2024 19:02

amanasifkhalid mentioned this pull request Apr 4, 2024
JIT: Support Swift error handling for reverse P/Invokes #100429
Merged

jakobbotsch added 2 commits April 4, 2024 21:08

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
fa1860c
…invokes-structs

Fix bad merge
010552a

amanasifkhalid approved these changes Apr 4, 2024
View reviewed changes

Address feedback
4f272f7

jakobbotsch merged commit a971763 into dotnet:mainApr 5, 2024

jakobbotsch deleted the swift-reverse-pinvokes-structs branch April 5, 2024 08:04

github-actionsBot locked and limited conversation to collaborators May 5, 2024

jakobbotsch added 30 commits March 25, 2024 20:05

JIT: Split ABI classification by ABI
fea5284

Refactor, fix arm64
150cb28

Run jit-format
af2fc72

Comments
1d09c9f

Fix varargs retbuf case
dcccedd

Fix SysV
7fe878b

Add function headers
9297865

Nit
25e2c49

Fix macOS arm64 ABI bug
9954062

Preemptively fix build
5fab654

More build fixes
3f1c738

Further fix build
b8d9334

Move classifiers into target specific files
f12a9d7

Fix x86
70a0aff

Fix Apple ARM64 ABI for HVAs
0e82029
For HVAs the element size can be > 8, but should at most be 8-byte aligned.

Initial work
8cf09c7

Fix build
10bbcce

More fixes
6d2a284

Check for swift call conv
90bab28

More
b5586da

More fixing
a17cdeb

Fix further
6214044

Fixes
60eecf1

More fixing
10d1f3b

Fix
8db32af

Fix
1eab0d9

Handle stack and registers separately
be0137e

More
3faedce

Enable implicit byrefs on SysV x64
5b72edd

Fix SysV x64 arg asserts
27cb1b1

jakobbotsch added 6 commits April 3, 2024 15:35

Maybe that does it
5929425

Run jit-format
0bf62c0

Clean up
955e5bf

Fix an x64 assert
efc5637

Clean up
c4874e0

Straggler
ee436f6

jakobbotsch added 2 commits April 4, 2024 11:01

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
700864a
…invokes-structs

Run jit-format
ef478a0

build-analysisBot mentioned this pull request Apr 4, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

EgorBo mentioned this pull request Apr 4, 2024
Force 2 iterations of OptRepeat #100473
Closed

jakobbotsch marked this pull request as ready for review April 4, 2024 18:59

jakobbotsch requested a review from amanasifkhalid April 4, 2024 19:02

amanasifkhalid mentioned this pull request Apr 4, 2024
JIT: Support Swift error handling for reverse P/Invokes #100429
Merged

jakobbotsch added 2 commits April 4, 2024 21:08

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
fa1860c
…invokes-structs

Fix bad merge
010552a

amanasifkhalid approved these changes Apr 4, 2024
View reviewed changes

Address feedback
4f272f7

jakobbotsch merged commit a971763 into dotnet:mainApr 5, 2024

jakobbotsch deleted the swift-reverse-pinvokes-structs branch April 5, 2024 08:04

github-actionsBot locked and limited conversation to collaborators May 5, 2024

jakobbotsch added 30 commits March 25, 2024 20:05

JIT: Split ABI classification by ABI
fea5284

Refactor, fix arm64
150cb28

Run jit-format
af2fc72

Comments
1d09c9f

Fix varargs retbuf case
dcccedd

Fix SysV
7fe878b

Add function headers
9297865

Nit
25e2c49

Fix macOS arm64 ABI bug
9954062

Preemptively fix build
5fab654

More build fixes
3f1c738

Further fix build
b8d9334

Move classifiers into target specific files
f12a9d7

Fix x86
70a0aff

Fix Apple ARM64 ABI for HVAs
0e82029
For HVAs the element size can be > 8, but should at most be 8-byte aligned.

Initial work
8cf09c7

Fix build
10bbcce

More fixes
6d2a284

Check for swift call conv
90bab28

More
b5586da

More fixing
a17cdeb

Fix further
6214044

Fixes
60eecf1

More fixing
10d1f3b

Fix
8db32af

Fix
1eab0d9

Handle stack and registers separately
be0137e

More
3faedce

Enable implicit byrefs on SysV x64
5b72edd

Fix SysV x64 arg asserts
27cb1b1

jakobbotsch added 6 commits April 3, 2024 15:35

Maybe that does it
5929425

Run jit-format
0bf62c0

Clean up
955e5bf

Fix an x64 assert
efc5637

Clean up
c4874e0

Straggler
ee436f6

jakobbotsch added 2 commits April 4, 2024 11:01

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
700864a
…invokes-structs

Run jit-format
ef478a0

build-analysisBot mentioned this pull request Apr 4, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

EgorBo mentioned this pull request Apr 4, 2024
Force 2 iterations of OptRepeat #100473
Closed

jakobbotsch marked this pull request as ready for review April 4, 2024 18:59

jakobbotsch requested a review from amanasifkhalid April 4, 2024 19:02

amanasifkhalid mentioned this pull request Apr 4, 2024
JIT: Support Swift error handling for reverse P/Invokes #100429
Merged

jakobbotsch added 2 commits April 4, 2024 21:08

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
fa1860c
…invokes-structs

Fix bad merge
010552a

amanasifkhalid approved these changes Apr 4, 2024
View reviewed changes

Address feedback
4f272f7

jakobbotsch merged commit a971763 into dotnet:mainApr 5, 2024

jakobbotsch deleted the swift-reverse-pinvokes-structs branch April 5, 2024 08:04

github-actionsBot locked and limited conversation to collaborators May 5, 2024

jakobbotsch added 30 commits March 25, 2024 20:05

JIT: Split ABI classification by ABI
fea5284

Refactor, fix arm64
150cb28

Run jit-format
af2fc72

Comments
1d09c9f

Fix varargs retbuf case
dcccedd

Fix SysV
7fe878b

Add function headers
9297865

Nit
25e2c49

Fix macOS arm64 ABI bug
9954062

Preemptively fix build
5fab654

More build fixes
3f1c738

Further fix build
b8d9334

Move classifiers into target specific files
f12a9d7

Fix x86
70a0aff

Fix Apple ARM64 ABI for HVAs
0e82029
For HVAs the element size can be > 8, but should at most be 8-byte aligned.

Initial work
8cf09c7

Fix build
10bbcce

More fixes
6d2a284

Check for swift call conv
90bab28

More
b5586da

More fixing
a17cdeb

Fix further
6214044

Fixes
60eecf1

More fixing
10d1f3b

Fix
8db32af

Fix
1eab0d9

Handle stack and registers separately
be0137e

More
3faedce

Enable implicit byrefs on SysV x64
5b72edd

Fix SysV x64 arg asserts
27cb1b1

jakobbotsch added 6 commits April 3, 2024 15:35

Maybe that does it
5929425

Run jit-format
0bf62c0

Clean up
955e5bf

Fix an x64 assert
efc5637

Clean up
c4874e0

Straggler
ee436f6

jakobbotsch added 2 commits April 4, 2024 11:01

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
700864a
…invokes-structs

Run jit-format
ef478a0

build-analysisBot mentioned this pull request Apr 4, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

EgorBo mentioned this pull request Apr 4, 2024
Force 2 iterations of OptRepeat #100473
Closed

jakobbotsch marked this pull request as ready for review April 4, 2024 18:59

jakobbotsch requested a review from amanasifkhalid April 4, 2024 19:02

amanasifkhalid mentioned this pull request Apr 4, 2024
JIT: Support Swift error handling for reverse P/Invokes #100429
Merged

jakobbotsch added 2 commits April 4, 2024 21:08

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
fa1860c
…invokes-structs

Fix bad merge
010552a

amanasifkhalid approved these changes Apr 4, 2024
View reviewed changes

Address feedback
4f272f7

jakobbotsch merged commit a971763 into dotnet:mainApr 5, 2024

jakobbotsch deleted the swift-reverse-pinvokes-structs branch April 5, 2024 08:04

github-actionsBot locked and limited conversation to collaborators May 5, 2024

jakobbotsch added 30 commits March 25, 2024 20:05

JIT: Split ABI classification by ABI
fea5284

Refactor, fix arm64
150cb28

Run jit-format
af2fc72

Comments
1d09c9f

Fix varargs retbuf case
dcccedd

Fix SysV
7fe878b

Add function headers
9297865

Nit
25e2c49

Fix macOS arm64 ABI bug
9954062

Preemptively fix build
5fab654

More build fixes
3f1c738

Further fix build
b8d9334

Move classifiers into target specific files
f12a9d7

Fix x86
70a0aff

Fix Apple ARM64 ABI for HVAs
0e82029
For HVAs the element size can be > 8, but should at most be 8-byte aligned.

Initial work
8cf09c7

Fix build
10bbcce

More fixes
6d2a284

Check for swift call conv
90bab28

More
b5586da

More fixing
a17cdeb

Fix further
6214044

Fixes
60eecf1

More fixing
10d1f3b

Fix
8db32af

Fix
1eab0d9

Handle stack and registers separately
be0137e

More
3faedce

Enable implicit byrefs on SysV x64
5b72edd

Fix SysV x64 arg asserts
27cb1b1

jakobbotsch added 6 commits April 3, 2024 15:35

Maybe that does it
5929425

Run jit-format
0bf62c0

Clean up
955e5bf

Fix an x64 assert
efc5637

Clean up
c4874e0

Straggler
ee436f6

jakobbotsch added 2 commits April 4, 2024 11:01

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
700864a
…invokes-structs

Run jit-format
ef478a0

build-analysisBot mentioned this pull request Apr 4, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

EgorBo mentioned this pull request Apr 4, 2024
Force 2 iterations of OptRepeat #100473
Closed

jakobbotsch marked this pull request as ready for review April 4, 2024 18:59

jakobbotsch requested a review from amanasifkhalid April 4, 2024 19:02

amanasifkhalid mentioned this pull request Apr 4, 2024
JIT: Support Swift error handling for reverse P/Invokes #100429
Merged

jakobbotsch added 2 commits April 4, 2024 21:08

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
fa1860c
…invokes-structs

Fix bad merge
010552a

amanasifkhalid approved these changes Apr 4, 2024
View reviewed changes

Address feedback
4f272f7

jakobbotsch merged commit a971763 into dotnet:mainApr 5, 2024

jakobbotsch deleted the swift-reverse-pinvokes-structs branch April 5, 2024 08:04

github-actionsBot locked and limited conversation to collaborators May 5, 2024

jakobbotsch added 30 commits March 25, 2024 20:05

JIT: Split ABI classification by ABI
fea5284

Refactor, fix arm64
150cb28

Run jit-format
af2fc72

Comments
1d09c9f

Fix varargs retbuf case
dcccedd

Fix SysV
7fe878b

Add function headers
9297865

Nit
25e2c49

Fix macOS arm64 ABI bug
9954062

Preemptively fix build
5fab654

More build fixes
3f1c738

Further fix build
b8d9334

Move classifiers into target specific files
f12a9d7

Fix x86
70a0aff

Fix Apple ARM64 ABI for HVAs
0e82029
For HVAs the element size can be > 8, but should at most be 8-byte aligned.

Initial work
8cf09c7

Fix build
10bbcce

More fixes
6d2a284

Check for swift call conv
90bab28

More
b5586da

More fixing
a17cdeb

Fix further
6214044

Fixes
60eecf1

More fixing
10d1f3b

Fix
8db32af

Fix
1eab0d9

Handle stack and registers separately
be0137e

More
3faedce

Enable implicit byrefs on SysV x64
5b72edd

Fix SysV x64 arg asserts
27cb1b1

jakobbotsch added 6 commits April 3, 2024 15:35

Maybe that does it
5929425

Run jit-format
0bf62c0

Clean up
955e5bf

Fix an x64 assert
efc5637

Clean up
c4874e0

Straggler
ee436f6

jakobbotsch added 2 commits April 4, 2024 11:01

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
700864a
…invokes-structs

Run jit-format
ef478a0

build-analysisBot mentioned this pull request Apr 4, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

EgorBo mentioned this pull request Apr 4, 2024
Force 2 iterations of OptRepeat #100473
Closed

jakobbotsch marked this pull request as ready for review April 4, 2024 18:59

jakobbotsch requested a review from amanasifkhalid April 4, 2024 19:02

amanasifkhalid mentioned this pull request Apr 4, 2024
JIT: Support Swift error handling for reverse P/Invokes #100429
Merged

jakobbotsch added 2 commits April 4, 2024 21:08

Merge branch 'main' of github.com:dotnet/runtime into swift-reverse-p…
fa1860c
…invokes-structs

Fix bad merge
010552a

amanasifkhalid approved these changes Apr 4, 2024
View reviewed changes

Address feedback
4f272f7

jakobbotsch merged commit a971763 into dotnet:mainApr 5, 2024

jakobbotsch deleted the swift-reverse-pinvokes-structs branch April 5, 2024 08:04

github-actionsBot locked and limited conversation to collaborators May 5, 2024

Uh oh!

Conversation

jakobbotsch commented Mar 27, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakobbotsch commented Apr 3, 2024

Uh oh!

azure-pipelinesBot commented Apr 3, 2024

Uh oh!

jakobbotsch commented Apr 4, 2024

Uh oh!

jakobbotsch commented Apr 4, 2024

Uh oh!

amanasifkhalid left a comment

Choose a reason for hiding this comment

Uh oh!

amanasifkhalidApr 4, 2024

Choose a reason for hiding this comment

Uh oh!

jakobbotschApr 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakobbotsch commented Apr 4, 2024

Uh oh!

jakobbotsch commented Apr 4, 2024

Uh oh!

azure-pipelinesBot commented Apr 4, 2024

Uh oh!

jakobbotsch commented Apr 4, 2024

Uh oh!

jakobbotsch commented Apr 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jakobbotsch commented Mar 27, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakobbotsch commented Apr 3, 2024

Uh oh!

azure-pipelinesBot commented Apr 3, 2024

Uh oh!

jakobbotsch commented Apr 4, 2024

Uh oh!

jakobbotsch commented Apr 4, 2024

Uh oh!

amanasifkhalid left a comment

Choose a reason for hiding this comment

Uh oh!

amanasifkhalidApr 4, 2024

Choose a reason for hiding this comment

Uh oh!

jakobbotschApr 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakobbotsch commented Apr 4, 2024

Uh oh!

jakobbotsch commented Apr 4, 2024

Uh oh!

azure-pipelinesBot commented Apr 4, 2024

Uh oh!

jakobbotsch commented Apr 4, 2024

Uh oh!

jakobbotsch commented Apr 5, 2024

Uh oh!

Reviewers

Assignees

jakobbotsch commented Mar 27, 2024•
edited
Loading

jakobbotsch commented Mar 27, 2024•
edited
Loading

jakobbotsch commented Mar 27, 2024•
edited
Loading

jakobbotsch commented Mar 27, 2024•
edited
Loading