Uh oh!
There was an error while loading. Please reload this page.
Commit Accounting related changes - #100380
Conversation
Tagging subscribers to this area: @dotnet/gc |
9beeb42 to
34c53c5Comparecc4c736 to
fcbcdc2CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
4d24a44 to
78d6849Compare78d6849 to
1a3ef3cCompareUh oh!
There was an error while loading. Please reload this page.
Maoni0
left a comment
There was a problem hiding this comment.
other than the one small comment, LGTM!
cshung
commented
May 22, 2024
This change is tested with all these combinations: x86/x64 Bug #102585 is found, but it is unrelated to commit accounting. |
heap_segmentare moved across heaps duringchange_heap_count, this change records them so thatcommitted_by_oh_per_heapis still valid.committed_byvalues regardless ofheap_hard_limit, which will allow usrefresh_memory_limitfor segments.verify_regionsinto_DEBUG.release_segment, heap_segment are released byvirtual_free, we need to also decrement the committed counters when that happen.get_segment, we accidentally usedmax_generationasohfor UOH segments, this change will make it use the rightoh.grow_brick_card_table, heap_segment are released byvirtual_free, we need to also decrement the committed counters when that happen.... to be continued.