Linker dependency framework by jtschuster · Pull Request #101277 · dotnet/runtime

jtschuster · 2024-04-19T04:45:54Z

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types.

…ependencyFramework

dotnet-policy-service · 2024-04-19T04:46:32Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

vitek-karas · 2024-04-19T14:17:40Z

+ protected override void OnMarked (MarkStepNodeFactory context)
+ {
+ markStep.MarkTypeImpl (reference, reason, origin);
+ }


I don't know enough of the DF to tell if this is the right place to do the heavy processing. But I guess for now it is.
I assume eventually all of this would move to GetDependencies and we would remove OnMarked, right?
Future thought: Try to figure out how the DF will play with Annotations and the notion of "marked item" which is used outside of the mark step in the trimmer.

Yeah, I think ideally most of this moves to GetDependencies and this is minimal or removed.
My thought is that eventually the Annotations markings will forward to the analyzer markings, but that could get complicated if marking (not just IsMarked checks) happen outside of MarkStep. In the meantime, I think OnMarked will call Annotations.MarkX.

vitek-karas · 2024-04-19T14:19:27Z

 var parameter = parameters[i];

-TypeDefinition? argumentTypeDef = MarkType (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));
+var argumentTypeDef = MarkTypeImpl (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));


This is the place where it gets interesting for TypeRef versus TypeDef :-)

…ependencyFramework

…cyFramework

sbomer · 2024-05-02T16:50:14Z

 if (CheckProcessed (type))
 return type;

+ if (type.HasMethods) {


I'm curious why this moved - at first glance it looks like it better belongs in ProcessType since it should happen just once per type definition.

Originally I moved it up because it relied on the DependencyInfo, but I think that can condition can be removed and moved back to ProcessMethod. I think the check on the DependencyKind was only to prevent infinite recursion when marking cctors, which we won't hit with the dependency analyzer.

sbomer · 2024-05-02T16:51:26Z

+ protected override string GetName (NodeFactory context) => $"{type.GetDisplayName()} is relevant to variant casting";
+ protected override void OnMarked (NodeFactory context)
+ {
+ context.MarkStep.Annotations.MarkRelevantToVariantCasting (type);


When do we use OnMarked vs GetStaticDependencies?

I just used OnMarked arbitrarily for this since there aren't any dependencies. It looks like OnMarked will do work up front when the node is returned from another GetStaticDependencies, then it's added to a stack to later call GetStaticDependencies.

- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

…ster/runtime into LinkerDependencyFramework

sbomer

LGTM, thank you!

vitek-karas · 2024-05-03T08:09:47Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

jtschuster · 2024-05-03T19:04:43Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

Yep, it looks like this has about the exact same speed performance. We allocate a bit more for all the Funcs used when producing nodes, but they're short lived and shouldn't impact max working set too much (and we can remove the allocation in a follow up).

…link

…ster/runtime into LinkerDependencyFramework

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types. Makes ILCompiler.DependencyAnalysisFramework output path independent of target architecture. Removes TargetArchitecture and TargetOS from ILLink.Tasks project references. --------- Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>

jtschuster · 2024-04-19T04:45:54Z

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types.

…ependencyFramework

dotnet-policy-service · 2024-04-19T04:46:32Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

vitek-karas · 2024-04-19T14:17:40Z

+ protected override void OnMarked (MarkStepNodeFactory context)
+ {
+ markStep.MarkTypeImpl (reference, reason, origin);
+ }


I don't know enough of the DF to tell if this is the right place to do the heavy processing. But I guess for now it is.
I assume eventually all of this would move to GetDependencies and we would remove OnMarked, right?
Future thought: Try to figure out how the DF will play with Annotations and the notion of "marked item" which is used outside of the mark step in the trimmer.

Yeah, I think ideally most of this moves to GetDependencies and this is minimal or removed.
My thought is that eventually the Annotations markings will forward to the analyzer markings, but that could get complicated if marking (not just IsMarked checks) happen outside of MarkStep. In the meantime, I think OnMarked will call Annotations.MarkX.

vitek-karas · 2024-04-19T14:19:27Z

 var parameter = parameters[i];

-TypeDefinition? argumentTypeDef = MarkType (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));
+var argumentTypeDef = MarkTypeImpl (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));


This is the place where it gets interesting for TypeRef versus TypeDef :-)

…ependencyFramework

…cyFramework

sbomer · 2024-05-02T16:50:14Z

 if (CheckProcessed (type))
 return type;

+ if (type.HasMethods) {


I'm curious why this moved - at first glance it looks like it better belongs in ProcessType since it should happen just once per type definition.

Originally I moved it up because it relied on the DependencyInfo, but I think that can condition can be removed and moved back to ProcessMethod. I think the check on the DependencyKind was only to prevent infinite recursion when marking cctors, which we won't hit with the dependency analyzer.

sbomer · 2024-05-02T16:51:26Z

+ protected override string GetName (NodeFactory context) => $"{type.GetDisplayName()} is relevant to variant casting";
+ protected override void OnMarked (NodeFactory context)
+ {
+ context.MarkStep.Annotations.MarkRelevantToVariantCasting (type);


When do we use OnMarked vs GetStaticDependencies?

I just used OnMarked arbitrarily for this since there aren't any dependencies. It looks like OnMarked will do work up front when the node is returned from another GetStaticDependencies, then it's added to a stack to later call GetStaticDependencies.

- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

…ster/runtime into LinkerDependencyFramework

sbomer

LGTM, thank you!

vitek-karas · 2024-05-03T08:09:47Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

jtschuster · 2024-05-03T19:04:43Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

Yep, it looks like this has about the exact same speed performance. We allocate a bit more for all the Funcs used when producing nodes, but they're short lived and shouldn't impact max working set too much (and we can remove the allocation in a follow up).

…link

…ster/runtime into LinkerDependencyFramework

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types. Makes ILCompiler.DependencyAnalysisFramework output path independent of target architecture. Removes TargetArchitecture and TargetOS from ILLink.Tasks project references. --------- Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>

jtschuster · 2024-04-19T04:45:54Z

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types.

…ependencyFramework

dotnet-policy-service · 2024-04-19T04:46:32Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

vitek-karas · 2024-04-19T14:17:40Z

+ protected override void OnMarked (MarkStepNodeFactory context)
+ {
+ markStep.MarkTypeImpl (reference, reason, origin);
+ }


I don't know enough of the DF to tell if this is the right place to do the heavy processing. But I guess for now it is.
I assume eventually all of this would move to GetDependencies and we would remove OnMarked, right?
Future thought: Try to figure out how the DF will play with Annotations and the notion of "marked item" which is used outside of the mark step in the trimmer.

Yeah, I think ideally most of this moves to GetDependencies and this is minimal or removed.
My thought is that eventually the Annotations markings will forward to the analyzer markings, but that could get complicated if marking (not just IsMarked checks) happen outside of MarkStep. In the meantime, I think OnMarked will call Annotations.MarkX.

vitek-karas · 2024-04-19T14:19:27Z

 var parameter = parameters[i];

-TypeDefinition? argumentTypeDef = MarkType (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));
+var argumentTypeDef = MarkTypeImpl (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));


This is the place where it gets interesting for TypeRef versus TypeDef :-)

…ependencyFramework

…cyFramework

sbomer · 2024-05-02T16:50:14Z

 if (CheckProcessed (type))
 return type;

+ if (type.HasMethods) {


I'm curious why this moved - at first glance it looks like it better belongs in ProcessType since it should happen just once per type definition.

Originally I moved it up because it relied on the DependencyInfo, but I think that can condition can be removed and moved back to ProcessMethod. I think the check on the DependencyKind was only to prevent infinite recursion when marking cctors, which we won't hit with the dependency analyzer.

sbomer · 2024-05-02T16:51:26Z

+ protected override string GetName (NodeFactory context) => $"{type.GetDisplayName()} is relevant to variant casting";
+ protected override void OnMarked (NodeFactory context)
+ {
+ context.MarkStep.Annotations.MarkRelevantToVariantCasting (type);


When do we use OnMarked vs GetStaticDependencies?

I just used OnMarked arbitrarily for this since there aren't any dependencies. It looks like OnMarked will do work up front when the node is returned from another GetStaticDependencies, then it's added to a stack to later call GetStaticDependencies.

- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

…ster/runtime into LinkerDependencyFramework

sbomer

LGTM, thank you!

vitek-karas · 2024-05-03T08:09:47Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

jtschuster · 2024-05-03T19:04:43Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

Yep, it looks like this has about the exact same speed performance. We allocate a bit more for all the Funcs used when producing nodes, but they're short lived and shouldn't impact max working set too much (and we can remove the allocation in a follow up).

…link

…ster/runtime into LinkerDependencyFramework

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types. Makes ILCompiler.DependencyAnalysisFramework output path independent of target architecture. Removes TargetArchitecture and TargetOS from ILLink.Tasks project references. --------- Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>

jtschuster · 2024-04-19T04:45:54Z

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types.

…ependencyFramework

dotnet-policy-service · 2024-04-19T04:46:32Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

vitek-karas · 2024-04-19T14:17:40Z

+ protected override void OnMarked (MarkStepNodeFactory context)
+ {
+ markStep.MarkTypeImpl (reference, reason, origin);
+ }


I don't know enough of the DF to tell if this is the right place to do the heavy processing. But I guess for now it is.
I assume eventually all of this would move to GetDependencies and we would remove OnMarked, right?
Future thought: Try to figure out how the DF will play with Annotations and the notion of "marked item" which is used outside of the mark step in the trimmer.

Yeah, I think ideally most of this moves to GetDependencies and this is minimal or removed.
My thought is that eventually the Annotations markings will forward to the analyzer markings, but that could get complicated if marking (not just IsMarked checks) happen outside of MarkStep. In the meantime, I think OnMarked will call Annotations.MarkX.

vitek-karas · 2024-04-19T14:19:27Z

 var parameter = parameters[i];

-TypeDefinition? argumentTypeDef = MarkType (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));
+var argumentTypeDef = MarkTypeImpl (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));


This is the place where it gets interesting for TypeRef versus TypeDef :-)

…ependencyFramework

…cyFramework

sbomer · 2024-05-02T16:50:14Z

 if (CheckProcessed (type))
 return type;

+ if (type.HasMethods) {


I'm curious why this moved - at first glance it looks like it better belongs in ProcessType since it should happen just once per type definition.

Originally I moved it up because it relied on the DependencyInfo, but I think that can condition can be removed and moved back to ProcessMethod. I think the check on the DependencyKind was only to prevent infinite recursion when marking cctors, which we won't hit with the dependency analyzer.

sbomer · 2024-05-02T16:51:26Z

+ protected override string GetName (NodeFactory context) => $"{type.GetDisplayName()} is relevant to variant casting";
+ protected override void OnMarked (NodeFactory context)
+ {
+ context.MarkStep.Annotations.MarkRelevantToVariantCasting (type);


When do we use OnMarked vs GetStaticDependencies?

I just used OnMarked arbitrarily for this since there aren't any dependencies. It looks like OnMarked will do work up front when the node is returned from another GetStaticDependencies, then it's added to a stack to later call GetStaticDependencies.

- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

…ster/runtime into LinkerDependencyFramework

sbomer

LGTM, thank you!

vitek-karas · 2024-05-03T08:09:47Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

jtschuster · 2024-05-03T19:04:43Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

Yep, it looks like this has about the exact same speed performance. We allocate a bit more for all the Funcs used when producing nodes, but they're short lived and shouldn't impact max working set too much (and we can remove the allocation in a follow up).

…link

…ster/runtime into LinkerDependencyFramework

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types. Makes ILCompiler.DependencyAnalysisFramework output path independent of target architecture. Removes TargetArchitecture and TargetOS from ILLink.Tasks project references. --------- Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>

jtschuster · 2024-04-19T04:45:54Z

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types.

…ependencyFramework

dotnet-policy-service · 2024-04-19T04:46:32Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

vitek-karas · 2024-04-19T14:17:40Z

+ protected override void OnMarked (MarkStepNodeFactory context)
+ {
+ markStep.MarkTypeImpl (reference, reason, origin);
+ }


I don't know enough of the DF to tell if this is the right place to do the heavy processing. But I guess for now it is.
I assume eventually all of this would move to GetDependencies and we would remove OnMarked, right?
Future thought: Try to figure out how the DF will play with Annotations and the notion of "marked item" which is used outside of the mark step in the trimmer.

Yeah, I think ideally most of this moves to GetDependencies and this is minimal or removed.
My thought is that eventually the Annotations markings will forward to the analyzer markings, but that could get complicated if marking (not just IsMarked checks) happen outside of MarkStep. In the meantime, I think OnMarked will call Annotations.MarkX.

vitek-karas · 2024-04-19T14:19:27Z

 var parameter = parameters[i];

-TypeDefinition? argumentTypeDef = MarkType (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));
+var argumentTypeDef = MarkTypeImpl (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));


This is the place where it gets interesting for TypeRef versus TypeDef :-)

…ependencyFramework

…cyFramework

sbomer · 2024-05-02T16:50:14Z

 if (CheckProcessed (type))
 return type;

+ if (type.HasMethods) {


I'm curious why this moved - at first glance it looks like it better belongs in ProcessType since it should happen just once per type definition.

Originally I moved it up because it relied on the DependencyInfo, but I think that can condition can be removed and moved back to ProcessMethod. I think the check on the DependencyKind was only to prevent infinite recursion when marking cctors, which we won't hit with the dependency analyzer.

sbomer · 2024-05-02T16:51:26Z

+ protected override string GetName (NodeFactory context) => $"{type.GetDisplayName()} is relevant to variant casting";
+ protected override void OnMarked (NodeFactory context)
+ {
+ context.MarkStep.Annotations.MarkRelevantToVariantCasting (type);


When do we use OnMarked vs GetStaticDependencies?

I just used OnMarked arbitrarily for this since there aren't any dependencies. It looks like OnMarked will do work up front when the node is returned from another GetStaticDependencies, then it's added to a stack to later call GetStaticDependencies.

- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

…ster/runtime into LinkerDependencyFramework

sbomer

LGTM, thank you!

vitek-karas · 2024-05-03T08:09:47Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

jtschuster · 2024-05-03T19:04:43Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

Yep, it looks like this has about the exact same speed performance. We allocate a bit more for all the Funcs used when producing nodes, but they're short lived and shouldn't impact max working set too much (and we can remove the allocation in a follow up).

…link

…ster/runtime into LinkerDependencyFramework

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types. Makes ILCompiler.DependencyAnalysisFramework output path independent of target architecture. Removes TargetArchitecture and TargetOS from ILLink.Tasks project references. --------- Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>

jtschuster · 2024-04-19T04:45:54Z

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types.

…ependencyFramework

dotnet-policy-service · 2024-04-19T04:46:32Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

vitek-karas · 2024-04-19T14:17:40Z

+ protected override void OnMarked (MarkStepNodeFactory context)
+ {
+ markStep.MarkTypeImpl (reference, reason, origin);
+ }


I don't know enough of the DF to tell if this is the right place to do the heavy processing. But I guess for now it is.
I assume eventually all of this would move to GetDependencies and we would remove OnMarked, right?
Future thought: Try to figure out how the DF will play with Annotations and the notion of "marked item" which is used outside of the mark step in the trimmer.

Yeah, I think ideally most of this moves to GetDependencies and this is minimal or removed.
My thought is that eventually the Annotations markings will forward to the analyzer markings, but that could get complicated if marking (not just IsMarked checks) happen outside of MarkStep. In the meantime, I think OnMarked will call Annotations.MarkX.

vitek-karas · 2024-04-19T14:19:27Z

 var parameter = parameters[i];

-TypeDefinition? argumentTypeDef = MarkType (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));
+var argumentTypeDef = MarkTypeImpl (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));


This is the place where it gets interesting for TypeRef versus TypeDef :-)

…ependencyFramework

…cyFramework

sbomer · 2024-05-02T16:50:14Z

 if (CheckProcessed (type))
 return type;

+ if (type.HasMethods) {


I'm curious why this moved - at first glance it looks like it better belongs in ProcessType since it should happen just once per type definition.

Originally I moved it up because it relied on the DependencyInfo, but I think that can condition can be removed and moved back to ProcessMethod. I think the check on the DependencyKind was only to prevent infinite recursion when marking cctors, which we won't hit with the dependency analyzer.

sbomer · 2024-05-02T16:51:26Z

+ protected override string GetName (NodeFactory context) => $"{type.GetDisplayName()} is relevant to variant casting";
+ protected override void OnMarked (NodeFactory context)
+ {
+ context.MarkStep.Annotations.MarkRelevantToVariantCasting (type);


When do we use OnMarked vs GetStaticDependencies?

I just used OnMarked arbitrarily for this since there aren't any dependencies. It looks like OnMarked will do work up front when the node is returned from another GetStaticDependencies, then it's added to a stack to later call GetStaticDependencies.

- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

…ster/runtime into LinkerDependencyFramework

sbomer

LGTM, thank you!

vitek-karas · 2024-05-03T08:09:47Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

jtschuster · 2024-05-03T19:04:43Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

Yep, it looks like this has about the exact same speed performance. We allocate a bit more for all the Funcs used when producing nodes, but they're short lived and shouldn't impact max working set too much (and we can remove the allocation in a follow up).

…link

…ster/runtime into LinkerDependencyFramework

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types. Makes ILCompiler.DependencyAnalysisFramework output path independent of target architecture. Removes TargetArchitecture and TargetOS from ILLink.Tasks project references. --------- Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>

jtschuster · 2024-04-19T04:45:54Z

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types.

…ependencyFramework

dotnet-policy-service · 2024-04-19T04:46:32Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

vitek-karas · 2024-04-19T14:17:40Z

+ protected override void OnMarked (MarkStepNodeFactory context)
+ {
+ markStep.MarkTypeImpl (reference, reason, origin);
+ }


I don't know enough of the DF to tell if this is the right place to do the heavy processing. But I guess for now it is.
I assume eventually all of this would move to GetDependencies and we would remove OnMarked, right?
Future thought: Try to figure out how the DF will play with Annotations and the notion of "marked item" which is used outside of the mark step in the trimmer.

Yeah, I think ideally most of this moves to GetDependencies and this is minimal or removed.
My thought is that eventually the Annotations markings will forward to the analyzer markings, but that could get complicated if marking (not just IsMarked checks) happen outside of MarkStep. In the meantime, I think OnMarked will call Annotations.MarkX.

vitek-karas · 2024-04-19T14:19:27Z

 var parameter = parameters[i];

-TypeDefinition? argumentTypeDef = MarkType (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));
+var argumentTypeDef = MarkTypeImpl (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));


This is the place where it gets interesting for TypeRef versus TypeDef :-)

…ependencyFramework

…cyFramework

sbomer · 2024-05-02T16:50:14Z

 if (CheckProcessed (type))
 return type;

+ if (type.HasMethods) {


I'm curious why this moved - at first glance it looks like it better belongs in ProcessType since it should happen just once per type definition.

Originally I moved it up because it relied on the DependencyInfo, but I think that can condition can be removed and moved back to ProcessMethod. I think the check on the DependencyKind was only to prevent infinite recursion when marking cctors, which we won't hit with the dependency analyzer.

sbomer · 2024-05-02T16:51:26Z

+ protected override string GetName (NodeFactory context) => $"{type.GetDisplayName()} is relevant to variant casting";
+ protected override void OnMarked (NodeFactory context)
+ {
+ context.MarkStep.Annotations.MarkRelevantToVariantCasting (type);


When do we use OnMarked vs GetStaticDependencies?

I just used OnMarked arbitrarily for this since there aren't any dependencies. It looks like OnMarked will do work up front when the node is returned from another GetStaticDependencies, then it's added to a stack to later call GetStaticDependencies.

- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

…ster/runtime into LinkerDependencyFramework

sbomer

LGTM, thank you!

vitek-karas · 2024-05-03T08:09:47Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

jtschuster · 2024-05-03T19:04:43Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

Yep, it looks like this has about the exact same speed performance. We allocate a bit more for all the Funcs used when producing nodes, but they're short lived and shouldn't impact max working set too much (and we can remove the allocation in a follow up).

…link

…ster/runtime into LinkerDependencyFramework

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types. Makes ILCompiler.DependencyAnalysisFramework output path independent of target architecture. Removes TargetArchitecture and TargetOS from ILLink.Tasks project references. --------- Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>

jtschuster · 2024-04-19T04:45:54Z

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types.

…ependencyFramework

dotnet-policy-service · 2024-04-19T04:46:32Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

vitek-karas · 2024-04-19T14:17:40Z

+ protected override void OnMarked (MarkStepNodeFactory context)
+ {
+ markStep.MarkTypeImpl (reference, reason, origin);
+ }


I don't know enough of the DF to tell if this is the right place to do the heavy processing. But I guess for now it is.
I assume eventually all of this would move to GetDependencies and we would remove OnMarked, right?
Future thought: Try to figure out how the DF will play with Annotations and the notion of "marked item" which is used outside of the mark step in the trimmer.

Yeah, I think ideally most of this moves to GetDependencies and this is minimal or removed.
My thought is that eventually the Annotations markings will forward to the analyzer markings, but that could get complicated if marking (not just IsMarked checks) happen outside of MarkStep. In the meantime, I think OnMarked will call Annotations.MarkX.

vitek-karas · 2024-04-19T14:19:27Z

 var parameter = parameters[i];

-TypeDefinition? argumentTypeDef = MarkType (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));
+var argumentTypeDef = MarkTypeImpl (argument, new DependencyInfo (DependencyKind.GenericArgumentType, instance));


This is the place where it gets interesting for TypeRef versus TypeDef :-)

…ependencyFramework

…cyFramework

sbomer · 2024-05-02T16:50:14Z

 if (CheckProcessed (type))
 return type;

+ if (type.HasMethods) {


I'm curious why this moved - at first glance it looks like it better belongs in ProcessType since it should happen just once per type definition.

Originally I moved it up because it relied on the DependencyInfo, but I think that can condition can be removed and moved back to ProcessMethod. I think the check on the DependencyKind was only to prevent infinite recursion when marking cctors, which we won't hit with the dependency analyzer.

sbomer · 2024-05-02T16:51:26Z

+ protected override string GetName (NodeFactory context) => $"{type.GetDisplayName()} is relevant to variant casting";
+ protected override void OnMarked (NodeFactory context)
+ {
+ context.MarkStep.Annotations.MarkRelevantToVariantCasting (type);


When do we use OnMarked vs GetStaticDependencies?

I just used OnMarked arbitrarily for this since there aren't any dependencies. It looks like OnMarked will do work up front when the node is returned from another GetStaticDependencies, then it's added to a stack to later call GetStaticDependencies.

- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

…ster/runtime into LinkerDependencyFramework

sbomer

LGTM, thank you!

vitek-karas · 2024-05-03T08:09:47Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

jtschuster · 2024-05-03T19:04:43Z

Did you try a simple perf measurement? I don't expect to see noticeable difference, but it does change how the main loop works... ;-)

Yep, it looks like this has about the exact same speed performance. We allocate a bit more for all the Funcs used when producing nodes, but they're short lived and shouldn't impact max working set too much (and we can remove the allocation in a follow up).

…link

…ster/runtime into LinkerDependencyFramework

Recreates the Process() loop in MarkStep with node that depends on a new copy of itself when the loop needs to be rerun. Within the loop, the new Method and Type nodes are added to the dependency framework analyzer as roots when MarkMethod and MarkType are called, which leads to the OnMarked methods to be called, which forwards to the ProcessType/Method method in MarkStep. The dependency analyzer doesn't do anything interesting yet. In a follow-up I'll move dependencies from the MarkX and ProcessX methods to the DependencyNode types. Makes ILCompiler.DependencyAnalysisFramework output path independent of target architecture. Removes TargetArchitecture and TargetOS from ILLink.Tasks project references. --------- Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>

vitek-karasand others added 5 commits September 13, 2023 11:19

MarkStep runs inside dependency framework
afe8990

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
4a92aaf
…ependencyFramework

Put MarkType into DependencyFramework
76fe923

Leave MarkType in MarkStep, use captured MarkStep to call it
b3ccd66

Format
eb5e333

jtschuster added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 19, 2024

ghost added the area-NativeAOT-coreclr label Apr 19, 2024

dotnet-policy-serviceBot assigned jtschuster Apr 19, 2024

vitek-karas reviewed Apr 19, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Linker.Steps/MarkStep.cs Outdated

vitek-karas reviewed Apr 19, 2024
View reviewed changes

jtschuster added 3 commits April 19, 2024 16:21

Use DF for TypeDefinition and MethodDefinition
e1270bb

Rename MarkTypeImpl to ProcessType and clean up code
2d12ade

Clean up code a bit more
1dc80db

MichalStrehovsky reviewed Apr 22, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Mono.Linker.csproj Outdated

jtschuster added 7 commits April 22, 2024 12:07

Use ProjectReference for DAF, and undo method moves
991f7a0

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
069f47b
…ependencyFramework

Don't have additional virtualmethods processing
c1670eb

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
8382e68
…ependencyFramework

Remove old header comment copied from MarkStep
5bf5ece

Remove nullable directives from ilc files
e6edbce

Sign DAF instead of nowarn on trimmer
10a5c57

jtschuster removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 22, 2024

jtschuster added 2 commits April 22, 2024 16:51

Re-add doc comment; Make types internal
166d2d5

Undo Queue changes, fix visibility issues
01f3a79

This was referenced Apr 23, 2024
[wasm] System.Text.Json.Tests running out of memory #98578
Closed
WASM test failing with OOM #100111
Closed

Merge branch 'ILLinkDescriptionDuplicatePreserve' into LinkerDependen…
8cbedd1
…cyFramework

This was referenced Apr 27, 2024
[wasm][firefox] crit: OpenQA.Selenium.WebDriverException: Failed to decode response from marionette #101617
Open
AbbreviatedMonthGenitiveNames_Get_ReturnsExpected_HybridGlobalization failing with string mismatch #101634
Closed

Merge branch 'main' into LinkerDependencyFramework
df7a522

This was referenced May 1, 2024
[wasm] WBT: Blazor tests on windows failing with Failed to bind to address for random ports #92910
Closed
System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanScalarDestination_SpecialValues fails #101721
Closed

Merge branch 'main' into LinkerDependencyFramework
28bf0be

MichalStrehovsky approved these changes May 2, 2024
View reviewed changes

sbomer reviewed May 2, 2024
View reviewed changes

jtschuster added 3 commits May 2, 2024 11:15

PR Feedback:
3ca9f9a
- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
830f23e
…ster/runtime into LinkerDependencyFramework

Add space before method call parentheses
3001124

sbomer approved these changes May 2, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 2, 2024
Test failure in System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101731
Closed

jtschuster added 2 commits May 3, 2024 13:12

Don't pass TargetOS and TargetArch to ILLink.Tasks when using live il…
f003f74
…link

Merge branch 'main' into LinkerDependencyFramework
a0f6861

sbomer reviewed May 3, 2024
View reviewed changes

Comment threadeng/liveILLink.targets Outdated

jtschuster added 4 commits May 3, 2024 14:56

Update comment in liveILLink.targets
d358b42

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
0fab4e3
…ster/runtime into LinkerDependencyFramework

Don't append platform to output dirs
5e124b5

Merge branch 'main' into LinkerDependencyFramework
855b109

jtschuster requested a review from agocke May 6, 2024 20:03

jtschuster merged commit fbb67a6 into dotnet:mainMay 6, 2024

This was referenced May 6, 2024
Failed to find compatible device: arm64-v8a dotnet/dnceng#2283
Closed
Cannot find 'arm64-v8a' device dotnet/dnceng#2284
Closed

github-actionsBot locked and limited conversation to collaborators Jun 6, 2024

vitek-karasand others added 5 commits September 13, 2023 11:19

MarkStep runs inside dependency framework
afe8990

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
4a92aaf
…ependencyFramework

Put MarkType into DependencyFramework
76fe923

Leave MarkType in MarkStep, use captured MarkStep to call it
b3ccd66

Format
eb5e333

jtschuster added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 19, 2024

ghost added the area-NativeAOT-coreclr label Apr 19, 2024

dotnet-policy-serviceBot assigned jtschuster Apr 19, 2024

vitek-karas reviewed Apr 19, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Linker.Steps/MarkStep.cs Outdated

vitek-karas reviewed Apr 19, 2024
View reviewed changes

jtschuster added 3 commits April 19, 2024 16:21

Use DF for TypeDefinition and MethodDefinition
e1270bb

Rename MarkTypeImpl to ProcessType and clean up code
2d12ade

Clean up code a bit more
1dc80db

MichalStrehovsky reviewed Apr 22, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Mono.Linker.csproj Outdated

jtschuster added 7 commits April 22, 2024 12:07

Use ProjectReference for DAF, and undo method moves
991f7a0

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
069f47b
…ependencyFramework

Don't have additional virtualmethods processing
c1670eb

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
8382e68
…ependencyFramework

Remove old header comment copied from MarkStep
5bf5ece

Remove nullable directives from ilc files
e6edbce

Sign DAF instead of nowarn on trimmer
10a5c57

jtschuster removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 22, 2024

jtschuster added 2 commits April 22, 2024 16:51

Re-add doc comment; Make types internal
166d2d5

Undo Queue changes, fix visibility issues
01f3a79

This was referenced Apr 23, 2024
[wasm] System.Text.Json.Tests running out of memory #98578
Closed
WASM test failing with OOM #100111
Closed

Merge branch 'ILLinkDescriptionDuplicatePreserve' into LinkerDependen…
8cbedd1
…cyFramework

This was referenced Apr 27, 2024
[wasm][firefox] crit: OpenQA.Selenium.WebDriverException: Failed to decode response from marionette #101617
Open
AbbreviatedMonthGenitiveNames_Get_ReturnsExpected_HybridGlobalization failing with string mismatch #101634
Closed

Merge branch 'main' into LinkerDependencyFramework
df7a522

This was referenced May 1, 2024
[wasm] WBT: Blazor tests on windows failing with Failed to bind to address for random ports #92910
Closed
System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanScalarDestination_SpecialValues fails #101721
Closed

Merge branch 'main' into LinkerDependencyFramework
28bf0be

MichalStrehovsky approved these changes May 2, 2024
View reviewed changes

sbomer reviewed May 2, 2024
View reviewed changes

jtschuster added 3 commits May 2, 2024 11:15

PR Feedback:
3ca9f9a
- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
830f23e
…ster/runtime into LinkerDependencyFramework

Add space before method call parentheses
3001124

sbomer approved these changes May 2, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 2, 2024
Test failure in System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101731
Closed

jtschuster added 2 commits May 3, 2024 13:12

Don't pass TargetOS and TargetArch to ILLink.Tasks when using live il…
f003f74
…link

Merge branch 'main' into LinkerDependencyFramework
a0f6861

sbomer reviewed May 3, 2024
View reviewed changes

Comment threadeng/liveILLink.targets Outdated

jtschuster added 4 commits May 3, 2024 14:56

Update comment in liveILLink.targets
d358b42

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
0fab4e3
…ster/runtime into LinkerDependencyFramework

Don't append platform to output dirs
5e124b5

Merge branch 'main' into LinkerDependencyFramework
855b109

jtschuster requested a review from agocke May 6, 2024 20:03

jtschuster merged commit fbb67a6 into dotnet:mainMay 6, 2024

This was referenced May 6, 2024
Failed to find compatible device: arm64-v8a dotnet/dnceng#2283
Closed
Cannot find 'arm64-v8a' device dotnet/dnceng#2284
Closed

github-actionsBot locked and limited conversation to collaborators Jun 6, 2024

vitek-karasand others added 5 commits September 13, 2023 11:19

MarkStep runs inside dependency framework
afe8990

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
4a92aaf
…ependencyFramework

Put MarkType into DependencyFramework
76fe923

Leave MarkType in MarkStep, use captured MarkStep to call it
b3ccd66

Format
eb5e333

jtschuster added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 19, 2024

ghost added the area-NativeAOT-coreclr label Apr 19, 2024

dotnet-policy-serviceBot assigned jtschuster Apr 19, 2024

vitek-karas reviewed Apr 19, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Linker.Steps/MarkStep.cs Outdated

vitek-karas reviewed Apr 19, 2024
View reviewed changes

jtschuster added 3 commits April 19, 2024 16:21

Use DF for TypeDefinition and MethodDefinition
e1270bb

Rename MarkTypeImpl to ProcessType and clean up code
2d12ade

Clean up code a bit more
1dc80db

MichalStrehovsky reviewed Apr 22, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Mono.Linker.csproj Outdated

jtschuster added 7 commits April 22, 2024 12:07

Use ProjectReference for DAF, and undo method moves
991f7a0

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
069f47b
…ependencyFramework

Don't have additional virtualmethods processing
c1670eb

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
8382e68
…ependencyFramework

Remove old header comment copied from MarkStep
5bf5ece

Remove nullable directives from ilc files
e6edbce

Sign DAF instead of nowarn on trimmer
10a5c57

jtschuster removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 22, 2024

jtschuster added 2 commits April 22, 2024 16:51

Re-add doc comment; Make types internal
166d2d5

Undo Queue changes, fix visibility issues
01f3a79

This was referenced Apr 23, 2024
[wasm] System.Text.Json.Tests running out of memory #98578
Closed
WASM test failing with OOM #100111
Closed

Merge branch 'ILLinkDescriptionDuplicatePreserve' into LinkerDependen…
8cbedd1
…cyFramework

This was referenced Apr 27, 2024
[wasm][firefox] crit: OpenQA.Selenium.WebDriverException: Failed to decode response from marionette #101617
Open
AbbreviatedMonthGenitiveNames_Get_ReturnsExpected_HybridGlobalization failing with string mismatch #101634
Closed

Merge branch 'main' into LinkerDependencyFramework
df7a522

This was referenced May 1, 2024
[wasm] WBT: Blazor tests on windows failing with Failed to bind to address for random ports #92910
Closed
System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanScalarDestination_SpecialValues fails #101721
Closed

Merge branch 'main' into LinkerDependencyFramework
28bf0be

MichalStrehovsky approved these changes May 2, 2024
View reviewed changes

sbomer reviewed May 2, 2024
View reviewed changes

jtschuster added 3 commits May 2, 2024 11:15

PR Feedback:
3ca9f9a
- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
830f23e
…ster/runtime into LinkerDependencyFramework

Add space before method call parentheses
3001124

sbomer approved these changes May 2, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 2, 2024
Test failure in System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101731
Closed

jtschuster added 2 commits May 3, 2024 13:12

Don't pass TargetOS and TargetArch to ILLink.Tasks when using live il…
f003f74
…link

Merge branch 'main' into LinkerDependencyFramework
a0f6861

sbomer reviewed May 3, 2024
View reviewed changes

Comment threadeng/liveILLink.targets Outdated

jtschuster added 4 commits May 3, 2024 14:56

Update comment in liveILLink.targets
d358b42

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
0fab4e3
…ster/runtime into LinkerDependencyFramework

Don't append platform to output dirs
5e124b5

Merge branch 'main' into LinkerDependencyFramework
855b109

jtschuster requested a review from agocke May 6, 2024 20:03

jtschuster merged commit fbb67a6 into dotnet:mainMay 6, 2024

This was referenced May 6, 2024
Failed to find compatible device: arm64-v8a dotnet/dnceng#2283
Closed
Cannot find 'arm64-v8a' device dotnet/dnceng#2284
Closed

github-actionsBot locked and limited conversation to collaborators Jun 6, 2024

vitek-karasand others added 5 commits September 13, 2023 11:19

MarkStep runs inside dependency framework
afe8990

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
4a92aaf
…ependencyFramework

Put MarkType into DependencyFramework
76fe923

Leave MarkType in MarkStep, use captured MarkStep to call it
b3ccd66

Format
eb5e333

jtschuster added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 19, 2024

ghost added the area-NativeAOT-coreclr label Apr 19, 2024

dotnet-policy-serviceBot assigned jtschuster Apr 19, 2024

vitek-karas reviewed Apr 19, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Linker.Steps/MarkStep.cs Outdated

vitek-karas reviewed Apr 19, 2024
View reviewed changes

jtschuster added 3 commits April 19, 2024 16:21

Use DF for TypeDefinition and MethodDefinition
e1270bb

Rename MarkTypeImpl to ProcessType and clean up code
2d12ade

Clean up code a bit more
1dc80db

MichalStrehovsky reviewed Apr 22, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Mono.Linker.csproj Outdated

jtschuster added 7 commits April 22, 2024 12:07

Use ProjectReference for DAF, and undo method moves
991f7a0

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
069f47b
…ependencyFramework

Don't have additional virtualmethods processing
c1670eb

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
8382e68
…ependencyFramework

Remove old header comment copied from MarkStep
5bf5ece

Remove nullable directives from ilc files
e6edbce

Sign DAF instead of nowarn on trimmer
10a5c57

jtschuster removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 22, 2024

jtschuster added 2 commits April 22, 2024 16:51

Re-add doc comment; Make types internal
166d2d5

Undo Queue changes, fix visibility issues
01f3a79

This was referenced Apr 23, 2024
[wasm] System.Text.Json.Tests running out of memory #98578
Closed
WASM test failing with OOM #100111
Closed

Merge branch 'ILLinkDescriptionDuplicatePreserve' into LinkerDependen…
8cbedd1
…cyFramework

This was referenced Apr 27, 2024
[wasm][firefox] crit: OpenQA.Selenium.WebDriverException: Failed to decode response from marionette #101617
Open
AbbreviatedMonthGenitiveNames_Get_ReturnsExpected_HybridGlobalization failing with string mismatch #101634
Closed

Merge branch 'main' into LinkerDependencyFramework
df7a522

This was referenced May 1, 2024
[wasm] WBT: Blazor tests on windows failing with Failed to bind to address for random ports #92910
Closed
System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanScalarDestination_SpecialValues fails #101721
Closed

Merge branch 'main' into LinkerDependencyFramework
28bf0be

MichalStrehovsky approved these changes May 2, 2024
View reviewed changes

sbomer reviewed May 2, 2024
View reviewed changes

jtschuster added 3 commits May 2, 2024 11:15

PR Feedback:
3ca9f9a
- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
830f23e
…ster/runtime into LinkerDependencyFramework

Add space before method call parentheses
3001124

sbomer approved these changes May 2, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 2, 2024
Test failure in System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101731
Closed

jtschuster added 2 commits May 3, 2024 13:12

Don't pass TargetOS and TargetArch to ILLink.Tasks when using live il…
f003f74
…link

Merge branch 'main' into LinkerDependencyFramework
a0f6861

sbomer reviewed May 3, 2024
View reviewed changes

Comment threadeng/liveILLink.targets Outdated

jtschuster added 4 commits May 3, 2024 14:56

Update comment in liveILLink.targets
d358b42

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
0fab4e3
…ster/runtime into LinkerDependencyFramework

Don't append platform to output dirs
5e124b5

Merge branch 'main' into LinkerDependencyFramework
855b109

jtschuster requested a review from agocke May 6, 2024 20:03

jtschuster merged commit fbb67a6 into dotnet:mainMay 6, 2024

This was referenced May 6, 2024
Failed to find compatible device: arm64-v8a dotnet/dnceng#2283
Closed
Cannot find 'arm64-v8a' device dotnet/dnceng#2284
Closed

github-actionsBot locked and limited conversation to collaborators Jun 6, 2024

vitek-karasand others added 5 commits September 13, 2023 11:19

MarkStep runs inside dependency framework
afe8990

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
4a92aaf
…ependencyFramework

Put MarkType into DependencyFramework
76fe923

Leave MarkType in MarkStep, use captured MarkStep to call it
b3ccd66

Format
eb5e333

jtschuster added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 19, 2024

ghost added the area-NativeAOT-coreclr label Apr 19, 2024

dotnet-policy-serviceBot assigned jtschuster Apr 19, 2024

vitek-karas reviewed Apr 19, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Linker.Steps/MarkStep.cs Outdated

vitek-karas reviewed Apr 19, 2024
View reviewed changes

jtschuster added 3 commits April 19, 2024 16:21

Use DF for TypeDefinition and MethodDefinition
e1270bb

Rename MarkTypeImpl to ProcessType and clean up code
2d12ade

Clean up code a bit more
1dc80db

MichalStrehovsky reviewed Apr 22, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Mono.Linker.csproj Outdated

jtschuster added 7 commits April 22, 2024 12:07

Use ProjectReference for DAF, and undo method moves
991f7a0

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
069f47b
…ependencyFramework

Don't have additional virtualmethods processing
c1670eb

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
8382e68
…ependencyFramework

Remove old header comment copied from MarkStep
5bf5ece

Remove nullable directives from ilc files
e6edbce

Sign DAF instead of nowarn on trimmer
10a5c57

jtschuster removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 22, 2024

jtschuster added 2 commits April 22, 2024 16:51

Re-add doc comment; Make types internal
166d2d5

Undo Queue changes, fix visibility issues
01f3a79

This was referenced Apr 23, 2024
[wasm] System.Text.Json.Tests running out of memory #98578
Closed
WASM test failing with OOM #100111
Closed

Merge branch 'ILLinkDescriptionDuplicatePreserve' into LinkerDependen…
8cbedd1
…cyFramework

This was referenced Apr 27, 2024
[wasm][firefox] crit: OpenQA.Selenium.WebDriverException: Failed to decode response from marionette #101617
Open
AbbreviatedMonthGenitiveNames_Get_ReturnsExpected_HybridGlobalization failing with string mismatch #101634
Closed

Merge branch 'main' into LinkerDependencyFramework
df7a522

This was referenced May 1, 2024
[wasm] WBT: Blazor tests on windows failing with Failed to bind to address for random ports #92910
Closed
System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanScalarDestination_SpecialValues fails #101721
Closed

Merge branch 'main' into LinkerDependencyFramework
28bf0be

MichalStrehovsky approved these changes May 2, 2024
View reviewed changes

sbomer reviewed May 2, 2024
View reviewed changes

jtschuster added 3 commits May 2, 2024 11:15

PR Feedback:
3ca9f9a
- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
830f23e
…ster/runtime into LinkerDependencyFramework

Add space before method call parentheses
3001124

sbomer approved these changes May 2, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 2, 2024
Test failure in System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101731
Closed

jtschuster added 2 commits May 3, 2024 13:12

Don't pass TargetOS and TargetArch to ILLink.Tasks when using live il…
f003f74
…link

Merge branch 'main' into LinkerDependencyFramework
a0f6861

sbomer reviewed May 3, 2024
View reviewed changes

Comment threadeng/liveILLink.targets Outdated

jtschuster added 4 commits May 3, 2024 14:56

Update comment in liveILLink.targets
d358b42

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
0fab4e3
…ster/runtime into LinkerDependencyFramework

Don't append platform to output dirs
5e124b5

Merge branch 'main' into LinkerDependencyFramework
855b109

jtschuster requested a review from agocke May 6, 2024 20:03

jtschuster merged commit fbb67a6 into dotnet:mainMay 6, 2024

This was referenced May 6, 2024
Failed to find compatible device: arm64-v8a dotnet/dnceng#2283
Closed
Cannot find 'arm64-v8a' device dotnet/dnceng#2284
Closed

github-actionsBot locked and limited conversation to collaborators Jun 6, 2024

vitek-karasand others added 5 commits September 13, 2023 11:19

MarkStep runs inside dependency framework
afe8990

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
4a92aaf
…ependencyFramework

Put MarkType into DependencyFramework
76fe923

Leave MarkType in MarkStep, use captured MarkStep to call it
b3ccd66

Format
eb5e333

jtschuster added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 19, 2024

ghost added the area-NativeAOT-coreclr label Apr 19, 2024

dotnet-policy-serviceBot assigned jtschuster Apr 19, 2024

vitek-karas reviewed Apr 19, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Linker.Steps/MarkStep.cs Outdated

vitek-karas reviewed Apr 19, 2024
View reviewed changes

jtschuster added 3 commits April 19, 2024 16:21

Use DF for TypeDefinition and MethodDefinition
e1270bb

Rename MarkTypeImpl to ProcessType and clean up code
2d12ade

Clean up code a bit more
1dc80db

MichalStrehovsky reviewed Apr 22, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Mono.Linker.csproj Outdated

jtschuster added 7 commits April 22, 2024 12:07

Use ProjectReference for DAF, and undo method moves
991f7a0

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
069f47b
…ependencyFramework

Don't have additional virtualmethods processing
c1670eb

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
8382e68
…ependencyFramework

Remove old header comment copied from MarkStep
5bf5ece

Remove nullable directives from ilc files
e6edbce

Sign DAF instead of nowarn on trimmer
10a5c57

jtschuster removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 22, 2024

jtschuster added 2 commits April 22, 2024 16:51

Re-add doc comment; Make types internal
166d2d5

Undo Queue changes, fix visibility issues
01f3a79

This was referenced Apr 23, 2024
[wasm] System.Text.Json.Tests running out of memory #98578
Closed
WASM test failing with OOM #100111
Closed

Merge branch 'ILLinkDescriptionDuplicatePreserve' into LinkerDependen…
8cbedd1
…cyFramework

This was referenced Apr 27, 2024
[wasm][firefox] crit: OpenQA.Selenium.WebDriverException: Failed to decode response from marionette #101617
Open
AbbreviatedMonthGenitiveNames_Get_ReturnsExpected_HybridGlobalization failing with string mismatch #101634
Closed

Merge branch 'main' into LinkerDependencyFramework
df7a522

This was referenced May 1, 2024
[wasm] WBT: Blazor tests on windows failing with Failed to bind to address for random ports #92910
Closed
System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanScalarDestination_SpecialValues fails #101721
Closed

Merge branch 'main' into LinkerDependencyFramework
28bf0be

MichalStrehovsky approved these changes May 2, 2024
View reviewed changes

sbomer reviewed May 2, 2024
View reviewed changes

jtschuster added 3 commits May 2, 2024 11:15

PR Feedback:
3ca9f9a
- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
830f23e
…ster/runtime into LinkerDependencyFramework

Add space before method call parentheses
3001124

sbomer approved these changes May 2, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 2, 2024
Test failure in System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101731
Closed

jtschuster added 2 commits May 3, 2024 13:12

Don't pass TargetOS and TargetArch to ILLink.Tasks when using live il…
f003f74
…link

Merge branch 'main' into LinkerDependencyFramework
a0f6861

sbomer reviewed May 3, 2024
View reviewed changes

Comment threadeng/liveILLink.targets Outdated

jtschuster added 4 commits May 3, 2024 14:56

Update comment in liveILLink.targets
d358b42

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
0fab4e3
…ster/runtime into LinkerDependencyFramework

Don't append platform to output dirs
5e124b5

Merge branch 'main' into LinkerDependencyFramework
855b109

jtschuster requested a review from agocke May 6, 2024 20:03

jtschuster merged commit fbb67a6 into dotnet:mainMay 6, 2024

This was referenced May 6, 2024
Failed to find compatible device: arm64-v8a dotnet/dnceng#2283
Closed
Cannot find 'arm64-v8a' device dotnet/dnceng#2284
Closed

github-actionsBot locked and limited conversation to collaborators Jun 6, 2024

vitek-karasand others added 5 commits September 13, 2023 11:19

MarkStep runs inside dependency framework
afe8990

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
4a92aaf
…ependencyFramework

Put MarkType into DependencyFramework
76fe923

Leave MarkType in MarkStep, use captured MarkStep to call it
b3ccd66

Format
eb5e333

jtschuster added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 19, 2024

ghost added the area-NativeAOT-coreclr label Apr 19, 2024

dotnet-policy-serviceBot assigned jtschuster Apr 19, 2024

vitek-karas reviewed Apr 19, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Linker.Steps/MarkStep.cs Outdated

vitek-karas reviewed Apr 19, 2024
View reviewed changes

jtschuster added 3 commits April 19, 2024 16:21

Use DF for TypeDefinition and MethodDefinition
e1270bb

Rename MarkTypeImpl to ProcessType and clean up code
2d12ade

Clean up code a bit more
1dc80db

MichalStrehovsky reviewed Apr 22, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Mono.Linker.csproj Outdated

jtschuster added 7 commits April 22, 2024 12:07

Use ProjectReference for DAF, and undo method moves
991f7a0

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
069f47b
…ependencyFramework

Don't have additional virtualmethods processing
c1670eb

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
8382e68
…ependencyFramework

Remove old header comment copied from MarkStep
5bf5ece

Remove nullable directives from ilc files
e6edbce

Sign DAF instead of nowarn on trimmer
10a5c57

jtschuster removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 22, 2024

jtschuster added 2 commits April 22, 2024 16:51

Re-add doc comment; Make types internal
166d2d5

Undo Queue changes, fix visibility issues
01f3a79

This was referenced Apr 23, 2024
[wasm] System.Text.Json.Tests running out of memory #98578
Closed
WASM test failing with OOM #100111
Closed

Merge branch 'ILLinkDescriptionDuplicatePreserve' into LinkerDependen…
8cbedd1
…cyFramework

This was referenced Apr 27, 2024
[wasm][firefox] crit: OpenQA.Selenium.WebDriverException: Failed to decode response from marionette #101617
Open
AbbreviatedMonthGenitiveNames_Get_ReturnsExpected_HybridGlobalization failing with string mismatch #101634
Closed

Merge branch 'main' into LinkerDependencyFramework
df7a522

This was referenced May 1, 2024
[wasm] WBT: Blazor tests on windows failing with Failed to bind to address for random ports #92910
Closed
System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanScalarDestination_SpecialValues fails #101721
Closed

Merge branch 'main' into LinkerDependencyFramework
28bf0be

MichalStrehovsky approved these changes May 2, 2024
View reviewed changes

sbomer reviewed May 2, 2024
View reviewed changes

jtschuster added 3 commits May 2, 2024 11:15

PR Feedback:
3ca9f9a
- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
830f23e
…ster/runtime into LinkerDependencyFramework

Add space before method call parentheses
3001124

sbomer approved these changes May 2, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 2, 2024
Test failure in System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101731
Closed

jtschuster added 2 commits May 3, 2024 13:12

Don't pass TargetOS and TargetArch to ILLink.Tasks when using live il…
f003f74
…link

Merge branch 'main' into LinkerDependencyFramework
a0f6861

sbomer reviewed May 3, 2024
View reviewed changes

Comment threadeng/liveILLink.targets Outdated

jtschuster added 4 commits May 3, 2024 14:56

Update comment in liveILLink.targets
d358b42

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
0fab4e3
…ster/runtime into LinkerDependencyFramework

Don't append platform to output dirs
5e124b5

Merge branch 'main' into LinkerDependencyFramework
855b109

jtschuster requested a review from agocke May 6, 2024 20:03

jtschuster merged commit fbb67a6 into dotnet:mainMay 6, 2024

This was referenced May 6, 2024
Failed to find compatible device: arm64-v8a dotnet/dnceng#2283
Closed
Cannot find 'arm64-v8a' device dotnet/dnceng#2284
Closed

github-actionsBot locked and limited conversation to collaborators Jun 6, 2024

vitek-karasand others added 5 commits September 13, 2023 11:19

MarkStep runs inside dependency framework
afe8990

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
4a92aaf
…ependencyFramework

Put MarkType into DependencyFramework
76fe923

Leave MarkType in MarkStep, use captured MarkStep to call it
b3ccd66

Format
eb5e333

jtschuster added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 19, 2024

ghost added the area-NativeAOT-coreclr label Apr 19, 2024

dotnet-policy-serviceBot assigned jtschuster Apr 19, 2024

vitek-karas reviewed Apr 19, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Linker.Steps/MarkStep.cs Outdated

vitek-karas reviewed Apr 19, 2024
View reviewed changes

jtschuster added 3 commits April 19, 2024 16:21

Use DF for TypeDefinition and MethodDefinition
e1270bb

Rename MarkTypeImpl to ProcessType and clean up code
2d12ade

Clean up code a bit more
1dc80db

MichalStrehovsky reviewed Apr 22, 2024
View reviewed changes

Comment threadsrc/tools/illink/src/linker/Mono.Linker.csproj Outdated

jtschuster added 7 commits April 22, 2024 12:07

Use ProjectReference for DAF, and undo method moves
991f7a0

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
069f47b
…ependencyFramework

Don't have additional virtualmethods processing
c1670eb

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto LinkerD…
8382e68
…ependencyFramework

Remove old header comment copied from MarkStep
5bf5ece

Remove nullable directives from ilc files
e6edbce

Sign DAF instead of nowarn on trimmer
10a5c57

jtschuster removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Apr 22, 2024

jtschuster added 2 commits April 22, 2024 16:51

Re-add doc comment; Make types internal
166d2d5

Undo Queue changes, fix visibility issues
01f3a79

This was referenced Apr 23, 2024
[wasm] System.Text.Json.Tests running out of memory #98578
Closed
WASM test failing with OOM #100111
Closed

Merge branch 'ILLinkDescriptionDuplicatePreserve' into LinkerDependen…
8cbedd1
…cyFramework

This was referenced Apr 27, 2024
[wasm][firefox] crit: OpenQA.Selenium.WebDriverException: Failed to decode response from marionette #101617
Open
AbbreviatedMonthGenitiveNames_Get_ReturnsExpected_HybridGlobalization failing with string mismatch #101634
Closed

Merge branch 'main' into LinkerDependencyFramework
df7a522

This was referenced May 1, 2024
[wasm] WBT: Blazor tests on windows failing with Failed to bind to address for random ports #92910
Closed
System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanScalarDestination_SpecialValues fails #101721
Closed

Merge branch 'main' into LinkerDependencyFramework
28bf0be

MichalStrehovsky approved these changes May 2, 2024
View reviewed changes

sbomer reviewed May 2, 2024
View reviewed changes

jtschuster added 3 commits May 2, 2024 11:15

PR Feedback:
3ca9f9a
- Rename dependency analyzer - Remove empty lines - Remove methods queue - Move static ctor marking

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
830f23e
…ster/runtime into LinkerDependencyFramework

Add space before method call parentheses
3001124

sbomer approved these changes May 2, 2024
View reviewed changes

build-analysisBot mentioned this pull request May 2, 2024
Test failure in System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101731
Closed

jtschuster added 2 commits May 3, 2024 13:12

Don't pass TargetOS and TargetArch to ILLink.Tasks when using live il…
f003f74
…link

Merge branch 'main' into LinkerDependencyFramework
a0f6861

sbomer reviewed May 3, 2024
View reviewed changes

Comment threadeng/liveILLink.targets Outdated

jtschuster added 4 commits May 3, 2024 14:56

Update comment in liveILLink.targets
d358b42

Merge branch 'LinkerDependencyFramework' ofhttps://github.com/jtschu…
0fab4e3
…ster/runtime into LinkerDependencyFramework

Don't append platform to output dirs
5e124b5

Merge branch 'main' into LinkerDependencyFramework
855b109

jtschuster requested a review from agocke May 6, 2024 20:03

jtschuster merged commit fbb67a6 into dotnet:mainMay 6, 2024

This was referenced May 6, 2024
Failed to find compatible device: arm64-v8a dotnet/dnceng#2283
Closed
Cannot find 'arm64-v8a' device dotnet/dnceng#2284
Closed

github-actionsBot locked and limited conversation to collaborators Jun 6, 2024

Uh oh!

Conversation

jtschuster commented Apr 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Apr 19, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbomer left a comment

Choose a reason for hiding this comment

Uh oh!

vitek-karas commented May 3, 2024

Uh oh!

jtschuster commented May 3, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

jtschuster commented Apr 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Apr 19, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbomer left a comment

Choose a reason for hiding this comment

Uh oh!

jtschuster commented Apr 19, 2024•
edited
Loading

jtschuster commented May 3, 2024•
edited
Loading

jtschuster commented Apr 19, 2024•
edited
Loading

jtschuster commented May 3, 2024•
edited
Loading

jtschuster commented Apr 19, 2024•
edited
Loading