Don't inline expand boxes with many GC pointers - #101669

Closed
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom
MichalStrehovsky:gcptrbox
Closed

Don't inline expand boxes with many GC pointers#101669
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom
MichalStrehovsky:gcptrbox

Conversation

@MichalStrehovsky

@MichalStrehovskyMichalStrehovsky commented Apr 29, 2024

Copy link
Copy Markdown
Member

No description provided.

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 29, 2024
@dotnet-policy-service

dotnet-policy-serviceBot commented Apr 29, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky

MichalStrehovsky commented Apr 29, 2024

Copy link
Copy Markdown
MemberAuthor

/benchmark plaintext,json,fortunes aspnet-citrine-win runtime,libs

@MichalStrehovskyMichalStrehovsky mentioned this pull request Apr 29, 2024
Merged
@pr-benchmarks

pr-benchmarksBot commented Apr 29, 2024

Copy link
Copy Markdown

Benchmark started for plaintext, json, fortunes on aspnet-citrine-win with runtime, libs. Logs: link

@pr-benchmarks

pr-benchmarksBot commented Apr 29, 2024

Copy link
Copy Markdown
plaintext - aspnet-citrine-win

applicationplaintext.baseplaintext.pr
Max CPU Usage (%)8070-12.50%
Max Cores usage (%)2,2331,961-12.18%
Max Working Set (MB)7271-1.39%
Max Private Memory (MB)94940.00%
Build Time (ms)8,2196,994-14.90%
Start Time (ms)358352-1.68%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadplaintext.baseplaintext.pr
Max CPU Usage (%)8382-1.20%
Max Cores usage (%)2,3282,305-0.99%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3703700.00%
Build Time (ms)6,4325,524-14.12%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)9089-1.11%
Requests/sec9,995,3539,944,556-0.51%
Requests150,903,360150,159,616-0.49%
Mean latency (ms)15.5817.14+10.01%
Max latency (ms)551.67442.85-19.73%
Bad responses00
Socket errors00
Read throughput (MB/s)1,198.081,198.080.00%
Latency 50th (ms)0.900.900.00%
Latency 75th (ms)8.778.99+2.51%
Latency 90th (ms)51.7756.33+8.81%
Latency 99th (ms)177.66214.30+20.62%

json - aspnet-citrine-win

applicationjson.basejson.pr
Max CPU Usage (%)7779+2.60%
Max Cores usage (%)2,1602,203+1.99%
Max Working Set (MB)6162+1.64%
Max Private Memory (MB)8384+1.20%
Build Time (ms)3,5633,604+1.15%
Start Time (ms)362353-2.49%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadjson.basejson.pr
Max CPU Usage (%)78780.00%
Max Cores usage (%)2,1852,176-0.41%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,2883,329+1.25%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)124119-4.03%
Requests/sec1,163,8361,148,431-1.32%
Requests17,573,83017,341,261-1.32%
Mean latency (ms)2.392.34-2.09%
Max latency (ms)104.85104.56-0.28%
Bad responses00
Socket errors00
Read throughput (MB/s)162.05159.90-1.33%
Latency 50th (ms)0.280.29+1.05%
Latency 75th (ms)0.981.02+4.08%
Latency 90th (ms)7.827.36-5.88%
Latency 99th (ms)27.1727.34+0.63%

fortunes - aspnet-citrine-win

dbfortunes.basefortunes.pr
Max CPU Usage (%)3132+3.23%
Max Cores usage (%)873886+1.49%
Max Working Set (MB)53530.00%
Build Time (ms)1,1941,185-0.75%
Start Time (ms)1,1941,198+0.34%
Published Size (KB)421,392421,3920.00%
applicationfortunes.basefortunes.pr
Max CPU Usage (%)8988-1.12%
Max Cores usage (%)2,5002,452-1.92%
Max Working Set (MB)530561+5.85%
Max Private Memory (MB)540589+9.07%
Build Time (ms)3,7033,837+3.62%
Start Time (ms)2,2442,136-4.81%
Published Size (KB)105,755105,7550.00%
Symbols Size (KB)55550.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadfortunes.basefortunes.pr
Max CPU Usage (%)3938-2.56%
Max Cores usage (%)1,0811,069-1.11%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,3973,423+0.77%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)106105-0.94%
Requests/sec439,111436,789-0.53%
Requests6,630,6726,595,331-0.53%
Mean latency (ms)1.511.49-1.32%
Max latency (ms)40.6524.59-39.51%
Bad responses00
Socket errors00
Read throughput (MB/s)577.48574.43-0.53%
Latency 50th (ms)1.061.07+0.94%
Latency 75th (ms)1.321.320.00%
Latency 90th (ms)1.931.92-0.52%
Latency 99th (ms)11.5711.78+1.82%

@github-actionsgithub-actionsBot mentioned this pull request Apr 29, 2024
Closed
EgorBo
EgorBo reviewed Apr 29, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/importer.cpp
// After a certain number of GC pointers, the write barriers used
// in inline expansion stop being profitable.
ClassLayout* layout = typGetObjLayout(pResolvedToken->hClass);
if (layout->GetGCPtrCount() > 3)

@EgorBoEgorBoApr 29, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this might need more work, e.g. when we box a struct with 4 fields but all of them are null or e.g. nongc strings - this will be a regression. Also, I suspect this might ruin some "optimize boxing" optimizations.

I think we need to either fix all those places to deal with a helper call or we need to emit a bulk copy in codegen, just like I did in #99096 (but to do it for batched-copy, not batched-precise-barrier).

@jkotas

jkotas commented Apr 29, 2024

Copy link
Copy Markdown
Member

We have optimized JIT_Box helper variants only on Windows:

runtime/src/coreclr/vm/jitinterfacegen.cpp

Lines 75 to 88 in f88ab88

#ifdef TARGET_UNIX
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_NewS_MP_FastPortable);
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_NewS_MP_FastPortable);
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_VC, JIT_NewArr1VC_MP_FastPortable);
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_OBJ, JIT_NewArr1OBJ_MP_FastPortable);
ECall::DynamicallyAssignFCallImpl(GetEEFuncEntryPoint(AllocateString_MP_FastPortable), ECall::FastAllocateString);
#else// TARGET_UNIX
// if (multi-proc || server GC)
if (GCHeapUtilities::UseThreadAllocationContexts())
{
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_TrialAllocSFastMP_InlineGetThread);
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_TrialAllocSFastMP_InlineGetThread);
SetJitHelperFunction(CORINFO_HELP_BOX, JIT_BoxFastMP_InlineGetThread);
. We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.

@MichalStrehovskyMichalStrehovsky mentioned this pull request Apr 29, 2024
Closed
@MichalStrehovsky

MichalStrehovsky commented Apr 29, 2024

Copy link
Copy Markdown
MemberAuthor

We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.

For ContainsPointers the optimized assembly helper needs to thunk out to C++ anyway so the optimization might not amount to much for the relevant cases. I'll add this to the issue. Not actually planning to work on this based on Egor's comments.

@MichalStrehovsky
MichalStrehovsky deleted the gcptrbox branch April 29, 2024 21:55
@EgorBo

EgorBo commented Apr 29, 2024

Copy link
Copy Markdown
Member

Not actually planning to work on this based on Egor's comments.

I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper (where you'll just do memcpyGC) and call it in genCodeForCpObj (so the actuall allocation for the box will be handled efficiently via the NEWS helper as is).

@MichalStrehovsky

MichalStrehovsky commented Apr 29, 2024

Copy link
Copy Markdown
MemberAuthor

I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper

If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.

@EgorBo

EgorBo commented Apr 29, 2024

Copy link
Copy Markdown
Member

I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper

If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.

Yep, that's what I meant, the helper is completely unused/unimplemented, so at least we won't have to bump R2R format 🙂

@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 31, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo left review comments
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@jkotas@EgorBo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Don't inline expand boxes with many GC pointers - #101669
Closed
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Closed
Don't inline expand boxes with many GC pointers#101669
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 29, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
/benchmark plaintext,json,fortunes aspnet-citrine-win runtime,libs
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024
 Merged

@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Benchmark started for plaintext, json, fortunes on aspnet-citrine-win with runtime, libs. Logs: link
@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

plaintext - aspnet-citrine-win
applicationplaintext.baseplaintext.pr
Max CPU Usage (%)8070-12.50%
Max Cores usage (%)2,2331,961-12.18%
Max Working Set (MB)7271-1.39%
Max Private Memory (MB)94940.00%
Build Time (ms)8,2196,994-14.90%
Start Time (ms)358352-1.68%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadplaintext.baseplaintext.pr
Max CPU Usage (%)8382-1.20%
Max Cores usage (%)2,3282,305-0.99%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3703700.00%
Build Time (ms)6,4325,524-14.12%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)9089-1.11%
Requests/sec9,995,3539,944,556-0.51%
Requests150,903,360150,159,616-0.49%
Mean latency (ms)15.5817.14+10.01%
Max latency (ms)551.67442.85-19.73%
Bad responses00
Socket errors00
Read throughput (MB/s)1,198.081,198.080.00%
Latency 50th (ms)0.900.900.00%
Latency 75th (ms)8.778.99+2.51%
Latency 90th (ms)51.7756.33+8.81%
Latency 99th (ms)177.66214.30+20.62%
json - aspnet-citrine-win
applicationjson.basejson.pr
Max CPU Usage (%)7779+2.60%
Max Cores usage (%)2,1602,203+1.99%
Max Working Set (MB)6162+1.64%
Max Private Memory (MB)8384+1.20%
Build Time (ms)3,5633,604+1.15%
Start Time (ms)362353-2.49%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadjson.basejson.pr
Max CPU Usage (%)78780.00%
Max Cores usage (%)2,1852,176-0.41%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,2883,329+1.25%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)124119-4.03%
Requests/sec1,163,8361,148,431-1.32%
Requests17,573,83017,341,261-1.32%
Mean latency (ms)2.392.34-2.09%
Max latency (ms)104.85104.56-0.28%
Bad responses00
Socket errors00
Read throughput (MB/s)162.05159.90-1.33%
Latency 50th (ms)0.280.29+1.05%
Latency 75th (ms)0.981.02+4.08%
Latency 90th (ms)7.827.36-5.88%
Latency 99th (ms)27.1727.34+0.63%
fortunes - aspnet-citrine-win
dbfortunes.basefortunes.pr
Max CPU Usage (%)3132+3.23%
Max Cores usage (%)873886+1.49%
Max Working Set (MB)53530.00%
Build Time (ms)1,1941,185-0.75%
Start Time (ms)1,1941,198+0.34%
Published Size (KB)421,392421,3920.00%
applicationfortunes.basefortunes.pr
Max CPU Usage (%)8988-1.12%
Max Cores usage (%)2,5002,452-1.92%
Max Working Set (MB)530561+5.85%
Max Private Memory (MB)540589+9.07%
Build Time (ms)3,7033,837+3.62%
Start Time (ms)2,2442,136-4.81%
Published Size (KB)105,755105,7550.00%
Symbols Size (KB)55550.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadfortunes.basefortunes.pr
Max CPU Usage (%)3938-2.56%
Max Cores usage (%)1,0811,069-1.11%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,3973,423+0.77%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)106105-0.94%
Requests/sec439,111436,789-0.53%
Requests6,630,6726,595,331-0.53%
Mean latency (ms)1.511.49-1.32%
Max latency (ms)40.6524.59-39.51%
Bad responses00
Socket errors00
Read throughput (MB/s)577.48574.43-0.53%
Latency 50th (ms)1.061.07+0.94%
Latency 75th (ms)1.321.320.00%
Latency 90th (ms)1.931.92-0.52%
Latency 99th (ms)11.5711.78+1.82%
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 29, 2024

Closed

EgorBo
EgorBo
reviewed
Apr 29, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/importer.cpp
 // After a certain number of GC pointers, the write barriers used
 // in inline expansion stop being profitable.
 ClassLayout* layout = typGetObjLayout(pResolvedToken->hClass);
 if (layout->GetGCPtrCount() > 3)
@EgorBoEgorBoApr 29, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this might need more work, e.g. when we box a struct with 4 fields but all of them are null or e.g. nongc strings - this will be a regression. Also, I suspect this might ruin some "optimize boxing" optimizations.
I think we need to either fix all those places to deal with a helper call or we need to emit a bulk copy in codegen, just like I did in #99096 (but to do it for batched-copy, not batched-precise-barrier).
@jkotas
jkotas
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
We have optimized JIT_Box helper variants only on Windows: 
runtime/src/coreclr/vm/jitinterfacegen.cpp

Lines 75 to 88
in
f88ab88
 #ifdef TARGET_UNIX 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_VC, JIT_NewArr1VC_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_OBJ, JIT_NewArr1OBJ_MP_FastPortable); 
ECall::DynamicallyAssignFCallImpl(GetEEFuncEntryPoint(AllocateString_MP_FastPortable), ECall::FastAllocateString); 
 #else// TARGET_UNIX
// if (multi-proc || server GC)
if (GCHeapUtilities::UseThreadAllocationContexts()) 
 { 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_BOX, JIT_BoxFastMP_InlineGetThread); 

. We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024

Closed

@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
For ContainsPointers the optimized assembly helper needs to thunk out to C++ anyway so the optimization might not amount to much for the relevant cases. I'll add this to the issue. Not actually planning to work on this based on Egor's comments.
@MichalStrehovsky
MichalStrehovsky
deleted the

gcptrbox

branch
April 29, 2024 21:55
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
Not actually planning to work on this based on Egor's comments.
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper (where you'll just do memcpyGC) and call it in genCodeForCpObj (so the actuall allocation for the box will be handled efficiently via the NEWS helper as is).
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
Yep, that's what I meant, the helper is completely unused/unimplemented, so at least we won't have to bump R2R format 🙂
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo left review comments
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@jkotas@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Don't inline expand boxes with many GC pointers - #101669
Closed
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Closed
Don't inline expand boxes with many GC pointers#101669
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 29, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
/benchmark plaintext,json,fortunes aspnet-citrine-win runtime,libs
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024
 Merged

@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Benchmark started for plaintext, json, fortunes on aspnet-citrine-win with runtime, libs. Logs: link
@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

plaintext - aspnet-citrine-win
applicationplaintext.baseplaintext.pr
Max CPU Usage (%)8070-12.50%
Max Cores usage (%)2,2331,961-12.18%
Max Working Set (MB)7271-1.39%
Max Private Memory (MB)94940.00%
Build Time (ms)8,2196,994-14.90%
Start Time (ms)358352-1.68%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadplaintext.baseplaintext.pr
Max CPU Usage (%)8382-1.20%
Max Cores usage (%)2,3282,305-0.99%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3703700.00%
Build Time (ms)6,4325,524-14.12%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)9089-1.11%
Requests/sec9,995,3539,944,556-0.51%
Requests150,903,360150,159,616-0.49%
Mean latency (ms)15.5817.14+10.01%
Max latency (ms)551.67442.85-19.73%
Bad responses00
Socket errors00
Read throughput (MB/s)1,198.081,198.080.00%
Latency 50th (ms)0.900.900.00%
Latency 75th (ms)8.778.99+2.51%
Latency 90th (ms)51.7756.33+8.81%
Latency 99th (ms)177.66214.30+20.62%
json - aspnet-citrine-win
applicationjson.basejson.pr
Max CPU Usage (%)7779+2.60%
Max Cores usage (%)2,1602,203+1.99%
Max Working Set (MB)6162+1.64%
Max Private Memory (MB)8384+1.20%
Build Time (ms)3,5633,604+1.15%
Start Time (ms)362353-2.49%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadjson.basejson.pr
Max CPU Usage (%)78780.00%
Max Cores usage (%)2,1852,176-0.41%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,2883,329+1.25%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)124119-4.03%
Requests/sec1,163,8361,148,431-1.32%
Requests17,573,83017,341,261-1.32%
Mean latency (ms)2.392.34-2.09%
Max latency (ms)104.85104.56-0.28%
Bad responses00
Socket errors00
Read throughput (MB/s)162.05159.90-1.33%
Latency 50th (ms)0.280.29+1.05%
Latency 75th (ms)0.981.02+4.08%
Latency 90th (ms)7.827.36-5.88%
Latency 99th (ms)27.1727.34+0.63%
fortunes - aspnet-citrine-win
dbfortunes.basefortunes.pr
Max CPU Usage (%)3132+3.23%
Max Cores usage (%)873886+1.49%
Max Working Set (MB)53530.00%
Build Time (ms)1,1941,185-0.75%
Start Time (ms)1,1941,198+0.34%
Published Size (KB)421,392421,3920.00%
applicationfortunes.basefortunes.pr
Max CPU Usage (%)8988-1.12%
Max Cores usage (%)2,5002,452-1.92%
Max Working Set (MB)530561+5.85%
Max Private Memory (MB)540589+9.07%
Build Time (ms)3,7033,837+3.62%
Start Time (ms)2,2442,136-4.81%
Published Size (KB)105,755105,7550.00%
Symbols Size (KB)55550.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadfortunes.basefortunes.pr
Max CPU Usage (%)3938-2.56%
Max Cores usage (%)1,0811,069-1.11%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,3973,423+0.77%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)106105-0.94%
Requests/sec439,111436,789-0.53%
Requests6,630,6726,595,331-0.53%
Mean latency (ms)1.511.49-1.32%
Max latency (ms)40.6524.59-39.51%
Bad responses00
Socket errors00
Read throughput (MB/s)577.48574.43-0.53%
Latency 50th (ms)1.061.07+0.94%
Latency 75th (ms)1.321.320.00%
Latency 90th (ms)1.931.92-0.52%
Latency 99th (ms)11.5711.78+1.82%
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 29, 2024

Closed

EgorBo
EgorBo
reviewed
Apr 29, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/importer.cpp
 // After a certain number of GC pointers, the write barriers used
 // in inline expansion stop being profitable.
 ClassLayout* layout = typGetObjLayout(pResolvedToken->hClass);
 if (layout->GetGCPtrCount() > 3)
@EgorBoEgorBoApr 29, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this might need more work, e.g. when we box a struct with 4 fields but all of them are null or e.g. nongc strings - this will be a regression. Also, I suspect this might ruin some "optimize boxing" optimizations.
I think we need to either fix all those places to deal with a helper call or we need to emit a bulk copy in codegen, just like I did in #99096 (but to do it for batched-copy, not batched-precise-barrier).
@jkotas
jkotas
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
We have optimized JIT_Box helper variants only on Windows: 
runtime/src/coreclr/vm/jitinterfacegen.cpp

Lines 75 to 88
in
f88ab88
 #ifdef TARGET_UNIX 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_VC, JIT_NewArr1VC_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_OBJ, JIT_NewArr1OBJ_MP_FastPortable); 
ECall::DynamicallyAssignFCallImpl(GetEEFuncEntryPoint(AllocateString_MP_FastPortable), ECall::FastAllocateString); 
 #else// TARGET_UNIX
// if (multi-proc || server GC)
if (GCHeapUtilities::UseThreadAllocationContexts()) 
 { 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_BOX, JIT_BoxFastMP_InlineGetThread); 

. We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024

Closed

@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
For ContainsPointers the optimized assembly helper needs to thunk out to C++ anyway so the optimization might not amount to much for the relevant cases. I'll add this to the issue. Not actually planning to work on this based on Egor's comments.
@MichalStrehovsky
MichalStrehovsky
deleted the

gcptrbox

branch
April 29, 2024 21:55
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
Not actually planning to work on this based on Egor's comments.
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper (where you'll just do memcpyGC) and call it in genCodeForCpObj (so the actuall allocation for the box will be handled efficiently via the NEWS helper as is).
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
Yep, that's what I meant, the helper is completely unused/unimplemented, so at least we won't have to bump R2R format 🙂
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo left review comments
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@jkotas@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Don't inline expand boxes with many GC pointers - #101669
Closed
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Closed
Don't inline expand boxes with many GC pointers#101669
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 29, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
/benchmark plaintext,json,fortunes aspnet-citrine-win runtime,libs
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024
 Merged

@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Benchmark started for plaintext, json, fortunes on aspnet-citrine-win with runtime, libs. Logs: link
@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

plaintext - aspnet-citrine-win
applicationplaintext.baseplaintext.pr
Max CPU Usage (%)8070-12.50%
Max Cores usage (%)2,2331,961-12.18%
Max Working Set (MB)7271-1.39%
Max Private Memory (MB)94940.00%
Build Time (ms)8,2196,994-14.90%
Start Time (ms)358352-1.68%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadplaintext.baseplaintext.pr
Max CPU Usage (%)8382-1.20%
Max Cores usage (%)2,3282,305-0.99%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3703700.00%
Build Time (ms)6,4325,524-14.12%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)9089-1.11%
Requests/sec9,995,3539,944,556-0.51%
Requests150,903,360150,159,616-0.49%
Mean latency (ms)15.5817.14+10.01%
Max latency (ms)551.67442.85-19.73%
Bad responses00
Socket errors00
Read throughput (MB/s)1,198.081,198.080.00%
Latency 50th (ms)0.900.900.00%
Latency 75th (ms)8.778.99+2.51%
Latency 90th (ms)51.7756.33+8.81%
Latency 99th (ms)177.66214.30+20.62%
json - aspnet-citrine-win
applicationjson.basejson.pr
Max CPU Usage (%)7779+2.60%
Max Cores usage (%)2,1602,203+1.99%
Max Working Set (MB)6162+1.64%
Max Private Memory (MB)8384+1.20%
Build Time (ms)3,5633,604+1.15%
Start Time (ms)362353-2.49%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadjson.basejson.pr
Max CPU Usage (%)78780.00%
Max Cores usage (%)2,1852,176-0.41%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,2883,329+1.25%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)124119-4.03%
Requests/sec1,163,8361,148,431-1.32%
Requests17,573,83017,341,261-1.32%
Mean latency (ms)2.392.34-2.09%
Max latency (ms)104.85104.56-0.28%
Bad responses00
Socket errors00
Read throughput (MB/s)162.05159.90-1.33%
Latency 50th (ms)0.280.29+1.05%
Latency 75th (ms)0.981.02+4.08%
Latency 90th (ms)7.827.36-5.88%
Latency 99th (ms)27.1727.34+0.63%
fortunes - aspnet-citrine-win
dbfortunes.basefortunes.pr
Max CPU Usage (%)3132+3.23%
Max Cores usage (%)873886+1.49%
Max Working Set (MB)53530.00%
Build Time (ms)1,1941,185-0.75%
Start Time (ms)1,1941,198+0.34%
Published Size (KB)421,392421,3920.00%
applicationfortunes.basefortunes.pr
Max CPU Usage (%)8988-1.12%
Max Cores usage (%)2,5002,452-1.92%
Max Working Set (MB)530561+5.85%
Max Private Memory (MB)540589+9.07%
Build Time (ms)3,7033,837+3.62%
Start Time (ms)2,2442,136-4.81%
Published Size (KB)105,755105,7550.00%
Symbols Size (KB)55550.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadfortunes.basefortunes.pr
Max CPU Usage (%)3938-2.56%
Max Cores usage (%)1,0811,069-1.11%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,3973,423+0.77%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)106105-0.94%
Requests/sec439,111436,789-0.53%
Requests6,630,6726,595,331-0.53%
Mean latency (ms)1.511.49-1.32%
Max latency (ms)40.6524.59-39.51%
Bad responses00
Socket errors00
Read throughput (MB/s)577.48574.43-0.53%
Latency 50th (ms)1.061.07+0.94%
Latency 75th (ms)1.321.320.00%
Latency 90th (ms)1.931.92-0.52%
Latency 99th (ms)11.5711.78+1.82%
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 29, 2024

Closed

EgorBo
EgorBo
reviewed
Apr 29, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/importer.cpp
 // After a certain number of GC pointers, the write barriers used
 // in inline expansion stop being profitable.
 ClassLayout* layout = typGetObjLayout(pResolvedToken->hClass);
 if (layout->GetGCPtrCount() > 3)
@EgorBoEgorBoApr 29, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this might need more work, e.g. when we box a struct with 4 fields but all of them are null or e.g. nongc strings - this will be a regression. Also, I suspect this might ruin some "optimize boxing" optimizations.
I think we need to either fix all those places to deal with a helper call or we need to emit a bulk copy in codegen, just like I did in #99096 (but to do it for batched-copy, not batched-precise-barrier).
@jkotas
jkotas
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
We have optimized JIT_Box helper variants only on Windows: 
runtime/src/coreclr/vm/jitinterfacegen.cpp

Lines 75 to 88
in
f88ab88
 #ifdef TARGET_UNIX 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_VC, JIT_NewArr1VC_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_OBJ, JIT_NewArr1OBJ_MP_FastPortable); 
ECall::DynamicallyAssignFCallImpl(GetEEFuncEntryPoint(AllocateString_MP_FastPortable), ECall::FastAllocateString); 
 #else// TARGET_UNIX
// if (multi-proc || server GC)
if (GCHeapUtilities::UseThreadAllocationContexts()) 
 { 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_BOX, JIT_BoxFastMP_InlineGetThread); 

. We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024

Closed

@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
For ContainsPointers the optimized assembly helper needs to thunk out to C++ anyway so the optimization might not amount to much for the relevant cases. I'll add this to the issue. Not actually planning to work on this based on Egor's comments.
@MichalStrehovsky
MichalStrehovsky
deleted the

gcptrbox

branch
April 29, 2024 21:55
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
Not actually planning to work on this based on Egor's comments.
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper (where you'll just do memcpyGC) and call it in genCodeForCpObj (so the actuall allocation for the box will be handled efficiently via the NEWS helper as is).
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
Yep, that's what I meant, the helper is completely unused/unimplemented, so at least we won't have to bump R2R format 🙂
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo left review comments
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@jkotas@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Don't inline expand boxes with many GC pointers - #101669
Closed
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Closed
Don't inline expand boxes with many GC pointers#101669
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 29, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
/benchmark plaintext,json,fortunes aspnet-citrine-win runtime,libs
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024
 Merged

@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Benchmark started for plaintext, json, fortunes on aspnet-citrine-win with runtime, libs. Logs: link
@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

plaintext - aspnet-citrine-win
applicationplaintext.baseplaintext.pr
Max CPU Usage (%)8070-12.50%
Max Cores usage (%)2,2331,961-12.18%
Max Working Set (MB)7271-1.39%
Max Private Memory (MB)94940.00%
Build Time (ms)8,2196,994-14.90%
Start Time (ms)358352-1.68%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadplaintext.baseplaintext.pr
Max CPU Usage (%)8382-1.20%
Max Cores usage (%)2,3282,305-0.99%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3703700.00%
Build Time (ms)6,4325,524-14.12%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)9089-1.11%
Requests/sec9,995,3539,944,556-0.51%
Requests150,903,360150,159,616-0.49%
Mean latency (ms)15.5817.14+10.01%
Max latency (ms)551.67442.85-19.73%
Bad responses00
Socket errors00
Read throughput (MB/s)1,198.081,198.080.00%
Latency 50th (ms)0.900.900.00%
Latency 75th (ms)8.778.99+2.51%
Latency 90th (ms)51.7756.33+8.81%
Latency 99th (ms)177.66214.30+20.62%
json - aspnet-citrine-win
applicationjson.basejson.pr
Max CPU Usage (%)7779+2.60%
Max Cores usage (%)2,1602,203+1.99%
Max Working Set (MB)6162+1.64%
Max Private Memory (MB)8384+1.20%
Build Time (ms)3,5633,604+1.15%
Start Time (ms)362353-2.49%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadjson.basejson.pr
Max CPU Usage (%)78780.00%
Max Cores usage (%)2,1852,176-0.41%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,2883,329+1.25%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)124119-4.03%
Requests/sec1,163,8361,148,431-1.32%
Requests17,573,83017,341,261-1.32%
Mean latency (ms)2.392.34-2.09%
Max latency (ms)104.85104.56-0.28%
Bad responses00
Socket errors00
Read throughput (MB/s)162.05159.90-1.33%
Latency 50th (ms)0.280.29+1.05%
Latency 75th (ms)0.981.02+4.08%
Latency 90th (ms)7.827.36-5.88%
Latency 99th (ms)27.1727.34+0.63%
fortunes - aspnet-citrine-win
dbfortunes.basefortunes.pr
Max CPU Usage (%)3132+3.23%
Max Cores usage (%)873886+1.49%
Max Working Set (MB)53530.00%
Build Time (ms)1,1941,185-0.75%
Start Time (ms)1,1941,198+0.34%
Published Size (KB)421,392421,3920.00%
applicationfortunes.basefortunes.pr
Max CPU Usage (%)8988-1.12%
Max Cores usage (%)2,5002,452-1.92%
Max Working Set (MB)530561+5.85%
Max Private Memory (MB)540589+9.07%
Build Time (ms)3,7033,837+3.62%
Start Time (ms)2,2442,136-4.81%
Published Size (KB)105,755105,7550.00%
Symbols Size (KB)55550.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadfortunes.basefortunes.pr
Max CPU Usage (%)3938-2.56%
Max Cores usage (%)1,0811,069-1.11%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,3973,423+0.77%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)106105-0.94%
Requests/sec439,111436,789-0.53%
Requests6,630,6726,595,331-0.53%
Mean latency (ms)1.511.49-1.32%
Max latency (ms)40.6524.59-39.51%
Bad responses00
Socket errors00
Read throughput (MB/s)577.48574.43-0.53%
Latency 50th (ms)1.061.07+0.94%
Latency 75th (ms)1.321.320.00%
Latency 90th (ms)1.931.92-0.52%
Latency 99th (ms)11.5711.78+1.82%
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 29, 2024

Closed

EgorBo
EgorBo
reviewed
Apr 29, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/importer.cpp
 // After a certain number of GC pointers, the write barriers used
 // in inline expansion stop being profitable.
 ClassLayout* layout = typGetObjLayout(pResolvedToken->hClass);
 if (layout->GetGCPtrCount() > 3)
@EgorBoEgorBoApr 29, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this might need more work, e.g. when we box a struct with 4 fields but all of them are null or e.g. nongc strings - this will be a regression. Also, I suspect this might ruin some "optimize boxing" optimizations.
I think we need to either fix all those places to deal with a helper call or we need to emit a bulk copy in codegen, just like I did in #99096 (but to do it for batched-copy, not batched-precise-barrier).
@jkotas
jkotas
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
We have optimized JIT_Box helper variants only on Windows: 
runtime/src/coreclr/vm/jitinterfacegen.cpp

Lines 75 to 88
in
f88ab88
 #ifdef TARGET_UNIX 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_VC, JIT_NewArr1VC_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_OBJ, JIT_NewArr1OBJ_MP_FastPortable); 
ECall::DynamicallyAssignFCallImpl(GetEEFuncEntryPoint(AllocateString_MP_FastPortable), ECall::FastAllocateString); 
 #else// TARGET_UNIX
// if (multi-proc || server GC)
if (GCHeapUtilities::UseThreadAllocationContexts()) 
 { 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_BOX, JIT_BoxFastMP_InlineGetThread); 

. We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024

Closed

@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
For ContainsPointers the optimized assembly helper needs to thunk out to C++ anyway so the optimization might not amount to much for the relevant cases. I'll add this to the issue. Not actually planning to work on this based on Egor's comments.
@MichalStrehovsky
MichalStrehovsky
deleted the

gcptrbox

branch
April 29, 2024 21:55
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
Not actually planning to work on this based on Egor's comments.
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper (where you'll just do memcpyGC) and call it in genCodeForCpObj (so the actuall allocation for the box will be handled efficiently via the NEWS helper as is).
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
Yep, that's what I meant, the helper is completely unused/unimplemented, so at least we won't have to bump R2R format 🙂
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo left review comments
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@jkotas@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Don't inline expand boxes with many GC pointers - #101669
Closed
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Closed
Don't inline expand boxes with many GC pointers#101669
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 29, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
/benchmark plaintext,json,fortunes aspnet-citrine-win runtime,libs
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024
 Merged

@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Benchmark started for plaintext, json, fortunes on aspnet-citrine-win with runtime, libs. Logs: link
@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

plaintext - aspnet-citrine-win
applicationplaintext.baseplaintext.pr
Max CPU Usage (%)8070-12.50%
Max Cores usage (%)2,2331,961-12.18%
Max Working Set (MB)7271-1.39%
Max Private Memory (MB)94940.00%
Build Time (ms)8,2196,994-14.90%
Start Time (ms)358352-1.68%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadplaintext.baseplaintext.pr
Max CPU Usage (%)8382-1.20%
Max Cores usage (%)2,3282,305-0.99%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3703700.00%
Build Time (ms)6,4325,524-14.12%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)9089-1.11%
Requests/sec9,995,3539,944,556-0.51%
Requests150,903,360150,159,616-0.49%
Mean latency (ms)15.5817.14+10.01%
Max latency (ms)551.67442.85-19.73%
Bad responses00
Socket errors00
Read throughput (MB/s)1,198.081,198.080.00%
Latency 50th (ms)0.900.900.00%
Latency 75th (ms)8.778.99+2.51%
Latency 90th (ms)51.7756.33+8.81%
Latency 99th (ms)177.66214.30+20.62%
json - aspnet-citrine-win
applicationjson.basejson.pr
Max CPU Usage (%)7779+2.60%
Max Cores usage (%)2,1602,203+1.99%
Max Working Set (MB)6162+1.64%
Max Private Memory (MB)8384+1.20%
Build Time (ms)3,5633,604+1.15%
Start Time (ms)362353-2.49%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadjson.basejson.pr
Max CPU Usage (%)78780.00%
Max Cores usage (%)2,1852,176-0.41%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,2883,329+1.25%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)124119-4.03%
Requests/sec1,163,8361,148,431-1.32%
Requests17,573,83017,341,261-1.32%
Mean latency (ms)2.392.34-2.09%
Max latency (ms)104.85104.56-0.28%
Bad responses00
Socket errors00
Read throughput (MB/s)162.05159.90-1.33%
Latency 50th (ms)0.280.29+1.05%
Latency 75th (ms)0.981.02+4.08%
Latency 90th (ms)7.827.36-5.88%
Latency 99th (ms)27.1727.34+0.63%
fortunes - aspnet-citrine-win
dbfortunes.basefortunes.pr
Max CPU Usage (%)3132+3.23%
Max Cores usage (%)873886+1.49%
Max Working Set (MB)53530.00%
Build Time (ms)1,1941,185-0.75%
Start Time (ms)1,1941,198+0.34%
Published Size (KB)421,392421,3920.00%
applicationfortunes.basefortunes.pr
Max CPU Usage (%)8988-1.12%
Max Cores usage (%)2,5002,452-1.92%
Max Working Set (MB)530561+5.85%
Max Private Memory (MB)540589+9.07%
Build Time (ms)3,7033,837+3.62%
Start Time (ms)2,2442,136-4.81%
Published Size (KB)105,755105,7550.00%
Symbols Size (KB)55550.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadfortunes.basefortunes.pr
Max CPU Usage (%)3938-2.56%
Max Cores usage (%)1,0811,069-1.11%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,3973,423+0.77%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)106105-0.94%
Requests/sec439,111436,789-0.53%
Requests6,630,6726,595,331-0.53%
Mean latency (ms)1.511.49-1.32%
Max latency (ms)40.6524.59-39.51%
Bad responses00
Socket errors00
Read throughput (MB/s)577.48574.43-0.53%
Latency 50th (ms)1.061.07+0.94%
Latency 75th (ms)1.321.320.00%
Latency 90th (ms)1.931.92-0.52%
Latency 99th (ms)11.5711.78+1.82%
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 29, 2024

Closed

EgorBo
EgorBo
reviewed
Apr 29, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/importer.cpp
 // After a certain number of GC pointers, the write barriers used
 // in inline expansion stop being profitable.
 ClassLayout* layout = typGetObjLayout(pResolvedToken->hClass);
 if (layout->GetGCPtrCount() > 3)
@EgorBoEgorBoApr 29, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this might need more work, e.g. when we box a struct with 4 fields but all of them are null or e.g. nongc strings - this will be a regression. Also, I suspect this might ruin some "optimize boxing" optimizations.
I think we need to either fix all those places to deal with a helper call or we need to emit a bulk copy in codegen, just like I did in #99096 (but to do it for batched-copy, not batched-precise-barrier).
@jkotas
jkotas
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
We have optimized JIT_Box helper variants only on Windows: 
runtime/src/coreclr/vm/jitinterfacegen.cpp

Lines 75 to 88
in
f88ab88
 #ifdef TARGET_UNIX 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_VC, JIT_NewArr1VC_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_OBJ, JIT_NewArr1OBJ_MP_FastPortable); 
ECall::DynamicallyAssignFCallImpl(GetEEFuncEntryPoint(AllocateString_MP_FastPortable), ECall::FastAllocateString); 
 #else// TARGET_UNIX
// if (multi-proc || server GC)
if (GCHeapUtilities::UseThreadAllocationContexts()) 
 { 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_BOX, JIT_BoxFastMP_InlineGetThread); 

. We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024

Closed

@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
For ContainsPointers the optimized assembly helper needs to thunk out to C++ anyway so the optimization might not amount to much for the relevant cases. I'll add this to the issue. Not actually planning to work on this based on Egor's comments.
@MichalStrehovsky
MichalStrehovsky
deleted the

gcptrbox

branch
April 29, 2024 21:55
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
Not actually planning to work on this based on Egor's comments.
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper (where you'll just do memcpyGC) and call it in genCodeForCpObj (so the actuall allocation for the box will be handled efficiently via the NEWS helper as is).
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
Yep, that's what I meant, the helper is completely unused/unimplemented, so at least we won't have to bump R2R format 🙂
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo left review comments
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@jkotas@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Don't inline expand boxes with many GC pointers - #101669
Closed
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Closed
Don't inline expand boxes with many GC pointers#101669
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 29, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
/benchmark plaintext,json,fortunes aspnet-citrine-win runtime,libs
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024
 Merged

@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Benchmark started for plaintext, json, fortunes on aspnet-citrine-win with runtime, libs. Logs: link
@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

plaintext - aspnet-citrine-win
applicationplaintext.baseplaintext.pr
Max CPU Usage (%)8070-12.50%
Max Cores usage (%)2,2331,961-12.18%
Max Working Set (MB)7271-1.39%
Max Private Memory (MB)94940.00%
Build Time (ms)8,2196,994-14.90%
Start Time (ms)358352-1.68%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadplaintext.baseplaintext.pr
Max CPU Usage (%)8382-1.20%
Max Cores usage (%)2,3282,305-0.99%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3703700.00%
Build Time (ms)6,4325,524-14.12%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)9089-1.11%
Requests/sec9,995,3539,944,556-0.51%
Requests150,903,360150,159,616-0.49%
Mean latency (ms)15.5817.14+10.01%
Max latency (ms)551.67442.85-19.73%
Bad responses00
Socket errors00
Read throughput (MB/s)1,198.081,198.080.00%
Latency 50th (ms)0.900.900.00%
Latency 75th (ms)8.778.99+2.51%
Latency 90th (ms)51.7756.33+8.81%
Latency 99th (ms)177.66214.30+20.62%
json - aspnet-citrine-win
applicationjson.basejson.pr
Max CPU Usage (%)7779+2.60%
Max Cores usage (%)2,1602,203+1.99%
Max Working Set (MB)6162+1.64%
Max Private Memory (MB)8384+1.20%
Build Time (ms)3,5633,604+1.15%
Start Time (ms)362353-2.49%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadjson.basejson.pr
Max CPU Usage (%)78780.00%
Max Cores usage (%)2,1852,176-0.41%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,2883,329+1.25%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)124119-4.03%
Requests/sec1,163,8361,148,431-1.32%
Requests17,573,83017,341,261-1.32%
Mean latency (ms)2.392.34-2.09%
Max latency (ms)104.85104.56-0.28%
Bad responses00
Socket errors00
Read throughput (MB/s)162.05159.90-1.33%
Latency 50th (ms)0.280.29+1.05%
Latency 75th (ms)0.981.02+4.08%
Latency 90th (ms)7.827.36-5.88%
Latency 99th (ms)27.1727.34+0.63%
fortunes - aspnet-citrine-win
dbfortunes.basefortunes.pr
Max CPU Usage (%)3132+3.23%
Max Cores usage (%)873886+1.49%
Max Working Set (MB)53530.00%
Build Time (ms)1,1941,185-0.75%
Start Time (ms)1,1941,198+0.34%
Published Size (KB)421,392421,3920.00%
applicationfortunes.basefortunes.pr
Max CPU Usage (%)8988-1.12%
Max Cores usage (%)2,5002,452-1.92%
Max Working Set (MB)530561+5.85%
Max Private Memory (MB)540589+9.07%
Build Time (ms)3,7033,837+3.62%
Start Time (ms)2,2442,136-4.81%
Published Size (KB)105,755105,7550.00%
Symbols Size (KB)55550.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadfortunes.basefortunes.pr
Max CPU Usage (%)3938-2.56%
Max Cores usage (%)1,0811,069-1.11%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,3973,423+0.77%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)106105-0.94%
Requests/sec439,111436,789-0.53%
Requests6,630,6726,595,331-0.53%
Mean latency (ms)1.511.49-1.32%
Max latency (ms)40.6524.59-39.51%
Bad responses00
Socket errors00
Read throughput (MB/s)577.48574.43-0.53%
Latency 50th (ms)1.061.07+0.94%
Latency 75th (ms)1.321.320.00%
Latency 90th (ms)1.931.92-0.52%
Latency 99th (ms)11.5711.78+1.82%
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 29, 2024

Closed

EgorBo
EgorBo
reviewed
Apr 29, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/importer.cpp
 // After a certain number of GC pointers, the write barriers used
 // in inline expansion stop being profitable.
 ClassLayout* layout = typGetObjLayout(pResolvedToken->hClass);
 if (layout->GetGCPtrCount() > 3)
@EgorBoEgorBoApr 29, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this might need more work, e.g. when we box a struct with 4 fields but all of them are null or e.g. nongc strings - this will be a regression. Also, I suspect this might ruin some "optimize boxing" optimizations.
I think we need to either fix all those places to deal with a helper call or we need to emit a bulk copy in codegen, just like I did in #99096 (but to do it for batched-copy, not batched-precise-barrier).
@jkotas
jkotas
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
We have optimized JIT_Box helper variants only on Windows: 
runtime/src/coreclr/vm/jitinterfacegen.cpp

Lines 75 to 88
in
f88ab88
 #ifdef TARGET_UNIX 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_VC, JIT_NewArr1VC_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_OBJ, JIT_NewArr1OBJ_MP_FastPortable); 
ECall::DynamicallyAssignFCallImpl(GetEEFuncEntryPoint(AllocateString_MP_FastPortable), ECall::FastAllocateString); 
 #else// TARGET_UNIX
// if (multi-proc || server GC)
if (GCHeapUtilities::UseThreadAllocationContexts()) 
 { 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_BOX, JIT_BoxFastMP_InlineGetThread); 

. We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024

Closed

@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
For ContainsPointers the optimized assembly helper needs to thunk out to C++ anyway so the optimization might not amount to much for the relevant cases. I'll add this to the issue. Not actually planning to work on this based on Egor's comments.
@MichalStrehovsky
MichalStrehovsky
deleted the

gcptrbox

branch
April 29, 2024 21:55
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
Not actually planning to work on this based on Egor's comments.
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper (where you'll just do memcpyGC) and call it in genCodeForCpObj (so the actuall allocation for the box will be handled efficiently via the NEWS helper as is).
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
Yep, that's what I meant, the helper is completely unused/unimplemented, so at least we won't have to bump R2R format 🙂
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo left review comments
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@jkotas@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Don't inline expand boxes with many GC pointers - #101669
Closed
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Closed
Don't inline expand boxes with many GC pointers#101669
MichalStrehovsky wants to merge 1 commit into
dotnet:mainfrom 
MichalStrehovsky:gcptrbox
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 29, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
/benchmark plaintext,json,fortunes aspnet-citrine-win runtime,libs
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024
 Merged

@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

Benchmark started for plaintext, json, fortunes on aspnet-citrine-win with runtime, libs. Logs: link
@pr-benchmarks
pr-benchmarksBot
commented
Apr 29, 2024

Copy link


Copy Markdown

plaintext - aspnet-citrine-win
applicationplaintext.baseplaintext.pr
Max CPU Usage (%)8070-12.50%
Max Cores usage (%)2,2331,961-12.18%
Max Working Set (MB)7271-1.39%
Max Private Memory (MB)94940.00%
Build Time (ms)8,2196,994-14.90%
Start Time (ms)358352-1.68%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadplaintext.baseplaintext.pr
Max CPU Usage (%)8382-1.20%
Max Cores usage (%)2,3282,305-0.99%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3703700.00%
Build Time (ms)6,4325,524-14.12%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)9089-1.11%
Requests/sec9,995,3539,944,556-0.51%
Requests150,903,360150,159,616-0.49%
Mean latency (ms)15.5817.14+10.01%
Max latency (ms)551.67442.85-19.73%
Bad responses00
Socket errors00
Read throughput (MB/s)1,198.081,198.080.00%
Latency 50th (ms)0.900.900.00%
Latency 75th (ms)8.778.99+2.51%
Latency 90th (ms)51.7756.33+8.81%
Latency 99th (ms)177.66214.30+20.62%
json - aspnet-citrine-win
applicationjson.basejson.pr
Max CPU Usage (%)7779+2.60%
Max Cores usage (%)2,1602,203+1.99%
Max Working Set (MB)6162+1.64%
Max Private Memory (MB)8384+1.20%
Build Time (ms)3,5633,604+1.15%
Start Time (ms)362353-2.49%
Published Size (KB)105,748105,7480.00%
Symbols Size (KB)54540.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadjson.basejson.pr
Max CPU Usage (%)78780.00%
Max Cores usage (%)2,1852,176-0.41%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,2883,329+1.25%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)124119-4.03%
Requests/sec1,163,8361,148,431-1.32%
Requests17,573,83017,341,261-1.32%
Mean latency (ms)2.392.34-2.09%
Max latency (ms)104.85104.56-0.28%
Bad responses00
Socket errors00
Read throughput (MB/s)162.05159.90-1.33%
Latency 50th (ms)0.280.29+1.05%
Latency 75th (ms)0.981.02+4.08%
Latency 90th (ms)7.827.36-5.88%
Latency 99th (ms)27.1727.34+0.63%
fortunes - aspnet-citrine-win
dbfortunes.basefortunes.pr
Max CPU Usage (%)3132+3.23%
Max Cores usage (%)873886+1.49%
Max Working Set (MB)53530.00%
Build Time (ms)1,1941,185-0.75%
Start Time (ms)1,1941,198+0.34%
Published Size (KB)421,392421,3920.00%
applicationfortunes.basefortunes.pr
Max CPU Usage (%)8988-1.12%
Max Cores usage (%)2,5002,452-1.92%
Max Working Set (MB)530561+5.85%
Max Private Memory (MB)540589+9.07%
Build Time (ms)3,7033,837+3.62%
Start Time (ms)2,2442,136-4.81%
Published Size (KB)105,755105,7550.00%
Symbols Size (KB)55550.00%
.NET Core SDK Version9.0.100-preview.5.24227.19.0.100-preview.5.24227.1
loadfortunes.basefortunes.pr
Max CPU Usage (%)3938-2.56%
Max Cores usage (%)1,0811,069-1.11%
Max Working Set (MB)46460.00%
Max Private Memory (MB)3633630.00%
Build Time (ms)3,3973,423+0.77%
Start Time (ms)00
Published Size (KB)72,25972,2590.00%
Symbols Size (KB)00
.NET Core SDK Version8.0.2048.0.204
First Request (ms)106105-0.94%
Requests/sec439,111436,789-0.53%
Requests6,630,6726,595,331-0.53%
Mean latency (ms)1.511.49-1.32%
Max latency (ms)40.6524.59-39.51%
Bad responses00
Socket errors00
Read throughput (MB/s)577.48574.43-0.53%
Latency 50th (ms)1.061.07+0.94%
Latency 75th (ms)1.321.320.00%
Latency 90th (ms)1.931.92-0.52%
Latency 99th (ms)11.5711.78+1.82%
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 29, 2024

Closed

EgorBo
EgorBo
reviewed
Apr 29, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/importer.cpp
 // After a certain number of GC pointers, the write barriers used
 // in inline expansion stop being profitable.
 ClassLayout* layout = typGetObjLayout(pResolvedToken->hClass);
 if (layout->GetGCPtrCount() > 3)
@EgorBoEgorBoApr 29, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this might need more work, e.g. when we box a struct with 4 fields but all of them are null or e.g. nongc strings - this will be a regression. Also, I suspect this might ruin some "optimize boxing" optimizations.
I think we need to either fix all those places to deal with a helper call or we need to emit a bulk copy in codegen, just like I did in #99096 (but to do it for batched-copy, not batched-precise-barrier).
@jkotas
jkotas
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
We have optimized JIT_Box helper variants only on Windows: 
runtime/src/coreclr/vm/jitinterfacegen.cpp

Lines 75 to 88
in
f88ab88
 #ifdef TARGET_UNIX 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_NewS_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_VC, JIT_NewArr1VC_MP_FastPortable); 
SetJitHelperFunction(CORINFO_HELP_NEWARR_1_OBJ, JIT_NewArr1OBJ_MP_FastPortable); 
ECall::DynamicallyAssignFCallImpl(GetEEFuncEntryPoint(AllocateString_MP_FastPortable), ECall::FastAllocateString); 
 #else// TARGET_UNIX
// if (multi-proc || server GC)
if (GCHeapUtilities::UseThreadAllocationContexts()) 
 { 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_NEWSFAST_ALIGN8, JIT_TrialAllocSFastMP_InlineGetThread); 
SetJitHelperFunction(CORINFO_HELP_BOX, JIT_BoxFastMP_InlineGetThread); 

. We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Apr 29, 2024

Closed

@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
We would need to implemented the optimized non-Windows JIT_Box helper variants on non-Windows too to make this optimization work well, using the same strategy as the optimized non-Windows allocation helpers are implemented.
For ContainsPointers the optimized assembly helper needs to thunk out to C++ anyway so the optimization might not amount to much for the relevant cases. I'll add this to the issue. Not actually planning to work on this based on Egor's comments.
@MichalStrehovsky
MichalStrehovsky
deleted the

gcptrbox

branch
April 29, 2024 21:55
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
Not actually planning to work on this based on Egor's comments.
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper (where you'll just do memcpyGC) and call it in genCodeForCpObj (so the actuall allocation for the box will be handled efficiently via the NEWS helper as is).
@MichalStrehovsky
MichalStrehovsky
commented
Apr 29, 2024

Copy link


Copy Markdown

MemberAuthor
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
@EgorBo
EgorBo
commented
Apr 29, 2024

Copy link


Copy Markdown

Member
I can try myself, but I think it should be more or less trivial, you just need to introduce a new helper
If we want to keep the NEWS, we might just be able to use the CORINFO_HELP_ASSIGN_STRUCT to do the copying.
Yep, that's what I meant, the helper is completely unused/unimplemented, so at least we won't have to bump R2R format 🙂
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
May 31, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo left review comments
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@jkotas@EgorBo