Backport #92375 and #93082 to release/8.0-staging by eduardo-vp · Pull Request #101744 · dotnet/runtime

eduardo-vp · 2024-04-30T21:57:52Z

This is part of the work to transition to the 1ES templates in servicing branches.

PR #92375 was cleanly cherry-picked, except for changes in eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml which were discarded.

For PR #93082, only the changes in eng/pipelines/runtime*.yml were included as the others are not required.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442616&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

ghost · 2024-04-30T21:58:08Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-01T01:17:59Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

agocke · 2024-05-01T14:33:59Z

Probably not strictly necessary to backport new tests, but not a problem if it makes porting easier. This won’t work for net6 because Native aot wasn’t supported then.

Sounds good, thanks for letting me know. I'll make the PR simpler in that case, hoping that it can be directly backported to net6

agocke

Lgtm although we only strictly need to port changes to runtime-official and dependencies thereof. If possible I would try to avoid other changes that may change behavior for only the public build.

…d steps (dotnet#92375)

…lates (dotnet#93082)

jeffschwMSFT

approved. we can take this as tell mode

cc @carlossanlop

eduardo-vp · 2024-04-30T21:57:52Z

This is part of the work to transition to the 1ES templates in servicing branches.

PR #92375 was cleanly cherry-picked, except for changes in eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml which were discarded.

For PR #93082, only the changes in eng/pipelines/runtime*.yml were included as the others are not required.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442616&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

ghost · 2024-04-30T21:58:08Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-01T01:17:59Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

agocke · 2024-05-01T14:33:59Z

Probably not strictly necessary to backport new tests, but not a problem if it makes porting easier. This won’t work for net6 because Native aot wasn’t supported then.

Sounds good, thanks for letting me know. I'll make the PR simpler in that case, hoping that it can be directly backported to net6

agocke

Lgtm although we only strictly need to port changes to runtime-official and dependencies thereof. If possible I would try to avoid other changes that may change behavior for only the public build.

…d steps (dotnet#92375)

…lates (dotnet#93082)

jeffschwMSFT

approved. we can take this as tell mode

cc @carlossanlop

eduardo-vp · 2024-04-30T21:57:52Z

This is part of the work to transition to the 1ES templates in servicing branches.

PR #92375 was cleanly cherry-picked, except for changes in eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml which were discarded.

For PR #93082, only the changes in eng/pipelines/runtime*.yml were included as the others are not required.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442616&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

ghost · 2024-04-30T21:58:08Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-01T01:17:59Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

agocke · 2024-05-01T14:33:59Z

Probably not strictly necessary to backport new tests, but not a problem if it makes porting easier. This won’t work for net6 because Native aot wasn’t supported then.

Sounds good, thanks for letting me know. I'll make the PR simpler in that case, hoping that it can be directly backported to net6

agocke

Lgtm although we only strictly need to port changes to runtime-official and dependencies thereof. If possible I would try to avoid other changes that may change behavior for only the public build.

…d steps (dotnet#92375)

…lates (dotnet#93082)

jeffschwMSFT

approved. we can take this as tell mode

cc @carlossanlop

eduardo-vp · 2024-04-30T21:57:52Z

This is part of the work to transition to the 1ES templates in servicing branches.

PR #92375 was cleanly cherry-picked, except for changes in eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml which were discarded.

For PR #93082, only the changes in eng/pipelines/runtime*.yml were included as the others are not required.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442616&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

ghost · 2024-04-30T21:58:08Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-01T01:17:59Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

agocke · 2024-05-01T14:33:59Z

Probably not strictly necessary to backport new tests, but not a problem if it makes porting easier. This won’t work for net6 because Native aot wasn’t supported then.

Sounds good, thanks for letting me know. I'll make the PR simpler in that case, hoping that it can be directly backported to net6

agocke

Lgtm although we only strictly need to port changes to runtime-official and dependencies thereof. If possible I would try to avoid other changes that may change behavior for only the public build.

…d steps (dotnet#92375)

…lates (dotnet#93082)

jeffschwMSFT

approved. we can take this as tell mode

cc @carlossanlop

eduardo-vp · 2024-04-30T21:57:52Z

This is part of the work to transition to the 1ES templates in servicing branches.

PR #92375 was cleanly cherry-picked, except for changes in eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml which were discarded.

For PR #93082, only the changes in eng/pipelines/runtime*.yml were included as the others are not required.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442616&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

ghost · 2024-04-30T21:58:08Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-01T01:17:59Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

agocke · 2024-05-01T14:33:59Z

Probably not strictly necessary to backport new tests, but not a problem if it makes porting easier. This won’t work for net6 because Native aot wasn’t supported then.

Sounds good, thanks for letting me know. I'll make the PR simpler in that case, hoping that it can be directly backported to net6

agocke

Lgtm although we only strictly need to port changes to runtime-official and dependencies thereof. If possible I would try to avoid other changes that may change behavior for only the public build.

…d steps (dotnet#92375)

…lates (dotnet#93082)

jeffschwMSFT

approved. we can take this as tell mode

cc @carlossanlop

eduardo-vp · 2024-04-30T21:57:52Z

This is part of the work to transition to the 1ES templates in servicing branches.

PR #92375 was cleanly cherry-picked, except for changes in eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml which were discarded.

For PR #93082, only the changes in eng/pipelines/runtime*.yml were included as the others are not required.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442616&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

ghost · 2024-04-30T21:58:08Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-01T01:17:59Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

agocke · 2024-05-01T14:33:59Z

Probably not strictly necessary to backport new tests, but not a problem if it makes porting easier. This won’t work for net6 because Native aot wasn’t supported then.

Sounds good, thanks for letting me know. I'll make the PR simpler in that case, hoping that it can be directly backported to net6

agocke

Lgtm although we only strictly need to port changes to runtime-official and dependencies thereof. If possible I would try to avoid other changes that may change behavior for only the public build.

…d steps (dotnet#92375)

…lates (dotnet#93082)

jeffschwMSFT

approved. we can take this as tell mode

cc @carlossanlop

eduardo-vp · 2024-04-30T21:57:52Z

This is part of the work to transition to the 1ES templates in servicing branches.

PR #92375 was cleanly cherry-picked, except for changes in eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml which were discarded.

For PR #93082, only the changes in eng/pipelines/runtime*.yml were included as the others are not required.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442616&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

ghost · 2024-04-30T21:58:08Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-01T01:17:59Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

agocke · 2024-05-01T14:33:59Z

Probably not strictly necessary to backport new tests, but not a problem if it makes porting easier. This won’t work for net6 because Native aot wasn’t supported then.

Sounds good, thanks for letting me know. I'll make the PR simpler in that case, hoping that it can be directly backported to net6

agocke

Lgtm although we only strictly need to port changes to runtime-official and dependencies thereof. If possible I would try to avoid other changes that may change behavior for only the public build.

…d steps (dotnet#92375)

…lates (dotnet#93082)

jeffschwMSFT

approved. we can take this as tell mode

cc @carlossanlop

eduardo-vp · 2024-04-30T21:57:52Z

This is part of the work to transition to the 1ES templates in servicing branches.

PR #92375 was cleanly cherry-picked, except for changes in eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml which were discarded.

For PR #93082, only the changes in eng/pipelines/runtime*.yml were included as the others are not required.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442616&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

ghost · 2024-04-30T21:58:08Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-05-01T01:17:59Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

agocke · 2024-05-01T14:33:59Z

Probably not strictly necessary to backport new tests, but not a problem if it makes porting easier. This won’t work for net6 because Native aot wasn’t supported then.

Sounds good, thanks for letting me know. I'll make the PR simpler in that case, hoping that it can be directly backported to net6

agocke

Lgtm although we only strictly need to port changes to runtime-official and dependencies thereof. If possible I would try to avoid other changes that may change behavior for only the public build.

…d steps (dotnet#92375)

…lates (dotnet#93082)

jeffschwMSFT

approved. we can take this as tell mode

cc @carlossanlop

eduardo-vp changed the base branch from main to release/8.0-stagingApril 30, 2024 21:58

ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Apr 30, 2024

dotnet-policy-serviceBot assigned eduardo-vp Apr 30, 2024

eduardo-vp added area-Infrastructure and removed new-api-needs-documentation needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 1, 2024

eduardo-vp changed the title ~~[Testing] Backport #92375 and #93082 to release/8.0-staging~~Backport #92375 and #93082 to release/8.0-stagingMay 1, 2024

eduardo-vp marked this pull request as ready for review May 1, 2024 05:09

eduardo-vp requested a review from radical as a code owner May 1, 2024 05:09

eduardo-vp requested review from agocke and jkoritzinsky May 1, 2024 05:11

agocke reviewed May 1, 2024
View reviewed changes

agocke approved these changes May 1, 2024
View reviewed changes

Allow multiple post-build steps and allow templated pre and post-buil…
9111100
…d steps (dotnet#92375)

eduardo-vp force-pushed the backport-92375-to-release-8.0-staging branch from 895af02 to ee04040Compare May 1, 2024 20:17

Convert AllConfigurations and NETFX jobs to use the global build temp…
5acba8c
…lates (dotnet#93082)

eduardo-vp force-pushed the backport-92375-to-release-8.0-staging branch from ee04040 to 5acba8cCompare May 1, 2024 20:34

build-analysisBot mentioned this pull request May 2, 2024
Tracking issue for "WORKLOAD TIMED OUT" #90309
Closed

eduardo-vp added the Servicing-consider Issue for next servicing release review label May 2, 2024

jeffschwMSFT approved these changes May 2, 2024
View reviewed changes

jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 2, 2024

eduardo-vp merged commit 37a6d07 into dotnet:release/8.0-stagingMay 2, 2024

amanasifkhalid mentioned this pull request May 14, 2024
[release/6.0-staging] Backport #92375 #102172
Merged

eduardo-vp deleted the backport-92375-to-release-8.0-staging branch May 29, 2024 20:36

github-actionsBot locked and limited conversation to collaborators Jun 29, 2024