Delete DebugSymbols=true setting for the repo build by jkotas · Pull Request #102392 · dotnet/runtime

jkotas · 2024-05-17T18:29:49Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. Also, this gets us closer to default build configuration used by our users.

dotnet-policy-service · 2024-05-17T18:30:16Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-05-18T17:24:12Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-05-18T17:24:20Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T17:24:29Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T17:24:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:29:35Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:29:45Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:36:25Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:36:37Z

Azure Pipelines successfully started running 1 pipeline(s).

am11 · 2024-05-19T00:09:14Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2022 documents DebugSymbols as:

Setting -p:DebugSymbols=false on the command line disables generation of program database (.pdb) symbol files.

Does it mean documentation is incorrect or it's in fact an accidental bug?

jkotas · 2024-05-19T19:47:43Z

Does it mean documentation is incorrect or it's in fact an accidental bug?

I have opened dotnet/sdk#41364

My conclusion after reading through mentions of DebugSymbols property in dotnet/sdk repo is that it is a legacy mess that that should be avoided. DebugType property is what actually works.

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables.

MichalStrehovsky

Thanks!

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

ViktorHofer · 2024-05-21T11:47:42Z

For others reviewing this, the Microsoft.NET.Sdk makes this property still default to true when doing a Debug configuration build: https://github.com/dotnet/sdk/blob/ace21a69999eede779921900fca9420d37395aee/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L49

* Delete DebugSymbols This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. * Update eng/illink.targets Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> --------- Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

sbomer · 2024-05-30T17:59:47Z

Based on #102392 (comment), should DebugSymbols=true also be removed from the SDK when building the Debug configuration, or is disabling some peephole optimizations useful for debugging?

jkotas · 2024-05-30T19:18:50Z

Possibly. It depends on whether and how the behavior of DebugSymbols is changed: dotnet/sdk#41364

jkotas · 2024-05-17T18:29:49Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. Also, this gets us closer to default build configuration used by our users.

dotnet-policy-service · 2024-05-17T18:30:16Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-05-18T17:24:12Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-05-18T17:24:20Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T17:24:29Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T17:24:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:29:35Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:29:45Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:36:25Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:36:37Z

Azure Pipelines successfully started running 1 pipeline(s).

am11 · 2024-05-19T00:09:14Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2022 documents DebugSymbols as:

Setting -p:DebugSymbols=false on the command line disables generation of program database (.pdb) symbol files.

Does it mean documentation is incorrect or it's in fact an accidental bug?

jkotas · 2024-05-19T19:47:43Z

Does it mean documentation is incorrect or it's in fact an accidental bug?

I have opened dotnet/sdk#41364

My conclusion after reading through mentions of DebugSymbols property in dotnet/sdk repo is that it is a legacy mess that that should be avoided. DebugType property is what actually works.

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables.

MichalStrehovsky

Thanks!

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

ViktorHofer · 2024-05-21T11:47:42Z

For others reviewing this, the Microsoft.NET.Sdk makes this property still default to true when doing a Debug configuration build: https://github.com/dotnet/sdk/blob/ace21a69999eede779921900fca9420d37395aee/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L49

* Delete DebugSymbols This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. * Update eng/illink.targets Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> --------- Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

sbomer · 2024-05-30T17:59:47Z

Based on #102392 (comment), should DebugSymbols=true also be removed from the SDK when building the Debug configuration, or is disabling some peephole optimizations useful for debugging?

jkotas · 2024-05-30T19:18:50Z

Possibly. It depends on whether and how the behavior of DebugSymbols is changed: dotnet/sdk#41364

jkotas · 2024-05-17T18:29:49Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. Also, this gets us closer to default build configuration used by our users.

dotnet-policy-service · 2024-05-17T18:30:16Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-05-18T17:24:12Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-05-18T17:24:20Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T17:24:29Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T17:24:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:29:35Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:29:45Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:36:25Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:36:37Z

Azure Pipelines successfully started running 1 pipeline(s).

am11 · 2024-05-19T00:09:14Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2022 documents DebugSymbols as:

Setting -p:DebugSymbols=false on the command line disables generation of program database (.pdb) symbol files.

Does it mean documentation is incorrect or it's in fact an accidental bug?

jkotas · 2024-05-19T19:47:43Z

Does it mean documentation is incorrect or it's in fact an accidental bug?

I have opened dotnet/sdk#41364

My conclusion after reading through mentions of DebugSymbols property in dotnet/sdk repo is that it is a legacy mess that that should be avoided. DebugType property is what actually works.

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables.

MichalStrehovsky

Thanks!

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

ViktorHofer · 2024-05-21T11:47:42Z

For others reviewing this, the Microsoft.NET.Sdk makes this property still default to true when doing a Debug configuration build: https://github.com/dotnet/sdk/blob/ace21a69999eede779921900fca9420d37395aee/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L49

* Delete DebugSymbols This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. * Update eng/illink.targets Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> --------- Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

sbomer · 2024-05-30T17:59:47Z

Based on #102392 (comment), should DebugSymbols=true also be removed from the SDK when building the Debug configuration, or is disabling some peephole optimizations useful for debugging?

jkotas · 2024-05-30T19:18:50Z

Possibly. It depends on whether and how the behavior of DebugSymbols is changed: dotnet/sdk#41364

jkotas · 2024-05-17T18:29:49Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. Also, this gets us closer to default build configuration used by our users.

dotnet-policy-service · 2024-05-17T18:30:16Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-05-18T17:24:12Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-05-18T17:24:20Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T17:24:29Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T17:24:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:29:35Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:29:45Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:36:25Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:36:37Z

Azure Pipelines successfully started running 1 pipeline(s).

am11 · 2024-05-19T00:09:14Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2022 documents DebugSymbols as:

Setting -p:DebugSymbols=false on the command line disables generation of program database (.pdb) symbol files.

Does it mean documentation is incorrect or it's in fact an accidental bug?

jkotas · 2024-05-19T19:47:43Z

Does it mean documentation is incorrect or it's in fact an accidental bug?

I have opened dotnet/sdk#41364

My conclusion after reading through mentions of DebugSymbols property in dotnet/sdk repo is that it is a legacy mess that that should be avoided. DebugType property is what actually works.

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables.

MichalStrehovsky

Thanks!

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

ViktorHofer · 2024-05-21T11:47:42Z

For others reviewing this, the Microsoft.NET.Sdk makes this property still default to true when doing a Debug configuration build: https://github.com/dotnet/sdk/blob/ace21a69999eede779921900fca9420d37395aee/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L49

* Delete DebugSymbols This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. * Update eng/illink.targets Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> --------- Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

sbomer · 2024-05-30T17:59:47Z

Based on #102392 (comment), should DebugSymbols=true also be removed from the SDK when building the Debug configuration, or is disabling some peephole optimizations useful for debugging?

jkotas · 2024-05-30T19:18:50Z

Possibly. It depends on whether and how the behavior of DebugSymbols is changed: dotnet/sdk#41364

jkotas · 2024-05-17T18:29:49Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. Also, this gets us closer to default build configuration used by our users.

dotnet-policy-service · 2024-05-17T18:30:16Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-05-18T17:24:12Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-05-18T17:24:20Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T17:24:29Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T17:24:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:29:35Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:29:45Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:36:25Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:36:37Z

Azure Pipelines successfully started running 1 pipeline(s).

am11 · 2024-05-19T00:09:14Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2022 documents DebugSymbols as:

Setting -p:DebugSymbols=false on the command line disables generation of program database (.pdb) symbol files.

Does it mean documentation is incorrect or it's in fact an accidental bug?

jkotas · 2024-05-19T19:47:43Z

Does it mean documentation is incorrect or it's in fact an accidental bug?

I have opened dotnet/sdk#41364

My conclusion after reading through mentions of DebugSymbols property in dotnet/sdk repo is that it is a legacy mess that that should be avoided. DebugType property is what actually works.

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables.

MichalStrehovsky

Thanks!

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

ViktorHofer · 2024-05-21T11:47:42Z

For others reviewing this, the Microsoft.NET.Sdk makes this property still default to true when doing a Debug configuration build: https://github.com/dotnet/sdk/blob/ace21a69999eede779921900fca9420d37395aee/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L49

* Delete DebugSymbols This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. * Update eng/illink.targets Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> --------- Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

sbomer · 2024-05-30T17:59:47Z

Based on #102392 (comment), should DebugSymbols=true also be removed from the SDK when building the Debug configuration, or is disabling some peephole optimizations useful for debugging?

jkotas · 2024-05-30T19:18:50Z

Possibly. It depends on whether and how the behavior of DebugSymbols is changed: dotnet/sdk#41364

jkotas · 2024-05-17T18:29:49Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. Also, this gets us closer to default build configuration used by our users.

dotnet-policy-service · 2024-05-17T18:30:16Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-05-18T17:24:12Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-05-18T17:24:20Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T17:24:29Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T17:24:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:29:35Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:29:45Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:36:25Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:36:37Z

Azure Pipelines successfully started running 1 pipeline(s).

am11 · 2024-05-19T00:09:14Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2022 documents DebugSymbols as:

Setting -p:DebugSymbols=false on the command line disables generation of program database (.pdb) symbol files.

Does it mean documentation is incorrect or it's in fact an accidental bug?

jkotas · 2024-05-19T19:47:43Z

Does it mean documentation is incorrect or it's in fact an accidental bug?

I have opened dotnet/sdk#41364

My conclusion after reading through mentions of DebugSymbols property in dotnet/sdk repo is that it is a legacy mess that that should be avoided. DebugType property is what actually works.

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables.

MichalStrehovsky

Thanks!

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

ViktorHofer · 2024-05-21T11:47:42Z

For others reviewing this, the Microsoft.NET.Sdk makes this property still default to true when doing a Debug configuration build: https://github.com/dotnet/sdk/blob/ace21a69999eede779921900fca9420d37395aee/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L49

* Delete DebugSymbols This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. * Update eng/illink.targets Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> --------- Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

sbomer · 2024-05-30T17:59:47Z

Based on #102392 (comment), should DebugSymbols=true also be removed from the SDK when building the Debug configuration, or is disabling some peephole optimizations useful for debugging?

jkotas · 2024-05-30T19:18:50Z

Possibly. It depends on whether and how the behavior of DebugSymbols is changed: dotnet/sdk#41364

jkotas · 2024-05-17T18:29:49Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. Also, this gets us closer to default build configuration used by our users.

dotnet-policy-service · 2024-05-17T18:30:16Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-05-18T17:24:12Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-05-18T17:24:20Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T17:24:29Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T17:24:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:29:35Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:29:45Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:36:25Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:36:37Z

Azure Pipelines successfully started running 1 pipeline(s).

am11 · 2024-05-19T00:09:14Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2022 documents DebugSymbols as:

Setting -p:DebugSymbols=false on the command line disables generation of program database (.pdb) symbol files.

Does it mean documentation is incorrect or it's in fact an accidental bug?

jkotas · 2024-05-19T19:47:43Z

Does it mean documentation is incorrect or it's in fact an accidental bug?

I have opened dotnet/sdk#41364

My conclusion after reading through mentions of DebugSymbols property in dotnet/sdk repo is that it is a legacy mess that that should be avoided. DebugType property is what actually works.

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables.

MichalStrehovsky

Thanks!

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

ViktorHofer · 2024-05-21T11:47:42Z

For others reviewing this, the Microsoft.NET.Sdk makes this property still default to true when doing a Debug configuration build: https://github.com/dotnet/sdk/blob/ace21a69999eede779921900fca9420d37395aee/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L49

* Delete DebugSymbols This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. * Update eng/illink.targets Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> --------- Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

sbomer · 2024-05-30T17:59:47Z

Based on #102392 (comment), should DebugSymbols=true also be removed from the SDK when building the Debug configuration, or is disabling some peephole optimizations useful for debugging?

jkotas · 2024-05-30T19:18:50Z

Possibly. It depends on whether and how the behavior of DebugSymbols is changed: dotnet/sdk#41364

jkotas · 2024-05-17T18:29:49Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. Also, this gets us closer to default build configuration used by our users.

dotnet-policy-service · 2024-05-17T18:30:16Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-05-18T17:24:12Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-05-18T17:24:20Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T17:24:29Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T17:24:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:29:35Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:29:45Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-05-18T22:36:25Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2024-05-18T22:36:37Z

Azure Pipelines successfully started running 1 pipeline(s).

am11 · 2024-05-19T00:09:14Z

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations.

https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2022 documents DebugSymbols as:

Setting -p:DebugSymbols=false on the command line disables generation of program database (.pdb) symbol files.

Does it mean documentation is incorrect or it's in fact an accidental bug?

jkotas · 2024-05-19T19:47:43Z

Does it mean documentation is incorrect or it's in fact an accidental bug?

I have opened dotnet/sdk#41364

My conclusion after reading through mentions of DebugSymbols property in dotnet/sdk repo is that it is a legacy mess that that should be avoided. DebugType property is what actually works.

This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables.

MichalStrehovsky

Thanks!

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

ViktorHofer · 2024-05-21T11:47:42Z

For others reviewing this, the Microsoft.NET.Sdk makes this property still default to true when doing a Debug configuration build: https://github.com/dotnet/sdk/blob/ace21a69999eede779921900fca9420d37395aee/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L49

* Delete DebugSymbols This property does not do what its name says. The symbols are generated regardless of whether this property is true or false. What this property actually does is that it disables C# peephole IL optimizations. This change results in ~0.5% IL binary size improvement thanks to the Roslyn IL peephole optimizations that it enables. * Update eng/illink.targets Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com> --------- Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

sbomer · 2024-05-30T17:59:47Z

Based on #102392 (comment), should DebugSymbols=true also be removed from the SDK when building the Debug configuration, or is disabling some peephole optimizations useful for debugging?

jkotas · 2024-05-30T19:18:50Z

Possibly. It depends on whether and how the behavior of DebugSymbols is changed: dotnet/sdk#41364

jkotas added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it area-Infrastructure-libraries labels May 17, 2024

dotnet-policy-serviceBot assigned jkotas May 17, 2024

jkotas changed the title ~~Delete DebugSymbols~~Delete DebugSymbols propertyMay 17, 2024

jkotas closed this May 17, 2024

jkotas reopened this May 17, 2024

jkotas closed this May 17, 2024

jkotas reopened this May 17, 2024

jkotas force-pushed the debugsymbols branch from 1fec2fc to e841c63Compare May 17, 2024 19:07

jkotas force-pushed the debugsymbols branch from 3d21eb6 to 0bd0dcdCompare May 18, 2024 16:56

jkotas changed the title ~~Delete DebugSymbols property~~Delete DebugSymbols=true setting for the repo buildMay 18, 2024

jkotas removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels May 18, 2024

build-analysisBot mentioned this pull request May 18, 2024
Dead lettering tests #101524
Closed

jkotas force-pushed the debugsymbols branch from 0bd0dcd to 12d8702Compare May 18, 2024 21:37

jkotas force-pushed the debugsymbols branch from 12d8702 to 9c186d0Compare May 18, 2024 22:36

jkotas mentioned this pull request May 19, 2024
Delete empty DebugType property from test projects #102422
Merged

jkotas force-pushed the debugsymbols branch from 9c186d0 to 22299f7Compare May 20, 2024 02:47

jkotas marked this pull request as ready for review May 20, 2024 02:47

jkotas requested a review from MichalStrehovsky as a code owner May 20, 2024 02:47

jkotas mentioned this pull request May 21, 2024
Migrate to zlib-ng, part 2: consume it in runtime #102403
Merged
15 tasks

MichalStrehovsky approved these changes May 21, 2024
View reviewed changes

Comment threadeng/illink.targets Outdated

Update eng/illink.targets
3130f65
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

ViktorHofer approved these changes May 21, 2024
View reviewed changes

This was referenced May 21, 2024
Abort on mono in SwiftErrorHandling #102478
Closed
SupportedLinuxPlatforms_IsSupportedIsTrue failed in CI #102479
Closed

jkotas merged commit 153a94b into dotnet:mainMay 21, 2024

jkotas deleted the debugsymbols branch May 21, 2024 15:15

AndyAyersMS mentioned this pull request May 29, 2024
[Perf] Linux/x64: 27 Improvements on 5/21/2024 3:15:28 PM dotnet/perf-autofiling-issues#35101
Closed

github-actionsBot locked and limited conversation to collaborators Jul 4, 2024