[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation - #102565

Merged
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom
filipnavara:backport-95898
Jun 4, 2024
Merged

[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation#102565
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom
filipnavara:backport-95898

Conversation

@filipnavara

@filipnavarafilipnavara commented May 22, 2024•
edited by karelz
Loading

Copy link
Copy Markdown
Member

Backport of #95898 to release/8.0-staging

Fixes#95725

Customer Impact

Reported by customers in issue #95898 and by eM Client in #95725 (comment) - they cannot connect to Microsoft Exchange and quite a few other host providers on Android client (which uses ManagedNtlm by default).

Authenticating to HTTPS servers using NTLM fails with "Unauthorized" error code when Extended Authentication option is enabled on the server. This is an increasingly common setting on Microsoft Exchange deployments. The bug affects primarily the Android platform where the Managed NTLM implementation is used. We also allow the Managed NTLM as opt-in on macOS and Linux which would be likewise affected if the developer chooses to enable the System.Net.Security.UseManagedNtlm app context switch (which is rare).

Regression

No

Testing

Validated by eM Client on private Exchange instance in Azure VM + against one of the largest host providers in Germany.
The fix has been in .NET 9 since December 2023 and there were no observed issues.

Note: There are no unit tests, the set up is too complicated to test it meaningfully.

Risk

Low; the modified code path is in platform specific code for a single authentication scheme.

@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label May 22, 2024
@filipnavarafilipnavara added the Servicing-consider Issue for next servicing release review label May 22, 2024
@filipnavara

filipnavara commented May 22, 2024

Copy link
Copy Markdown
MemberAuthor

/cc @rzikm@wfurt

We have another customer of our product affected by this issue. They provided a test account on their server and we verified that the fix resolves the issue.

@rzikmrzikm removed the Servicing-consider Issue for next servicing release review label May 23, 2024
@rzikmrzikm added this to the 8.0.x milestone May 23, 2024
@rzikm

rzikm commented May 23, 2024

Copy link
Copy Markdown
Member

LGTM.

Removed Servicing-Consider for now, in case @karelz wants to edit the template first.

@filipnavarafilipnavara mentioned this pull request May 24, 2024
Closed
@vitek-karas

vitek-karas commented May 24, 2024

Copy link
Copy Markdown
Member

/fyi @simonrozsival

@JeroenBer

JeroenBer commented May 25, 2024

Copy link
Copy Markdown

Yes we urgently need this for our customers. Not only for Android but also iOS and macOS since the unmanaged implementations cause crashes and are not usable (#97966)

@dotnet-policy-service

dotnet-policy-serviceBot commented May 29, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@JeroenBer

JeroenBer commented May 31, 2024

Copy link
Copy Markdown

@rzikm , not sure how this works but I see the PR is missing the "Servicing-approved" label before it can be merged. Who can do this ?

@rzikm

rzikm commented May 31, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@JeroenBer I am keeping eye on this issue. The earliest this fix can get released is in July servicing release, and deadline for that release is mid June, we are still on track for that release.

@JeroenBer

JeroenBer commented May 31, 2024

Copy link
Copy Markdown

@rzikm Thanks for keeping an eye on this. A lot of our customers are waiting for this. July is still a long time but please let's make that. If there's anything we can do to speed this up, like creating a service case at Microsoft, then please let me know.

@rzikm

rzikm commented May 31, 2024

Copy link
Copy Markdown
Member

Creating a service case is unlikely to speed things up.

.NET has monthly cadence of servicing releases (with release dates coinciding with patch Tuesdays). Around the time one release is released, next one is branched off and starts to be prepared.

Restarting the process mid-way to include additional fixes would be costly (I don't know the figures, it's just my assumption based on my observations).

At any rate, there is potentially a way to unblock you and your customers earlier by using a private build of System.Net.Security.dll containing the fix. We use the process for validating that the fix is working. For desktop platforms the steps are simple (self-contained publish of the app+ overwriting the changed dll), I can provide you with the right dll for macOS if this option is available for you.

Unfortunately, I don't know if a similar process is possible for mobile platforms. Maybe @simonrozsival knows.

@simonrozsival

simonrozsival commented Jun 3, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Unfortunately, I don't know if a similar process is possible for mobile platforms.

It is possible to use custom runtime build in a mobile app, but I wouldn't recommend it. An example how to use custom dll on Android (or other mobile platforms) is shown here in the "Known workarounds" section: #95295

@JeroenBer

JeroenBer commented Jun 3, 2024

Copy link
Copy Markdown

Well in that case please try to get this fix in the July servicing release.

@rzikmrzikm added the Servicing-consider Issue for next servicing release review label Jun 3, 2024
@rzikm

rzikm commented Jun 3, 2024•
edited by karelz
Loading

Copy link
Copy Markdown
Member

Approved via email on 6/3 and on 6/6 (with corrected customer info).

@rzikmrzikm added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 3, 2024
@rzikm
rzikm merged commit ca28411 into dotnet:release/8.0-stagingJun 4, 2024
@filipnavara
filipnavara deleted the backport-95898 branch June 4, 2024 07:57
@JeroenBer

JeroenBer commented Jun 7, 2024

Copy link
Copy Markdown

@rzikm this is merged into dotnet:release/8.0-staging I think, does this mean it will come into the next servicing release in July ?

For Android / iOS / macOS does this come available with a workload update for android / ios / macos or does this come available with a SDK update ?
I mean Android / iOS / macOS have their own runtimes or is this something that is shared between all runtimes ? Or is this not in the runtime ?

@wfurt

wfurt commented Jun 7, 2024

Copy link
Copy Markdown
Member

The libraries are shared across all runtimes. For Android, the managed implementation is the only one option because there is no GSSAPI. For iOS & macOS you need to subscribe to it.

@JeroenBer

JeroenBer commented Jun 7, 2024

Copy link
Copy Markdown

Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.

@wfurt

wfurt commented Jun 7, 2024

Copy link
Copy Markdown
Member

Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.

yes. cc @filipnavara just in case I missed something.

@filipnavara

filipnavara commented Jun 7, 2024

Copy link
Copy Markdown
MemberAuthor

It’s correct. SDK update is all that’s needed.

@karelzkarelz mentioned this pull request Jun 24, 2024
Closed
@karelzkarelz modified the milestones: 8.0.x, 8.0.7Jun 25, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 25, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@simonrozsivalsimonrozsivalsimonrozsival approved these changes
@rzikmrzikmrzikm approved these changes

Assignees

No one assigned

Labels

area-System.Net.Securitycommunity-contributionIndicates that the PR has been added by a community memberos-androidServicing-approvedApproved for servicing release

Projects

None yet

Milestone

8.0.7

Development

Successfully merging this pull request may close these issues.

7 participants

@filipnavara@rzikm@vitek-karas@JeroenBer@simonrozsival@wfurt@karelz
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation - #102565
Merged
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Jun 4, 2024
Merged
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation#102565
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Conversation
@filipnavara
@filipnavarafilipnavara
commented
May 22, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #95898 to release/8.0-staging
Fixes#95725
Customer Impact
Reported by customers in issue #95898 and by eM Client in #95725 (comment) - they cannot connect to Microsoft Exchange and quite a few other host providers on Android client (which uses ManagedNtlm by default).
Authenticating to HTTPS servers using NTLM fails with "Unauthorized" error code when Extended Authentication option is enabled on the server. This is an increasingly common setting on Microsoft Exchange deployments. The bug affects primarily the Android platform where the Managed NTLM implementation is used. We also allow the Managed NTLM as opt-in on macOS and Linux which would be likewise affected if the developer chooses to enable the System.Net.Security.UseManagedNtlm app context switch (which is rare).
Regression
No
Testing
Validated by eM Client on private Exchange instance in Azure VM + against one of the largest host providers in Germany.

The fix has been in .NET 9 since December 2023 and there were no observed issues.
Note: There are no unit tests, the set up is too complicated to test it meaningfully.
Risk
Low; the modified code path is in platform specific code for a single authentication scheme.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
May 22, 2024
@filipnavarafilipnavara
added
the 
Servicing-consider
Issue for next servicing release review
label
May 22, 2024
@filipnavara
filipnavara
commented
May 22, 2024

Copy link


Copy Markdown

MemberAuthor
/cc @rzikm@wfurt
We have another customer of our product affected by this issue. They provided a test account on their server and we verified that the fix resolves the issue.
@rzikmrzikm
removed
the 
Servicing-consider
Issue for next servicing release review
label
May 23, 2024
@rzikmrzikm
added this to the 8.0.x milestone
May 23, 2024
@rzikm
rzikm
commented
May 23, 2024

Copy link


Copy Markdown

Member
LGTM.
Removed Servicing-Consider for now, in case @karelz wants to edit the template first.
@filipnavarafilipnavara
mentioned this pull request
May 24, 2024

Closed

@vitek-karas
vitek-karas
commented
May 24, 2024

Copy link


Copy Markdown

Member
/fyi @simonrozsival
@JeroenBer
JeroenBer
commented
May 25, 2024

Copy link


Copy Markdown

Yes we urgently need this for our customers. Not only for Android but also iOS and macOS since the unmanaged implementations cause crashes and are not usable (#97966)
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones

See info in area-owners.md if you want to be subscribed.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm , not sure how this works but I see the PR is missing the "Servicing-approved" label before it can be merged. Who can do this ?
@rzikm
rzikm
commented
May 31, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@JeroenBer I am keeping eye on this issue. The earliest this fix can get released is in July servicing release, and deadline for that release is mid June, we are still on track for that release.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm Thanks for keeping an eye on this. A lot of our customers are waiting for this. July is still a long time but please let's make that. If there's anything we can do to speed this up, like creating a service case at Microsoft, then please let me know.
@rzikm
rzikm
commented
May 31, 2024

Copy link


Copy Markdown

Member
Creating a service case is unlikely to speed things up.
.NET has monthly cadence of servicing releases (with release dates coinciding with patch Tuesdays). Around the time one release is released, next one is branched off and starts to be prepared.
Restarting the process mid-way to include additional fixes would be costly (I don't know the figures, it's just my assumption based on my observations).
At any rate, there is potentially a way to unblock you and your customers earlier by using a private build of System.Net.Security.dll containing the fix. We use the process for validating that the fix is working. For desktop platforms the steps are simple (self-contained publish of the app+ overwriting the changed dll), I can provide you with the right dll for macOS if this option is available for you.
Unfortunately, I don't know if a similar process is possible for mobile platforms. Maybe @simonrozsival knows.
@simonrozsival
simonrozsival
commented
Jun 3, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Unfortunately, I don't know if a similar process is possible for mobile platforms.
It is possible to use custom runtime build in a mobile app, but I wouldn't recommend it. An example how to use custom dll on Android (or other mobile platforms) is shown here in the "Known workarounds" section: #95295
@JeroenBer
JeroenBer
commented
Jun 3, 2024

Copy link


Copy Markdown

Well in that case please try to get this fix in the July servicing release.
@rzikmrzikm
added
the 
Servicing-consider
Issue for next servicing release review
label
Jun 3, 2024
@rzikm
rzikm
commented
Jun 3, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Approved via email on 6/3 and on 6/6 (with corrected customer info).
@rzikmrzikm
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jun 3, 2024
@rzikm
rzikm
merged commit ca28411
into
dotnet:release/8.0-stagingJun 4, 2024
@filipnavara
filipnavara
deleted the

backport-95898

branch
June 4, 2024 07:57
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

@rzikm this is merged into dotnet:release/8.0-staging I think, does this mean it will come into the next servicing release in July ?
For Android / iOS / macOS does this come available with a workload update for android / ios / macos or does this come available with a SDK update ?

I mean Android / iOS / macOS have their own runtimes or is this something that is shared between all runtimes ? Or is this not in the runtime ?
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
The libraries are shared across all runtimes. For Android, the managed implementation is the only one option because there is no GSSAPI. For iOS & macOS you need to subscribe to it.
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
yes. cc @filipnavara just in case I missed something.
@filipnavara
filipnavara
commented
Jun 7, 2024

Copy link


Copy Markdown

MemberAuthor
It’s correct. SDK update is all that’s needed.
@karelzkarelz
mentioned this pull request
Jun 24, 2024

Closed

@karelzkarelz
modified the milestones:
8.0.x, 8.0.7Jun 25, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 25, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@simonrozsivalsimonrozsivalsimonrozsival approved these changes
@rzikmrzikmrzikm approved these changes

Assignees


No one assigned


Labels

area-System.Net.Securitycommunity-contributionIndicates that the PR has been added by a community memberos-androidServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.7

Development

Successfully merging this pull request may close these issues.

7 participants

@filipnavara@rzikm@vitek-karas@JeroenBer@simonrozsival@wfurt@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation - #102565
Merged
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Jun 4, 2024
Merged
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation#102565
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Conversation
@filipnavara
@filipnavarafilipnavara
commented
May 22, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #95898 to release/8.0-staging
Fixes#95725
Customer Impact
Reported by customers in issue #95898 and by eM Client in #95725 (comment) - they cannot connect to Microsoft Exchange and quite a few other host providers on Android client (which uses ManagedNtlm by default).
Authenticating to HTTPS servers using NTLM fails with "Unauthorized" error code when Extended Authentication option is enabled on the server. This is an increasingly common setting on Microsoft Exchange deployments. The bug affects primarily the Android platform where the Managed NTLM implementation is used. We also allow the Managed NTLM as opt-in on macOS and Linux which would be likewise affected if the developer chooses to enable the System.Net.Security.UseManagedNtlm app context switch (which is rare).
Regression
No
Testing
Validated by eM Client on private Exchange instance in Azure VM + against one of the largest host providers in Germany.

The fix has been in .NET 9 since December 2023 and there were no observed issues.
Note: There are no unit tests, the set up is too complicated to test it meaningfully.
Risk
Low; the modified code path is in platform specific code for a single authentication scheme.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
May 22, 2024
@filipnavarafilipnavara
added
the 
Servicing-consider
Issue for next servicing release review
label
May 22, 2024
@filipnavara
filipnavara
commented
May 22, 2024

Copy link


Copy Markdown

MemberAuthor
/cc @rzikm@wfurt
We have another customer of our product affected by this issue. They provided a test account on their server and we verified that the fix resolves the issue.
@rzikmrzikm
removed
the 
Servicing-consider
Issue for next servicing release review
label
May 23, 2024
@rzikmrzikm
added this to the 8.0.x milestone
May 23, 2024
@rzikm
rzikm
commented
May 23, 2024

Copy link


Copy Markdown

Member
LGTM.
Removed Servicing-Consider for now, in case @karelz wants to edit the template first.
@filipnavarafilipnavara
mentioned this pull request
May 24, 2024

Closed

@vitek-karas
vitek-karas
commented
May 24, 2024

Copy link


Copy Markdown

Member
/fyi @simonrozsival
@JeroenBer
JeroenBer
commented
May 25, 2024

Copy link


Copy Markdown

Yes we urgently need this for our customers. Not only for Android but also iOS and macOS since the unmanaged implementations cause crashes and are not usable (#97966)
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones

See info in area-owners.md if you want to be subscribed.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm , not sure how this works but I see the PR is missing the "Servicing-approved" label before it can be merged. Who can do this ?
@rzikm
rzikm
commented
May 31, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@JeroenBer I am keeping eye on this issue. The earliest this fix can get released is in July servicing release, and deadline for that release is mid June, we are still on track for that release.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm Thanks for keeping an eye on this. A lot of our customers are waiting for this. July is still a long time but please let's make that. If there's anything we can do to speed this up, like creating a service case at Microsoft, then please let me know.
@rzikm
rzikm
commented
May 31, 2024

Copy link


Copy Markdown

Member
Creating a service case is unlikely to speed things up.
.NET has monthly cadence of servicing releases (with release dates coinciding with patch Tuesdays). Around the time one release is released, next one is branched off and starts to be prepared.
Restarting the process mid-way to include additional fixes would be costly (I don't know the figures, it's just my assumption based on my observations).
At any rate, there is potentially a way to unblock you and your customers earlier by using a private build of System.Net.Security.dll containing the fix. We use the process for validating that the fix is working. For desktop platforms the steps are simple (self-contained publish of the app+ overwriting the changed dll), I can provide you with the right dll for macOS if this option is available for you.
Unfortunately, I don't know if a similar process is possible for mobile platforms. Maybe @simonrozsival knows.
@simonrozsival
simonrozsival
commented
Jun 3, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Unfortunately, I don't know if a similar process is possible for mobile platforms.
It is possible to use custom runtime build in a mobile app, but I wouldn't recommend it. An example how to use custom dll on Android (or other mobile platforms) is shown here in the "Known workarounds" section: #95295
@JeroenBer
JeroenBer
commented
Jun 3, 2024

Copy link


Copy Markdown

Well in that case please try to get this fix in the July servicing release.
@rzikmrzikm
added
the 
Servicing-consider
Issue for next servicing release review
label
Jun 3, 2024
@rzikm
rzikm
commented
Jun 3, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Approved via email on 6/3 and on 6/6 (with corrected customer info).
@rzikmrzikm
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jun 3, 2024
@rzikm
rzikm
merged commit ca28411
into
dotnet:release/8.0-stagingJun 4, 2024
@filipnavara
filipnavara
deleted the

backport-95898

branch
June 4, 2024 07:57
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

@rzikm this is merged into dotnet:release/8.0-staging I think, does this mean it will come into the next servicing release in July ?
For Android / iOS / macOS does this come available with a workload update for android / ios / macos or does this come available with a SDK update ?

I mean Android / iOS / macOS have their own runtimes or is this something that is shared between all runtimes ? Or is this not in the runtime ?
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
The libraries are shared across all runtimes. For Android, the managed implementation is the only one option because there is no GSSAPI. For iOS & macOS you need to subscribe to it.
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
yes. cc @filipnavara just in case I missed something.
@filipnavara
filipnavara
commented
Jun 7, 2024

Copy link


Copy Markdown

MemberAuthor
It’s correct. SDK update is all that’s needed.
@karelzkarelz
mentioned this pull request
Jun 24, 2024

Closed

@karelzkarelz
modified the milestones:
8.0.x, 8.0.7Jun 25, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 25, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@simonrozsivalsimonrozsivalsimonrozsival approved these changes
@rzikmrzikmrzikm approved these changes

Assignees


No one assigned


Labels

area-System.Net.Securitycommunity-contributionIndicates that the PR has been added by a community memberos-androidServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.7

Development

Successfully merging this pull request may close these issues.

7 participants

@filipnavara@rzikm@vitek-karas@JeroenBer@simonrozsival@wfurt@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation - #102565
Merged
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Jun 4, 2024
Merged
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation#102565
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Conversation
@filipnavara
@filipnavarafilipnavara
commented
May 22, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #95898 to release/8.0-staging
Fixes#95725
Customer Impact
Reported by customers in issue #95898 and by eM Client in #95725 (comment) - they cannot connect to Microsoft Exchange and quite a few other host providers on Android client (which uses ManagedNtlm by default).
Authenticating to HTTPS servers using NTLM fails with "Unauthorized" error code when Extended Authentication option is enabled on the server. This is an increasingly common setting on Microsoft Exchange deployments. The bug affects primarily the Android platform where the Managed NTLM implementation is used. We also allow the Managed NTLM as opt-in on macOS and Linux which would be likewise affected if the developer chooses to enable the System.Net.Security.UseManagedNtlm app context switch (which is rare).
Regression
No
Testing
Validated by eM Client on private Exchange instance in Azure VM + against one of the largest host providers in Germany.

The fix has been in .NET 9 since December 2023 and there were no observed issues.
Note: There are no unit tests, the set up is too complicated to test it meaningfully.
Risk
Low; the modified code path is in platform specific code for a single authentication scheme.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
May 22, 2024
@filipnavarafilipnavara
added
the 
Servicing-consider
Issue for next servicing release review
label
May 22, 2024
@filipnavara
filipnavara
commented
May 22, 2024

Copy link


Copy Markdown

MemberAuthor
/cc @rzikm@wfurt
We have another customer of our product affected by this issue. They provided a test account on their server and we verified that the fix resolves the issue.
@rzikmrzikm
removed
the 
Servicing-consider
Issue for next servicing release review
label
May 23, 2024
@rzikmrzikm
added this to the 8.0.x milestone
May 23, 2024
@rzikm
rzikm
commented
May 23, 2024

Copy link


Copy Markdown

Member
LGTM.
Removed Servicing-Consider for now, in case @karelz wants to edit the template first.
@filipnavarafilipnavara
mentioned this pull request
May 24, 2024

Closed

@vitek-karas
vitek-karas
commented
May 24, 2024

Copy link


Copy Markdown

Member
/fyi @simonrozsival
@JeroenBer
JeroenBer
commented
May 25, 2024

Copy link


Copy Markdown

Yes we urgently need this for our customers. Not only for Android but also iOS and macOS since the unmanaged implementations cause crashes and are not usable (#97966)
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones

See info in area-owners.md if you want to be subscribed.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm , not sure how this works but I see the PR is missing the "Servicing-approved" label before it can be merged. Who can do this ?
@rzikm
rzikm
commented
May 31, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@JeroenBer I am keeping eye on this issue. The earliest this fix can get released is in July servicing release, and deadline for that release is mid June, we are still on track for that release.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm Thanks for keeping an eye on this. A lot of our customers are waiting for this. July is still a long time but please let's make that. If there's anything we can do to speed this up, like creating a service case at Microsoft, then please let me know.
@rzikm
rzikm
commented
May 31, 2024

Copy link


Copy Markdown

Member
Creating a service case is unlikely to speed things up.
.NET has monthly cadence of servicing releases (with release dates coinciding with patch Tuesdays). Around the time one release is released, next one is branched off and starts to be prepared.
Restarting the process mid-way to include additional fixes would be costly (I don't know the figures, it's just my assumption based on my observations).
At any rate, there is potentially a way to unblock you and your customers earlier by using a private build of System.Net.Security.dll containing the fix. We use the process for validating that the fix is working. For desktop platforms the steps are simple (self-contained publish of the app+ overwriting the changed dll), I can provide you with the right dll for macOS if this option is available for you.
Unfortunately, I don't know if a similar process is possible for mobile platforms. Maybe @simonrozsival knows.
@simonrozsival
simonrozsival
commented
Jun 3, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Unfortunately, I don't know if a similar process is possible for mobile platforms.
It is possible to use custom runtime build in a mobile app, but I wouldn't recommend it. An example how to use custom dll on Android (or other mobile platforms) is shown here in the "Known workarounds" section: #95295
@JeroenBer
JeroenBer
commented
Jun 3, 2024

Copy link


Copy Markdown

Well in that case please try to get this fix in the July servicing release.
@rzikmrzikm
added
the 
Servicing-consider
Issue for next servicing release review
label
Jun 3, 2024
@rzikm
rzikm
commented
Jun 3, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Approved via email on 6/3 and on 6/6 (with corrected customer info).
@rzikmrzikm
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jun 3, 2024
@rzikm
rzikm
merged commit ca28411
into
dotnet:release/8.0-stagingJun 4, 2024
@filipnavara
filipnavara
deleted the

backport-95898

branch
June 4, 2024 07:57
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

@rzikm this is merged into dotnet:release/8.0-staging I think, does this mean it will come into the next servicing release in July ?
For Android / iOS / macOS does this come available with a workload update for android / ios / macos or does this come available with a SDK update ?

I mean Android / iOS / macOS have their own runtimes or is this something that is shared between all runtimes ? Or is this not in the runtime ?
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
The libraries are shared across all runtimes. For Android, the managed implementation is the only one option because there is no GSSAPI. For iOS & macOS you need to subscribe to it.
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
yes. cc @filipnavara just in case I missed something.
@filipnavara
filipnavara
commented
Jun 7, 2024

Copy link


Copy Markdown

MemberAuthor
It’s correct. SDK update is all that’s needed.
@karelzkarelz
mentioned this pull request
Jun 24, 2024

Closed

@karelzkarelz
modified the milestones:
8.0.x, 8.0.7Jun 25, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 25, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@simonrozsivalsimonrozsivalsimonrozsival approved these changes
@rzikmrzikmrzikm approved these changes

Assignees


No one assigned


Labels

area-System.Net.Securitycommunity-contributionIndicates that the PR has been added by a community memberos-androidServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.7

Development

Successfully merging this pull request may close these issues.

7 participants

@filipnavara@rzikm@vitek-karas@JeroenBer@simonrozsival@wfurt@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation - #102565
Merged
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Jun 4, 2024
Merged
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation#102565
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Conversation
@filipnavara
@filipnavarafilipnavara
commented
May 22, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #95898 to release/8.0-staging
Fixes#95725
Customer Impact
Reported by customers in issue #95898 and by eM Client in #95725 (comment) - they cannot connect to Microsoft Exchange and quite a few other host providers on Android client (which uses ManagedNtlm by default).
Authenticating to HTTPS servers using NTLM fails with "Unauthorized" error code when Extended Authentication option is enabled on the server. This is an increasingly common setting on Microsoft Exchange deployments. The bug affects primarily the Android platform where the Managed NTLM implementation is used. We also allow the Managed NTLM as opt-in on macOS and Linux which would be likewise affected if the developer chooses to enable the System.Net.Security.UseManagedNtlm app context switch (which is rare).
Regression
No
Testing
Validated by eM Client on private Exchange instance in Azure VM + against one of the largest host providers in Germany.

The fix has been in .NET 9 since December 2023 and there were no observed issues.
Note: There are no unit tests, the set up is too complicated to test it meaningfully.
Risk
Low; the modified code path is in platform specific code for a single authentication scheme.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
May 22, 2024
@filipnavarafilipnavara
added
the 
Servicing-consider
Issue for next servicing release review
label
May 22, 2024
@filipnavara
filipnavara
commented
May 22, 2024

Copy link


Copy Markdown

MemberAuthor
/cc @rzikm@wfurt
We have another customer of our product affected by this issue. They provided a test account on their server and we verified that the fix resolves the issue.
@rzikmrzikm
removed
the 
Servicing-consider
Issue for next servicing release review
label
May 23, 2024
@rzikmrzikm
added this to the 8.0.x milestone
May 23, 2024
@rzikm
rzikm
commented
May 23, 2024

Copy link


Copy Markdown

Member
LGTM.
Removed Servicing-Consider for now, in case @karelz wants to edit the template first.
@filipnavarafilipnavara
mentioned this pull request
May 24, 2024

Closed

@vitek-karas
vitek-karas
commented
May 24, 2024

Copy link


Copy Markdown

Member
/fyi @simonrozsival
@JeroenBer
JeroenBer
commented
May 25, 2024

Copy link


Copy Markdown

Yes we urgently need this for our customers. Not only for Android but also iOS and macOS since the unmanaged implementations cause crashes and are not usable (#97966)
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones

See info in area-owners.md if you want to be subscribed.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm , not sure how this works but I see the PR is missing the "Servicing-approved" label before it can be merged. Who can do this ?
@rzikm
rzikm
commented
May 31, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@JeroenBer I am keeping eye on this issue. The earliest this fix can get released is in July servicing release, and deadline for that release is mid June, we are still on track for that release.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm Thanks for keeping an eye on this. A lot of our customers are waiting for this. July is still a long time but please let's make that. If there's anything we can do to speed this up, like creating a service case at Microsoft, then please let me know.
@rzikm
rzikm
commented
May 31, 2024

Copy link


Copy Markdown

Member
Creating a service case is unlikely to speed things up.
.NET has monthly cadence of servicing releases (with release dates coinciding with patch Tuesdays). Around the time one release is released, next one is branched off and starts to be prepared.
Restarting the process mid-way to include additional fixes would be costly (I don't know the figures, it's just my assumption based on my observations).
At any rate, there is potentially a way to unblock you and your customers earlier by using a private build of System.Net.Security.dll containing the fix. We use the process for validating that the fix is working. For desktop platforms the steps are simple (self-contained publish of the app+ overwriting the changed dll), I can provide you with the right dll for macOS if this option is available for you.
Unfortunately, I don't know if a similar process is possible for mobile platforms. Maybe @simonrozsival knows.
@simonrozsival
simonrozsival
commented
Jun 3, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Unfortunately, I don't know if a similar process is possible for mobile platforms.
It is possible to use custom runtime build in a mobile app, but I wouldn't recommend it. An example how to use custom dll on Android (or other mobile platforms) is shown here in the "Known workarounds" section: #95295
@JeroenBer
JeroenBer
commented
Jun 3, 2024

Copy link


Copy Markdown

Well in that case please try to get this fix in the July servicing release.
@rzikmrzikm
added
the 
Servicing-consider
Issue for next servicing release review
label
Jun 3, 2024
@rzikm
rzikm
commented
Jun 3, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Approved via email on 6/3 and on 6/6 (with corrected customer info).
@rzikmrzikm
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jun 3, 2024
@rzikm
rzikm
merged commit ca28411
into
dotnet:release/8.0-stagingJun 4, 2024
@filipnavara
filipnavara
deleted the

backport-95898

branch
June 4, 2024 07:57
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

@rzikm this is merged into dotnet:release/8.0-staging I think, does this mean it will come into the next servicing release in July ?
For Android / iOS / macOS does this come available with a workload update for android / ios / macos or does this come available with a SDK update ?

I mean Android / iOS / macOS have their own runtimes or is this something that is shared between all runtimes ? Or is this not in the runtime ?
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
The libraries are shared across all runtimes. For Android, the managed implementation is the only one option because there is no GSSAPI. For iOS & macOS you need to subscribe to it.
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
yes. cc @filipnavara just in case I missed something.
@filipnavara
filipnavara
commented
Jun 7, 2024

Copy link


Copy Markdown

MemberAuthor
It’s correct. SDK update is all that’s needed.
@karelzkarelz
mentioned this pull request
Jun 24, 2024

Closed

@karelzkarelz
modified the milestones:
8.0.x, 8.0.7Jun 25, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 25, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@simonrozsivalsimonrozsivalsimonrozsival approved these changes
@rzikmrzikmrzikm approved these changes

Assignees


No one assigned


Labels

area-System.Net.Securitycommunity-contributionIndicates that the PR has been added by a community memberos-androidServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.7

Development

Successfully merging this pull request may close these issues.

7 participants

@filipnavara@rzikm@vitek-karas@JeroenBer@simonrozsival@wfurt@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation - #102565
Merged
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Jun 4, 2024
Merged
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation#102565
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Conversation
@filipnavara
@filipnavarafilipnavara
commented
May 22, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #95898 to release/8.0-staging
Fixes#95725
Customer Impact
Reported by customers in issue #95898 and by eM Client in #95725 (comment) - they cannot connect to Microsoft Exchange and quite a few other host providers on Android client (which uses ManagedNtlm by default).
Authenticating to HTTPS servers using NTLM fails with "Unauthorized" error code when Extended Authentication option is enabled on the server. This is an increasingly common setting on Microsoft Exchange deployments. The bug affects primarily the Android platform where the Managed NTLM implementation is used. We also allow the Managed NTLM as opt-in on macOS and Linux which would be likewise affected if the developer chooses to enable the System.Net.Security.UseManagedNtlm app context switch (which is rare).
Regression
No
Testing
Validated by eM Client on private Exchange instance in Azure VM + against one of the largest host providers in Germany.

The fix has been in .NET 9 since December 2023 and there were no observed issues.
Note: There are no unit tests, the set up is too complicated to test it meaningfully.
Risk
Low; the modified code path is in platform specific code for a single authentication scheme.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
May 22, 2024
@filipnavarafilipnavara
added
the 
Servicing-consider
Issue for next servicing release review
label
May 22, 2024
@filipnavara
filipnavara
commented
May 22, 2024

Copy link


Copy Markdown

MemberAuthor
/cc @rzikm@wfurt
We have another customer of our product affected by this issue. They provided a test account on their server and we verified that the fix resolves the issue.
@rzikmrzikm
removed
the 
Servicing-consider
Issue for next servicing release review
label
May 23, 2024
@rzikmrzikm
added this to the 8.0.x milestone
May 23, 2024
@rzikm
rzikm
commented
May 23, 2024

Copy link


Copy Markdown

Member
LGTM.
Removed Servicing-Consider for now, in case @karelz wants to edit the template first.
@filipnavarafilipnavara
mentioned this pull request
May 24, 2024

Closed

@vitek-karas
vitek-karas
commented
May 24, 2024

Copy link


Copy Markdown

Member
/fyi @simonrozsival
@JeroenBer
JeroenBer
commented
May 25, 2024

Copy link


Copy Markdown

Yes we urgently need this for our customers. Not only for Android but also iOS and macOS since the unmanaged implementations cause crashes and are not usable (#97966)
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones

See info in area-owners.md if you want to be subscribed.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm , not sure how this works but I see the PR is missing the "Servicing-approved" label before it can be merged. Who can do this ?
@rzikm
rzikm
commented
May 31, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@JeroenBer I am keeping eye on this issue. The earliest this fix can get released is in July servicing release, and deadline for that release is mid June, we are still on track for that release.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm Thanks for keeping an eye on this. A lot of our customers are waiting for this. July is still a long time but please let's make that. If there's anything we can do to speed this up, like creating a service case at Microsoft, then please let me know.
@rzikm
rzikm
commented
May 31, 2024

Copy link


Copy Markdown

Member
Creating a service case is unlikely to speed things up.
.NET has monthly cadence of servicing releases (with release dates coinciding with patch Tuesdays). Around the time one release is released, next one is branched off and starts to be prepared.
Restarting the process mid-way to include additional fixes would be costly (I don't know the figures, it's just my assumption based on my observations).
At any rate, there is potentially a way to unblock you and your customers earlier by using a private build of System.Net.Security.dll containing the fix. We use the process for validating that the fix is working. For desktop platforms the steps are simple (self-contained publish of the app+ overwriting the changed dll), I can provide you with the right dll for macOS if this option is available for you.
Unfortunately, I don't know if a similar process is possible for mobile platforms. Maybe @simonrozsival knows.
@simonrozsival
simonrozsival
commented
Jun 3, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Unfortunately, I don't know if a similar process is possible for mobile platforms.
It is possible to use custom runtime build in a mobile app, but I wouldn't recommend it. An example how to use custom dll on Android (or other mobile platforms) is shown here in the "Known workarounds" section: #95295
@JeroenBer
JeroenBer
commented
Jun 3, 2024

Copy link


Copy Markdown

Well in that case please try to get this fix in the July servicing release.
@rzikmrzikm
added
the 
Servicing-consider
Issue for next servicing release review
label
Jun 3, 2024
@rzikm
rzikm
commented
Jun 3, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Approved via email on 6/3 and on 6/6 (with corrected customer info).
@rzikmrzikm
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jun 3, 2024
@rzikm
rzikm
merged commit ca28411
into
dotnet:release/8.0-stagingJun 4, 2024
@filipnavara
filipnavara
deleted the

backport-95898

branch
June 4, 2024 07:57
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

@rzikm this is merged into dotnet:release/8.0-staging I think, does this mean it will come into the next servicing release in July ?
For Android / iOS / macOS does this come available with a workload update for android / ios / macos or does this come available with a SDK update ?

I mean Android / iOS / macOS have their own runtimes or is this something that is shared between all runtimes ? Or is this not in the runtime ?
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
The libraries are shared across all runtimes. For Android, the managed implementation is the only one option because there is no GSSAPI. For iOS & macOS you need to subscribe to it.
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
yes. cc @filipnavara just in case I missed something.
@filipnavara
filipnavara
commented
Jun 7, 2024

Copy link


Copy Markdown

MemberAuthor
It’s correct. SDK update is all that’s needed.
@karelzkarelz
mentioned this pull request
Jun 24, 2024

Closed

@karelzkarelz
modified the milestones:
8.0.x, 8.0.7Jun 25, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 25, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@simonrozsivalsimonrozsivalsimonrozsival approved these changes
@rzikmrzikmrzikm approved these changes

Assignees


No one assigned


Labels

area-System.Net.Securitycommunity-contributionIndicates that the PR has been added by a community memberos-androidServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.7

Development

Successfully merging this pull request may close these issues.

7 participants

@filipnavara@rzikm@vitek-karas@JeroenBer@simonrozsival@wfurt@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation - #102565
Merged
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Jun 4, 2024
Merged
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation#102565
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Conversation
@filipnavara
@filipnavarafilipnavara
commented
May 22, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #95898 to release/8.0-staging
Fixes#95725
Customer Impact
Reported by customers in issue #95898 and by eM Client in #95725 (comment) - they cannot connect to Microsoft Exchange and quite a few other host providers on Android client (which uses ManagedNtlm by default).
Authenticating to HTTPS servers using NTLM fails with "Unauthorized" error code when Extended Authentication option is enabled on the server. This is an increasingly common setting on Microsoft Exchange deployments. The bug affects primarily the Android platform where the Managed NTLM implementation is used. We also allow the Managed NTLM as opt-in on macOS and Linux which would be likewise affected if the developer chooses to enable the System.Net.Security.UseManagedNtlm app context switch (which is rare).
Regression
No
Testing
Validated by eM Client on private Exchange instance in Azure VM + against one of the largest host providers in Germany.

The fix has been in .NET 9 since December 2023 and there were no observed issues.
Note: There are no unit tests, the set up is too complicated to test it meaningfully.
Risk
Low; the modified code path is in platform specific code for a single authentication scheme.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
May 22, 2024
@filipnavarafilipnavara
added
the 
Servicing-consider
Issue for next servicing release review
label
May 22, 2024
@filipnavara
filipnavara
commented
May 22, 2024

Copy link


Copy Markdown

MemberAuthor
/cc @rzikm@wfurt
We have another customer of our product affected by this issue. They provided a test account on their server and we verified that the fix resolves the issue.
@rzikmrzikm
removed
the 
Servicing-consider
Issue for next servicing release review
label
May 23, 2024
@rzikmrzikm
added this to the 8.0.x milestone
May 23, 2024
@rzikm
rzikm
commented
May 23, 2024

Copy link


Copy Markdown

Member
LGTM.
Removed Servicing-Consider for now, in case @karelz wants to edit the template first.
@filipnavarafilipnavara
mentioned this pull request
May 24, 2024

Closed

@vitek-karas
vitek-karas
commented
May 24, 2024

Copy link


Copy Markdown

Member
/fyi @simonrozsival
@JeroenBer
JeroenBer
commented
May 25, 2024

Copy link


Copy Markdown

Yes we urgently need this for our customers. Not only for Android but also iOS and macOS since the unmanaged implementations cause crashes and are not usable (#97966)
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones

See info in area-owners.md if you want to be subscribed.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm , not sure how this works but I see the PR is missing the "Servicing-approved" label before it can be merged. Who can do this ?
@rzikm
rzikm
commented
May 31, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@JeroenBer I am keeping eye on this issue. The earliest this fix can get released is in July servicing release, and deadline for that release is mid June, we are still on track for that release.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm Thanks for keeping an eye on this. A lot of our customers are waiting for this. July is still a long time but please let's make that. If there's anything we can do to speed this up, like creating a service case at Microsoft, then please let me know.
@rzikm
rzikm
commented
May 31, 2024

Copy link


Copy Markdown

Member
Creating a service case is unlikely to speed things up.
.NET has monthly cadence of servicing releases (with release dates coinciding with patch Tuesdays). Around the time one release is released, next one is branched off and starts to be prepared.
Restarting the process mid-way to include additional fixes would be costly (I don't know the figures, it's just my assumption based on my observations).
At any rate, there is potentially a way to unblock you and your customers earlier by using a private build of System.Net.Security.dll containing the fix. We use the process for validating that the fix is working. For desktop platforms the steps are simple (self-contained publish of the app+ overwriting the changed dll), I can provide you with the right dll for macOS if this option is available for you.
Unfortunately, I don't know if a similar process is possible for mobile platforms. Maybe @simonrozsival knows.
@simonrozsival
simonrozsival
commented
Jun 3, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Unfortunately, I don't know if a similar process is possible for mobile platforms.
It is possible to use custom runtime build in a mobile app, but I wouldn't recommend it. An example how to use custom dll on Android (or other mobile platforms) is shown here in the "Known workarounds" section: #95295
@JeroenBer
JeroenBer
commented
Jun 3, 2024

Copy link


Copy Markdown

Well in that case please try to get this fix in the July servicing release.
@rzikmrzikm
added
the 
Servicing-consider
Issue for next servicing release review
label
Jun 3, 2024
@rzikm
rzikm
commented
Jun 3, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Approved via email on 6/3 and on 6/6 (with corrected customer info).
@rzikmrzikm
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jun 3, 2024
@rzikm
rzikm
merged commit ca28411
into
dotnet:release/8.0-stagingJun 4, 2024
@filipnavara
filipnavara
deleted the

backport-95898

branch
June 4, 2024 07:57
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

@rzikm this is merged into dotnet:release/8.0-staging I think, does this mean it will come into the next servicing release in July ?
For Android / iOS / macOS does this come available with a workload update for android / ios / macos or does this come available with a SDK update ?

I mean Android / iOS / macOS have their own runtimes or is this something that is shared between all runtimes ? Or is this not in the runtime ?
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
The libraries are shared across all runtimes. For Android, the managed implementation is the only one option because there is no GSSAPI. For iOS & macOS you need to subscribe to it.
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
yes. cc @filipnavara just in case I missed something.
@filipnavara
filipnavara
commented
Jun 7, 2024

Copy link


Copy Markdown

MemberAuthor
It’s correct. SDK update is all that’s needed.
@karelzkarelz
mentioned this pull request
Jun 24, 2024

Closed

@karelzkarelz
modified the milestones:
8.0.x, 8.0.7Jun 25, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 25, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@simonrozsivalsimonrozsivalsimonrozsival approved these changes
@rzikmrzikmrzikm approved these changes

Assignees


No one assigned


Labels

area-System.Net.Securitycommunity-contributionIndicates that the PR has been added by a community memberos-androidServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.7

Development

Successfully merging this pull request may close these issues.

7 participants

@filipnavara@rzikm@vitek-karas@JeroenBer@simonrozsival@wfurt@karelz

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation - #102565
Merged
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Jun 4, 2024
Merged
[release/8.0-staging] Fix calculation of channel bindings hash in managed NTLM implementation#102565
rzikm merged 1 commit into
dotnet:release/8.0-stagingfrom 
filipnavara:backport-95898
Conversation
@filipnavara
@filipnavarafilipnavara
commented
May 22, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Backport of #95898 to release/8.0-staging
Fixes#95725
Customer Impact
Reported by customers in issue #95898 and by eM Client in #95725 (comment) - they cannot connect to Microsoft Exchange and quite a few other host providers on Android client (which uses ManagedNtlm by default).
Authenticating to HTTPS servers using NTLM fails with "Unauthorized" error code when Extended Authentication option is enabled on the server. This is an increasingly common setting on Microsoft Exchange deployments. The bug affects primarily the Android platform where the Managed NTLM implementation is used. We also allow the Managed NTLM as opt-in on macOS and Linux which would be likewise affected if the developer chooses to enable the System.Net.Security.UseManagedNtlm app context switch (which is rare).
Regression
No
Testing
Validated by eM Client on private Exchange instance in Azure VM + against one of the largest host providers in Germany.

The fix has been in .NET 9 since December 2023 and there were no observed issues.
Note: There are no unit tests, the set up is too complicated to test it meaningfully.
Risk
Low; the modified code path is in platform specific code for a single authentication scheme.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
May 22, 2024
@filipnavarafilipnavara
added
the 
Servicing-consider
Issue for next servicing release review
label
May 22, 2024
@filipnavara
filipnavara
commented
May 22, 2024

Copy link


Copy Markdown

MemberAuthor
/cc @rzikm@wfurt
We have another customer of our product affected by this issue. They provided a test account on their server and we verified that the fix resolves the issue.
@rzikmrzikm
removed
the 
Servicing-consider
Issue for next servicing release review
label
May 23, 2024
@rzikmrzikm
added this to the 8.0.x milestone
May 23, 2024
@rzikm
rzikm
commented
May 23, 2024

Copy link


Copy Markdown

Member
LGTM.
Removed Servicing-Consider for now, in case @karelz wants to edit the template first.
@filipnavarafilipnavara
mentioned this pull request
May 24, 2024

Closed

@vitek-karas
vitek-karas
commented
May 24, 2024

Copy link


Copy Markdown

Member
/fyi @simonrozsival
@JeroenBer
JeroenBer
commented
May 25, 2024

Copy link


Copy Markdown

Yes we urgently need this for our customers. Not only for Android but also iOS and macOS since the unmanaged implementations cause crashes and are not usable (#97966)
@dotnet-policy-service
dotnet-policy-serviceBot
commented
May 29, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones

See info in area-owners.md if you want to be subscribed.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm , not sure how this works but I see the PR is missing the "Servicing-approved" label before it can be merged. Who can do this ?
@rzikm
rzikm
commented
May 31, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@JeroenBer I am keeping eye on this issue. The earliest this fix can get released is in July servicing release, and deadline for that release is mid June, we are still on track for that release.
@JeroenBer
JeroenBer
commented
May 31, 2024

Copy link


Copy Markdown

@rzikm Thanks for keeping an eye on this. A lot of our customers are waiting for this. July is still a long time but please let's make that. If there's anything we can do to speed this up, like creating a service case at Microsoft, then please let me know.
@rzikm
rzikm
commented
May 31, 2024

Copy link


Copy Markdown

Member
Creating a service case is unlikely to speed things up.
.NET has monthly cadence of servicing releases (with release dates coinciding with patch Tuesdays). Around the time one release is released, next one is branched off and starts to be prepared.
Restarting the process mid-way to include additional fixes would be costly (I don't know the figures, it's just my assumption based on my observations).
At any rate, there is potentially a way to unblock you and your customers earlier by using a private build of System.Net.Security.dll containing the fix. We use the process for validating that the fix is working. For desktop platforms the steps are simple (self-contained publish of the app+ overwriting the changed dll), I can provide you with the right dll for macOS if this option is available for you.
Unfortunately, I don't know if a similar process is possible for mobile platforms. Maybe @simonrozsival knows.
@simonrozsival
simonrozsival
commented
Jun 3, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Unfortunately, I don't know if a similar process is possible for mobile platforms.
It is possible to use custom runtime build in a mobile app, but I wouldn't recommend it. An example how to use custom dll on Android (or other mobile platforms) is shown here in the "Known workarounds" section: #95295
@JeroenBer
JeroenBer
commented
Jun 3, 2024

Copy link


Copy Markdown

Well in that case please try to get this fix in the July servicing release.
@rzikmrzikm
added
the 
Servicing-consider
Issue for next servicing release review
label
Jun 3, 2024
@rzikm
rzikm
commented
Jun 3, 2024•

edited by karelz

Loading

Copy link


Copy Markdown

Member
Approved via email on 6/3 and on 6/6 (with corrected customer info).
@rzikmrzikm
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Jun 3, 2024
@rzikm
rzikm
merged commit ca28411
into
dotnet:release/8.0-stagingJun 4, 2024
@filipnavara
filipnavara
deleted the

backport-95898

branch
June 4, 2024 07:57
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

@rzikm this is merged into dotnet:release/8.0-staging I think, does this mean it will come into the next servicing release in July ?
For Android / iOS / macOS does this come available with a workload update for android / ios / macos or does this come available with a SDK update ?

I mean Android / iOS / macOS have their own runtimes or is this something that is shared between all runtimes ? Or is this not in the runtime ?
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
The libraries are shared across all runtimes. For Android, the managed implementation is the only one option because there is no GSSAPI. For iOS & macOS you need to subscribe to it.
@JeroenBer
JeroenBer
commented
Jun 7, 2024

Copy link


Copy Markdown

Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
@wfurt
wfurt
commented
Jun 7, 2024

Copy link


Copy Markdown

Member
Thanks for the info, so just updating the SDK and rebuilding would be enough then ? No need to update workloads for android etc. For iOS / macOS we opted in for managed NTLM.
yes. cc @filipnavara just in case I missed something.
@filipnavara
filipnavara
commented
Jun 7, 2024

Copy link


Copy Markdown

MemberAuthor
It’s correct. SDK update is all that’s needed.
@karelzkarelz
mentioned this pull request
Jun 24, 2024

Closed

@karelzkarelz
modified the milestones:
8.0.x, 8.0.7Jun 25, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 25, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@simonrozsivalsimonrozsivalsimonrozsival approved these changes
@rzikmrzikmrzikm approved these changes

Assignees


No one assigned


Labels

area-System.Net.Securitycommunity-contributionIndicates that the PR has been added by a community memberos-androidServicing-approvedApproved for servicing release

Projects


None yet


Milestone

8.0.7

Development

Successfully merging this pull request may close these issues.

7 participants

@filipnavara@rzikm@vitek-karas@JeroenBer@simonrozsival@wfurt@karelz