Skip to content

Update SDK to 9.0 preview 4 - #102604

Merged
ViktorHofer merged 9 commits into
dotnet:mainfrom
am11:feature/sdk-update/9.0-preview4
May 27, 2024
Merged

Update SDK to 9.0 preview 4#102604
ViktorHofer merged 9 commits into
dotnet:mainfrom
am11:feature/sdk-update/9.0-preview4

Conversation

@am11

@am11am11 commented May 23, 2024

Copy link
Copy Markdown
Member

No description provided.

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 23, 2024
@am11am11 changed the title Update SDK to preview 4Update SDK to 9.0 preview 4May 23, 2024
@am11am11 added area-Infrastructure community-contribution Indicates that the PR has been added by a community member and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 23, 2024
ilonatommy
ilonatommy reviewed May 23, 2024
View reviewed changes

@ilonatommyilonatommy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places with pinned versions:

@am11

am11 commented May 23, 2024

Copy link
Copy Markdown
MemberAuthor

Sure, will update those as well. I was mainly following @MichalStrehovsky's footsteps #100945 (which made me think only to grep 9.*preview.3, find versions on the internets and replace) 😅

am11
am11 commented May 23, 2024
View reviewed changes
Comment threadeng/Version.Details.xml Outdated
@am11

am11 commented May 23, 2024

Copy link
Copy Markdown
MemberAuthor

Build wasi-wasm linux Release WasmBuildTests is failing with:

 Discovered: Wasi.Build.Tests (found 1 of 11 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_fkeubaml_415] You must install or update .NET to run this application.
[Release_fkeubaml_415] [Release_fkeubaml_415] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_fkeubaml_415] Architecture: x64
[Release_fkeubaml_415] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.4.24266.19' (x64)
[Release_fkeubaml_415] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_fkeubaml_415] [Release_fkeubaml_415] The following frameworks were found:
[Release_fkeubaml_415] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] 9.0.0-preview.4.24251.3 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] [Release_fkeubaml_415] Learn more:
[Release_fkeubaml_415] https://aka.ms/dotnet/app-launch-failed
[Release_fkeubaml_415] [Release_fkeubaml_415] To install missing framework, download:
[Release_fkeubaml_415] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.4.24266.19&arch=x64&rid=linux-x64&os=ubuntu.22.04
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(44,0): at Wasm.Build.Tests.CommandResult.EnsureExitCode(Int32 expectedExitCode, String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(28,0): at Wasm.Build.Tests.CommandResult.EnsureSuccessful(String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasi/Wasi.Build.Tests/ILStripTests.cs(52,0): at Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(String stripILAfterAOT, Boolean expectILStripping, Boolean singleFileBundle)

@ilonatommy, is there anything else which needs to be updated before preview.1 -> preview.4 switch is possible for Wasm.Build.Tests?

@build-analysisbuild-analysisBot mentioned this pull request May 23, 2024
Closed
@am11

am11 commented May 23, 2024

Copy link
Copy Markdown
MemberAuthor

Build wasi-wasm linux Release WasmBuildTests is failing with:

Applied @lewing's #102624 as a patch and it fixed the error. 👏
(lets wait until that one is landed then I'll revert and merge main)

sbomer
sbomer reviewed May 23, 2024
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
@am11am11 mentioned this pull request May 24, 2024
Closed
@am11
am11force-pushed the feature/sdk-update/9.0-preview4 branch from 7dbbef4 to 2a12d10CompareMay 24, 2024 19:16
@am11

am11 commented May 25, 2024

Copy link
Copy Markdown
MemberAuthor

@lewing looks like #100275 is back.

@build-analysisbuild-analysisBot mentioned this pull request May 25, 2024
Closed
@am11

am11 commented May 27, 2024

Copy link
Copy Markdown
MemberAuthor
[20:31:01] info: Using threadless Xunit runner
[20:31:01] info: Discovering: System.Security.Cryptography.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:31:04] info: Discovered: System.Security.Cryptography.Tests.dll (found 1815 of 4463 test cases)
[20:31:04] info: Starting: System.Security.Cryptography.Tests.dll
[20:31:34] info: Finished: System.Security.Cryptography.Tests.dll
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
....

@akoeplinger could you rerun this leg so we can find out if it's a persistent problem? In previous run it was green which is why I have this feeling. 🤞

@am11

am11 commented May 27, 2024

Copy link
Copy Markdown
MemberAuthor

Looks green (enough) to me! :shipit:

@ViktorHofer
ViktorHofer merged commit 0d0aafc into dotnet:mainMay 27, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@am11@Ruihan-Yin
Update SDK to 9.0 preview 4 (dotnet#102604)
d45d24f
* Update SDK to preview 4
* Update BlazorClient and Shared csprojs
* Update System.Reflection.Metadata and co.
* nitpick
* Revert version update
* Remove ILCompiler workaround
* Remove crossgen2 workaround
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 27, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sbomersbomersbomer left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@ericstjericstjericstj left review comments
@ilonatommyilonatommyilonatommy left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

No one assigned

Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@am11@sbomer@akoeplinger@ViktorHofer@ericstj@ilonatommy
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Update SDK to 9.0 preview 4 by am11 · Pull Request #102604 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 preview 4 - #102604
Merged
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
May 27, 2024
Merged
Update SDK to 9.0 preview 4#102604
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
Conversation
@am11
@am11am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
May 23, 2024
@am11am11
changed the title
Update SDK to preview 4Update SDK to 9.0 preview 4May 23, 2024
@am11am11
added

area-Infrastructure

community-contribution
Indicates that the PR has been added by a community member
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
May 23, 2024
ilonatommy
ilonatommy
reviewed
May 23, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places with pinned versions:
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Sure, will update those as well. I was mainly following @MichalStrehovsky's footsteps #100945 (which made me think only to grep 9.*preview.3, find versions on the internets and replace) 😅
am11
am11
commented
May 23, 2024
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
 Discovered: Wasi.Build.Tests (found 1 of 11 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_fkeubaml_415] You must install or update .NET to run this application.
[Release_fkeubaml_415] [Release_fkeubaml_415] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_fkeubaml_415] Architecture: x64
[Release_fkeubaml_415] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.4.24266.19' (x64)
[Release_fkeubaml_415] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_fkeubaml_415] [Release_fkeubaml_415] The following frameworks were found:
[Release_fkeubaml_415] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] 9.0.0-preview.4.24251.3 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] [Release_fkeubaml_415] Learn more:
[Release_fkeubaml_415] https://aka.ms/dotnet/app-launch-failed
[Release_fkeubaml_415] [Release_fkeubaml_415] To install missing framework, download:
[Release_fkeubaml_415] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.4.24266.19&arch=x64&rid=linux-x64&os=ubuntu.22.04
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(44,0): at Wasm.Build.Tests.CommandResult.EnsureExitCode(Int32 expectedExitCode, String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(28,0): at Wasm.Build.Tests.CommandResult.EnsureSuccessful(String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasi/Wasi.Build.Tests/ILStripTests.cs(52,0): at Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(String stripILAfterAOT, Boolean expectILStripping, Boolean singleFileBundle)

@ilonatommy, is there anything else which needs to be updated before preview.1 -> preview.4 switch is possible for Wasm.Build.Tests?
@build-analysisbuild-analysisBot
mentioned this pull request
May 23, 2024

Closed

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
Applied @lewing's #102624 as a patch and it fixed the error. 👏

(lets wait until that one is landed then I'll revert and merge main)
sbomer
sbomer
reviewed
May 23, 2024
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
@am11am11
mentioned this pull request
May 24, 2024
 Closed

@am11
am11force-pushed
the
feature/sdk-update/9.0-preview4
branch
from
7dbbef4 to
2a12d10CompareMay 24, 2024 19:16
@am11
am11
commented
May 25, 2024

Copy link


Copy Markdown

MemberAuthor
@lewing looks like #100275 is back.
@build-analysisbuild-analysisBot
mentioned this pull request
May 25, 2024

Closed

@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
[20:31:01] info: Using threadless Xunit runner
[20:31:01] info: Discovering: System.Security.Cryptography.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:31:04] info: Discovered: System.Security.Cryptography.Tests.dll (found 1815 of 4463 test cases)
[20:31:04] info: Starting: System.Security.Cryptography.Tests.dll
[20:31:34] info: Finished: System.Security.Cryptography.Tests.dll
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
....

@akoeplinger could you rerun this leg so we can find out if it's a persistent problem? In previous run it was green which is why I have this feeling. 🤞
@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
Looks green (enough) to me! :shipit:
@ViktorHofer
ViktorHofer
merged commit 0d0aafc
into
dotnet:mainMay 27, 2024
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@am11@Ruihan-Yin
Update SDK to 9.0 preview 4 (dotnet#102604)
d45d24f
* Update SDK to preview 4
* Update BlazorClient and Shared csprojs
* Update System.Reflection.Metadata and co.
* nitpick
* Revert version update
* Remove ILCompiler workaround
* Remove crossgen2 workaround
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 27, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@ericstjericstjericstj left review comments
@ilonatommyilonatommyilonatommy left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@am11@sbomer@akoeplinger@ViktorHofer@ericstj@ilonatommy

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update SDK to 9.0 preview 4 by am11 · Pull Request #102604 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 preview 4 - #102604
Merged
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
May 27, 2024
Merged
Update SDK to 9.0 preview 4#102604
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
Conversation
@am11
@am11am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
May 23, 2024
@am11am11
changed the title
Update SDK to preview 4Update SDK to 9.0 preview 4May 23, 2024
@am11am11
added

area-Infrastructure

community-contribution
Indicates that the PR has been added by a community member
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
May 23, 2024
ilonatommy
ilonatommy
reviewed
May 23, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places with pinned versions:
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Sure, will update those as well. I was mainly following @MichalStrehovsky's footsteps #100945 (which made me think only to grep 9.*preview.3, find versions on the internets and replace) 😅
am11
am11
commented
May 23, 2024
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
 Discovered: Wasi.Build.Tests (found 1 of 11 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_fkeubaml_415] You must install or update .NET to run this application.
[Release_fkeubaml_415] [Release_fkeubaml_415] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_fkeubaml_415] Architecture: x64
[Release_fkeubaml_415] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.4.24266.19' (x64)
[Release_fkeubaml_415] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_fkeubaml_415] [Release_fkeubaml_415] The following frameworks were found:
[Release_fkeubaml_415] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] 9.0.0-preview.4.24251.3 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] [Release_fkeubaml_415] Learn more:
[Release_fkeubaml_415] https://aka.ms/dotnet/app-launch-failed
[Release_fkeubaml_415] [Release_fkeubaml_415] To install missing framework, download:
[Release_fkeubaml_415] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.4.24266.19&arch=x64&rid=linux-x64&os=ubuntu.22.04
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(44,0): at Wasm.Build.Tests.CommandResult.EnsureExitCode(Int32 expectedExitCode, String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(28,0): at Wasm.Build.Tests.CommandResult.EnsureSuccessful(String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasi/Wasi.Build.Tests/ILStripTests.cs(52,0): at Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(String stripILAfterAOT, Boolean expectILStripping, Boolean singleFileBundle)

@ilonatommy, is there anything else which needs to be updated before preview.1 -> preview.4 switch is possible for Wasm.Build.Tests?
@build-analysisbuild-analysisBot
mentioned this pull request
May 23, 2024

Closed

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
Applied @lewing's #102624 as a patch and it fixed the error. 👏

(lets wait until that one is landed then I'll revert and merge main)
sbomer
sbomer
reviewed
May 23, 2024
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
@am11am11
mentioned this pull request
May 24, 2024
 Closed

@am11
am11force-pushed
the
feature/sdk-update/9.0-preview4
branch
from
7dbbef4 to
2a12d10CompareMay 24, 2024 19:16
@am11
am11
commented
May 25, 2024

Copy link


Copy Markdown

MemberAuthor
@lewing looks like #100275 is back.
@build-analysisbuild-analysisBot
mentioned this pull request
May 25, 2024

Closed

@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
[20:31:01] info: Using threadless Xunit runner
[20:31:01] info: Discovering: System.Security.Cryptography.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:31:04] info: Discovered: System.Security.Cryptography.Tests.dll (found 1815 of 4463 test cases)
[20:31:04] info: Starting: System.Security.Cryptography.Tests.dll
[20:31:34] info: Finished: System.Security.Cryptography.Tests.dll
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
....

@akoeplinger could you rerun this leg so we can find out if it's a persistent problem? In previous run it was green which is why I have this feeling. 🤞
@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
Looks green (enough) to me! :shipit:
@ViktorHofer
ViktorHofer
merged commit 0d0aafc
into
dotnet:mainMay 27, 2024
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@am11@Ruihan-Yin
Update SDK to 9.0 preview 4 (dotnet#102604)
d45d24f
* Update SDK to preview 4
* Update BlazorClient and Shared csprojs
* Update System.Reflection.Metadata and co.
* nitpick
* Revert version update
* Remove ILCompiler workaround
* Remove crossgen2 workaround
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 27, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@ericstjericstjericstj left review comments
@ilonatommyilonatommyilonatommy left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@am11@sbomer@akoeplinger@ViktorHofer@ericstj@ilonatommy

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update SDK to 9.0 preview 4 by am11 · Pull Request #102604 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 preview 4 - #102604
Merged
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
May 27, 2024
Merged
Update SDK to 9.0 preview 4#102604
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
Conversation
@am11
@am11am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
May 23, 2024
@am11am11
changed the title
Update SDK to preview 4Update SDK to 9.0 preview 4May 23, 2024
@am11am11
added

area-Infrastructure

community-contribution
Indicates that the PR has been added by a community member
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
May 23, 2024
ilonatommy
ilonatommy
reviewed
May 23, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places with pinned versions:
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Sure, will update those as well. I was mainly following @MichalStrehovsky's footsteps #100945 (which made me think only to grep 9.*preview.3, find versions on the internets and replace) 😅
am11
am11
commented
May 23, 2024
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
 Discovered: Wasi.Build.Tests (found 1 of 11 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_fkeubaml_415] You must install or update .NET to run this application.
[Release_fkeubaml_415] [Release_fkeubaml_415] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_fkeubaml_415] Architecture: x64
[Release_fkeubaml_415] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.4.24266.19' (x64)
[Release_fkeubaml_415] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_fkeubaml_415] [Release_fkeubaml_415] The following frameworks were found:
[Release_fkeubaml_415] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] 9.0.0-preview.4.24251.3 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] [Release_fkeubaml_415] Learn more:
[Release_fkeubaml_415] https://aka.ms/dotnet/app-launch-failed
[Release_fkeubaml_415] [Release_fkeubaml_415] To install missing framework, download:
[Release_fkeubaml_415] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.4.24266.19&arch=x64&rid=linux-x64&os=ubuntu.22.04
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(44,0): at Wasm.Build.Tests.CommandResult.EnsureExitCode(Int32 expectedExitCode, String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(28,0): at Wasm.Build.Tests.CommandResult.EnsureSuccessful(String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasi/Wasi.Build.Tests/ILStripTests.cs(52,0): at Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(String stripILAfterAOT, Boolean expectILStripping, Boolean singleFileBundle)

@ilonatommy, is there anything else which needs to be updated before preview.1 -> preview.4 switch is possible for Wasm.Build.Tests?
@build-analysisbuild-analysisBot
mentioned this pull request
May 23, 2024

Closed

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
Applied @lewing's #102624 as a patch and it fixed the error. 👏

(lets wait until that one is landed then I'll revert and merge main)
sbomer
sbomer
reviewed
May 23, 2024
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
@am11am11
mentioned this pull request
May 24, 2024
 Closed

@am11
am11force-pushed
the
feature/sdk-update/9.0-preview4
branch
from
7dbbef4 to
2a12d10CompareMay 24, 2024 19:16
@am11
am11
commented
May 25, 2024

Copy link


Copy Markdown

MemberAuthor
@lewing looks like #100275 is back.
@build-analysisbuild-analysisBot
mentioned this pull request
May 25, 2024

Closed

@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
[20:31:01] info: Using threadless Xunit runner
[20:31:01] info: Discovering: System.Security.Cryptography.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:31:04] info: Discovered: System.Security.Cryptography.Tests.dll (found 1815 of 4463 test cases)
[20:31:04] info: Starting: System.Security.Cryptography.Tests.dll
[20:31:34] info: Finished: System.Security.Cryptography.Tests.dll
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
....

@akoeplinger could you rerun this leg so we can find out if it's a persistent problem? In previous run it was green which is why I have this feeling. 🤞
@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
Looks green (enough) to me! :shipit:
@ViktorHofer
ViktorHofer
merged commit 0d0aafc
into
dotnet:mainMay 27, 2024
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@am11@Ruihan-Yin
Update SDK to 9.0 preview 4 (dotnet#102604)
d45d24f
* Update SDK to preview 4
* Update BlazorClient and Shared csprojs
* Update System.Reflection.Metadata and co.
* nitpick
* Revert version update
* Remove ILCompiler workaround
* Remove crossgen2 workaround
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 27, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@ericstjericstjericstj left review comments
@ilonatommyilonatommyilonatommy left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@am11@sbomer@akoeplinger@ViktorHofer@ericstj@ilonatommy

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Update SDK to 9.0 preview 4 by am11 · Pull Request #102604 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 preview 4 - #102604
Merged
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
May 27, 2024
Merged
Update SDK to 9.0 preview 4#102604
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
Conversation
@am11
@am11am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
May 23, 2024
@am11am11
changed the title
Update SDK to preview 4Update SDK to 9.0 preview 4May 23, 2024
@am11am11
added

area-Infrastructure

community-contribution
Indicates that the PR has been added by a community member
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
May 23, 2024
ilonatommy
ilonatommy
reviewed
May 23, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places with pinned versions:
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Sure, will update those as well. I was mainly following @MichalStrehovsky's footsteps #100945 (which made me think only to grep 9.*preview.3, find versions on the internets and replace) 😅
am11
am11
commented
May 23, 2024
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
 Discovered: Wasi.Build.Tests (found 1 of 11 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_fkeubaml_415] You must install or update .NET to run this application.
[Release_fkeubaml_415] [Release_fkeubaml_415] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_fkeubaml_415] Architecture: x64
[Release_fkeubaml_415] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.4.24266.19' (x64)
[Release_fkeubaml_415] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_fkeubaml_415] [Release_fkeubaml_415] The following frameworks were found:
[Release_fkeubaml_415] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] 9.0.0-preview.4.24251.3 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] [Release_fkeubaml_415] Learn more:
[Release_fkeubaml_415] https://aka.ms/dotnet/app-launch-failed
[Release_fkeubaml_415] [Release_fkeubaml_415] To install missing framework, download:
[Release_fkeubaml_415] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.4.24266.19&arch=x64&rid=linux-x64&os=ubuntu.22.04
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(44,0): at Wasm.Build.Tests.CommandResult.EnsureExitCode(Int32 expectedExitCode, String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(28,0): at Wasm.Build.Tests.CommandResult.EnsureSuccessful(String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasi/Wasi.Build.Tests/ILStripTests.cs(52,0): at Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(String stripILAfterAOT, Boolean expectILStripping, Boolean singleFileBundle)

@ilonatommy, is there anything else which needs to be updated before preview.1 -> preview.4 switch is possible for Wasm.Build.Tests?
@build-analysisbuild-analysisBot
mentioned this pull request
May 23, 2024

Closed

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
Applied @lewing's #102624 as a patch and it fixed the error. 👏

(lets wait until that one is landed then I'll revert and merge main)
sbomer
sbomer
reviewed
May 23, 2024
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
@am11am11
mentioned this pull request
May 24, 2024
 Closed

@am11
am11force-pushed
the
feature/sdk-update/9.0-preview4
branch
from
7dbbef4 to
2a12d10CompareMay 24, 2024 19:16
@am11
am11
commented
May 25, 2024

Copy link


Copy Markdown

MemberAuthor
@lewing looks like #100275 is back.
@build-analysisbuild-analysisBot
mentioned this pull request
May 25, 2024

Closed

@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
[20:31:01] info: Using threadless Xunit runner
[20:31:01] info: Discovering: System.Security.Cryptography.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:31:04] info: Discovered: System.Security.Cryptography.Tests.dll (found 1815 of 4463 test cases)
[20:31:04] info: Starting: System.Security.Cryptography.Tests.dll
[20:31:34] info: Finished: System.Security.Cryptography.Tests.dll
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
....

@akoeplinger could you rerun this leg so we can find out if it's a persistent problem? In previous run it was green which is why I have this feeling. 🤞
@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
Looks green (enough) to me! :shipit:
@ViktorHofer
ViktorHofer
merged commit 0d0aafc
into
dotnet:mainMay 27, 2024
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@am11@Ruihan-Yin
Update SDK to 9.0 preview 4 (dotnet#102604)
d45d24f
* Update SDK to preview 4
* Update BlazorClient and Shared csprojs
* Update System.Reflection.Metadata and co.
* nitpick
* Revert version update
* Remove ILCompiler workaround
* Remove crossgen2 workaround
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 27, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@ericstjericstjericstj left review comments
@ilonatommyilonatommyilonatommy left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@am11@sbomer@akoeplinger@ViktorHofer@ericstj@ilonatommy

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update SDK to 9.0 preview 4 by am11 · Pull Request #102604 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 preview 4 - #102604
Merged
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
May 27, 2024
Merged
Update SDK to 9.0 preview 4#102604
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
Conversation
@am11
@am11am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
May 23, 2024
@am11am11
changed the title
Update SDK to preview 4Update SDK to 9.0 preview 4May 23, 2024
@am11am11
added

area-Infrastructure

community-contribution
Indicates that the PR has been added by a community member
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
May 23, 2024
ilonatommy
ilonatommy
reviewed
May 23, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places with pinned versions:
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Sure, will update those as well. I was mainly following @MichalStrehovsky's footsteps #100945 (which made me think only to grep 9.*preview.3, find versions on the internets and replace) 😅
am11
am11
commented
May 23, 2024
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
 Discovered: Wasi.Build.Tests (found 1 of 11 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_fkeubaml_415] You must install or update .NET to run this application.
[Release_fkeubaml_415] [Release_fkeubaml_415] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_fkeubaml_415] Architecture: x64
[Release_fkeubaml_415] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.4.24266.19' (x64)
[Release_fkeubaml_415] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_fkeubaml_415] [Release_fkeubaml_415] The following frameworks were found:
[Release_fkeubaml_415] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] 9.0.0-preview.4.24251.3 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] [Release_fkeubaml_415] Learn more:
[Release_fkeubaml_415] https://aka.ms/dotnet/app-launch-failed
[Release_fkeubaml_415] [Release_fkeubaml_415] To install missing framework, download:
[Release_fkeubaml_415] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.4.24266.19&arch=x64&rid=linux-x64&os=ubuntu.22.04
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(44,0): at Wasm.Build.Tests.CommandResult.EnsureExitCode(Int32 expectedExitCode, String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(28,0): at Wasm.Build.Tests.CommandResult.EnsureSuccessful(String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasi/Wasi.Build.Tests/ILStripTests.cs(52,0): at Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(String stripILAfterAOT, Boolean expectILStripping, Boolean singleFileBundle)

@ilonatommy, is there anything else which needs to be updated before preview.1 -> preview.4 switch is possible for Wasm.Build.Tests?
@build-analysisbuild-analysisBot
mentioned this pull request
May 23, 2024

Closed

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
Applied @lewing's #102624 as a patch and it fixed the error. 👏

(lets wait until that one is landed then I'll revert and merge main)
sbomer
sbomer
reviewed
May 23, 2024
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
@am11am11
mentioned this pull request
May 24, 2024
 Closed

@am11
am11force-pushed
the
feature/sdk-update/9.0-preview4
branch
from
7dbbef4 to
2a12d10CompareMay 24, 2024 19:16
@am11
am11
commented
May 25, 2024

Copy link


Copy Markdown

MemberAuthor
@lewing looks like #100275 is back.
@build-analysisbuild-analysisBot
mentioned this pull request
May 25, 2024

Closed

@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
[20:31:01] info: Using threadless Xunit runner
[20:31:01] info: Discovering: System.Security.Cryptography.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:31:04] info: Discovered: System.Security.Cryptography.Tests.dll (found 1815 of 4463 test cases)
[20:31:04] info: Starting: System.Security.Cryptography.Tests.dll
[20:31:34] info: Finished: System.Security.Cryptography.Tests.dll
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
....

@akoeplinger could you rerun this leg so we can find out if it's a persistent problem? In previous run it was green which is why I have this feeling. 🤞
@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
Looks green (enough) to me! :shipit:
@ViktorHofer
ViktorHofer
merged commit 0d0aafc
into
dotnet:mainMay 27, 2024
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@am11@Ruihan-Yin
Update SDK to 9.0 preview 4 (dotnet#102604)
d45d24f
* Update SDK to preview 4
* Update BlazorClient and Shared csprojs
* Update System.Reflection.Metadata and co.
* nitpick
* Revert version update
* Remove ILCompiler workaround
* Remove crossgen2 workaround
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 27, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@ericstjericstjericstj left review comments
@ilonatommyilonatommyilonatommy left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@am11@sbomer@akoeplinger@ViktorHofer@ericstj@ilonatommy

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update SDK to 9.0 preview 4 by am11 · Pull Request #102604 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 preview 4 - #102604
Merged
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
May 27, 2024
Merged
Update SDK to 9.0 preview 4#102604
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
Conversation
@am11
@am11am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
May 23, 2024
@am11am11
changed the title
Update SDK to preview 4Update SDK to 9.0 preview 4May 23, 2024
@am11am11
added

area-Infrastructure

community-contribution
Indicates that the PR has been added by a community member
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
May 23, 2024
ilonatommy
ilonatommy
reviewed
May 23, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places with pinned versions:
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Sure, will update those as well. I was mainly following @MichalStrehovsky's footsteps #100945 (which made me think only to grep 9.*preview.3, find versions on the internets and replace) 😅
am11
am11
commented
May 23, 2024
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
 Discovered: Wasi.Build.Tests (found 1 of 11 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_fkeubaml_415] You must install or update .NET to run this application.
[Release_fkeubaml_415] [Release_fkeubaml_415] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_fkeubaml_415] Architecture: x64
[Release_fkeubaml_415] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.4.24266.19' (x64)
[Release_fkeubaml_415] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_fkeubaml_415] [Release_fkeubaml_415] The following frameworks were found:
[Release_fkeubaml_415] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] 9.0.0-preview.4.24251.3 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] [Release_fkeubaml_415] Learn more:
[Release_fkeubaml_415] https://aka.ms/dotnet/app-launch-failed
[Release_fkeubaml_415] [Release_fkeubaml_415] To install missing framework, download:
[Release_fkeubaml_415] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.4.24266.19&arch=x64&rid=linux-x64&os=ubuntu.22.04
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(44,0): at Wasm.Build.Tests.CommandResult.EnsureExitCode(Int32 expectedExitCode, String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(28,0): at Wasm.Build.Tests.CommandResult.EnsureSuccessful(String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasi/Wasi.Build.Tests/ILStripTests.cs(52,0): at Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(String stripILAfterAOT, Boolean expectILStripping, Boolean singleFileBundle)

@ilonatommy, is there anything else which needs to be updated before preview.1 -> preview.4 switch is possible for Wasm.Build.Tests?
@build-analysisbuild-analysisBot
mentioned this pull request
May 23, 2024

Closed

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
Applied @lewing's #102624 as a patch and it fixed the error. 👏

(lets wait until that one is landed then I'll revert and merge main)
sbomer
sbomer
reviewed
May 23, 2024
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
@am11am11
mentioned this pull request
May 24, 2024
 Closed

@am11
am11force-pushed
the
feature/sdk-update/9.0-preview4
branch
from
7dbbef4 to
2a12d10CompareMay 24, 2024 19:16
@am11
am11
commented
May 25, 2024

Copy link


Copy Markdown

MemberAuthor
@lewing looks like #100275 is back.
@build-analysisbuild-analysisBot
mentioned this pull request
May 25, 2024

Closed

@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
[20:31:01] info: Using threadless Xunit runner
[20:31:01] info: Discovering: System.Security.Cryptography.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:31:04] info: Discovered: System.Security.Cryptography.Tests.dll (found 1815 of 4463 test cases)
[20:31:04] info: Starting: System.Security.Cryptography.Tests.dll
[20:31:34] info: Finished: System.Security.Cryptography.Tests.dll
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
....

@akoeplinger could you rerun this leg so we can find out if it's a persistent problem? In previous run it was green which is why I have this feeling. 🤞
@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
Looks green (enough) to me! :shipit:
@ViktorHofer
ViktorHofer
merged commit 0d0aafc
into
dotnet:mainMay 27, 2024
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@am11@Ruihan-Yin
Update SDK to 9.0 preview 4 (dotnet#102604)
d45d24f
* Update SDK to preview 4
* Update BlazorClient and Shared csprojs
* Update System.Reflection.Metadata and co.
* nitpick
* Revert version update
* Remove ILCompiler workaround
* Remove crossgen2 workaround
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 27, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@ericstjericstjericstj left review comments
@ilonatommyilonatommyilonatommy left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@am11@sbomer@akoeplinger@ViktorHofer@ericstj@ilonatommy

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Update SDK to 9.0 preview 4 by am11 · Pull Request #102604 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 preview 4 - #102604
Merged
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
May 27, 2024
Merged
Update SDK to 9.0 preview 4#102604
ViktorHofer merged 9 commits into
dotnet:mainfrom 
am11:feature/sdk-update/9.0-preview4
Conversation
@am11
@am11am11
commented
May 23, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
May 23, 2024
@am11am11
changed the title
Update SDK to preview 4Update SDK to 9.0 preview 4May 23, 2024
@am11am11
added

area-Infrastructure

community-contribution
Indicates that the PR has been added by a community member
and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
May 23, 2024
ilonatommy
ilonatommy
reviewed
May 23, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places with pinned versions:
@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Sure, will update those as well. I was mainly following @MichalStrehovsky's footsteps #100945 (which made me think only to grep 9.*preview.3, find versions on the internets and replace) 😅
am11
am11
commented
May 23, 2024
View reviewed changes
Comment threadeng/Version.Details.xml
Outdated

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
 Discovered: Wasi.Build.Tests (found 1 of 11 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_fkeubaml_415] You must install or update .NET to run this application.
[Release_fkeubaml_415] [Release_fkeubaml_415] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_fkeubaml_415] Architecture: x64
[Release_fkeubaml_415] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.4.24266.19' (x64)
[Release_fkeubaml_415] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_fkeubaml_415] [Release_fkeubaml_415] The following frameworks were found:
[Release_fkeubaml_415] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] 9.0.0-preview.4.24251.3 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_fkeubaml_415] [Release_fkeubaml_415] Learn more:
[Release_fkeubaml_415] https://aka.ms/dotnet/app-launch-failed
[Release_fkeubaml_415] [Release_fkeubaml_415] To install missing framework, download:
[Release_fkeubaml_415] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.4.24266.19&arch=x64&rid=linux-x64&os=ubuntu.22.04
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(44,0): at Wasm.Build.Tests.CommandResult.EnsureExitCode(Int32 expectedExitCode, String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(28,0): at Wasm.Build.Tests.CommandResult.EnsureSuccessful(String messagePrefix, Boolean suppressOutput)
/_/src/mono/wasi/Wasi.Build.Tests/ILStripTests.cs(52,0): at Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(String stripILAfterAOT, Boolean expectILStripping, Boolean singleFileBundle)

@ilonatommy, is there anything else which needs to be updated before preview.1 -> preview.4 switch is possible for Wasm.Build.Tests?
@build-analysisbuild-analysisBot
mentioned this pull request
May 23, 2024

Closed

@am11
am11
commented
May 23, 2024

Copy link


Copy Markdown

MemberAuthor
Build wasi-wasm linux Release WasmBuildTests is failing with:
Applied @lewing's #102624 as a patch and it fixed the error. 👏

(lets wait until that one is landed then I'll revert and merge main)
sbomer
sbomer
reviewed
May 23, 2024
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
@am11am11
mentioned this pull request
May 24, 2024
 Closed

@am11
am11force-pushed
the
feature/sdk-update/9.0-preview4
branch
from
7dbbef4 to
2a12d10CompareMay 24, 2024 19:16
@am11
am11
commented
May 25, 2024

Copy link


Copy Markdown

MemberAuthor
@lewing looks like #100275 is back.
@build-analysisbuild-analysisBot
mentioned this pull request
May 25, 2024

Closed

@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
[20:31:01] info: Using threadless Xunit runner
[20:31:01] info: Discovering: System.Security.Cryptography.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:31:04] info: Discovered: System.Security.Cryptography.Tests.dll (found 1815 of 4463 test cases)
[20:31:04] info: Starting: System.Security.Cryptography.Tests.dll
[20:31:34] info: Finished: System.Security.Cryptography.Tests.dll
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
[20:31:40] info: Unable to evaluate script: tab crashed
....

@akoeplinger could you rerun this leg so we can find out if it's a persistent problem? In previous run it was green which is why I have this feeling. 🤞
@am11
am11
commented
May 27, 2024

Copy link


Copy Markdown

MemberAuthor
Looks green (enough) to me! :shipit:
@ViktorHofer
ViktorHofer
merged commit 0d0aafc
into
dotnet:mainMay 27, 2024
Ruihan-Yin pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
@am11@Ruihan-Yin
Update SDK to 9.0 preview 4 (dotnet#102604)
d45d24f
* Update SDK to preview 4
* Update BlazorClient and Shared csprojs
* Update System.Reflection.Metadata and co.
* nitpick
* Revert version update
* Remove ILCompiler workaround
* Remove crossgen2 workaround
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jun 27, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@sbomersbomersbomer left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@ericstjericstjericstj left review comments
@ilonatommyilonatommyilonatommy left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees


No one assigned


Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@am11@sbomer@akoeplinger@ViktorHofer@ericstj@ilonatommy