Minimally allow Vector.Shuffle to expand for values that become constant by global morph

[tannergooding]

This changes:

privatestaticVector128<float>Test(){vary=Vector128.Create(3,2,1,0);returnVector128.Shuffle(Vector128.Create(1.0f,2.0f,3.0f,4.0f),y);}

From generating:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M000_IG01: ;; offset=0x0000pushrbxsubrsp,64movrbx,rcxG_M000_IG02: ;; offset=0x0008vmovupsxmm0, xmmword ptr [reloc @RWD00] vmovaps xmmword ptr [rsp+0x30],xmm0vmovupsxmm0, xmmword ptr [reloc @RWD16] vmovaps xmmword ptr [rsp+0x20],xmm0leardx,[rsp+0x30]lear8,[rsp+0x20]movrcx,rbxcall[System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float]]movrax,rbxG_M000_IG03: ;; offset=0x003Aaddrsp,64poprbxretRWD00 dq	400000003F800000h,4080000040400000hRWD16 dq	0000000200000003h,0000000000000001h; Total bytes of code: 64

to instead generate:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M40807_IG01: ;; offset=0x0000 ;; size=0 bbWeight=1 PerfScore 0.00G_M40807_IG02: ;; offset=0x0000vpermilpsxmm0, xmmword ptr [reloc @RWD00],27vmovups xmmword ptr [rcx],xmm0movrax,rcx ;; size=17 bbWeight=1 PerfScore 4.25G_M40807_IG03: ;; offset=0x0011ret ;; size=1 bbWeight=1 PerfScore 1.00RWD00 dq	400000003F800000h,4080000040400000h; Total bytes of code: 18

---

Due to limitations in forward sub, this does not handle some other cases where other statements interfere with the ability to substitute.

Doing this post global morph is much more difficult as the call gets rewritten to spilled locals, such as:

fgMorphTreeBB01,STMT00002(after)[000016]SACXG+-----*CALLvoid System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float][000021]DA--------- arg1 setup +--* STORE_LCL_VAR simd16<System.Runtime.Intrinsics.Vector128`1>(AX) V04 tmp2 [000014]-----+-----| \--*HWINTRINSIC simd16 float Add
[000012]-----+-----|+--*LCL_VAR simd16 V03 tmp1 [000013]-----+-----| \--*LCL_VARsimd16 V03 tmp1 (lastuse)[000022]-----------arg1in rdx +--*LCL_ADDR long V04 tmp2 [+0][000015]-----+-----arg2in r8 +--*LCL_ADDR long V01 loc0 [+0][000017]-----+-----retbufin rcx \--*LCL_VAR byref V00 RetBuf 

This is basically the same reason we can't do what GT_INTRINSIC does by just carrying a GT_HWINTRINSIC down to rationalization and rewriting it back to a call. The ABI handling around return buffers and parameter passing happens very early today (return buffers around import and parameter passing in global morph). If the ABI handling were moved down, then we could move this logic later (such as post VN) and catch essentially all cases instead.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[tannergooding]

Ended up replacing this with #102702, which allows it to be done in rationalization instead and so can cover many more scenarios.

[tannergooding]

This changes:

privatestaticVector128<float>Test(){vary=Vector128.Create(3,2,1,0);returnVector128.Shuffle(Vector128.Create(1.0f,2.0f,3.0f,4.0f),y);}

From generating:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M000_IG01: ;; offset=0x0000pushrbxsubrsp,64movrbx,rcxG_M000_IG02: ;; offset=0x0008vmovupsxmm0, xmmword ptr [reloc @RWD00] vmovaps xmmword ptr [rsp+0x30],xmm0vmovupsxmm0, xmmword ptr [reloc @RWD16] vmovaps xmmword ptr [rsp+0x20],xmm0leardx,[rsp+0x30]lear8,[rsp+0x20]movrcx,rbxcall[System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float]]movrax,rbxG_M000_IG03: ;; offset=0x003Aaddrsp,64poprbxretRWD00 dq	400000003F800000h,4080000040400000hRWD16 dq	0000000200000003h,0000000000000001h; Total bytes of code: 64

to instead generate:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M40807_IG01: ;; offset=0x0000 ;; size=0 bbWeight=1 PerfScore 0.00G_M40807_IG02: ;; offset=0x0000vpermilpsxmm0, xmmword ptr [reloc @RWD00],27vmovups xmmword ptr [rcx],xmm0movrax,rcx ;; size=17 bbWeight=1 PerfScore 4.25G_M40807_IG03: ;; offset=0x0011ret ;; size=1 bbWeight=1 PerfScore 1.00RWD00 dq	400000003F800000h,4080000040400000h; Total bytes of code: 18

---

Due to limitations in forward sub, this does not handle some other cases where other statements interfere with the ability to substitute.

Doing this post global morph is much more difficult as the call gets rewritten to spilled locals, such as:

fgMorphTreeBB01,STMT00002(after)[000016]SACXG+-----*CALLvoid System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float][000021]DA--------- arg1 setup +--* STORE_LCL_VAR simd16<System.Runtime.Intrinsics.Vector128`1>(AX) V04 tmp2 [000014]-----+-----| \--*HWINTRINSIC simd16 float Add
[000012]-----+-----|+--*LCL_VAR simd16 V03 tmp1 [000013]-----+-----| \--*LCL_VARsimd16 V03 tmp1 (lastuse)[000022]-----------arg1in rdx +--*LCL_ADDR long V04 tmp2 [+0][000015]-----+-----arg2in r8 +--*LCL_ADDR long V01 loc0 [+0][000017]-----+-----retbufin rcx \--*LCL_VAR byref V00 RetBuf 

This is basically the same reason we can't do what GT_INTRINSIC does by just carrying a GT_HWINTRINSIC down to rationalization and rewriting it back to a call. The ABI handling around return buffers and parameter passing happens very early today (return buffers around import and parameter passing in global morph). If the ABI handling were moved down, then we could move this logic later (such as post VN) and catch essentially all cases instead.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[tannergooding]

Ended up replacing this with #102702, which allows it to be done in rationalization instead and so can cover many more scenarios.

[tannergooding]

This changes:

privatestaticVector128<float>Test(){vary=Vector128.Create(3,2,1,0);returnVector128.Shuffle(Vector128.Create(1.0f,2.0f,3.0f,4.0f),y);}

From generating:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M000_IG01: ;; offset=0x0000pushrbxsubrsp,64movrbx,rcxG_M000_IG02: ;; offset=0x0008vmovupsxmm0, xmmword ptr [reloc @RWD00] vmovaps xmmword ptr [rsp+0x30],xmm0vmovupsxmm0, xmmword ptr [reloc @RWD16] vmovaps xmmword ptr [rsp+0x20],xmm0leardx,[rsp+0x30]lear8,[rsp+0x20]movrcx,rbxcall[System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float]]movrax,rbxG_M000_IG03: ;; offset=0x003Aaddrsp,64poprbxretRWD00 dq	400000003F800000h,4080000040400000hRWD16 dq	0000000200000003h,0000000000000001h; Total bytes of code: 64

to instead generate:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M40807_IG01: ;; offset=0x0000 ;; size=0 bbWeight=1 PerfScore 0.00G_M40807_IG02: ;; offset=0x0000vpermilpsxmm0, xmmword ptr [reloc @RWD00],27vmovups xmmword ptr [rcx],xmm0movrax,rcx ;; size=17 bbWeight=1 PerfScore 4.25G_M40807_IG03: ;; offset=0x0011ret ;; size=1 bbWeight=1 PerfScore 1.00RWD00 dq	400000003F800000h,4080000040400000h; Total bytes of code: 18

---

Due to limitations in forward sub, this does not handle some other cases where other statements interfere with the ability to substitute.

Doing this post global morph is much more difficult as the call gets rewritten to spilled locals, such as:

fgMorphTreeBB01,STMT00002(after)[000016]SACXG+-----*CALLvoid System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float][000021]DA--------- arg1 setup +--* STORE_LCL_VAR simd16<System.Runtime.Intrinsics.Vector128`1>(AX) V04 tmp2 [000014]-----+-----| \--*HWINTRINSIC simd16 float Add
[000012]-----+-----|+--*LCL_VAR simd16 V03 tmp1 [000013]-----+-----| \--*LCL_VARsimd16 V03 tmp1 (lastuse)[000022]-----------arg1in rdx +--*LCL_ADDR long V04 tmp2 [+0][000015]-----+-----arg2in r8 +--*LCL_ADDR long V01 loc0 [+0][000017]-----+-----retbufin rcx \--*LCL_VAR byref V00 RetBuf 

This is basically the same reason we can't do what GT_INTRINSIC does by just carrying a GT_HWINTRINSIC down to rationalization and rewriting it back to a call. The ABI handling around return buffers and parameter passing happens very early today (return buffers around import and parameter passing in global morph). If the ABI handling were moved down, then we could move this logic later (such as post VN) and catch essentially all cases instead.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[tannergooding]

Ended up replacing this with #102702, which allows it to be done in rationalization instead and so can cover many more scenarios.

[tannergooding]

This changes:

privatestaticVector128<float>Test(){vary=Vector128.Create(3,2,1,0);returnVector128.Shuffle(Vector128.Create(1.0f,2.0f,3.0f,4.0f),y);}

From generating:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M000_IG01: ;; offset=0x0000pushrbxsubrsp,64movrbx,rcxG_M000_IG02: ;; offset=0x0008vmovupsxmm0, xmmword ptr [reloc @RWD00] vmovaps xmmword ptr [rsp+0x30],xmm0vmovupsxmm0, xmmword ptr [reloc @RWD16] vmovaps xmmword ptr [rsp+0x20],xmm0leardx,[rsp+0x30]lear8,[rsp+0x20]movrcx,rbxcall[System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float]]movrax,rbxG_M000_IG03: ;; offset=0x003Aaddrsp,64poprbxretRWD00 dq	400000003F800000h,4080000040400000hRWD16 dq	0000000200000003h,0000000000000001h; Total bytes of code: 64

to instead generate:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M40807_IG01: ;; offset=0x0000 ;; size=0 bbWeight=1 PerfScore 0.00G_M40807_IG02: ;; offset=0x0000vpermilpsxmm0, xmmword ptr [reloc @RWD00],27vmovups xmmword ptr [rcx],xmm0movrax,rcx ;; size=17 bbWeight=1 PerfScore 4.25G_M40807_IG03: ;; offset=0x0011ret ;; size=1 bbWeight=1 PerfScore 1.00RWD00 dq	400000003F800000h,4080000040400000h; Total bytes of code: 18

---

Due to limitations in forward sub, this does not handle some other cases where other statements interfere with the ability to substitute.

Doing this post global morph is much more difficult as the call gets rewritten to spilled locals, such as:

fgMorphTreeBB01,STMT00002(after)[000016]SACXG+-----*CALLvoid System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float][000021]DA--------- arg1 setup +--* STORE_LCL_VAR simd16<System.Runtime.Intrinsics.Vector128`1>(AX) V04 tmp2 [000014]-----+-----| \--*HWINTRINSIC simd16 float Add
[000012]-----+-----|+--*LCL_VAR simd16 V03 tmp1 [000013]-----+-----| \--*LCL_VARsimd16 V03 tmp1 (lastuse)[000022]-----------arg1in rdx +--*LCL_ADDR long V04 tmp2 [+0][000015]-----+-----arg2in r8 +--*LCL_ADDR long V01 loc0 [+0][000017]-----+-----retbufin rcx \--*LCL_VAR byref V00 RetBuf 

This is basically the same reason we can't do what GT_INTRINSIC does by just carrying a GT_HWINTRINSIC down to rationalization and rewriting it back to a call. The ABI handling around return buffers and parameter passing happens very early today (return buffers around import and parameter passing in global morph). If the ABI handling were moved down, then we could move this logic later (such as post VN) and catch essentially all cases instead.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[tannergooding]

Ended up replacing this with #102702, which allows it to be done in rationalization instead and so can cover many more scenarios.

[tannergooding]

This changes:

privatestaticVector128<float>Test(){vary=Vector128.Create(3,2,1,0);returnVector128.Shuffle(Vector128.Create(1.0f,2.0f,3.0f,4.0f),y);}

From generating:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M000_IG01: ;; offset=0x0000pushrbxsubrsp,64movrbx,rcxG_M000_IG02: ;; offset=0x0008vmovupsxmm0, xmmword ptr [reloc @RWD00] vmovaps xmmword ptr [rsp+0x30],xmm0vmovupsxmm0, xmmword ptr [reloc @RWD16] vmovaps xmmword ptr [rsp+0x20],xmm0leardx,[rsp+0x30]lear8,[rsp+0x20]movrcx,rbxcall[System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float]]movrax,rbxG_M000_IG03: ;; offset=0x003Aaddrsp,64poprbxretRWD00 dq	400000003F800000h,4080000040400000hRWD16 dq	0000000200000003h,0000000000000001h; Total bytes of code: 64

to instead generate:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M40807_IG01: ;; offset=0x0000 ;; size=0 bbWeight=1 PerfScore 0.00G_M40807_IG02: ;; offset=0x0000vpermilpsxmm0, xmmword ptr [reloc @RWD00],27vmovups xmmword ptr [rcx],xmm0movrax,rcx ;; size=17 bbWeight=1 PerfScore 4.25G_M40807_IG03: ;; offset=0x0011ret ;; size=1 bbWeight=1 PerfScore 1.00RWD00 dq	400000003F800000h,4080000040400000h; Total bytes of code: 18

---

Due to limitations in forward sub, this does not handle some other cases where other statements interfere with the ability to substitute.

Doing this post global morph is much more difficult as the call gets rewritten to spilled locals, such as:

fgMorphTreeBB01,STMT00002(after)[000016]SACXG+-----*CALLvoid System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float][000021]DA--------- arg1 setup +--* STORE_LCL_VAR simd16<System.Runtime.Intrinsics.Vector128`1>(AX) V04 tmp2 [000014]-----+-----| \--*HWINTRINSIC simd16 float Add
[000012]-----+-----|+--*LCL_VAR simd16 V03 tmp1 [000013]-----+-----| \--*LCL_VARsimd16 V03 tmp1 (lastuse)[000022]-----------arg1in rdx +--*LCL_ADDR long V04 tmp2 [+0][000015]-----+-----arg2in r8 +--*LCL_ADDR long V01 loc0 [+0][000017]-----+-----retbufin rcx \--*LCL_VAR byref V00 RetBuf 

This is basically the same reason we can't do what GT_INTRINSIC does by just carrying a GT_HWINTRINSIC down to rationalization and rewriting it back to a call. The ABI handling around return buffers and parameter passing happens very early today (return buffers around import and parameter passing in global morph). If the ABI handling were moved down, then we could move this logic later (such as post VN) and catch essentially all cases instead.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[tannergooding]

Ended up replacing this with #102702, which allows it to be done in rationalization instead and so can cover many more scenarios.

[tannergooding]

This changes:

privatestaticVector128<float>Test(){vary=Vector128.Create(3,2,1,0);returnVector128.Shuffle(Vector128.Create(1.0f,2.0f,3.0f,4.0f),y);}

From generating:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M000_IG01: ;; offset=0x0000pushrbxsubrsp,64movrbx,rcxG_M000_IG02: ;; offset=0x0008vmovupsxmm0, xmmword ptr [reloc @RWD00] vmovaps xmmword ptr [rsp+0x30],xmm0vmovupsxmm0, xmmword ptr [reloc @RWD16] vmovaps xmmword ptr [rsp+0x20],xmm0leardx,[rsp+0x30]lear8,[rsp+0x20]movrcx,rbxcall[System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float]]movrax,rbxG_M000_IG03: ;; offset=0x003Aaddrsp,64poprbxretRWD00 dq	400000003F800000h,4080000040400000hRWD16 dq	0000000200000003h,0000000000000001h; Total bytes of code: 64

to instead generate:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M40807_IG01: ;; offset=0x0000 ;; size=0 bbWeight=1 PerfScore 0.00G_M40807_IG02: ;; offset=0x0000vpermilpsxmm0, xmmword ptr [reloc @RWD00],27vmovups xmmword ptr [rcx],xmm0movrax,rcx ;; size=17 bbWeight=1 PerfScore 4.25G_M40807_IG03: ;; offset=0x0011ret ;; size=1 bbWeight=1 PerfScore 1.00RWD00 dq	400000003F800000h,4080000040400000h; Total bytes of code: 18

---

Due to limitations in forward sub, this does not handle some other cases where other statements interfere with the ability to substitute.

Doing this post global morph is much more difficult as the call gets rewritten to spilled locals, such as:

fgMorphTreeBB01,STMT00002(after)[000016]SACXG+-----*CALLvoid System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float][000021]DA--------- arg1 setup +--* STORE_LCL_VAR simd16<System.Runtime.Intrinsics.Vector128`1>(AX) V04 tmp2 [000014]-----+-----| \--*HWINTRINSIC simd16 float Add
[000012]-----+-----|+--*LCL_VAR simd16 V03 tmp1 [000013]-----+-----| \--*LCL_VARsimd16 V03 tmp1 (lastuse)[000022]-----------arg1in rdx +--*LCL_ADDR long V04 tmp2 [+0][000015]-----+-----arg2in r8 +--*LCL_ADDR long V01 loc0 [+0][000017]-----+-----retbufin rcx \--*LCL_VAR byref V00 RetBuf 

This is basically the same reason we can't do what GT_INTRINSIC does by just carrying a GT_HWINTRINSIC down to rationalization and rewriting it back to a call. The ABI handling around return buffers and parameter passing happens very early today (return buffers around import and parameter passing in global morph). If the ABI handling were moved down, then we could move this logic later (such as post VN) and catch essentially all cases instead.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[tannergooding]

Ended up replacing this with #102702, which allows it to be done in rationalization instead and so can cover many more scenarios.

[tannergooding]

This changes:

privatestaticVector128<float>Test(){vary=Vector128.Create(3,2,1,0);returnVector128.Shuffle(Vector128.Create(1.0f,2.0f,3.0f,4.0f),y);}

From generating:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M000_IG01: ;; offset=0x0000pushrbxsubrsp,64movrbx,rcxG_M000_IG02: ;; offset=0x0008vmovupsxmm0, xmmword ptr [reloc @RWD00] vmovaps xmmword ptr [rsp+0x30],xmm0vmovupsxmm0, xmmword ptr [reloc @RWD16] vmovaps xmmword ptr [rsp+0x20],xmm0leardx,[rsp+0x30]lear8,[rsp+0x20]movrcx,rbxcall[System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float]]movrax,rbxG_M000_IG03: ;; offset=0x003Aaddrsp,64poprbxretRWD00 dq	400000003F800000h,4080000040400000hRWD16 dq	0000000200000003h,0000000000000001h; Total bytes of code: 64

to instead generate:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M40807_IG01: ;; offset=0x0000 ;; size=0 bbWeight=1 PerfScore 0.00G_M40807_IG02: ;; offset=0x0000vpermilpsxmm0, xmmword ptr [reloc @RWD00],27vmovups xmmword ptr [rcx],xmm0movrax,rcx ;; size=17 bbWeight=1 PerfScore 4.25G_M40807_IG03: ;; offset=0x0011ret ;; size=1 bbWeight=1 PerfScore 1.00RWD00 dq	400000003F800000h,4080000040400000h; Total bytes of code: 18

---

Due to limitations in forward sub, this does not handle some other cases where other statements interfere with the ability to substitute.

Doing this post global morph is much more difficult as the call gets rewritten to spilled locals, such as:

fgMorphTreeBB01,STMT00002(after)[000016]SACXG+-----*CALLvoid System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float][000021]DA--------- arg1 setup +--* STORE_LCL_VAR simd16<System.Runtime.Intrinsics.Vector128`1>(AX) V04 tmp2 [000014]-----+-----| \--*HWINTRINSIC simd16 float Add
[000012]-----+-----|+--*LCL_VAR simd16 V03 tmp1 [000013]-----+-----| \--*LCL_VARsimd16 V03 tmp1 (lastuse)[000022]-----------arg1in rdx +--*LCL_ADDR long V04 tmp2 [+0][000015]-----+-----arg2in r8 +--*LCL_ADDR long V01 loc0 [+0][000017]-----+-----retbufin rcx \--*LCL_VAR byref V00 RetBuf 

This is basically the same reason we can't do what GT_INTRINSIC does by just carrying a GT_HWINTRINSIC down to rationalization and rewriting it back to a call. The ABI handling around return buffers and parameter passing happens very early today (return buffers around import and parameter passing in global morph). If the ABI handling were moved down, then we could move this logic later (such as post VN) and catch essentially all cases instead.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[tannergooding]

Ended up replacing this with #102702, which allows it to be done in rationalization instead and so can cover many more scenarios.

[tannergooding]

This changes:

privatestaticVector128<float>Test(){vary=Vector128.Create(3,2,1,0);returnVector128.Shuffle(Vector128.Create(1.0f,2.0f,3.0f,4.0f),y);}

From generating:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M000_IG01: ;; offset=0x0000pushrbxsubrsp,64movrbx,rcxG_M000_IG02: ;; offset=0x0008vmovupsxmm0, xmmword ptr [reloc @RWD00] vmovaps xmmword ptr [rsp+0x30],xmm0vmovupsxmm0, xmmword ptr [reloc @RWD16] vmovaps xmmword ptr [rsp+0x20],xmm0leardx,[rsp+0x30]lear8,[rsp+0x20]movrcx,rbxcall[System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float]]movrax,rbxG_M000_IG03: ;; offset=0x003Aaddrsp,64poprbxretRWD00 dq	400000003F800000h,4080000040400000hRWD16 dq	0000000200000003h,0000000000000001h; Total bytes of code: 64

to instead generate:

; Method Program:Test():System.Runtime.Intrinsics.Vector128`1[float] (FullOpts)G_M40807_IG01: ;; offset=0x0000 ;; size=0 bbWeight=1 PerfScore 0.00G_M40807_IG02: ;; offset=0x0000vpermilpsxmm0, xmmword ptr [reloc @RWD00],27vmovups xmmword ptr [rcx],xmm0movrax,rcx ;; size=17 bbWeight=1 PerfScore 4.25G_M40807_IG03: ;; offset=0x0011ret ;; size=1 bbWeight=1 PerfScore 1.00RWD00 dq	400000003F800000h,4080000040400000h; Total bytes of code: 18

---

Due to limitations in forward sub, this does not handle some other cases where other statements interfere with the ability to substitute.

Doing this post global morph is much more difficult as the call gets rewritten to spilled locals, such as:

fgMorphTreeBB01,STMT00002(after)[000016]SACXG+-----*CALLvoid System.Runtime.Intrinsics.Vector128:Shuffle(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[int]):System.Runtime.Intrinsics.Vector128`1[float][000021]DA--------- arg1 setup +--* STORE_LCL_VAR simd16<System.Runtime.Intrinsics.Vector128`1>(AX) V04 tmp2 [000014]-----+-----| \--*HWINTRINSIC simd16 float Add
[000012]-----+-----|+--*LCL_VAR simd16 V03 tmp1 [000013]-----+-----| \--*LCL_VARsimd16 V03 tmp1 (lastuse)[000022]-----------arg1in rdx +--*LCL_ADDR long V04 tmp2 [+0][000015]-----+-----arg2in r8 +--*LCL_ADDR long V01 loc0 [+0][000017]-----+-----retbufin rcx \--*LCL_VAR byref V00 RetBuf 

This is basically the same reason we can't do what GT_INTRINSIC does by just carrying a GT_HWINTRINSIC down to rationalization and rewriting it back to a call. The ABI handling around return buffers and parameter passing happens very early today (return buffers around import and parameter passing in global morph). If the ABI handling were moved down, then we could move this logic later (such as post VN) and catch essentially all cases instead.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[tannergooding]

Ended up replacing this with #102702, which allows it to be done in rationalization instead and so can cover many more scenarios.