Skip to content

JIT: Prototype an aggressive SSA-based dead code elimination phase - #103087

Closed
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce
Closed

JIT: Prototype an aggressive SSA-based dead code elimination phase#103087
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

Unlike normal liveness based DCE, this algorithm is able to remove loops that do not compute any values that are externally visible.

The algorithm implemented here appears in Cytron, Ron, et al. "Efficiently computing static single assignment form and the control dependence graph.". It was implemented in collaboration with @AndyAyersMS and @TIHan.

Example:

publicstaticvoidMain(){for(inti=0;i<100;i++){}Console.WriteLine("Hello");}

Before:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M48905_IG02: ;; offset=0x0004movecx,100align[0 bytes for IG03] ;; size=5 bbWeight=1 PerfScore 0.25G_M48905_IG03: ;; offset=0x0009dececxjne SHORT G_M48905_IG03 ;; size=4 bbWeight=4 PerfScore 5.00G_M48905_IG04: ;; offset=0x000Dmovrcx,0x1ECD7572C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=1 PerfScore 3.50G_M48905_IG05: ;; offset=0x001Eaddrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25

After:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=4 PerfScore 1.00G_M48905_IG02: ;; offset=0x0004movrcx,0x277EDA22C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=4 PerfScore 14.00G_M48905_IG03: ;; offset=0x0015addrsp,40ret ;; size=5 bbWeight=4 PerfScore 5.00

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 5, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

This algorithm unfortunately does not seem to be compatible with IL semantics. In particular it is very non-trivial to identify when we can get rid of conditional backedges because it requires us to prove that the forward edge will eventually be taken. That is, for an example like

publicstaticvoidTest(intk){for(inti=0;i<=k;i++){}}

the algorithm naturally uncovers that the loop has no side effect, and will happily delete i++ and mark the loop condition as dead. However, it is not correct to actually remove this loop, since we do not know whether it will be infinite or not. Detecting in general whether a cycle in the flow graph will be taken indefinitely seems intractable for us. In C/C++ removing these loops is ok because it is UB for them to be infinite.

@build-analysisbuild-analysisBot mentioned this pull request Jun 5, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
JIT: Prototype an aggressive SSA-based dead code elimination phase by jakobbotsch · Pull Request #103087 · dotnet/runtime · GitHub
Skip to content

JIT: Prototype an aggressive SSA-based dead code elimination phase - #103087

Closed
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce
Closed

JIT: Prototype an aggressive SSA-based dead code elimination phase#103087
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

Unlike normal liveness based DCE, this algorithm is able to remove loops that do not compute any values that are externally visible.

The algorithm implemented here appears in Cytron, Ron, et al. "Efficiently computing static single assignment form and the control dependence graph.". It was implemented in collaboration with @AndyAyersMS and @TIHan.

Example:

publicstaticvoidMain(){for(inti=0;i<100;i++){}Console.WriteLine("Hello");}

Before:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M48905_IG02: ;; offset=0x0004movecx,100align[0 bytes for IG03] ;; size=5 bbWeight=1 PerfScore 0.25G_M48905_IG03: ;; offset=0x0009dececxjne SHORT G_M48905_IG03 ;; size=4 bbWeight=4 PerfScore 5.00G_M48905_IG04: ;; offset=0x000Dmovrcx,0x1ECD7572C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=1 PerfScore 3.50G_M48905_IG05: ;; offset=0x001Eaddrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25

After:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=4 PerfScore 1.00G_M48905_IG02: ;; offset=0x0004movrcx,0x277EDA22C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=4 PerfScore 14.00G_M48905_IG03: ;; offset=0x0015addrsp,40ret ;; size=5 bbWeight=4 PerfScore 5.00

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 5, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

This algorithm unfortunately does not seem to be compatible with IL semantics. In particular it is very non-trivial to identify when we can get rid of conditional backedges because it requires us to prove that the forward edge will eventually be taken. That is, for an example like

publicstaticvoidTest(intk){for(inti=0;i<=k;i++){}}

the algorithm naturally uncovers that the loop has no side effect, and will happily delete i++ and mark the loop condition as dead. However, it is not correct to actually remove this loop, since we do not know whether it will be infinite or not. Detecting in general whether a cycle in the flow graph will be taken indefinitely seems intractable for us. In C/C++ removing these loops is ok because it is UB for them to be infinite.

@build-analysisbuild-analysisBot mentioned this pull request Jun 5, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' JIT: Prototype an aggressive SSA-based dead code elimination phase by jakobbotsch · Pull Request #103087 · dotnet/runtime · GitHub
Skip to content

JIT: Prototype an aggressive SSA-based dead code elimination phase - #103087

Closed
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce
Closed

JIT: Prototype an aggressive SSA-based dead code elimination phase#103087
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

Unlike normal liveness based DCE, this algorithm is able to remove loops that do not compute any values that are externally visible.

The algorithm implemented here appears in Cytron, Ron, et al. "Efficiently computing static single assignment form and the control dependence graph.". It was implemented in collaboration with @AndyAyersMS and @TIHan.

Example:

publicstaticvoidMain(){for(inti=0;i<100;i++){}Console.WriteLine("Hello");}

Before:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M48905_IG02: ;; offset=0x0004movecx,100align[0 bytes for IG03] ;; size=5 bbWeight=1 PerfScore 0.25G_M48905_IG03: ;; offset=0x0009dececxjne SHORT G_M48905_IG03 ;; size=4 bbWeight=4 PerfScore 5.00G_M48905_IG04: ;; offset=0x000Dmovrcx,0x1ECD7572C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=1 PerfScore 3.50G_M48905_IG05: ;; offset=0x001Eaddrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25

After:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=4 PerfScore 1.00G_M48905_IG02: ;; offset=0x0004movrcx,0x277EDA22C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=4 PerfScore 14.00G_M48905_IG03: ;; offset=0x0015addrsp,40ret ;; size=5 bbWeight=4 PerfScore 5.00

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 5, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

This algorithm unfortunately does not seem to be compatible with IL semantics. In particular it is very non-trivial to identify when we can get rid of conditional backedges because it requires us to prove that the forward edge will eventually be taken. That is, for an example like

publicstaticvoidTest(intk){for(inti=0;i<=k;i++){}}

the algorithm naturally uncovers that the loop has no side effect, and will happily delete i++ and mark the loop condition as dead. However, it is not correct to actually remove this loop, since we do not know whether it will be infinite or not. Detecting in general whether a cycle in the flow graph will be taken indefinitely seems intractable for us. In C/C++ removing these loops is ok because it is UB for them to be infinite.

@build-analysisbuild-analysisBot mentioned this pull request Jun 5, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' JIT: Prototype an aggressive SSA-based dead code elimination phase by jakobbotsch · Pull Request #103087 · dotnet/runtime · GitHub
Skip to content

JIT: Prototype an aggressive SSA-based dead code elimination phase - #103087

Closed
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce
Closed

JIT: Prototype an aggressive SSA-based dead code elimination phase#103087
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

Unlike normal liveness based DCE, this algorithm is able to remove loops that do not compute any values that are externally visible.

The algorithm implemented here appears in Cytron, Ron, et al. "Efficiently computing static single assignment form and the control dependence graph.". It was implemented in collaboration with @AndyAyersMS and @TIHan.

Example:

publicstaticvoidMain(){for(inti=0;i<100;i++){}Console.WriteLine("Hello");}

Before:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M48905_IG02: ;; offset=0x0004movecx,100align[0 bytes for IG03] ;; size=5 bbWeight=1 PerfScore 0.25G_M48905_IG03: ;; offset=0x0009dececxjne SHORT G_M48905_IG03 ;; size=4 bbWeight=4 PerfScore 5.00G_M48905_IG04: ;; offset=0x000Dmovrcx,0x1ECD7572C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=1 PerfScore 3.50G_M48905_IG05: ;; offset=0x001Eaddrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25

After:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=4 PerfScore 1.00G_M48905_IG02: ;; offset=0x0004movrcx,0x277EDA22C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=4 PerfScore 14.00G_M48905_IG03: ;; offset=0x0015addrsp,40ret ;; size=5 bbWeight=4 PerfScore 5.00

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 5, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

This algorithm unfortunately does not seem to be compatible with IL semantics. In particular it is very non-trivial to identify when we can get rid of conditional backedges because it requires us to prove that the forward edge will eventually be taken. That is, for an example like

publicstaticvoidTest(intk){for(inti=0;i<=k;i++){}}

the algorithm naturally uncovers that the loop has no side effect, and will happily delete i++ and mark the loop condition as dead. However, it is not correct to actually remove this loop, since we do not know whether it will be infinite or not. Detecting in general whether a cycle in the flow graph will be taken indefinitely seems intractable for us. In C/C++ removing these loops is ok because it is UB for them to be infinite.

@build-analysisbuild-analysisBot mentioned this pull request Jun 5, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' JIT: Prototype an aggressive SSA-based dead code elimination phase by jakobbotsch · Pull Request #103087 · dotnet/runtime · GitHub
Skip to content

JIT: Prototype an aggressive SSA-based dead code elimination phase - #103087

Closed
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce
Closed

JIT: Prototype an aggressive SSA-based dead code elimination phase#103087
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

Unlike normal liveness based DCE, this algorithm is able to remove loops that do not compute any values that are externally visible.

The algorithm implemented here appears in Cytron, Ron, et al. "Efficiently computing static single assignment form and the control dependence graph.". It was implemented in collaboration with @AndyAyersMS and @TIHan.

Example:

publicstaticvoidMain(){for(inti=0;i<100;i++){}Console.WriteLine("Hello");}

Before:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M48905_IG02: ;; offset=0x0004movecx,100align[0 bytes for IG03] ;; size=5 bbWeight=1 PerfScore 0.25G_M48905_IG03: ;; offset=0x0009dececxjne SHORT G_M48905_IG03 ;; size=4 bbWeight=4 PerfScore 5.00G_M48905_IG04: ;; offset=0x000Dmovrcx,0x1ECD7572C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=1 PerfScore 3.50G_M48905_IG05: ;; offset=0x001Eaddrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25

After:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=4 PerfScore 1.00G_M48905_IG02: ;; offset=0x0004movrcx,0x277EDA22C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=4 PerfScore 14.00G_M48905_IG03: ;; offset=0x0015addrsp,40ret ;; size=5 bbWeight=4 PerfScore 5.00

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 5, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

This algorithm unfortunately does not seem to be compatible with IL semantics. In particular it is very non-trivial to identify when we can get rid of conditional backedges because it requires us to prove that the forward edge will eventually be taken. That is, for an example like

publicstaticvoidTest(intk){for(inti=0;i<=k;i++){}}

the algorithm naturally uncovers that the loop has no side effect, and will happily delete i++ and mark the loop condition as dead. However, it is not correct to actually remove this loop, since we do not know whether it will be infinite or not. Detecting in general whether a cycle in the flow graph will be taken indefinitely seems intractable for us. In C/C++ removing these loops is ok because it is UB for them to be infinite.

@build-analysisbuild-analysisBot mentioned this pull request Jun 5, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' JIT: Prototype an aggressive SSA-based dead code elimination phase by jakobbotsch · Pull Request #103087 · dotnet/runtime · GitHub
Skip to content

JIT: Prototype an aggressive SSA-based dead code elimination phase - #103087

Closed
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce
Closed

JIT: Prototype an aggressive SSA-based dead code elimination phase#103087
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

Unlike normal liveness based DCE, this algorithm is able to remove loops that do not compute any values that are externally visible.

The algorithm implemented here appears in Cytron, Ron, et al. "Efficiently computing static single assignment form and the control dependence graph.". It was implemented in collaboration with @AndyAyersMS and @TIHan.

Example:

publicstaticvoidMain(){for(inti=0;i<100;i++){}Console.WriteLine("Hello");}

Before:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M48905_IG02: ;; offset=0x0004movecx,100align[0 bytes for IG03] ;; size=5 bbWeight=1 PerfScore 0.25G_M48905_IG03: ;; offset=0x0009dececxjne SHORT G_M48905_IG03 ;; size=4 bbWeight=4 PerfScore 5.00G_M48905_IG04: ;; offset=0x000Dmovrcx,0x1ECD7572C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=1 PerfScore 3.50G_M48905_IG05: ;; offset=0x001Eaddrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25

After:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=4 PerfScore 1.00G_M48905_IG02: ;; offset=0x0004movrcx,0x277EDA22C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=4 PerfScore 14.00G_M48905_IG03: ;; offset=0x0015addrsp,40ret ;; size=5 bbWeight=4 PerfScore 5.00

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 5, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

This algorithm unfortunately does not seem to be compatible with IL semantics. In particular it is very non-trivial to identify when we can get rid of conditional backedges because it requires us to prove that the forward edge will eventually be taken. That is, for an example like

publicstaticvoidTest(intk){for(inti=0;i<=k;i++){}}

the algorithm naturally uncovers that the loop has no side effect, and will happily delete i++ and mark the loop condition as dead. However, it is not correct to actually remove this loop, since we do not know whether it will be infinite or not. Detecting in general whether a cycle in the flow graph will be taken indefinitely seems intractable for us. In C/C++ removing these loops is ok because it is UB for them to be infinite.

@build-analysisbuild-analysisBot mentioned this pull request Jun 5, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); JIT: Prototype an aggressive SSA-based dead code elimination phase by jakobbotsch · Pull Request #103087 · dotnet/runtime · GitHub
Skip to content

JIT: Prototype an aggressive SSA-based dead code elimination phase - #103087

Closed
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce
Closed

JIT: Prototype an aggressive SSA-based dead code elimination phase#103087
jakobbotsch wants to merge 9 commits into
dotnet:mainfrom
jakobbotsch:ssa-based-dce

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

Unlike normal liveness based DCE, this algorithm is able to remove loops that do not compute any values that are externally visible.

The algorithm implemented here appears in Cytron, Ron, et al. "Efficiently computing static single assignment form and the control dependence graph.". It was implemented in collaboration with @AndyAyersMS and @TIHan.

Example:

publicstaticvoidMain(){for(inti=0;i<100;i++){}Console.WriteLine("Hello");}

Before:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M48905_IG02: ;; offset=0x0004movecx,100align[0 bytes for IG03] ;; size=5 bbWeight=1 PerfScore 0.25G_M48905_IG03: ;; offset=0x0009dececxjne SHORT G_M48905_IG03 ;; size=4 bbWeight=4 PerfScore 5.00G_M48905_IG04: ;; offset=0x000Dmovrcx,0x1ECD7572C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=1 PerfScore 3.50G_M48905_IG05: ;; offset=0x001Eaddrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25

After:

G_M48905_IG01: ;; offset=0x0000subrsp,40 ;; size=4 bbWeight=4 PerfScore 1.00G_M48905_IG02: ;; offset=0x0004movrcx,0x277EDA22C30 ; 'Hello'call[System.Console:WriteLine(System.String)]nop ;; size=17 bbWeight=4 PerfScore 14.00G_M48905_IG03: ;; offset=0x0015addrsp,40ret ;; size=5 bbWeight=4 PerfScore 5.00

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 5, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

This algorithm unfortunately does not seem to be compatible with IL semantics. In particular it is very non-trivial to identify when we can get rid of conditional backedges because it requires us to prove that the forward edge will eventually be taken. That is, for an example like

publicstaticvoidTest(intk){for(inti=0;i<=k;i++){}}

the algorithm naturally uncovers that the loop has no side effect, and will happily delete i++ and mark the loop condition as dead. However, it is not correct to actually remove this loop, since we do not know whether it will be infinite or not. Detecting in general whether a cycle in the flow graph will be taken indefinitely seems intractable for us. In C/C++ removing these loops is ok because it is UB for them to be infinite.

@build-analysisbuild-analysisBot mentioned this pull request Jun 5, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobbotsch@AndyAyersMS