JIT: Added SVE Prefetch* APIs. - #103094

Merged
TIHan merged 20 commits into
dotnet:mainfrom
TIHan:sve-prefect-apis
Jun 12, 2024
Merged

JIT: Added SVE Prefetch* APIs.#103094
TIHan merged 20 commits into
dotnet:mainfrom
TIHan:sve-prefect-apis

Conversation

@TIHan

@TIHanTIHan commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

Contributes to #99957

Adds:

  • PrefetchBytes
  • PrefetchInt16
  • PrefetchInt32
  • PrefetchInt64

@ghost

ghost commented Jun 5, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Jun 5, 2024

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

TIHan
TIHan commented Jun 5, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
All = 31 // All available (implicitly a multiple of two).
};

public enum SvePrefetchType : byte

@TIHanTIHanJun 5, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalspathak@tannergooding was this enum type approved? I ask because of the SV_PLDL1KEEP names.

@kunalspathakkunalspathakJun 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?

#94006 (comment)

@a74nha74nhJun 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#97831 approved the Prefetch* APIs.

The enum should have been approved as part of that, but wasn't looked at directly.

@kunalspathakkunalspathakJun 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum names are different and were approved in #94007 (comment)

@kunalspathakkunalspathakJun 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TIHan - can you update the names accordingly?

@TIHan

TIHan commented Jun 5, 2024

Copy link
Copy Markdown
ContributorAuthor

@dotnet/arm64-contrib @kunalspathak this is ready. There is no visible output to validate since this instruction is intended to be a hint.

===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_0() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_1() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_2() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_3() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_4() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_5() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_6() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_7() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_8() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_9() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_10() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_11() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt16() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt32() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt64() : 3
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@TIHan
TIHanforce-pushed the sve-prefect-apis branch from c7b382d to 5c66924CompareJune 5, 2024 21:26
@kunalspathakkunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Jun 5, 2024
@kunalspathakkunalspathak mentioned this pull request Jun 5, 2024
Closed
kunalspathak
kunalspathak suggested changes Jun 5, 2024
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments.

Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
All = 31 // All available (implicitly a multiple of two).
};

public enum SvePrefetchType : byte

@kunalspathakkunalspathakJun 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?

#94006 (comment)

Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template Outdated
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template Outdated
Comment threadsrc/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs Outdated
@kunalspathak

kunalspathak commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

also, need to handle immediate value and table generation logic.

@kunalspathak

kunalspathak commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

@a74nh - so for this API, there is no visual side effect, so wondering how do we test it? also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.

This was referenced Jun 6, 2024
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 6, 2024
Open
Closed
@a74nh

a74nh commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

@a74nh - so for this API, there is no visual side effect, so wondering how do we test it?

I'm not sure if there is anything we can test for. We can't read the setting back from the system.

also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.

We can't pass 6 or 7 as an immediate as C# compile will fail. So this only applies where it's in a variable, and we generate the lookup table.

Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run. So, I don't think we should do anything special, and keep this patch as is.

@kunalspathak

kunalspathak commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

So this only applies where it's in a variable

Yes, i think the question was more towards variable and how we should handle it in table generation logic. It wasn't clear what translates to the prfop , if it was 6/7.

image

Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run.

Thanks for confirming this.

kunalspathak
kunalspathak reviewed Jun 6, 2024
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template Outdated
@TIHan

TIHan commented Jun 6, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.

See the original PR: #98468

@a74nh

a74nh commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.

See the original PR: #98468

Depends how you define valid :)
They don't do anything when used but they shouldn't cause an error. I think the code in #98468 is ok as it is.

TIHan
TIHan commented Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp
@build-analysisbuild-analysisBot mentioned this pull request Jun 11, 2024
Closed
tannergooding
tannergooding reviewed Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/rationalize.cpp Outdated
@tannergoodingtannergooding mentioned this pull request Jun 11, 2024
Merged
@TIHan
TIHanforce-pushed the sve-prefect-apis branch from a5d2203 to 086ebd3CompareJune 11, 2024 18:18
@TIHan

TIHan commented Jun 11, 2024

Copy link
Copy Markdown
ContributorAuthor

@kunalspathak this is ready again.

#103288 will need to be merged first before this one.

kunalspathak
kunalspathak suggested changes Jun 11, 2024
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some left over code that I don't think is needed. Also we should generalize the test template.

Comment threadsrc/coreclr/jit/fgdiagnostic.cpp Outdated
Comment threadsrc/coreclr/jit/gentree.cpp Outdated
Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h Outdated
Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h Outdated
Comment threadsrc/coreclr/jit/lsraarm64.cpp
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template Outdated
This was referenced Jun 12, 2024
Closed
Open
kunalspathak
kunalspathak approved these changes Jun 12, 2024
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@TIHan

TIHan commented Jun 12, 2024

Copy link
Copy Markdown
ContributorAuthor

Woo!

@TIHan
TIHan merged commit be2827c into dotnet:mainJun 12, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding left review comments
+2 more reviewers
@a74nha74nha74nh left review comments
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-System.Runtime.Intrinsicsarm-sveWork related to arm64 SVE/SVE2 supportnew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@kunalspathak@a74nh@tannergooding
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
JIT: Added SVE Prefetch* APIs. - #103094
Merged
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Jun 12, 2024
Merged
JIT: Added SVE Prefetch* APIs.#103094
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Conversation
@TIHan
@TIHanTIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Contributes to #99957
Adds:
  • PrefetchBytes
  • PrefetchInt16
  • PrefetchInt32
  • PrefetchInt64
@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

TIHan
TIHan
commented
Jun 5, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@TIHanTIHanJun 5, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalspathak@tannergooding was this enum type approved? I ask because of the SV_PLDL1KEEP names.
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
@a74nha74nhJun 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#97831 approved the Prefetch* APIs.
The enum should have been approved as part of that, but wasn't looked at directly.
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum names are different and were approved in #94007 (comment)
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TIHan - can you update the names accordingly?
@TIHan
TIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib @kunalspathak this is ready. There is no visible output to validate since this instruction is intended to be a hint.
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_0() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_1() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_2() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_3() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_4() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_5() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_6() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_7() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_8() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_9() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_10() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_11() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt16() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt32() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt64() : 3
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
c7b382d to
5c66924CompareJune 5, 2024 21:26
@kunalspathakkunalspathak
added
the 
arm-sve
Work related to arm64 SVE/SVE2 support
label
Jun 5, 2024
@kunalspathakkunalspathak
mentioned this pull request
Jun 5, 2024

Closed

kunalspathak
kunalspathak
suggested changes
Jun 5, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments.
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Outdated

@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
also, need to handle immediate value and table generation logic.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it? also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.

This was referenced Jun 6, 2024

Closed


Closed


Closed


Closed


Closed


Closed


This was referenced Jun 6, 2024

Open


Closed

@a74nh
a74nh
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it?
I'm not sure if there is anything we can test for. We can't read the setting back from the system.
also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.
We can't pass 6 or 7 as an immediate as C# compile will fail. So this only applies where it's in a variable, and we generate the lookup table.
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run. So, I don't think we should do anything special, and keep this patch as is.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
So this only applies where it's in a variable
Yes, i think the question was more towards variable and how we should handle it in table generation logic. It wasn't clear what translates to the prfop , if it was 6/7.
image
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run.
Thanks for confirming this.
kunalspathak
kunalspathak
reviewed
Jun 6, 2024
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

@TIHan
TIHan
commented
Jun 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
@a74nh
a74nh
commented
Jun 7, 2024

Copy link


Copy Markdown

Contributor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
Depends how you define valid :)

They don't do anything when used but they shouldn't cause an error. I think the code in #98468 is ok as it is.
TIHan
TIHan
commented
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 11, 2024

Closed

tannergooding
tannergooding
reviewed
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/rationalize.cpp
Outdated

@tannergoodingtannergooding
mentioned this pull request
Jun 11, 2024
 Merged

@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
a5d2203 to
086ebd3CompareJune 11, 2024 18:18
@TIHan
TIHan
commented
Jun 11, 2024

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak this is ready again.
#103288 will need to be merged first before this one.
kunalspathak
kunalspathak
suggested changes
Jun 11, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some left over code that I don't think is needed. Also we should generalize the test template.
Comment threadsrc/coreclr/jit/fgdiagnostic.cpp
Outdated

Comment threadsrc/coreclr/jit/gentree.cpp
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/lsraarm64.cpp
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated


This was referenced Jun 12, 2024

Closed


Open

kunalspathak
kunalspathak
approved these changes
Jun 12, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
@TIHan
TIHan
commented
Jun 12, 2024

Copy link


Copy Markdown

ContributorAuthor
Woo!
@TIHan
TIHan
merged commit be2827c
into
dotnet:mainJun 12, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding left review comments

+2 more reviewers

@a74nha74nha74nh left review comments
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-System.Runtime.Intrinsicsarm-sveWork related to arm64 SVE/SVE2 supportnew-api-needs-documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@kunalspathak@a74nh@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
JIT: Added SVE Prefetch* APIs. - #103094
Merged
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Jun 12, 2024
Merged
JIT: Added SVE Prefetch* APIs.#103094
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Conversation
@TIHan
@TIHanTIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Contributes to #99957
Adds:
  • PrefetchBytes
  • PrefetchInt16
  • PrefetchInt32
  • PrefetchInt64
@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

TIHan
TIHan
commented
Jun 5, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@TIHanTIHanJun 5, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalspathak@tannergooding was this enum type approved? I ask because of the SV_PLDL1KEEP names.
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
@a74nha74nhJun 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#97831 approved the Prefetch* APIs.
The enum should have been approved as part of that, but wasn't looked at directly.
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum names are different and were approved in #94007 (comment)
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TIHan - can you update the names accordingly?
@TIHan
TIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib @kunalspathak this is ready. There is no visible output to validate since this instruction is intended to be a hint.
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_0() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_1() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_2() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_3() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_4() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_5() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_6() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_7() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_8() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_9() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_10() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_11() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt16() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt32() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt64() : 3
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
c7b382d to
5c66924CompareJune 5, 2024 21:26
@kunalspathakkunalspathak
added
the 
arm-sve
Work related to arm64 SVE/SVE2 support
label
Jun 5, 2024
@kunalspathakkunalspathak
mentioned this pull request
Jun 5, 2024

Closed

kunalspathak
kunalspathak
suggested changes
Jun 5, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments.
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Outdated

@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
also, need to handle immediate value and table generation logic.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it? also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.

This was referenced Jun 6, 2024

Closed


Closed


Closed


Closed


Closed


Closed


This was referenced Jun 6, 2024

Open


Closed

@a74nh
a74nh
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it?
I'm not sure if there is anything we can test for. We can't read the setting back from the system.
also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.
We can't pass 6 or 7 as an immediate as C# compile will fail. So this only applies where it's in a variable, and we generate the lookup table.
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run. So, I don't think we should do anything special, and keep this patch as is.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
So this only applies where it's in a variable
Yes, i think the question was more towards variable and how we should handle it in table generation logic. It wasn't clear what translates to the prfop , if it was 6/7.
image
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run.
Thanks for confirming this.
kunalspathak
kunalspathak
reviewed
Jun 6, 2024
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

@TIHan
TIHan
commented
Jun 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
@a74nh
a74nh
commented
Jun 7, 2024

Copy link


Copy Markdown

Contributor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
Depends how you define valid :)

They don't do anything when used but they shouldn't cause an error. I think the code in #98468 is ok as it is.
TIHan
TIHan
commented
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 11, 2024

Closed

tannergooding
tannergooding
reviewed
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/rationalize.cpp
Outdated

@tannergoodingtannergooding
mentioned this pull request
Jun 11, 2024
 Merged

@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
a5d2203 to
086ebd3CompareJune 11, 2024 18:18
@TIHan
TIHan
commented
Jun 11, 2024

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak this is ready again.
#103288 will need to be merged first before this one.
kunalspathak
kunalspathak
suggested changes
Jun 11, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some left over code that I don't think is needed. Also we should generalize the test template.
Comment threadsrc/coreclr/jit/fgdiagnostic.cpp
Outdated

Comment threadsrc/coreclr/jit/gentree.cpp
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/lsraarm64.cpp
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated


This was referenced Jun 12, 2024

Closed


Open

kunalspathak
kunalspathak
approved these changes
Jun 12, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
@TIHan
TIHan
commented
Jun 12, 2024

Copy link


Copy Markdown

ContributorAuthor
Woo!
@TIHan
TIHan
merged commit be2827c
into
dotnet:mainJun 12, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding left review comments

+2 more reviewers

@a74nha74nha74nh left review comments
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-System.Runtime.Intrinsicsarm-sveWork related to arm64 SVE/SVE2 supportnew-api-needs-documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@kunalspathak@a74nh@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
JIT: Added SVE Prefetch* APIs. - #103094
Merged
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Jun 12, 2024
Merged
JIT: Added SVE Prefetch* APIs.#103094
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Conversation
@TIHan
@TIHanTIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Contributes to #99957
Adds:
  • PrefetchBytes
  • PrefetchInt16
  • PrefetchInt32
  • PrefetchInt64
@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

TIHan
TIHan
commented
Jun 5, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@TIHanTIHanJun 5, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalspathak@tannergooding was this enum type approved? I ask because of the SV_PLDL1KEEP names.
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
@a74nha74nhJun 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#97831 approved the Prefetch* APIs.
The enum should have been approved as part of that, but wasn't looked at directly.
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum names are different and were approved in #94007 (comment)
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TIHan - can you update the names accordingly?
@TIHan
TIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib @kunalspathak this is ready. There is no visible output to validate since this instruction is intended to be a hint.
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_0() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_1() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_2() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_3() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_4() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_5() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_6() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_7() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_8() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_9() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_10() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_11() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt16() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt32() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt64() : 3
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
c7b382d to
5c66924CompareJune 5, 2024 21:26
@kunalspathakkunalspathak
added
the 
arm-sve
Work related to arm64 SVE/SVE2 support
label
Jun 5, 2024
@kunalspathakkunalspathak
mentioned this pull request
Jun 5, 2024

Closed

kunalspathak
kunalspathak
suggested changes
Jun 5, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments.
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Outdated

@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
also, need to handle immediate value and table generation logic.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it? also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.

This was referenced Jun 6, 2024

Closed


Closed


Closed


Closed


Closed


Closed


This was referenced Jun 6, 2024

Open


Closed

@a74nh
a74nh
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it?
I'm not sure if there is anything we can test for. We can't read the setting back from the system.
also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.
We can't pass 6 or 7 as an immediate as C# compile will fail. So this only applies where it's in a variable, and we generate the lookup table.
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run. So, I don't think we should do anything special, and keep this patch as is.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
So this only applies where it's in a variable
Yes, i think the question was more towards variable and how we should handle it in table generation logic. It wasn't clear what translates to the prfop , if it was 6/7.
image
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run.
Thanks for confirming this.
kunalspathak
kunalspathak
reviewed
Jun 6, 2024
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

@TIHan
TIHan
commented
Jun 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
@a74nh
a74nh
commented
Jun 7, 2024

Copy link


Copy Markdown

Contributor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
Depends how you define valid :)

They don't do anything when used but they shouldn't cause an error. I think the code in #98468 is ok as it is.
TIHan
TIHan
commented
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 11, 2024

Closed

tannergooding
tannergooding
reviewed
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/rationalize.cpp
Outdated

@tannergoodingtannergooding
mentioned this pull request
Jun 11, 2024
 Merged

@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
a5d2203 to
086ebd3CompareJune 11, 2024 18:18
@TIHan
TIHan
commented
Jun 11, 2024

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak this is ready again.
#103288 will need to be merged first before this one.
kunalspathak
kunalspathak
suggested changes
Jun 11, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some left over code that I don't think is needed. Also we should generalize the test template.
Comment threadsrc/coreclr/jit/fgdiagnostic.cpp
Outdated

Comment threadsrc/coreclr/jit/gentree.cpp
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/lsraarm64.cpp
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated


This was referenced Jun 12, 2024

Closed


Open

kunalspathak
kunalspathak
approved these changes
Jun 12, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
@TIHan
TIHan
commented
Jun 12, 2024

Copy link


Copy Markdown

ContributorAuthor
Woo!
@TIHan
TIHan
merged commit be2827c
into
dotnet:mainJun 12, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding left review comments

+2 more reviewers

@a74nha74nha74nh left review comments
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-System.Runtime.Intrinsicsarm-sveWork related to arm64 SVE/SVE2 supportnew-api-needs-documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@kunalspathak@a74nh@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
JIT: Added SVE Prefetch* APIs. - #103094
Merged
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Jun 12, 2024
Merged
JIT: Added SVE Prefetch* APIs.#103094
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Conversation
@TIHan
@TIHanTIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Contributes to #99957
Adds:
  • PrefetchBytes
  • PrefetchInt16
  • PrefetchInt32
  • PrefetchInt64
@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

TIHan
TIHan
commented
Jun 5, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@TIHanTIHanJun 5, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalspathak@tannergooding was this enum type approved? I ask because of the SV_PLDL1KEEP names.
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
@a74nha74nhJun 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#97831 approved the Prefetch* APIs.
The enum should have been approved as part of that, but wasn't looked at directly.
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum names are different and were approved in #94007 (comment)
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TIHan - can you update the names accordingly?
@TIHan
TIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib @kunalspathak this is ready. There is no visible output to validate since this instruction is intended to be a hint.
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_0() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_1() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_2() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_3() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_4() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_5() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_6() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_7() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_8() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_9() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_10() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_11() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt16() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt32() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt64() : 3
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
c7b382d to
5c66924CompareJune 5, 2024 21:26
@kunalspathakkunalspathak
added
the 
arm-sve
Work related to arm64 SVE/SVE2 support
label
Jun 5, 2024
@kunalspathakkunalspathak
mentioned this pull request
Jun 5, 2024

Closed

kunalspathak
kunalspathak
suggested changes
Jun 5, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments.
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Outdated

@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
also, need to handle immediate value and table generation logic.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it? also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.

This was referenced Jun 6, 2024

Closed


Closed


Closed


Closed


Closed


Closed


This was referenced Jun 6, 2024

Open


Closed

@a74nh
a74nh
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it?
I'm not sure if there is anything we can test for. We can't read the setting back from the system.
also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.
We can't pass 6 or 7 as an immediate as C# compile will fail. So this only applies where it's in a variable, and we generate the lookup table.
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run. So, I don't think we should do anything special, and keep this patch as is.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
So this only applies where it's in a variable
Yes, i think the question was more towards variable and how we should handle it in table generation logic. It wasn't clear what translates to the prfop , if it was 6/7.
image
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run.
Thanks for confirming this.
kunalspathak
kunalspathak
reviewed
Jun 6, 2024
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

@TIHan
TIHan
commented
Jun 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
@a74nh
a74nh
commented
Jun 7, 2024

Copy link


Copy Markdown

Contributor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
Depends how you define valid :)

They don't do anything when used but they shouldn't cause an error. I think the code in #98468 is ok as it is.
TIHan
TIHan
commented
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 11, 2024

Closed

tannergooding
tannergooding
reviewed
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/rationalize.cpp
Outdated

@tannergoodingtannergooding
mentioned this pull request
Jun 11, 2024
 Merged

@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
a5d2203 to
086ebd3CompareJune 11, 2024 18:18
@TIHan
TIHan
commented
Jun 11, 2024

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak this is ready again.
#103288 will need to be merged first before this one.
kunalspathak
kunalspathak
suggested changes
Jun 11, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some left over code that I don't think is needed. Also we should generalize the test template.
Comment threadsrc/coreclr/jit/fgdiagnostic.cpp
Outdated

Comment threadsrc/coreclr/jit/gentree.cpp
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/lsraarm64.cpp
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated


This was referenced Jun 12, 2024

Closed


Open

kunalspathak
kunalspathak
approved these changes
Jun 12, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
@TIHan
TIHan
commented
Jun 12, 2024

Copy link


Copy Markdown

ContributorAuthor
Woo!
@TIHan
TIHan
merged commit be2827c
into
dotnet:mainJun 12, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding left review comments

+2 more reviewers

@a74nha74nha74nh left review comments
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-System.Runtime.Intrinsicsarm-sveWork related to arm64 SVE/SVE2 supportnew-api-needs-documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@kunalspathak@a74nh@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
JIT: Added SVE Prefetch* APIs. - #103094
Merged
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Jun 12, 2024
Merged
JIT: Added SVE Prefetch* APIs.#103094
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Conversation
@TIHan
@TIHanTIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Contributes to #99957
Adds:
  • PrefetchBytes
  • PrefetchInt16
  • PrefetchInt32
  • PrefetchInt64
@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

TIHan
TIHan
commented
Jun 5, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@TIHanTIHanJun 5, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalspathak@tannergooding was this enum type approved? I ask because of the SV_PLDL1KEEP names.
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
@a74nha74nhJun 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#97831 approved the Prefetch* APIs.
The enum should have been approved as part of that, but wasn't looked at directly.
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum names are different and were approved in #94007 (comment)
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TIHan - can you update the names accordingly?
@TIHan
TIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib @kunalspathak this is ready. There is no visible output to validate since this instruction is intended to be a hint.
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_0() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_1() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_2() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_3() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_4() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_5() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_6() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_7() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_8() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_9() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_10() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_11() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt16() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt32() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt64() : 3
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
c7b382d to
5c66924CompareJune 5, 2024 21:26
@kunalspathakkunalspathak
added
the 
arm-sve
Work related to arm64 SVE/SVE2 support
label
Jun 5, 2024
@kunalspathakkunalspathak
mentioned this pull request
Jun 5, 2024

Closed

kunalspathak
kunalspathak
suggested changes
Jun 5, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments.
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Outdated

@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
also, need to handle immediate value and table generation logic.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it? also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.

This was referenced Jun 6, 2024

Closed


Closed


Closed


Closed


Closed


Closed


This was referenced Jun 6, 2024

Open


Closed

@a74nh
a74nh
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it?
I'm not sure if there is anything we can test for. We can't read the setting back from the system.
also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.
We can't pass 6 or 7 as an immediate as C# compile will fail. So this only applies where it's in a variable, and we generate the lookup table.
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run. So, I don't think we should do anything special, and keep this patch as is.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
So this only applies where it's in a variable
Yes, i think the question was more towards variable and how we should handle it in table generation logic. It wasn't clear what translates to the prfop , if it was 6/7.
image
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run.
Thanks for confirming this.
kunalspathak
kunalspathak
reviewed
Jun 6, 2024
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

@TIHan
TIHan
commented
Jun 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
@a74nh
a74nh
commented
Jun 7, 2024

Copy link


Copy Markdown

Contributor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
Depends how you define valid :)

They don't do anything when used but they shouldn't cause an error. I think the code in #98468 is ok as it is.
TIHan
TIHan
commented
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 11, 2024

Closed

tannergooding
tannergooding
reviewed
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/rationalize.cpp
Outdated

@tannergoodingtannergooding
mentioned this pull request
Jun 11, 2024
 Merged

@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
a5d2203 to
086ebd3CompareJune 11, 2024 18:18
@TIHan
TIHan
commented
Jun 11, 2024

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak this is ready again.
#103288 will need to be merged first before this one.
kunalspathak
kunalspathak
suggested changes
Jun 11, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some left over code that I don't think is needed. Also we should generalize the test template.
Comment threadsrc/coreclr/jit/fgdiagnostic.cpp
Outdated

Comment threadsrc/coreclr/jit/gentree.cpp
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/lsraarm64.cpp
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated


This was referenced Jun 12, 2024

Closed


Open

kunalspathak
kunalspathak
approved these changes
Jun 12, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
@TIHan
TIHan
commented
Jun 12, 2024

Copy link


Copy Markdown

ContributorAuthor
Woo!
@TIHan
TIHan
merged commit be2827c
into
dotnet:mainJun 12, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding left review comments

+2 more reviewers

@a74nha74nha74nh left review comments
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-System.Runtime.Intrinsicsarm-sveWork related to arm64 SVE/SVE2 supportnew-api-needs-documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@kunalspathak@a74nh@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
JIT: Added SVE Prefetch* APIs. - #103094
Merged
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Jun 12, 2024
Merged
JIT: Added SVE Prefetch* APIs.#103094
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Conversation
@TIHan
@TIHanTIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Contributes to #99957
Adds:
  • PrefetchBytes
  • PrefetchInt16
  • PrefetchInt32
  • PrefetchInt64
@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

TIHan
TIHan
commented
Jun 5, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@TIHanTIHanJun 5, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalspathak@tannergooding was this enum type approved? I ask because of the SV_PLDL1KEEP names.
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
@a74nha74nhJun 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#97831 approved the Prefetch* APIs.
The enum should have been approved as part of that, but wasn't looked at directly.
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum names are different and were approved in #94007 (comment)
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TIHan - can you update the names accordingly?
@TIHan
TIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib @kunalspathak this is ready. There is no visible output to validate since this instruction is intended to be a hint.
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_0() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_1() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_2() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_3() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_4() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_5() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_6() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_7() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_8() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_9() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_10() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_11() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt16() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt32() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt64() : 3
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
c7b382d to
5c66924CompareJune 5, 2024 21:26
@kunalspathakkunalspathak
added
the 
arm-sve
Work related to arm64 SVE/SVE2 support
label
Jun 5, 2024
@kunalspathakkunalspathak
mentioned this pull request
Jun 5, 2024

Closed

kunalspathak
kunalspathak
suggested changes
Jun 5, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments.
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Outdated

@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
also, need to handle immediate value and table generation logic.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it? also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.

This was referenced Jun 6, 2024

Closed


Closed


Closed


Closed


Closed


Closed


This was referenced Jun 6, 2024

Open


Closed

@a74nh
a74nh
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it?
I'm not sure if there is anything we can test for. We can't read the setting back from the system.
also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.
We can't pass 6 or 7 as an immediate as C# compile will fail. So this only applies where it's in a variable, and we generate the lookup table.
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run. So, I don't think we should do anything special, and keep this patch as is.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
So this only applies where it's in a variable
Yes, i think the question was more towards variable and how we should handle it in table generation logic. It wasn't clear what translates to the prfop , if it was 6/7.
image
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run.
Thanks for confirming this.
kunalspathak
kunalspathak
reviewed
Jun 6, 2024
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

@TIHan
TIHan
commented
Jun 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
@a74nh
a74nh
commented
Jun 7, 2024

Copy link


Copy Markdown

Contributor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
Depends how you define valid :)

They don't do anything when used but they shouldn't cause an error. I think the code in #98468 is ok as it is.
TIHan
TIHan
commented
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 11, 2024

Closed

tannergooding
tannergooding
reviewed
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/rationalize.cpp
Outdated

@tannergoodingtannergooding
mentioned this pull request
Jun 11, 2024
 Merged

@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
a5d2203 to
086ebd3CompareJune 11, 2024 18:18
@TIHan
TIHan
commented
Jun 11, 2024

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak this is ready again.
#103288 will need to be merged first before this one.
kunalspathak
kunalspathak
suggested changes
Jun 11, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some left over code that I don't think is needed. Also we should generalize the test template.
Comment threadsrc/coreclr/jit/fgdiagnostic.cpp
Outdated

Comment threadsrc/coreclr/jit/gentree.cpp
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/lsraarm64.cpp
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated


This was referenced Jun 12, 2024

Closed


Open

kunalspathak
kunalspathak
approved these changes
Jun 12, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
@TIHan
TIHan
commented
Jun 12, 2024

Copy link


Copy Markdown

ContributorAuthor
Woo!
@TIHan
TIHan
merged commit be2827c
into
dotnet:mainJun 12, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding left review comments

+2 more reviewers

@a74nha74nha74nh left review comments
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-System.Runtime.Intrinsicsarm-sveWork related to arm64 SVE/SVE2 supportnew-api-needs-documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@kunalspathak@a74nh@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
JIT: Added SVE Prefetch* APIs. - #103094
Merged
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Jun 12, 2024
Merged
JIT: Added SVE Prefetch* APIs.#103094
TIHan merged 20 commits into
dotnet:mainfrom 
TIHan:sve-prefect-apis
Conversation
@TIHan
@TIHanTIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Contributes to #99957
Adds:
  • PrefetchBytes
  • PrefetchInt16
  • PrefetchInt32
  • PrefetchInt64
@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
ghost
commented
Jun 5, 2024

Copy link


Copy Markdown

Note regarding the new-api-needs-documentation label:
This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

TIHan
TIHan
commented
Jun 5, 2024
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@TIHanTIHanJun 5, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalspathak@tannergooding was this enum type approved? I ask because of the SV_PLDL1KEEP names.
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
@a74nha74nhJun 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#97831 approved the Prefetch* APIs.
The enum should have been approved as part of that, but wasn't looked at directly.
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum names are different and were approved in #94007 (comment)
@kunalspathakkunalspathakJun 7, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TIHan - can you update the names accordingly?
@TIHan
TIHan
commented
Jun 5, 2024

Copy link


Copy Markdown

ContributorAuthor
@dotnet/arm64-contrib @kunalspathak this is ready. There is no visible output to validate since this instruction is intended to be a hint.
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_0() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_1() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_2() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_3() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_4() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_5() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_6() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_7() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_8() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_9() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_10() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchBytes_11() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt16() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt32() : 3
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_PrefetchInt64() : 3
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 5, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics

See info in area-owners.md if you want to be subscribed.
@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
c7b382d to
5c66924CompareJune 5, 2024 21:26
@kunalspathakkunalspathak
added
the 
arm-sve
Work related to arm64 SVE/SVE2 support
label
Jun 5, 2024
@kunalspathakkunalspathak
mentioned this pull request
Jun 5, 2024

Closed

kunalspathak
kunalspathak
suggested changes
Jun 5, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments.
Comment threadsrc/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
 All = 31 // All available (implicitly a multiple of two).
 };

 public enum SvePrefetchType : byte
@kunalspathakkunalspathakJun 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a note here about they not approved? @tannergooding can you confirm?
#94006 (comment)
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

Comment threadsrc/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Outdated

@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
also, need to handle immediate value and table generation logic.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it? also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.

This was referenced Jun 6, 2024

Closed


Closed


Closed


Closed


Closed


Closed


This was referenced Jun 6, 2024

Open


Closed

@a74nh
a74nh
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
@a74nh - so for this API, there is no visual side effect, so wondering how do we test it?
I'm not sure if there is anything we can test for. We can't read the setting back from the system.
also, values 6 and 7 seems invalid(?) but we are not sure how to validate it.
We can't pass 6 or 7 as an immediate as C# compile will fail. So this only applies where it's in a variable, and we generate the lookup table.
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run. So, I don't think we should do anything special, and keep this patch as is.
@kunalspathak
kunalspathak
commented
Jun 6, 2024

Copy link


Copy Markdown

Contributor
So this only applies where it's in a variable
Yes, i think the question was more towards variable and how we should handle it in table generation logic. It wasn't clear what translates to the prfop , if it was 6/7.
image
Testing this in C++ asm, prfw with 6 or 7 doesn't cause an error when run.
Thanks for confirming this.
kunalspathak
kunalspathak
reviewed
Jun 6, 2024
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated

@TIHan
TIHan
commented
Jun 6, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
@a74nh
a74nh
commented
Jun 7, 2024

Copy link


Copy Markdown

Contributor
@a74nh Are 6, 7, 14 and 15 valid constants? In the hwintrinsic codegen sve tests, I do test those constants and they will be decoded as you expect.
See the original PR: #98468
Depends how you define valid :)

They don't do anything when used but they shouldn't cause an error. I think the code in #98468 is ok as it is.
TIHan
TIHan
commented
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsiccodegenarm64.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 11, 2024

Closed

tannergooding
tannergooding
reviewed
Jun 11, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/rationalize.cpp
Outdated

@tannergoodingtannergooding
mentioned this pull request
Jun 11, 2024
 Merged

@TIHan
TIHanforce-pushed
the
sve-prefect-apis
branch
from
a5d2203 to
086ebd3CompareJune 11, 2024 18:18
@TIHan
TIHan
commented
Jun 11, 2024

Copy link


Copy Markdown

ContributorAuthor
@kunalspathak this is ready again.
#103288 will need to be merged first before this one.
kunalspathak
kunalspathak
suggested changes
Jun 11, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some left over code that I don't think is needed. Also we should generalize the test template.
Comment threadsrc/coreclr/jit/fgdiagnostic.cpp
Outdated

Comment threadsrc/coreclr/jit/gentree.cpp
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/hwintrinsiclistarm64sve.h
Outdated

Comment threadsrc/coreclr/jit/lsraarm64.cpp
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/Shared/SvePrefetchTest.template
Outdated


This was referenced Jun 12, 2024

Closed


Open

kunalspathak
kunalspathak
approved these changes
Jun 12, 2024
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
@TIHan
TIHan
commented
Jun 12, 2024

Copy link


Copy Markdown

ContributorAuthor
Woo!
@TIHan
TIHan
merged commit be2827c
into
dotnet:mainJun 12, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding left review comments

+2 more reviewers

@a74nha74nha74nh left review comments
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-System.Runtime.Intrinsicsarm-sveWork related to arm64 SVE/SVE2 supportnew-api-needs-documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@TIHan@kunalspathak@a74nh@tannergooding