Handle more than 64 registers - Part 5 by kunalspathak · Pull Request #103188 · dotnet/runtime

kunalspathak · 2024-06-08T02:24:21Z

Convert all the RBM_REG* to regMaskTP
Introduce SRBM_REG* that can be used at places where we just need SingleTypeRegSet
Start using regMaskTP for registers at kill RefPosition

dotnet-policy-service · 2024-06-08T02:24:58Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This reverts commit b68f2d3.

kunalspathak · 2024-06-10T15:48:26Z

@dotnet/jit-contrib @jakobbotsch PTAL

jakobbotsch · 2024-06-10T17:37:48Z

 // passed in is preserved by the validator and take care to get the
 // target from the register for the call (even in debug mode).
- static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & (1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) == 0);
+ static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & regMaskTP(1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) ==


We can make IsRegNumInMaskconstexpr to make this a bit more natural (feel free to do as part of a follow-up).

I tried doing that, but as a cascade effect I need to make genSingleTypeRegSet, getRegForType(), etc. as constexpr which I am not sure is worth doing for just an assert. Will pass this on for now.

jakobbotsch · 2024-06-10T17:39:23Z

+ hasPC = (imm & SRBM_PC) != 0;
+ hasLR = (imm & SRBM_LR) != 0;
+ imm &= ~(SRBM_PC | SRBM_LR);


I guess this means there is (and was) an invariant on the exact indices defined for these registers?

jakobbotsch · 2024-06-10T17:53:47Z

+ static constexpr regMaskTP CreateFromRegNum(regNumber reg, regMaskSmall mask)
+ {


Is mask needed as a parameter? Can't we compute it here as 1 << reg?

predicate registers starts from 64 thru 80 and the mask of them start with 0x0. I can make it work, but just want to rely on the mask that we already have in register files and how we use them currently.

For predicate registers it would just be (1 << (reg - 64)) under the if, I suppose.

Sure, I don't have much preference on which way or the other, but will keep this in mind during follow up.

jakobbotsch

Nice, this looks great to me. Most changes look mechanical.

kunalspathak · 2024-06-11T03:59:06Z

/rerun

kunalspathak · 2024-06-11T04:21:14Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-11T17:11:13Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-08T02:24:21Z

Convert all the RBM_REG* to regMaskTP
Introduce SRBM_REG* that can be used at places where we just need SingleTypeRegSet
Start using regMaskTP for registers at kill RefPosition

dotnet-policy-service · 2024-06-08T02:24:58Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This reverts commit b68f2d3.

kunalspathak · 2024-06-10T15:48:26Z

@dotnet/jit-contrib @jakobbotsch PTAL

jakobbotsch · 2024-06-10T17:37:48Z

 // passed in is preserved by the validator and take care to get the
 // target from the register for the call (even in debug mode).
- static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & (1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) == 0);
+ static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & regMaskTP(1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) ==


We can make IsRegNumInMaskconstexpr to make this a bit more natural (feel free to do as part of a follow-up).

I tried doing that, but as a cascade effect I need to make genSingleTypeRegSet, getRegForType(), etc. as constexpr which I am not sure is worth doing for just an assert. Will pass this on for now.

jakobbotsch · 2024-06-10T17:39:23Z

+ hasPC = (imm & SRBM_PC) != 0;
+ hasLR = (imm & SRBM_LR) != 0;
+ imm &= ~(SRBM_PC | SRBM_LR);


I guess this means there is (and was) an invariant on the exact indices defined for these registers?

jakobbotsch · 2024-06-10T17:53:47Z

+ static constexpr regMaskTP CreateFromRegNum(regNumber reg, regMaskSmall mask)
+ {


Is mask needed as a parameter? Can't we compute it here as 1 << reg?

predicate registers starts from 64 thru 80 and the mask of them start with 0x0. I can make it work, but just want to rely on the mask that we already have in register files and how we use them currently.

For predicate registers it would just be (1 << (reg - 64)) under the if, I suppose.

Sure, I don't have much preference on which way or the other, but will keep this in mind during follow up.

jakobbotsch

Nice, this looks great to me. Most changes look mechanical.

kunalspathak · 2024-06-11T03:59:06Z

/rerun

kunalspathak · 2024-06-11T04:21:14Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-11T17:11:13Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-08T02:24:21Z

Convert all the RBM_REG* to regMaskTP
Introduce SRBM_REG* that can be used at places where we just need SingleTypeRegSet
Start using regMaskTP for registers at kill RefPosition

dotnet-policy-service · 2024-06-08T02:24:58Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This reverts commit b68f2d3.

kunalspathak · 2024-06-10T15:48:26Z

@dotnet/jit-contrib @jakobbotsch PTAL

jakobbotsch · 2024-06-10T17:37:48Z

 // passed in is preserved by the validator and take care to get the
 // target from the register for the call (even in debug mode).
- static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & (1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) == 0);
+ static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & regMaskTP(1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) ==


We can make IsRegNumInMaskconstexpr to make this a bit more natural (feel free to do as part of a follow-up).

I tried doing that, but as a cascade effect I need to make genSingleTypeRegSet, getRegForType(), etc. as constexpr which I am not sure is worth doing for just an assert. Will pass this on for now.

jakobbotsch · 2024-06-10T17:39:23Z

+ hasPC = (imm & SRBM_PC) != 0;
+ hasLR = (imm & SRBM_LR) != 0;
+ imm &= ~(SRBM_PC | SRBM_LR);


I guess this means there is (and was) an invariant on the exact indices defined for these registers?

jakobbotsch · 2024-06-10T17:53:47Z

+ static constexpr regMaskTP CreateFromRegNum(regNumber reg, regMaskSmall mask)
+ {


Is mask needed as a parameter? Can't we compute it here as 1 << reg?

predicate registers starts from 64 thru 80 and the mask of them start with 0x0. I can make it work, but just want to rely on the mask that we already have in register files and how we use them currently.

For predicate registers it would just be (1 << (reg - 64)) under the if, I suppose.

Sure, I don't have much preference on which way or the other, but will keep this in mind during follow up.

jakobbotsch

Nice, this looks great to me. Most changes look mechanical.

kunalspathak · 2024-06-11T03:59:06Z

/rerun

kunalspathak · 2024-06-11T04:21:14Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-11T17:11:13Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-08T02:24:21Z

Convert all the RBM_REG* to regMaskTP
Introduce SRBM_REG* that can be used at places where we just need SingleTypeRegSet
Start using regMaskTP for registers at kill RefPosition

dotnet-policy-service · 2024-06-08T02:24:58Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This reverts commit b68f2d3.

kunalspathak · 2024-06-10T15:48:26Z

@dotnet/jit-contrib @jakobbotsch PTAL

jakobbotsch · 2024-06-10T17:37:48Z

 // passed in is preserved by the validator and take care to get the
 // target from the register for the call (even in debug mode).
- static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & (1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) == 0);
+ static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & regMaskTP(1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) ==


We can make IsRegNumInMaskconstexpr to make this a bit more natural (feel free to do as part of a follow-up).

I tried doing that, but as a cascade effect I need to make genSingleTypeRegSet, getRegForType(), etc. as constexpr which I am not sure is worth doing for just an assert. Will pass this on for now.

jakobbotsch · 2024-06-10T17:39:23Z

+ hasPC = (imm & SRBM_PC) != 0;
+ hasLR = (imm & SRBM_LR) != 0;
+ imm &= ~(SRBM_PC | SRBM_LR);


I guess this means there is (and was) an invariant on the exact indices defined for these registers?

jakobbotsch · 2024-06-10T17:53:47Z

+ static constexpr regMaskTP CreateFromRegNum(regNumber reg, regMaskSmall mask)
+ {


Is mask needed as a parameter? Can't we compute it here as 1 << reg?

predicate registers starts from 64 thru 80 and the mask of them start with 0x0. I can make it work, but just want to rely on the mask that we already have in register files and how we use them currently.

For predicate registers it would just be (1 << (reg - 64)) under the if, I suppose.

Sure, I don't have much preference on which way or the other, but will keep this in mind during follow up.

jakobbotsch

Nice, this looks great to me. Most changes look mechanical.

kunalspathak · 2024-06-11T03:59:06Z

/rerun

kunalspathak · 2024-06-11T04:21:14Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-11T17:11:13Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-08T02:24:21Z

Convert all the RBM_REG* to regMaskTP
Introduce SRBM_REG* that can be used at places where we just need SingleTypeRegSet
Start using regMaskTP for registers at kill RefPosition

dotnet-policy-service · 2024-06-08T02:24:58Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This reverts commit b68f2d3.

kunalspathak · 2024-06-10T15:48:26Z

@dotnet/jit-contrib @jakobbotsch PTAL

jakobbotsch · 2024-06-10T17:37:48Z

 // passed in is preserved by the validator and take care to get the
 // target from the register for the call (even in debug mode).
- static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & (1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) == 0);
+ static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & regMaskTP(1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) ==


We can make IsRegNumInMaskconstexpr to make this a bit more natural (feel free to do as part of a follow-up).

I tried doing that, but as a cascade effect I need to make genSingleTypeRegSet, getRegForType(), etc. as constexpr which I am not sure is worth doing for just an assert. Will pass this on for now.

jakobbotsch · 2024-06-10T17:39:23Z

+ hasPC = (imm & SRBM_PC) != 0;
+ hasLR = (imm & SRBM_LR) != 0;
+ imm &= ~(SRBM_PC | SRBM_LR);


I guess this means there is (and was) an invariant on the exact indices defined for these registers?

jakobbotsch · 2024-06-10T17:53:47Z

+ static constexpr regMaskTP CreateFromRegNum(regNumber reg, regMaskSmall mask)
+ {


Is mask needed as a parameter? Can't we compute it here as 1 << reg?

predicate registers starts from 64 thru 80 and the mask of them start with 0x0. I can make it work, but just want to rely on the mask that we already have in register files and how we use them currently.

For predicate registers it would just be (1 << (reg - 64)) under the if, I suppose.

Sure, I don't have much preference on which way or the other, but will keep this in mind during follow up.

jakobbotsch

Nice, this looks great to me. Most changes look mechanical.

kunalspathak · 2024-06-11T03:59:06Z

/rerun

kunalspathak · 2024-06-11T04:21:14Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-11T17:11:13Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-08T02:24:21Z

Convert all the RBM_REG* to regMaskTP
Introduce SRBM_REG* that can be used at places where we just need SingleTypeRegSet
Start using regMaskTP for registers at kill RefPosition

dotnet-policy-service · 2024-06-08T02:24:58Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This reverts commit b68f2d3.

kunalspathak · 2024-06-10T15:48:26Z

@dotnet/jit-contrib @jakobbotsch PTAL

jakobbotsch · 2024-06-10T17:37:48Z

 // passed in is preserved by the validator and take care to get the
 // target from the register for the call (even in debug mode).
- static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & (1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) == 0);
+ static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & regMaskTP(1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) ==


We can make IsRegNumInMaskconstexpr to make this a bit more natural (feel free to do as part of a follow-up).

I tried doing that, but as a cascade effect I need to make genSingleTypeRegSet, getRegForType(), etc. as constexpr which I am not sure is worth doing for just an assert. Will pass this on for now.

jakobbotsch · 2024-06-10T17:39:23Z

+ hasPC = (imm & SRBM_PC) != 0;
+ hasLR = (imm & SRBM_LR) != 0;
+ imm &= ~(SRBM_PC | SRBM_LR);


I guess this means there is (and was) an invariant on the exact indices defined for these registers?

jakobbotsch · 2024-06-10T17:53:47Z

+ static constexpr regMaskTP CreateFromRegNum(regNumber reg, regMaskSmall mask)
+ {


Is mask needed as a parameter? Can't we compute it here as 1 << reg?

predicate registers starts from 64 thru 80 and the mask of them start with 0x0. I can make it work, but just want to rely on the mask that we already have in register files and how we use them currently.

For predicate registers it would just be (1 << (reg - 64)) under the if, I suppose.

Sure, I don't have much preference on which way or the other, but will keep this in mind during follow up.

jakobbotsch

Nice, this looks great to me. Most changes look mechanical.

kunalspathak · 2024-06-11T03:59:06Z

/rerun

kunalspathak · 2024-06-11T04:21:14Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-11T17:11:13Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-08T02:24:21Z

Convert all the RBM_REG* to regMaskTP
Introduce SRBM_REG* that can be used at places where we just need SingleTypeRegSet
Start using regMaskTP for registers at kill RefPosition

dotnet-policy-service · 2024-06-08T02:24:58Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This reverts commit b68f2d3.

kunalspathak · 2024-06-10T15:48:26Z

@dotnet/jit-contrib @jakobbotsch PTAL

jakobbotsch · 2024-06-10T17:37:48Z

 // passed in is preserved by the validator and take care to get the
 // target from the register for the call (even in debug mode).
- static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & (1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) == 0);
+ static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & regMaskTP(1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) ==


We can make IsRegNumInMaskconstexpr to make this a bit more natural (feel free to do as part of a follow-up).

I tried doing that, but as a cascade effect I need to make genSingleTypeRegSet, getRegForType(), etc. as constexpr which I am not sure is worth doing for just an assert. Will pass this on for now.

jakobbotsch · 2024-06-10T17:39:23Z

+ hasPC = (imm & SRBM_PC) != 0;
+ hasLR = (imm & SRBM_LR) != 0;
+ imm &= ~(SRBM_PC | SRBM_LR);


I guess this means there is (and was) an invariant on the exact indices defined for these registers?

jakobbotsch · 2024-06-10T17:53:47Z

+ static constexpr regMaskTP CreateFromRegNum(regNumber reg, regMaskSmall mask)
+ {


Is mask needed as a parameter? Can't we compute it here as 1 << reg?

predicate registers starts from 64 thru 80 and the mask of them start with 0x0. I can make it work, but just want to rely on the mask that we already have in register files and how we use them currently.

For predicate registers it would just be (1 << (reg - 64)) under the if, I suppose.

Sure, I don't have much preference on which way or the other, but will keep this in mind during follow up.

jakobbotsch

Nice, this looks great to me. Most changes look mechanical.

kunalspathak · 2024-06-11T03:59:06Z

/rerun

kunalspathak · 2024-06-11T04:21:14Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-11T17:11:13Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-08T02:24:21Z

Convert all the RBM_REG* to regMaskTP
Introduce SRBM_REG* that can be used at places where we just need SingleTypeRegSet
Start using regMaskTP for registers at kill RefPosition

dotnet-policy-service · 2024-06-08T02:24:58Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This reverts commit b68f2d3.

kunalspathak · 2024-06-10T15:48:26Z

@dotnet/jit-contrib @jakobbotsch PTAL

jakobbotsch · 2024-06-10T17:37:48Z

 // passed in is preserved by the validator and take care to get the
 // target from the register for the call (even in debug mode).
- static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & (1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) == 0);
+ static_assert_no_msg((RBM_VALIDATE_INDIRECT_CALL_TRASH & regMaskTP(1 << REG_VALIDATE_INDIRECT_CALL_ADDR)) ==


We can make IsRegNumInMaskconstexpr to make this a bit more natural (feel free to do as part of a follow-up).

I tried doing that, but as a cascade effect I need to make genSingleTypeRegSet, getRegForType(), etc. as constexpr which I am not sure is worth doing for just an assert. Will pass this on for now.

jakobbotsch · 2024-06-10T17:39:23Z

+ hasPC = (imm & SRBM_PC) != 0;
+ hasLR = (imm & SRBM_LR) != 0;
+ imm &= ~(SRBM_PC | SRBM_LR);


I guess this means there is (and was) an invariant on the exact indices defined for these registers?

jakobbotsch · 2024-06-10T17:53:47Z

+ static constexpr regMaskTP CreateFromRegNum(regNumber reg, regMaskSmall mask)
+ {


Is mask needed as a parameter? Can't we compute it here as 1 << reg?

predicate registers starts from 64 thru 80 and the mask of them start with 0x0. I can make it work, but just want to rely on the mask that we already have in register files and how we use them currently.

For predicate registers it would just be (1 << (reg - 64)) under the if, I suppose.

Sure, I don't have much preference on which way or the other, but will keep this in mind during follow up.

jakobbotsch

Nice, this looks great to me. Most changes look mechanical.

kunalspathak · 2024-06-11T03:59:06Z

/rerun

kunalspathak · 2024-06-11T04:21:14Z

@dotnet-policy-service rerun

kunalspathak · 2024-06-11T17:11:13Z

@dotnet-policy-service rerun

kunalspathak added 12 commits June 6, 2024 18:38

first cut
4f81f69

make clrjit/clrjit_universal_arm64_x64 working, introduce SRBM_*
c8f9b15

make clrjit_universal_arm_x64 build
e150ec5

make everything else build
f7e759f

fix some static asserts
f887a6d

jit format
c50b029

minor static assert fix
a3bea88

Remove RegMaskTP_NONE
2e2d48c

fix some build errors
bbf7da1

jit format
80b658c

some more fixes
8ee0adc

Use regMaskTP for kill RefPositions
1534499

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2024

dotnet-policy-serviceBot assigned kunalspathak Jun 8, 2024

Merge remote-tracking branch 'origin/main' into part5
73d011b

build-analysisBot mentioned this pull request Jun 8, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

kunalspathak added 5 commits June 8, 2024 19:53

fix a typo
f5ceca1

Fix build errors for riscv64/loongarch64
21e3c2f

try to fix gcc errors
b68f2d3

jit format
7f5a542

Revert "try to fix gcc errors"
3d02d69
This reverts commit b68f2d3.

kunalspathak marked this pull request as ready for review June 10, 2024 15:48

kunalspathak requested a review from jakobbotsch June 10, 2024 15:48

kunalspathak added 2 commits June 10, 2024 09:24

fix gcc build failure
f1b00a6

minor code cleanup
491da62

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

jakobbotsch approved these changes Jun 10, 2024
View reviewed changes

review comments
b64e835

build-analysisBot mentioned this pull request Jun 10, 2024
CI timeout in System.Data.Tests.DataTableReadXmlSchemaTest.XsdSchemaDeserializationIgnoresLocale #103062
Closed

kunalspathak merged commit d06fb08 into dotnet:mainJun 11, 2024

kunalspathak deleted the part5 branch June 11, 2024 17:18

kunalspathak mentioned this pull request Jun 13, 2024
Handle more than 64 registers - The finale #103387
Merged

LuckyXu-HF mentioned this pull request Jun 13, 2024
[LoongArch64] Synchronize with PR#103188 to fix the build error. #103390
Merged

kunalspathak mentioned this pull request Jun 14, 2024
Handle > 64 registers + predicate registers for Arm64 #98258
Closed
17 tasks

github-actionsBot locked and limited conversation to collaborators Jul 12, 2024

kunalspathak added 12 commits June 6, 2024 18:38

first cut
4f81f69

make clrjit/clrjit_universal_arm64_x64 working, introduce SRBM_*
c8f9b15

make clrjit_universal_arm_x64 build
e150ec5

make everything else build
f7e759f

fix some static asserts
f887a6d

jit format
c50b029

minor static assert fix
a3bea88

Remove RegMaskTP_NONE
2e2d48c

fix some build errors
bbf7da1

jit format
80b658c

some more fixes
8ee0adc

Use regMaskTP for kill RefPositions
1534499

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2024

dotnet-policy-serviceBot assigned kunalspathak Jun 8, 2024

Merge remote-tracking branch 'origin/main' into part5
73d011b

build-analysisBot mentioned this pull request Jun 8, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

kunalspathak added 5 commits June 8, 2024 19:53

fix a typo
f5ceca1

Fix build errors for riscv64/loongarch64
21e3c2f

try to fix gcc errors
b68f2d3

jit format
7f5a542

Revert "try to fix gcc errors"
3d02d69
This reverts commit b68f2d3.

kunalspathak marked this pull request as ready for review June 10, 2024 15:48

kunalspathak requested a review from jakobbotsch June 10, 2024 15:48

kunalspathak added 2 commits June 10, 2024 09:24

fix gcc build failure
f1b00a6

minor code cleanup
491da62

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

jakobbotsch approved these changes Jun 10, 2024
View reviewed changes

review comments
b64e835

build-analysisBot mentioned this pull request Jun 10, 2024
CI timeout in System.Data.Tests.DataTableReadXmlSchemaTest.XsdSchemaDeserializationIgnoresLocale #103062
Closed

kunalspathak merged commit d06fb08 into dotnet:mainJun 11, 2024

kunalspathak deleted the part5 branch June 11, 2024 17:18

kunalspathak mentioned this pull request Jun 13, 2024
Handle more than 64 registers - The finale #103387
Merged

LuckyXu-HF mentioned this pull request Jun 13, 2024
[LoongArch64] Synchronize with PR#103188 to fix the build error. #103390
Merged

kunalspathak mentioned this pull request Jun 14, 2024
Handle > 64 registers + predicate registers for Arm64 #98258
Closed
17 tasks

github-actionsBot locked and limited conversation to collaborators Jul 12, 2024

kunalspathak added 12 commits June 6, 2024 18:38

first cut
4f81f69

make clrjit/clrjit_universal_arm64_x64 working, introduce SRBM_*
c8f9b15

make clrjit_universal_arm_x64 build
e150ec5

make everything else build
f7e759f

fix some static asserts
f887a6d

jit format
c50b029

minor static assert fix
a3bea88

Remove RegMaskTP_NONE
2e2d48c

fix some build errors
bbf7da1

jit format
80b658c

some more fixes
8ee0adc

Use regMaskTP for kill RefPositions
1534499

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2024

dotnet-policy-serviceBot assigned kunalspathak Jun 8, 2024

Merge remote-tracking branch 'origin/main' into part5
73d011b

build-analysisBot mentioned this pull request Jun 8, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

kunalspathak added 5 commits June 8, 2024 19:53

fix a typo
f5ceca1

Fix build errors for riscv64/loongarch64
21e3c2f

try to fix gcc errors
b68f2d3

jit format
7f5a542

Revert "try to fix gcc errors"
3d02d69
This reverts commit b68f2d3.

kunalspathak marked this pull request as ready for review June 10, 2024 15:48

kunalspathak requested a review from jakobbotsch June 10, 2024 15:48

kunalspathak added 2 commits June 10, 2024 09:24

fix gcc build failure
f1b00a6

minor code cleanup
491da62

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

jakobbotsch approved these changes Jun 10, 2024
View reviewed changes

review comments
b64e835

build-analysisBot mentioned this pull request Jun 10, 2024
CI timeout in System.Data.Tests.DataTableReadXmlSchemaTest.XsdSchemaDeserializationIgnoresLocale #103062
Closed

kunalspathak merged commit d06fb08 into dotnet:mainJun 11, 2024

kunalspathak deleted the part5 branch June 11, 2024 17:18

kunalspathak mentioned this pull request Jun 13, 2024
Handle more than 64 registers - The finale #103387
Merged

LuckyXu-HF mentioned this pull request Jun 13, 2024
[LoongArch64] Synchronize with PR#103188 to fix the build error. #103390
Merged

kunalspathak mentioned this pull request Jun 14, 2024
Handle > 64 registers + predicate registers for Arm64 #98258
Closed
17 tasks

github-actionsBot locked and limited conversation to collaborators Jul 12, 2024

kunalspathak added 12 commits June 6, 2024 18:38

first cut
4f81f69

make clrjit/clrjit_universal_arm64_x64 working, introduce SRBM_*
c8f9b15

make clrjit_universal_arm_x64 build
e150ec5

make everything else build
f7e759f

fix some static asserts
f887a6d

jit format
c50b029

minor static assert fix
a3bea88

Remove RegMaskTP_NONE
2e2d48c

fix some build errors
bbf7da1

jit format
80b658c

some more fixes
8ee0adc

Use regMaskTP for kill RefPositions
1534499

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2024

dotnet-policy-serviceBot assigned kunalspathak Jun 8, 2024

Merge remote-tracking branch 'origin/main' into part5
73d011b

build-analysisBot mentioned this pull request Jun 8, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

kunalspathak added 5 commits June 8, 2024 19:53

fix a typo
f5ceca1

Fix build errors for riscv64/loongarch64
21e3c2f

try to fix gcc errors
b68f2d3

jit format
7f5a542

Revert "try to fix gcc errors"
3d02d69
This reverts commit b68f2d3.

kunalspathak marked this pull request as ready for review June 10, 2024 15:48

kunalspathak requested a review from jakobbotsch June 10, 2024 15:48

kunalspathak added 2 commits June 10, 2024 09:24

fix gcc build failure
f1b00a6

minor code cleanup
491da62

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

jakobbotsch approved these changes Jun 10, 2024
View reviewed changes

review comments
b64e835

build-analysisBot mentioned this pull request Jun 10, 2024
CI timeout in System.Data.Tests.DataTableReadXmlSchemaTest.XsdSchemaDeserializationIgnoresLocale #103062
Closed

kunalspathak merged commit d06fb08 into dotnet:mainJun 11, 2024

kunalspathak deleted the part5 branch June 11, 2024 17:18

kunalspathak mentioned this pull request Jun 13, 2024
Handle more than 64 registers - The finale #103387
Merged

LuckyXu-HF mentioned this pull request Jun 13, 2024
[LoongArch64] Synchronize with PR#103188 to fix the build error. #103390
Merged

kunalspathak mentioned this pull request Jun 14, 2024
Handle > 64 registers + predicate registers for Arm64 #98258
Closed
17 tasks

github-actionsBot locked and limited conversation to collaborators Jul 12, 2024

kunalspathak added 12 commits June 6, 2024 18:38

first cut
4f81f69

make clrjit/clrjit_universal_arm64_x64 working, introduce SRBM_*
c8f9b15

make clrjit_universal_arm_x64 build
e150ec5

make everything else build
f7e759f

fix some static asserts
f887a6d

jit format
c50b029

minor static assert fix
a3bea88

Remove RegMaskTP_NONE
2e2d48c

fix some build errors
bbf7da1

jit format
80b658c

some more fixes
8ee0adc

Use regMaskTP for kill RefPositions
1534499

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2024

dotnet-policy-serviceBot assigned kunalspathak Jun 8, 2024

Merge remote-tracking branch 'origin/main' into part5
73d011b

build-analysisBot mentioned this pull request Jun 8, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

kunalspathak added 5 commits June 8, 2024 19:53

fix a typo
f5ceca1

Fix build errors for riscv64/loongarch64
21e3c2f

try to fix gcc errors
b68f2d3

jit format
7f5a542

Revert "try to fix gcc errors"
3d02d69
This reverts commit b68f2d3.

kunalspathak marked this pull request as ready for review June 10, 2024 15:48

kunalspathak requested a review from jakobbotsch June 10, 2024 15:48

kunalspathak added 2 commits June 10, 2024 09:24

fix gcc build failure
f1b00a6

minor code cleanup
491da62

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

jakobbotsch approved these changes Jun 10, 2024
View reviewed changes

review comments
b64e835

build-analysisBot mentioned this pull request Jun 10, 2024
CI timeout in System.Data.Tests.DataTableReadXmlSchemaTest.XsdSchemaDeserializationIgnoresLocale #103062
Closed

kunalspathak merged commit d06fb08 into dotnet:mainJun 11, 2024

kunalspathak deleted the part5 branch June 11, 2024 17:18

kunalspathak mentioned this pull request Jun 13, 2024
Handle more than 64 registers - The finale #103387
Merged

LuckyXu-HF mentioned this pull request Jun 13, 2024
[LoongArch64] Synchronize with PR#103188 to fix the build error. #103390
Merged

kunalspathak mentioned this pull request Jun 14, 2024
Handle > 64 registers + predicate registers for Arm64 #98258
Closed
17 tasks

github-actionsBot locked and limited conversation to collaborators Jul 12, 2024

kunalspathak added 12 commits June 6, 2024 18:38

first cut
4f81f69

make clrjit/clrjit_universal_arm64_x64 working, introduce SRBM_*
c8f9b15

make clrjit_universal_arm_x64 build
e150ec5

make everything else build
f7e759f

fix some static asserts
f887a6d

jit format
c50b029

minor static assert fix
a3bea88

Remove RegMaskTP_NONE
2e2d48c

fix some build errors
bbf7da1

jit format
80b658c

some more fixes
8ee0adc

Use regMaskTP for kill RefPositions
1534499

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2024

dotnet-policy-serviceBot assigned kunalspathak Jun 8, 2024

Merge remote-tracking branch 'origin/main' into part5
73d011b

build-analysisBot mentioned this pull request Jun 8, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

kunalspathak added 5 commits June 8, 2024 19:53

fix a typo
f5ceca1

Fix build errors for riscv64/loongarch64
21e3c2f

try to fix gcc errors
b68f2d3

jit format
7f5a542

Revert "try to fix gcc errors"
3d02d69
This reverts commit b68f2d3.

kunalspathak marked this pull request as ready for review June 10, 2024 15:48

kunalspathak requested a review from jakobbotsch June 10, 2024 15:48

kunalspathak added 2 commits June 10, 2024 09:24

fix gcc build failure
f1b00a6

minor code cleanup
491da62

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

jakobbotsch approved these changes Jun 10, 2024
View reviewed changes

review comments
b64e835

build-analysisBot mentioned this pull request Jun 10, 2024
CI timeout in System.Data.Tests.DataTableReadXmlSchemaTest.XsdSchemaDeserializationIgnoresLocale #103062
Closed

kunalspathak merged commit d06fb08 into dotnet:mainJun 11, 2024

kunalspathak deleted the part5 branch June 11, 2024 17:18

kunalspathak mentioned this pull request Jun 13, 2024
Handle more than 64 registers - The finale #103387
Merged

LuckyXu-HF mentioned this pull request Jun 13, 2024
[LoongArch64] Synchronize with PR#103188 to fix the build error. #103390
Merged

kunalspathak mentioned this pull request Jun 14, 2024
Handle > 64 registers + predicate registers for Arm64 #98258
Closed
17 tasks

github-actionsBot locked and limited conversation to collaborators Jul 12, 2024

kunalspathak added 12 commits June 6, 2024 18:38

first cut
4f81f69

make clrjit/clrjit_universal_arm64_x64 working, introduce SRBM_*
c8f9b15

make clrjit_universal_arm_x64 build
e150ec5

make everything else build
f7e759f

fix some static asserts
f887a6d

jit format
c50b029

minor static assert fix
a3bea88

Remove RegMaskTP_NONE
2e2d48c

fix some build errors
bbf7da1

jit format
80b658c

some more fixes
8ee0adc

Use regMaskTP for kill RefPositions
1534499

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2024

dotnet-policy-serviceBot assigned kunalspathak Jun 8, 2024

Merge remote-tracking branch 'origin/main' into part5
73d011b

build-analysisBot mentioned this pull request Jun 8, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

kunalspathak added 5 commits June 8, 2024 19:53

fix a typo
f5ceca1

Fix build errors for riscv64/loongarch64
21e3c2f

try to fix gcc errors
b68f2d3

jit format
7f5a542

Revert "try to fix gcc errors"
3d02d69
This reverts commit b68f2d3.

kunalspathak marked this pull request as ready for review June 10, 2024 15:48

kunalspathak requested a review from jakobbotsch June 10, 2024 15:48

kunalspathak added 2 commits June 10, 2024 09:24

fix gcc build failure
f1b00a6

minor code cleanup
491da62

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

jakobbotsch approved these changes Jun 10, 2024
View reviewed changes

review comments
b64e835

build-analysisBot mentioned this pull request Jun 10, 2024
CI timeout in System.Data.Tests.DataTableReadXmlSchemaTest.XsdSchemaDeserializationIgnoresLocale #103062
Closed

kunalspathak merged commit d06fb08 into dotnet:mainJun 11, 2024

kunalspathak deleted the part5 branch June 11, 2024 17:18

kunalspathak mentioned this pull request Jun 13, 2024
Handle more than 64 registers - The finale #103387
Merged

LuckyXu-HF mentioned this pull request Jun 13, 2024
[LoongArch64] Synchronize with PR#103188 to fix the build error. #103390
Merged

kunalspathak mentioned this pull request Jun 14, 2024
Handle > 64 registers + predicate registers for Arm64 #98258
Closed
17 tasks

github-actionsBot locked and limited conversation to collaborators Jul 12, 2024

kunalspathak added 12 commits June 6, 2024 18:38

first cut
4f81f69

make clrjit/clrjit_universal_arm64_x64 working, introduce SRBM_*
c8f9b15

make clrjit_universal_arm_x64 build
e150ec5

make everything else build
f7e759f

fix some static asserts
f887a6d

jit format
c50b029

minor static assert fix
a3bea88

Remove RegMaskTP_NONE
2e2d48c

fix some build errors
bbf7da1

jit format
80b658c

some more fixes
8ee0adc

Use regMaskTP for kill RefPositions
1534499

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2024

dotnet-policy-serviceBot assigned kunalspathak Jun 8, 2024

Merge remote-tracking branch 'origin/main' into part5
73d011b

build-analysisBot mentioned this pull request Jun 8, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

kunalspathak added 5 commits June 8, 2024 19:53

fix a typo
f5ceca1

Fix build errors for riscv64/loongarch64
21e3c2f

try to fix gcc errors
b68f2d3

jit format
7f5a542

Revert "try to fix gcc errors"
3d02d69
This reverts commit b68f2d3.

kunalspathak marked this pull request as ready for review June 10, 2024 15:48

kunalspathak requested a review from jakobbotsch June 10, 2024 15:48

kunalspathak added 2 commits June 10, 2024 09:24

fix gcc build failure
f1b00a6

minor code cleanup
491da62

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

Comment threadsrc/coreclr/jit/lsra.h

jakobbotsch reviewed Jun 10, 2024
View reviewed changes

jakobbotsch approved these changes Jun 10, 2024
View reviewed changes

review comments
b64e835

build-analysisBot mentioned this pull request Jun 10, 2024
CI timeout in System.Data.Tests.DataTableReadXmlSchemaTest.XsdSchemaDeserializationIgnoresLocale #103062
Closed

kunalspathak merged commit d06fb08 into dotnet:mainJun 11, 2024

kunalspathak deleted the part5 branch June 11, 2024 17:18

kunalspathak mentioned this pull request Jun 13, 2024
Handle more than 64 registers - The finale #103387
Merged

LuckyXu-HF mentioned this pull request Jun 13, 2024
[LoongArch64] Synchronize with PR#103188 to fix the build error. #103390
Merged

kunalspathak mentioned this pull request Jun 14, 2024
Handle > 64 registers + predicate registers for Arm64 #98258
Closed
17 tasks

github-actionsBot locked and limited conversation to collaborators Jul 12, 2024

		static constexpr regMaskTP CreateFromRegNum(regNumber reg, regMaskSmall mask)
		{

Uh oh!

Conversation

kunalspathak commented Jun 8, 2024

Uh oh!

dotnet-policy-serviceBot commented Jun 8, 2024

Uh oh!

kunalspathak commented Jun 10, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakobbotsch left a comment

Choose a reason for hiding this comment

Uh oh!

kunalspathak commented Jun 11, 2024

Uh oh!

kunalspathak commented Jun 11, 2024

Uh oh!

kunalspathak commented Jun 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kunalspathak commented Jun 8, 2024

Uh oh!

dotnet-policy-serviceBot commented Jun 8, 2024

Uh oh!

kunalspathak commented Jun 10, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakobbotsch left a comment

Choose a reason for hiding this comment

Uh oh!

kunalspathak commented Jun 11, 2024

Uh oh!

kunalspathak commented Jun 11, 2024

Uh oh!

kunalspathak commented Jun 11, 2024

Uh oh!

Reviewers

Assignees